[GitHub] phoenix pull request #214: PHOENIX-3298 Single column primary key may not be...

[lomoree]

Github user lomoree closed the pull request at:

https://github.com/apache/phoenix/pull/214


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] phoenix pull request #214: PHOENIX-3298 Single column primary key may not be...

[lomoree]

Github user lomoree commented on a diff in the pull request:

https://github.com/apache/phoenix/pull/214#discussion_r82305850
  
--- Diff: 
phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java ---
@@ -1453,7 +1453,7 @@ public void testInvalidPrimaryKeyDecl() throws 
Exception {
 }
 }
 }
-
+
--- End diff --

Of course, I will avoid fixing these in the future. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] phoenix pull request #214: PHOENIX-3298 Single column primary key may not be...

[maryannxue]

Github user maryannxue commented on a diff in the pull request:

https://github.com/apache/phoenix/pull/214#discussion_r82285685
  
--- Diff: 
phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java ---
@@ -1453,7 +1453,7 @@ public void testInvalidPrimaryKeyDecl() throws 
Exception {
 }
 }
 }
-
+
--- End diff --

@lomoree It's nice to avoid these trailing spaces, but most of the time, we 
need to avoid such changes in our patch, especially for 'calcite' branch at the 
moment, for it would make future merge to master more difficult.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] phoenix pull request #214: PHOENIX-3298 Single column primary key may not be...

[lomoree]

GitHub user lomoree opened a pull request:

https://github.com/apache/phoenix/pull/214

PHOENIX-3298 Single column primary key may not be null

Note: This patch will not immediately resolve the 
testInvalidPrimaryKeyDecl() test case due to another issue, PHOENIX-3345. 
However, they are independent issues so there's no reason to wait on this.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bloomberg/phoenix nullcolumns

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/phoenix/pull/214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #214


commit 669c000c8bea3230f2e895cefebbd00cf6f7d7c6
Author: ERIC LOMORE 
Date:   2016-09-30T06:19:18Z

PHOENIX-3298 Single column primary key may not be null




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---