[jira] [Commented] (PHOENIX-3393) Use Iterables.removeIf instead of Iterator.remove in HBase filters
[ https://issues.apache.org/jira/browse/PHOENIX-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15594873#comment-15594873 ] Hudson commented on PHOENIX-3393: - FAILURE: Integrated in Jenkins build Phoenix-master #1444 (See [https://builds.apache.org/job/Phoenix-master/1444/]) PHOENIX-3393 Use Iterables.removeIf instead of Iterator.remove in HBase (ankitsinghal59: rev 5c9fb7b68ebeed20e3876579534df4adf21943a4) * (edit) phoenix-core/src/main/java/org/apache/phoenix/filter/ColumnProjectionFilter.java > Use Iterables.removeIf instead of Iterator.remove in HBase filters > -- > > Key: PHOENIX-3393 > URL: https://issues.apache.org/jira/browse/PHOENIX-3393 > Project: Phoenix > Issue Type: Improvement >Reporter: Robert Yokota >Assignee: Robert Yokota >Priority: Minor > Fix For: 4.9.0 > > Attachments: PHOENIX-3393.master.001.patch > > > This is a performance improvement to use Iterables.removeIf in the > filterRowCells method of ColumnProjectionFilter as described here: > https://rayokota.wordpress.com/2016/10/20/tips-on-writing-custom-hbase-filters/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-3393) Use Iterables.removeIf instead of Iterator.remove in HBase filters
[ https://issues.apache.org/jira/browse/PHOENIX-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15594811#comment-15594811 ] Ankit Singhal commented on PHOENIX-3393: LGTM as well. Thanks [~rayokota] for the contribution. Checked code for other areas if above optimization can be applied, but didn't find any code with randomAccessList(like Arraylist) and having significant remove operations. Committed your change to 4.x branches and master. > Use Iterables.removeIf instead of Iterator.remove in HBase filters > -- > > Key: PHOENIX-3393 > URL: https://issues.apache.org/jira/browse/PHOENIX-3393 > Project: Phoenix > Issue Type: Improvement >Reporter: Robert Yokota >Assignee: Robert Yokota >Priority: Minor > Fix For: 4.9.0 > > Attachments: PHOENIX-3393.master.001.patch > > > This is a performance improvement to use Iterables.removeIf in the > filterRowCells method of ColumnProjectionFilter as described here: > https://rayokota.wordpress.com/2016/10/20/tips-on-writing-custom-hbase-filters/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-3393) Use Iterables.removeIf instead of Iterator.remove in HBase filters
[
https://issues.apache.org/jira/browse/PHOENIX-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15594482#comment-15594482
]
Hadoop QA commented on PHOENIX-3393:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12834487/PHOENIX-3393.master.001.patch
against master branch at commit 1e78d3b368b7aa8397224074f691ea2fed340e34.
ATTACHMENT ID: 12834487
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
43 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/631//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/631//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/631//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/631//console
This message is automatically generated.
> Use Iterables.removeIf instead of Iterator.remove in HBase filters
> --
>
> Key: PHOENIX-3393
> URL: https://issues.apache.org/jira/browse/PHOENIX-3393
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Robert Yokota
>Assignee: Robert Yokota
>Priority: Minor
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3393.master.001.patch
>
>
> This is a performance improvement to use Iterables.removeIf in the
> filterRowCells method of ColumnProjectionFilter as described here:
> https://rayokota.wordpress.com/2016/10/20/tips-on-writing-custom-hbase-filters/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PHOENIX-3393) Use Iterables.removeIf instead of Iterator.remove in HBase filters
[ https://issues.apache.org/jira/browse/PHOENIX-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592915#comment-15592915 ] Robert Yokota commented on PHOENIX-3393: Also, as [~tedyu] mentioned, if Phoenix is using Java 8, you can use Collection.removeIf instead > Use Iterables.removeIf instead of Iterator.remove in HBase filters > -- > > Key: PHOENIX-3393 > URL: https://issues.apache.org/jira/browse/PHOENIX-3393 > Project: Phoenix > Issue Type: Improvement >Reporter: Robert Yokota >Assignee: Robert Yokota >Priority: Minor > Attachments: PHOENIX-3393.master.001.patch > > > This is a performance improvement to use Iterables.removeIf in the > filterRowCells method of ColumnProjectionFilter as described here: > https://rayokota.wordpress.com/2016/10/20/tips-on-writing-custom-hbase-filters/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-3393) Use Iterables.removeIf instead of Iterator.remove in HBase filters
[ https://issues.apache.org/jira/browse/PHOENIX-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592709#comment-15592709 ] Robert Yokota commented on PHOENIX-3393: Thanks, I just did the performance comparison for one of our own custom filters as mentioned in the blog. > Use Iterables.removeIf instead of Iterator.remove in HBase filters > -- > > Key: PHOENIX-3393 > URL: https://issues.apache.org/jira/browse/PHOENIX-3393 > Project: Phoenix > Issue Type: Improvement >Reporter: Robert Yokota >Assignee: Robert Yokota >Priority: Minor > Attachments: PHOENIX-3393.master.001.patch > > > This is a performance improvement to use Iterables.removeIf in the > filterRowCells method of ColumnProjectionFilter as described here: > https://rayokota.wordpress.com/2016/10/20/tips-on-writing-custom-hbase-filters/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-3393) Use Iterables.removeIf instead of Iterator.remove in HBase filters
[ https://issues.apache.org/jira/browse/PHOENIX-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592702#comment-15592702 ] James Taylor commented on PHOENIX-3393: --- Thanks for the patch, [~rayokota], and nice blog too. Looks good to me. What do you think, [~an...@apache.org]? If it looks good to you, would you mind committing? Have you done any performance comparisons, Robert? > Use Iterables.removeIf instead of Iterator.remove in HBase filters > -- > > Key: PHOENIX-3393 > URL: https://issues.apache.org/jira/browse/PHOENIX-3393 > Project: Phoenix > Issue Type: Improvement >Reporter: Robert Yokota >Assignee: Robert Yokota >Priority: Minor > Attachments: PHOENIX-3393.master.001.patch > > > This is a performance improvement to use Iterables.removeIf in the > filterRowCells method of ColumnProjectionFilter as described here: > https://rayokota.wordpress.com/2016/10/20/tips-on-writing-custom-hbase-filters/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
