[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155632#comment-16155632 ] James Taylor commented on PHOENIX-4156: --- Yes, let's remove it. I'll remove that feature in a separate JIRA as it was never released. > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch, > PHOENIX-4156_v3.patch, PHOENIX-4156_v4.patch, PHOENIX-4156_v5.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155622#comment-16155622 ] Samarth Jain commented on PHOENIX-4156: --- [~jamestaylor] - looks like the test is still flapping a bit but only for one case: {code} testIndexWriteFailure[MutableIndexFailureIT_transactional=false,localIndex=false,isNamespaceMapped=false,disableIndexOnWriteFailure=false,rebuildIndexOnWriteFailure=false,failRebuildTask=false,throwIndexWriteFailure=null] {code} It looks like in the case when rebuildIndexOnWriteFailure=false, we are replaying mutations by issuing DMLs with SCN: {code} private void replayMutations() throws SQLException { Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES); for (int i = 0; i < exceptions.size(); i++) { CommitException e = exceptions.get(i); long ts = e.getServerTimestamp(); props.setProperty(PhoenixRuntime.REPLAY_AT_ATTRIB, Long.toString(ts)); try (Connection conn = DriverManager.getConnection(getUrl(), props)) { if (i == 0) { updateTable(conn, false); } else if (i == 1) { updateTableAgain(conn, false); } else { fail(); } } } } {code} Considering we are working on disallowing DMLs with SCN, it makes this test case invalid. I guess it also makes the mode rebuildIndexOnWriteFailure=false also not as useful because now clients won't be able to reply the mutations to get the index back in sync. Should we remove this case altogether from this test? > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch, > PHOENIX-4156_v3.patch, PHOENIX-4156_v4.patch, PHOENIX-4156_v5.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154598#comment-16154598 ] Hudson commented on PHOENIX-4156: - FAILURE: Integrated in Jenkins build Phoenix-master #1771 (See [https://builds.apache.org/job/Phoenix-master/1771/]) PHOENIX-4156 Fix flapping MutableIndexFailureIT (samarth: rev 6e9ce8742e73eccb0d7678ae8f09be9e76b9be98) * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataRegionObserver.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch, > PHOENIX-4156_v3.patch, PHOENIX-4156_v4.patch, PHOENIX-4156_v5.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154292#comment-16154292 ] Hadoop QA commented on PHOENIX-4156: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12885450/PHOENIX-4156_v5.patch against master branch at commit 6e9ce8742e73eccb0d7678ae8f09be9e76b9be98. ATTACHMENT ID: 12885450 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1374//console This message is automatically generated. > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch, > PHOENIX-4156_v3.patch, PHOENIX-4156_v4.patch, PHOENIX-4156_v5.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154277#comment-16154277 ] James Taylor commented on PHOENIX-4156: --- +1 > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch, > PHOENIX-4156_v3.patch, PHOENIX-4156_v4.patch, PHOENIX-4156_v5.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154146#comment-16154146 ] James Taylor commented on PHOENIX-4156: --- Your patch never uses DEFAULT_INDEX_REBUILD_TASK_INITIAL_DELAY. I think you have a copy paste error. See my previous comment (where you're using DEFAULT_INDEX_FAILURE_HANDLING_REBUILD_INTERVAL instead of DEFAULT_INDEX_REBUILD_TASK_INITIAL_DELAY. 10 seconds is fine - didn't realize we had a delay before. > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch, > PHOENIX-4156_v3.patch, PHOENIX-4156_v4.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154127#comment-16154127 ] Hadoop QA commented on PHOENIX-4156: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12885415/PHOENIX-4156_v4.patch against master branch at commit 0a3ef6c1b5f2013ce6b3e5158e0417294ab7d92b. ATTACHMENT ID: 12885415 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: +serverProps.put(QueryServices.INDEX_REBUILD_RPC_RETRIES_COUNTER, Long.toString(numRpcRetries)); + serverProps.put(QueryServices.INDEX_FAILURE_HANDLING_REBUILD_OVERLAP_FORWARD_TIME_ATTRIB, Long.toString(forwardOverlapMs)); +serverProps.put(QueryServices.INDEX_REBUILD_TASK_INITIAL_DELAY, Long.toString(Long.MAX_VALUE)); + serverProps.put(QueryServices.INDEX_REBUILD_DISABLE_TIMESTAMP_THRESHOLD, Long.toString(disableTimestampThresholdMs)); +private void checkStateAfterRebuild(Connection conn, String fullIndexName, PIndexState expectedIndexState) throws InterruptedException, SQLException { +executor.scheduleWithFixedDelay(task, initialRebuildTaskDelay, rebuildIndexTimeInterval, TimeUnit.MILLISECONDS); +public static final String INDEX_REBUILD_TASK_INITIAL_DELAY = "phoenix.index.rebuild.task.initial.delay"; {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CaseStatementIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableSnapshotReadsMapReduceIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.PartialIndexRebuilderIT {color:red}-1 core zombie tests{color}. There are 2 zombie test(s): at org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.testRetriesExhaustedFailure(TestAssignmentManager.java:283) at org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.testServerNotYetRunning(TestAssignmentManager.java:269) Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1371//testReport/ Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1371//console This message is automatically generated. > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch, > PHOENIX-4156_v3.patch, PHOENIX-4156_v4.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154099#comment-16154099 ] Samarth Jain commented on PHOENIX-4156: --- I currently have the default value as 10 seconds (which was the previous value too) {code} +public static final long DEFAULT_INDEX_REBUILD_TASK_INITIAL_DELAY = 1; // 10 secs {code} > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch, > PHOENIX-4156_v3.patch, PHOENIX-4156_v4.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153944#comment-16153944 ] James Taylor commented on PHOENIX-4156: --- bq. I wanted to disable the scheduled thread so the test can execute the rebuild task itself and assert the state of indexes. I don't think we can do that by setting the "do not rebuild" index policy on the table. I see. That seems fine then. Why not a default for the delay of 0? bq. when the disableIndexOnWriteFailure=false and rebuildIndexOnFailure=false, we are relying on the users to replay the mutations, right? So in this case the index disable timestamp shouldn't be set? Correct. > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch, > PHOENIX-4156_v3.patch, PHOENIX-4156_v4.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153916#comment-16153916 ] Samarth Jain commented on PHOENIX-4156: --- [~jamestaylor] - I wanted to disable the scheduled thread so the test can execute the rebuild task itself and assert the state of indexes. I don't think we can do that by setting the "do not rebuild" index policy on the table. Also, quick question to confirm if this is correct - when the disableIndexOnWriteFailure=false and rebuildIndexOnFailure=false, we are relying on the users to replay the mutations, right? So in this case the index disable timestamp shouldn't be set? Attaching an updated patch that makes sure we are not calling the rebuild task in the test when rebuildIndexOnFailure=false. > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch, > PHOENIX-4156_v3.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152933#comment-16152933 ] James Taylor commented on PHOENIX-4156: --- Is the new delay only for tests not to run the rebuilder? How about if you disable the rebuilder on the table you don't want to rebuild? Looks like the test is still flapping, though. > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch, > PHOENIX-4156_v3.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152905#comment-16152905 ] Hadoop QA commented on PHOENIX-4156: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12885273/PHOENIX-4156_v3.patch against master branch at commit f03c43bdd2abb18f3a1edbc717340b52b529fb48. ATTACHMENT ID: 12885273 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: +serverProps.put(QueryServices.INDEX_REBUILD_RPC_RETRIES_COUNTER, Long.toString(numRpcRetries)); + serverProps.put(QueryServices.INDEX_FAILURE_HANDLING_REBUILD_OVERLAP_FORWARD_TIME_ATTRIB, Long.toString(forwardOverlapMs)); +serverProps.put(QueryServices.INDEX_REBUILD_TASK_INITIAL_DELAY, Long.toString(Long.MAX_VALUE)); + serverProps.put(QueryServices.INDEX_REBUILD_DISABLE_TIMESTAMP_THRESHOLD, Long.toString(disableTimestampThresholdMs)); +private void checkStateAfterRebuild(Connection conn, String fullIndexName, PIndexState expectedIndexState) throws InterruptedException, SQLException { +executor.scheduleWithFixedDelay(task, initialRebuildTaskDelay, rebuildIndexTimeInterval, TimeUnit.MILLISECONDS); +public static final String INDEX_REBUILD_TASK_INITIAL_DELAY = "phoenix.index.rebuild.task.initial.delay"; {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.PartialIndexRebuilderIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MutableQueryIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.GroupByIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableSnapshotReadsMapReduceIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1367//testReport/ Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1367//console This message is automatically generated. > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch, > PHOENIX-4156_v3.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152753#comment-16152753 ] James Taylor commented on PHOENIX-4156: --- Thanks, [~samarthjain]. Code doesn't agree with comment here. When would the table level property matter if the global config has the rebuilder turned off? {code} PhoenixIndexFailurePolicy.java @@ -87,18 +87,17 @@ public class PhoenixIndexFailurePolicy extends DelegateIndexFailurePolicy { public void setup(Stoppable parent, RegionCoprocessorEnvironment env) { super.setup(parent, env); this.env = env; -rebuildIndexOnFailure = env.getConfiguration().getBoolean(QueryServices.INDEX_FAILURE_HANDLING_REBUILD_ATTRIB, -QueryServicesOptions.DEFAULT_INDEX_FAILURE_HANDLING_REBUILD); HTableDescriptor htd = env.getRegion().getTableDesc(); // If rebuild index is turned off globally, no need to check the table because the background thread // won't be running in this case {code} > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152422#comment-16152422 ] Hadoop QA commented on PHOENIX-4156: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12885211/PHOENIX-4156_v2.patch against master branch at commit f03c43bdd2abb18f3a1edbc717340b52b529fb48. ATTACHMENT ID: 12885211 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: +serverProps.put(QueryServices.INDEX_REBUILD_RPC_RETRIES_COUNTER, Long.toString(numRpcRetries)); + serverProps.put(QueryServices.INDEX_FAILURE_HANDLING_REBUILD_OVERLAP_FORWARD_TIME_ATTRIB, Long.toString(forwardOverlapMs)); +// disable running the index rebuild task because we want to control it's execution ourselves +serverProps.put(QueryServices.INDEX_FAILURE_HANDLING_REBUILD_ATTRIB, Boolean.FALSE.toString()); + serverProps.put(QueryServices.INDEX_REBUILD_DISABLE_TIMESTAMP_THRESHOLD, Long.toString(disableTimestampThresholdMs)); +private void checkStateAfterRebuild(Connection conn, String fullIndexName, PIndexState expectedIndexState) throws InterruptedException, SQLException { +rebuildIndexOnFailure = env.getConfiguration().getBoolean(QueryServices.INDEX_FAILURE_HANDLING_REBUILD_ATTRIB, {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MutableQueryIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.GroupByIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableSnapshotReadsMapReduceIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1366//testReport/ Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1366//console This message is automatically generated. > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
[ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152018#comment-16152018 ] Hadoop QA commented on PHOENIX-4156: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12885168/PHOENIX-4156_v1.patch against master branch at commit f03c43bdd2abb18f3a1edbc717340b52b529fb48. ATTACHMENT ID: 12885168 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+0 tests included{color}. The patch appears to be a documentation, build, or dev patch that doesn't require tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ClientTimeArithmeticQueryIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableSnapshotReadsMapReduceIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1365//testReport/ Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1365//console This message is automatically generated. > Fix flapping MutableIndexFailureIT > -- > > Key: PHOENIX-4156 > URL: https://issues.apache.org/jira/browse/PHOENIX-4156 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4156_v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)