[GitHub] kishoreg edited a comment on issue #3725: Replace partition ranges with partitions

2019-01-18 Thread GitBox 
kishoreg edited a comment on issue #3725: Replace partition ranges with 
partitions
URL: https://github.com/apache/incubator-pinot/pull/3725#issuecomment-455752096
 
 
   Good example. With your change, how can we store partition 1,3,5? 
   
   Sorry, my bad. From your example, it looked like we are converting list of 
range to a single range. 
   
   Converting it to list works. Let’s chat on second part on why this change is 
a must apart from reducing few bytes in metadata. 
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

Re: Requesting a review for updating license & notice information

2019-01-18 Thread Felix Cheung 
Thanks for doing that and sending this note.

I will help check today.




From: Seunghyun Lee 
Sent: Friday, January 18, 2019 3:42 PM
To: dev@pinot.apache.org
Subject: Requesting a review for updating license & notice information

Hi Mentors,

I have recently tracked down all dependencies that we bundle for our
distribution and came up with license, notice files for Pinot project. I
followed Apache Spark's approach since it provides the detailed
documentation on how to build license, notice files.

Can someone look into the following pull request so that we can have some
initial feedbacks before we start to work on the release process?
https://github.com/apache/incubator-pinot/pull/3722

Best,
Seunghyun

[GitHub] kishoreg commented on issue #3725: Replace partition ranges with partitions

2019-01-18 Thread GitBox 
kishoreg commented on issue #3725: Replace partition ranges with partitions
URL: https://github.com/apache/incubator-pinot/pull/3725#issuecomment-455752096
 
 
   Good example. With your change, how can we store partition 1,3,5?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] Jackie-Jiang commented on issue #3725: Replace partition ranges with partitions

2019-01-18 Thread GitBox 
Jackie-Jiang commented on issue #3725: Replace partition ranges with partitions
URL: https://github.com/apache/incubator-pinot/pull/3725#issuecomment-455750311
 
 
   > What’s the benefit of changing this? What happens if minion merges two 
segments with different ranges?
   
   We treat range as single value right now, which is very confusing. When 
minion merges two segments, the partitions will also be merged. For example, 
segment 1 has partition 1 and 3, segment 2 has partition 3 and 5, then merged 
segment will have partition 1, 3 and 5.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] ly923976094 opened a new issue #3726: Multithreading concurrent request query, time increase problem

2019-01-18 Thread GitBox 
ly923976094 opened a new issue #3726: Multithreading concurrent request query, 
time increase problem
URL: https://github.com/apache/incubator-pinot/issues/3726
 
 
   For the same PQL, the time difference between using one thread to query and 
10 threads to query concurrently is quite large. May I ask whether the number 
of concurrent requests is controlled by pinot server or whether the number of 
concurrent requests can be configured
   
   pql:SELECT SUM(psr1_nume), SUM(psr1_deno) FROM 
video_market-video_download_performance_full_day WHERE fdate BETWEEN 
154704960 AND 1547135999000 AND country = 'USA' GROUP BY province, isp TOP 
1000
   
   1 thread:
   timeUsedMs: 623
   
   10 thread:
   timeUsedMs: 1760
   timeUsedMs: 1920
   timeUsedMs: 1964
   timeUsedMs: 1963
   timeUsedMs: 1966
   timeUsedMs: 1868
   timeUsedMs: 1854
   timeUsedMs: 1968
   timeUsedMs: 1874
   timeUsedMs: 1869
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] ly923976094 commented on issue #3717: kafka consume problem

2019-01-18 Thread GitBox 
ly923976094 commented on issue #3717: kafka consume problem
URL: 
https://github.com/apache/incubator-pinot/issues/3717#issuecomment-455742219
 
 
   > Not sure what the reason is that you want to stop consumption. If this is 
a new table and you set it up wrong, you can drop the table and recreate it 
after correcting parameters (topic name, server settings, or any other that you 
are trying to correct).
   > 
   > if this table has been in production for a long time and you want to stop 
consumption, then you can disable the table in helix. it will stop after the 
next consuming segment has completed.
   > 
   > If you can describe your problem some more, there may be other things we 
can do. Are you using LLC or HLC?
   
   I use LLC (kafka0.10.2.1),   this table has been in production for a long 
time and I want to stop consumption, if I disable the table in helix, this 
table is unable to query, there is no way to stop consumption can continue to 
query


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] kishoreg commented on issue #3725: Replace partition ranges with partitions

2019-01-18 Thread GitBox 
kishoreg commented on issue #3725: Replace partition ranges with partitions
URL: https://github.com/apache/incubator-pinot/pull/3725#issuecomment-455738520
 
 
   What’s the benefit of changing this?  What happens if minion merges two 
segments with different ranges?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] Jackie-Jiang commented on issue #3722: Update LICENSE and NOTICE files

2019-01-18 Thread GitBox 
Jackie-Jiang commented on issue #3722: Update LICENSE and NOTICE files
URL: https://github.com/apache/incubator-pinot/pull/3722#issuecomment-455735093
 
 
   Awesome! You make my OCD so satisfied!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] kishoreg opened a new pull request #3723: Remove auto-gen class files that were checked-in

2019-01-18 Thread GitBox 
kishoreg opened a new pull request #3723: Remove auto-gen class files that were 
checked-in
URL: https://github.com/apache/incubator-pinot/pull/3723
 
 
   Removed the auto-generated classes from request.thrift and response.thrift. 
The generated files show up under target/generated-sources/thrift and are 
automatically added to the source folder.  There is one downside with this. We 
need thrift installed to compile and build Pinot code. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] codecov-io commented on issue #3722: Update LICENSE and NOTICE files

2019-01-18 Thread GitBox 
codecov-io commented on issue #3722: Update LICENSE and NOTICE files
URL: https://github.com/apache/incubator-pinot/pull/3722#issuecomment-455726148
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3722?src=pr=h1) 
Report
   > Merging 
[#3722](https://codecov.io/gh/apache/incubator-pinot/pull/3722?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/f09db48ebf4b0bd7a551e8f0c2fd86c1177e4f7a?src=pr=desc)
 will **increase** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/3722/graphs/tree.svg?width=650=4ibza2ugkz=150=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3722?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#3722  +/-   ##
   
   + Coverage 67.18%   67.33%   +0.14% 
 Complexity44  
   
 Files  1027 1027  
 Lines 5083050830  
 Branches   7093 7093  
   
   + Hits  3415034226  +76 
   + Misses1433614275  -61 
   + Partials   2344 2329  -15
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/3722?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3722/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=)
 | `51.64% <0%> (-24.18%)` | `0% <0%> (ø)` | |
   | 
[...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3722/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=)
 | `72.72% <0%> (-5.46%)` | `0% <0%> (ø)` | |
   | 
[...lix/core/realtime/PinotRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3722/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90UmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh)
 | `72.77% <0%> (-2.1%)` | `0% <0%> (ø)` | |
   | 
[...ache/pinot/common/metadata/ZKMetadataProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/3722/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0YWRhdGEvWktNZXRhZGF0YVByb3ZpZGVyLmphdmE=)
 | `68.94% <0%> (-1.25%)` | `0% <0%> (ø)` | |
   | 
[...not/common/metadata/segment/SegmentZKMetadata.java](https://codecov.io/gh/apache/incubator-pinot/pull/3722/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0YWRhdGEvc2VnbWVudC9TZWdtZW50WktNZXRhZGF0YS5qYXZh)
 | `77.98% <0%> (-0.63%)` | `0% <0%> (ø)` | |
   | 
[...regation/function/customobject/QuantileDigest.java](https://codecov.io/gh/apache/incubator-pinot/pull/3722/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9jdXN0b21vYmplY3QvUXVhbnRpbGVEaWdlc3QuamF2YQ==)
 | `57.87% <0%> (-0.45%)` | `0% <0%> (ø)` | |
   | 
[...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3722/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9NVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=)
 | `63.63% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | 
[...a/org/apache/pinot/core/common/DataBlockCache.java](https://codecov.io/gh/apache/incubator-pinot/pull/3722/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YUJsb2NrQ2FjaGUuamF2YQ==)
 | `80.15% <0%> (+0.76%)` | `0% <0%> (ø)` | :arrow_down: |
   | 
[...g/apache/pinot/common/utils/helix/HelixHelper.java](https://codecov.io/gh/apache/incubator-pinot/pull/3722/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvaGVsaXgvSGVsaXhIZWxwZXIuamF2YQ==)
 | `55.35% <0%> (+1.19%)` | `0% <0%> (ø)` | :arrow_down: |
   | 
[.../pinot/core/data/manager/BaseTableDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3722/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvQmFzZVRhYmxlRGF0YU1hbmFnZXIuamF2YQ==)
 | `93.82% <0%> (+1.23%)` | `0% <0%> (ø)` | :arrow_down: |
   | ... and [25 
more](https://codecov.io/gh/apache/incubator-pinot/pull/3722/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3722?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] snleee edited a comment on issue #3722: Update LICENSE and NOTICE files

2019-01-18 Thread GitBox 
snleee edited a comment on issue #3722: Update LICENSE and NOTICE files
URL: https://github.com/apache/incubator-pinot/pull/3722#issuecomment-455721410
 
 
   @felixcheung  @olamy Can you check this when you find the time?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] snleee edited a comment on issue #3722: Update LICENSE and NOTICE files

2019-01-18 Thread GitBox 
snleee edited a comment on issue #3722: Update LICENSE and NOTICE files
URL: https://github.com/apache/incubator-pinot/pull/3722#issuecomment-455720913
 
 
   After removing category X dependency and removing "pinot-perf" from 
distribution package, we are bundling `109` external jar files and `9` js/css 
libraries within the source code. After this pr, anyone who's changing version 
of any library or adding a new library needs to update NOTICE & LICENSE files.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] snleee commented on issue #3722: Update LICENSE and NOTICE files

2019-01-18 Thread GitBox 
snleee commented on issue #3722: Update LICENSE and NOTICE files
URL: https://github.com/apache/incubator-pinot/pull/3722#issuecomment-455720913
 
 
   After removing category X dependency and removing "pinot-perf" from 
distribution package, we are bundling `109` external jar files and `9` js/css 
libraries within source code. After this pr, anyone who's changing version of 
any library or adding a new library needs to update NOTICE & LICENSE files.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] codecov-io edited a comment on issue #3711: Fix SegmentConverter to handle virtual column

2019-01-18 Thread GitBox 
codecov-io edited a comment on issue #3711: Fix SegmentConverter to handle 
virtual column
URL: https://github.com/apache/incubator-pinot/pull/3711#issuecomment-455365326
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3711?src=pr=h1) 
Report
   > Merging 
[#3711](https://codecov.io/gh/apache/incubator-pinot/pull/3711?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/f09db48ebf4b0bd7a551e8f0c2fd86c1177e4f7a?src=pr=desc)
 will **increase** coverage by `0.08%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/3711/graphs/tree.svg?width=650=4ibza2ugkz=150=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3711?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#3711  +/-   ##
   
   + Coverage 67.18%   67.27%   +0.08% 
 Complexity44  
   
 Files  1027 1027  
 Lines 5083050830  
 Branches   7093 7093  
   
   + Hits  3415034194  +44 
   + Misses1433614307  -29 
   + Partials   2344 2329  -15
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/3711?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ot/core/data/readers/PinotSegmentRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUGlub3RTZWdtZW50UmVjb3JkUmVhZGVyLmphdmE=)
 | `92.59% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...r/validation/RealtimeSegmentValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1JlYWx0aW1lU2VnbWVudFZhbGlkYXRpb25NYW5hZ2VyLmphdmE=)
 | `41.26% <0%> (-15.88%)` | `0% <0%> (ø)` | |
   | 
[...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=)
 | `63.73% <0%> (-12.09%)` | `0% <0%> (ø)` | |
   | 
[...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=)
 | `88.88% <0%> (-6.67%)` | `0% <0%> (ø)` | |
   | 
[...e/operator/dociditerators/SortedDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9Tb3J0ZWREb2NJZEl0ZXJhdG9yLmphdmE=)
 | `59.45% <0%> (-5.41%)` | `0% <0%> (ø)` | |
   | 
[...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==)
 | `68.88% <0%> (-4.45%)` | `0% <0%> (ø)` | |
   | 
[...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9NVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=)
 | `60.6% <0%> (-3.04%)` | `0% <0%> (ø)` | |
   | 
[...der/HighLevelConsumerBasedRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL0hpZ2hMZXZlbENvbnN1bWVyQmFzZWRSb3V0aW5nVGFibGVCdWlsZGVyLmphdmE=)
 | `90.9% <0%> (-3.04%)` | `0% <0%> (ø)` | |
   | 
[...lix/core/realtime/PinotRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90UmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh)
 | `73.82% <0%> (-1.05%)` | `0% <0%> (ø)` | |
   | 
[...t/creator/impl/SegmentIndexCreationDriverImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50SW5kZXhDcmVhdGlvbkRyaXZlckltcGwuamF2YQ==)
 | `89.45% <0%> (-0.85%)` | `0% <0%> (ø)` | |
   | ... and [23 
more](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at

[GitHub] snleee opened a new pull request #3722: Update LICENSE and NOTICE files

2019-01-18 Thread GitBox 
snleee opened a new pull request #3722: Update LICENSE and NOTICE files
URL: https://github.com/apache/incubator-pinot/pull/3722
 
 
   Followed Apache Spark's approach for handling LICENSE, NOTICE.
   
https://github.com/apache/spark/commit/f825847c82042a9eee7bd5cfab106310d279fc32
   
   - Checked licenses for all libraries that we bundle
   - Checked licenses for all js/css files that we bundle
   - Removed dependencies of category X libraries (#3718)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] npawar opened a new pull request #3721: Add metric to capture max queries per 10s seen in the last minute

2019-01-18 Thread GitBox 
npawar opened a new pull request #3721: Add metric to capture max queries per 
10s seen in the last minute
URL: https://github.com/apache/incubator-pinot/pull/3721
 
 
   We don't have a very good way of knowing what was the QPS for a table at a 
given time. Currently, whenever we receive a query, we emit a "1" in the 
`QUERIES` BrokerMeter. This doesn't really give us the rate of queries over a 
smaller chunk of time, say QPS. This can be solved in metrics viewing 
applications, by showing average values over a period of time. However, we will 
lose spikes in queries if the chunk of time is even slightly big (say 1 minute).
   Introducing a gauge to capture max qps in the last minute, to give us an 
accurate look into qps received by the broker. Starting with buckets of 10s 
(instead of 1s i.e. queries per 10 sec)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] codecov-io edited a comment on issue #3711: Fix SegmentConverter to handle virtual column

2019-01-18 Thread GitBox 
codecov-io edited a comment on issue #3711: Fix SegmentConverter to handle 
virtual column
URL: https://github.com/apache/incubator-pinot/pull/3711#issuecomment-455365326
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3711?src=pr=h1) 
Report
   > Merging 
[#3711](https://codecov.io/gh/apache/incubator-pinot/pull/3711?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/f09db48ebf4b0bd7a551e8f0c2fd86c1177e4f7a?src=pr=desc)
 will **decrease** coverage by `0.07%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/3711/graphs/tree.svg?width=650=4ibza2ugkz=150=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3711?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#3711  +/-   ##
   
   - Coverage 67.18%   67.11%   -0.08% 
 Complexity44  
   
 Files  1027 1027  
 Lines 5083050831   +1 
 Branches   7093 7093  
   
   - Hits  3415034115  -35 
   - Misses1433614378  +42 
   + Partials   2344 2338   -6
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/3711?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ot/core/data/readers/PinotSegmentRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUGlub3RTZWdtZW50UmVjb3JkUmVhZGVyLmphdmE=)
 | `92.72% <100%> (+0.13%)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=)
 | `30.76% <0%> (-45.06%)` | `0% <0%> (ø)` | |
   | 
[...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh)
 | `43.47% <0%> (-36.24%)` | `0% <0%> (ø)` | |
   | 
[...er/validation/BrokerResourceValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL0Jyb2tlclJlc291cmNlVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==)
 | `42.1% <0%> (-31.58%)` | `0% <0%> (ø)` | |
   | 
[...egation/function/customobject/MinMaxRangePair.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9jdXN0b21vYmplY3QvTWluTWF4UmFuZ2VQYWlyLmphdmE=)
 | `75.86% <0%> (-24.14%)` | `0% <0%> (ø)` | |
   | 
[...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=)
 | `88.88% <0%> (-6.67%)` | `0% <0%> (ø)` | |
   | 
[...e/operator/dociditerators/SortedDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9Tb3J0ZWREb2NJZEl0ZXJhdG9yLmphdmE=)
 | `59.45% <0%> (-5.41%)` | `0% <0%> (ø)` | |
   | 
[...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlbG9jYXRpb24vUmVhbHRpbWVTZWdtZW50UmVsb2NhdG9yLmphdmE=)
 | `69.38% <0%> (-5.11%)` | `0% <0%> (ø)` | |
   | 
[...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9NVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=)
 | `60.6% <0%> (-3.04%)` | `0% <0%> (ø)` | |
   | 
[...e/operator/dociditerators/SVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9TVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=)
 | `65.47% <0%> (-2.39%)` | `0% <0%> (ø)` | |
   | ... and [30 
more](https://codecov.io/gh/apache/incubator-pinot/pull/3711/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at

[GitHub] Jackie-Jiang commented on a change in pull request #3711: Fix SegmentConverter to handle virtual column

2019-01-18 Thread GitBox 
Jackie-Jiang commented on a change in pull request #3711: Fix SegmentConverter 
to handle virtual column
URL: https://github.com/apache/incubator-pinot/pull/3711#discussion_r249208864
 
 

 ##
 File path: 
pinot-core/src/main/java/org/apache/pinot/core/data/readers/PinotSegmentRecordReader.java
 ##
 @@ -72,7 +73,10 @@ public PinotSegmentRecordReader(@Nonnull File indexDir, 
@Nullable Schema schema,
   SegmentMetadata segmentMetadata = _immutableSegment.getSegmentMetadata();
   _numDocs = segmentMetadata.getTotalRawDocs();
   if (schema == null) {
-_schema = segmentMetadata.getSchema();
+// In order not to expose virtual columns to client, schema shouldn't 
be fetched from segmentMetadata;
+// otherwise the original metadata will be modified.
+_schema = new SegmentMetadataImpl(indexDir).getSchema();
+_schema.getAllFieldSpecs().removeIf(fieldSpec -> 
_schema.isVirtualColumn(fieldSpec.getName()));
 
 Review comment:
   You don't need to remove virtual columns here because virtual columns will 
not be added to the segment metadata without explicitly adding them.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] jihaozh merged pull request #3714: [TE] yaml - subscribed detection names in notification yaml

2019-01-18 Thread GitBox 
jihaozh merged pull request #3714: [TE] yaml - subscribed detection names in 
notification yaml
URL: https://github.com/apache/incubator-pinot/pull/3714
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] jihaozh opened a new pull request #3720: [TE] alerter - do not send replay anomalies

2019-01-18 Thread GitBox 
jihaozh opened a new pull request #3720: [TE] alerter - do not send replay 
anomalies
URL: https://github.com/apache/incubator-pinot/pull/3720
 
 
   Don't send an alert if the anomaly is from replay or user report.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] xiaohui-sun commented on a change in pull request #3709: [TE] - Fix true anomaly definition to include expected anomaly

2019-01-18 Thread GitBox 
xiaohui-sun commented on a change in pull request #3709: [TE] - Fix true 
anomaly definition to include expected anomaly 
URL: https://github.com/apache/incubator-pinot/pull/3709#discussion_r249158040
 
 

 ##
 File path: 
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detector/email/filter/PrecisionRecallEvaluator.java
 ##
 @@ -200,12 +202,14 @@ public void init(List anomalies) 
{
   AnomalyFeedback feedback = anomaly.getFeedback();
   boolean isLabeledTrueAnomaly = false;
   boolean isLabeledTrueAnomalyNewTrend = false;
-  if (feedback != null && feedback.getFeedbackType() != null && 
feedback.getFeedbackType()
-  .equals(AnomalyFeedbackType.ANOMALY_NEW_TREND)) {
-isLabeledTrueAnomalyNewTrend = true;
-  } else if (feedback != null && feedback.getFeedbackType() != null && 
feedback.getFeedbackType()
-  .equals(AnomalyFeedbackType.ANOMALY)) {
-isLabeledTrueAnomaly = true;
+  if (feedback != null && feedback.getFeedbackType() != null) {
+AnomalyClassificationType anomalyClassificationType = 
ResourceUtils.getClassificationType(feedback.getFeedbackType());
+if (anomalyClassificationType == 
AnomalyClassificationType.TRUE_POSITIVE) {
 
 Review comment:
   Done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] aaronucsd merged pull request #3719: [TE] aaronucsd/remove true in alert list

2019-01-18 Thread GitBox 
aaronucsd merged pull request #3719: [TE] aaronucsd/remove true in alert list
URL: https://github.com/apache/incubator-pinot/pull/3719
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] aaronucsd opened a new pull request #3719: [TE] aaronucsd/remove true in alert list

2019-01-18 Thread GitBox 
aaronucsd opened a new pull request #3719: [TE] aaronucsd/remove true in alert 
list
URL: https://github.com/apache/incubator-pinot/pull/3719
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] akshayrai commented on a change in pull request #3714: [TE] yaml - subscribed detection names in notification yaml

2019-01-18 Thread GitBox 
akshayrai commented on a change in pull request #3714: [TE] yaml - subscribed 
detection names in notification yaml
URL: https://github.com/apache/incubator-pinot/pull/3714#discussion_r249148882
 
 

 ##
 File path: 
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlDetectionAlertConfigTranslator.java
 ##
 @@ -209,15 +185,24 @@ public DetectionAlertConfigDTO 
translate(Map yamlAlertConfig) {
 
 alertConfigDTO.setAlertSchemes(buildAlertSchemes(yamlAlertConfig));
 alertConfigDTO.setAlertSuppressors(buildAlertSuppressors(yamlAlertConfig));
-alertConfigDTO.setProperties(buildAlerterProperties(yamlAlertConfig));
+alertConfigDTO.setHighWaterMark(0L);
 
 // NOTE: The below fields will/should be hidden from the YAML/UI. They 
will only be updated by the backend pipeline.
-List detectionConfigIds = 
ConfigUtils.getList(yamlAlertConfig.get(PROP_DETECTION_CONFIG_IDS));
+List detectionConfigIds = 
ConfigUtils.getLongs(yamlAlertConfig.get(PROP_DETECTION_CONFIG_IDS));
 
 Review comment:
   I think we can just remove this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] xiaohui-sun commented on a change in pull request #3709: [TE] - Fix true anomaly definition to include expected anomaly

2019-01-18 Thread GitBox 
xiaohui-sun commented on a change in pull request #3709: [TE] - Fix true 
anomaly definition to include expected anomaly 
URL: https://github.com/apache/incubator-pinot/pull/3709#discussion_r249145991
 
 

 ##
 File path: 
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detector/email/filter/PrecisionRecallEvaluator.java
 ##
 @@ -203,8 +203,8 @@ public void init(List anomalies) {
   if (feedback != null && feedback.getFeedbackType() != null && 
feedback.getFeedbackType()
   .equals(AnomalyFeedbackType.ANOMALY_NEW_TREND)) {
 isLabeledTrueAnomalyNewTrend = true;
-  } else if (feedback != null && feedback.getFeedbackType() != null && 
feedback.getFeedbackType()
-  .equals(AnomalyFeedbackType.ANOMALY)) {
+  } else if (feedback != null && feedback.getFeedbackType() != null &&
+  (feedback.getFeedbackType().equals(AnomalyFeedbackType.ANOMALY) || 
feedback.getFeedbackType().equals(AnomalyFeedbackType.ANOMALY_EXPECTED))) {
 
 Review comment:
   Put it into a helper function.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org

[GitHub] codecov-io edited a comment on issue #3671: Make different PinotFS concrete classes have the same behaviors

2019-01-18 Thread GitBox 
codecov-io edited a comment on issue #3671:  Make different PinotFS concrete 
classes have the same behaviors
URL: https://github.com/apache/incubator-pinot/pull/3671#issuecomment-452940403
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr=h1) 
Report
   > Merging 
[#3671](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/3c4c1c81d675ab887d746ca4654811745e5013c9?src=pr=desc)
 will **increase** coverage by `9.89%`.
   > The diff coverage is `67.05%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/3671/graphs/tree.svg?width=650=4ibza2ugkz=150=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#3671  +/-   ##
   
   + Coverage 57.25%   67.15%   +9.89% 
   - Complexity4   44  +40 
   
 Files  1027 1027  
 Lines 5082850888  +60 
 Branches   7093 7107  +14 
   
   + Hits  2910434175+5071 
   + Misses1957114362-5209 
   - Partials   2153 2351 +198
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...main/java/org/apache/pinot/filesystem/PinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr=tree#diff-cGlub3QtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvZmlsZXN5c3RlbS9QaW5vdEZTLmphdmE=)
 | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1NlZ21lbnREZWxldGlvbk1hbmFnZXIuamF2YQ==)
 | `79.5% <100%> (+4.91%)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...java/org/apache/pinot/filesystem/LocalPinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr=tree#diff-cGlub3QtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvZmlsZXN5c3RlbS9Mb2NhbFBpbm90RlMuamF2YQ==)
 | `74.39% <18.75%> (-13.85%)` | `0 <0> (ø)` | |
   | 
[...ava/org/apache/pinot/filesystem/HadoopPinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr=tree#diff-cGlub3QtaGFkb29wLWZpbGVzeXN0ZW0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L2ZpbGVzeXN0ZW0vSGFkb29wUGlub3RGUy5qYXZh)
 | `64.05% <77.27%> (+64.05%)` | `40 <28> (+40)` | :arrow_up: |
   | 
[...ator/transform/function/BaseTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vQmFzZVRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=)
 | `29.95% <0%> (+0.42%)` | `0% <0%> (ø)` | :arrow_down: |
   | 
[...regation/function/customobject/QuantileDigest.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9jdXN0b21vYmplY3QvUXVhbnRpbGVEaWdlc3QuamF2YQ==)
 | `58.31% <0%> (+0.44%)` | `0% <0%> (ø)` | :arrow_down: |
   | 
[...g/apache/pinot/common/utils/helix/HelixHelper.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvaGVsaXgvSGVsaXhIZWxwZXIuamF2YQ==)
 | `54.16% <0%> (+0.59%)` | `0% <0%> (ø)` | :arrow_down: |
   | 
[...ment/creator/impl/SegmentColumnarIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50Q29sdW1uYXJJbmRleENyZWF0b3IuamF2YQ==)
 | `88.41% <0%> (+0.77%)` | `0% <0%> (ø)` | :arrow_down: |
   | 
[...r/transform/function/ValueInTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVmFsdWVJblRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=)
 | `39.2% <0%> (+0.8%)` | `0% <0%> (ø)` | :arrow_down: |
   | 
[...a/org/apache/pinot/common/utils/ServiceStatus.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvU2VydmljZVN0YXR1cy5qYXZh)
 | `70.73% <0%> (+0.81%)` | `0% <0%> (ø)` | :arrow_down: |
   | ... and [327 
more](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at

[GitHub] ly923976094 commented on issue #3717: kafka consume problem

2019-01-18 Thread GitBox 
ly923976094 commented on issue #3717: kafka consume problem
URL: 
https://github.com/apache/incubator-pinot/issues/3717#issuecomment-455475008
 
 
   > Stop temporarily or permanently?
   > […](#)
   > On Thu, Jan 17, 2019 at 10:23 PM Sun-Li ***@***.***> wrote: The table has 
kafka real-time consumption configured. How do I stop this consumption — You 
are receiving this because you are subscribed to this thread. Reply to this 
email directly, view it on GitHub <#3717>, or mute the thread 

 .
   
   What's the solution to both of these  （ temporarily or permanently）


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org