[jira] [Commented] (PIVOT-689) Finishing touches on Skin Colors
[ https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104142#comment-14104142 ] Roger Whitcomb commented on PIVOT-689: -- Ciao Sandro, Just saw the commit. Code looks good. Will try it in our app to see how it looks (about too much whiteness?). I had one other suggestion, which is to add these default colors into the theme JSON files themselves, with defaults to BLACK / WHITE if not present. That way even these could be set /tweaked in a custom color scheme. What do you think? ~Roger > Finishing touches on Skin Colors > > > Key: PIVOT-689 > URL: https://issues.apache.org/jira/browse/PIVOT-689 > Project: Pivot > Issue Type: Improvement > Components: wtk-terra >Reporter: Sandro Martini >Assignee: Sandro Martini >Priority: Minor > Fix For: 2.1, 2.0.5 > > Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer - > dark.launch, KitchenSink - Dark.launch, pivot689.patch > > > Finishing touches on Skin Colors, some info here (and more later here in > JIRA): https://issues.apache.org/jira/browse/PIVOT-579 > See if even the final part of this (not implemented) could be useful: > https://issues.apache.org/jira/browse/PIVOT-245 > And there was another discussion (I have to find where, in nabble) is change > some color index usage to have better visual appearance (of course > retrofitting existing behavior when/if possible). > Note that probably after these little changes, custom color json files should > be a little updated. > And a little thing on this: > now only Tooltips doesn't use a palette color (they use an hard-coded color) > ... what do you think to make them use the yellow-ish color at > palette index 19 (or one of is variants, the 18 or 20) ? And use a similar > (yellow-ish but a different color index, if possible) color on warnings. > I could adapt a little that color in all Pivot palettes to look similar to > what should be ... tell me. > For example, someone remember the background color in Swing Tooltips (ok not > the best in graphic design and colors :-) ), but with this little change we > could also have this little feature, where in most palettes will be > yellow-ish, but where needed could be different. > Added some documentation in the Terra package JavaDoc file on color palette > usage in the Terra Skin, to help anyone wants to write their custom colors, > and then removed, probably the best place for this is in a Tutorial. > Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some > Tooltips to see how they happen, but see where they makes sense. > And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3, > grouping them by similar components (some componets should be added there). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PIVOT-689) Finishing touches on Skin Colors
[ https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105540#comment-14105540 ] Roger Whitcomb commented on PIVOT-689: -- Preliminary results are that since we define most/all our colors in BXML files, there seems to be no difference in our app between old and new. I'm also checking one other small Pivot app I have. > Finishing touches on Skin Colors > > > Key: PIVOT-689 > URL: https://issues.apache.org/jira/browse/PIVOT-689 > Project: Pivot > Issue Type: Improvement > Components: wtk-terra >Reporter: Sandro Martini >Assignee: Sandro Martini >Priority: Minor > Fix For: 2.1, 2.0.5 > > Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer - > dark.launch, KitchenSink - Dark.launch, pivot689.patch > > > Finishing touches on Skin Colors, some info here (and more later here in > JIRA): https://issues.apache.org/jira/browse/PIVOT-579 > See if even the final part of this (not implemented) could be useful: > https://issues.apache.org/jira/browse/PIVOT-245 > And there was another discussion (I have to find where, in nabble) is change > some color index usage to have better visual appearance (of course > retrofitting existing behavior when/if possible). > Note that probably after these little changes, custom color json files should > be a little updated. > And a little thing on this: > now only Tooltips doesn't use a palette color (they use an hard-coded color) > ... what do you think to make them use the yellow-ish color at > palette index 19 (or one of is variants, the 18 or 20) ? And use a similar > (yellow-ish but a different color index, if possible) color on warnings. > I could adapt a little that color in all Pivot palettes to look similar to > what should be ... tell me. > For example, someone remember the background color in Swing Tooltips (ok not > the best in graphic design and colors :-) ), but with this little change we > could also have this little feature, where in most palettes will be > yellow-ish, but where needed could be different. > Added some documentation in the Terra package JavaDoc file on color palette > usage in the Terra Skin, to help anyone wants to write their custom colors, > and then removed, probably the best place for this is in a Tutorial. > Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some > Tooltips to see how they happen, but see where they makes sense. > And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3, > grouping them by similar components (some componets should be added there). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PIVOT-689) Finishing touches on Skin Colors
[ https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120510#comment-14120510 ] Roger Whitcomb commented on PIVOT-689: -- Ciao Sandro, With regard to changing the default font: we found that the Java "logical" fonts (such as "MONOSPACED", "DIALOG", etc.) support more characters in the Unicode set since they are composite fonts. So, "Verdana" was not found to be a good choice for us. Changing to "DIALOG" worked well for us to be able to see Korean characters (for instance) correctly. None of the "Windows-only" fonts had the characters to display Korean (not "Arial", "Verdana", "Tahoma"...) but MONOSPACED, DIALOG, SERIF, and SANS_SERIF all did have these characters. So, my recommendation (and this is a big visual difference) would be to change the default Theme font to "DIALOG 12" instead of "Verdana 11". This also works better on non-Windows platforms, which don't typically have these Windows fonts available. OSX, for instance, has Helvetica, but not Arial or Verdana. Linux typically has Bitstream and DejaVu fonts, maybe Lucida, but none of the other "Windows" fonts. > Finishing touches on Skin Colors > > > Key: PIVOT-689 > URL: https://issues.apache.org/jira/browse/PIVOT-689 > Project: Pivot > Issue Type: Improvement > Components: wtk-terra >Reporter: Sandro Martini >Assignee: Sandro Martini > Fix For: 2.1, 2.0.5 > > Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer - > dark.launch, KitchenSink - Dark.launch, pivot689.patch, > pivot_colorschemebuilder_dark_flat_screencapt.png, > pivot_colorschemebuilder_dark_screencapt.png, > pivot_colorschemebuilder_default_flat_screenshot.png, > pivot_colorschemebuilder_default_screencapt.png > > > Finishing touches on Skin Colors, some info here (and more later here in > JIRA): https://issues.apache.org/jira/browse/PIVOT-579 > See if even the final part of this (not implemented) could be useful: > https://issues.apache.org/jira/browse/PIVOT-245 > And there was another discussion (I have to find where, in nabble) is change > some color index usage to have better visual appearance (of course > retrofitting existing behavior when/if possible). > Note that probably after these little changes, custom color json files should > be a little updated. > And a little thing on this: > now only Tooltips doesn't use a palette color (they use an hard-coded color) > ... what do you think to make them use the yellow-ish color at > palette index 19 (or one of is variants, the 18 or 20) ? And use a similar > (yellow-ish but a different color index, if possible) color on warnings. > I could adapt a little that color in all Pivot palettes to look similar to > what should be ... tell me. > For example, someone remember the background color in Swing Tooltips (ok not > the best in graphic design and colors :-) ), but with this little change we > could also have this little feature, where in most palettes will be > yellow-ish, but where needed could be different. > Added some documentation in the Terra package JavaDoc file on color palette > usage in the Terra Skin, to help anyone wants to write their custom colors, > and then removed, probably the best place for this is in a Tutorial. > Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some > Tooltips to see how they happen, but see where they makes sense. > And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3, > grouping them by similar components (some componets should be added there). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PIVOT-958) Change default theme font to one of the Java "logical" fonts
Roger Whitcomb created PIVOT-958: Summary: Change default theme font to one of the Java "logical" fonts Key: PIVOT-958 URL: https://issues.apache.org/jira/browse/PIVOT-958 Project: Pivot Issue Type: Improvement Components: wtk-terra Affects Versions: 2.0.4 Environment: WIndows XP, Windows 7, OSX Mavericks, Linux RedHat Reporter: Roger Whitcomb Assignee: Roger Whitcomb Fix For: 2.1, 2.0.5 The current default Terra Theme font is "Verdana 11". While this is a nice-looking font, it is not available (by default) on platforms other than Windows, and it does not support a wide range of the Unicode character set (typically not much outside the Latin-1 range). This is a problem for applications needing to routinely handle Japanese, Korean, Chinese, etc. characters in the GUI. The proposal would be to change the default theme font to either "DIALOG 12" or maybe "SANS_SERIF 12" in order to take advantage of the increased character set coverage in these "logical" fonts. Since this is a big visual change, it is not clear if it should go into 2.0.5 or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (PIVOT-916) Replace DesktopApplicationContext.displayException calls with ApplicationContext.handleUncaughtException
[ https://issues.apache.org/jira/browse/PIVOT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb reopened PIVOT-916: -- Assignee: Roger Whitcomb (was: Sandro Martini) I'd like to make another small enhancement here: namely move the default code that is now inside "uncaughtExceptionThrown" to its own static method so that any Application that implements the new interface could itself default to calling the default, default method if desired. > Replace DesktopApplicationContext.displayException calls with > ApplicationContext.handleUncaughtException > > > Key: PIVOT-916 > URL: https://issues.apache.org/jira/browse/PIVOT-916 > Project: Pivot > Issue Type: Improvement >Reporter: Karel Hübl >Assignee: Roger Whitcomb > Fix For: 2.0.4 > > Attachments: ScriptApplication.java.patch, app_exception.patch, > trunk_wtk.patch, wtk_test.zip > > > There should be consistent way to handle uncaught exceptions in Pivot > applications. > However uncaught exceptions thrown in DesktopApplicationContext class (for > example in application.startup ) are handled using private static method > displayException, which displays dialog and its logic cannot be overriden. > May be ApplicationContext.handleUncaughtException could be made protected and > calls to DesktopApplicationContext.displayException could be replaced by > ApplicationContext.handleUncaughtException. And possibly Application.Adapter > could implement UncaughtExceptionHandler - so current > DesktopApplicationContext.displayException logic could be moved to new > Application.Adapter.uncaughtExceptionThrown method. > This should enable to override uncaught exception handling globally in pivot > applications. > Motivation: > We deploy Pivot app using Java Web Start. Users have by default disabled Java > Console (and they are not familiar with it). We want to display custom dialog > to handle uncaught exceptions displaying full stack trace and with possiblity > to report exception to help desk. > I think, in current implementation it is not possible to override handling of > uncaught exceptions thrown during application init and other specific > situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIVOT-916) Replace DesktopApplicationContext.displayException calls with ApplicationContext.handleUncaughtException
[
https://issues.apache.org/jira/browse/PIVOT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Whitcomb updated PIVOT-916:
-
Attachment: 916.diff
Proposed change: just move the code from inside "handleUncaughtException" to
its own method "defaultUncaughtExceptionHandler" so it can be called from user
application if desired.
My implementation looks like this:
@Override
public void uncaughtExceptionThrown(Exception exception) {
try {
MessageDialog.showException(mainWindow, exception);
}
catch (Exception ourProblem) {
// Ignore this exception (essentially spurious problem in our
code)
// and display the original one via the default handler
ApplicationContext.defaultUncaughtExceptionHandler(exception);
}
}
> Replace DesktopApplicationContext.displayException calls with
> ApplicationContext.handleUncaughtException
>
>
> Key: PIVOT-916
> URL: https://issues.apache.org/jira/browse/PIVOT-916
> Project: Pivot
> Issue Type: Improvement
>Reporter: Karel Hübl
>Assignee: Roger Whitcomb
> Fix For: 2.0.4, 2.1, 2.0.5
>
> Attachments: 916.diff, ScriptApplication.java.patch,
> app_exception.patch, trunk_wtk.patch, wtk_test.zip
>
>
> There should be consistent way to handle uncaught exceptions in Pivot
> applications.
> However uncaught exceptions thrown in DesktopApplicationContext class (for
> example in application.startup ) are handled using private static method
> displayException, which displays dialog and its logic cannot be overriden.
> May be ApplicationContext.handleUncaughtException could be made protected and
> calls to DesktopApplicationContext.displayException could be replaced by
> ApplicationContext.handleUncaughtException. And possibly Application.Adapter
> could implement UncaughtExceptionHandler - so current
> DesktopApplicationContext.displayException logic could be moved to new
> Application.Adapter.uncaughtExceptionThrown method.
> This should enable to override uncaught exception handling globally in pivot
> applications.
> Motivation:
> We deploy Pivot app using Java Web Start. Users have by default disabled Java
> Console (and they are not familiar with it). We want to display custom dialog
> to handle uncaught exceptions displaying full stack trace and with possiblity
> to report exception to help desk.
> I think, in current implementation it is not possible to override handling of
> uncaught exceptions thrown during application init and other specific
> situations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIVOT-689) Finishing touches on Skin Colors
[ https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129405#comment-14129405 ] Roger Whitcomb commented on PIVOT-689: -- I'm seeing a few visual changes in our application with these changes: * Menu items now have a light gray background that used to be transparent or white. * TextArea now has a light gray background that also used to be white. Were these intentional or artifacts of other things? > Finishing touches on Skin Colors > > > Key: PIVOT-689 > URL: https://issues.apache.org/jira/browse/PIVOT-689 > Project: Pivot > Issue Type: Improvement > Components: wtk-terra >Reporter: Sandro Martini >Assignee: Sandro Martini > Fix For: 2.1, 2.0.5 > > Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer - > dark.launch, KitchenSink - Dark.launch, pivot689.patch, > pivot_colorschemebuilder_dark_flat_screencapt.png, > pivot_colorschemebuilder_dark_screencapt.png, > pivot_colorschemebuilder_default_flat_screenshot.png, > pivot_colorschemebuilder_default_screencapt.png > > > Finishing touches on Skin Colors, some info here (and more later here in > JIRA): https://issues.apache.org/jira/browse/PIVOT-579 > See if even the final part of this (not implemented) could be useful: > https://issues.apache.org/jira/browse/PIVOT-245 > And there was another discussion (I have to find where, in nabble) is change > some color index usage to have better visual appearance (of course > retrofitting existing behavior when/if possible). > Note that probably after these little changes, custom color json files should > be a little updated. > And a little thing on this: > now only Tooltips doesn't use a palette color (they use an hard-coded color) > ... what do you think to make them use the yellow-ish color at > palette index 19 (or one of is variants, the 18 or 20) ? And use a similar > (yellow-ish but a different color index, if possible) color on warnings. > I could adapt a little that color in all Pivot palettes to look similar to > what should be ... tell me. > For example, someone remember the background color in Swing Tooltips (ok not > the best in graphic design and colors :-) ), but with this little change we > could also have this little feature, where in most palettes will be > yellow-ish, but where needed could be different. > Added some documentation in the Terra package JavaDoc file on color palette > usage in the Terra Skin, to help anyone wants to write their custom colors, > and then removed, probably the best place for this is in a Tutorial. > Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some > Tooltips to see how they happen, but see where they makes sense. > And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3, > grouping them by similar components (some componets should be added there). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIVOT-689) Finishing touches on Skin Colors
[ https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-689: - Attachment: log Just updated trunk from SVN, did a "ant clean package" and got the errors in "log" file... Mostly "themeIsFlat()" not found... > Finishing touches on Skin Colors > > > Key: PIVOT-689 > URL: https://issues.apache.org/jira/browse/PIVOT-689 > Project: Pivot > Issue Type: Improvement > Components: wtk-terra >Reporter: Sandro Martini >Assignee: Sandro Martini > Fix For: 2.1, 2.0.5 > > Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer - > dark.launch, KitchenSink - Dark.launch, log, pivot689.patch, > pivot_colorschemebuilder_dark_flat_screencapt.png, > pivot_colorschemebuilder_dark_screencapt.png, > pivot_colorschemebuilder_default_flat_screenshot.png, > pivot_colorschemebuilder_default_screencapt.png > > > Finishing touches on Skin Colors, some info here (and more later here in > JIRA): https://issues.apache.org/jira/browse/PIVOT-579 > See if even the final part of this (not implemented) could be useful: > https://issues.apache.org/jira/browse/PIVOT-245 > And there was another discussion (I have to find where, in nabble) is change > some color index usage to have better visual appearance (of course > retrofitting existing behavior when/if possible). > Note that probably after these little changes, custom color json files should > be a little updated. > And a little thing on this: > now only Tooltips doesn't use a palette color (they use an hard-coded color) > ... what do you think to make them use the yellow-ish color at > palette index 19 (or one of is variants, the 18 or 20) ? And use a similar > (yellow-ish but a different color index, if possible) color on warnings. > I could adapt a little that color in all Pivot palettes to look similar to > what should be ... tell me. > For example, someone remember the background color in Swing Tooltips (ok not > the best in graphic design and colors :-) ), but with this little change we > could also have this little feature, where in most palettes will be > yellow-ish, but where needed could be different. > Added some documentation in the Terra package JavaDoc file on color palette > usage in the Terra Skin, to help anyone wants to write their custom colors, > and then removed, probably the best place for this is in a Tutorial. > Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some > Tooltips to see how they happen, but see where they makes sense. > And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3, > grouping them by similar components (some componets should be added there). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIVOT-689) Finishing touches on Skin Colors
[ https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-689: - Attachment: (was: log) > Finishing touches on Skin Colors > > > Key: PIVOT-689 > URL: https://issues.apache.org/jira/browse/PIVOT-689 > Project: Pivot > Issue Type: Improvement > Components: wtk-terra >Reporter: Sandro Martini >Assignee: Sandro Martini > Fix For: 2.1, 2.0.5 > > Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer - > dark.launch, KitchenSink - Dark.launch, pivot689.patch, > pivot_colorschemebuilder_dark_flat_screencapt.png, > pivot_colorschemebuilder_dark_screencapt.png, > pivot_colorschemebuilder_default_flat_screenshot.png, > pivot_colorschemebuilder_default_screencapt.png > > > Finishing touches on Skin Colors, some info here (and more later here in > JIRA): https://issues.apache.org/jira/browse/PIVOT-579 > See if even the final part of this (not implemented) could be useful: > https://issues.apache.org/jira/browse/PIVOT-245 > And there was another discussion (I have to find where, in nabble) is change > some color index usage to have better visual appearance (of course > retrofitting existing behavior when/if possible). > Note that probably after these little changes, custom color json files should > be a little updated. > And a little thing on this: > now only Tooltips doesn't use a palette color (they use an hard-coded color) > ... what do you think to make them use the yellow-ish color at > palette index 19 (or one of is variants, the 18 or 20) ? And use a similar > (yellow-ish but a different color index, if possible) color on warnings. > I could adapt a little that color in all Pivot palettes to look similar to > what should be ... tell me. > For example, someone remember the background color in Swing Tooltips (ok not > the best in graphic design and colors :-) ), but with this little change we > could also have this little feature, where in most palettes will be > yellow-ish, but where needed could be different. > Added some documentation in the Terra package JavaDoc file on color palette > usage in the Terra Skin, to help anyone wants to write their custom colors, > and then removed, probably the best place for this is in a Tutorial. > Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some > Tooltips to see how they happen, but see where they makes sense. > And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3, > grouping them by similar components (some componets should be added there). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (PIVOT-689) Finishing touches on Skin Colors
[ https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-689: - Comment: was deleted (was: Just updated trunk from SVN, did a "ant clean package" and got the errors in "log" file... Mostly "themeIsFlat()" not found...) > Finishing touches on Skin Colors > > > Key: PIVOT-689 > URL: https://issues.apache.org/jira/browse/PIVOT-689 > Project: Pivot > Issue Type: Improvement > Components: wtk-terra >Reporter: Sandro Martini >Assignee: Sandro Martini > Fix For: 2.1, 2.0.5 > > Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer - > dark.launch, KitchenSink - Dark.launch, pivot689.patch, > pivot_colorschemebuilder_dark_flat_screencapt.png, > pivot_colorschemebuilder_dark_screencapt.png, > pivot_colorschemebuilder_default_flat_screenshot.png, > pivot_colorschemebuilder_default_screencapt.png > > > Finishing touches on Skin Colors, some info here (and more later here in > JIRA): https://issues.apache.org/jira/browse/PIVOT-579 > See if even the final part of this (not implemented) could be useful: > https://issues.apache.org/jira/browse/PIVOT-245 > And there was another discussion (I have to find where, in nabble) is change > some color index usage to have better visual appearance (of course > retrofitting existing behavior when/if possible). > Note that probably after these little changes, custom color json files should > be a little updated. > And a little thing on this: > now only Tooltips doesn't use a palette color (they use an hard-coded color) > ... what do you think to make them use the yellow-ish color at > palette index 19 (or one of is variants, the 18 or 20) ? And use a similar > (yellow-ish but a different color index, if possible) color on warnings. > I could adapt a little that color in all Pivot palettes to look similar to > what should be ... tell me. > For example, someone remember the background color in Swing Tooltips (ok not > the best in graphic design and colors :-) ), but with this little change we > could also have this little feature, where in most palettes will be > yellow-ish, but where needed could be different. > Added some documentation in the Terra package JavaDoc file on color palette > usage in the Terra Skin, to help anyone wants to write their custom colors, > and then removed, probably the best place for this is in a Tutorial. > Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some > Tooltips to see how they happen, but see where they makes sense. > And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3, > grouping them by similar components (some componets should be added there). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-916) Replace DesktopApplicationContext.displayException calls with ApplicationContext.handleUncaughtException
[ https://issues.apache.org/jira/browse/PIVOT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14130642#comment-14130642 ] Roger Whitcomb commented on PIVOT-916: -- Checked in the change to "trunk": Sendingwtk\src\org\apache\pivot\wtk\ApplicationContext.java Transmitting file data . Committed revision 1624381. Merged into "branches/2.0.x": Sending. Sendingwtk\src\org\apache\pivot\wtk\ApplicationContext.java Transmitting file data . Committed revision 1624382. > Replace DesktopApplicationContext.displayException calls with > ApplicationContext.handleUncaughtException > > > Key: PIVOT-916 > URL: https://issues.apache.org/jira/browse/PIVOT-916 > Project: Pivot > Issue Type: Improvement >Reporter: Karel Hübl >Assignee: Roger Whitcomb > Fix For: 2.0.4, 2.1, 2.0.5 > > Attachments: 916.diff, ScriptApplication.java.patch, > app_exception.patch, trunk_wtk.patch, wtk_test.zip > > > There should be consistent way to handle uncaught exceptions in Pivot > applications. > However uncaught exceptions thrown in DesktopApplicationContext class (for > example in application.startup ) are handled using private static method > displayException, which displays dialog and its logic cannot be overriden. > May be ApplicationContext.handleUncaughtException could be made protected and > calls to DesktopApplicationContext.displayException could be replaced by > ApplicationContext.handleUncaughtException. And possibly Application.Adapter > could implement UncaughtExceptionHandler - so current > DesktopApplicationContext.displayException logic could be moved to new > Application.Adapter.uncaughtExceptionThrown method. > This should enable to override uncaught exception handling globally in pivot > applications. > Motivation: > We deploy Pivot app using Java Web Start. Users have by default disabled Java > Console (and they are not familiar with it). We want to display custom dialog > to handle uncaught exceptions displaying full stack trace and with possiblity > to report exception to help desk. > I think, in current implementation it is not possible to override handling of > uncaught exceptions thrown during application init and other specific > situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (PIVOT-916) Replace DesktopApplicationContext.displayException calls with ApplicationContext.handleUncaughtException
[ https://issues.apache.org/jira/browse/PIVOT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb resolved PIVOT-916. -- Resolution: Fixed > Replace DesktopApplicationContext.displayException calls with > ApplicationContext.handleUncaughtException > > > Key: PIVOT-916 > URL: https://issues.apache.org/jira/browse/PIVOT-916 > Project: Pivot > Issue Type: Improvement >Reporter: Karel Hübl >Assignee: Roger Whitcomb > Fix For: 2.1, 2.0.5, 2.0.4 > > Attachments: 916.diff, ScriptApplication.java.patch, > app_exception.patch, trunk_wtk.patch, wtk_test.zip > > > There should be consistent way to handle uncaught exceptions in Pivot > applications. > However uncaught exceptions thrown in DesktopApplicationContext class (for > example in application.startup ) are handled using private static method > displayException, which displays dialog and its logic cannot be overriden. > May be ApplicationContext.handleUncaughtException could be made protected and > calls to DesktopApplicationContext.displayException could be replaced by > ApplicationContext.handleUncaughtException. And possibly Application.Adapter > could implement UncaughtExceptionHandler - so current > DesktopApplicationContext.displayException logic could be moved to new > Application.Adapter.uncaughtExceptionThrown method. > This should enable to override uncaught exception handling globally in pivot > applications. > Motivation: > We deploy Pivot app using Java Web Start. Users have by default disabled Java > Console (and they are not familiar with it). We want to display custom dialog > to handle uncaught exceptions displaying full stack trace and with possiblity > to report exception to help desk. > I think, in current implementation it is not possible to override handling of > uncaught exceptions thrown during application init and other specific > situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-959) TerraTextInputSkin may process the same key press twice
[ https://issues.apache.org/jira/browse/PIVOT-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167527#comment-14167527 ] Roger Whitcomb commented on PIVOT-959: -- In looking through the code, it seems like TerraTextInputSkin is the only class that does this (call "super.keyPressed" twice). The "consumed" value from the first call is never used, and in fact, is set by each of the "if" cases, and "else" sets it by calling "super.keyPressed" again. So, I agree with Alessandro's analysis, and believe that we should take out the first call. If there would be problems it would be with the keys that are processed in this skin method itself (which would be DELETE, BACKSPACE, HOME, END, arrow keys, etc.). The only problem I could envision would be with TAB (which should traverse fields in a container) but which is never processed by TextInput. So, I believe this fix would be completely safe. > TerraTextInputSkin may process the same key press twice > --- > > Key: PIVOT-959 > URL: https://issues.apache.org/jira/browse/PIVOT-959 > Project: Pivot > Issue Type: Bug > Components: wtk-terra >Affects Versions: 2.0.4 >Reporter: Alessandro Pira >Priority: Minor > Fix For: 2.1, 2.0.5 > > > TerraTextInputSkin's keyPress method may call super.keyPress twice (once as > its first instruction, and then again in the "else" branch). > I suggest to remove the first ancestor call. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-689) Finishing touches on Skin Colors
[
https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174400#comment-14174400
]
Roger Whitcomb commented on PIVOT-689:
--
Had another thought. Could we / should we ship a number of the possible theme
files (including possibly the old one from 2.0.4) so that you could simply
choose one (non-default) by doing:
System.setProperty("org.apache.pivot.wtk.skin.terra.location",
"TerraTheme_dark.json");
(for instance) before you instantiate the theme for the first time?
That would make a simple way to select one of the styles we have predesigned.
> Finishing touches on Skin Colors
>
>
> Key: PIVOT-689
> URL: https://issues.apache.org/jira/browse/PIVOT-689
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
>Reporter: Sandro Martini
>Assignee: Sandro Martini
> Fix For: 2.1, 2.0.5
>
> Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer -
> dark.launch, KitchenSink - Dark.launch, pivot689.patch,
> pivot_colorschemebuilder_dark_flat_screencapt.png,
> pivot_colorschemebuilder_dark_screencapt.png,
> pivot_colorschemebuilder_default_flat_screenshot.png,
> pivot_colorschemebuilder_default_screencapt.png
>
>
> Finishing touches on Skin Colors, some info here (and more later here in
> JIRA): https://issues.apache.org/jira/browse/PIVOT-579
> See if even the final part of this (not implemented) could be useful:
> https://issues.apache.org/jira/browse/PIVOT-245
> And there was another discussion (I have to find where, in nabble) is change
> some color index usage to have better visual appearance (of course
> retrofitting existing behavior when/if possible).
> Note that probably after these little changes, custom color json files should
> be a little updated.
> And a little thing on this:
> now only Tooltips doesn't use a palette color (they use an hard-coded color)
> ... what do you think to make them use the yellow-ish color at
> palette index 19 (or one of is variants, the 18 or 20) ? And use a similar
> (yellow-ish but a different color index, if possible) color on warnings.
> I could adapt a little that color in all Pivot palettes to look similar to
> what should be ... tell me.
> For example, someone remember the background color in Swing Tooltips (ok not
> the best in graphic design and colors :-) ), but with this little change we
> could also have this little feature, where in most palettes will be
> yellow-ish, but where needed could be different.
> Added some documentation in the Terra package JavaDoc file on color palette
> usage in the Terra Skin, to help anyone wants to write their custom colors,
> and then removed, probably the best place for this is in a Tutorial.
> Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some
> Tooltips to see how they happen, but see where they makes sense.
> And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3,
> grouping them by similar components (some componets should be added there).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIVOT-689) Finishing touches on Skin Colors
[
https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175260#comment-14175260
]
Roger Whitcomb commented on PIVOT-689:
--
Actually you can do
'System.setProperty("org.apache.pivot.wtk.skin.terra.location",
"TerraTheme_dark.json")' (for instance) even in code (i.e., not on the command
line) before you create any Pivot components.
So, having some others shipped in the pivot-wtk-terra.jar file would facilitate
doing this (and thus setting up a dark theme).
Another thing I thought of, if we had some color schemes that looked good,
would be to setup a small enum for use in a new method in Theme that would set
the "location" from a field in the enum. Then, potentially you could write
code like this:
Theme.setColorScheme(ColorScheme.DARK);
which would set "location" to "TerraTheme_dark.json".
For non-standard ones, then you could go back to using the System.setProperty
method (as above) or using -D on the command line.
What do you think? I can code up a patch for my enum scheme if you want to
look at it.
> Finishing touches on Skin Colors
>
>
> Key: PIVOT-689
> URL: https://issues.apache.org/jira/browse/PIVOT-689
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
>Reporter: Sandro Martini
>Assignee: Sandro Martini
> Fix For: 2.1, 2.0.5
>
> Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer -
> dark.launch, KitchenSink - Dark.launch, pivot689.patch,
> pivot_colorschemebuilder_dark_flat_screencapt.png,
> pivot_colorschemebuilder_dark_screencapt.png,
> pivot_colorschemebuilder_default_flat_screenshot.png,
> pivot_colorschemebuilder_default_screencapt.png
>
>
> Finishing touches on Skin Colors, some info here (and more later here in
> JIRA): https://issues.apache.org/jira/browse/PIVOT-579
> See if even the final part of this (not implemented) could be useful:
> https://issues.apache.org/jira/browse/PIVOT-245
> And there was another discussion (I have to find where, in nabble) is change
> some color index usage to have better visual appearance (of course
> retrofitting existing behavior when/if possible).
> Note that probably after these little changes, custom color json files should
> be a little updated.
> And a little thing on this:
> now only Tooltips doesn't use a palette color (they use an hard-coded color)
> ... what do you think to make them use the yellow-ish color at
> palette index 19 (or one of is variants, the 18 or 20) ? And use a similar
> (yellow-ish but a different color index, if possible) color on warnings.
> I could adapt a little that color in all Pivot palettes to look similar to
> what should be ... tell me.
> For example, someone remember the background color in Swing Tooltips (ok not
> the best in graphic design and colors :-) ), but with this little change we
> could also have this little feature, where in most palettes will be
> yellow-ish, but where needed could be different.
> Added some documentation in the Terra package JavaDoc file on color palette
> usage in the Terra Skin, to help anyone wants to write their custom colors,
> and then removed, probably the best place for this is in a Tutorial.
> Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some
> Tooltips to see how they happen, but see where they makes sense.
> And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3,
> grouping them by similar components (some componets should be added there).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (PIVOT-916) Replace DesktopApplicationContext.displayException calls with ApplicationContext.handleUncaughtException
[ https://issues.apache.org/jira/browse/PIVOT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb closed PIVOT-916. Implemented and tested in our application. All is good. > Replace DesktopApplicationContext.displayException calls with > ApplicationContext.handleUncaughtException > > > Key: PIVOT-916 > URL: https://issues.apache.org/jira/browse/PIVOT-916 > Project: Pivot > Issue Type: Improvement >Reporter: Karel Hübl >Assignee: Roger Whitcomb > Fix For: 2.0.4, 2.1, 2.0.5 > > Attachments: 916.diff, ScriptApplication.java.patch, > app_exception.patch, trunk_wtk.patch, wtk_test.zip > > > There should be consistent way to handle uncaught exceptions in Pivot > applications. > However uncaught exceptions thrown in DesktopApplicationContext class (for > example in application.startup ) are handled using private static method > displayException, which displays dialog and its logic cannot be overriden. > May be ApplicationContext.handleUncaughtException could be made protected and > calls to DesktopApplicationContext.displayException could be replaced by > ApplicationContext.handleUncaughtException. And possibly Application.Adapter > could implement UncaughtExceptionHandler - so current > DesktopApplicationContext.displayException logic could be moved to new > Application.Adapter.uncaughtExceptionThrown method. > This should enable to override uncaught exception handling globally in pivot > applications. > Motivation: > We deploy Pivot app using Java Web Start. Users have by default disabled Java > Console (and they are not familiar with it). We want to display custom dialog > to handle uncaught exceptions displaying full stack trace and with possiblity > to report exception to help desk. > I think, in current implementation it is not possible to override handling of > uncaught exceptions thrown during application init and other specific > situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PIVOT-960) Implement simple macro system in JSONSerializer
Roger Whitcomb created PIVOT-960: Summary: Implement simple macro system in JSONSerializer Key: PIVOT-960 URL: https://issues.apache.org/jira/browse/PIVOT-960 Project: Pivot Issue Type: Improvement Components: core-json Affects Versions: 2.0.4 Environment: All Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.1 It occurred to me since we are using JSON style sheets to style our application, and it is getting quite big, that a macro system (maybe similar to C/C++ with #define or something similar) would be useful, especially for repeated colors, and other constants (like padding values, fonts, etc.) This would enable using custom values consistently while avoiding inconsistencies due to typos or changes introduced one place and not others. I was thinking of a simple #define NAME value as in C/C++, and then using $(NAME) as the substitution token. This is easily implemented in JSONSerializer. I'm open to suggestions for the syntax, but I believe the feature will be very useful, especially for the JSON stylesheet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PIVOT-961) Add new notification type of component similar to new OSX notifications.
Roger Whitcomb created PIVOT-961: Summary: Add new notification type of component similar to new OSX notifications. Key: PIVOT-961 URL: https://issues.apache.org/jira/browse/PIVOT-961 Project: Pivot Issue Type: New Feature Components: wtk, wtk-terra Affects Versions: 2.1 Environment: All Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.1 In newer versions of OSX, you get notifications on the desktop that slide in from the upper right, display for a few seconds and then slide out. For some situations in an application this type of notification would be ideal to use, if available (instead of an Alert, for instance, that must be acknowledged with a click). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIVOT-960) Implement simple macro system in JSONSerializer
[ https://issues.apache.org/jira/browse/PIVOT-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-960: - Attachment: 960.patch The "960.patch" file is a complete solution. There are updates to the JSONSerializerTest using a simple macro, and testing the functionality. One new file: org.apache.pivot.core.serialization.MacroReader which acts as a filter on top of another Reader, doing the defining and expansion of macros. > Implement simple macro system in JSONSerializer > --- > > Key: PIVOT-960 > URL: https://issues.apache.org/jira/browse/PIVOT-960 > Project: Pivot > Issue Type: Improvement > Components: core-json >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1 > > Attachments: 960.patch > > > It occurred to me since we are using JSON style sheets to style our > application, and it is getting quite big, that a macro system (maybe similar > to C/C++ with #define or something similar) would be useful, especially for > repeated colors, and other constants (like padding values, fonts, etc.) This > would enable using custom values consistently while avoiding inconsistencies > due to typos or changes introduced one place and not others. > I was thinking of a simple > #define NAME value > as in C/C++, and then using $(NAME) as the substitution token. This is > easily implemented in JSONSerializer. > I'm open to suggestions for the syntax, but I believe the feature will be > very useful, especially for the JSON stylesheet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-960) Implement simple macro system in JSONSerializer
[
https://issues.apache.org/jira/browse/PIVOT-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190401#comment-14190401
]
Roger Whitcomb commented on PIVOT-960:
--
I can definitely change the macro expansion format to $NAME instead of $(NAME).
I had thought of ${NAME} (which is the syntax Ant uses).
To answer your questions:
* If a variable is not defined, then then macro remains unexpanded, so $NAME ->
$NAME still. This is why I chose $NAME as the expansion, because "$" is not
otherwise used specially in JSON.
* Currently there are no (additional) exceptions possible in this code than
there used to be, so no worries there.
A couple of other points:
* The macro value starts at the first non-white character after the name, and
can be continued on another line using \ as the last character on the line.
* The macro name is just bounded by whitespace, so the "name" can be any
combination of non-white characters (such as {_(IOP)_} if you want)
So, will commit the change with the $(NAME) -> $NAME change as suggested.
> Implement simple macro system in JSONSerializer
> ---
>
> Key: PIVOT-960
> URL: https://issues.apache.org/jira/browse/PIVOT-960
> Project: Pivot
> Issue Type: Improvement
> Components: core-json
>Affects Versions: 2.0.4
> Environment: All
>Reporter: Roger Whitcomb
>Assignee: Roger Whitcomb
>Priority: Minor
> Fix For: 2.1
>
> Attachments: 960.patch
>
>
> It occurred to me since we are using JSON style sheets to style our
> application, and it is getting quite big, that a macro system (maybe similar
> to C/C++ with #define or something similar) would be useful, especially for
> repeated colors, and other constants (like padding values, fonts, etc.) This
> would enable using custom values consistently while avoiding inconsistencies
> due to typos or changes introduced one place and not others.
> I was thinking of a simple
> #define NAME value
> as in C/C++, and then using $(NAME) as the substitution token. This is
> easily implemented in JSONSerializer.
> I'm open to suggestions for the syntax, but I believe the feature will be
> very useful, especially for the JSON stylesheet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIVOT-960) Implement simple macro system in JSONSerializer
[ https://issues.apache.org/jira/browse/PIVOT-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196772#comment-14196772 ] Roger Whitcomb commented on PIVOT-960: -- Okay, in looking at the code trying to change the macro expansion from $(NAME) to just $NAME I see a couple of problems: 1. Suppose I have a macro like: #define PREFIX vertical and I want to use it like this: $(PREFIX)Alignment : 'center' I cannot do this with just the $PREFIXAlignment syntax... 2. Even though "$" is not a valid JSON character by itself, it might be found inside some text strings, which could cause confusion in a case like this: 'Enter price as $123' where the $123 should not be interpreted as a macro (the intention in this text), but is with this syntax. The $(NAME) is not something that would be normal in text, and so is much less likely to be wrongly interpreted as a macro expansion. So, I think (even though it is more verbose) that I will stick to the $(NAME) syntax. Thoughts? Thanks. > Implement simple macro system in JSONSerializer > --- > > Key: PIVOT-960 > URL: https://issues.apache.org/jira/browse/PIVOT-960 > Project: Pivot > Issue Type: Improvement > Components: core-json >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1 > > Attachments: 960.patch > > > It occurred to me since we are using JSON style sheets to style our > application, and it is getting quite big, that a macro system (maybe similar > to C/C++ with #define or something similar) would be useful, especially for > repeated colors, and other constants (like padding values, fonts, etc.) This > would enable using custom values consistently while avoiding inconsistencies > due to typos or changes introduced one place and not others. > I was thinking of a simple > #define NAME value > as in C/C++, and then using $(NAME) as the substitution token. This is > easily implemented in JSONSerializer. > I'm open to suggestions for the syntax, but I believe the feature will be > very useful, especially for the JSON stylesheet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-960) Implement simple macro system in JSONSerializer
[
https://issues.apache.org/jira/browse/PIVOT-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14199177#comment-14199177
]
Roger Whitcomb commented on PIVOT-960:
--
Okay, I implemented this using "${NAME}" syntax, and did some more thorough
testing (added to the JSONSerializerTest) using an update "map.json" with a
bunch of macro definitions in it. Committed to "trunk":
Sendingcore\src\org\apache\pivot\json\JSONSerializer.java
Adding core\src\org\apache\pivot\serialization\MacroReader.java
Sendingcore\test\org\apache\pivot\json\test\JSONSerializerTest.java
Sendingcore\test\org\apache\pivot\json\test\map.json
Transmitting file data
Committed revision 1636971.
> Implement simple macro system in JSONSerializer
> ---
>
> Key: PIVOT-960
> URL: https://issues.apache.org/jira/browse/PIVOT-960
> Project: Pivot
> Issue Type: Improvement
> Components: core-json
>Affects Versions: 2.0.4
> Environment: All
>Reporter: Roger Whitcomb
>Assignee: Roger Whitcomb
>Priority: Minor
> Fix For: 2.1
>
> Attachments: 960.patch
>
>
> It occurred to me since we are using JSON style sheets to style our
> application, and it is getting quite big, that a macro system (maybe similar
> to C/C++ with #define or something similar) would be useful, especially for
> repeated colors, and other constants (like padding values, fonts, etc.) This
> would enable using custom values consistently while avoiding inconsistencies
> due to typos or changes introduced one place and not others.
> I was thinking of a simple
> #define NAME value
> as in C/C++, and then using $(NAME) as the substitution token. This is
> easily implemented in JSONSerializer.
> I'm open to suggestions for the syntax, but I believe the feature will be
> very useful, especially for the JSON stylesheet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (PIVOT-967) JSONSerializer doesn't correctly handle CR characters
Roger Whitcomb created PIVOT-967: Summary: JSONSerializer doesn't correctly handle CR characters Key: PIVOT-967 URL: https://issues.apache.org/jira/browse/PIVOT-967 Project: Pivot Issue Type: Bug Components: core-serialization Affects Versions: 2.0.4, 2.1, 2.0.5 Environment: All, but particularly Windows Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.1, 2.0.5 The JSON standard (see JSON.org) defines specific escape sequences for the following characters: \b, \f, \n, \r, \t and \u for other control characters. But the encoding logic in JSONSerializer doesn't match this list (particularly missing \r and not encoding other control characters using \u). The "writeObject" method only recognizes \t and \n and does not encode any control character less than 0xFF. The "readString" method seems a bit weird also in its handling of control characters in the input. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIVOT-967) JSONSerializer doesn't correctly handle CR characters
[ https://issues.apache.org/jira/browse/PIVOT-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-967: - Attachment: 967.patch This "967.patch" is my best guess as to the correct code. I have tried it in my fail case situation and everything appears to be correct. And I think all the comments I have added are correct as to intent and operation. > JSONSerializer doesn't correctly handle CR characters > - > > Key: PIVOT-967 > URL: https://issues.apache.org/jira/browse/PIVOT-967 > Project: Pivot > Issue Type: Bug > Components: core-serialization >Affects Versions: 2.0.4, 2.1, 2.0.5 > Environment: All, but particularly Windows >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > Attachments: 967.patch > > > The JSON standard (see JSON.org) defines specific escape sequences for the > following characters: \b, \f, \n, \r, \t and \u for other control > characters. But the encoding logic in JSONSerializer doesn't match this list > (particularly missing \r and not encoding other control characters using > \u). The "writeObject" method only recognizes \t and \n and does not > encode any control character less than 0xFF. The "readString" method seems a > bit weird also in its handling of control characters in the input. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (PIVOT-967) JSONSerializer doesn't correctly handle CR characters
[ https://issues.apache.org/jira/browse/PIVOT-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb resolved PIVOT-967. -- Resolution: Fixed I have updated the "map.json" file and JSONSerializerTest to test all these changes. Once more thing: JSONSerializer.writeObject couldn't correctly handle a java.util.Map passed in as the object, so I recognize this case now and put a MapAdapter around it. This also is tested in JSONSerializerTest. trunk: Sendingcore\src\org\apache\pivot\json\JSONSerializer.java Sendingcore\test\org\apache\pivot\json\test\JSONSerializerTest.java Sendingcore\test\org\apache\pivot\json\test\map.json Transmitting file data ... Committed revision 1675517. branches/2.0.x (merged with some Java 1.7 -> 1.6 changes): Sending. Sendingcore\src\org\apache\pivot\json\JSONSerializer.java Sendingcore\test\org\apache\pivot\json\test\JSONSerializerTest.java Sendingcore\test\org\apache\pivot\json\test\map.json Transmitting file data ... Committed revision 1675522. > JSONSerializer doesn't correctly handle CR characters > - > > Key: PIVOT-967 > URL: https://issues.apache.org/jira/browse/PIVOT-967 > Project: Pivot > Issue Type: Bug > Components: core-serialization >Affects Versions: 2.0.4, 2.1, 2.0.5 > Environment: All, but particularly Windows >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > Attachments: 967.patch > > > The JSON standard (see JSON.org) defines specific escape sequences for the > following characters: \b, \f, \n, \r, \t and \u for other control > characters. But the encoding logic in JSONSerializer doesn't match this list > (particularly missing \r and not encoding other control characters using > \u). The "writeObject" method only recognizes \t and \n and does not > encode any control character less than 0xFF. The "readString" method seems a > bit weird also in its handling of control characters in the input. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-966) UI zooming and buttons detection in Apache Pivot at program start
[ https://issues.apache.org/jira/browse/PIVOT-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530930#comment-14530930 ] Roger Whitcomb commented on PIVOT-966: -- In the Javadoc for ScaleDecorator it says this: * Decorator that scales the painting of a component along the X and/or Y axes. * Generally speaking, decorators don't force a repaint of the component(s) * they are attached to when their parameters are changed. So, if this decorator * is changed after being applied to a particular component (e.g., to do a * dynamic resize) then either the component.repaint() method must be called or * the decorator should be removed and added again to force a repaint with the * new scale. So, does it help if you attach the ScaleDecorator to the Window AFTER setting all the decorator parameters (esp. the scale factor)? Something like this: final ScaleDecorator sd = new ScaleDecorator(); sd.setHorizontalAlignment( HorizontalAlignment.LEFT ); sd.setVerticalAlignment( VerticalAlignment.TOP ); sd.setScale( 2.0f ); sd.update(); window.getDecorators().add( sd ); window.open(display); (You've probably tried this, but just wanted to check...) Thanks, ~Roger > UI zooming and buttons detection in Apache Pivot at program start > - > > Key: PIVOT-966 > URL: https://issues.apache.org/jira/browse/PIVOT-966 > Project: Pivot > Issue Type: Bug > Components: wtk-effects >Affects Versions: 2.0.4, 2.1 > Environment: Ubuntu 14.04 LTS 64bit, Oracle JDK 1.7.0-65 >Reporter: Vesa Muukka >Assignee: Sandro Martini > Fix For: 2.1, 2.0.5 > > > Zooming UI at program start wents right but all buttons responds from wrong > locations (as if the zoom/scale factor would still be the default 1.0). > This effect can be easily tested with ApachePivot > org.apache.pivot.demos.text.TextPaneDemo > by adding ScaleDecorator & setScale before window.open(display) call like > this: > > final ScaleDecorator sd = new ScaleDecorator(); > window.getDecorators().add( sd ); > sd.setHorizontalAlignment( HorizontalAlignment.LEFT ); > sd.setVerticalAlignment( VerticalAlignment.TOP ); > sd.setScale( 2.0f ); > sd.update(); > window.open(display); > textPane.requestFocus(); > } > The program UI will scale correctly the but buttons will react from wrong > locations. > There is a issue report in the pivot-user mailing list archives: March 2015 > with the same header as well with more information. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-966) UI zooming and buttons detection in Apache Pivot at program start
[ https://issues.apache.org/jira/browse/PIVOT-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531520#comment-14531520 ] Roger Whitcomb commented on PIVOT-966: -- Aha. So, my previous suggestion does not work, but this does: ... display.getDisplayHost().setScale(2.0d); window.open(display); ... No need for a ScaleDecorator, but simply scale the ApplicationContext.displayHost before opening the window. > UI zooming and buttons detection in Apache Pivot at program start > - > > Key: PIVOT-966 > URL: https://issues.apache.org/jira/browse/PIVOT-966 > Project: Pivot > Issue Type: Bug > Components: wtk-effects >Affects Versions: 2.0.4, 2.1 > Environment: Ubuntu 14.04 LTS 64bit, Oracle JDK 1.7.0-65 >Reporter: Vesa Muukka >Assignee: Sandro Martini > Fix For: 2.1, 2.0.5 > > > Zooming UI at program start wents right but all buttons responds from wrong > locations (as if the zoom/scale factor would still be the default 1.0). > This effect can be easily tested with ApachePivot > org.apache.pivot.demos.text.TextPaneDemo > by adding ScaleDecorator & setScale before window.open(display) call like > this: > > final ScaleDecorator sd = new ScaleDecorator(); > window.getDecorators().add( sd ); > sd.setHorizontalAlignment( HorizontalAlignment.LEFT ); > sd.setVerticalAlignment( VerticalAlignment.TOP ); > sd.setScale( 2.0f ); > sd.update(); > window.open(display); > textPane.requestFocus(); > } > The program UI will scale correctly the but buttons will react from wrong > locations. > There is a issue report in the pivot-user mailing list archives: March 2015 > with the same header as well with more information. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-966) UI zooming and buttons detection in Apache Pivot at program start
[ https://issues.apache.org/jira/browse/PIVOT-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532903#comment-14532903 ] Roger Whitcomb commented on PIVOT-966: -- Yes I do think some Javadoc would be good. Any suggestions as to where would be best? Thanks. > UI zooming and buttons detection in Apache Pivot at program start > - > > Key: PIVOT-966 > URL: https://issues.apache.org/jira/browse/PIVOT-966 > Project: Pivot > Issue Type: Bug > Components: wtk-effects >Affects Versions: 2.0.4, 2.1 > Environment: Ubuntu 14.04 LTS 64bit, Oracle JDK 1.7.0-65 >Reporter: Vesa Muukka >Assignee: Sandro Martini > Fix For: 2.1, 2.0.5 > > > Zooming UI at program start wents right but all buttons responds from wrong > locations (as if the zoom/scale factor would still be the default 1.0). > This effect can be easily tested with ApachePivot > org.apache.pivot.demos.text.TextPaneDemo > by adding ScaleDecorator & setScale before window.open(display) call like > this: > > final ScaleDecorator sd = new ScaleDecorator(); > window.getDecorators().add( sd ); > sd.setHorizontalAlignment( HorizontalAlignment.LEFT ); > sd.setVerticalAlignment( VerticalAlignment.TOP ); > sd.setScale( 2.0f ); > sd.update(); > window.open(display); > textPane.requestFocus(); > } > The program UI will scale correctly the but buttons will react from wrong > locations. > There is a issue report in the pivot-user mailing list archives: March 2015 > with the same header as well with more information. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (PIVOT-966) UI zooming and buttons detection in Apache Pivot at program start
[ https://issues.apache.org/jira/browse/PIVOT-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb reassigned PIVOT-966: Assignee: Roger Whitcomb (was: Sandro Martini) > UI zooming and buttons detection in Apache Pivot at program start > - > > Key: PIVOT-966 > URL: https://issues.apache.org/jira/browse/PIVOT-966 > Project: Pivot > Issue Type: Bug > Components: wtk-effects >Affects Versions: 2.0.4, 2.1 > Environment: Ubuntu 14.04 LTS 64bit, Oracle JDK 1.7.0-65 >Reporter: Vesa Muukka >Assignee: Roger Whitcomb > Fix For: 2.1, 2.0.5 > > > Zooming UI at program start wents right but all buttons responds from wrong > locations (as if the zoom/scale factor would still be the default 1.0). > This effect can be easily tested with ApachePivot > org.apache.pivot.demos.text.TextPaneDemo > by adding ScaleDecorator & setScale before window.open(display) call like > this: > > final ScaleDecorator sd = new ScaleDecorator(); > window.getDecorators().add( sd ); > sd.setHorizontalAlignment( HorizontalAlignment.LEFT ); > sd.setVerticalAlignment( VerticalAlignment.TOP ); > sd.setScale( 2.0f ); > sd.update(); > window.open(display); > textPane.requestFocus(); > } > The program UI will scale correctly the but buttons will react from wrong > locations. > There is a issue report in the pivot-user mailing list archives: March 2015 > with the same header as well with more information. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (PIVOT-966) UI zooming and buttons detection in Apache Pivot at program start
[ https://issues.apache.org/jira/browse/PIVOT-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb resolved PIVOT-966. -- Resolution: Not A Problem Using Application.DisplayHost.setScale() is the right way to do this. Going to add some Javadoc to help with understanding this use case. > UI zooming and buttons detection in Apache Pivot at program start > - > > Key: PIVOT-966 > URL: https://issues.apache.org/jira/browse/PIVOT-966 > Project: Pivot > Issue Type: Bug > Components: wtk-effects >Affects Versions: 2.0.4, 2.1 > Environment: Ubuntu 14.04 LTS 64bit, Oracle JDK 1.7.0-65 >Reporter: Vesa Muukka >Assignee: Roger Whitcomb > Fix For: 2.1, 2.0.5 > > > Zooming UI at program start wents right but all buttons responds from wrong > locations (as if the zoom/scale factor would still be the default 1.0). > This effect can be easily tested with ApachePivot > org.apache.pivot.demos.text.TextPaneDemo > by adding ScaleDecorator & setScale before window.open(display) call like > this: > > final ScaleDecorator sd = new ScaleDecorator(); > window.getDecorators().add( sd ); > sd.setHorizontalAlignment( HorizontalAlignment.LEFT ); > sd.setVerticalAlignment( VerticalAlignment.TOP ); > sd.setScale( 2.0f ); > sd.update(); > window.open(display); > textPane.requestFocus(); > } > The program UI will scale correctly the but buttons will react from wrong > locations. > There is a issue report in the pivot-user mailing list archives: March 2015 > with the same header as well with more information. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (PIVOT-966) UI zooming and buttons detection in Apache Pivot at program start
[ https://issues.apache.org/jira/browse/PIVOT-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532911#comment-14532911 ] Roger Whitcomb edited comment on PIVOT-966 at 5/7/15 4:25 PM: -- Using ApplicationContext.DisplayHost.setScale() is the right way to do this. Going to add some Javadoc to help with understanding this use case. was (Author: rwhitcomb): Using Application.DisplayHost.setScale() is the right way to do this. Going to add some Javadoc to help with understanding this use case. > UI zooming and buttons detection in Apache Pivot at program start > - > > Key: PIVOT-966 > URL: https://issues.apache.org/jira/browse/PIVOT-966 > Project: Pivot > Issue Type: Bug > Components: wtk-effects >Affects Versions: 2.0.4, 2.1 > Environment: Ubuntu 14.04 LTS 64bit, Oracle JDK 1.7.0-65 >Reporter: Vesa Muukka >Assignee: Roger Whitcomb > Fix For: 2.1, 2.0.5 > > > Zooming UI at program start wents right but all buttons responds from wrong > locations (as if the zoom/scale factor would still be the default 1.0). > This effect can be easily tested with ApachePivot > org.apache.pivot.demos.text.TextPaneDemo > by adding ScaleDecorator & setScale before window.open(display) call like > this: > > final ScaleDecorator sd = new ScaleDecorator(); > window.getDecorators().add( sd ); > sd.setHorizontalAlignment( HorizontalAlignment.LEFT ); > sd.setVerticalAlignment( VerticalAlignment.TOP ); > sd.setScale( 2.0f ); > sd.update(); > window.open(display); > textPane.requestFocus(); > } > The program UI will scale correctly the but buttons will react from wrong > locations. > There is a issue report in the pivot-user mailing list archives: March 2015 > with the same header as well with more information. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-966) UI zooming and buttons detection in Apache Pivot at program start
[ https://issues.apache.org/jira/browse/PIVOT-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533000#comment-14533000 ] Roger Whitcomb commented on PIVOT-966: -- Committed Javadoc changes: trunk: Sendingwtk/src/org/apache/pivot/wtk/ApplicationContext.java Transmitting file data . Committed revision 1678238. branches/2.0.x: Sending. Sendingwtk/src/org/apache/pivot/wtk/ApplicationContext.java Transmitting file data . Committed revision 1678239. > UI zooming and buttons detection in Apache Pivot at program start > - > > Key: PIVOT-966 > URL: https://issues.apache.org/jira/browse/PIVOT-966 > Project: Pivot > Issue Type: Bug > Components: wtk-effects >Affects Versions: 2.0.4, 2.1 > Environment: Ubuntu 14.04 LTS 64bit, Oracle JDK 1.7.0-65 >Reporter: Vesa Muukka >Assignee: Roger Whitcomb > Fix For: 2.1, 2.0.5 > > > Zooming UI at program start wents right but all buttons responds from wrong > locations (as if the zoom/scale factor would still be the default 1.0). > This effect can be easily tested with ApachePivot > org.apache.pivot.demos.text.TextPaneDemo > by adding ScaleDecorator & setScale before window.open(display) call like > this: > > final ScaleDecorator sd = new ScaleDecorator(); > window.getDecorators().add( sd ); > sd.setHorizontalAlignment( HorizontalAlignment.LEFT ); > sd.setVerticalAlignment( VerticalAlignment.TOP ); > sd.setScale( 2.0f ); > sd.update(); > window.open(display); > textPane.requestFocus(); > } > The program UI will scale correctly the but buttons will react from wrong > locations. > There is a issue report in the pivot-user mailing list archives: March 2015 > with the same header as well with more information. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-966) UI zooming and buttons detection in Apache Pivot at program start
[ https://issues.apache.org/jira/browse/PIVOT-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533168#comment-14533168 ] Roger Whitcomb commented on PIVOT-966: -- Also committed changes to TextPaneDemo.java to demonstrate the use with a "--scale=n" startup property. trunk: Sendingdemos\src\org\apache\pivot\demos\text\TextPaneDemo.java Transmitting file data . Committed revision 1678251. branches/2.0.x: Sending. Sendingdemos\src\org\apache\pivot\demos\text\TextPaneDemo.java Transmitting file data . Committed revision 1678253. > UI zooming and buttons detection in Apache Pivot at program start > - > > Key: PIVOT-966 > URL: https://issues.apache.org/jira/browse/PIVOT-966 > Project: Pivot > Issue Type: Bug > Components: wtk-effects >Affects Versions: 2.0.4, 2.1 > Environment: Ubuntu 14.04 LTS 64bit, Oracle JDK 1.7.0-65 >Reporter: Vesa Muukka >Assignee: Roger Whitcomb > Fix For: 2.1, 2.0.5 > > > Zooming UI at program start wents right but all buttons responds from wrong > locations (as if the zoom/scale factor would still be the default 1.0). > This effect can be easily tested with ApachePivot > org.apache.pivot.demos.text.TextPaneDemo > by adding ScaleDecorator & setScale before window.open(display) call like > this: > > final ScaleDecorator sd = new ScaleDecorator(); > window.getDecorators().add( sd ); > sd.setHorizontalAlignment( HorizontalAlignment.LEFT ); > sd.setVerticalAlignment( VerticalAlignment.TOP ); > sd.setScale( 2.0f ); > sd.update(); > window.open(display); > textPane.requestFocus(); > } > The program UI will scale correctly the but buttons will react from wrong > locations. > There is a issue report in the pivot-user mailing list archives: March 2015 > with the same header as well with more information. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-966) UI zooming and buttons detection in Apache Pivot at program start
[ https://issues.apache.org/jira/browse/PIVOT-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533191#comment-14533191 ] Roger Whitcomb commented on PIVOT-966: -- One more thing: using Ctrl-Shift-MouseWheel will scale the display up and down as well, for the user of your application. > UI zooming and buttons detection in Apache Pivot at program start > - > > Key: PIVOT-966 > URL: https://issues.apache.org/jira/browse/PIVOT-966 > Project: Pivot > Issue Type: Bug > Components: wtk-effects >Affects Versions: 2.0.4, 2.1 > Environment: Ubuntu 14.04 LTS 64bit, Oracle JDK 1.7.0-65 >Reporter: Vesa Muukka >Assignee: Roger Whitcomb > Fix For: 2.1, 2.0.5 > > > Zooming UI at program start wents right but all buttons responds from wrong > locations (as if the zoom/scale factor would still be the default 1.0). > This effect can be easily tested with ApachePivot > org.apache.pivot.demos.text.TextPaneDemo > by adding ScaleDecorator & setScale before window.open(display) call like > this: > > final ScaleDecorator sd = new ScaleDecorator(); > window.getDecorators().add( sd ); > sd.setHorizontalAlignment( HorizontalAlignment.LEFT ); > sd.setVerticalAlignment( VerticalAlignment.TOP ); > sd.setScale( 2.0f ); > sd.update(); > window.open(display); > textPane.requestFocus(); > } > The program UI will scale correctly the but buttons will react from wrong > locations. > There is a issue report in the pivot-user mailing list archives: March 2015 > with the same header as well with more information. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-966) UI zooming and buttons detection in Apache Pivot at program start
[ https://issues.apache.org/jira/browse/PIVOT-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1454#comment-1454 ] Roger Whitcomb commented on PIVOT-966: -- Go for it! Yes, that would be good to have instructions for the test application. > UI zooming and buttons detection in Apache Pivot at program start > - > > Key: PIVOT-966 > URL: https://issues.apache.org/jira/browse/PIVOT-966 > Project: Pivot > Issue Type: Bug > Components: wtk-effects >Affects Versions: 2.0.4, 2.1 > Environment: Ubuntu 14.04 LTS 64bit, Oracle JDK 1.7.0-65 >Reporter: Vesa Muukka >Assignee: Roger Whitcomb > Fix For: 2.1, 2.0.5 > > > Zooming UI at program start wents right but all buttons responds from wrong > locations (as if the zoom/scale factor would still be the default 1.0). > This effect can be easily tested with ApachePivot > org.apache.pivot.demos.text.TextPaneDemo > by adding ScaleDecorator & setScale before window.open(display) call like > this: > > final ScaleDecorator sd = new ScaleDecorator(); > window.getDecorators().add( sd ); > sd.setHorizontalAlignment( HorizontalAlignment.LEFT ); > sd.setVerticalAlignment( VerticalAlignment.TOP ); > sd.setScale( 2.0f ); > sd.update(); > window.open(display); > textPane.requestFocus(); > } > The program UI will scale correctly the but buttons will react from wrong > locations. > There is a issue report in the pivot-user mailing list archives: March 2015 > with the same header as well with more information. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PIVOT-968) Use try-with-resources internally now that Java 7 is required
Roger Whitcomb created PIVOT-968: Summary: Use try-with-resources internally now that Java 7 is required Key: PIVOT-968 URL: https://issues.apache.org/jira/browse/PIVOT-968 Project: Pivot Issue Type: Improvement Components: core-io, core-serialization, wtk, wtk-terra Affects Versions: 2.1 Environment: All Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.1 Java 7 introduced a "try-with-resources" statement that automatically calls the "close()" method for resources that implement the (new) AutoCloseable interface, which includes most/all I/O related objects, and more. Pivot could benefit internally with more readable / maintainable code using this construct. Since Java 7 is now required for the 2.1 (and later) releases, this is a reasonable step to upgrade the code internally (see PIVOT-895). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-895) Update requirements to Java 7
[ https://issues.apache.org/jira/browse/PIVOT-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535699#comment-14535699 ] Roger Whitcomb commented on PIVOT-895: -- Add a new issue: PIVOT-968 for try-with-resource. > Update requirements to Java 7 > - > > Key: PIVOT-895 > URL: https://issues.apache.org/jira/browse/PIVOT-895 > Project: Pivot > Issue Type: Improvement >Reporter: Sandro Martini >Assignee: Sandro Martini > Labels: build, dependencies, java > Fix For: 2.1 > > > Now that Java 6 is going in Out-of-Life (and support without paying for it) > it's time to update dependencies and require Java 7 as a minimum version to > build and run Pivot Applications. > Of course maintenance branch 2.0.x will stay with Java 6 as requirements. > Some related info: > http://www.oracle.com/technetwork/java/eol-135779.html > http://www.infoq.com/news/2012/08/ava-6-eol-extended > And then, verify if disable (not delete for now) existing jobs on Jenkins > that builds the trunk with Java 6 ... anyway they could be useful to see if > we have some incompatibility with Java 6. > Then, we can even remove few little tricks due to bugs (not fixed) in Java 6. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (PIVOT-895) Update requirements to Java 7
[ https://issues.apache.org/jira/browse/PIVOT-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535699#comment-14535699 ] Roger Whitcomb edited comment on PIVOT-895 at 5/8/15 10:11 PM: --- Added a new issue: PIVOT-968 for try-with-resource. was (Author: rwhitcomb): Add a new issue: PIVOT-968 for try-with-resource. > Update requirements to Java 7 > - > > Key: PIVOT-895 > URL: https://issues.apache.org/jira/browse/PIVOT-895 > Project: Pivot > Issue Type: Improvement >Reporter: Sandro Martini >Assignee: Sandro Martini > Labels: build, dependencies, java > Fix For: 2.1 > > > Now that Java 6 is going in Out-of-Life (and support without paying for it) > it's time to update dependencies and require Java 7 as a minimum version to > build and run Pivot Applications. > Of course maintenance branch 2.0.x will stay with Java 6 as requirements. > Some related info: > http://www.oracle.com/technetwork/java/eol-135779.html > http://www.infoq.com/news/2012/08/ava-6-eol-extended > And then, verify if disable (not delete for now) existing jobs on Jenkins > that builds the trunk with Java 6 ... anyway they could be useful to see if > we have some incompatibility with Java 6. > Then, we can even remove few little tricks due to bugs (not fixed) in Java 6. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PIVOT-969) Better handle uncaught exceptions in background threads in Pivot
Roger Whitcomb created PIVOT-969: Summary: Better handle uncaught exceptions in background threads in Pivot Key: PIVOT-969 URL: https://issues.apache.org/jira/browse/PIVOT-969 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0.4, 2.1 Environment: All Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.1 PIVOT-916 regularized the handling of uncaught exceptions in most places in the GUI thread and during startup. But background threads can still basically ignore uncaught exceptions. But using the Thread.setDefaultUncaughtExceptionHandler and changing some of our interfaces (namely Application.UncaughtExceptionHandler) we could use the ApplicationContext.handleUncaughtException as the default exception handler (which delegates to an application's override method). This would involve changing the signature (or adding an override method) that accepts (Thread, Throwable) in both ApplicationContext and Application.UncaughtExceptionHandler interface. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIVOT-969) Better handle uncaught exceptions in background threads in Pivot
[ https://issues.apache.org/jira/browse/PIVOT-969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-969: - Attachment: task.patch The file "task.patch" has what I consider a good first step for this, that doesn't break backward compatibility, and yet addresses this issue for all the standard background "Task" operations (and subclasses). Comments? Suggestions? > Better handle uncaught exceptions in background threads in Pivot > > > Key: PIVOT-969 > URL: https://issues.apache.org/jira/browse/PIVOT-969 > Project: Pivot > Issue Type: Improvement > Components: wtk >Affects Versions: 2.0.4, 2.1 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Labels: exception-reporting, uncaught-exceptions > Fix For: 2.1 > > Attachments: task.patch > > > PIVOT-916 regularized the handling of uncaught exceptions in most places in > the GUI thread and during startup. But background threads can still > basically ignore uncaught exceptions. But using the > Thread.setDefaultUncaughtExceptionHandler and changing some of our interfaces > (namely Application.UncaughtExceptionHandler) we could use the > ApplicationContext.handleUncaughtException as the default exception handler > (which delegates to an application's override method). > This would involve changing the signature (or adding an override method) that > accepts (Thread, Throwable) in both ApplicationContext and > Application.UncaughtExceptionHandler interface. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-969) Better handle uncaught exceptions in background threads in Pivot
[ https://issues.apache.org/jira/browse/PIVOT-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553173#comment-14553173 ] Roger Whitcomb commented on PIVOT-969: -- I want to run some tests to see if this patch actually has any effect. It occurred to me that where we really need the uncaught handler is way outside this realm (i.e., before the ExecuteCallback is even created, perhaps). So, I'm not sure this change will even have any effect. But I do have a fail case in our application that I can test with. > Better handle uncaught exceptions in background threads in Pivot > > > Key: PIVOT-969 > URL: https://issues.apache.org/jira/browse/PIVOT-969 > Project: Pivot > Issue Type: Improvement > Components: wtk >Affects Versions: 2.0.4, 2.1 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Labels: exception-reporting, uncaught-exceptions > Fix For: 2.1 > > Attachments: task.patch > > > PIVOT-916 regularized the handling of uncaught exceptions in most places in > the GUI thread and during startup. But background threads can still > basically ignore uncaught exceptions. But using the > Thread.setDefaultUncaughtExceptionHandler and changing some of our interfaces > (namely Application.UncaughtExceptionHandler) we could use the > ApplicationContext.handleUncaughtException as the default exception handler > (which delegates to an application's override method). > This would involve changing the signature (or adding an override method) that > accepts (Thread, Throwable) in both ApplicationContext and > Application.UncaughtExceptionHandler interface. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PIVOT-970) Add an "htmlStyle" attribute to Label and other places
Roger Whitcomb created PIVOT-970: Summary: Add an "htmlStyle" attribute to Label and other places Key: PIVOT-970 URL: https://issues.apache.org/jira/browse/PIVOT-970 Project: Pivot Issue Type: New Feature Components: wtk-terra Affects Versions: 2.0.4, 2.1 Environment: All Reporter: Roger Whitcomb Assignee: Roger Whitcomb Fix For: 2.1 It would be really cool to be able to apply some of the HTML style tags (such as , , , etc.) to text inside a Label. Then by extension things like Button.DataRenderer could inherit the same things. That way you could create buttons with interestingly styled text without having to create a bitmap. It's a lot of work inside LabelSkin but it would translate easily to other places that use Labels for rendering. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PIVOT-971) Add the ability to have tri-state checkboxes in ListView
Roger Whitcomb created PIVOT-971: Summary: Add the ability to have tri-state checkboxes in ListView Key: PIVOT-971 URL: https://issues.apache.org/jira/browse/PIVOT-971 Project: Pivot Issue Type: New Feature Components: wtk, wtk-terra Affects Versions: 2.0.4 Environment: All Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.1 For one place in our application, a ListView is used along with checkboxes, but it seems like it would be good to be able to use tri-state checkboxes here, such that a mixed state could be indicated for some entries. But, then the question becomes: if the checkbox is mixed, is it checked or not? Two thoughts on that: 1. Add a method to get the checkbox state for all items, so you can check yourself if they are checked, unchecked or mixed. 2. Add a property "mixedAreChecked", which if set true (default false) would make the mixed state entries show up as checked. Also, how do you set the "mixed" state for an item? Not sure about that yet. Altogether: lots of implications throughout the code to support this feature. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIVOT-971) Add the ability to have tri-state checkboxes in ListView
[ https://issues.apache.org/jira/browse/PIVOT-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-971: - Attachment: listview.diffs "listview.diffs" is the set of changes that seems complete to me and works well in our application. > Add the ability to have tri-state checkboxes in ListView > > > Key: PIVOT-971 > URL: https://issues.apache.org/jira/browse/PIVOT-971 > Project: Pivot > Issue Type: New Feature > Components: wtk, wtk-terra >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Labels: listview > Fix For: 2.1 > > Attachments: listview.diffs > > > For one place in our application, a ListView is used along with checkboxes, > but it seems like it would be good to be able to use tri-state checkboxes > here, such that a mixed state could be indicated for some entries. But, then > the question becomes: if the checkbox is mixed, is it checked or not? Two > thoughts on that: > 1. Add a method to get the checkbox state for all items, so you can check > yourself if they are checked, unchecked or mixed. > 2. Add a property "mixedAreChecked", which if set true (default false) would > make the mixed state entries show up as checked. > Also, how do you set the "mixed" state for an item? Not sure about that yet. > Altogether: lots of implications throughout the code to support this feature. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIVOT-971) Add the ability to have tri-state checkboxes in ListView
[ https://issues.apache.org/jira/browse/PIVOT-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-971: - Attachment: tri-state listview.png "tri-state listview" image is a partial screen shot from our application of the feature. > Add the ability to have tri-state checkboxes in ListView > > > Key: PIVOT-971 > URL: https://issues.apache.org/jira/browse/PIVOT-971 > Project: Pivot > Issue Type: New Feature > Components: wtk, wtk-terra >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Labels: listview > Fix For: 2.1 > > Attachments: listview.diffs, tri-state listview.png > > > For one place in our application, a ListView is used along with checkboxes, > but it seems like it would be good to be able to use tri-state checkboxes > here, such that a mixed state could be indicated for some entries. But, then > the question becomes: if the checkbox is mixed, is it checked or not? Two > thoughts on that: > 1. Add a method to get the checkbox state for all items, so you can check > yourself if they are checked, unchecked or mixed. > 2. Add a property "mixedAreChecked", which if set true (default false) would > make the mixed state entries show up as checked. > Also, how do you set the "mixed" state for an item? Not sure about that yet. > Altogether: lots of implications throughout the code to support this feature. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-971) Add the ability to have tri-state checkboxes in ListView
[ https://issues.apache.org/jira/browse/PIVOT-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581212#comment-14581212 ] Roger Whitcomb commented on PIVOT-971: -- Committed changes in "trunk": Adding core\src\org\apache\pivot\util\Utils.java Sendingdemos\src\org\apache\pivot\demos\rss\RSSItemRenderer.java Sendingdemos\src\org\apache\pivot\demos\text\TextPaneDemo.java Sendingtests\src\org\apache\pivot\tests\DataBindingTest.java Sending tutorials\src\org\apache\pivot\tutorials\webqueries\ResultItemRenderer.java Sendingwtk\src\org\apache\pivot\wtk\ListView.java Sendingwtk\src\org\apache\pivot\wtk\ListViewBindingListener.java Sendingwtk\src\org\apache\pivot\wtk\ListViewItemStateListener.java Sendingwtk\src\org\apache\pivot\wtk\ListViewListener.java Sending wtk\src\org\apache\pivot\wtk\content\ListViewColorItemRenderer.java Sendingwtk\src\org\apache\pivot\wtk\content\ListViewItemEditor.java Sendingwtk\src\org\apache\pivot\wtk\content\ListViewItemRenderer.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFileBrowserSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraListViewSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraVFSBrowserSkin.java Transmitting file data ... Committed revision 1684795. > Add the ability to have tri-state checkboxes in ListView > > > Key: PIVOT-971 > URL: https://issues.apache.org/jira/browse/PIVOT-971 > Project: Pivot > Issue Type: New Feature > Components: wtk, wtk-terra >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Labels: listview > Fix For: 2.1 > > Attachments: listview.diffs, tri-state listview.png > > > For one place in our application, a ListView is used along with checkboxes, > but it seems like it would be good to be able to use tri-state checkboxes > here, such that a mixed state could be indicated for some entries. But, then > the question becomes: if the checkbox is mixed, is it checked or not? Two > thoughts on that: > 1. Add a method to get the checkbox state for all items, so you can check > yourself if they are checked, unchecked or mixed. > 2. Add a property "mixedAreChecked", which if set true (default false) would > make the mixed state entries show up as checked. > Also, how do you set the "mixed" state for an item? Not sure about that yet. > Altogether: lots of implications throughout the code to support this feature. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIVOT-969) Better handle uncaught exceptions in background threads in Pivot
[ https://issues.apache.org/jira/browse/PIVOT-969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-969: - Attachment: handler.diffs "handler.diffs" is another change that does break backward-compatibility, but basically allows the Application.UncaughtExceptionHandler to serve as a Thread.UncaughtExceptionHandler. > Better handle uncaught exceptions in background threads in Pivot > > > Key: PIVOT-969 > URL: https://issues.apache.org/jira/browse/PIVOT-969 > Project: Pivot > Issue Type: Improvement > Components: wtk >Affects Versions: 2.0.4, 2.1 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Labels: exception-reporting, uncaught-exceptions > Fix For: 2.1 > > Attachments: handler.diffs, task.patch > > > PIVOT-916 regularized the handling of uncaught exceptions in most places in > the GUI thread and during startup. But background threads can still > basically ignore uncaught exceptions. But using the > Thread.setDefaultUncaughtExceptionHandler and changing some of our interfaces > (namely Application.UncaughtExceptionHandler) we could use the > ApplicationContext.handleUncaughtException as the default exception handler > (which delegates to an application's override method). > This would involve changing the signature (or adding an override method) that > accepts (Thread, Throwable) in both ApplicationContext and > Application.UncaughtExceptionHandler interface. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-969) Better handle uncaught exceptions in background threads in Pivot
[ https://issues.apache.org/jira/browse/PIVOT-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581261#comment-14581261 ] Roger Whitcomb commented on PIVOT-969: -- Checked in this latest change (only) to trunk: Sendingwtk\src\org\apache\pivot\wtk\Application.java Sendingwtk\src\org\apache\pivot\wtk\ApplicationContext.java Transmitting file data .. Committed revision 1684799. > Better handle uncaught exceptions in background threads in Pivot > > > Key: PIVOT-969 > URL: https://issues.apache.org/jira/browse/PIVOT-969 > Project: Pivot > Issue Type: Improvement > Components: wtk >Affects Versions: 2.0.4, 2.1 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Labels: exception-reporting, uncaught-exceptions > Fix For: 2.1 > > Attachments: handler.diffs, task.patch > > > PIVOT-916 regularized the handling of uncaught exceptions in most places in > the GUI thread and during startup. But background threads can still > basically ignore uncaught exceptions. But using the > Thread.setDefaultUncaughtExceptionHandler and changing some of our interfaces > (namely Application.UncaughtExceptionHandler) we could use the > ApplicationContext.handleUncaughtException as the default exception handler > (which delegates to an application's override method). > This would involve changing the signature (or adding an override method) that > accepts (Thread, Throwable) in both ApplicationContext and > Application.UncaughtExceptionHandler interface. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIVOT-968) Use try-with-resources internally now that Java 7 is required
[ https://issues.apache.org/jira/browse/PIVOT-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-968: - Attachment: resources.diffs "resources.diffs" shows a start at using try-with-resources in some of the Pivot code (but only applicable to "trunk" that is built with Java 7). > Use try-with-resources internally now that Java 7 is required > - > > Key: PIVOT-968 > URL: https://issues.apache.org/jira/browse/PIVOT-968 > Project: Pivot > Issue Type: Improvement > Components: core-io, core-serialization, wtk, wtk-terra >Affects Versions: 2.1 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1 > > Attachments: resources.diffs > > > Java 7 introduced a "try-with-resources" statement that automatically calls > the "close()" method for resources that implement the (new) AutoCloseable > interface, which includes most/all I/O related objects, and more. Pivot > could benefit internally with more readable / maintainable code using this > construct. Since Java 7 is now required for the 2.1 (and later) releases, > this is a reasonable step to upgrade the code internally (see PIVOT-895). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-968) Use try-with-resources internally now that Java 7 is required
[ https://issues.apache.org/jira/browse/PIVOT-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581276#comment-14581276 ] Roger Whitcomb commented on PIVOT-968: -- Committed these changes in "trunk": Sending tutorials\src\org\apache\pivot\tutorials\bxmlexplorer\BXMLExplorerDocument.java Sending tutorials\src\org\apache\pivot\tutorials\databinding\DataBinding.java Sendingweb\src\org\apache\pivot\web\Query.java Sendingweb-server\src\org\apache\pivot\web\server\ProxyServlet.java Sendingweb-server\src\org\apache\pivot\web\server\QueryServlet.java Sendingwtk\src\org\apache\pivot\wtk\ApplicationContext.java Sendingwtk\src\org\apache\pivot\wtk\TextArea.java Sendingwtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraTheme.java Transmitting file data Committed revision 1684802. > Use try-with-resources internally now that Java 7 is required > - > > Key: PIVOT-968 > URL: https://issues.apache.org/jira/browse/PIVOT-968 > Project: Pivot > Issue Type: Improvement > Components: core-io, core-serialization, wtk, wtk-terra >Affects Versions: 2.1 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1 > > Attachments: resources.diffs > > > Java 7 introduced a "try-with-resources" statement that automatically calls > the "close()" method for resources that implement the (new) AutoCloseable > interface, which includes most/all I/O related objects, and more. Pivot > could benefit internally with more readable / maintainable code using this > construct. Since Java 7 is now required for the 2.1 (and later) releases, > this is a reasonable step to upgrade the code internally (see PIVOT-895). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-969) Better handle uncaught exceptions in background threads in Pivot
[ https://issues.apache.org/jira/browse/PIVOT-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582336#comment-14582336 ] Roger Whitcomb commented on PIVOT-969: -- Ooops! Build was broken. Fix that and do some more rearranging: Sendingwtk\src\org\apache\pivot\wtk\ApplicationContext.java Sendingwtk\src\org\apache\pivot\wtk\BrowserApplicationContext.java Sendingwtk\src\org\apache\pivot\wtk\DesktopApplicationContext.java Transmitting file data ... Committed revision 1684960. > Better handle uncaught exceptions in background threads in Pivot > > > Key: PIVOT-969 > URL: https://issues.apache.org/jira/browse/PIVOT-969 > Project: Pivot > Issue Type: Improvement > Components: wtk >Affects Versions: 2.0.4, 2.1 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Labels: exception-reporting, uncaught-exceptions > Fix For: 2.1 > > Attachments: handler.diffs, task.patch > > > PIVOT-916 regularized the handling of uncaught exceptions in most places in > the GUI thread and during startup. But background threads can still > basically ignore uncaught exceptions. But using the > Thread.setDefaultUncaughtExceptionHandler and changing some of our interfaces > (namely Application.UncaughtExceptionHandler) we could use the > ApplicationContext.handleUncaughtException as the default exception handler > (which delegates to an application's override method). > This would involve changing the signature (or adding an override method) that > accepts (Thread, Throwable) in both ApplicationContext and > Application.UncaughtExceptionHandler interface. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PIVOT-972) Add another small tutorial (calculator app)
Roger Whitcomb created PIVOT-972: Summary: Add another small tutorial (calculator app) Key: PIVOT-972 URL: https://issues.apache.org/jira/browse/PIVOT-972 Project: Pivot Issue Type: Improvement Components: tutorials Affects Versions: 2.0.4 Environment: All Reporter: Roger Whitcomb Priority: Minor Fix For: 2.1, 2.0.5 Wanting to demonstrate keyboard and action mapping paradigms via a calculator application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIVOT-972) Add another small tutorial (calculator app)
[ https://issues.apache.org/jira/browse/PIVOT-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-972: - Attachment: Pivot-Calculator-Concept.png The "Pivot-Calculator-Concept" picture is what I have in mind to implement as a small tutorial. > Add another small tutorial (calculator app) > --- > > Key: PIVOT-972 > URL: https://issues.apache.org/jira/browse/PIVOT-972 > Project: Pivot > Issue Type: Improvement > Components: tutorials >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > Attachments: Pivot-Calculator-Concept.png > > > Wanting to demonstrate keyboard and action mapping paradigms via a calculator > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-972) Add another small tutorial (calculator app)
[ https://issues.apache.org/jira/browse/PIVOT-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603781#comment-14603781 ] Roger Whitcomb commented on PIVOT-972: -- Add the new directory: svn mkdir -m "Adding a new calculator directory to Pivot tutorials." https://svn.apache.org/repos/asf/pivot/trunk/tutorials/src/org/apache/pivot/tutorials/calculator Committed revision 1687873. In trunk: SendingLICENSE Adding tutorials/src/org/apache/pivot/tutorials/calculator/Calculator.java Adding (bin) tutorials/src/org/apache/pivot/tutorials/calculator/asterisk_orange.png Adding tutorials/src/org/apache/pivot/tutorials/calculator/calculator.bxml Adding tutorials/src/org/apache/pivot/tutorials/calculator/calculator_styles.json Sendingwtk/src/org/apache/pivot/wtk/Keyboard.java Transmitting file data .. Committed revision 1687874. See the commit message for 1687874 for details on what (I see) is still left to do here. > Add another small tutorial (calculator app) > --- > > Key: PIVOT-972 > URL: https://issues.apache.org/jira/browse/PIVOT-972 > Project: Pivot > Issue Type: Improvement > Components: tutorials >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > Attachments: Pivot-Calculator-Concept.png > > > Wanting to demonstrate keyboard and action mapping paradigms via a calculator > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-972) Add another small tutorial (calculator app)
[ https://issues.apache.org/jira/browse/PIVOT-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606395#comment-14606395 ] Roger Whitcomb commented on PIVOT-972: -- Fixed a bug with the percent calculations. Sendingorg/apache/pivot/tutorials/calculator/Calculator.java Transmitting file data . Committed revision 1688306. > Add another small tutorial (calculator app) > --- > > Key: PIVOT-972 > URL: https://issues.apache.org/jira/browse/PIVOT-972 > Project: Pivot > Issue Type: Improvement > Components: tutorials >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > Attachments: Pivot-Calculator-Concept.png > > > Wanting to demonstrate keyboard and action mapping paradigms via a calculator > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-972) Add another small tutorial (calculator app)
[ https://issues.apache.org/jira/browse/PIVOT-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608645#comment-14608645 ] Roger Whitcomb commented on PIVOT-972: -- Fix a few more bugs: Sendingorg/apache/pivot/tutorials/calculator/Calculator.java Sendingorg/apache/pivot/tutorials/calculator/calculator_styles.json Transmitting file data .. Committed revision 1688484. > Add another small tutorial (calculator app) > --- > > Key: PIVOT-972 > URL: https://issues.apache.org/jira/browse/PIVOT-972 > Project: Pivot > Issue Type: Improvement > Components: tutorials >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > Attachments: Pivot-Calculator-Concept.png > > > Wanting to demonstrate keyboard and action mapping paradigms via a calculator > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-964) Changes in SVG viewBox attribute causes SVG not to render.
[ https://issues.apache.org/jira/browse/PIVOT-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609019#comment-14609019 ] Roger Whitcomb commented on PIVOT-964: -- I have just now tried a few things, and made a variable value for the view box offset (instead of 800), and it seems to work correctly for any value up to 507, then at 508 it disappears (on my screen resolution at least). Must be an overflow or something like that. Will try to investigate further Seems like an odd value, though. I will check in the updated Pivot sample code a little later. > Changes in SVG viewBox attribute causes SVG not to render. > -- > > Key: PIVOT-964 > URL: https://issues.apache.org/jira/browse/PIVOT-964 > Project: Pivot > Issue Type: Bug >Affects Versions: 2.0.4 > Environment: Windows 7, Java 1.7, Eclipse, Pivot 2.0.4, svgSalamander >Reporter: João Martins >Assignee: Sandro Martini > Labels: svgSalamander > Fix For: 2.1, 2.0.5 > > Attachments: TestClient2.java, TestClient3.java > > > We try to display a simple SVG file with a rect of width 2000 and height > 1000. This is done using an ImageView. > We have two values of viewBox, both of which capture at least part of the > rectangle. For one of them, the rectangle is rendered. For the other, it > isn't (but should). > The exact same scenario, using svgSalamander & Java Swing, works. With Pivot > instead of Swing, it does not. > Here is a Swing minimal example: http://pastebin.com/i0xJbUTg > Here is a Pivot minimal example: http://pastebin.com/tpgnVe0c -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-964) Changes in SVG viewBox attribute causes SVG not to render.
[ https://issues.apache.org/jira/browse/PIVOT-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609039#comment-14609039 ] Roger Whitcomb commented on PIVOT-964: -- Likewise, if you set the y offset to 269 it will work, but 270 makes it go invisible. So, any X offset less than 508 or any Y offset less than 270 is fine. Investigating further. > Changes in SVG viewBox attribute causes SVG not to render. > -- > > Key: PIVOT-964 > URL: https://issues.apache.org/jira/browse/PIVOT-964 > Project: Pivot > Issue Type: Bug >Affects Versions: 2.0.4 > Environment: Windows 7, Java 1.7, Eclipse, Pivot 2.0.4, svgSalamander >Reporter: João Martins >Assignee: Sandro Martini > Labels: svgSalamander > Fix For: 2.1, 2.0.5 > > Attachments: TestClient2.java, TestClient3.java > > > We try to display a simple SVG file with a rect of width 2000 and height > 1000. This is done using an ImageView. > We have two values of viewBox, both of which capture at least part of the > rectangle. For one of them, the rectangle is rendered. For the other, it > isn't (but should). > The exact same scenario, using svgSalamander & Java Swing, works. With Pivot > instead of Swing, it does not. > Here is a Swing minimal example: http://pastebin.com/i0xJbUTg > Here is a Pivot minimal example: http://pastebin.com/tpgnVe0c -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-964) Changes in SVG viewBox attribute causes SVG not to render.
[ https://issues.apache.org/jira/browse/PIVOT-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609132#comment-14609132 ] Roger Whitcomb commented on PIVOT-964: -- Made changes (in trunk) to the test case program: Sendingorg\apache\pivot\tests\issues\pivot964\Pivot964Pivot.java Transmitting file data . Committed revision 1688523. Merged to branches/2.0.x: Sending. Sending tests\src\org\apache\pivot\tests\issues\pivot964\Pivot964Pivot.java Transmitting file data . Committed revision 1688524. > Changes in SVG viewBox attribute causes SVG not to render. > -- > > Key: PIVOT-964 > URL: https://issues.apache.org/jira/browse/PIVOT-964 > Project: Pivot > Issue Type: Bug >Affects Versions: 2.0.4 > Environment: Windows 7, Java 1.7, Eclipse, Pivot 2.0.4, svgSalamander >Reporter: João Martins >Assignee: Sandro Martini > Labels: svgSalamander > Fix For: 2.1, 2.0.5 > > Attachments: TestClient2.java, TestClient3.java > > > We try to display a simple SVG file with a rect of width 2000 and height > 1000. This is done using an ImageView. > We have two values of viewBox, both of which capture at least part of the > rectangle. For one of them, the rectangle is rendered. For the other, it > isn't (but should). > The exact same scenario, using svgSalamander & Java Swing, works. With Pivot > instead of Swing, it does not. > Here is a Swing minimal example: http://pastebin.com/i0xJbUTg > Here is a Pivot minimal example: http://pastebin.com/tpgnVe0c -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-964) Changes in SVG viewBox attribute causes SVG not to render.
[ https://issues.apache.org/jira/browse/PIVOT-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609543#comment-14609543 ] Roger Whitcomb commented on PIVOT-964: -- Oops! Fixed the Java 6 compile errors in branches/2.0.x: Sendingsrc/org/apache/pivot/tests/issues/pivot964/Pivot964Pivot.java Transmitting file data . Committed revision 1688550. > Changes in SVG viewBox attribute causes SVG not to render. > -- > > Key: PIVOT-964 > URL: https://issues.apache.org/jira/browse/PIVOT-964 > Project: Pivot > Issue Type: Bug >Affects Versions: 2.0.4 > Environment: Windows 7, Java 1.7, Eclipse, Pivot 2.0.4, svgSalamander >Reporter: João Martins >Assignee: Sandro Martini > Labels: svgSalamander > Fix For: 2.1, 2.0.5 > > Attachments: TestClient2.java, TestClient3.java > > > We try to display a simple SVG file with a rect of width 2000 and height > 1000. This is done using an ImageView. > We have two values of viewBox, both of which capture at least part of the > rectangle. For one of them, the rectangle is rendered. For the other, it > isn't (but should). > The exact same scenario, using svgSalamander & Java Swing, works. With Pivot > instead of Swing, it does not. > Here is a Swing minimal example: http://pastebin.com/i0xJbUTg > Here is a Pivot minimal example: http://pastebin.com/tpgnVe0c -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-949) bxml:script using js file (absolute path) doesn't work
[
https://issues.apache.org/jira/browse/PIVOT-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617030#comment-14617030
]
Roger Whitcomb commented on PIVOT-949:
--
I think I may know the underlying reason for this, after getting a similar
error in one of our BXML files that had this script in it:
importClass(org.apache.pivot.wtk.Button);
function isSelected(state) {
return state == Button.State.SELECTED;
}
We would get an error with Java 8 (but not with Java 7): "Mapping function
"isSelected" is not defined.".
After much debugging and research I found several resources that helped to fix
the problem:
https://wiki.openjdk.java.net/display/Nashorn/Rhino+Migration+Guide
It turns out that the new Nashorn script engine in Java 8 does not directly
support the Rhino function "importClass". Instead you need to load a
compatibility script first:
try {
load("nashorn:mozilla_compat.js");
} catch (exception) { }
There is also a difference in the way the global namespace is stored under
Nashorn. So, I am preparing a patch to BXMLSerializer to fix this. This will
do two things:
1) If "nashorn" is detected as the script engine, run this script fragment
before any user scripts so that "importClass()" and etc. are available (to
maintain backward compatibility).
2) Do the namespace switching (basically load the "nashorn.global" element into
the script GLOBAL_SCOPE before invoking functions).
I will have a separate patch for this in a couple of hours after I finish
testing with my application.
I have no comment, however, on your proposed patch, Sandro. If it helps,
great, but I suspect this other problem I have just described is also causing
problems.
> bxml:script using js file (absolute path) doesn't work
> --
>
> Key: PIVOT-949
> URL: https://issues.apache.org/jira/browse/PIVOT-949
> Project: Pivot
> Issue Type: Bug
> Components: core-serialization
>Affects Versions: 2.0.3, 2.0.4
> Environment: Windows 7
> Java 7 Update 67, Java 8 Update 20
>Reporter: Said SAID EL IMAM
>Assignee: Sandro Martini
> Labels: java7, java8, javascript
> Fix For: 2.1, 2.0.5
>
> Attachments: PIVOT-949_patch1.patch
>
>
> Hi,
> I use in my bxml files lines like:
>
> which loads some variables that I can use in the file by calling them like
> $icon
> But when using a Java version higher than 6, I get this error:
> org.apache.pivot.serialization.SerializationException: Value "icon" is not
> defined.
> at
> org.apache.pivot.beans.BXMLSerializer.processAttributes(BXMLSerializer.java:1093)
> at
> org.apache.pivot.beans.BXMLSerializer.processStartElement(BXMLSerializer.java:819)
> at
> org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:443)
> at
> org.apache.pivot.beans.BXMLSerializer.processStartElement(BXMLSerializer.java:910)
> at
> org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:443)
> at
> org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:634)
> at
> org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:607)
> at dcp.main.gui.pivot.Master.startup(Master.java:190)
> at
> org.apache.pivot.wtk.DesktopApplicationContext$2.run(DesktopApplicationContext.java:641)
> at
> org.apache.pivot.wtk.ApplicationContext$QueuedCallback.run(ApplicationContext.java:1607)
> at java.awt.event.InvocationEvent.dispatch(Unknown Source)
> at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
> at java.awt.EventQueue.access$400(Unknown Source)
> at java.awt.EventQueue$3.run(Unknown Source)
> at java.awt.EventQueue$3.run(Unknown Source)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown
> Source)
> at java.awt.EventQueue.dispatchEvent(Unknown Source)
> at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
> at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
> at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
> at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
> at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
> at java.awt.EventDispatchThread.run(Unknown Source)
> And my application shows a popup window with the message:
> Value "icon" is not defined.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIVOT-949) bxml:script using js file (absolute path) doesn't work
[ https://issues.apache.org/jira/browse/PIVOT-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617133#comment-14617133 ] Roger Whitcomb commented on PIVOT-949: -- Here is the reference from which I was able to figure out the use of the "nashorn.global" namespace: https://wiki.openjdk.java.net/display/Nashorn/Nashorn+jsr223+engine+notes > bxml:script using js file (absolute path) doesn't work > -- > > Key: PIVOT-949 > URL: https://issues.apache.org/jira/browse/PIVOT-949 > Project: Pivot > Issue Type: Bug > Components: core-serialization >Affects Versions: 2.0.3, 2.0.4 > Environment: Windows 7 > Java 7 Update 67, Java 8 Update 20 >Reporter: Said SAID EL IMAM >Assignee: Sandro Martini > Labels: java7, java8, javascript > Fix For: 2.1, 2.0.5 > > Attachments: PIVOT-949_patch1.patch > > > Hi, > I use in my bxml files lines like: > > which loads some variables that I can use in the file by calling them like > $icon > But when using a Java version higher than 6, I get this error: > org.apache.pivot.serialization.SerializationException: Value "icon" is not > defined. > at > org.apache.pivot.beans.BXMLSerializer.processAttributes(BXMLSerializer.java:1093) > at > org.apache.pivot.beans.BXMLSerializer.processStartElement(BXMLSerializer.java:819) > at > org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:443) > at > org.apache.pivot.beans.BXMLSerializer.processStartElement(BXMLSerializer.java:910) > at > org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:443) > at > org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:634) > at > org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:607) > at dcp.main.gui.pivot.Master.startup(Master.java:190) > at > org.apache.pivot.wtk.DesktopApplicationContext$2.run(DesktopApplicationContext.java:641) > at > org.apache.pivot.wtk.ApplicationContext$QueuedCallback.run(ApplicationContext.java:1607) > at java.awt.event.InvocationEvent.dispatch(Unknown Source) > at java.awt.EventQueue.dispatchEventImpl(Unknown Source) > at java.awt.EventQueue.access$400(Unknown Source) > at java.awt.EventQueue$3.run(Unknown Source) > at java.awt.EventQueue$3.run(Unknown Source) > at java.security.AccessController.doPrivileged(Native Method) > at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown > Source) > at java.awt.EventQueue.dispatchEvent(Unknown Source) > at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) > at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) > at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) > at java.awt.EventDispatchThread.pumpEvents(Unknown Source) > at java.awt.EventDispatchThread.pumpEvents(Unknown Source) > at java.awt.EventDispatchThread.run(Unknown Source) > And my application shows a popup window with the message: > Value "icon" is not defined. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-949) bxml:script using js file (absolute path) doesn't work
[ https://issues.apache.org/jira/browse/PIVOT-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630353#comment-14630353 ] Roger Whitcomb commented on PIVOT-949: -- Yes, I am now officially totally confused. With my changes (apparently) working, I tried tidying up the code for commit and then it stopped working. Now I cannot get back to working code. The error I'm getting has to do with lack of permission to access the "user.dir" property, from deep inside the Nashorn code trying to load the "nashorn:mozilla_compat.js". It is (apparently) trying to construct a File object from this string, which is dumb, since it is a resource in the nashorn.jar file. And why it doesn't have permission to access "user.dir" property is a mystery to me, since all my other (signed jar) code DOES have permission. I will come back to this in a couple of weeks (after vacation). > bxml:script using js file (absolute path) doesn't work > -- > > Key: PIVOT-949 > URL: https://issues.apache.org/jira/browse/PIVOT-949 > Project: Pivot > Issue Type: Bug > Components: core-serialization >Affects Versions: 2.0.3, 2.0.4 > Environment: Windows 7 > Java 7 Update 67, Java 8 Update 20 >Reporter: Said SAID EL IMAM >Assignee: Sandro Martini > Labels: java7, java8, javascript > Fix For: 2.1, 2.0.5 > > Attachments: PIVOT-949_patch1.patch > > > Hi, > I use in my bxml files lines like: > > which loads some variables that I can use in the file by calling them like > $icon > But when using a Java version higher than 6, I get this error: > org.apache.pivot.serialization.SerializationException: Value "icon" is not > defined. > at > org.apache.pivot.beans.BXMLSerializer.processAttributes(BXMLSerializer.java:1093) > at > org.apache.pivot.beans.BXMLSerializer.processStartElement(BXMLSerializer.java:819) > at > org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:443) > at > org.apache.pivot.beans.BXMLSerializer.processStartElement(BXMLSerializer.java:910) > at > org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:443) > at > org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:634) > at > org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:607) > at dcp.main.gui.pivot.Master.startup(Master.java:190) > at > org.apache.pivot.wtk.DesktopApplicationContext$2.run(DesktopApplicationContext.java:641) > at > org.apache.pivot.wtk.ApplicationContext$QueuedCallback.run(ApplicationContext.java:1607) > at java.awt.event.InvocationEvent.dispatch(Unknown Source) > at java.awt.EventQueue.dispatchEventImpl(Unknown Source) > at java.awt.EventQueue.access$400(Unknown Source) > at java.awt.EventQueue$3.run(Unknown Source) > at java.awt.EventQueue$3.run(Unknown Source) > at java.security.AccessController.doPrivileged(Native Method) > at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown > Source) > at java.awt.EventQueue.dispatchEvent(Unknown Source) > at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) > at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) > at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) > at java.awt.EventDispatchThread.pumpEvents(Unknown Source) > at java.awt.EventDispatchThread.pumpEvents(Unknown Source) > at java.awt.EventDispatchThread.run(Unknown Source) > And my application shows a popup window with the message: > Value "icon" is not defined. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-949) bxml:script using js file (absolute path) doesn't work
[ https://issues.apache.org/jira/browse/PIVOT-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630559#comment-14630559 ] Roger Whitcomb commented on PIVOT-949: -- Yes, I think that would be wise: resolve this issue and we'll make a new issue for the nashorn-related bugs. > bxml:script using js file (absolute path) doesn't work > -- > > Key: PIVOT-949 > URL: https://issues.apache.org/jira/browse/PIVOT-949 > Project: Pivot > Issue Type: Bug > Components: core-serialization >Affects Versions: 2.0.3, 2.0.4 > Environment: Windows 7 > Java 7 Update 67, Java 8 Update 20 >Reporter: Said SAID EL IMAM >Assignee: Sandro Martini > Labels: java7, java8, javascript > Fix For: 2.1, 2.0.5 > > Attachments: PIVOT-949_patch1.patch > > > Hi, > I use in my bxml files lines like: > > which loads some variables that I can use in the file by calling them like > $icon > But when using a Java version higher than 6, I get this error: > org.apache.pivot.serialization.SerializationException: Value "icon" is not > defined. > at > org.apache.pivot.beans.BXMLSerializer.processAttributes(BXMLSerializer.java:1093) > at > org.apache.pivot.beans.BXMLSerializer.processStartElement(BXMLSerializer.java:819) > at > org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:443) > at > org.apache.pivot.beans.BXMLSerializer.processStartElement(BXMLSerializer.java:910) > at > org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:443) > at > org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:634) > at > org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:607) > at dcp.main.gui.pivot.Master.startup(Master.java:190) > at > org.apache.pivot.wtk.DesktopApplicationContext$2.run(DesktopApplicationContext.java:641) > at > org.apache.pivot.wtk.ApplicationContext$QueuedCallback.run(ApplicationContext.java:1607) > at java.awt.event.InvocationEvent.dispatch(Unknown Source) > at java.awt.EventQueue.dispatchEventImpl(Unknown Source) > at java.awt.EventQueue.access$400(Unknown Source) > at java.awt.EventQueue$3.run(Unknown Source) > at java.awt.EventQueue$3.run(Unknown Source) > at java.security.AccessController.doPrivileged(Native Method) > at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown > Source) > at java.awt.EventQueue.dispatchEvent(Unknown Source) > at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) > at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) > at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) > at java.awt.EventDispatchThread.pumpEvents(Unknown Source) > at java.awt.EventDispatchThread.pumpEvents(Unknown Source) > at java.awt.EventDispatchThread.run(Unknown Source) > And my application shows a popup window with the message: > Value "icon" is not defined. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-799) extending Pivot collections with Monads and functional methods
[ https://issues.apache.org/jira/browse/PIVOT-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631515#comment-14631515 ] Roger Whitcomb commented on PIVOT-799: -- Still getting these warnings with your latest changes: [javac] c:\Projects\pivot\trunk\core\src\org\apache\pivot\functional\monad\OptionCompanion.java:33: warning: [unchecked] unchecked conversion [javac] return INSTANCE; [javac]^ [javac] required: OptionCompanion [javac] found:OptionCompanion [javac] where T is a type-variable: [javac] T extends Object declared in method getInstance() [javac] c:\Projects\pivot\trunk\core\src\org\apache\pivot\functional\monad\TryCompanion.java:33: warning: [unchecked] unchecked conversion [javac] return INSTANCE; [javac]^ [javac] required: TryCompanion [javac] found:TryCompanion [javac] where T is a type-variable: [javac] T extends Object declared in method getInstance() [javac] 2 warnings > extending Pivot collections with Monads and functional methods > -- > > Key: PIVOT-799 > URL: https://issues.apache.org/jira/browse/PIVOT-799 > Project: Pivot > Issue Type: Improvement > Components: core-collections >Reporter: Sandro Martini >Assignee: Sandro Martini >Priority: Minor > Fix For: 2.1 > > Attachments: Monad_sample_revised.groovy, > PIVOT-799_functions_and_options(initial).patch > > > Add some usuful methods to Pivot Collections like those needed to process all > elements, going more "function style", like addAll, contains, etc ... > To simplify usage from people coming from other languages, try to align to > other languages names/conventions (for what is possible) , like Scala, C# . > Verify even if add a interface (defining a single method) that could be > passed to some methods to contain logic for processing all elements (like the > apply() in Scala), and chose a right name for it (maybe function or other > similar). > Some info here: > http://apache-pivot-developers.417237.n3.nabble.com/Some-idea-on-extending-Pivot-collections-td3321472.html > But for more changes in Collections (still to be discussed), wait the 3.0 ... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-965) Java 8 BXML scripting security issues in Apache Pivot RIAs
[ https://issues.apache.org/jira/browse/PIVOT-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631577#comment-14631577 ] Roger Whitcomb commented on PIVOT-965: -- I believe this is related to the new Java security guidelines. There are some Nashorn-related changes that are necessary, but they probably won't address this issue. Karel, are you using signed .jar files in your RIA? > Java 8 BXML scripting security issues in Apache Pivot RIAs > -- > > Key: PIVOT-965 > URL: https://issues.apache.org/jira/browse/PIVOT-965 > Project: Pivot > Issue Type: Bug > Components: core-serialization >Affects Versions: 2.0.4 > Environment: Windows, Sun JRE 64-bit 1.8.0_31b13 >Reporter: Karel Hübl >Assignee: Sandro Martini > Labels: java8, jdk8 > Fix For: 2.1, 2.0.5 > > > We encounter security issues in our pivot application after upgrading to JRE > 1.8. The application is deployed as RIA using Java Web Start. > I found out, that the problem is connected with nashorn script engine which > replaced rhino script engine from previous java version. BXMLSerializer is > using ScriptEngine to evaluate scripts in BXML files. It seems, that all > calls initiated from BXML scripts, are considered untrusted in JRE 1.8 RIA > Environment - this means security dialogs and exceptions are thrown, when > trying execute privileged actions (network communication, reflection ...). > Currently, I am not sure, if this is Pivot or Nashorn bug, but it is problem > for current Apache Pivot RIAs. To investigate the srcipting behaviour in > RIAs, I created testing non Pivot project > https://github.com/kaja78/jnlpScripting The project contains testing > application, which is deployed as JWS. When you execute the java web start > app in JRE 1.8, the security dialog is displayed when testing method is > executed from nashorn script engine (if you press cancel button on security > dialog, you get SecurityException). When you uncomment 2 lines in > Webcontent/jnlpScripting.jnlp file, rhino script engine is used instead of > nashorn and no security dialog is displayed. This fix works also for our > Pivot RIAs. > I believe, Pivot should work in JRE 1.8 RIA Environment without security > issues by default, so it should be fixed somehow in Pivot - may be, by > correct ScriptEngine configuration in BXMLSerializer or by including Rhino > libraries in Pivot distribution. Any idea how to "correctly" fix this issue? > Btw.: I found this bug: http://bugs.java.com/view_bug.do?bug_id=8045075 I am > not sure, if it is the same problem. But anyway, it should be fixed in > 1.8.25.b01 and we are encountering above issues in latest 1.8.0.31.b13. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PIVOT-974) Use of "importClass" or "importPackage" function in Javascript within BXML files won't work under Java 8 Nashorn script engine
Roger Whitcomb created PIVOT-974:
Summary: Use of "importClass" or "importPackage" function in
Javascript within BXML files won't work under Java 8 Nashorn script engine
Key: PIVOT-974
URL: https://issues.apache.org/jira/browse/PIVOT-974
Project: Pivot
Issue Type: Bug
Components: core-serialization
Affects Versions: 2.1
Environment: All
Reporter: Roger Whitcomb
Assignee: Roger Whitcomb
Priority: Critical
Fix For: 2.1
A small script such as this in a BXML file now will not work in Java 8:
importClass(org.apache.pivot.wtk.Button);
function isSelected(state) {
return state == Button.State.SELECTED;
}
The reason is that the "importClass" function is not present in the base
Nashorn engine, but is provided by a compatibility library: "mozilla_compat.js".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (PIVOT-974) Use of "importClass" or "importPackage" function in Javascript within BXML files won't work under Java 8 Nashorn script engine
[
https://issues.apache.org/jira/browse/PIVOT-974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Whitcomb updated PIVOT-974:
-
Attachment: 974.patch
The "974.patch" file implements a fix for this.
> Use of "importClass" or "importPackage" function in Javascript within BXML
> files won't work under Java 8 Nashorn script engine
> --
>
> Key: PIVOT-974
> URL: https://issues.apache.org/jira/browse/PIVOT-974
> Project: Pivot
> Issue Type: Bug
> Components: core-serialization
>Affects Versions: 2.1
> Environment: All
>Reporter: Roger Whitcomb
>Assignee: Roger Whitcomb
>Priority: Critical
> Fix For: 2.1
>
> Attachments: 974.patch
>
>
> A small script such as this in a BXML file now will not work in Java 8:
>
> importClass(org.apache.pivot.wtk.Button);
> function isSelected(state) {
> return state == Button.State.SELECTED;
> }
>
> The reason is that the "importClass" function is not present in the base
> Nashorn engine, but is provided by a compatibility library:
> "mozilla_compat.js".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIVOT-974) Use of "importClass" or "importPackage" function in Javascript within BXML files won't work under Java 8 Nashorn script engine
[
https://issues.apache.org/jira/browse/PIVOT-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631635#comment-14631635
]
Roger Whitcomb commented on PIVOT-974:
--
Committed this fix in "trunk":
Sendingcore\src\org\apache\pivot\beans\BXMLSerializer.java
Transmitting file data .
Committed revision 1691618.
> Use of "importClass" or "importPackage" function in Javascript within BXML
> files won't work under Java 8 Nashorn script engine
> --
>
> Key: PIVOT-974
> URL: https://issues.apache.org/jira/browse/PIVOT-974
> Project: Pivot
> Issue Type: Bug
> Components: core-serialization
>Affects Versions: 2.1
> Environment: All
>Reporter: Roger Whitcomb
>Assignee: Roger Whitcomb
>Priority: Critical
> Fix For: 2.1
>
> Attachments: 974.patch
>
>
> A small script such as this in a BXML file now will not work in Java 8:
>
> importClass(org.apache.pivot.wtk.Button);
> function isSelected(state) {
> return state == Button.State.SELECTED;
> }
>
> The reason is that the "importClass" function is not present in the base
> Nashorn engine, but is provided by a compatibility library:
> "mozilla_compat.js".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIVOT-974) Use of "importClass" or "importPackage" function in Javascript within BXML files won't work under Java 8 Nashorn script engine
[
https://issues.apache.org/jira/browse/PIVOT-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633788#comment-14633788
]
Roger Whitcomb commented on PIVOT-974:
--
I thought about it. At first glance it doesn't seem necessary, but it could be
that users will be running on Java 8 even if we build only with Java 6. So, it
does probably make sense.
I can do the merge later today.
Thanks.
> Use of "importClass" or "importPackage" function in Javascript within BXML
> files won't work under Java 8 Nashorn script engine
> --
>
> Key: PIVOT-974
> URL: https://issues.apache.org/jira/browse/PIVOT-974
> Project: Pivot
> Issue Type: Bug
> Components: core-serialization
>Affects Versions: 2.1
> Environment: All
>Reporter: Roger Whitcomb
>Assignee: Roger Whitcomb
>Priority: Critical
> Fix For: 2.1
>
> Attachments: 974.patch
>
>
> A small script such as this in a BXML file now will not work in Java 8:
>
> importClass(org.apache.pivot.wtk.Button);
> function isSelected(state) {
> return state == Button.State.SELECTED;
> }
>
> The reason is that the "importClass" function is not present in the base
> Nashorn engine, but is provided by a compatibility library:
> "mozilla_compat.js".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIVOT-965) Java 8 BXML scripting security issues in Apache Pivot RIAs
[ https://issues.apache.org/jira/browse/PIVOT-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633795#comment-14633795 ] Roger Whitcomb commented on PIVOT-965: -- Hi Karel, what if you add some of the other attributes into your manifest mentioned here: http://docs.oracle.com/javase/7/docs/technotes/guides/jweb/security/manifest.html Thanks. > Java 8 BXML scripting security issues in Apache Pivot RIAs > -- > > Key: PIVOT-965 > URL: https://issues.apache.org/jira/browse/PIVOT-965 > Project: Pivot > Issue Type: Bug > Components: core-serialization >Affects Versions: 2.0.4 > Environment: Windows, Sun JRE 64-bit 1.8.0_31b13 >Reporter: Karel Hübl >Assignee: Sandro Martini > Labels: java8, jdk8 > Fix For: 2.1, 2.0.5 > > > We encounter security issues in our pivot application after upgrading to JRE > 1.8. The application is deployed as RIA using Java Web Start. > I found out, that the problem is connected with nashorn script engine which > replaced rhino script engine from previous java version. BXMLSerializer is > using ScriptEngine to evaluate scripts in BXML files. It seems, that all > calls initiated from BXML scripts, are considered untrusted in JRE 1.8 RIA > Environment - this means security dialogs and exceptions are thrown, when > trying execute privileged actions (network communication, reflection ...). > Currently, I am not sure, if this is Pivot or Nashorn bug, but it is problem > for current Apache Pivot RIAs. To investigate the srcipting behaviour in > RIAs, I created testing non Pivot project > https://github.com/kaja78/jnlpScripting The project contains testing > application, which is deployed as JWS. When you execute the java web start > app in JRE 1.8, the security dialog is displayed when testing method is > executed from nashorn script engine (if you press cancel button on security > dialog, you get SecurityException). When you uncomment 2 lines in > Webcontent/jnlpScripting.jnlp file, rhino script engine is used instead of > nashorn and no security dialog is displayed. This fix works also for our > Pivot RIAs. > I believe, Pivot should work in JRE 1.8 RIA Environment without security > issues by default, so it should be fixed somehow in Pivot - may be, by > correct ScriptEngine configuration in BXMLSerializer or by including Rhino > libraries in Pivot distribution. Any idea how to "correctly" fix this issue? > Btw.: I found this bug: http://bugs.java.com/view_bug.do?bug_id=8045075 I am > not sure, if it is the same problem. But anyway, it should be fixed in > 1.8.25.b01 and we are encountering above issues in latest 1.8.0.31.b13. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-974) Use of "importClass" or "importPackage" function in Javascript within BXML files won't work under Java 8 Nashorn script engine
[
https://issues.apache.org/jira/browse/PIVOT-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633999#comment-14633999
]
Roger Whitcomb commented on PIVOT-974:
--
Okay, merged to "branches/2.0.x":
Sending2.0.x
Sending2.0.x/core/src/org/apache/pivot/beans/BXMLSerializer.java
Transmitting file data .
Committed revision 1692012.
> Use of "importClass" or "importPackage" function in Javascript within BXML
> files won't work under Java 8 Nashorn script engine
> --
>
> Key: PIVOT-974
> URL: https://issues.apache.org/jira/browse/PIVOT-974
> Project: Pivot
> Issue Type: Bug
> Components: core-serialization
>Affects Versions: 2.1
> Environment: All
>Reporter: Roger Whitcomb
>Assignee: Roger Whitcomb
>Priority: Critical
> Fix For: 2.1
>
> Attachments: 974.patch
>
>
> A small script such as this in a BXML file now will not work in Java 8:
>
> importClass(org.apache.pivot.wtk.Button);
> function isSelected(state) {
> return state == Button.State.SELECTED;
> }
>
> The reason is that the "importClass" function is not present in the base
> Nashorn engine, but is provided by a compatibility library:
> "mozilla_compat.js".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (PIVOT-974) Use of "importClass" or "importPackage" function in Javascript within BXML files won't work under Java 8 Nashorn script engine
[
https://issues.apache.org/jira/browse/PIVOT-974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Whitcomb resolved PIVOT-974.
--
Resolution: Fixed
All seems good now.
> Use of "importClass" or "importPackage" function in Javascript within BXML
> files won't work under Java 8 Nashorn script engine
> --
>
> Key: PIVOT-974
> URL: https://issues.apache.org/jira/browse/PIVOT-974
> Project: Pivot
> Issue Type: Bug
> Components: core-serialization
>Affects Versions: 2.1
> Environment: All
>Reporter: Roger Whitcomb
>Assignee: Roger Whitcomb
>Priority: Critical
> Fix For: 2.1, 2.0.5
>
> Attachments: 974.patch
>
>
> A small script such as this in a BXML file now will not work in Java 8:
>
> importClass(org.apache.pivot.wtk.Button);
> function isSelected(state) {
> return state == Button.State.SELECTED;
> }
>
> The reason is that the "importClass" function is not present in the base
> Nashorn engine, but is provided by a compatibility library:
> "mozilla_compat.js".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (PIVOT-975) Build problems with Java 1.8.0_45
Roger Whitcomb created PIVOT-975: Summary: Build problems with Java 1.8.0_45 Key: PIVOT-975 URL: https://issues.apache.org/jira/browse/PIVOT-975 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0.4, 2.1 Environment: OSX Yosemite (10.10.4), Java 1.8.0_45 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.1, 2.0.5 Trying to build either 2.0.x or trunk with Java 8 gives error: For 2.0.x: Building Pivot requires JDK 1.6 or greater. Please see the BUILD file for more information.For trunk: Building Pivot requires JDK 1.7 or greater. Please see the BUILD file for more information. Fixing that in the build.xml then gives warnings about LocalManifestAdapter shouldn't be accessed from outside its source file. Moving the class to its own file solves this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-975) Build problems with Java 1.8.0_45
[ https://issues.apache.org/jira/browse/PIVOT-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635298#comment-14635298 ] Roger Whitcomb commented on PIVOT-975: -- In branches/2.0.x: Sendingbuild.xml Sendingwtk/src/org/apache/pivot/wtk/LocalManifest.java Adding wtk/src/org/apache/pivot/wtk/LocalManifestAdapter.java Transmitting file data ... Committed revision 1692157. > Build problems with Java 1.8.0_45 > - > > Key: PIVOT-975 > URL: https://issues.apache.org/jira/browse/PIVOT-975 > Project: Pivot > Issue Type: Bug > Components: wtk >Affects Versions: 2.0.4, 2.1 > Environment: OSX Yosemite (10.10.4), Java 1.8.0_45 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > > Trying to build either 2.0.x or trunk with Java 8 gives error: > For 2.0.x: > Building Pivot requires JDK 1.6 or greater. Please see the > BUILD file for more information.For trunk: > Building Pivot requires JDK 1.7 or greater. Please see the > BUILD file for more information. > Fixing that in the build.xml then gives warnings about LocalManifestAdapter > shouldn't be accessed from outside its source file. Moving the class to its > own file solves this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-975) Build problems with Java 1.8.0_45
[ https://issues.apache.org/jira/browse/PIVOT-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635314#comment-14635314 ] Roger Whitcomb commented on PIVOT-975: -- Merged to trunk: Sending. Sendingbuild.xml Sendingwtk/src/org/apache/pivot/wtk/LocalManifest.java Adding wtk/src/org/apache/pivot/wtk/LocalManifestAdapter.java Transmitting file data ... Committed revision 1692159. > Build problems with Java 1.8.0_45 > - > > Key: PIVOT-975 > URL: https://issues.apache.org/jira/browse/PIVOT-975 > Project: Pivot > Issue Type: Bug > Components: wtk >Affects Versions: 2.0.4, 2.1 > Environment: OSX Yosemite (10.10.4), Java 1.8.0_45 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > > Trying to build either 2.0.x or trunk with Java 8 gives error: > For 2.0.x: > Building Pivot requires JDK 1.6 or greater. Please see the > BUILD file for more information.For trunk: > Building Pivot requires JDK 1.7 or greater. Please see the > BUILD file for more information. > Fixing that in the build.xml then gives warnings about LocalManifestAdapter > shouldn't be accessed from outside its source file. Moving the class to its > own file solves this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PIVOT-976) Many, many Javadoc errors building with Java 8
Roger Whitcomb created PIVOT-976: Summary: Many, many Javadoc errors building with Java 8 Key: PIVOT-976 URL: https://issues.apache.org/jira/browse/PIVOT-976 Project: Pivot Issue Type: Bug Components: all Affects Versions: 2.0.4, 2.1 Environment: OSX 10.10.4, Java 1.8.0_45 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.1, 2.0.5 Java 8 has tightened up the description of Javadoc so that stuff that Java 7 ignored is now being flagged as either errors or warnings. Currently there are 64 errors and 100 warnings if you do "ant clean doc" with Java 8. Many of these are due to @param tags that have no description for the parameter. A lot more are due to "" that could/should just be "". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PIVOT-977) Specialized component to implement an HTML hyperlink
Roger Whitcomb created PIVOT-977: Summary: Specialized component to implement an HTML hyperlink Key: PIVOT-977 URL: https://issues.apache.org/jira/browse/PIVOT-977 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0.4 Environment: All Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.1 The appearance of a LinkButton is the same as an HTML hyperlink, but actually using it to implement a hyperlink is rather involved. So, it would be nice if there was a specialized component (subclass of LinkButton) that actually implements the hyperlink functionality, using the standard Java "Desktop.browse(URI)" method, so it is quite simple to implement a real hyperlink within an application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIVOT-977) Specialized component to implement an HTML hyperlink
[ https://issues.apache.org/jira/browse/PIVOT-977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-977: - Attachment: 977.patch The "977.patch" file implements this component, including a couple of test programs to illustrate the functionality. The button content by default will be the URI or URL string, but it can be set to any text desired, and/or a text and icon (just like any other button). The only additional thing I was considering was a listener for changes to the URI/URL on this button. Not sure if this is really necessary. > Specialized component to implement an HTML hyperlink > > > Key: PIVOT-977 > URL: https://issues.apache.org/jira/browse/PIVOT-977 > Project: Pivot > Issue Type: Improvement > Components: wtk >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Labels: hyperlink, linkbutton > Fix For: 2.1 > > Attachments: 977.patch > > > The appearance of a LinkButton is the same as an HTML hyperlink, but actually > using it to implement a hyperlink is rather involved. So, it would be nice > if there was a specialized component (subclass of LinkButton) that actually > implements the hyperlink functionality, using the standard Java > "Desktop.browse(URI)" method, so it is quite simple to implement a real > hyperlink within an application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-977) Specialized component to implement an HTML hyperlink
[ https://issues.apache.org/jira/browse/PIVOT-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658672#comment-14658672 ] Roger Whitcomb commented on PIVOT-977: -- Committed the change to "trunk" (with additional Javadoc over and above what is shown in the "977.patch" file): Sendingbuild.xml Adding tests/src/org/apache/pivot/tests/HyperlinkButtonTest.java Adding tests/src/org/apache/pivot/tests/HyperlinkButtonTest2.java Adding wtk/src/org/apache/pivot/wtk/HyperlinkButton.java Sendingwtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTheme.java Transmitting file data . Committed revision 1694282. > Specialized component to implement an HTML hyperlink > > > Key: PIVOT-977 > URL: https://issues.apache.org/jira/browse/PIVOT-977 > Project: Pivot > Issue Type: Improvement > Components: wtk >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Labels: hyperlink, linkbutton > Fix For: 2.1 > > Attachments: 977.patch > > > The appearance of a LinkButton is the same as an HTML hyperlink, but actually > using it to implement a hyperlink is rather involved. So, it would be nice > if there was a specialized component (subclass of LinkButton) that actually > implements the hyperlink functionality, using the standard Java > "Desktop.browse(URI)" method, so it is quite simple to implement a real > hyperlink within an application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-977) Specialized component to implement an HTML hyperlink
[ https://issues.apache.org/jira/browse/PIVOT-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658680#comment-14658680 ] Roger Whitcomb commented on PIVOT-977: -- After playing around with this, I don't think any additional listener for the URI/URL change is necessary. But feel free to comment if anyone thinks otherwise. The other thing that could be changed is the way we check for "Desktop.isSupported" in the "perform" method. These checks could turn into exceptions instead, so that something gets signaled if the link can't be implemented, rather than just silently failing. Thoughts? > Specialized component to implement an HTML hyperlink > > > Key: PIVOT-977 > URL: https://issues.apache.org/jira/browse/PIVOT-977 > Project: Pivot > Issue Type: Improvement > Components: wtk >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Labels: hyperlink, linkbutton > Fix For: 2.1 > > Attachments: 977.patch > > > The appearance of a LinkButton is the same as an HTML hyperlink, but actually > using it to implement a hyperlink is rather involved. So, it would be nice > if there was a specialized component (subclass of LinkButton) that actually > implements the hyperlink functionality, using the standard Java > "Desktop.browse(URI)" method, so it is quite simple to implement a real > hyperlink within an application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-977) Specialized component to implement an HTML hyperlink
[ https://issues.apache.org/jira/browse/PIVOT-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658698#comment-14658698 ] Roger Whitcomb commented on PIVOT-977: -- Corrected a minor typo in one of the test programs: Sendingtests/src/org/apache/pivot/tests/HyperlinkButtonTest.java Transmitting file data . Committed revision 1694284. > Specialized component to implement an HTML hyperlink > > > Key: PIVOT-977 > URL: https://issues.apache.org/jira/browse/PIVOT-977 > Project: Pivot > Issue Type: Improvement > Components: wtk >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Labels: hyperlink, linkbutton > Fix For: 2.1 > > Attachments: 977.patch > > > The appearance of a LinkButton is the same as an HTML hyperlink, but actually > using it to implement a hyperlink is rather involved. So, it would be nice > if there was a specialized component (subclass of LinkButton) that actually > implements the hyperlink functionality, using the standard Java > "Desktop.browse(URI)" method, so it is quite simple to implement a real > hyperlink within an application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-976) Many, many Javadoc errors building with Java 8
[ https://issues.apache.org/jira/browse/PIVOT-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658738#comment-14658738 ] Roger Whitcomb commented on PIVOT-976: -- First wave of these changes: Correct the "self-closing element not allowed" errors from using "" instead of just "". Sendingwtk/src/org/apache/pivot/wtk/Component.java Sendingwtk/src/org/apache/pivot/wtk/DesktopApplicationContext.java Sendingwtk/src/org/apache/pivot/wtk/RadioButtonGroup.java Sendingwtk/src/org/apache/pivot/wtk/Theme.java Sendingwtk/src/org/apache/pivot/wtk/effects/Transition.java Sendingwtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTheme.java Transmitting file data .. Committed revision 1694299. > Many, many Javadoc errors building with Java 8 > -- > > Key: PIVOT-976 > URL: https://issues.apache.org/jira/browse/PIVOT-976 > Project: Pivot > Issue Type: Bug > Components: all >Affects Versions: 2.0.4, 2.1 > Environment: OSX 10.10.4, Java 1.8.0_45 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > > Java 8 has tightened up the description of Javadoc so that stuff that Java 7 > ignored is now being flagged as either errors or warnings. Currently there > are 64 errors and 100 warnings if you do "ant clean doc" with Java 8. > Many of these are due to @param tags that have no description for the > parameter. A lot more are due to "" that could/should just be "". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-976) Many, many Javadoc errors building with Java 8
[ https://issues.apache.org/jira/browse/PIVOT-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658758#comment-14658758 ] Roger Whitcomb commented on PIVOT-976: -- Another round: Sendingcore/src/org/apache/pivot/serialization/CSVSerializer.java Sendingcore/src/org/apache/pivot/xml/Element.java Sendingwtk/src/org/apache/pivot/wtk/Skin.java Sendingwtk/src/org/apache/pivot/wtk/Spinner.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCalendarSkin.java Transmitting file data . Committed revision 1694304. > Many, many Javadoc errors building with Java 8 > -- > > Key: PIVOT-976 > URL: https://issues.apache.org/jira/browse/PIVOT-976 > Project: Pivot > Issue Type: Bug > Components: all >Affects Versions: 2.0.4, 2.1 > Environment: OSX 10.10.4, Java 1.8.0_45 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > > Java 8 has tightened up the description of Javadoc so that stuff that Java 7 > ignored is now being flagged as either errors or warnings. Currently there > are 64 errors and 100 warnings if you do "ant clean doc" with Java 8. > Many of these are due to @param tags that have no description for the > parameter. A lot more are due to "" that could/should just be "". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-976) Many, many Javadoc errors building with Java 8
[ https://issues.apache.org/jira/browse/PIVOT-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658786#comment-14658786 ] Roger Whitcomb commented on PIVOT-976: -- Fixed all the errors found (still 100 warnings, though): Sendingcore/src/org/apache/pivot/functional/monad/TryCompanion.java Sendingwtk/src/org/apache/pivot/wtk/BrowserApplicationContext.java Sendingwtk/src/org/apache/pivot/wtk/Component.java Sendingwtk/src/org/apache/pivot/wtk/DesktopApplicationContext.java Sendingwtk/src/org/apache/pivot/wtk/ListView.java Sendingwtk/src/org/apache/pivot/wtk/RadioButtonGroup.java Transmitting file data .. Committed revision 1694313. NOTE: One of these set of changes I don't think will work correctly under Java 7, but will test after submission. > Many, many Javadoc errors building with Java 8 > -- > > Key: PIVOT-976 > URL: https://issues.apache.org/jira/browse/PIVOT-976 > Project: Pivot > Issue Type: Bug > Components: all >Affects Versions: 2.0.4, 2.1 > Environment: OSX 10.10.4, Java 1.8.0_45 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > > Java 8 has tightened up the description of Javadoc so that stuff that Java 7 > ignored is now being flagged as either errors or warnings. Currently there > are 64 errors and 100 warnings if you do "ant clean doc" with Java 8. > Many of these are due to @param tags that have no description for the > parameter. A lot more are due to "" that could/should just be "". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-976) Many, many Javadoc errors building with Java 8
[ https://issues.apache.org/jira/browse/PIVOT-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659181#comment-14659181 ] Roger Whitcomb commented on PIVOT-976: -- Just tested "ant clean package doc" with JDK 1.7.0_25 and everything was clean with the very latest source. > Many, many Javadoc errors building with Java 8 > -- > > Key: PIVOT-976 > URL: https://issues.apache.org/jira/browse/PIVOT-976 > Project: Pivot > Issue Type: Bug > Components: all >Affects Versions: 2.0.4, 2.1 > Environment: OSX 10.10.4, Java 1.8.0_45 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > > Java 8 has tightened up the description of Javadoc so that stuff that Java 7 > ignored is now being flagged as either errors or warnings. Currently there > are 64 errors and 100 warnings if you do "ant clean doc" with Java 8. > Many of these are due to @param tags that have no description for the > parameter. A lot more are due to "" that could/should just be "". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-976) Many, many Javadoc errors building with Java 8
[ https://issues.apache.org/jira/browse/PIVOT-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660461#comment-14660461 ] Roger Whitcomb commented on PIVOT-976: -- Clear up the warnings in Component.java: Sendingwtk/src/org/apache/pivot/wtk/Component.java Transmitting file data . Committed revision 1694544. > Many, many Javadoc errors building with Java 8 > -- > > Key: PIVOT-976 > URL: https://issues.apache.org/jira/browse/PIVOT-976 > Project: Pivot > Issue Type: Bug > Components: all >Affects Versions: 2.0.4, 2.1 > Environment: OSX 10.10.4, Java 1.8.0_45 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > > Java 8 has tightened up the description of Javadoc so that stuff that Java 7 > ignored is now being flagged as either errors or warnings. Currently there > are 64 errors and 100 warnings if you do "ant clean doc" with Java 8. > Many of these are due to @param tags that have no description for the > parameter. A lot more are due to "" that could/should just be "". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-976) Many, many Javadoc errors building with Java 8
[ https://issues.apache.org/jira/browse/PIVOT-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680715#comment-14680715 ] Roger Whitcomb commented on PIVOT-976: -- Some more fixes for warnings (files with just a few warnings): Sendingcore/src/org/apache/pivot/collections/List.java Sendingcore/src/org/apache/pivot/collections/Map.java Sendingcore/src/org/apache/pivot/collections/Sequence.java Sendingwtk/src/org/apache/pivot/wtk/ConstrainedVisual.java Sendingwtk/src/org/apache/pivot/wtk/Skin.java Sendingwtk/src/org/apache/pivot/wtk/Visual.java Sendingwtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java Transmitting file data ... Committed revision 1695162. > Many, many Javadoc errors building with Java 8 > -- > > Key: PIVOT-976 > URL: https://issues.apache.org/jira/browse/PIVOT-976 > Project: Pivot > Issue Type: Bug > Components: all >Affects Versions: 2.0.4, 2.1 > Environment: OSX 10.10.4, Java 1.8.0_45 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > > Java 8 has tightened up the description of Javadoc so that stuff that Java 7 > ignored is now being flagged as either errors or warnings. Currently there > are 64 errors and 100 warnings if you do "ant clean doc" with Java 8. > Many of these are due to @param tags that have no description for the > parameter. A lot more are due to "" that could/should just be "". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PIVOT-978) Possible to get calendar dates in year 10000 and beyond
Roger Whitcomb created PIVOT-978: Summary: Possible to get calendar dates in year 1 and beyond Key: PIVOT-978 URL: https://issues.apache.org/jira/browse/PIVOT-978 Project: Pivot Issue Type: Bug Components: wtk-terra Affects Versions: 2.0.4, 2.1 Environment: ALL Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.1, 2.0.5 Summary of the steps to reproduce (from QA tester of our application): 1. click into the year field - it seems not possible to change the year, however: 2. press 1 and a date of 1 is entered 3. press 2 and it's 2 4. press 3 and it's 3 (if you press 3 first, it could be 3000 and so it would be valid) 5. you get a error message e.g. Invalid year: 1 6. nevertheless you can change the year with the arrow keys/buttons but for every change you get the error message. You also get the error message if you go to the upper and lower bounds of the calender, which is the year 1582 and 1 (both exclusive) by means of arrow keys / arrow buttons. You can change the year into the wrong direction if you are willing to confirm the error message on every keypress. And if you want to change the year back to some meaningful value, you have to confirm the error message again, until you hit a valid year. If in such a invalid year (e.g 1580), you can click on a day and the date will change to that date in 1583. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (PIVOT-977) Specialized component to implement an HTML hyperlink
[ https://issues.apache.org/jira/browse/PIVOT-977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb resolved PIVOT-977. -- Resolution: Fixed Much testing in our application -- everything seems good. > Specialized component to implement an HTML hyperlink > > > Key: PIVOT-977 > URL: https://issues.apache.org/jira/browse/PIVOT-977 > Project: Pivot > Issue Type: Improvement > Components: wtk >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Labels: hyperlink, linkbutton > Fix For: 2.1 > > Attachments: 977.patch > > > The appearance of a LinkButton is the same as an HTML hyperlink, but actually > using it to implement a hyperlink is rather involved. So, it would be nice > if there was a specialized component (subclass of LinkButton) that actually > implements the hyperlink functionality, using the standard Java > "Desktop.browse(URI)" method, so it is quite simple to implement a real > hyperlink within an application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (PIVOT-978) Possible to get calendar dates in year 10000 and beyond
[ https://issues.apache.org/jira/browse/PIVOT-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb resolved PIVOT-978. -- Resolution: Fixed branches/2.0.x: Sendingcore\src\org\apache\pivot\util\CalendarDate.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraCalendarSkin.java Transmitting file data .. Committed revision 1703071. One very minor problem remains: still get exception when trying to display January 1583, because the beginning of the week is in 1582. > Possible to get calendar dates in year 1 and beyond > --- > > Key: PIVOT-978 > URL: https://issues.apache.org/jira/browse/PIVOT-978 > Project: Pivot > Issue Type: Bug > Components: wtk-terra >Affects Versions: 2.0.4, 2.1 > Environment: ALL >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > > Summary of the steps to reproduce (from QA tester of our application): > 1. click into the year field - it seems not possible to change the year, > however: > 2. press 1 and a date of 1 is entered > 3. press 2 and it's 2 > 4. press 3 and it's 3 (if you press 3 first, it could be 3000 and so it > would be valid) > 5. you get a error message e.g. Invalid year: 1 > 6. nevertheless you can change the year with the arrow keys/buttons but for > every change you get the error message. > You also get the error message if you go to the upper and lower bounds of the > calender, which is the year 1582 and 1 (both exclusive) by means of arrow > keys / arrow buttons. You can change the year into the wrong direction if you > are willing to confirm the error message on every keypress. And if you want > to change the year back to some meaningful value, you have to confirm the > error message again, until you hit a valid year. If in such a invalid year > (e.g 1580), you can click on a day and the date will change to that date in > 1583. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-965) Java 8 BXML scripting security issues in Apache Pivot RIAs
[ https://issues.apache.org/jira/browse/PIVOT-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745726#comment-14745726 ] Roger Whitcomb commented on PIVOT-965: -- I would like to see what kind of Javascript calls are generating the security prompts. I was getting problems with Nashorn just doing calls on Pivot objects within the same BXML file until I updated BXMLSerializer with some namespace fixes, etc. Karel, could you try with the last either 2.0.5 or "trunk" code and see if you still have the same issues? Especially with the "trunk" code I have added the new security-related manifests to the Pivot .jar files (note: this has not been migrated to 2.0.x yet) and this might help. Thanks. > Java 8 BXML scripting security issues in Apache Pivot RIAs > -- > > Key: PIVOT-965 > URL: https://issues.apache.org/jira/browse/PIVOT-965 > Project: Pivot > Issue Type: Bug > Components: core-serialization >Affects Versions: 2.0.4 > Environment: Windows, Sun JRE 64-bit 1.8.0_31b13 >Reporter: Karel Hübl >Assignee: Sandro Martini > Labels: java8, jdk8 > Fix For: 2.1, 2.0.5 > > > We encounter security issues in our pivot application after upgrading to JRE > 1.8. The application is deployed as RIA using Java Web Start. > I found out, that the problem is connected with nashorn script engine which > replaced rhino script engine from previous java version. BXMLSerializer is > using ScriptEngine to evaluate scripts in BXML files. It seems, that all > calls initiated from BXML scripts, are considered untrusted in JRE 1.8 RIA > Environment - this means security dialogs and exceptions are thrown, when > trying execute privileged actions (network communication, reflection ...). > Currently, I am not sure, if this is Pivot or Nashorn bug, but it is problem > for current Apache Pivot RIAs. To investigate the srcipting behaviour in > RIAs, I created testing non Pivot project > https://github.com/kaja78/jnlpScripting The project contains testing > application, which is deployed as JWS. When you execute the java web start > app in JRE 1.8, the security dialog is displayed when testing method is > executed from nashorn script engine (if you press cancel button on security > dialog, you get SecurityException). When you uncomment 2 lines in > Webcontent/jnlpScripting.jnlp file, rhino script engine is used instead of > nashorn and no security dialog is displayed. This fix works also for our > Pivot RIAs. > I believe, Pivot should work in JRE 1.8 RIA Environment without security > issues by default, so it should be fixed somehow in Pivot - may be, by > correct ScriptEngine configuration in BXMLSerializer or by including Rhino > libraries in Pivot distribution. Any idea how to "correctly" fix this issue? > Btw.: I found this bug: http://bugs.java.com/view_bug.do?bug_id=8045075 I am > not sure, if it is the same problem. But anyway, it should be fixed in > 1.8.25.b01 and we are encountering above issues in latest 1.8.0.31.b13. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (PIVOT-975) Build problems with Java 1.8.0_45
[ https://issues.apache.org/jira/browse/PIVOT-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb resolved PIVOT-975. -- Resolution: Fixed Building either trunk or 2.0.x branch works fine now with Java 8 (1.8.0_45). > Build problems with Java 1.8.0_45 > - > > Key: PIVOT-975 > URL: https://issues.apache.org/jira/browse/PIVOT-975 > Project: Pivot > Issue Type: Bug > Components: wtk >Affects Versions: 2.0.4, 2.1 > Environment: OSX Yosemite (10.10.4), Java 1.8.0_45 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > > Trying to build either 2.0.x or trunk with Java 8 gives error: > For 2.0.x: > Building Pivot requires JDK 1.6 or greater. Please see the > BUILD file for more information.For trunk: > Building Pivot requires JDK 1.7 or greater. Please see the > BUILD file for more information. > Fixing that in the build.xml then gives warnings about LocalManifestAdapter > shouldn't be accessed from outside its source file. Moving the class to its > own file solves this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-972) Add another small tutorial (calculator app)
[ https://issues.apache.org/jira/browse/PIVOT-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745824#comment-14745824 ] Roger Whitcomb commented on PIVOT-972: -- Merged to branches/2.0.x with the following revisions: 1703262 1703265 1703266 1703267 > Add another small tutorial (calculator app) > --- > > Key: PIVOT-972 > URL: https://issues.apache.org/jira/browse/PIVOT-972 > Project: Pivot > Issue Type: Improvement > Components: tutorials >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > Attachments: Pivot-Calculator-Concept.png > > > Wanting to demonstrate keyboard and action mapping paradigms via a calculator > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIVOT-976) Many, many Javadoc errors building with Java 8
[ https://issues.apache.org/jira/browse/PIVOT-976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-976: - Fix Version/s: (was: 2.0.5) > Many, many Javadoc errors building with Java 8 > -- > > Key: PIVOT-976 > URL: https://issues.apache.org/jira/browse/PIVOT-976 > Project: Pivot > Issue Type: Bug > Components: all >Affects Versions: 2.0.4, 2.1 > Environment: OSX 10.10.4, Java 1.8.0_45 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1 > > > Java 8 has tightened up the description of Javadoc so that stuff that Java 7 > ignored is now being flagged as either errors or warnings. Currently there > are 64 errors and 100 warnings if you do "ant clean doc" with Java 8. > Many of these are due to @param tags that have no description for the > parameter. A lot more are due to "" that could/should just be "". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-972) Add another small tutorial (calculator app)
[ https://issues.apache.org/jira/browse/PIVOT-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745950#comment-14745950 ] Roger Whitcomb commented on PIVOT-972: -- Had to make a small modification in branches/2.0.x to work around a javac compiler issue with Java 6. Revision 1703273. > Add another small tutorial (calculator app) > --- > > Key: PIVOT-972 > URL: https://issues.apache.org/jira/browse/PIVOT-972 > Project: Pivot > Issue Type: Improvement > Components: tutorials >Affects Versions: 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1, 2.0.5 > > Attachments: Pivot-Calculator-Concept.png > > > Wanting to demonstrate keyboard and action mapping paradigms via a calculator > application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-976) Many, many Javadoc errors building with Java 8
[ https://issues.apache.org/jira/browse/PIVOT-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935470#comment-14935470 ] Roger Whitcomb commented on PIVOT-976: -- Adding @param descriptions to these nine files: Sendingcharts/src/org/apache/pivot/charts/ChartViewCategoryListener.java Sendingcharts/src/org/apache/pivot/charts/ChartViewListener.java Sendingcharts/src/org/apache/pivot/charts/ChartViewSeriesListener.java Sendingwtk/src/org/apache/pivot/wtk/ComponentKeyListener.java Sendingwtk/src/org/apache/pivot/wtk/ComponentListener.java Sendingwtk/src/org/apache/pivot/wtk/ComponentMouseButtonListener.java Sendingwtk/src/org/apache/pivot/wtk/ComponentMouseListener.java Sendingwtk/src/org/apache/pivot/wtk/ComponentMouseWheelListener.java Sendingwtk/src/org/apache/pivot/wtk/ComponentTooltipListener.java Transmitting file data . Committed revision 1705893. > Many, many Javadoc errors building with Java 8 > -- > > Key: PIVOT-976 > URL: https://issues.apache.org/jira/browse/PIVOT-976 > Project: Pivot > Issue Type: Bug > Components: all >Affects Versions: 2.0.4, 2.1 > Environment: OSX 10.10.4, Java 1.8.0_45 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1 > > > Java 8 has tightened up the description of Javadoc so that stuff that Java 7 > ignored is now being flagged as either errors or warnings. Currently there > are 64 errors and 100 warnings if you do "ant clean doc" with Java 8. > Many of these are due to @param tags that have no description for the > parameter. A lot more are due to "" that could/should just be "". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-976) Many, many Javadoc errors building with Java 8
[ https://issues.apache.org/jira/browse/PIVOT-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935937#comment-14935937 ] Roger Whitcomb commented on PIVOT-976: -- More fixes to Javadoc, and still over 100 warnings left to fix. This time address the warnings in the "beans" and "serializer" areas: Sendingcore/src/org/apache/pivot/beans/BXML.java Sendingcore/src/org/apache/pivot/beans/BXMLSerializer.java Sendingcore/src/org/apache/pivot/beans/BeanAdapter.java Sendingcore/src/org/apache/pivot/beans/BeanMonitor.java Sendingcore/src/org/apache/pivot/beans/DefaultProperty.java Sendingcore/src/org/apache/pivot/beans/IDProperty.java Sendingcore/src/org/apache/pivot/beans/NamespaceBinding.java Sendingcore/src/org/apache/pivot/beans/PropertyChangeListener.java Sendingcore/src/org/apache/pivot/beans/Resolvable.java Sendingcore/src/org/apache/pivot/serialization/Serializer.java Transmitting file data .. Committed revision 1705929. > Many, many Javadoc errors building with Java 8 > -- > > Key: PIVOT-976 > URL: https://issues.apache.org/jira/browse/PIVOT-976 > Project: Pivot > Issue Type: Bug > Components: all >Affects Versions: 2.0.4, 2.1 > Environment: OSX 10.10.4, Java 1.8.0_45 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1 > > > Java 8 has tightened up the description of Javadoc so that stuff that Java 7 > ignored is now being flagged as either errors or warnings. Currently there > are 64 errors and 100 warnings if you do "ant clean doc" with Java 8. > Many of these are due to @param tags that have no description for the > parameter. A lot more are due to "" that could/should just be "". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-976) Many, many Javadoc errors building with Java 8
[ https://issues.apache.org/jira/browse/PIVOT-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936031#comment-14936031 ] Roger Whitcomb commented on PIVOT-976: -- This time in the "collections" and "util" space: Sendingcore/src/org/apache/pivot/collections/Queue.java Sendingcore/src/org/apache/pivot/collections/QueueListener.java Sendingcore/src/org/apache/pivot/collections/Sequence.java Sendingcore/src/org/apache/pivot/collections/Set.java Sendingcore/src/org/apache/pivot/collections/Stack.java Sendingcore/src/org/apache/pivot/collections/StackListener.java Sendingcore/src/org/apache/pivot/functional/monad/None.java Sendingcore/src/org/apache/pivot/functional/monad/OptionCompanion.java Sendingcore/src/org/apache/pivot/functional/monad/TryCompanion.java Sendingcore/src/org/apache/pivot/util/ListenerList.java Sendingcore/src/org/apache/pivot/util/concurrent/Task.java Transmitting file data ... Committed revision 1705946. > Many, many Javadoc errors building with Java 8 > -- > > Key: PIVOT-976 > URL: https://issues.apache.org/jira/browse/PIVOT-976 > Project: Pivot > Issue Type: Bug > Components: all >Affects Versions: 2.0.4, 2.1 > Environment: OSX 10.10.4, Java 1.8.0_45 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1 > > > Java 8 has tightened up the description of Javadoc so that stuff that Java 7 > ignored is now being flagged as either errors or warnings. Currently there > are 64 errors and 100 warnings if you do "ant clean doc" with Java 8. > Many of these are due to @param tags that have no description for the > parameter. A lot more are due to "" that could/should just be "". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIVOT-976) Many, many Javadoc errors building with Java 8
[ https://issues.apache.org/jira/browse/PIVOT-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938329#comment-14938329 ] Roger Whitcomb commented on PIVOT-976: -- Twenty more files: Sendingcore/src/org/apache/pivot/json/JSON.java Sendingcore/src/org/apache/pivot/json/JSONSerializer.java Sendingcore/src/org/apache/pivot/json/JSONSerializerListener.java Sendingcore/src/org/apache/pivot/serialization/CSVSerializer.java Sending core/src/org/apache/pivot/serialization/CSVSerializerListener.java Sendingcore/src/org/apache/pivot/text/FileSizeFormat.java Sendingcore/src/org/apache/pivot/util/Base64.java Sendingcore/src/org/apache/pivot/util/CalendarDate.java Sendingcore/src/org/apache/pivot/util/MIMEType.java Sendingcore/src/org/apache/pivot/util/MessageBus.java Sendingcore/src/org/apache/pivot/util/MessageBusListener.java Sendingcore/src/org/apache/pivot/util/Service.java Sendingcore/src/org/apache/pivot/util/Time.java Sendingcore/src/org/apache/pivot/util/TypeLiteral.java Sendingcore/src/org/apache/pivot/util/Utils.java Sendingcore/src/org/apache/pivot/xml/Element.java Sendingcore/src/org/apache/pivot/xml/ElementListener.java Sendingcore/src/org/apache/pivot/xml/Node.java Sendingcore/src/org/apache/pivot/xml/NodeListener.java Sendingcore/src/org/apache/pivot/xml/XMLSerializerListener.java Transmitting file data Committed revision 1706138. > Many, many Javadoc errors building with Java 8 > -- > > Key: PIVOT-976 > URL: https://issues.apache.org/jira/browse/PIVOT-976 > Project: Pivot > Issue Type: Bug > Components: all >Affects Versions: 2.0.4, 2.1 > Environment: OSX 10.10.4, Java 1.8.0_45 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1 > > > Java 8 has tightened up the description of Javadoc so that stuff that Java 7 > ignored is now being flagged as either errors or warnings. Currently there > are 64 errors and 100 warnings if you do "ant clean doc" with Java 8. > Many of these are due to @param tags that have no description for the > parameter. A lot more are due to "" that could/should just be "". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
