[GitHub] JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close. URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-410172284 @chrisdutz I guess due to my partial scala background I totally ignore Javas Completable futures as superior and thus didnt think about using them : D But I agree that it shows the intention of the code clearer. Perhaps we add a Util Class that "converts" a Netty Future into a Completable Future, as we surely need this functionality more often. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close. URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-409963436 @sruehl my understanding is that netty avoids a scenario where one uses the event loop executors threads for blocking and thus, risks a deadlock. This should not be the case in this situation because the EventLoops Thread wich does the listener notification only counts down the latch. But as this solution seems uglier than it should be it is possibly a good idea to go over to the netty list and ask there (I am totally new to netty). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close. URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-409958048 @chrisdutz your fixes in the master made it work for me also. As I found a solution to avoid the blocking exception in the meanwhile I combined your code with mine. I think the only obvious solution is, as i propose, to use a CountDownLatch to communicate between the ChannelCloseFuture and the close method on another ThreadPool than the EventLoopGroup (which netty forbids). Is this solution feasible for you? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
