[Bug 60786] [PATCH] Keeping the first rows of an SXSSFSheet in memory for createing pivot table
https://bz.apache.org/bugzilla/show_bug.cgi?id=60786 Dominik Stadler changed: What|Removed |Added Keywords||PatchAvailable -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 Dominik Stadler changed: What|Removed |Added Attachment #34840|text/plain |application/zip mime type|| Attachment #34840|1 |0 is patch|| -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 Dominik Stadler changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #15 from Dominik Stadler --- Please note that providing a diff instead of the whole source of the files would be better as the whole files can quickly become outdated due to other changes to the codebase and thus will make applying the changes more and more difficult over time. See http://poi.apache.org/guidelines.html#SubmittingPatches for some automated ways of creating the patch-files. Also ideally some additional unit-tests accompany a patch so the changes are verified and stay in place correctly through future changes to the code. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60866] [PATCH] Support for named cell styles in SS Common
https://bz.apache.org/bugzilla/show_bug.cgi?id=60866 Dominik Stadler changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 Dominik Stadler changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #6 from Dominik Stadler --- I did a look, here some initial comments: * The initial implementation looks already like a good start, thanks for putting in the work * Maybe we should throw "UnsupportedException" in the methods that are not supported, this way the user immediately knows even if she does not look at the JavaDoc? * As it is complex new functionality, we might first add it to the "scratchpad" project/source-folders so we can let it stabilise some more until we declare it as "production ready" by moving it into the ooxml-part. * Please remove the "// TODO Auto-generated method stub" comments with a comment that explains why the method is empty or with an exception as stated above or simply remove it * Please try to format the code consistently according to our coding-guidelines, see http://poi.apache.org/guidelines.html#CodeStyle, your IDE will usually allow to define it and reformat a whole file in one go. * Is there a way to not duplicate the date-formats in StreamedSheetEventHandler? We already handle them in various places, e.g. DateFormatConverter * On testing I would love to see some test that kind of "trashes" the implementation, i.e. take all spreadsheets that we have under test-data and run the normal XSSFWorkbook/HSSFWorkbook and compare results to your implementation as far as possible. This way we ensure that your code handles all the special cases that can arise. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60786] [PATCH] Keeping the first rows of an SXSSFSheet in memory for createing pivot table
https://bz.apache.org/bugzilla/show_bug.cgi?id=60786 Dominik Stadler changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Dominik Stadler --- Thanks for the patch, any chance of a unit-test that verifies these changes so they stay in place correctly in the future? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 59666] Unable to apply sorting/custom sorting on cell range addresss
https://bz.apache.org/bugzilla/show_bug.cgi?id=59666 dollinger.flor...@gmx.de changed: What|Removed |Added Priority|P5 |P1 Severity|blocker |normal -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60325] Poor performance in DirectoryNode.createDocument() for NPOIFSFileSystem
https://bz.apache.org/bugzilla/show_bug.cgi?id=60325 --- Comment #2 from Dominik Stadler --- Hm, the ByteBuffer.wrap() call seems unlikely to be the time-culprit as it just populates some members, I'd try to use some profiler or APM tool here to find what is actually using up the time. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60325] Poor performance in DirectoryNode.createDocument() for NPOIFSFileSystem
https://bz.apache.org/bugzilla/show_bug.cgi?id=60325 --- Comment #3 from Dominik Stadler --- A quick analysis points more into the direction of NPOIFSMiniStore.getBlockAt() because it iterates block-by-block via an Iterator, for large documents the offset can be high (i.e. in your sample between 500 and 1000 times for each call) and thus there are many loop-iterations with many it.next() calls to StreamBlockByteBufferIterator which has to perform more work to do these steps. Unfortunately this is quite core to the class, so not easily replaced with something more performing as far as I see :(. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60325] Poor performance in DirectoryNode.createDocument() for NPOIFSFileSystem
https://bz.apache.org/bugzilla/show_bug.cgi?id=60325 --- Comment #4 from Dominik Stadler --- Created attachment 34845 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34845&action=edit Screenshot from JVisualVM sampling -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60868] CTRow#isSetCustomHeight not working when customHeight set to "false"
https://bz.apache.org/bugzilla/show_bug.cgi?id=60868 Dominik Stadler changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Dominik Stadler --- I did take a look, the generated isSetCustomHeight() actually does the following: return this.get_store().find_attribute_user(CUSTOMHEIGHT$16) != null; so it returns true if the attribute appears in the XML. The only place where POI itself uses isSetCustomHeight() is during clearing the manually set height, where a general isSet-call makes sense to use the default that is applied when the flag is not set at all. So I currently don't see much that can be done inside Apache POI here, please reopen the bug with more suggestions if you disagree. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] poi pull request #51: Fix typo in exception message
GitHub user kinow opened a pull request: https://github.com/apache/poi/pull/51 Fix typo in exception message s/lenght/length It said Could not read complex escher property, lenght was Now it says Could not read complex escher property, length was You can merge this pull request into a Git repository by running: $ git pull https://github.com/kinow/poi fix-typo-in-exception Alternatively you can review and apply these changes as the patch at: https://github.com/apache/poi/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit 882b21182522cebf452f32936120019576085f7e Author: Bruno P. Kinoshita Date: 2017-03-19T12:17:10Z Fix typo in exception message --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60848] SUMPRODUCT fails when first arg is of form --(...)
https://bz.apache.org/bugzilla/show_bug.cgi?id=60848 Dominik Stadler changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Dominik Stadler --- Do you have a sample file/sample code or unit-test that reproduces the problem? This would make it a lot easier for developers to reproduce and work on a fix. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] poi pull request #51: Fix typo in exception message
Github user asfgit closed the pull request at: https://github.com/apache/poi/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60823] [PATCH] DGET function, correct behavior with multiple result entries but only one non-blank
https://bz.apache.org/bugzilla/show_bug.cgi?id=60823 Dominik Stadler changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Dominik Stadler --- Applied via r1787658, thanks a lot for the patch! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 55791] PartAlreadyExistsException when removing and adding slides
https://bz.apache.org/bugzilla/show_bug.cgi?id=55791 Dominik Stadler changed: What|Removed |Added Blocks||60810 Referenced Bugs: https://bz.apache.org/bugzilla/show_bug.cgi?id=60810 [Bug 60810] PartAlreadyExistsException when read slides note -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60810] PartAlreadyExistsException when read slides note
https://bz.apache.org/bugzilla/show_bug.cgi?id=60810 Dominik Stadler changed: What|Removed |Added Depends on||55791, 60042 --- Comment #2 from Dominik Stadler --- Bug 55791 and bug 60042 sound related. Referenced Bugs: https://bz.apache.org/bugzilla/show_bug.cgi?id=55791 [Bug 55791] PartAlreadyExistsException when removing and adding slides https://bz.apache.org/bugzilla/show_bug.cgi?id=60042 [Bug 60042] PartAlreadyExistsException thrown when removing and adding slides. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60042] PartAlreadyExistsException thrown when removing and adding slides.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60042 Dominik Stadler changed: What|Removed |Added Blocks||60810 Referenced Bugs: https://bz.apache.org/bugzilla/show_bug.cgi?id=60810 [Bug 60810] PartAlreadyExistsException when read slides note -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60810] PartAlreadyExistsException when read slides note
https://bz.apache.org/bugzilla/show_bug.cgi?id=60810 Bug 60810 depends on bug 60042, which changed state. Bug 60042 Summary: PartAlreadyExistsException thrown when removing and adding slides. https://bz.apache.org/bugzilla/show_bug.cgi?id=60042 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60042] PartAlreadyExistsException thrown when removing and adding slides.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60042 Dominik Stadler changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Dominik Stadler --- This seems to have been fixed shortly after version 3.14 was released, see bug 55791. I tried the test-code with the attached sample and it did work fine in current trunk. *** This bug has been marked as a duplicate of bug 55791 *** -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 55791] PartAlreadyExistsException when removing and adding slides
https://bz.apache.org/bugzilla/show_bug.cgi?id=55791 Dominik Stadler changed: What|Removed |Added CC||john.littlewood@uk.thalesgr ||oup.com --- Comment #4 from Dominik Stadler --- *** Bug 60042 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 dollinger.flor...@gmx.de changed: What|Removed |Added Attachment #34840|0 |1 is obsolete|| --- Comment #16 from dollinger.flor...@gmx.de --- Created attachment 34846 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34846&action=edit patch as a diff file (git) Hey Dominik, thanks for the advice, i added the patch diff file - i am not very familiar with jUnit, but I will give it a try. Btw.: Should the current repository jUnit tests run without any errors? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 dollinger.flor...@gmx.de changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #17 from dollinger.flor...@gmx.de --- back to NEW -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60805] Remove calls to System.out.print and System.out.println
https://bz.apache.org/bugzilla/show_bug.cgi?id=60805 --- Comment #1 from Dominik Stadler --- There is a bundled signature for this: However disabling forbidden-apis in all the examples and devtools via annotation is a bit tedious and excludes all api-checks in those classes/methods. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60845] [PATCH] copied cell style and CF
https://bz.apache.org/bugzilla/show_bug.cgi?id=60845 --- Comment #18 from Dominik Stadler --- Yes, unit-tests are expected to run fine always, we had some failures on Windows recently, but they should be fixed again. If they fail for you, please post on the dev-mailing-list so we can discuss if it is a dev-setup-issue or a problem in the tests themselves. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60810] PartAlreadyExistsException when read slides note
https://bz.apache.org/bugzilla/show_bug.cgi?id=60810 Dominik Stadler changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Dominik Stadler --- I tried to fix this via r1787663, as far as I see this should make it work by doing more checks for already existing names in relationships. I couldn't fully test the resulting file as I did not have access to Powerpoint itself, please verify with a recent nightly build as soon as this is applied there. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #7 from Renjith R --- Thanks a lot for the Inputs, Dominik. Let me work out on these points and I'll get back to you. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
