[Bug 60707] [PATCH] Reading very large excel files using StAX made easier - StreamingWorkbook
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 PJ Fanning changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier - StreamingWorkbook
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #24 from PJ Fanning --- this is abandoned -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier - StreamingWorkbook
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #23 from Renjith R --- Cool! Looks promising. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier - StreamingWorkbook
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #22 from PJ Fanning --- One alternative worth trying is https://github.com/monitorjbl/excel-streaming-reader which is built on top of Apache POI. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier - StreamingWorkbook
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #21 from PJ Fanning --- Renjith - feel free to fork my branch. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier - StreamingWorkbook
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #20 from Renjith R --- Hi PJ Fanning, I believe you have done some code review changes and some tidy ups.Thanks for that. So am I good to take the latest code from your repository(https://github.com/pjfanning/poi.git) with Branch: "streaming-workbook"?. I would like to resume from where I stopped a couple of months back. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier - StreamingWorkbook
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 Dominik Stadler changed: What|Removed |Added Summary|[PATCH] Reading very large |[PATCH] Reading very large |excel files using StAX made |excel files using StAX made |easier. |easier - StreamingWorkbook -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #19 from PJ Fanning --- I created a new branch and Pull Request for the work to date. I took Renjith's patch and did a little tidy up. https://github.com/apache/poi/pull/64 I think we need a fair amount of extra coverage (using different workbooks) and to decide whether enough of the core Workbook API is implemented to proceed. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 Bug 60707 depends on bug 61213, which changed state. Bug 61213 Summary: Replace SXSSFWorkbook copyStreamAndInjectWorksheet with StAX equivalent https://bz.apache.org/bugzilla/show_bug.cgi?id=61213 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #18 from Renjith R --- You can take it from git. https://github.com/ranju4u6/poi/blob/Startup/test-data/spreadsheet/SpreadSheetSample04022017.xlsx Sorry, I did not get a chance to look into your code due to tight work schedule. I have committed my changes to the following branch. https://github.com/ranju4u6/poi/tree/Startup If you find it interesting, please take it up. It may take me a couple of months or more to get into a normal schedule. I'll catch up with you then. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #17 from PJ Fanning --- Renjith - could you attach SpreadSheetSample04022017.xlsx to the issue? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 Dominik Stadler changed: What|Removed |Added Depends on||61213 Referenced Bugs: https://bz.apache.org/bugzilla/show_bug.cgi?id=61213 [Bug 61213] Replace SXSSFWorkbook copyStreamAndInjectWorksheet with StAX equivalent -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #16 from PJ Fanning --- Renjith - the StaxHelper is already merged to the svn trunk (src/java). The rest of the change for using StAX parser for issue 61213 is still under discussion. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #15 from Renjith R --- Sure, I'll look into it. Hope (https://bz.apache.org/bugzilla/show_bug.cgi?id=61213) is the one you are talking about. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #14 from PJ Fanning --- I added a StaxHelper class today because I think it is a good idea for us to apply default configuration to the factories. One benefit is to protect against XML Entity Expansion attacks. Would you be able to uptake this? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #13 from Renjith R --- Did someone get a chance to review the code? I'd be glad to see some comments. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #12 from Renjith R --- I was analyzing 'DateFormatConverter' to see if I can reuse any logic from it. But, as per my understanding, this class is more helpful while writing data to excel. eg convert(Locale.JAPANESE, "dd , "), will generate a data format string which can be used for applying a style to Cell. I'll keep on searching. Please let me know if anyone has any clue on this. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #11 from Renjith R --- I was analyzing 'DateFormatConverter' to see if I can reuse any logic from it. But, as per my understanding, this class is more helpful while writing data to excel. eg convert(Locale.JAPANESE, "dd , "), will generate a data format string which can be used for applying a style to Cell. I'll keep on searching. Please let me know if anyone has any clue on this. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #10 from Renjith R --- Created attachment 34945 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34945&action=edit Version 4: Added @NotImplemented. Added feature getColumnIndex Thanks a lot for the suggestion. Added @NotImplemented. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #9 from Javen O'Neal --- Could you also add a @NotImplemented annotation to methods where you throw Unsupported operation exception? This will make it clear to the Javadocs readers that the method isn't implemented yet. https://poi.apache.org/apidocs/org/apache/poi/util/NotImplemented.html -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #8 from Renjith R --- Created attachment 34943 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34943&action=edit Version 3: Patch with some of the review comments implemented Hi.. I have tried to implement most of the comments. I am still working on reusing the existing methods for reading the date from excel. Since it is time-consuming, I am posting rest of the changes here. Kindly take and look and let me know your queries, suggestions etc.. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #7 from Renjith R --- Thanks a lot for the Inputs, Dominik. Let me work out on these points and I'll get back to you. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 Dominik Stadler changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #6 from Dominik Stadler --- I did a look, here some initial comments: * The initial implementation looks already like a good start, thanks for putting in the work * Maybe we should throw "UnsupportedException" in the methods that are not supported, this way the user immediately knows even if she does not look at the JavaDoc? * As it is complex new functionality, we might first add it to the "scratchpad" project/source-folders so we can let it stabilise some more until we declare it as "production ready" by moving it into the ooxml-part. * Please remove the "// TODO Auto-generated method stub" comments with a comment that explains why the method is empty or with an exception as stated above or simply remove it * Please try to format the code consistently according to our coding-guidelines, see http://poi.apache.org/guidelines.html#CodeStyle, your IDE will usually allow to define it and reformat a whole file in one go. * Is there a way to not duplicate the date-formats in StreamedSheetEventHandler? We already handle them in various places, e.g. DateFormatConverter * On testing I would love to see some test that kind of "trashes" the implementation, i.e. take all spreadsheets that we have under test-data and run the normal XSSFWorkbook/HSSFWorkbook and compare results to your implementation as far as possible. This way we ensure that your code handles all the special cases that can arise. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #5 from Renjith R --- I'll continue to add the functionalities and post the patches here. I will be glad if someone got a chance to review my work. Let me know if you want me to look at anything specific or please guide me if I am moving in a wrong direction. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #4 from Renjith R --- Gentle reminder. Did someone got a chance to look into? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 Dominik Stadler changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 Renjith R changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #3 from Renjith R --- I have implemented Cell, Row, Sheet & Workbook interfaces for easy integration with existing functionality. Methods which needs more research to implement are mentioned as 'Will be supported in future'. Others are also provided with proper comments. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 --- Comment #2 from Renjith R --- Created attachment 34757 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34757&action=edit Patch which implements the interfaces Cell, Row, Sheet & Workbook I have implemented the Cell, Row, Sheet & Workbook interfaces for easy integration with existing functionality. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60707] [PATCH] Reading very large excel files using StAX made easier.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60707 Javen O'Neal changed: What|Removed |Added Keywords||PatchAvailable Status|NEW |NEEDINFO --- Comment #1 from Javen O'Neal --- This looks like a good start and a complement to SXSSFWorbook, which is a write-only streaming API. The unit test for StreamingWorkbook is a nice touch, too. In order to better integrate these classes within POI, they would need to implement the Workbook, Sheet, Row, and Cell interfaces so that someone can write generic Common SS code and switch between HSSF, XSSF, write-SXSSF and sax-read-SXSSF. It's fine to stub out most methods for now as either "will be supported in the future" or "won't be supported due to memory footprint". -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
