[GitHub] incubator-predictionio issue #441: pio batchpredict error
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/441 This doesnât look like a valid PR. @561152 are you looking to report an issue? Please do so by filing a JIRA following instructions at http://predictionio.incubator.apache.org/community/contribute-code/#how-to-report-an-issue ---
[GitHub] incubator-predictionio issue #440: [PIO-101] Document usage of Plug-in of ev...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/440 This is awesome. Thanks @takezoe ! ---
[GitHub] incubator-predictionio issue #438: [PIO-129] Move CLI document
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/438 LGTM. Merging. Thanks @takezoe ! ---
[GitHub] incubator-predictionio issue #436: [PIO-125] Add Spark 2.2 support
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/436 LGTM. Merging. Thanks @marevol ! ---
[GitHub] incubator-predictionio pull request #439: [PIO-131] Fix Apache licensing iss...
Github user dszeto commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/439#discussion_r143087035 --- Diff: docs/manual/source/install/install-sourcecode.html.md.erb --- @@ -28,15 +28,20 @@ Download Apache PredictionIO (incubating) <%= data.versions.pio %> from an Apache [mirror](https://www.apache.org/dyn/closer.cgi/incubator/predictionio/<%= data.versions.pio %>/apache-predictionio-<%= data.versions.pio %>.tar.gz). +Verify this release using [signatures and checksums](https://www.apache.org/ +dist/incubator/predictionio/0.12.0-incubating/) and [project release KEYS]( +https://www.apache.org/dist/incubator/predictionio/KEYS). Refer to +[instructions](http://httpd.apache.org/download.cgi#verify) on how to verify. --- End diff -- I think it would be better to copy those instructions over. ---
[GitHub] incubator-predictionio pull request #439: [PIO-131] Fix Apache licensing iss...
Github user dszeto commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/439#discussion_r143086982 --- Diff: docs/manual/source/install/install-sourcecode.html.md.erb --- @@ -28,15 +28,20 @@ Download Apache PredictionIO (incubating) <%= data.versions.pio %> from an Apache [mirror](https://www.apache.org/dyn/closer.cgi/incubator/predictionio/<%= data.versions.pio %>/apache-predictionio-<%= data.versions.pio %>.tar.gz). +Verify this release using [signatures and checksums](https://www.apache.org/ +dist/incubator/predictionio/0.12.0-incubating/) and [project release KEYS]( --- End diff -- How about using `data.versions.pio` instead? ---
[GitHub] incubator-predictionio issue #436: [PIO-125] Add Spark 2.2 support
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/436 @marevol Apache installed `docker-compose` on their Jenkins finally. We can move these tests there for faster build time. ---
[GitHub] incubator-predictionio issue #436: [PIO-125] Add Spark 2.2 support
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/436 Hey @marevol , any idea with the failing test? I'm wondering if the new Guava dependency is not working fine with older Hadoop/Spark. ---
[GitHub] incubator-predictionio-sdk-ruby issue #22: Add support for Ruby 2.4
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-sdk-ruby/pull/22 Thanks for fixing this, @anothermh ! Sorry that the contribution guide is outdated. I will update it. Meanwhile, please follow https://github.com/apache/incubator-predictionio/blob/develop/CONTRIBUTING.md and create a ticket with component `Ruby SDK` to describe this. ---
[GitHub] incubator-predictionio-sdk-ruby issue #21: Normalize eventTime format to iso...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-sdk-ruby/pull/21 Thanks for the fix @shouya ! Sorry that it took a bit to merge. ---
[GitHub] incubator-predictionio-sdk-python pull request #23: Update project info
Github user dszeto commented on a diff in the pull request: https://github.com/apache/incubator-predictionio-sdk-python/pull/23#discussion_r138747266 --- Diff: setup.py --- @@ -3,8 +3,8 @@ except ImportError: from distutils.core import setup -__author__ = "The PredictionIO Team" -__email__ = "h...@tappingstone.com" +__author__ = "Apache PredictionIO" +__email__ = "u...@predictionio.incubator.apache.org" __copyright__ = "Copyright 2014, TappingStone, Inc." --- End diff -- Yes we should. In fact, we should also change all other SDKs to reflect that. Thanks for taking care of this! ---
[GitHub] incubator-predictionio issue #434: Update install-sourcecode.html.md.erb
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/434 Thanks for catching! ---
[GitHub] incubator-predictionio issue #433: Update webhooks.html.md.erb
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/433 Merging. Thanks @aayush142128 ! ---
[GitHub] incubator-predictionio issue #431: Update templates.yaml - user name change
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/431 Verified that GitHub is forwarding repos from the previous user to the new user. Merging. Thanks @thomasste ! ---
[GitHub] incubator-predictionio issue #367: [PIO-59] Use /dev/urandom to create acces...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/367 I am convinced that this PR does not decrease the security of generating random app access keys. I will merge if there is no objection. ---
[GitHub] incubator-predictionio issue #427: [PIO-116] PySpark Support
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/427 Verified working with Python 2. Thanks! ---
[GitHub] incubator-predictionio issue #427: [PIO-116] PySpark Support
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/427 @marevol Looks like Python 3 is also a hard requirement? This does not work when I run `pyspark` with Python 2. ---
[GitHub] incubator-predictionio issue #430: [PIO-119] Bump up Elasticsearch to 5.5.2
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/430 @mars may want to test this. ---
[GitHub] incubator-predictionio pull request #424: Implement Storage app & channel na...
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/424#discussion_r134588503
--- Diff:
data/src/main/scala/org/apache/predictionio/data/store/Common.scala ---
@@ -19,35 +19,46 @@
package org.apache.predictionio.data.store
import org.apache.predictionio.data.storage.Storage
+import scala.collection.mutable
import grizzled.slf4j.Logger
private[predictionio] object Common {
@transient lazy val logger = Logger[this.type]
@transient lazy private val appsDb = Storage.getMetaDataApps()
@transient lazy private val channelsDb = Storage.getMetaDataChannels()
+ // Memoize app & channel name-to-ID resolution to avoid excessive
storage IO
+ @transient lazy val appNameToIdCache =
+mutable.Map[(String, Option[String]), (Int, Option[Int])]()
/* throw exception if invalid app name or channel name */
def appNameToId(appName: String, channelName: Option[String]): (Int,
Option[Int]) = {
-val appOpt = appsDb.getByName(appName)
-
-appOpt.map { app =>
- val channelMap: Map[String, Int] = channelsDb.getByAppid(app.id)
-.map(c => (c.name, c.id)).toMap
-
- val channelId: Option[Int] = channelName.map { ch =>
-if (channelMap.contains(ch)) {
- channelMap(ch)
-} else {
- logger.error(s"Invalid channel name ${ch}.")
- throw new IllegalArgumentException(s"Invalid channel name
${ch}.")
+val cacheHit = appNameToIdCache.get(appName, channelName)
+cacheHit match {
+ case Some((a: Int, c: Option[Int])) => (a,c)
+ case None => {
+val appOpt = appsDb.getByName(appName)
+
+appOpt.map { app =>
+ val channelMap: Map[String, Int] = channelsDb.getByAppid(app.id)
+.map(c => (c.name, c.id)).toMap
+
+ val channelId: Option[Int] = channelName.map { ch =>
+if (channelMap.contains(ch)) {
+ channelMap(ch)
+} else {
+ logger.error(s"Invalid channel name ${ch}.")
+ throw new IllegalArgumentException(s"Invalid channel name
${ch}.")
+}
+ }
+
+ appNameToIdCache((appName, channelName)) = (app.id, channelId)
+ (app.id, channelId)
+}.getOrElse {
+ logger.error(s"Invalid app name ${appName}")
+ throw new IllegalArgumentException(s"Invalid app name
${appName}")
--- End diff --
It looks like this whole block can be simplified to
```scala
appNameToIdCache.getOrElseUpdate((appName, channelName), {
val appOpt = ...
appOpt map { app =>
...
val channelId: Option[Int] = ...
// do not need to set appNameToIdCache here manually
(app.id, channelId)
} getOrElse {
...
}
})
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #387: Oracle databas supports
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/387 You will need to use `docker` commands to either read volumes that were attached to running containers. The test is designed to return non-zero exit code if any tests fail, so if you can run to the end with a zero exit code that would mean tests are passing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #418: batchpredict docs
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/418 LGTM. Thanks @mars ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #405: [PIO-63]Add incubator logo and disclaimer...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/405 @takezoe It's done by our Jenkins project on ASF: https://builds.apache.org/job/PredictionIO-build-site/69/console Looks like the site built correctly but the publish step failed. I am investigating. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #417: [PIO-66] JIRA and release process for Pre...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/417 @shimamoto @takezoe Yes that sounds good. I'll merge this. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #417: [PIO-66] JIRA and release process for Pre...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/417 Hey, what do you think about putting Release Cadence under the Getting Involved section? We should probably clean up the Resources section because it sounds pretty generic. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #412: [PIO-105] Batch Predictions
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/412 Created https://issues.apache.org/jira/browse/PIO-110 and https://issues.apache.org/jira/browse/PIO-111 as follow-ups. Thanks @mars for the feature and @takezoe for the feedback! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #406: [PIO-102] Fix ESEngineInstances `getAll` ...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/406 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #387: Oracle databas supports
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/387 These reports are generated by `XMLTestRunner` in `tests/pio_tests/tests.py`, which are generated inside the container. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #401: [PIO-72] Fix class loading for pio-shell
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/401 LGTM. Thanks @chanlee514 @mars ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #407: [PIO-104] Make proper implementation of p...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/407 LGTM. Thanks @takezoe ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #405: [PIO-63]Add incubator logo and disclaimer...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/405 @takezoe @shimamoto Sorry for the late reply. I took a look and I think the current approach is good. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #355: [PIO-56] Adding embedded database and moc...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/355 Sorry for the late reply. LGTM and merging. Thanks @lucasbm88 ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #387: Oracle databas supports
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/387 Should be ``` tests/run_docker.sh $METADATA_REP $EVENTDATA_REP $MODELDATA_REP \ "python3 /PredictionIO/tests/pio_tests/tests.py" ``` where you replace those variables with `ORACLE` where applicable. This is assuming you have built the Docker image using `tests/build_docker.sh`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #387: Oracle databas supports
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/387 @liningalex Let us know how we can help. This is a great PR and we would like to get it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #412: [PIO-105] Batch Predictions
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/412 LGTM. Great work @mars ! Agree with @takezoe 's comments. I think there are a few follow up tasks we should do. 1. Refactor common code that exists in both `CreateServer` and `BatchPredict`. 2. Brush up Scala coding style as pointed out by @takezoe . 3. Document the new feature in the doc site. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #404: [PIO-100] Remove SLF4J warning message on...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/404 LGTM. I checked the dependency tree and looks like this is the easiest way out. Many transitive dependencies rely on `slf4j-log4j12`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #387: Oracle databas supports
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/387 We don't have any documentation (which we should add later) on how that's done, but basically, it would be adding a new combination in the test matrix (https://github.com/apache/incubator-predictionio/blob/develop/.travis.yml), and setting up https://github.com/apache/incubator-predictionio/blob/develop/tests/docker-compose.yml to bring up a container running Oracle. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #403: [PIO-97] Fixes docs under the PredictionI...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/403 LGTM. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #400: [PIO-97] Fixes examples of the official t...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/400 LGTM. Please feel free to merge once it's reviewed by one of us (in this case, @takezoe). Thanks @shimamoto ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #397: [PIO-69] Update LICENSE.txt and NOTICE.tx...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/397 @takezoe Excellent work. Thanks! ð I think the only concern left is to make sure whenever we add a new dependency that does not have clear indication of license compatibility, it will be caught automatically. We probably need to write a script and put in an exclusion file for those that we have manually verified, and put this check as part of our automated tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6 (and fix dep...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/391 Sorry for the late reply. Agree we should start properly deprecating it. Regarding the inconsistency, I think we should correct `0.98.6 in https://predictionio.incubator.apache.org/install/`, and indicate right now 0.98.5 is the minimum compatible version, but it is deprecated. I think it is okay to keep a more recent HBase version in the installation instructions though, so that new users do not install an EOMed version of HBase. Thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #387: Oracle databas supports
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/387 Hey @liningalex, if you don't have a chance adding integration test yet, I would like to merge this to a feature branch so that we can join forces on that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #393: [PIO-94] Fix to show stacktrace for error...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/393 LGTM. Thanks @mars ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #394: [PIO-95] Extend request timeout for REST ...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/394 @mars let's file a different JIRA for exposing engine server configuration in a generic way. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio pull request #394: [PIO-95] Extend request timeout fo...
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/394#discussion_r122524115
--- Diff: common/src/main/resources/application.conf ---
@@ -9,3 +9,7 @@ spray.can {
verbose-error-messages = "on"
}
}
+
+spray.can.server {
+ request-timeout = 35s
+}
--- End diff --
@mars You can put `request-timeout` inside the block above. We don't need
to repeat `spray.can.server`. The configuration library will flatten the
hierarchical configuration key.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/391 @takezoe LGTM. Mind also updating the documentation in this PR to reflect the new minimum requirement (http://predictionio.incubator.apache.org/install/)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #387: Oracle databas supports
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/387 @liningalex Is the main motivation for a separate `OJDBC` set of classes due to Oracle requiring different column types? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #390: Fix duplicate org name
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/390 @duksis asfgit closes it automatically when your change is merged to develop. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio pull request #385: [PIO-72] Fix class loading for pio...
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/385#discussion_r120960881
--- Diff: bin/compute-classpath.sh ---
@@ -17,36 +17,35 @@
# limitations under the License.
#
-SCALA_VERSION=2.10
-
# Figure out where PredictionIO is installed
FWDIR="$(cd `dirname $0`/..; pwd)"
. ${FWDIR}/bin/load-pio-env.sh
-# Build up classpath
-CLASSPATH="${PIO_CONF_DIR}"
-
-CLASSPATH="$CLASSPATH:${FWDIR}/plugins/*:${FWDIR}/lib/spark/*"
-
-ASSEMBLY_DIR="${FWDIR}/assembly"
-
if [ -n "$JAVA_HOME" ]; then
JAR_CMD="$JAVA_HOME/bin/jar"
else
JAR_CMD="jar"
fi
# Use pio-assembly JAR from either RELEASE or assembly directory
+ASSEMBLY_DIR="${FWDIR}/assembly"
--- End diff --
I think we have a bug here and in our testing Docker builds. If you try
this on a completely clean code tree, do `./make-distribution.sh` and directly
run `bin/pio`, it stops working.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #383: [PIO-65] Cache downloaded jars in Travis ...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/383 Merged. Thanks @takezoe ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #387: Oracle databas supports
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/387 @liningalex could you also please open a ticket on our Apache JIRA to help with tracking? Thanks! I will conduct a more thorough review ASAP. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #387: Oracle databas supports
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/387 @takezoe A quick search reveals https://hub.docker.com/r/wnameless/oracle-xe-11g/, but this limits the guarantee to whatever Oracle XE 11g supports. @liningalex would you mind taking a look at this option? Let us know if you need help adding integration test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #368: Update linux distro url
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/368 Hey @steven-haddix , sorry for the late response and thanks for the PR. A couple comments about this PR. The Linux manual installation page is supposed to be used with binary distributions of PredictionIO, which we are tackling here: https://issues.apache.org/jira/browse/PIO-69 Also Apache encourages the use of their distributions mirrors instead of hitting their archive server directly, thus this instruction: http://predictionio.incubator.apache.org/install/install-sourcecode/#downloading-source-code. It would be great to find a way for `wget` to work automatically with Apache mirrors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-sdk-ruby issue #20: Enable create event in batch
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-sdk-ruby/pull/20 LGTM. Thanks @kahirul ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-sdk-ruby issue #20: Enable create event in batch
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-sdk-ruby/pull/20 LGTM. Thanks @kahirul ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #371: [PIO-61] Add S3 Model Data Repository
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/371 Sorry for the delay. I was on vacation. This looks great to me, especially the use of `localstack`. I think the Travis failed downloading a Python library and erred out. It shouldn't matter IMO. I'll merge this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-sdk-ruby issue #19: Add ability to push events to spe...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-sdk-ruby/pull/19 LGTM. Thanks @ZhKostev ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #383: [PIO-65] Cache downloaded jars in Travis ...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/383 We should perhaps ping them again so we don't have to be stuck with Travis: https://issues.apache.org/jira/browse/INFRA-13543 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #382: [PIO-64] Fixed a bug that JDBCPEvents uni...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/382 Hey @emergentorder, do you have a chance to take a look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #377: Update analytics-ipynb.html.md.erb
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/377 To obtain committership, one would contribute and earn a nomination from a PMC member. Once the PMC voted favorably, the nominee will gain committership (the ability to push code directly to Apache repo). You are highly encouraged to make further contributions if committership is your goal. Please see http://apache.org/dev/. All Apache projects are governed similarly according to rules laid by the Apache Software Foundation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-template-text-classifier issue #12: Bump to PIO 0.11....
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-template-text-classifier/pull/12 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-template-text-classifier issue #9: Filter out stop wo...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-template-text-classifier/pull/9 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-template-text-classifier issue #8: Changed tokenizer ...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-template-text-classifier/pull/8 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-template-text-classifier issue #11: Create build.prop...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-template-text-classifier/pull/11 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #380: Pio train v0.11.0-incubating
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/issues/380 Hi, please redirect usage questions to u...@predictionio.incubator.apache.org, and development question to dev@predictionio.incubator.apache.org for more exposure to the rest of the community. Subscription instructions can be found at http://predictionio.incubator.apache.org/support/. Can you provide more information such as the template you have tried, your environment locally, how you built PredictionIO, etc? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-template-attribute-based-classifier issue #9: Python3...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-template-attribute-based-classifier/pull/9 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-template-attribute-based-classifier issue #10: Bump t...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-template-attribute-based-classifier/pull/10 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-template-attribute-based-classifier pull request #5: ...
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio-template-attribute-based-classifier/pull/5#discussion_r114821537
--- Diff: src/main/scala/Engine.scala ---
@@ -3,11 +3,13 @@ package org.template.classification
import io.prediction.controller.EngineFactory
import io.prediction.controller.Engine
-class Query(
- val attr0 : Double,
- val attr1 : Double,
- val attr2 : Double
-) extends Serializable
+class Query extends Serializable{
+ var attrs: Seq[Double] = null
+ def this(attrs: Double*) {
+this()
+this.attrs = attrs
+ }
+}
--- End diff --
Hey @mzjgithub , wondering why we need to have an auxiliary constructor
here. Can we simply have
```scala
class Query(val attrs: Seq[Double]) extends Serializable
```
?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio-template-ecom-recommender issue #12: Bump to PIO 0.11...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-template-ecom-recommender/pull/12 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-template-ecom-recommender issue #4: Develpg: Implemen...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-template-ecom-recommender/pull/4 Hi @goliasz , is this still work in progress or ready to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-template-skeleton issue #6: Bump to PIO 0.11.0-incuba...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-template-skeleton/pull/6 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-template-recommender issue #15: Bump to PIO 0.11.0-in...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-template-recommender/pull/15 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-template-skeleton issue #5: Example Tests
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-template-skeleton/pull/5 Thanks! Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-template-recommender issue #4: Migrate to sbt-assembl...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-template-recommender/pull/4 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-template-recommender issue #6: Fix small typo
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-template-recommender/pull/6 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio-template-recommender issue #12: Python 3 support for ...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio-template-recommender/pull/12 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #371: [PIO-61] Add S3 Model Data Repository
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/371 @marevol Would you like to add some integration test for this? https://github.com/jubos/fake-s3 or https://github.com/atlassian/localstack might be useful for mocking S3 locally within Travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #378: Bump to sbt 0.13.15
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/378 Test failure irrelevant to the change. Filed a ticket to track fixing tests: https://issues.apache.org/jira/browse/PIO-64 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #376: Fix docs because pio template is no longe...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/376 @takezoe Guidelines are here: http://predictionio.incubator.apache.org/community/contribute-documentation/ tl;dr - Use the livedoc branch if you want to update the current documentation. - Use the develop branch if you want to write documentation for the next release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #377: Update analytics-ipynb.html.md.erb
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/377 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #374: ES storage improvement/refactoring
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/374 LGTM. I'd like to suggest us to get into the habit of filing JIRA tickets for all changes. It will make the release notes writer easier to figure out what's been changed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #375: [ERROR] [Engine$] No engine found. Your b...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/issues/375 Hi, please redirect usage questions to u...@predictionio.incubator.apache.org, and development question to dev@predictionio.incubator.apache.org for more exposure to the rest of the community. Subscription instructions can be found at http://predictionio.incubator.apache.org/support/. Did you also modify your engine template's Scala version to 2.11.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #373: Improve insert performance for ES storage
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/373 LGTM. By the way, are you working with ES 5.2/5.3? @mars bumped into issues with ES 5.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio pull request #371: [PIO-61] Add S3 Model Data Reposit...
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/371#discussion_r113326594
--- Diff: storage/s3/build.sbt ---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import PIOBuild._
+
+name := "apache-predictionio-data-s3"
+
+libraryDependencies ++= Seq(
+ "org.apache.predictionio" %% "apache-predictionio-core" % version.value
% "provided",
+ "com.google.guava"% "guava" % "14.0.1"
% "provided",
+ "com.amazonaws" % "aws-java-sdk-s3" % "1.11.118",
+ "org.scalatest" %% "scalatest"% "2.1.7" %
"test")
+
+parallelExecution in Test := false
+
+pomExtra := childrenPomExtra.value
+
+assemblyOption in assembly := (assemblyOption in
assembly).value.copy(includeScala = false)
+
+assemblyShadeRules in assembly := Seq(
+ ShadeRule.rename("org.apache.http.**" ->
"shadeio.data.s3.http.@1").inAll,
+ ShadeRule.rename("com.fasterxml.**" ->
"shadeio.data.s3.fasterxml.@1").inAll
+)
--- End diff --
I think @mars is seeing some issues with
https://github.com/apache/incubator-predictionio/blob/develop/storage/elasticsearch/build.sbt#L42.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #370: Add EVENTDATA_REFRESH for elasticsearch
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/370 LGTM. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio pull request #371: [PIO-61] Add S3 Model Data Reposit...
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/371#discussion_r112760158
--- Diff: storage/s3/build.sbt ---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import PIOBuild._
+
+name := "apache-predictionio-data-s3"
+
+libraryDependencies ++= Seq(
+ "org.apache.predictionio" %% "apache-predictionio-core" % version.value
% "provided",
+ "com.google.guava"% "guava" % "14.0.1"
% "provided",
+ "com.amazonaws" % "aws-java-sdk-s3" % "1.11.118",
+ "org.scalatest" %% "scalatest"% "2.1.7" %
"test")
+
+parallelExecution in Test := false
+
+pomExtra := childrenPomExtra.value
+
+assemblyOption in assembly := (assemblyOption in
assembly).value.copy(includeScala = false)
+
+assemblyShadeRules in assembly := Seq(
+ ShadeRule.rename("org.apache.http.**" ->
"shadeio.data.s3.http.@1").inAll,
+ ShadeRule.rename("com.fasterxml.**" ->
"shadeio.data.s3.fasterxml.@1").inAll
+)
--- End diff --
Hey @marevol can you explain a little bit regarding these shade rules,
please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #370: Add EVENTDATA_REFRESH for elasticsearch
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/370 Thanks @marevol ! Do you know if the REST client allows configuration by file? For the old ES1 client, one could supply an `elasticsearch.yml` file for the client to read in the rest of the configuration. I took a look at the REST client documentation and could not see something equivalent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #363: Migrate Spray to Akka http
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/issues/363 Hi, please redirect usage questions to u...@predictionio.incubator.apache.org, and development question to dev@predictionio.incubator.apache.org for more exposure to the rest of the community. Subscription instructions can be found at http://predictionio.incubator.apache.org/support/. @anandaverma Thanks for offering help. With the new flexible build system, it is possible to use Akka HTTP only for the 2.11 build. It would probably be a little tricky to keep the code compatible with both Spray and Akka HTTP though. We do have an open ticket for this: https://issues.apache.org/jira/browse/PIO-31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #359: [PIO-57] Add SBT Native Packager
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/359 Hey @marevol , running into this: ``` + sbt/sbt assembly/rpm:packageBin [info] Loading global plugins from /Users/dszeto/.sbt/0.13/plugins [info] Loading project definition from /Users/dszeto/asf/incubator-predictionio/project [info] Set current project to apache-predictionio-parent (in build file:/Users/dszeto/asf/incubator-predictionio/) [error] error: Group field must be present in package: (main package) [error] error: Package has no %description: predictionio-0.11.0_SNAPSHOT-1.noarch [info] Building target platforms: noarch-apache-Linux java.lang.RuntimeException: Unable to run rpmbuild, check output for details. Errorcode 1 at scala.sys.package$.error(package.scala:27) at com.typesafe.sbt.packager.rpm.RpmHelper$$anonfun$buildPackage$1.apply(RpmHelper.scala:91) at com.typesafe.sbt.packager.rpm.RpmHelper$$anonfun$buildPackage$1.apply(RpmHelper.scala:68) at sbt.IO$.withTemporaryDirectory(IO.scala:344) at com.typesafe.sbt.packager.rpm.RpmHelper$.buildPackage(RpmHelper.scala:68) at com.typesafe.sbt.packager.rpm.RpmHelper$.buildRpm(RpmHelper.scala:20) at com.typesafe.sbt.packager.rpm.RpmPlugin$$anonfun$projectSettings$46.apply(RpmPlugin.scala:161) at com.typesafe.sbt.packager.rpm.RpmPlugin$$anonfun$projectSettings$46.apply(RpmPlugin.scala:157) at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47) at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40) at sbt.std.Transform$$anon$4.work(System.scala:63) at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228) at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228) at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17) at sbt.Execute.work(Execute.scala:237) at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228) at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228) at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159) at sbt.CompletionService$$anon$2.call(CompletionService.scala:28) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) [error] (assembly/rpm:packageBin) Unable to run rpmbuild, check output for details. Errorcode 1 [error] Total time: 0 s, completed Mar 28, 2017 10:25:38 AM ``` ``` $rpmbuild --version rpmbuild (RPM) 5.4.15 ``` I am on macOS Sierra 10.12.3. Have you run into this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio pull request #365: Remove duplicate settings.
Github user dszeto commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/365#discussion_r108459590 --- Diff: tools/build.sbt --- @@ -27,8 +27,6 @@ libraryDependencies ++= Seq( "io.spray" %% "spray-testkit" % "1.3.3" % "test", "org.specs2" %% "specs2" % "2.3.13" % "test") -dependencyOverrides += "org.slf4j" % "slf4j-log4j12" % "1.7.18" - --- End diff -- There was probably a SLF4J provider conflict before. Should be good to remove. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #364: [PIO-30] Spark 2 support on sbt way
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/364 I would still like to merge some of your changes if you are okay with that. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #364: [PIO-30] Spark 2 support on sbt way
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/364 @shimamoto We can't really release binary packages on Apache yet until we have reviewed all packaged transitive dependencies comply with Apache policies. It will be a non-trivial exercise. Many people want to ship 0.11 as soon as possible, so it would probably be the next release. We will still require users to build their own package, so cross building everything in one shot would take too much time for them. The goal is mostly about being flexible to use different dependencies instead of enforcing a set. We probably will only officially test Scala 2.10 + Spark 1.6, and Scala 2.11 + Spark 2. I tried other combos but haven't been able to make them work yet. Agree the ES dep need to be fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #364: [PIO-30] Spark 2 support on sbt way
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/364 @shimamoto I realized the original build system was quite inflexible, so I went ahead and did this in the last couple days: https://travis-ci.org/apache/incubator-predictionio/builds/212014483. It's very close to working with tests across different dependencies. My apologies without syncing up with you. The build system on that branch basically allows you to do this: ``` ./make-distribution.sh -Dscala.version=2.10.6 -Dspark.version=2.1.0 -Dhadoop.version=2.7.3 -Delasticsearch.version=5.2.2 ``` The script does not cross build, but `crossScalaVersions` in `build.sbt` is already defined, so it's possible to cross build and cross publish artifacts. `make-distribution.sh` could possibly be extended to produce more than one tarballs as well. Also, before `docker-compose` becomes available on Apache Jenkins, I am using that as a multi-build just to make sure things compile across versions: https://builds.apache.org/job/incubator-predictionio-multibuild/ Could you take a look at this branch and see how it looks to you? It would be great to converge our changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #362: Move storage depended tests to each stora...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/362 Thanks for spotting this! The latest unit tests are actually failing but exited with a 0 code. Debugging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #362: Move storage depended tests to each stora...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/362 @takezoe How did you trigger the compilation error? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #359: [PIO-57] Add SBT Native Packager
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/359 This is nice work! Would it be easier to wrap it with a script like what we are doing with make-distribution.sh? Also we are looking to release 0.11 soon once PIO-30 finished testing, so let me know if you need help to get this in, or set it aside for the next release. Also hoping to put up a release roadmap after 0.11 for discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #358: Update event serialization for ES5
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/358 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio pull request #359: [PIO-57] Add SBT Native Packager
Github user dszeto commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/359#discussion_r106041756 --- Diff: .travis.yml --- @@ -47,7 +47,7 @@ env: - BUILD_TYPE=Unit METADATA_REP=PGSQL EVENTDATA_REP=PGSQL MODELDATA_REP=PGSQL - BUILD_TYPE=Integration METADATA_REP=PGSQL EVENTDATA_REP=PGSQL MODELDATA_REP=PGSQL - BUILD_TYPE=Integration METADATA_REP=ELASTICSEARCH EVENTDATA_REP=HBASE MODELDATA_REP=LOCALFS ES_VERSION=5 -- BUILD_TYPE=Integration METADATA_REP=ELASTICSEARCH EVENTDATA_REP=PGSQL MODELDATA_REP=HDFS ES_VERSION=5 +- BUILD_TYPE=Integration METADATA_REP=ELASTICSEARCH EVENTDATA_REP=ELASTICSEARCH MODELDATA_REP=HDFS ES_VERSION=5 --- End diff -- Let's create a new entry if you want to test a new combination. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #361: Add solution for Hbase failure after disk...
Github user dszeto commented on the issue: https://github.com/apache/incubator-predictionio/pull/361 Awesome. Thanks @linamy85 ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio pull request #:
Github user dszeto commented on the pull request: https://github.com/apache/incubator-predictionio/commit/947db5e1b6e1ff629ef5bcb4412c92309e2a1354#commitcomment-21282274 @marevol Thanks for looking! I just saw that too and am pretty sad that it would require switching back to VM-based Travis. I am going to try one more thing and see if that would work before turning sudo back on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio pull request #357: [PIO-51] Properly locate engine di...
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/357#discussion_r105085253
--- Diff:
tools/src/main/scala/org/apache/predictionio/tools/console/Console.scala ---
@@ -734,7 +734,7 @@ object Console extends Logging {
}
}
- def getEngineInfo(jsonFile: File): EngineInfo = {
+ def getEngineInfo(jsonFile: File, engineDir: Option[String]): EngineInfo
= {
--- End diff --
@chanlee514 should we just pass in a `String` here? It doesn't look like
there would be a case for `None`. It also looks like
`o.a.p.tools.Common.getEngineDirPath` has already taken care of getting the
current working directory, so I think it should be safe to just drop using
`user.dir` completely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
