Re: [DISCUSS] Apache Pulsar 2.7.3 Release
+1 Regards, Shivji Kumar Jha http://www.shivjijha.com/ +91 8884075512 On Fri, 25 Jun 2021 at 10:24, Guangning E wrote: > +1 > > 丛搏 于2021年6月25日周五 下午12:10写道: > > > Hi all, > > > > How are you? I think you must be doing well. It has been two months > since > > we released > > the Apache Pulsar 2.7.2. We have a lot of fixes already merged. So I > would > > like to start to > > prepare our next patch release in the next few days. > > > > You can find the whole change list of the 2.7.3 release from: > > > > https://github.com/apache/pulsar/pulls?q=is%3Apr+label%3Arelease%2F2.7.3 > > > > If I missed some features, please let me know. And if some PRs can't > > complete in a few days, > > the owner can help check if we should include them in 2.7.3 or push them > to > > the next release version. > > > > Thanks, > > Bo > > >
Re: [DISCUSS] Apache Pulsar 2.7.3 Release
+1 丛搏 于2021年6月25日周五 下午12:10写道: > Hi all, > > How are you? I think you must be doing well. It has been two months since > we released > the Apache Pulsar 2.7.2. We have a lot of fixes already merged. So I would > like to start to > prepare our next patch release in the next few days. > > You can find the whole change list of the 2.7.3 release from: > > https://github.com/apache/pulsar/pulls?q=is%3Apr+label%3Arelease%2F2.7.3 > > If I missed some features, please let me know. And if some PRs can't > complete in a few days, > the owner can help check if we should include them in 2.7.3 or push them to > the next release version. > > Thanks, > Bo >
[DISCUSS] Apache Pulsar 2.7.3 Release
Hi all, How are you? I think you must be doing well. It has been two months since we released the Apache Pulsar 2.7.2. We have a lot of fixes already merged. So I would like to start to prepare our next patch release in the next few days. You can find the whole change list of the 2.7.3 release from: https://github.com/apache/pulsar/pulls?q=is%3Apr+label%3Arelease%2F2.7.3 If I missed some features, please let me know. And if some PRs can't complete in a few days, the owner can help check if we should include them in 2.7.3 or push them to the next release version. Thanks, Bo
[pulsar-io] Allow connector to access pulsar cluster via Context
Hi All, I'm working on a PR that allows connectors to get the pulsar client via context object. In this way, the connectors will be able to utilize the pulsar cluster to do message pub/sub. The use case for the change comes from the debezium connector. In order to access a pulsar topic as backing store, the connector currently creates its own pulsar client without any auth. This is undesirable and causes some problems for us. A clean way to do it is to allow it access the pulsar client inherited from FunctionWorker. This client is authed and secure. The draft PR is here: https://github.com/apache/pulsar/pull/11056 Based on some comments, it seems the community has previously discussed similar issues. Just want to hear people's thoughts and see how we can move this forward. Best Regards, Neng Lu
[GitHub] [pulsar-helm-chart] eolivelli commented on issue #134: Change to PULSAR_GC in values.yaml -XX args for Pulsar 2.8.0 needed
eolivelli commented on issue #134: URL: https://github.com/apache/pulsar-helm-chart/issues/134#issuecomment-867942324 Are you interested in sending a patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #135: Fix deprecation warning about rbac.authorization.k8s.io/v1beta1
lhotari opened a new pull request #135: URL: https://github.com/apache/pulsar-helm-chart/pull/135 ### Motivation Installing with helm shows this type of warning ``` W0624 17:14:41.741744 3044383 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding ``` ### Modifications Apply the fix suggested in the warning message. ### Verifying this change - [ ] Make sure that the change passes the CI checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-helm-chart] 871921256 commented on issue #134: Change to PULSAR_GC in values.yaml -XX args for Pulsar 2.8.0 needed
871921256 commented on issue #134: URL: https://github.com/apache/pulsar-helm-chart/issues/134#issuecomment-867631335 I also encounter this problem, and when I start ZK, I also report an error. Only when I use the old image 2.7.2 to start. images: zookeeper: repository: apachepulsar/pulsar-all tag: 2.7.2 pullPolicy: IfNotPresent bookie: repository: apachepulsar/pulsar-all tag: 2.8.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-adapters] atezs82 commented on a change in pull request #14: [pulsar-spark] added option for configuring Pulsar client
atezs82 commented on a change in pull request #14: URL: https://github.com/apache/pulsar-adapters/pull/14#discussion_r657772386 ## File path: pulsar-spark/src/main/java/org/apache/pulsar/spark/SparkStreamingPulsarReceiver.java ## @@ -43,34 +46,52 @@ private static final Logger LOG = LoggerFactory.getLogger(SparkStreamingPulsarReceiver.class); private String serviceUrl; -private ConsumerConfigurationData conf; +private Map clientConfig; +private ConsumerConfigurationData consumerConfig; private Authentication authentication; private PulsarClient pulsarClient; private Consumer consumer; public SparkStreamingPulsarReceiver( String serviceUrl, -ConsumerConfigurationData conf, +ConsumerConfigurationData consumerConfig, Authentication authentication) { -this(StorageLevel.MEMORY_AND_DISK_2(), serviceUrl, conf, authentication); +this(StorageLevel.MEMORY_AND_DISK_2(), serviceUrl, new HashMap<>(), consumerConfig, authentication); +} + +public SparkStreamingPulsarReceiver( Review comment: I would be happy to remove eg. the one having a default storage level: ``` public SparkStreamingPulsarReceiver( String serviceUrl, Map clientConfig, ConsumerConfigurationData consumerConfig, Authentication authentication) { this(StorageLevel.MEMORY_AND_DISK_2(), serviceUrl, clientConfig, consumerConfig, authentication); } ``` In that way we might have broader functionality (we just enforce the user to set the storage level whenever client configuration is provided). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-adapters] atezs82 commented on a change in pull request #14: [pulsar-spark] added option for configuring Pulsar client
atezs82 commented on a change in pull request #14: URL: https://github.com/apache/pulsar-adapters/pull/14#discussion_r657769442 ## File path: pulsar-spark/src/main/java/org/apache/pulsar/spark/SparkStreamingPulsarReceiver.java ## @@ -43,34 +46,52 @@ private static final Logger LOG = LoggerFactory.getLogger(SparkStreamingPulsarReceiver.class); private String serviceUrl; -private ConsumerConfigurationData conf; +private Map clientConfig; +private ConsumerConfigurationData consumerConfig; private Authentication authentication; private PulsarClient pulsarClient; private Consumer consumer; public SparkStreamingPulsarReceiver( String serviceUrl, -ConsumerConfigurationData conf, +ConsumerConfigurationData consumerConfig, Authentication authentication) { -this(StorageLevel.MEMORY_AND_DISK_2(), serviceUrl, conf, authentication); +this(StorageLevel.MEMORY_AND_DISK_2(), serviceUrl, new HashMap<>(), consumerConfig, authentication); +} + +public SparkStreamingPulsarReceiver( Review comment: The idea behind adding 2 new constructors to the 2 existing ones is I wanted to allow users of the interface to be able to configure Pulsar clients regardless whether they want to specify a storage level or leave it to default. Also, I wanted to keep previous constructors as well to keep backward compatibility. Please let me know what do you think about this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-adapters] atezs82 commented on a change in pull request #14: [pulsar-spark] added option for configuring Pulsar client
atezs82 commented on a change in pull request #14: URL: https://github.com/apache/pulsar-adapters/pull/14#discussion_r657762984 ## File path: pulsar-spark/src/main/java/org/apache/pulsar/spark/SparkStreamingPulsarReceiver.java ## @@ -43,34 +46,52 @@ private static final Logger LOG = LoggerFactory.getLogger(SparkStreamingPulsarReceiver.class); private String serviceUrl; -private ConsumerConfigurationData conf; +private Map clientConfig; +private ConsumerConfigurationData consumerConfig; private Authentication authentication; private PulsarClient pulsarClient; private Consumer consumer; public SparkStreamingPulsarReceiver( String serviceUrl, -ConsumerConfigurationData conf, +ConsumerConfigurationData consumerConfig, Authentication authentication) { -this(StorageLevel.MEMORY_AND_DISK_2(), serviceUrl, conf, authentication); +this(StorageLevel.MEMORY_AND_DISK_2(), serviceUrl, new HashMap<>(), consumerConfig, authentication); +} + +public SparkStreamingPulsarReceiver( +String serviceUrl, +Map clientConfig, +ConsumerConfigurationData consumerConfig, +Authentication authentication) { +this(StorageLevel.MEMORY_AND_DISK_2(), serviceUrl, clientConfig, consumerConfig, authentication); +} + +public SparkStreamingPulsarReceiver(StorageLevel storageLevel, Review comment: Thanks for the finding, corrected this in the upcoming patchset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-adapters] atezs82 commented on a change in pull request #14: [pulsar-spark] added option for configuring Pulsar client
atezs82 commented on a change in pull request #14: URL: https://github.com/apache/pulsar-adapters/pull/14#discussion_r657762984 ## File path: pulsar-spark/src/main/java/org/apache/pulsar/spark/SparkStreamingPulsarReceiver.java ## @@ -43,34 +46,52 @@ private static final Logger LOG = LoggerFactory.getLogger(SparkStreamingPulsarReceiver.class); private String serviceUrl; -private ConsumerConfigurationData conf; +private Map clientConfig; +private ConsumerConfigurationData consumerConfig; private Authentication authentication; private PulsarClient pulsarClient; private Consumer consumer; public SparkStreamingPulsarReceiver( String serviceUrl, -ConsumerConfigurationData conf, +ConsumerConfigurationData consumerConfig, Authentication authentication) { -this(StorageLevel.MEMORY_AND_DISK_2(), serviceUrl, conf, authentication); +this(StorageLevel.MEMORY_AND_DISK_2(), serviceUrl, new HashMap<>(), consumerConfig, authentication); +} + +public SparkStreamingPulsarReceiver( +String serviceUrl, +Map clientConfig, +ConsumerConfigurationData consumerConfig, +Authentication authentication) { +this(StorageLevel.MEMORY_AND_DISK_2(), serviceUrl, clientConfig, consumerConfig, authentication); +} + +public SparkStreamingPulsarReceiver(StorageLevel storageLevel, Review comment: Thanks for the finding, corrected this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-helm-chart] 871921256 commented on issue #86: Pulsar manager mount private/public key for token generation
871921256 commented on issue #86: URL: https://github.com/apache/pulsar-helm-chart/issues/86#issuecomment-867389286 Thank you very much. @dadacom379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-helm-chart] 871921256 removed a comment on issue #86: Pulsar manager mount private/public key for token generation
871921256 removed a comment on issue #86: URL: https://github.com/apache/pulsar-helm-chart/issues/86#issuecomment-867386848 Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-helm-chart] 871921256 commented on issue #86: Pulsar manager mount private/public key for token generation
871921256 commented on issue #86: URL: https://github.com/apache/pulsar-helm-chart/issues/86#issuecomment-867386848 Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org