Re: [DISCUSS] PIP-279: Reformat property in generateResponseWithEntry
+1 (binding)
This is a bug and we need this fix.
Regards
Jiwei Guo (Tboy)
On Wed, Jun 21, 2023 at 11:23 AM steven lu wrote:
> # Motivation
>
> reformat property,for a http header name cannot contain the following
> prohibited characters: =,;: \t\r\n\v\f
>
> for example:
> {"city=shanghai":"tag"}
> when we run `bin/pulsar-admin topics get-message-by-id `, it will
> throw exception, the exception is:
> `Reason: java.util.concurrent.CompletionException:
>
> org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException:
> Could not complete the operation. Number of retries has been
> exhausted. Failed reason: a header name cannot contain the following
> prohibited characters: =,;: \t\r\n\v\f: =`
>
> src="
> https://github.com/StevenLuMT/pulsar/assets/42990025/973d95b9-4ac2-4977-b160-162c4b53a613
> ">
>
> # High Level Design
>
> In master branch,
> in an http
> request:getMessageById("/{tenant}/{namespace}/{topic}/ledger/{ledgerId}/entry/{entryId}"),
> replace `"X-Pulsar-PROPERTY-" + msgProperties.getKey()` with
> `"X-Pulsar-PROPERTY"`
>
> After release-3.1.0, this feature begins to take effect.
>
Re: [VOTE] PIP-278: Support pluggable topic compaction service
I have left some comments in the proposal so please hold this vote until the comments are addressed. Thanks, Yunze On Mon, Jun 26, 2023 at 10:47 AM wrote: > > +1 (binding) > > Best, > Mattison > On 26 Jun 2023 at 10:01 +0800, Cong Zhao , wrote: > > Hello, community: > > > > This thread is to start a vote for PIP-278: Support pluggable topic > > compaction service. > > > > Discussion thread: > > https://lists.apache.org/thread/ox2bot3p9j9fydqkw3v5gt5twc8jslvd > > > > PIP PR: https://github.com/apache/pulsar/pull/20624 > > > > Sincerely > > Cong Zhao
Re: [VOTE] PIP-278: Support pluggable topic compaction service
+1 (binding) Best, Mattison On 26 Jun 2023 at 10:01 +0800, Cong Zhao , wrote: > Hello, community: > > This thread is to start a vote for PIP-278: Support pluggable topic > compaction service. > > Discussion thread: > https://lists.apache.org/thread/ox2bot3p9j9fydqkw3v5gt5twc8jslvd > > PIP PR: https://github.com/apache/pulsar/pull/20624 > > Sincerely > Cong Zhao
[VOTE] PIP-278: Support pluggable topic compaction service
Hello, community: This thread is to start a vote for PIP-278: Support pluggable topic compaction service. Discussion thread: https://lists.apache.org/thread/ox2bot3p9j9fydqkw3v5gt5twc8jslvd PIP PR: https://github.com/apache/pulsar/pull/20624 Sincerely Cong Zhao
Re: [DISCUSS] Provide consistent concept around partitioned topic and topic partition/internal topic
I'd like to say "a partitioned topic is a topic that consists of multiple non-partitioned topics". It's better not to use the "internal topic" concept. Thanks, Yunze On Sun, Jun 25, 2023 at 4:31 PM Joo Hyuk Kim wrote: > > Hi community: > > Currently, it seems like there is no good definition of what "partitioned > topic" and "non-partitioned topic" mean and some places topic > partition and internal > topic interchangeably. > > I would like to propose to vote (or discuss) to come up with solid > definition of what composes "partitioned topic", then apply to pulsar-site, > javadoc, and TopicName API accordingly. > > Let me know what you think > > > # ISSUE https://github.com/apache/pulsar/issues/20622 Regards Joo Hyuk, > Kim (Vince)
Re: [DISCUSS] PIP-277: Clusters list API return clusters with local flag
Hi Jiwei, Do you need to change the REST API? or will it just apply to the Admin CLI? If it requires REST API changes, you should also reflect them in the proposal. And yes, using the local and remote will be confusing because users can have multiple clusters without geo-replication. Maybe we should use the --current option to show which cluster are requesting. So that we will not introduce any break changes. If we don't have compatibility issue, I don't like the --current option :) With the --current option: ``` bin/pulsar-admin clusters list --current us-west(*) us-east us-cent ``` It looks like (*) is commonly used, e.g. kubectl config get-contexts ... Regards, Penghui On Sun, Jun 25, 2023 at 3:53 PM Zixuan Liu wrote: > +1, this is a good improvement. > > In the proposal, I don't suggest you append the `local` to the cluster > name: > > 1. It will be confusing when the original cluster name includes the > `local` name > 2. In some cases, it is not easy to distinguish between local and > remote clusters > > so I suggest we should add the `local` and `remote` flags like: > > ``` > # list remote clusters > bin/pulsar-admin clusters list --remote > us-east > us-cent > > # list local clustes > bin/pulsar-admin clusters list --local > us-west > > # list all clusters > bin/pulsar-admin clusters list > us-east > us-cent > us-west > ``` > > Thanks, > Zixuan > > guo jiwei 于2023年6月20日周二 14:00写道： > > > > Hi community: > > After configuring the geo-replication on Pulsar clusters, the > `clusters > > list` API will return multiple clusters, including the local Pulsar > cluster > > and remote clusters like > > > > ``` > > bin/pulsar-admin clusters list > > us-west > > us-east > > us-cent > > ``` > > But in this return, you can't distinguish the local and the remote > cluster. > > When you need to remove the geo-replication configuration, it will be > hard > > to decide which cluster should be removed on replicated tenants and > > namespaces unless you record the cluster information. > > > > > > ### Modification > > Add `local` flag to distinguish clusters > > ``` > > bin/pulsar-admin clusters list > > us-west(local) > > us-east > > us-cent > > ``` > > > > PIP: https://github.com/apache/pulsar/pull/20614 > > > > > > Regards > > Jiwei Guo (Tboy) >
[DISCUSS] Provide consistent concept around partitioned topic and topic partition/internal topic
Hi community: Currently, it seems like there is no good definition of what "partitioned topic" and "non-partitioned topic" mean and some places topic partition and internal topic interchangeably. I would like to propose to vote (or discuss) to come up with solid definition of what composes "partitioned topic", then apply to pulsar-site, javadoc, and TopicName API accordingly. Let me know what you think # ISSUE https://github.com/apache/pulsar/issues/20622 Regards Joo Hyuk, Kim (Vince)
Re: [DISCUSS] PIP-277: Clusters list API return clusters with local flag
+1, this is a good improvement. In the proposal, I don't suggest you append the `local` to the cluster name: 1. It will be confusing when the original cluster name includes the `local` name 2. In some cases, it is not easy to distinguish between local and remote clusters so I suggest we should add the `local` and `remote` flags like: ``` # list remote clusters bin/pulsar-admin clusters list --remote us-east us-cent # list local clustes bin/pulsar-admin clusters list --local us-west # list all clusters bin/pulsar-admin clusters list us-east us-cent us-west ``` Thanks, Zixuan guo jiwei 于2023年6月20日周二 14:00写道： > > Hi community: > After configuring the geo-replication on Pulsar clusters, the `clusters > list` API will return multiple clusters, including the local Pulsar cluster > and remote clusters like > > ``` > bin/pulsar-admin clusters list > us-west > us-east > us-cent > ``` > But in this return, you can't distinguish the local and the remote cluster. > When you need to remove the geo-replication configuration, it will be hard > to decide which cluster should be removed on replicated tenants and > namespaces unless you record the cluster information. > > > ### Modification > Add `local` flag to distinguish clusters > ``` > bin/pulsar-admin clusters list > us-west(local) > us-east > us-cent > ``` > > PIP: https://github.com/apache/pulsar/pull/20614 > > > Regards > Jiwei Guo (Tboy)
