Re: [VOTE] PIP-339: Introducing the --log-topic Option for Pulsar Sinks and Sources

[Hang Chen]

+1(binding)

Regards,
Hang

guo jiwei  于2024年2月27日周二 15:54写道：
>
> +1 (binding)
>
> Regards
> Jiwei Guo (Tboy)
>
>
> On Tue, Feb 27, 2024 at 10:18 AM Zike Yang  wrote:
>
> > +1 (no-binding)
> >
> > BR,
> > Zike Yang
> >
> > On Tue, Feb 27, 2024 at 8:56 AM PengHui Li  wrote:
> > >
> > > +1 (binding)
> > >
> > > Regards,
> > > Penghui
> > >
> > > On Mon, Feb 26, 2024 at 5:44 PM Pengcheng Jiang
> > >  wrote:
> > >
> > > > Hi, community
> > > >
> > > > I'm starting the vote for PIP-339: Introducing the --log-topic Option
> > for
> > > > Pulsar Sinks and Sources
> > > > PIP link: https://github.com/apache/pulsar/pull/22071
> > > >
> > > > Thanks,
> > > > Pengcheng Jiang
> > > >
> >

Re: [VOTE] PIP-339: Introducing the --log-topic Option for Pulsar Sinks and Sources

[guo jiwei]

+1 (binding)

Regards
Jiwei Guo (Tboy)


On Tue, Feb 27, 2024 at 10:18 AM Zike Yang  wrote:

> +1 (no-binding)
>
> BR,
> Zike Yang
>
> On Tue, Feb 27, 2024 at 8:56 AM PengHui Li  wrote:
> >
> > +1 (binding)
> >
> > Regards,
> > Penghui
> >
> > On Mon, Feb 26, 2024 at 5:44 PM Pengcheng Jiang
> >  wrote:
> >
> > > Hi, community
> > >
> > > I'm starting the vote for PIP-339: Introducing the --log-topic Option
> for
> > > Pulsar Sinks and Sources
> > > PIP link: https://github.com/apache/pulsar/pull/22071
> > >
> > > Thanks,
> > > Pengcheng Jiang
> > >
>

Re: [ANNOUNCE] New Committer: Kiryl Valkovich

[Lari Hotari]

Congrats, Kiryl!

-Lari

On Tue, 27 Feb 2024 at 06:53, tison  wrote:
>
> The Apache Pulsar Project Management Committee (PMC) has invited
> Kiryl Valkovich https://github.com/visortelle to become a committer, and we
> are pleased to announce that he has accepted.
>
> Welcome and Congratulations, Kiryl Valkovich!
>
> Please join us in congratulating and welcoming Kiryl onboard!
>
> Best Regards,
>
> tison
> on behalf of the Pulsar PMC

[ANNOUNCE] David Jensen as new PMC member in Apache Pulsar

[tison]

The Apache Pulsar Project Management Committee (PMC) has invited
David Jensen https://github.com/entvex to join the PMC, and we
are pleased to announce that he has accepted.

David is an active contributor of DotPulsar[1]. He is actively maintaining
the project and doing releases.

DotPulsar is the official .NET client library for Apache Pulsar, written
entirely in C# and implements Apache Pulsar's binary protocol.

On behalf of the Pulsar PMC, we extend a heartfelt welcome and
congratulations to David Jensen.

Best,
tison.

[1] https://github.com/apache/pulsar-dotpulsar

[ANNOUNCE] New Committer: Kiryl Valkovich

[tison]

The Apache Pulsar Project Management Committee (PMC) has invited
Kiryl Valkovich https://github.com/visortelle to become a committer, and we
are pleased to announce that he has accepted.

Welcome and Congratulations, Kiryl Valkovich!

Please join us in congratulating and welcoming Kiryl onboard!

Best Regards,

tison
on behalf of the Pulsar PMC

Re: [ANNOUNCE] New Committer: Asaf Mesika

[Ran Gao]

Congratulations, Asaf!

Best Regards,
Ran Gao

On 2024/02/20 16:50:29 Lari Hotari wrote:
> The Apache Pulsar Project Management Committee (PMC) has invited
> Asaf Mesika https://github.com/asafm to become a committer and we
> are pleased to announce that he has accepted.
> 
> Welcome and Congratulations, Asaf Mesika!
> 
> Please join us in congratulating and welcoming Asaf onboard!
> 
> Best Regards,
> 
> Lari Hotari
> on behalf of the Pulsar PMC
> 

Re: [VOTE] PIP-339: Introducing the --log-topic Option for Pulsar Sinks and Sources

[Zike Yang]

+1 (no-binding)

BR,
Zike Yang

On Tue, Feb 27, 2024 at 8:56 AM PengHui Li  wrote:
>
> +1 (binding)
>
> Regards,
> Penghui
>
> On Mon, Feb 26, 2024 at 5:44 PM Pengcheng Jiang
>  wrote:
>
> > Hi, community
> >
> > I'm starting the vote for PIP-339: Introducing the --log-topic Option for
> > Pulsar Sinks and Sources
> > PIP link: https://github.com/apache/pulsar/pull/22071
> >
> > Thanks,
> > Pengcheng Jiang
> >

Re: [ANNOUNCE] New Committer: Asaf Mesika

[PengHui Li]

Congrats, Asaf.

Penghui Li

On Thu, Feb 22, 2024 at 8:17 PM Cong Zhao  wrote:

> Congratulations!
>
> Thanks,
> Cong
>
> On 2024/02/20 16:50:29 Lari Hotari wrote:
> > The Apache Pulsar Project Management Committee (PMC) has invited
> > Asaf Mesika https://github.com/asafm to become a committer and we
> > are pleased to announce that he has accepted.
> >
> > Welcome and Congratulations, Asaf Mesika!
> >
> > Please join us in congratulating and welcoming Asaf onboard!
> >
> > Best Regards,
> >
> > Lari Hotari
> > on behalf of the Pulsar PMC
> >
>

Re: [VOTE] PIP-339: Introducing the --log-topic Option for Pulsar Sinks and Sources

[PengHui Li]

+1 (binding)

Regards,
Penghui

On Mon, Feb 26, 2024 at 5:44 PM Pengcheng Jiang
 wrote:

> Hi, community
>
> I'm starting the vote for PIP-339: Introducing the --log-topic Option for
> Pulsar Sinks and Sources
> PIP link: https://github.com/apache/pulsar/pull/22071
>
> Thanks,
> Pengcheng Jiang
>

Re: [DISCUSS] Apache Pulsar 3.1.3 Release

[PengHui Li]

+1

Thanks for driving the release.
And it should be the last patch release of Apache Pulsar 3.1.0
Then, we will move to 3.2.x

Regards,
Penghui

On Mon, Feb 26, 2024 at 8:08 PM ran leon  wrote:

> Dear the Apache Pulsar Dev community,
>
> I would like to propose releasing Apache Pulsar 3.1.3.
>
> It's almost two months since the release of 3.1.2, and there are 65 new
> commits in branch-3.1:
> https://github.com/apache/pulsar/compare/v3.1.2...branch-3.1
>
> Please let me know if you have any essential fixes to include in Apache
> Pulsar 3.1.3.
>
> Regards,
> Ran Gao
>

Re: [VOTE] Release Apache Pulsar Helm Chart 3.3.0 based on 3.3.0-candidate-1

[PengHui Li]

+1 (binding)

- Deploy pulsar cluster on local docker-desktop(with Kubernetes)
- Checked the signature
- Checked the license

Regards,
Penghui

On Sat, Feb 24, 2024 at 3:38 AM Lari Hotari  wrote:

> Hello Apache Pulsar Community,
>
> This is a call for the vote to release the Apache Pulsar Helm Chart
> version 3.3.0.
>
> Release notes for 3.3.0-candidate-1:
>
> https://github.com/apache/pulsar-helm-chart/releases/tag/pulsar-3.3.0-candidate-1
>
> The release candidate is available at:
> https://dist.apache.org/repos/dist/dev/pulsar/helm-chart/3.3.0-candidate-1/
>
> pulsar-chart-3.3.0-source.tar.gz - is the "main source release".
> pulsar-3.3.0.tgz - is the binary Helm Chart release.
>
> Public keys are available at: https://www.apache.org/dist/pulsar/KEYS
>
> For convenience "index.yaml" has been uploaded (though excluded from
> voting), so you can also run the below commands.
>
> helm repo add --force-update apache-pulsar-dist-dev
> https://dist.apache.org/repos/dist/dev/pulsar/helm-chart/3.3.0-candidate-1/
> helm repo update
> helm install pulsar apache-pulsar-dist-dev/pulsar --version 3.3.0 --set
> affinity.anti_affinity=false
>
> pulsar-3.3.0.tgz.prov - is also uploaded for verifying Chart Integrity,
> though it is not strictly required for releasing the artifact based on ASF
> Guidelines.
>
> You can optionally verify this file using this helm plugin
> https://github.com/technosophos/helm-gpg, or by using helm --verify (
> https://helm.sh/docs/helm/helm_verify/).
>
> helm fetch --prov apache-pulsar-dist-dev/pulsar
> helm plugin install https://github.com/technosophos/helm-gpg
> helm gpg verify pulsar-3.3.0.tgz
>
> The vote will be open for at least 72 hours.
>
> Only votes from PMC members are binding, but members of the community are
> encouraged to test the release and vote with "(non-binding)".
>
> For license checks, the .rat-excludes files is included, so you can run
> the following to verify licenses (just update ):
>
> tar -xvf pulsar-chart-3.3.0-source.tar.gz
> cd pulsar-chart-3.3.0
> java -jar /apache-rat-0.15/apache-rat-0.15.jar . -E .rat-excludes
>
> Please note that the version number excludes the `-candidate-X` string, so
> it's now
> simply 3.3.0. This will allow us to rename the artifact without modifying
> the artifact checksums when we actually release it.
>
> Thanks,
> Lari
>

Re: [DISCUSS] Migrate CLI parser from jcommander to picocli

[Zixuan Liu]

The new implementation is compatible with the existing tests, otherwise,
there will be a lot of changes in the src and test directories.

Thanks,
Zixuan

Ran Gao  于2024年2月26日周一 19:49写道：

> +1 (non-binding), it's more elegant. There will be a lot of changes, we
> can create some tasks based on commands.
>
> - Ran Gao
>
> On 2024/02/21 05:07:46 Zixuan Liu wrote:
> > Hi Pulsar Community,
> >
> > The pulsar CLI(pulsar-admin, pulsar-client, pulsar-shell, and so on) uses
> > the jcommander [1] as CLI parser, which is an awesome project, but the
> > maintainer is not active and cannot keep up with modern CLI
> > features(auto-completion, sub-command, native-images, suggest commands,
> and
> > so on). Then I found the picocli [2] project to meet these needs, which
> is
> > active and powerful. For comparison, please see [3].
> >
> > Error prompt:
> > ```
> > bin/pulsar-admin clusters update cluster-a -b
> >
> > # jcommander
> > Need to provide just 1 parameter
> >
> > # picocli
> > Unknown option: '-b'
> > ```
> >
> > Suggest commands:
> > ```
> > bin/pulsar-admin cluste
> >
> > # jcommander
> > Expected a command, got cluste
> >
> > # picocli
> > Unmatched argument at index 0: 'cluste'
> > Did you mean: pulsar-admin clusters?
> > ```
> >
> > What do you think about migrating CLI parse from jcommander to picocli?
> >
> > Thanks,
> > Zixuan
> >
> > [1] - https://github.com/cbeust/jcommander
> > [2] - https://picocli.info/
> > [3] - https://github.com/remkop/picocli/wiki/picocli-vs-JCommander
> >
>

Re: [DISCUSS] Migrate CLI parser from jcommander to picocli

[Zixuan Liu]

> If I am implementing a custom extension of Pulsar Shell/Pulsar Admin,
> currently my code doesn't depend on jcommander

Your PIP is a good design.

I can handle the adaptation of custom extension of Pulsar Shell/Pulsar
Admin, but `org.apache.pulsar.shell.ShellCommandsProvider` needs to be
changed, which uses the `JCommander` class: ` JCommander getJCommander();`
-> ` Object getCommander();`.

The `getCommander` method returns a picocli object, we can check this
object type in the pulsar shell, and then get the original object to set
the command name, get the admin URL, client URL, and so on.

I have an idea of refactoring this location with an interface to decouple
the code, but this will change more code, so I decided that
`getCommander()` method returns an Object type.

Thanks,
Zixuan

Enrico Olivelli  于2024年2月26日周一 15:33写道：

> Il Lun 26 Feb 2024, 02:23 PengHui Li  ha scritto:
>
> > +1 Great user experience improvement.
> >
> > Regards,
> > Penghui
> >
> > On Sat, Feb 24, 2024 at 3:15 AM Zixuan Liu  wrote:
> >
> > > > Can you please share some pointers ?
> > >
> > > Only `org.apache.pulsar.shell.ShellCommandsProvider#getJCommander` uses
> > > jcommander API. I need to use picocli instead of jcommander, or add a
> new
> > > method.
> >
>
> Sorry, I wasn't clear.
> If I am implementing a custom extension of Pulsar Shell/Pulsar Admin,
> currently my code doesn't depend on jcommander
>
> Please check this PIP
> https://github.com/apache/pulsar/issues/17155
>
> Enrico
>
>
> >
> > > Using picocli instead of jcommander will reduce some code, but it well
> n
> > > break the signature of some methods. I need to carefully study how to
> do
> > > it.
> > >
> > > This thread is just a preliminary idea to replace jcommander, and I
> will
> > > write a PIP later.
> > >
> > > Thanks,
> > > Zixuan
> > >
> > >
> > > Enrico Olivelli  于2024年2月23日周五 22:59写道：
> > >
> > > > Il Ven 23 Feb 2024, 04:34 Zixuan Liu  ha scritto:
> > > >
> > > > > Thanks for the feedback!
> > > > >
> > > > > > Please take into account Pulsar Shell extensions
> > > > >
> > > > > This is a tricky issue, I noticed that it depends on jcommander
> here,
> > > >
> > > >
> > > >
> > > > Can you please share some pointers ? IIRC the shell extensions
> > shouldn't
> > > > need jcommander, it should be exposed in the public API
> > > >
> > > > Enrico
> > > >
> > > > and I
> > > > > need to break this interface, and make it compatible with Pulsar
> > Shell
> > > > > implementation.
> > > > >
> > > > > I will create a draft PR to migrate the CLI parser from jcommander
> to
> > > > > picocli, and then make a PIP to the Pulsar.
> > > > >
> > > > > Thanks,
> > > > > Zixuan
> > > > >
> > > >
> > >
> >
>

[DISCUSS] Apache Pulsar 3.1.3 Release

[ran leon]

Dear the Apache Pulsar Dev community,

I would like to propose releasing Apache Pulsar 3.1.3.

It's almost two months since the release of 3.1.2, and there are 65 new
commits in branch-3.1:
https://github.com/apache/pulsar/compare/v3.1.2...branch-3.1

Please let me know if you have any essential fixes to include in Apache
Pulsar 3.1.3.

Regards,
Ran Gao

Re: [DISCUSS] Migrate CLI parser from jcommander to picocli

[Ran Gao]

+1 (non-binding), it's more elegant. There will be a lot of changes, we can 
create some tasks based on commands.

- Ran Gao

On 2024/02/21 05:07:46 Zixuan Liu wrote:
> Hi Pulsar Community,
> 
> The pulsar CLI(pulsar-admin, pulsar-client, pulsar-shell, and so on) uses
> the jcommander [1] as CLI parser, which is an awesome project, but the
> maintainer is not active and cannot keep up with modern CLI
> features(auto-completion, sub-command, native-images, suggest commands, and
> so on). Then I found the picocli [2] project to meet these needs, which is
> active and powerful. For comparison, please see [3].
> 
> Error prompt:
> ```
> bin/pulsar-admin clusters update cluster-a -b
> 
> # jcommander
> Need to provide just 1 parameter
> 
> # picocli
> Unknown option: '-b'
> ```
> 
> Suggest commands:
> ```
> bin/pulsar-admin cluste
> 
> # jcommander
> Expected a command, got cluste
> 
> # picocli
> Unmatched argument at index 0: 'cluste'
> Did you mean: pulsar-admin clusters?
> ```
> 
> What do you think about migrating CLI parse from jcommander to picocli?
> 
> Thanks,
> Zixuan
> 
> [1] - https://github.com/cbeust/jcommander
> [2] - https://picocli.info/
> [3] - https://github.com/remkop/picocli/wiki/picocli-vs-JCommander
> 

Re: [DISCUSS] PIP-338: Introducing the --log-topic Option for Pulsar Sinks and Sources

[Pengcheng Jiang]

Oh, sorry, I missed the reply before sending the vote mail

For the authorization, I think users are responsible for doing that, just
like what they do while setting the log topic for functions.

And it's easy to distinguish logs if one log topic is used for multiple
functions because the producer will add `fqn` to the property while sending
log entry to pulsar in here

:

```java
public void append(LogEvent logEvent) {
producer.newMessage()

.value(logEvent.getMessage().getFormattedMessage().getBytes(StandardCharsets.UTF_8))
.property(LOG_LEVEL, logEvent.getLevel().name())
.property(INSTANCE, instance)
.property(FQN, fqn)
.sendAsync();
}
```



Regards,
Pengcheng Jiang

PengHui Li  于2024年2月26日周一 09:48写道：

> Do we need to take the authorization into account?
> Users might need to take one more step to grant permission to access the
> log topic.
> It is better to mention it in the proposal.
>
> If users try to use one log topic for multiple functions,
> Is it easy for them to distinguish which function the logs are from?
>
> Regards,
> Penghui
>
> On Tue, Feb 20, 2024 at 9:03 AM Pengcheng Jiang
>  wrote:
>
> > Sorry, the PIP number should be PIP-339
> >
> > Pengcheng Jiang  于2024年2月19日周一 17:30写道：
> >
> > > Dear community,
> > >
> > > I created a PIP to support `--log-topic` for Pulsar Sinks and Sources:
> > > https://github.com/apache/pulsar/pull/22071
> > >
> > > It will make Pulsar Functions and Connectors have the same way to
> manage
> > > their logs.
> > >
> > > Any feedback and suggestions are welcome.
> > >
> > > Sincerely
> > > Pengcheng Jiang
> > >
> >
>

[VOTE] PIP-339: Introducing the --log-topic Option for Pulsar Sinks and Sources

[Pengcheng Jiang]

Hi, community

I'm starting the vote for PIP-339: Introducing the --log-topic Option for
Pulsar Sinks and Sources
PIP link: https://github.com/apache/pulsar/pull/22071

Thanks,
Pengcheng Jiang