Comments inline
On 2023/07/07 20:28:45 Dave Fisher wrote:
> Hi -
>
> I challenge the dev community about the state of building these branches
> 2.11, 3,0, and Master when you actually perform all of the unit tests. In the
> website it seems that we always tell everyone to use `mvn clean install
> -DskipTests` we do this because tests take too long and are flaky. We end up
> counting on GitHub Workflows and must not cover all of the Unit Tests.
>
> So, if you do `mvn clean install` on any of those three branches it is very
> likely to fail and often in the pulsar-broker tests. What are we going to do
> about this?
With all the flakiness in our tests, I don't think that we would recommend
running "mvn clean install" in one shot. There's not much to do about this than
to get rid of the flaky tests. That might take a few more years. :)
Unit tests and integration tests are run using ./build/run_unit_group.sh and
./build/run_integration_group.sh scripts in Pulsar CI. It's possible to use
these scripts if someone wants to build another CI for Pulsar without GitHub
Actions and run the tests in similar grouping as what Pulsar CI uses.
>
> Also, pulsar.apache.org/contribute/setup-building should likely include a
> discussion about installing docker,
Yes.
-Lari
