[jira] Closed: (QPID-2965) Latest source build fails with --without-sasl argument to configure
[ https://issues.apache.org/jira/browse/QPID-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brad Hubbard closed QPID-2965. -- Resolution: Fixed Fix Version/s: Future Fixed in revision 1041286 > Latest source build fails with --without-sasl argument to configure > --- > > Key: QPID-2965 > URL: https://issues.apache.org/jira/browse/QPID-2965 > Project: Qpid > Issue Type: Bug > Components: C++ Broker >Affects Versions: Future > Environment: Fedora 14 >Reporter: Brad Hubbard > Fix For: Future > > > git clone git://git.apache.org/qpid.git > ./configure --prefix=/home/brad/working/installs --without-sasl > The build fails with; > libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../include -I../include -I. -I=. > -Werror -pedantic -Wall -Wextra -Wno-shadow -Wpointer-arith -Wcast-qual > -Wcast-align -Wno-long-long -Wvolatile-register-var -Winvalid-pch > -Wno-system-headers -Woverloaded-virtual > -DQPID_LIBEXEC_DIR=\"/home/brad/working/installs/libexec/qpid\" -g -O2 -MT > qpid/SaslFactory.lo -MD -MP -MF qpid/.deps/SaslFactory.Tpo -c > qpid/SaslFactory.cpp -fPIC -DPIC -o qpid/.libs/SaslFactory.o > qpid/SaslFactory.cpp:48:21: error: prototype for 'std::auto_ptr > qpid::SaslFactory::create(const std::string&, const std::string&, const > std::string&, const std::string&, int, int)' does not match any in class > 'qpid::SaslFactory' > ./qpid//SaslFactory.h:37:25: error: candidate is: std::auto_ptr > qpid::SaslFactory::create(const std::string&, const std::string&, const > std::string&, const std::string&, int, int, bool) > make[3]: *** [qpid/SaslFactory.lo] Error 1 > make[3]: Leaving directory `/home/brad/working/src/qpid/qpid/cpp/src' > make[2]: *** [all-recursive] Error 1 > make[2]: Leaving directory `/home/brad/working/src/qpid/qpid/cpp/src' > make[1]: *** [all] Error 2 > make[1]: Leaving directory `/home/brad/working/src/qpid/qpid/cpp/src' > make: *** [all-recursive] Error 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-2965) Latest source build fails with --without-sasl argument to configure
Latest source build fails with --without-sasl argument to configure --- Key: QPID-2965 URL: https://issues.apache.org/jira/browse/QPID-2965 Project: Qpid Issue Type: Bug Components: C++ Broker Affects Versions: Future Environment: Fedora 14 Reporter: Brad Hubbard git clone git://git.apache.org/qpid.git ./configure --prefix=/home/brad/working/installs --without-sasl The build fails with; libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../include -I../include -I. -I=. -Werror -pedantic -Wall -Wextra -Wno-shadow -Wpointer-arith -Wcast-qual -Wcast-align -Wno-long-long -Wvolatile-register-var -Winvalid-pch -Wno-system-headers -Woverloaded-virtual -DQPID_LIBEXEC_DIR=\"/home/brad/working/installs/libexec/qpid\" -g -O2 -MT qpid/SaslFactory.lo -MD -MP -MF qpid/.deps/SaslFactory.Tpo -c qpid/SaslFactory.cpp -fPIC -DPIC -o qpid/.libs/SaslFactory.o qpid/SaslFactory.cpp:48:21: error: prototype for 'std::auto_ptr qpid::SaslFactory::create(const std::string&, const std::string&, const std::string&, const std::string&, int, int)' does not match any in class 'qpid::SaslFactory' ./qpid//SaslFactory.h:37:25: error: candidate is: std::auto_ptr qpid::SaslFactory::create(const std::string&, const std::string&, const std::string&, const std::string&, int, int, bool) make[3]: *** [qpid/SaslFactory.lo] Error 1 make[3]: Leaving directory `/home/brad/working/src/qpid/qpid/cpp/src' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/brad/working/src/qpid/qpid/cpp/src' make[1]: *** [all] Error 2 make[1]: Leaving directory `/home/brad/working/src/qpid/qpid/cpp/src' make: *** [all-recursive] Error 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
RE: [VOTE] Release RC3 as Qpid 0.8
[X] Yes, release RC3 as Qpid 0.8 [ ] No, I have an issue which I'll discuss in a new thread. -Steve - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2361) exchange configuration attributes are ignored when configuration is placed in virtualhosts.xml
[ https://issues.apache.org/jira/browse/QPID-2361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-2361. -- Resolution: Fixed > exchange configuration attributes are ignored when configuration is placed in > virtualhosts.xml > -- > > Key: QPID-2361 > URL: https://issues.apache.org/jira/browse/QPID-2361 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.5, 0.6 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.7 > > Attachments: 0001-QPID-2361-branch.patch, 0001-QPID-2361-trunk.patch > > > When configuring exchanges in virtualhosts.xml, only the name is picked up. > The type element is ignored and the default "direct" is used. Similarly, the > durable element is ignored and the default "false" is used. As such it is > impossible to define anything other than a transient direct exchange within > virtualhosts.xml. > When configured within the main config.xml file, the configuration is picked > up and used as expected. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2472) QpidCompositeRollingAppender log4j configuration is misleading
[ https://issues.apache.org/jira/browse/QPID-2472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-2472. -- Resolution: Fixed > QpidCompositeRollingAppender log4j configuration is misleading > -- > > Key: QPID-2472 > URL: https://issues.apache.org/jira/browse/QPID-2472 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.5, 0.6 >Reporter: Andrew Kennedy >Assignee: Robbie Gemmell > Fix For: 0.7 > > Attachments: > 0003-QPID-2472-Correct-log4j-XML-configuration-comments.patch > > > The QpidCompositeRollingAppender logging appender configuration is > misleading. The configuration file states that the default rollover size is > 1MB, wheras the actual default in the code is 10 MB. Additionally, the > 'CompressBackupFiles' flag controls both the creation of backups in a > separate directory on rollover, and the compression of these files. This > property should either be renamed or backing up of files to a separate > location should be enabled based on the presence of the 'backupFilesToPath' > property instead. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2360) declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup
[ https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-2360. -- Resolution: Fixed > declaring virtualhost level firewall configuration in virtualhosts.xml leads > to NPE on startup > -- > > Key: QPID-2360 > URL: https://issues.apache.org/jira/browse/QPID-2360 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: 0.6 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.7 > > Attachments: 0001-QPID-2630-QPID-2631-branch.patch, > 0001-QPID-2630-QPID-2631-trunk.patch > > > Declaring virtualhost level firewall configuration in virtualhosts.xml leads > to NPE on startup. > After moving the same configuration into config.xml the broker then loads ok > and the configuration works as expected. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [VOTE] Release RC3 as Qpid 0.8
[X] Yes, release RC3 as Qpid 0.8 [ ] No, I have an issue which I'll discuss in a new thread. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2613) message data is not commited to the persistent store on 0-8/0-9 codepath
[ https://issues.apache.org/jira/browse/QPID-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965897#action_12965897 ] Marnie McCormack commented on QPID-2613: Clearly we need a test that persistent data gets to the store too. > message data is not commited to the persistent store on 0-8/0-9 codepath > > > Key: QPID-2613 > URL: https://issues.apache.org/jira/browse/QPID-2613 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Broker MessageStore - DerbyStore >Affects Versions: 0.6 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Critical > Fix For: 0.7 > > > With the new persistence store implementation each message should currently > have StoredMessage.flushToStore() called on it as it arrives, however this is > not currently being done on the 0-8/0-9 codepath and as such the message data > is not commited to the store. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2583) Update tests to throw ConfigurationExceptions
[ https://issues.apache.org/jira/browse/QPID-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marnie McCormack resolved QPID-2583. Resolution: Fixed Fix Version/s: (was: 0.7) > Update tests to throw ConfigurationExceptions > - > > Key: QPID-2583 > URL: https://issues.apache.org/jira/browse/QPID-2583 > Project: Qpid > Issue Type: Bug > Components: Java Tests >Reporter: Martin Ritchie >Assignee: Martin Ritchie > > ConfigurationException is now properly propogated during ServerConfiguration > setup. This was previously done at a later stage, we now throw > ConfigurationException before the broker is initialised in the > ApplicationRegistry so the tests that used ServerConfiguration classes must > now be updated to process the exception, currently there is no error path > handling so adding a throw to the test methods will be sufficient. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2613) message data is not commited to the persistent store on 0-8/0-9 codepath
[ https://issues.apache.org/jira/browse/QPID-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marnie McCormack resolved QPID-2613. Resolution: Fixed > message data is not commited to the persistent store on 0-8/0-9 codepath > > > Key: QPID-2613 > URL: https://issues.apache.org/jira/browse/QPID-2613 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Broker MessageStore - DerbyStore >Affects Versions: 0.6 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Critical > Fix For: 0.7 > > > With the new persistence store implementation each message should currently > have StoredMessage.flushToStore() called on it as it arrives, however this is > not currently being done on the 0-8/0-9 codepath and as such the message data > is not commited to the store. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2828) jmx management console can NPE when adding a queue to the navigation tree after its MBean has just been unregistered but before the view is refreshed
[ https://issues.apache.org/jira/browse/QPID-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marnie McCormack resolved QPID-2828. Resolution: Fixed If not already added, user docs should include the new error message and explain what it means as not very guessable for users. > jmx management console can NPE when adding a queue to the navigation tree > after its MBean has just been unregistered but before the view is refreshed > - > > Key: QPID-2828 > URL: https://issues.apache.org/jira/browse/QPID-2828 > Project: Qpid > Issue Type: Bug > Components: Java Management : JMX Console >Affects Versions: 0.6 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 0.7 > > > The jmx management console can throw NullPointerException if attempting to > add queues to the navigation tree after an MBean unregistered notification is > received for the queue but before the next view refresh has occurred to > remove it from the selection list. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2943) add the examples to the Java client binary convenience release package
[ https://issues.apache.org/jira/browse/QPID-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marnie McCormack resolved QPID-2943. Resolution: Fixed RC3 contains example src > add the examples to the Java client binary convenience release package > -- > > Key: QPID-2943 > URL: https://issues.apache.org/jira/browse/QPID-2943 > Project: Qpid > Issue Type: Improvement > Components: Java Client >Affects Versions: 0.5, 0.6 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.7 > > > The Java client binary release package doe snot contain any examples. These > should be included to aid both user uptake and also testing of the release > package itself. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2430) Java broker emits NPE following qpid-tool being connected
[ https://issues.apache.org/jira/browse/QPID-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marnie McCormack resolved QPID-2430. Resolution: Fixed > Java broker emits NPE following qpid-tool being connected > - > > Key: QPID-2430 > URL: https://issues.apache.org/jira/browse/QPID-2430 > Project: Qpid > Issue Type: Bug > Components: Java Broker, Java Management : QMF >Affects Versions: 0.7 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.7 > > > Whilst qpid-tool is connected to the Java broker, after a period of time the > broker is seen to emit a NullPointerException. This was typically seen > quickyl before the management update period was increased to 10 seconds, now > it occurs after a longer period, suggesting the root cause is dependant on > the number of messages sent. Thus far, the same code location has generated > the NPE when called from slightly different contexts in the following 3 > threads: > Exception in thread "TimerThread-test:" java.lang.NullPointerException > Exception in thread "pool-1-thread-X" java.lang.NullPointerException > Exception in thread > "subflushrunner-org.apache.qpid.server.subscription.subscription_0...@1d4d493" > java.lang.NullPointerException > Up to date stack (r918944): > Exception in thread "TimerThread-test:" java.lang.NullPointerException > at > org.apache.qpid.server.txn.AutoCommitTransaction.dequeue(AutoCommitTransaction.java:55) > at > org.apache.qpid.server.subscription.Subscription_0_10.forceDequeue(Subscription_0_10.java:577) > at > org.apache.qpid.server.subscription.Subscription_0_10.send(Subscription_0_10.java:564) > at > org.apache.qpid.server.queue.SimpleAMQQueue.deliverMessage(SimpleAMQQueue.java:696) > at > org.apache.qpid.server.queue.SimpleAMQQueue.deliverToSubscription(SimpleAMQQueue.java:641) > at > org.apache.qpid.server.queue.SimpleAMQQueue.enqueue(SimpleAMQQueue.java:594) > at > org.apache.qpid.server.queue.SimpleAMQQueue.enqueue(SimpleAMQQueue.java:519) > at > org.apache.qpid.qmf.ManagementExchange.publishToConsole(ManagementExchange.java:364) > at > org.apache.qpid.qmf.ManagementExchange.publishObjectsToConsole(ManagementExchange.java:343) > at > org.apache.qpid.qmf.ManagementExchange.publishAllConsole(ManagementExchange.java:316) > at > org.apache.qpid.qmf.ManagementExchange$UpdateTask.run(ManagementExchange.java:497) > at java.util.TimerThread.mainLoop(Timer.java:512) > at java.util.TimerThread.run(Timer.java:462) > Older stacks (some line numbers have changed slightly since): > Exception in thread > "subflushrunner-org.apache.qpid.server.subscription.subscription_0...@1d4d493" > java.lang.NullPointerException > at > org.apache.qpid.server.txn.AutoCommitTransaction.dequeue(AutoCommitTransaction.java:55) > at > org.apache.qpid.server.subscription.Subscription_0_10.forceDequeue(Subscription_0_10.java:576) > at > org.apache.qpid.server.subscription.Subscription_0_10.send(Subscription_0_10.java:563) > at > org.apache.qpid.server.queue.SimpleAMQQueue.deliverMessage(SimpleAMQQueue.java:674) > at > org.apache.qpid.server.queue.SimpleAMQQueue.attemptDelivery(SimpleAMQQueue.java:1646) > at > org.apache.qpid.server.queue.SimpleAMQQueue.flushSubscription(SimpleAMQQueue.java:1585) > at > org.apache.qpid.server.queue.SubFlushRunner.run(SubFlushRunner.java:56) > at > java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) > at java.lang.Thread.run(Thread.java:619) > Exception in thread > "subflushrunner-org.apache.qpid.server.subscription.subscription_0...@1d4d493" > java.lang.NullPointerException > at > org.apache.qpid.server.txn.AutoCommitTransaction.dequeue(AutoCommitTransaction.java:55) > at > org.apache.qpid.server.subscription.Subscription_0_10.forceDequeue(Subscription_0_10.java:576) > at > org.apache.qpid.server.subscription.Subscription_0_10.send(Subscription_0_10.java:563) > at > org.apache.qpid.server.queue.SimpleAMQQueue.deliverMessage(SimpleAMQQueue.java:674) > at > org.apache.qpid.server.queue.SimpleAMQQueue.attemptDelivery(SimpleAMQQueue.java:1646) > at > org.apache.qpid.server.queue.SimpleAMQQueue.flushSubscription(SimpleAMQQueue.java:1585) > at > org.apache.qpid.server.queue.SubFlushRunner.run(SubFlushRunner.java:56) > at > java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:9
[jira] Resolved: (QPID-1825) Improve TimeToLiveTest.testActive to prevent spurious failures
[ https://issues.apache.org/jira/browse/QPID-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marnie McCormack resolved QPID-1825. Resolution: Fixed > Improve TimeToLiveTest.testActive to prevent spurious failures > -- > > Key: QPID-1825 > URL: https://issues.apache.org/jira/browse/QPID-1825 > Project: Qpid > Issue Type: Improvement > Components: Java Tests >Affects Versions: M4, 0.5 >Reporter: Martin Ritchie >Assignee: Martin Ritchie > Fix For: 0.7 > > > Summary: > Currently the systest TimeToLiveTest fails on the Java profile as some of the > messages sent with a TTL value are expected to time out and the test does not > account for the situation when they have not. > An improvement to the test would be to ensure that not all of the messages > are recevied as that would signify that TTL is actually broken in the server. > A little further investigation into why some of the messages are returning > would also be useful. > Currently the test sends messages with a TTL of 100ms in a transaction. After > the commit (so the broker definitely has the messages) it waits 100ms then > starts the consumer, yet some of the messages have not been expired by the > Java broker. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2868) throw exception users when attempt is made to move/copy messages to a non-existent queue
[ https://issues.apache.org/jira/browse/QPID-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marnie McCormack resolved QPID-2868. Resolution: Fixed > throw exception users when attempt is made to move/copy messages to a > non-existent queue > > > Key: QPID-2868 > URL: https://issues.apache.org/jira/browse/QPID-2868 > Project: Qpid > Issue Type: Bug > Components: Java Management : JMX Interface >Affects Versions: M4, 0.5, 0.6 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.7 > > > Current the broker attempts the move/copy when a on-existent queue is > specified, failing during the process. The input should be validated to > prevent acquiring messages and to give a move informative eror message. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2929) the broker-plugins jars are not incorporated into the broker release binary when using 'ant release-bin'
[ https://issues.apache.org/jira/browse/QPID-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marnie McCormack resolved QPID-2929. Resolution: Fixed broker plugins present in RC3 tar > the broker-plugins jars are not incorporated into the broker release binary > when using 'ant release-bin' > > > Key: QPID-2929 > URL: https://issues.apache.org/jira/browse/QPID-2929 > Project: Qpid > Issue Type: Bug > Components: Ant Build System, Java Broker, Packaging >Affects Versions: 0.7 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Critical > Fix For: 0.7 > > > the broker-plugins jars are not incorporated into the broker release binary > when using 'ant release-bin' -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2315) remove unused client package jar dependencies
[ https://issues.apache.org/jira/browse/QPID-2315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marnie McCormack resolved QPID-2315. Resolution: Fixed > remove unused client package jar dependencies > - > > Key: QPID-2315 > URL: https://issues.apache.org/jira/browse/QPID-2315 > Project: Qpid > Issue Type: Task > Components: Java Client, Java Common >Affects Versions: 0.6 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.7 > > > The client release package contains commons-configuration and its > dependencies because these are listed as dependencies for common. However > neither the client or common module makes use of commons-configuration so > these jars are unused (other than commons-lang and commons-collections which > the client module uses directly). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2421) Augment performance tests to allow pre-filling broker, fill and consume only runs.
[ https://issues.apache.org/jira/browse/QPID-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marnie McCormack resolved QPID-2421. Resolution: Fixed > Augment performance tests to allow pre-filling broker, fill and consume only > runs. > -- > > Key: QPID-2421 > URL: https://issues.apache.org/jira/browse/QPID-2421 > Project: Qpid > Issue Type: Improvement > Components: Java Tests >Reporter: Martin Ritchie >Assignee: Martin Ritchie >Priority: Minor > Fix For: 0.7 > > > To enable some different test cases such as: > - filling/draining the broker. > - measuring the time to consume messasges with a backlog whilst messages are > being published. > Tasks: > 1) Augment Testing framework to take a 'preFill' value which is some value of > messages that will be sent to the broker before the test cycle begins. > 2) Add a 'delayBeforeConsume' value that provides a time (in ms) to wait > after having pre-filled the broker before the consumers are started. > 3) Update the tests to allow 0 value for numConsumers meaning no consumers. > 4) Add ability to skip message sending, consumeOnly=true. > These changes will allow us to pre-fill the broker with data to test the > performance with a full heap. > Documentation of new features should be added to performance test page. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-2424) Augment CPU/GC processing scripts to provide additional stats.
[ https://issues.apache.org/jira/browse/QPID-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marnie McCormack resolved QPID-2424. Resolution: Fixed > Augment CPU/GC processing scripts to provide additional stats. > -- > > Key: QPID-2424 > URL: https://issues.apache.org/jira/browse/QPID-2424 > Project: Qpid > Issue Type: Improvement > Components: Java Performance Tests >Reporter: Martin Ritchie >Assignee: Martin Ritchie >Priority: Minor > Fix For: 0.7 > > > Augment perftest processing scripts to provide the following additional stats: > 1) CPU file processing. > a) Sort and extract min/max > b) sum and average > 2) GC data > a) Sort and extract min/max gc time > b) extract frequency of gcs > c) extract time between gcs >- sort extract min/max >- sum and averrage -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: Review Request: Clustered broker crashes in assertion in cluster/ExpiryPolicy.cpp
> On 2010-11-18 09:42:59, Gordon Sim wrote: > > Is the additional locking part of this specific issue? i.e. is it required > > specifically by the move to moving from 1-1 tp 1-n? Patch looks fine to me, > > just curious on that point. Not related to 1-n, but there was a slightly different assertion seen before adding the locking. Also by inspection it's clear that the locks should be there. - Alan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/107/#review42 --- On 2010-11-17 12:27:51, Alan Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/107/ > --- > > (Updated 2010-11-17 12:27:51) > > > Review request for qpid. > > > Summary > --- > > >QPID-2874 Clustered broker crashes in assertion in cluster/ExpiryPolicy.cpp > > - Added missing lock to ExpiryPolicy > - 1-N mapping for expiry ID to mapping when receiving an update. > - Regression test. > > A fan-out message (sent to multiple queues e.g. by fanout or topic > exchange) is a single message on multiple queues with a single expiry > ID. During an update however each instance is sent as a separate > message so we need to allow 1-N mapping of expiry ID to message during > update. > > The problem is to do with messages that are fanned-out to multiple queues. > The cluster update process does not recognize the same message on different > queues and updates as if it were two distinct messages. The cluster expiry > code > expects a 1-1 correspondence between messages and expiry-ids, which are > assigned per message, not per-queued-message. > > This patch allows a 1-n correspondence between expiry-id and messages > received via update, and ensures that all messages with the same expiry-id > are expired at the same time. > > Arguably it would be better to resolve the underlying problem - have update > recognize the same message on different queues and send the actual message > only once and inform the updatee of the queues it is on. That would be a more > involved fix, and would be redundant if we implement some form the new > cluster design. This patch fix solves the immediate problem for the shorter > term. > > > This addresses bug qpid-2874. > https://issues.apache.org/jira/browse/qpid-2874 > > > Diffs > - > > trunk/qpid/cpp/src/qpid/cluster/ExpiryPolicy.h 1035880 > trunk/qpid/cpp/src/qpid/cluster/ExpiryPolicy.cpp 1035880 > trunk/qpid/cpp/src/tests/cluster_tests.py 1035880 > trunk/qpid/python/qpid/brokertest.py 1035880 > > Diff: https://reviews.apache.org/r/107/diff > > > Testing > --- > > Passing the reproducers, make check and make check-long. See qpid-2874 > > > Thanks, > > Alan > >
Re: Review Request: Fix for bug 655078: Modified cluster_tests causes broker shut down with invalid-argument error.
> On 2010-12-01 06:41:30, Kenneth Giusti wrote:
> > Alan, I think I found a bug in the part of the code I contributed to this
> > patch:
> >
> > In ManagementAgent::exportDeletedObject() - we should add a call to
> > moveNewObjectsLH() right before entering the main loop. Specifically:
> >
> >
> > =
> >
> > void ManagementAgent::exportDeletedObjects(DeletedObjectList& outList)
> > {
> > sys::Mutex::ScopedLock lock (userLock);
> > list > deleteList;
> >
> > +
> > + moveNewObjectsLH();
> >
> > for (ManagementObjectMap::iterator iter = managementObjects.begin();
> > iter != managementObjects.end();
> > iter++) {
> >
> > ==
> >
> > Without this, there is a small chance that objects added, then deleted
> > *before* the next poll would not make it into the exported list.
Thanks, I made that change.
- Alan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/130/#review48
---
On 2010-11-30 12:08:32, Alan Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/130/
> ---
>
> (Updated 2010-11-30 12:08:32)
>
>
> Review request for qpid.
>
>
> Summary
> ---
>
> This patch is a roll up of the following 3 patches:
>
> commit 5b28517ab3890a7f5316f2c89964343b9cc0b0dd
> Author: Alan Conway
> Date: Mon Nov 29 14:39:46 2010 -0500
>
> Modified cluster_tests causes broker shut down with invalid-argument
> error.
>
> Described in https://bugzilla.redhat.com/show_bug.cgi?id=655078. The
> management agent's deleted-object list was not being replicated to new
> members joining the cluster, so management generated fewer deleted
> object notifications on the newer member, causing it to fail with an
> invalid-argument error. The list is now being replicated correctly.
>
> commit 733262b4d6cec8b0d30db949bfa93f11dc07773f
> Author: Alan Conway
> Date: Tue Nov 23 16:35:24 2010 -0500
>
> Add missing call to Message::setTimestamp in
> ManagementAgent::sendBufferLH.
>
> commit 32ed120146db5f756d8ea4f9a7e0330bf5716f9d
> Author: Alan Conway
> Date: Tue Nov 23 15:50:00 2010 -0500
>
> Enable cluster-safe assertions on transition to CATCHUP
>
> Delaying until READY was causing multiple clientConnect management
> events to be raised, because broker::Connection::setUserId relies on
> sys::isCluster to avoid producing duplicate events with
>
>
> Diffs
> -
>
> /trunk/qpid/cpp/src/cluster.mk 1040689
> /trunk/qpid/cpp/src/qpid/cluster/Cluster.cpp 1040689
> /trunk/qpid/cpp/src/qpid/cluster/Connection.h 1040689
> /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1040689
> /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1040689
> /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1040689
> /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1040689
> /trunk/qpid/cpp/src/tests/cluster_tests.py 1040689
> /trunk/qpid/cpp/xml/cluster.xml 1040689
>
> Diff: https://reviews.apache.org/r/130/diff
>
>
> Testing
> ---
>
> Passes make check, make check-long. Currently running make check-long in a
> loop.
>
>
> Thanks,
>
> Alan
>
>
[jira] Commented: (QPID-2949) broker prompts console interactively for password when --auth=no
[ https://issues.apache.org/jira/browse/QPID-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965737#action_12965737 ] Steve Huston commented on QPID-2949: This patch broke the Windows build: ..\..\qpid\cpp\src\qpid\client\windows\SaslFactory.cpp(105) : error C2511: 'std::auto_ptr<_Ty> qpid::SaslFactory::create(const std::string &,const std::string &,const std::string &,const std::string &,int,int)' : overloaded member function not found in 'qpid::SaslFactory' please see http://www.riverace.com/CDash-1.4.2/viewBuildError.php?buildid=1032 for more info, but the above error is the one that matters. > broker prompts console interactively for password when --auth=no > > > Key: QPID-2949 > URL: https://issues.apache.org/jira/browse/QPID-2949 > Project: Qpid > Issue Type: Bug > Components: C++ Broker >Affects Versions: 0.8 >Reporter: michael j. goulish >Assignee: michael j. goulish >Priority: Minor > Fix For: 0.9 > > Attachments: dont_prompt_me_2.diff > > > As a result of checkin svn r1024541, which promoted some client-side Sasl > code to the common library for use in broker, the broker now prompts for a > password when when it is run with --auth=no ! > The attached patch removes this behavior by propagating knowledge of > "--auth=no" down to SaslFactory. If authorization has been turned off, the > Saslfactory will create a null sasl object, just like it does if the code is > compiled with no Sasl support. > TODO -- also must fix the pathway where auth==yes. > NOTE: this is apparently an irritant rather than a disaster, since it did not > affect make check after the original checkin ( r102451 ). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: Review Request: Fix for bug 655078: Modified cluster_tests causes broker shut down with invalid-argument error.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/130/#review48
---
Alan, I think I found a bug in the part of the code I contributed to this patch:
In ManagementAgent::exportDeletedObject() - we should add a call to
moveNewObjectsLH() right before entering the main loop. Specifically:
=
void ManagementAgent::exportDeletedObjects(DeletedObjectList& outList)
{
sys::Mutex::ScopedLock lock (userLock);
list > deleteList;
+
+ moveNewObjectsLH();
for (ManagementObjectMap::iterator iter = managementObjects.begin();
iter != managementObjects.end();
iter++) {
==
Without this, there is a small chance that objects added, then deleted *before*
the next poll would not make it into the exported list.
- Kenneth
On 2010-11-30 12:08:32, Alan Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/130/
> ---
>
> (Updated 2010-11-30 12:08:32)
>
>
> Review request for qpid.
>
>
> Summary
> ---
>
> This patch is a roll up of the following 3 patches:
>
> commit 5b28517ab3890a7f5316f2c89964343b9cc0b0dd
> Author: Alan Conway
> Date: Mon Nov 29 14:39:46 2010 -0500
>
> Modified cluster_tests causes broker shut down with invalid-argument
> error.
>
> Described in https://bugzilla.redhat.com/show_bug.cgi?id=655078. The
> management agent's deleted-object list was not being replicated to new
> members joining the cluster, so management generated fewer deleted
> object notifications on the newer member, causing it to fail with an
> invalid-argument error. The list is now being replicated correctly.
>
> commit 733262b4d6cec8b0d30db949bfa93f11dc07773f
> Author: Alan Conway
> Date: Tue Nov 23 16:35:24 2010 -0500
>
> Add missing call to Message::setTimestamp in
> ManagementAgent::sendBufferLH.
>
> commit 32ed120146db5f756d8ea4f9a7e0330bf5716f9d
> Author: Alan Conway
> Date: Tue Nov 23 15:50:00 2010 -0500
>
> Enable cluster-safe assertions on transition to CATCHUP
>
> Delaying until READY was causing multiple clientConnect management
> events to be raised, because broker::Connection::setUserId relies on
> sys::isCluster to avoid producing duplicate events with
>
>
> Diffs
> -
>
> /trunk/qpid/cpp/src/cluster.mk 1040689
> /trunk/qpid/cpp/src/qpid/cluster/Cluster.cpp 1040689
> /trunk/qpid/cpp/src/qpid/cluster/Connection.h 1040689
> /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1040689
> /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1040689
> /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1040689
> /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1040689
> /trunk/qpid/cpp/src/tests/cluster_tests.py 1040689
> /trunk/qpid/cpp/xml/cluster.xml 1040689
>
> Diff: https://reviews.apache.org/r/130/diff
>
>
> Testing
> ---
>
> Passes make check, make check-long. Currently running make check-long in a
> loop.
>
>
> Thanks,
>
> Alan
>
>
[VOTE] Release RC3 as Qpid 0.8
As RC3 has now been out for a week without call for blocking changes to be made, it seems like it is time for a vote. If you haven't already got it, RC3 can now be found for download at: http://people.apache.org/~robbie/qpid/0.8/RC3/ It was produced from r1037942 of the 0.8-release-candidates branch. The output from running RAT across the 'full release' archive can be found at the following URL: http://people.apache.org/~robbie/qpid/0.8/0.8rc3_rat_output.txt The changes since RC2 were: - Updates to various RELEASE_NOTES files - Updates to/addition of various README files - Remove a few redundant or out of date scripts/README files from Java tree - Update to avoid error in the cpp hello_xml example - Make the ruby hello example executable - QPID-2914: python address parser doesn't recognize None - QPID-2947: update slf4j to allow using the Java client package out-of-the-box - QPID-2948: Generated API docs have extraneous macro names in method signatures - QPID-2950: stop incorrectly logging an expected exception during DerbyMessageStore closure The rules for release voting are summarised as follows: based on majority approval but officially only that requires three +1 votes be cast in order to release, and it is not possible to veto a release. The process is covered at: http://www.apache.org/foundation/voting.html#ReleaseVotes This vote will close at 3pm GMT on Saturday 4th December 2010 (i.e. 72.5 hrs from now), after which I will tally the votes. Please indicate your response by replying to this email either with a '+1, 0, -1' type answer, or by checking a box in the below options: [ ] Yes, release RC3 as Qpid 0.8 [ ] No, I have an issue which I'll discuss in a new thread. Thanks, Robbie - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[python-qpid] Blocking on dead sockets
Hi! I use python-qpid and I have faced with a few bugs in it: * If you open a few connections, and one of them breaks (for example, due to a network error), another connections can be locked for time, which is equal to network timeout of the broken connection. This happens due to working with sockets in blocking mode and due to using one Selector for all connections. * All connections could become locked forever due to races between Driver and Selector objects. Driver object removes itself from the Selector non-atomically and a situation when Driver is alredy closed, but the Selector refers to it could happen. In this case select() call in the Selector raise an exeption due to self._transport.fileno() call on Driver where self._transport is None. The selector doesn't handle errors on select(), so the selector's thread will be stopped due to unhandled Exception. * There is no checks on EINTR error on os.* calls. As a temporary solution for me, I've written a patch, which fixes the errors: https://github.com/KonishchevDmitry/qpid/commit/9090f7f32f5746d00de6fc378ac4b2f4fa75b856 It would be good if you'd include this patch to a new version of Qpid. -- Dmitry Konishchev mailto:konishc...@gmail.com - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
