date:20121012

[jira] [Created] (QPID-4368) Add AMQP 1.0 Support

2012-10-12 Thread Gordon Sim (JIRA)

Gordon Sim created QPID-4368:


 Summary: Add AMQP 1.0 Support
 Key: QPID-4368
 URL: https://issues.apache.org/jira/browse/QPID-4368
 Project: Qpid
  Issue Type: Improvement
  Components: C++ Broker, C++ Client
Reporter: Gordon Sim
Assignee: Gordon Sim
 Fix For: 0.19




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-3866) Priority ring queue lets lower-priority message displace higher-priority

2012-10-12 Thread Gordon Sim (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-3866.
--

   Resolution: Fixed
Fix Version/s: 0.19

Fixed as part of QPID-4178

 Priority ring queue lets lower-priority message displace higher-priority
 

 Key: QPID-3866
 URL: https://issues.apache.org/jira/browse/QPID-3866
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.14
Reporter: Alan Conway
Assignee: Gordon Sim
 Fix For: 0.19

 Attachments: priority-ring.py


 Currently a ring+priority queue works by removing the lowest priority message
 if the limit is reached. However it does not consider whether the new message
 is actually of lower priority than the one being displaced. A lower priority
 message should not displace a higher-priority message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-4178) qpidd refactor

2012-10-12 Thread Gordon Sim (JIRA)

[
https://issues.apache.org/jira/browse/QPID-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gordon Sim resolved QPID-4178.
--

Resolution: Fixed

qpidd refactor
--

Key: QPID-4178
URL: https://issues.apache.org/jira/browse/QPID-4178
Project: Qpid
Issue Type: Improvement
Components: C++ Broker
Reporter: Gordon Sim
Assignee: Gordon Sim
Fix For: 0.19

Attachments: refactor_store_impact.patch

== Background ==
I've been looking at what would be required to get AMQP 1.0 support in
the qpidd broker (using proton-c). In that context I felt there was a
need to refactor the broker code, particularly that part that would be
shared between different protocol versions. Part of the motivation was
clearer separation of 0-10 specific logic, so that 1.0 logic could be
introduced as an alternative. However part of it was also simply the
recognition of some long-standing problems that we have never stopped
to address.
So, here is a patch representing my ideas on what is needed. This is
a little stale again (patch was generated against r13613342) and
needs (yet) another rebase. However it is getting to the point where I'll be
asking to commit it soon, so if anyone has feedback, now is the time to give
it!
== Key Changes ==
qpid::broker::Message
This is now supposed to be a protocol neutral representation of a
message. It no longer exposes qpid::framing::FrameSet. It can be based
on data received in different encodings (this patch only includes the
existing 0-10 encoding).
The immutable, sharable state is separated from the mutable
queue-specific state. Messages themselves are no longer held through a
shared pointer but are passed by reference or copied if needed. The
immutable state (essentially the data as received) *is* still shared
and referenced internally through an intrusive pointer. There is no
longer a message level lock. A message instance is 'owned' by
someother entity (usually the queue it is on) which controls
concurrent access/modification if necessary.
The persistence context is a separate part of the message
also. Currently that can be shared between two message instances if
desired.
qpid::broker::Messages
Switched from using qpid::broker::QueuedMessage (which relied on
shared pointer to message itself and made sequence number the explicit
- and only - way to refer to a specific message) to using modified
Message class directly and a new qpid::broker::QueueCursor.
The cursor is opaque outside the Messages implementation to which it
relates. It provides a way to refer to a specific message (without
directly using sequence number, though at present that is what is used
'under the covers') and/or to track progress through a sequence of
messages (for consumers or other iterating entities).
I.e. its an iterator to a Message within its containing Messages
instance that is not invalidated by changes to that container.
A Messages instance *owns* the Message instances within it. Other
classes access this through a reference or (raw) pointer, or if needed
copy it (the immutable part can be - and is - safely shared).
The codepath for browse/consume is a lot more unified now. You use a
cursor and call Messages::next() in each case. This also lays the
foundation for selectors.
The simplified Messages interface led to a simplied
MessageDistributor. There is still a little more to do to clarify
these separate roles (or indeed perhaps unify them?) but more on that
later.
qpid::broker::amqp_0_10::MessageTransfer
This represents the familiar 0-10 encoding of a message. This class is
broadly similar to the old Message class, based on a FrameSet. However
it represents the shared and essentially immutable state. The
sendHeader() method now explicitly takes a copy of the original
headers and adds to it or otherwise modifies it if needed (e.g. for
redelivered flag, ttl, annotations etc).
[Ideally I'd like to move more of the 0-10 specific classes out of
qpid::broker and into qpid::broker::amqp_0_10, but that has no
functional relevance so I've left existing classes alone for now.]
qpid::broker::Consumer
The deliver() method now takes a QueueCursor (representing a 'handle'
to this message for use in subsequent operations such as accept,
relese etc) and a *constant reference* to the Message itself
(i.e. consumers can't alter the state of the message on the queue
directly, but only through operations on the queue itself).
qpid::broker::QueueRegistry
The actual queue creation has been pulled out into a base class,
QueueFactory. The actual class of the Queue returned can now be varied
and there are two subclasses in the current patch. The first is a
replacement for the ring policy logic, whereby messages are removed
from the queue in order to keep the queue from

44 matches

Mail list logo