[jira] [Commented] (PROTON-1532) Undefined method "plain" for SASL in Ruby binding

2017-08-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139544#comment-16139544
 ] 

ASF GitHub Bot commented on PROTON-1532:


Github user gberginc commented on the issue:

https://github.com/apache/qpid-proton/pull/116
  
Great, thanks! I am now closing this PR.


> Undefined method "plain" for SASL in Ruby binding
> -
>
> Key: PROTON-1532
> URL: https://issues.apache.org/jira/browse/PROTON-1532
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
> Environment: Centos, Ubuntu
>Reporter: Gregor Berginc
>Assignee: Alan Conway
> Fix For: proton-c-0.18.0
>
>
> When I try to connect to an AMQP endpoint using the URL of the form 
> amqp://user:password@host:port, I get an error about a missing "plain" 
> method. This occurs in [this 
> line|https://github.com/apache/qpid-proton/blob/master/proton-c/bindings/ruby/lib/reactor/connector.rb#L91].
>  This error can be reproduced simply using the following code
> {code:ruby}
> 2.3.3 :001 > require "qpid_proton"
>  => true 
> 2.3.3 :002 > transport = Qpid::Proton::Transport.new
>  => # @impl=# @__swigtype__="_p_pn_transport_t", 
> @proton_wrapper=#>> 
> 2.3.3 :003 > sasl = transport.sasl
>  => # @impl=# @__swigtype__="_p_pn_sasl_t">> 
> 2.3.3 :004 > sasl.plain('', '')
> NoMethodError: undefined method `plain' for 
> #
> from (irb):4
> from /usr/share/rvm/rubies/ruby-2.3.3/bin/irb:11:in `'
> {code}
> I have tried in Ubuntu 16.04 installing Proton via system packages and gem 
> 0.10.1 from Rubygems as well as in Centos 7, following the source code 
> install guide.
> I wonder if this method should be exposed by Swig somehow? Python binding 
> does not use it in that way, but it does set the username and password on the 
> connection.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1532) Undefined method "plain" for SASL in Ruby binding

2017-08-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139545#comment-16139545
 ] 

ASF GitHub Bot commented on PROTON-1532:


Github user gberginc closed the pull request at:

https://github.com/apache/qpid-proton/pull/116


> Undefined method "plain" for SASL in Ruby binding
> -
>
> Key: PROTON-1532
> URL: https://issues.apache.org/jira/browse/PROTON-1532
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
> Environment: Centos, Ubuntu
>Reporter: Gregor Berginc
>Assignee: Alan Conway
> Fix For: proton-c-0.18.0
>
>
> When I try to connect to an AMQP endpoint using the URL of the form 
> amqp://user:password@host:port, I get an error about a missing "plain" 
> method. This occurs in [this 
> line|https://github.com/apache/qpid-proton/blob/master/proton-c/bindings/ruby/lib/reactor/connector.rb#L91].
>  This error can be reproduced simply using the following code
> {code:ruby}
> 2.3.3 :001 > require "qpid_proton"
>  => true 
> 2.3.3 :002 > transport = Qpid::Proton::Transport.new
>  => # @impl=# @__swigtype__="_p_pn_transport_t", 
> @proton_wrapper=#>> 
> 2.3.3 :003 > sasl = transport.sasl
>  => # @impl=# @__swigtype__="_p_pn_sasl_t">> 
> 2.3.3 :004 > sasl.plain('', '')
> NoMethodError: undefined method `plain' for 
> #
> from (irb):4
> from /usr/share/rvm/rubies/ruby-2.3.3/bin/irb:11:in `'
> {code}
> I have tried in Ubuntu 16.04 installing Proton via system packages and gem 
> 0.10.1 from Rubygems as well as in Centos 7, following the source code 
> install guide.
> I wonder if this method should be exposed by Swig somehow? Python binding 
> does not use it in that way, but it does set the username and password on the 
> connection.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #116: PROTON-1532: Allow insecure mechanism in SASL

2017-08-23 Thread gberginc 
Github user gberginc closed the pull request at:

https://github.com/apache/qpid-proton/pull/116


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #116: PROTON-1532: Allow insecure mechanism in SASL

2017-08-23 Thread gberginc 
Github user gberginc commented on the issue:

https://github.com/apache/qpid-proton/pull/116
  
Great, thanks! I am now closing this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1532) Undefined method "plain" for SASL in Ruby binding

2017-08-23 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138767#comment-16138767
 ] 

ASF subversion and git services commented on PROTON-1532:
-

Commit 929681aa365cfad81f169fd22409cfa873db2deb in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=929681a ]

PROTON-1532: missing namespace in String.to_url


> Undefined method "plain" for SASL in Ruby binding
> -
>
> Key: PROTON-1532
> URL: https://issues.apache.org/jira/browse/PROTON-1532
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
> Environment: Centos, Ubuntu
>Reporter: Gregor Berginc
>Assignee: Alan Conway
> Fix For: proton-c-0.18.0
>
>
> When I try to connect to an AMQP endpoint using the URL of the form 
> amqp://user:password@host:port, I get an error about a missing "plain" 
> method. This occurs in [this 
> line|https://github.com/apache/qpid-proton/blob/master/proton-c/bindings/ruby/lib/reactor/connector.rb#L91].
>  This error can be reproduced simply using the following code
> {code:ruby}
> 2.3.3 :001 > require "qpid_proton"
>  => true 
> 2.3.3 :002 > transport = Qpid::Proton::Transport.new
>  => # @impl=# @__swigtype__="_p_pn_transport_t", 
> @proton_wrapper=#>> 
> 2.3.3 :003 > sasl = transport.sasl
>  => # @impl=# @__swigtype__="_p_pn_sasl_t">> 
> 2.3.3 :004 > sasl.plain('', '')
> NoMethodError: undefined method `plain' for 
> #
> from (irb):4
> from /usr/share/rvm/rubies/ruby-2.3.3/bin/irb:11:in `'
> {code}
> I have tried in Ubuntu 16.04 installing Proton via system packages and gem 
> 0.10.1 from Rubygems as well as in Centos 7, following the source code 
> install guide.
> I wonder if this method should be exposed by Swig somehow? Python binding 
> does not use it in that way, but it does set the username and password on the 
> connection.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1532) Undefined method "plain" for SASL in Ruby binding

2017-08-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138738#comment-16138738
 ] 

ASF GitHub Bot commented on PROTON-1532:


Github user alanconway commented on the issue:

https://github.com/apache/qpid-proton/pull/116
  
On Wed, 2017-08-23 at 00:06 -0700, Gregor Berginc wrote:
> @alanconway initially, I was using the gem from the rubygems link you 
mentioned, yes. I am looking forward to the new published version. Until then, 
I will host the gem at https://github.com/gberginc/qpid_proton_gem for I need 
to be able to deploy it from another app.
> I have tested your change and it almost worked for me. I only had to 
apply the following patch:
> diff --git a/proton-c/bindings/ruby/lib/core/url.rb 
b/proton-c/bindings/ruby/lib/core/url.rb
> index 39b64650..195567f2 100644
> --- a/proton-c/bindings/ruby/lib/core/url.rb
> +++ b/proton-c/bindings/ruby/lib/core/url.rb
> @@ -84,6 +84,6 @@ end
>  class String
># Convert this string to a URL
>def to_url()
> -return URL.new(self)
> +return Qpid::Proton::URL.new(self)
>end
>  end
> Not sure if this is because I am using the code from outside of the gem 
itself, though.
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.

I'll apply it, thanks!




> Undefined method "plain" for SASL in Ruby binding
> -
>
> Key: PROTON-1532
> URL: https://issues.apache.org/jira/browse/PROTON-1532
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
> Environment: Centos, Ubuntu
>Reporter: Gregor Berginc
>Assignee: Alan Conway
> Fix For: proton-c-0.18.0
>
>
> When I try to connect to an AMQP endpoint using the URL of the form 
> amqp://user:password@host:port, I get an error about a missing "plain" 
> method. This occurs in [this 
> line|https://github.com/apache/qpid-proton/blob/master/proton-c/bindings/ruby/lib/reactor/connector.rb#L91].
>  This error can be reproduced simply using the following code
> {code:ruby}
> 2.3.3 :001 > require "qpid_proton"
>  => true 
> 2.3.3 :002 > transport = Qpid::Proton::Transport.new
>  => # @impl=# @__swigtype__="_p_pn_transport_t", 
> @proton_wrapper=#>> 
> 2.3.3 :003 > sasl = transport.sasl
>  => # @impl=# @__swigtype__="_p_pn_sasl_t">> 
> 2.3.3 :004 > sasl.plain('', '')
> NoMethodError: undefined method `plain' for 
> #
> from (irb):4
> from /usr/share/rvm/rubies/ruby-2.3.3/bin/irb:11:in `'
> {code}
> I have tried in Ubuntu 16.04 installing Proton via system packages and gem 
> 0.10.1 from Rubygems as well as in Centos 7, following the source code 
> install guide.
> I wonder if this method should be exposed by Swig somehow? Python binding 
> does not use it in that way, but it does set the username and password on the 
> connection.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #116: PROTON-1532: Allow insecure mechanism in SASL

2017-08-23 Thread alanconway 
Github user alanconway commented on the issue:

https://github.com/apache/qpid-proton/pull/116
  
On Wed, 2017-08-23 at 00:06 -0700, Gregor Berginc wrote:
> @alanconway initially, I was using the gem from the rubygems link you 
mentioned, yes. I am looking forward to the new published version. Until then, 
I will host the gem at https://github.com/gberginc/qpid_proton_gem for I need 
to be able to deploy it from another app.
> I have tested your change and it almost worked for me. I only had to 
apply the following patch:
> diff --git a/proton-c/bindings/ruby/lib/core/url.rb 
b/proton-c/bindings/ruby/lib/core/url.rb
> index 39b64650..195567f2 100644
> --- a/proton-c/bindings/ruby/lib/core/url.rb
> +++ b/proton-c/bindings/ruby/lib/core/url.rb
> @@ -84,6 +84,6 @@ end
>  class String
># Convert this string to a URL
>def to_url()
> -return URL.new(self)
> +return Qpid::Proton::URL.new(self)
>end
>  end
> Not sure if this is because I am using the code from outside of the gem 
itself, though.
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.

I'll apply it, thanks!




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator

2017-08-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138692#comment-16138692
 ] 

ASF GitHub Bot commented on DISPATCH-802:
-

GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/190

DISPATCH-802 - Additional fixes - 1. Modified error name to amqp:prec…

…ondition-failed. 2. Modified error description 3. Prevented from setting 
the target on the return attach

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-802-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #190


commit 667fab3282a20c96e2a741914b8cbfedd075d041
Author: Ganesh Murthy 
Date:   2017-08-23T17:23:41Z

DISPATCH-802 - Additional fixes - 1. Modified error name to 
amqp:precondition-failed. 2. Modified error description 3. Prevented from 
setting the target on the return attach




> refuse transaction coordination links if they can't be routed to a coordinator
> --
>
> Key: DISPATCH-802
> URL: https://issues.apache.org/jira/browse/DISPATCH-802
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.8.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
> Fix For: 1.0.0
>
>
> The router is accepting transaction coordinator links even if the support 
> from DISPATCH-195 is not being used to link-route them somewhere that can 
> handle coordination. If the router can't link-route to a coordinator, and 
> knows it can't coordinate transactions itself, it shouldn't accept the links 
> to begin with but rather refuse them so clients know they will never work and 
> why.
> Prior to 0.8.0, credit was also given on these links, allowing attempt to 
> declare transactions. From 0.8.0 no credit is given since there is no 
> receiver, so clients have no way to use the accepted link and no indication 
> why.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #190: DISPATCH-802 - Additional fixes - 1. Modifi...

2017-08-23 Thread ganeshmurthy 
GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/190

DISPATCH-802 - Additional fixes - 1. Modified error name to amqp:prec…

…ondition-failed. 2. Modified error description 3. Prevented from setting 
the target on the return attach

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-802-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #190


commit 667fab3282a20c96e2a741914b8cbfedd075d041
Author: Ganesh Murthy 
Date:   2017-08-23T17:23:41Z

DISPATCH-802 - Additional fixes - 1. Modified error name to 
amqp:precondition-failed. 2. Modified error description 3. Prevented from 
setting the target on the return attach




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7896) Create system tests testing end-to-end message conversion

2017-08-23 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-7896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138513#comment-16138513
 ] 

ASF subversion and git services commented on QPID-7896:
---

Commit a7e4a716b3a8792a3e53e50f82c897a3ff33de08 in qpid-broker-j's branch 
refs/heads/master from [~lorenz.quack]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=a7e4a71 ]

QPID-7896: [Java System Tests] Create system tests testing end-to-end message 
conversion


> Create system tests testing end-to-end message conversion
> -
>
> Key: QPID-7896
> URL: https://issues.apache.org/jira/browse/QPID-7896
> Project: Qpid
>  Issue Type: New Feature
>  Components: Java Tests
>Reporter: Lorenz Quack
> Fix For: qpid-java-broker-7.0.0
>
>
> Qpid v7 has much matured AMQP 1.0 support.
> We expect adoption of AMQP 1.0 to only increase.
> Some users might want to perform a staged update of their client from AMQP 
> 0-x to 1.0.
> To support this message conversion becomes more important.
> To gain confidence in our message conversion capabilities we should have 
> system tests testing our main use case (JMS) end-to-end.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7434) Mature the AMQP message conversion layer (headers and content)

2017-08-23 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138515#comment-16138515
 ] 

ASF subversion and git services commented on QPID-7434:
---

Commit d12b40a4d066d79e5dc38b7b137a73b776817f0a in qpid-broker-j's branch 
refs/heads/master from [~lorenz.quack]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=d12b40a ]

QPID-7434: [Java Broker] Fix AMQP 0-10 to 1.0 correlationId conversion


> Mature the AMQP message conversion layer (headers and content)
> --
>
> Key: QPID-7434
> URL: https://issues.apache.org/jira/browse/QPID-7434
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Lorenz Quack
> Fix For: qpid-java-broker-7.0.0
>
>
> There are a number of gaps in our message converters that mean some message 
> are not converted with complete fidelity (particularly in the treatment of 
> application headers), and where complete fidelity cannot be acheived we need 
> sensible rules, uniformly implemented to decide how aspects degrade.
> For instance, for AMQP 0-8..0-10 allow application headers whose values were 
> complex types (e.g. map).  AMQP 1.0 disallows this.  What should the 
> behaviour be?  Should the header be dropped?
> Another instance is the length and constituency of the keys of application 
> headers.  AMQP 0-8..0-10 have a protocol restriction of 255 UTF8 bytes.  AMQP 
> has supports longer strings.  Also AMQP 0-9 says further restricts the key to 
> be formed like a Java identifier.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-7897) [Java 0-8...0-9-1 Client] Message#getJMSCorrelationIDAsBytes() erroneously first converts to string before retreiving bytes

2017-08-23 Thread Lorenz Quack (JIRA) 
Lorenz Quack created QPID-7897:
--

 Summary: [Java 0-8...0-9-1 Client] 
Message#getJMSCorrelationIDAsBytes() erroneously first converts to string 
before retreiving bytes 
 Key: QPID-7897
 URL: https://issues.apache.org/jira/browse/QPID-7897
 Project: Qpid
  Issue Type: Bug
  Components: Java Client
Reporter: Lorenz Quack


If the correlationId of a message does not contain valid UTF_8 (e.g., set via 
{{javax.jms.Message#setJMSCorrelationIDAsBytes}}) then 
{{javax.jms.Message#getJMSCorrelationIDAsBytes}} does not return the correct 
value.

Some relevant code 
snippets:{{AMQMessageDelegate_0_8#getJMSCorrelationIDAsBytes}} is implemented 
as follows:
{code:title=AMQMessageDelegate_0_8.java}public byte[] 
getJMSCorrelationIDAsBytes() throws JMSException
{
return getContentHeaderProperties().getCorrelationIdAsString().getBytes();
}{code}
{code:title=BasicContentHeaderProperties}public String 
getCorrelationIdAsString()
{
return (_correlationId == null) ? null : _correlationId.toString();
}{code}
{code:title=AMQShortString}public String toString()
{
if (_asString == null)
{
_asString = new String(_data, _offset, _length, StandardCharsets.UTF_8);
}
return _asString;
}{code}

If {{_data}} does not contain valid UTF_8 the result of this call chain is 
incorrect.
I do not see a reason why {{AMQMessageDelegate_0_8#getJMSCorrelationIDAsBytes}} 
should not return 
{{getContentHeaderProperties().getCorrelationId().getBytes()}} instead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-7896) Create system tests testing end-to-end message conversion

2017-08-23 Thread Lorenz Quack (JIRA) 
Lorenz Quack created QPID-7896:
--

 Summary: Create system tests testing end-to-end message conversion
 Key: QPID-7896
 URL: https://issues.apache.org/jira/browse/QPID-7896
 Project: Qpid
  Issue Type: New Feature
  Components: Java Tests
Reporter: Lorenz Quack
 Fix For: qpid-java-broker-7.0.0


Qpid v7 has much matured AMQP 1.0 support.
We expect adoption of AMQP 1.0 to only increase.
Some users might want to perform a staged update of their client from AMQP 0-x 
to 1.0.
To support this message conversion becomes more important.
To gain confidence in our message conversion capabilities we should have system 
tests testing our main use case (JMS) end-to-end.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator

2017-08-23 Thread Robbie Gemmell (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138332#comment-16138332
 ] 

Robbie Gemmell commented on DISPATCH-802:
-

{quote}
but instead should look like this (target=null)
{quote}

Yep, thats how you signal to peers that the attach really failed and a detach 
will follow immediately to indicate why.

> refuse transaction coordination links if they can't be routed to a coordinator
> --
>
> Key: DISPATCH-802
> URL: https://issues.apache.org/jira/browse/DISPATCH-802
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.8.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
> Fix For: 1.0.0
>
>
> The router is accepting transaction coordinator links even if the support 
> from DISPATCH-195 is not being used to link-route them somewhere that can 
> handle coordination. If the router can't link-route to a coordinator, and 
> knows it can't coordinate transactions itself, it shouldn't accept the links 
> to begin with but rather refuse them so clients know they will never work and 
> why.
> Prior to 0.8.0, credit was also given on these links, allowing attempt to 
> declare transactions. From 0.8.0 no credit is given since there is no 
> receiver, so clients have no way to use the accepted link and no indication 
> why.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator

2017-08-23 Thread Ganesh Murthy (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138307#comment-16138307
 ] 

Ganesh Murthy commented on DISPATCH-802:


Currently the return attach looks like this - 
{noformat}
[2016906257:1] <- 
Attach{name='qpid-jms:coordinator:ID:db8ca07c-92cf-4f9f-a1eb-492b220709dc:1:1', 
handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
source=Source{address='null', durable=NONE, expiryPolicy=SESSION_END, 
timeout=0, dynamic=false, dynamicNodeProperties=null, distributionMode=null, 
filter=null, defaultOutcome=null, outcomes=null, capabilities=null}, 
target=Target{address='null', durable=NONE, expiryPolicy=SESSION_END, 
timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=null}, 
unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null, 
properties=null}
{noformat}

but instead should look like this (target=null)

{noformat}
[2016906257:1] <- 
Attach{name='qpid-jms:coordinator:ID:db8ca07c-92cf-4f9f-a1eb-492b220709dc:1:1', 
handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
source=Source{address='null', durable=NONE, expiryPolicy=SESSION_END, 
timeout=0, dynamic=false, dynamicNodeProperties=null, distributionMode=null, 
filter=null, defaultOutcome=null, outcomes=null, capabilities=null}, 
target=null, unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null, 
properties=null}
{noformat}

[~gemmellr] is that correct?

I also saw your other comment about amqp:precondition-failed and I will modify 
the code to do the same.

> refuse transaction coordination links if they can't be routed to a coordinator
> --
>
> Key: DISPATCH-802
> URL: https://issues.apache.org/jira/browse/DISPATCH-802
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.8.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
> Fix For: 1.0.0
>
>
> The router is accepting transaction coordinator links even if the support 
> from DISPATCH-195 is not being used to link-route them somewhere that can 
> handle coordination. If the router can't link-route to a coordinator, and 
> knows it can't coordinate transactions itself, it shouldn't accept the links 
> to begin with but rather refuse them so clients know they will never work and 
> why.
> Prior to 0.8.0, credit was also given on these links, allowing attempt to 
> declare transactions. From 0.8.0 no credit is given since there is no 
> receiver, so clients have no way to use the accepted link and no indication 
> why.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7890) Qpid C++ Broker 1.36 Max Connections Per User Option not working

2017-08-23 Thread Robbie Gemmell (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138264#comment-16138264
 ] 

Robbie Gemmell commented on QPID-7890:
--

Questions should generally go to the users@ mailing list.

I noticed that [~chug] said the following last week in a reply to the 
notification mails that go to the dev@ mailing list, which you might not have 
seen as a result:

{quote}
Try enabling logging in the qpidd command line:
  --log-enable debug+:Security

That should expose the acl policy logic that arrives at the connection 
allow/deny conclusions.
{quote}

> Qpid C++ Broker 1.36 Max Connections Per User Option not working
> 
>
> Key: QPID-7890
> URL: https://issues.apache.org/jira/browse/QPID-7890
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.36.0
> Environment: Windows 10 64-Bit, Qpid C++ Broker 1.36
>Reporter: Spud Strumpet
>
> I have been trying to configure the maximum connections per user but none of 
> the options seem to be having an affect. 
> I have tried various combinations of setting:
> * --connection-limit-per-user N on the command line, and 
> * quota connections N username in the acl file
> In the broker trace log, it confirms that the connection limit is enabled, 
> but all connections then succeed anyway. None are rejected.
> I have tried setting max connections to zero in both places for all users, 
> but still I can connect.
> Is anyone able to confirm that the max connections options are working as 
> expected in the C++ 1.36 Broker? Thanks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-7890) Qpid C++ Broker 1.36 Max Connections Per User Option not working

2017-08-23 Thread Spud Strumpet (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Spud Strumpet updated QPID-7890:

Labels:   (was: connection)

> Qpid C++ Broker 1.36 Max Connections Per User Option not working
> 
>
> Key: QPID-7890
> URL: https://issues.apache.org/jira/browse/QPID-7890
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.36.0
> Environment: Windows 10 64-Bit, Qpid C++ Broker 1.36
>Reporter: Spud Strumpet
>
> I have been trying to configure the maximum connections per user but none of 
> the options seem to be having an affect. 
> I have tried various combinations of setting:
> * --connection-limit-per-user N on the command line, and 
> * quota connections N username in the acl file
> In the broker trace log, it confirms that the connection limit is enabled, 
> but all connections then succeed anyway. None are rejected.
> I have tried setting max connections to zero in both places for all users, 
> but still I can connect.
> Is anyone able to confirm that the max connections options are working as 
> expected in the C++ 1.36 Broker? Thanks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-7890) Qpid C++ Broker 1.36 Max Connections Per User Option not working

2017-08-23 Thread Spud Strumpet (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Spud Strumpet updated QPID-7890:

Labels: connection  (was: )

> Qpid C++ Broker 1.36 Max Connections Per User Option not working
> 
>
> Key: QPID-7890
> URL: https://issues.apache.org/jira/browse/QPID-7890
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.36.0
> Environment: Windows 10 64-Bit, Qpid C++ Broker 1.36
>Reporter: Spud Strumpet
>
> I have been trying to configure the maximum connections per user but none of 
> the options seem to be having an affect. 
> I have tried various combinations of setting:
> * --connection-limit-per-user N on the command line, and 
> * quota connections N username in the acl file
> In the broker trace log, it confirms that the connection limit is enabled, 
> but all connections then succeed anyway. None are rejected.
> I have tried setting max connections to zero in both places for all users, 
> but still I can connect.
> Is anyone able to confirm that the max connections options are working as 
> expected in the C++ 1.36 Broker? Thanks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-7890) Qpid C++ Broker 1.36 Max Connections Per User Option not working

2017-08-23 Thread Spud Strumpet (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Spud Strumpet updated QPID-7890:

Affects Version/s: qpid-cpp-1.36.0

> Qpid C++ Broker 1.36 Max Connections Per User Option not working
> 
>
> Key: QPID-7890
> URL: https://issues.apache.org/jira/browse/QPID-7890
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: qpid-cpp-1.36.0
> Environment: Windows 10 64-Bit, Qpid C++ Broker 1.36
>Reporter: Spud Strumpet
>
> I have been trying to configure the maximum connections per user but none of 
> the options seem to be having an affect. 
> I have tried various combinations of setting:
> * --connection-limit-per-user N on the command line, and 
> * quota connections N username in the acl file
> In the broker trace log, it confirms that the connection limit is enabled, 
> but all connections then succeed anyway. None are rejected.
> I have tried setting max connections to zero in both places for all users, 
> but still I can connect.
> Is anyone able to confirm that the max connections options are working as 
> expected in the C++ 1.36 Broker? Thanks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-810) auto link fails to trigger

2017-08-23 Thread Gordon Sim (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DISPATCH-810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved DISPATCH-810.
-
Resolution: Fixed

> auto link fails to trigger
> --
>
> Key: DISPATCH-810
> URL: https://issues.apache.org/jira/browse/DISPATCH-810
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.8.0
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.8.1, 1.0.0
>
>
> In some circumstances, e.g. under CI with limited CPU, an auto-link that is 
> configured to be setup when a matching container connects in to the router 
> will fail to trigger. This is because the qdr_connection_t and the 
> qd_connection_t are not linked together in time at the point the connection 
> is activated by the core thread (responding to the qdr_connection_opened 
> event), so the connection never gets a wakeup event and never checks for 
> actions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #116: PROTON-1532: Allow insecure mechanism in SASL

2017-08-23 Thread gberginc 
Github user gberginc commented on the issue:

https://github.com/apache/qpid-proton/pull/116
  
@alanconway initially, I was using the gem from the rubygems link you 
mentioned, yes. I am looking forward to the new published version. Until then, 
I will host the gem at https://github.com/gberginc/qpid_proton_gem for I need 
to be able to deploy it from another app.

I have tested your change and it almost worked for me. I only had to apply 
the following patch:
```
diff --git a/proton-c/bindings/ruby/lib/core/url.rb 
b/proton-c/bindings/ruby/lib/core/url.rb
index 39b64650..195567f2 100644
--- a/proton-c/bindings/ruby/lib/core/url.rb
+++ b/proton-c/bindings/ruby/lib/core/url.rb
@@ -84,6 +84,6 @@ end
 class String
   # Convert this string to a URL
   def to_url()
-return URL.new(self)
+return Qpid::Proton::URL.new(self)
   end
 end
```

Not sure if this is because I am using the code from outside of the gem 
itself, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1532) Undefined method "plain" for SASL in Ruby binding

2017-08-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137989#comment-16137989
 ] 

ASF GitHub Bot commented on PROTON-1532:


Github user gberginc commented on the issue:

https://github.com/apache/qpid-proton/pull/116
  
@alanconway initially, I was using the gem from the rubygems link you 
mentioned, yes. I am looking forward to the new published version. Until then, 
I will host the gem at https://github.com/gberginc/qpid_proton_gem for I need 
to be able to deploy it from another app.

I have tested your change and it almost worked for me. I only had to apply 
the following patch:
```
diff --git a/proton-c/bindings/ruby/lib/core/url.rb 
b/proton-c/bindings/ruby/lib/core/url.rb
index 39b64650..195567f2 100644
--- a/proton-c/bindings/ruby/lib/core/url.rb
+++ b/proton-c/bindings/ruby/lib/core/url.rb
@@ -84,6 +84,6 @@ end
 class String
   # Convert this string to a URL
   def to_url()
-return URL.new(self)
+return Qpid::Proton::URL.new(self)
   end
 end
```

Not sure if this is because I am using the code from outside of the gem 
itself, though.


> Undefined method "plain" for SASL in Ruby binding
> -
>
> Key: PROTON-1532
> URL: https://issues.apache.org/jira/browse/PROTON-1532
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
> Environment: Centos, Ubuntu
>Reporter: Gregor Berginc
>Assignee: Alan Conway
> Fix For: proton-c-0.18.0
>
>
> When I try to connect to an AMQP endpoint using the URL of the form 
> amqp://user:password@host:port, I get an error about a missing "plain" 
> method. This occurs in [this 
> line|https://github.com/apache/qpid-proton/blob/master/proton-c/bindings/ruby/lib/reactor/connector.rb#L91].
>  This error can be reproduced simply using the following code
> {code:ruby}
> 2.3.3 :001 > require "qpid_proton"
>  => true 
> 2.3.3 :002 > transport = Qpid::Proton::Transport.new
>  => # @impl=# @__swigtype__="_p_pn_transport_t", 
> @proton_wrapper=#>> 
> 2.3.3 :003 > sasl = transport.sasl
>  => # @impl=# @__swigtype__="_p_pn_sasl_t">> 
> 2.3.3 :004 > sasl.plain('', '')
> NoMethodError: undefined method `plain' for 
> #
> from (irb):4
> from /usr/share/rvm/rubies/ruby-2.3.3/bin/irb:11:in `'
> {code}
> I have tried in Ubuntu 16.04 installing Proton via system packages and gem 
> 0.10.1 from Rubygems as well as in Centos 7, following the source code 
> install guide.
> I wonder if this method should be exposed by Swig somehow? Python binding 
> does not use it in that way, but it does set the username and password on the 
> connection.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org