[jira] [Resolved] (DISPATCH-1117) doc on update logging with qdmanage is inaccurate
[ https://issues.apache.org/jira/browse/DISPATCH-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved DISPATCH-1117. -- Resolution: Fixed > doc on update logging with qdmanage is inaccurate > - > > Key: DISPATCH-1117 > URL: https://issues.apache.org/jira/browse/DISPATCH-1117 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > > (1) it shows examples using a 'create' operation which is not supported (and > not needed) > (2) it does not include name option for update which is required > (3) it has '–' in front of attributes which is incorrect > (4) it shows specifying the module on update which should not be recommended > (see DISPATCH-1116) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1117) doc on update logging with qdmanage is inaccurate
[ https://issues.apache.org/jira/browse/DISPATCH-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606459#comment-16606459 ] ASF subversion and git services commented on DISPATCH-1117: --- Commit 06bfb541453c08b604e80531c594f7dfd553c79b in qpid-dispatch's branch refs/heads/master from Gordon Sim [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=06bfb54 ] DISPATCH-1117: suggested doc fixes > doc on update logging with qdmanage is inaccurate > - > > Key: DISPATCH-1117 > URL: https://issues.apache.org/jira/browse/DISPATCH-1117 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > > (1) it shows examples using a 'create' operation which is not supported (and > not needed) > (2) it does not include name option for update which is required > (3) it has '–' in front of attributes which is incorrect > (4) it shows specifying the module on update which should not be recommended > (see DISPATCH-1116) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1116) qdmanage lets the module of log instance be changed
[ https://issues.apache.org/jira/browse/DISPATCH-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved DISPATCH-1116. -- Resolution: Fixed > qdmanage lets the module of log instance be changed > --- > > Key: DISPATCH-1116 > URL: https://issues.apache.org/jira/browse/DISPATCH-1116 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > > E.g. > {noformat} > $ qdmanage update --type=log --name=log/ROUTER module=SERVER enable=trace+ > { > "enable": "trace+", > "type": "org.apache.qpid.dispatch.log", > "identity": "log/ROUTER", > "module": "SERVER", > "name": "log/AUTHSERVICE" > } > {noformat} > This seems unnecessary and likely to cause problems. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1116) qdmanage lets the module of log instance be changed
[ https://issues.apache.org/jira/browse/DISPATCH-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606457#comment-16606457 ] ASF GitHub Bot commented on DISPATCH-1116: -- Github user asfgit closed the pull request at: https://github.com/apache/qpid-dispatch/pull/372 > qdmanage lets the module of log instance be changed > --- > > Key: DISPATCH-1116 > URL: https://issues.apache.org/jira/browse/DISPATCH-1116 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > > E.g. > {noformat} > $ qdmanage update --type=log --name=log/ROUTER module=SERVER enable=trace+ > { > "enable": "trace+", > "type": "org.apache.qpid.dispatch.log", > "identity": "log/ROUTER", > "module": "SERVER", > "name": "log/AUTHSERVICE" > } > {noformat} > This seems unnecessary and likely to cause problems. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1116) qdmanage lets the module of log instance be changed
[ https://issues.apache.org/jira/browse/DISPATCH-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606456#comment-16606456 ] ASF subversion and git services commented on DISPATCH-1116: --- Commit 6c34481438d6c268d3e8debd238e8d5131ff7be1 in qpid-dispatch's branch refs/heads/master from Gordon Sim [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=6c34481 ] DISPATCH-1116: prevent module being updated on log instances > qdmanage lets the module of log instance be changed > --- > > Key: DISPATCH-1116 > URL: https://issues.apache.org/jira/browse/DISPATCH-1116 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > > E.g. > {noformat} > $ qdmanage update --type=log --name=log/ROUTER module=SERVER enable=trace+ > { > "enable": "trace+", > "type": "org.apache.qpid.dispatch.log", > "identity": "log/ROUTER", > "module": "SERVER", > "name": "log/AUTHSERVICE" > } > {noformat} > This seems unnecessary and likely to cause problems. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #372: DISPATCH-1116: prevent module being updated...
Github user asfgit closed the pull request at: https://github.com/apache/qpid-dispatch/pull/372 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1116) qdmanage lets the module of log instance be changed
[ https://issues.apache.org/jira/browse/DISPATCH-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606348#comment-16606348 ] ASF GitHub Bot commented on DISPATCH-1116: -- Github user grs commented on the issue: https://github.com/apache/qpid-dispatch/pull/372 @ganeshmurthy @ted-ross does this look ok? > qdmanage lets the module of log instance be changed > --- > > Key: DISPATCH-1116 > URL: https://issues.apache.org/jira/browse/DISPATCH-1116 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > > E.g. > {noformat} > $ qdmanage update --type=log --name=log/ROUTER module=SERVER enable=trace+ > { > "enable": "trace+", > "type": "org.apache.qpid.dispatch.log", > "identity": "log/ROUTER", > "module": "SERVER", > "name": "log/AUTHSERVICE" > } > {noformat} > This seems unnecessary and likely to cause problems. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1117) doc on update logging with qdmanage is inaccurate
[ https://issues.apache.org/jira/browse/DISPATCH-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606347#comment-16606347 ] ASF GitHub Bot commented on DISPATCH-1117: -- Github user grs commented on the issue: https://github.com/apache/qpid-dispatch/pull/373 @bhardesty does this look ok? > doc on update logging with qdmanage is inaccurate > - > > Key: DISPATCH-1117 > URL: https://issues.apache.org/jira/browse/DISPATCH-1117 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > > (1) it shows examples using a 'create' operation which is not supported (and > not needed) > (2) it does not include name option for update which is required > (3) it has '–' in front of attributes which is incorrect > (4) it shows specifying the module on update which should not be recommended > (see DISPATCH-1116) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #372: DISPATCH-1116: prevent module being updated on log...
Github user grs commented on the issue: https://github.com/apache/qpid-dispatch/pull/372 @ganeshmurthy @ted-ross does this look ok? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #373: DISPATCH-1117: suggested doc fixes
Github user grs commented on the issue: https://github.com/apache/qpid-dispatch/pull/373 @bhardesty does this look ok? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #373: DISPATCH-1117: suggested doc fixes
Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/373 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=h1) Report > Merging [#373](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/eb766e3ade97b4ee5bca0b21ebe7403a8317d6e9?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/373/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #373 +/- ## == + Coverage 84.79% 84.83% +0.04% == Files 70 70 Lines 1600416002 -2 == + Hits1357013575 +5 + Misses 2434 2427 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=tree) | Coverage Π| | |---|---|---| | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.21% <0%> (-0.58%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `76.55% <0%> (-0.2%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `88.19% <0%> (+0.19%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.09% <0%> (+0.21%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.87% <0%> (+0.26%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.44% <0%> (+0.45%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=footer). Last update [eb766e3...792dfa8](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1117) doc on update logging with qdmanage is inaccurate
[ https://issues.apache.org/jira/browse/DISPATCH-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606328#comment-16606328 ] ASF GitHub Bot commented on DISPATCH-1117: -- Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/373 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=h1) Report > Merging [#373](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/eb766e3ade97b4ee5bca0b21ebe7403a8317d6e9?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/373/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #373 +/- ## == + Coverage 84.79% 84.83% +0.04% == Files 70 70 Lines 1600416002 -2 == + Hits1357013575 +5 + Misses 2434 2427 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.21% <0%> (-0.58%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `76.55% <0%> (-0.2%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `88.19% <0%> (+0.19%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.09% <0%> (+0.21%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.87% <0%> (+0.26%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/373/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.44% <0%> (+0.45%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=footer). Last update [eb766e3...792dfa8](https://codecov.io/gh/apache/qpid-dispatch/pull/373?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > doc on update logging with qdmanage is inaccurate > - > > Key: DISPATCH-1117 > URL: https://issues.apache.org/jira/browse/DISPATCH-1117 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > > (1) it shows examples using a 'create' operation which is not supported (and > not needed) > (2) it does not include name option for update which is required > (3) it has '–' in front of attributes which is incorrect > (4) it shows specifying the module on update which should not be recommended > (see DISPATCH-1116) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1113) Can't update log/AUTHSERVICE
[ https://issues.apache.org/jira/browse/DISPATCH-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved DISPATCH-1113. -- Resolution: Fixed > Can't update log/AUTHSERVICE > > > Key: DISPATCH-1113 > URL: https://issues.apache.org/jira/browse/DISPATCH-1113 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.3.0 >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1117) doc on update logging with qdmanage is inaccurate
[ https://issues.apache.org/jira/browse/DISPATCH-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606321#comment-16606321 ] ASF GitHub Bot commented on DISPATCH-1117: -- GitHub user grs opened a pull request: https://github.com/apache/qpid-dispatch/pull/373 DISPATCH-1117: suggested doc fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/grs/qpid-dispatch DISPATCH-1117 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/373.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #373 commit 792dfa80156bf22ae2c7a87c08c8206f0508fab1 Author: Gordon Sim Date: 2018-09-06T19:45:38Z DISPATCH-1117: suggested doc fixes > doc on update logging with qdmanage is inaccurate > - > > Key: DISPATCH-1117 > URL: https://issues.apache.org/jira/browse/DISPATCH-1117 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > > (1) it shows examples using a 'create' operation which is not supported (and > not needed) > (2) it does not include name option for update which is required > (3) it has '–' in front of attributes which is incorrect > (4) it shows specifying the module on update which should not be recommended > (see DISPATCH-1116) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #373: DISPATCH-1117: suggested doc fixes
GitHub user grs opened a pull request: https://github.com/apache/qpid-dispatch/pull/373 DISPATCH-1117: suggested doc fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/grs/qpid-dispatch DISPATCH-1117 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/373.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #373 commit 792dfa80156bf22ae2c7a87c08c8206f0508fab1 Author: Gordon Sim Date: 2018-09-06T19:45:38Z DISPATCH-1117: suggested doc fixes --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1117) doc on update logging with qdmanage is inaccurate
[ https://issues.apache.org/jira/browse/DISPATCH-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated DISPATCH-1117: - Description: (1) it shows examples using a 'create' operation which is not supported (and not needed) (2) it does not include name option for update which is required (3) it has '–' in front of attributes which is incorrect (4) it shows specifying the module on update which should not be recommended (see DISPATCH-1116) was: (1) it shows examples using a 'create' operation which is not supported (and not needed) (2) it has '–' in front of attributes which is incorrect (3) it shows specifying the module on update which should not be recommended (see DISPATCH-1116) > doc on update logging with qdmanage is inaccurate > - > > Key: DISPATCH-1117 > URL: https://issues.apache.org/jira/browse/DISPATCH-1117 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > > (1) it shows examples using a 'create' operation which is not supported (and > not needed) > (2) it does not include name option for update which is required > (3) it has '–' in front of attributes which is incorrect > (4) it shows specifying the module on update which should not be recommended > (see DISPATCH-1116) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1116) qdmanage lets the module of log instance be changed
[ https://issues.apache.org/jira/browse/DISPATCH-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606309#comment-16606309 ] ASF GitHub Bot commented on DISPATCH-1116: -- Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/372 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=h1) Report > Merging [#372](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/eb766e3ade97b4ee5bca0b21ebe7403a8317d6e9?src=pr&el=desc) will **increase** coverage by `0.07%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/372/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #372 +/- ## == + Coverage 84.79% 84.86% +0.07% == Files 70 70 Lines 1600416003 -1 == + Hits1357013581 +11 + Misses 2434 2422 -12 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `76.55% <0%> (-0.2%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.86% <0%> (+0.25%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.44% <0%> (+0.45%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.64% <0%> (+0.76%)` | :arrow_up: | | [src/router\_core/core\_timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGltZXIuYw==) | `96.42% <0%> (+1.78%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=footer). Last update [eb766e3...6c34481](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > qdmanage lets the module of log instance be changed > --- > > Key: DISPATCH-1116 > URL: https://issues.apache.org/jira/browse/DISPATCH-1116 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > > E.g. > {noformat} > $ qdmanage update --type=log --name=log/ROUTER module=SERVER enable=trace+ > { > "enable": "trace+", > "type": "org.apache.qpid.dispatch.log", > "identity": "log/ROUTER", > "module": "SERVER", > "name": "log/AUTHSERVICE" > } > {noformat} > This seems unnecessary and likely to cause problems. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1117) doc on update logging with qdmanage is inaccurate
Gordon Sim created DISPATCH-1117: Summary: doc on update logging with qdmanage is inaccurate Key: DISPATCH-1117 URL: https://issues.apache.org/jira/browse/DISPATCH-1117 Project: Qpid Dispatch Issue Type: Bug Reporter: Gordon Sim Fix For: 1.4.0 (1) it shows examples using a 'create' operation which is not supported (and not needed) (2) it has '–' in front of attributes which is incorrect (3) it shows specifying the module on update which should not be recommended (see DISPATCH-1116) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #372: DISPATCH-1116: prevent module being updated on log...
Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/372 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=h1) Report > Merging [#372](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/eb766e3ade97b4ee5bca0b21ebe7403a8317d6e9?src=pr&el=desc) will **increase** coverage by `0.07%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/372/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #372 +/- ## == + Coverage 84.79% 84.86% +0.07% == Files 70 70 Lines 1600416003 -1 == + Hits1357013581 +11 + Misses 2434 2422 -12 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=tree) | Coverage Π| | |---|---|---| | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `76.55% <0%> (-0.2%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.86% <0%> (+0.25%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.44% <0%> (+0.45%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.64% <0%> (+0.76%)` | :arrow_up: | | [src/router\_core/core\_timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGltZXIuYw==) | `96.42% <0%> (+1.78%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=footer). Last update [eb766e3...6c34481](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1116) qdmanage lets the module of log instance be changed
[ https://issues.apache.org/jira/browse/DISPATCH-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606298#comment-16606298 ] ASF GitHub Bot commented on DISPATCH-1116: -- GitHub user grs opened a pull request: https://github.com/apache/qpid-dispatch/pull/372 DISPATCH-1116: prevent module being updated on log instances You can merge this pull request into a Git repository by running: $ git pull https://github.com/grs/qpid-dispatch DISPATCH-1116 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/372.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #372 commit 6c34481438d6c268d3e8debd238e8d5131ff7be1 Author: Gordon Sim Date: 2018-09-06T19:12:04Z DISPATCH-1116: prevent module being updated on log instances > qdmanage lets the module of log instance be changed > --- > > Key: DISPATCH-1116 > URL: https://issues.apache.org/jira/browse/DISPATCH-1116 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > > E.g. > {noformat} > $ qdmanage update --type=log --name=log/ROUTER module=SERVER enable=trace+ > { > "enable": "trace+", > "type": "org.apache.qpid.dispatch.log", > "identity": "log/ROUTER", > "module": "SERVER", > "name": "log/AUTHSERVICE" > } > {noformat} > This seems unnecessary and likely to cause problems. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #372: DISPATCH-1116: prevent module being updated...
GitHub user grs opened a pull request: https://github.com/apache/qpid-dispatch/pull/372 DISPATCH-1116: prevent module being updated on log instances You can merge this pull request into a Git repository by running: $ git pull https://github.com/grs/qpid-dispatch DISPATCH-1116 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/372.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #372 commit 6c34481438d6c268d3e8debd238e8d5131ff7be1 Author: Gordon Sim Date: 2018-09-06T19:12:04Z DISPATCH-1116: prevent module being updated on log instances --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1113) Can't update log/AUTHSERVICE
[ https://issues.apache.org/jira/browse/DISPATCH-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606296#comment-16606296 ] ASF subversion and git services commented on DISPATCH-1113: --- Commit eb766e3ade97b4ee5bca0b21ebe7403a8317d6e9 in qpid-dispatch's branch refs/heads/master from Gordon Sim [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=eb766e3 ] DISPATCH-1113: expose AUTHSERVICE log module to management operations > Can't update log/AUTHSERVICE > > > Key: DISPATCH-1113 > URL: https://issues.apache.org/jira/browse/DISPATCH-1113 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.3.0 >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1116) qdmanage lets the module of log instance be changed
Gordon Sim created DISPATCH-1116: Summary: qdmanage lets the module of log instance be changed Key: DISPATCH-1116 URL: https://issues.apache.org/jira/browse/DISPATCH-1116 Project: Qpid Dispatch Issue Type: Bug Reporter: Gordon Sim Assignee: Gordon Sim Fix For: 1.4.0 E.g. {noformat} $ qdmanage update --type=log --name=log/ROUTER module=SERVER enable=trace+ { "enable": "trace+", "type": "org.apache.qpid.dispatch.log", "identity": "log/ROUTER", "module": "SERVER", "name": "log/AUTHSERVICE" } {noformat} This seems unnecessary and likely to cause problems. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1113) Can't update log/AUTHSERVICE
[ https://issues.apache.org/jira/browse/DISPATCH-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated DISPATCH-1113: - Summary: Can't update log/AUTHSERVICE (was: Operation 'CREATE' not implemented for 'org.apache.qpid.dispatch.log' ) > Can't update log/AUTHSERVICE > > > Key: DISPATCH-1113 > URL: https://issues.apache.org/jira/browse/DISPATCH-1113 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.3.0 >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Major > Fix For: 1.4.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-1880) "make install" doesn't install pdbs for proton-core and proton-proactor libs
[ https://issues.apache.org/jira/browse/PROTON-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-1880: --- Component/s: build > "make install" doesn't install pdbs for proton-core and proton-proactor libs > > > Key: PROTON-1880 > URL: https://issues.apache.org/jira/browse/PROTON-1880 > Project: Qpid Proton > Issue Type: Bug > Components: build >Affects Versions: proton-c-0.23.0 > Environment: Windows visual studio compiles >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.25.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-1919) [Python] Remove all use of messenger symbols
[ https://issues.apache.org/jira/browse/PROTON-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-1919: --- Component/s: python-binding > [Python] Remove all use of messenger symbols > > > Key: PROTON-1919 > URL: https://issues.apache.org/jira/browse/PROTON-1919 > Project: Qpid Proton > Issue Type: Improvement > Components: python-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.25.0 > > > The messenger API is no longer supported in the python binding. We need to > remove all remaining uses of messenger defined symbols, so that we can > ultimately link the python bindings to proton-core rather than the full > proton library. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-1798) Installable tests for proton
[ https://issues.apache.org/jira/browse/PROTON-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-1798: --- Fix Version/s: (was: proton-c-0.25.0) proton-c-0.26.0 > Installable tests for proton > > > Key: PROTON-1798 > URL: https://issues.apache.org/jira/browse/PROTON-1798 > Project: Qpid Proton > Issue Type: Test >Affects Versions: proton-c-0.21.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Labels: testing > Fix For: proton-c-0.26.0 > > > Install test scripts so that self-tests can be run on an installed package, > without access to the source tree. These tests will be a separate install > group. > > Initially the tests will consist of automatically building and running > installed examples, in future we can add unit tests etc. to the installed set. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-1873) 0.25.0 release tasks
[ https://issues.apache.org/jira/browse/PROTON-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved PROTON-1873. Resolution: Done > 0.25.0 release tasks > > > Key: PROTON-1873 > URL: https://issues.apache.org/jira/browse/PROTON-1873 > Project: Qpid Proton > Issue Type: Task > Components: proton-c, release >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: proton-c-0.25.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1115) Configure Travis to run Dispatch tests agianst the latest Proton release and Proton master branch
Ganesh Murthy created DISPATCH-1115: --- Summary: Configure Travis to run Dispatch tests agianst the latest Proton release and Proton master branch Key: DISPATCH-1115 URL: https://issues.apache.org/jira/browse/DISPATCH-1115 Project: Qpid Dispatch Issue Type: Improvement Components: Tools Affects Versions: 1.3.0 Reporter: Ganesh Murthy Assignee: Ganesh Murthy Fix For: 1.4.0 Currently, Dispatch tests running on Travis run only against Proton Master. Make these tests also run against the latest released version of Proton. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1898) Memory leak related to sending
[ https://issues.apache.org/jira/browse/PROTON-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605933#comment-16605933 ] Christoph commented on PROTON-1898: --- I just wanted to ask for the current state... And, is there any workaround? > Memory leak related to sending > -- > > Key: PROTON-1898 > URL: https://issues.apache.org/jira/browse/PROTON-1898 > Project: Qpid Proton > Issue Type: Bug > Components: go-binding >Affects Versions: proton-c-0.24.0 >Reporter: Christoph >Assignee: Alan Conway >Priority: Major > > I started implementing a GO application using qpid electron. There is one > connection used to receive messages (at-least-once). It works nicely with low > memory consumption, multiple links and multiple go routines, 50 bytes > payload, up to 3000 msg/s > But as soon as the application starts sending messages (to reply over the > same connection) memory consumption is continuously growing up to 2GB where I > stopped. > Even if electron does not leave many options for wrong usage there might be > an issue in the application. > So I tried the qpid electron example > "https://github.com/apache/qpid-proton/blob/master/go/examples/electron/send.go";, > the same issue. > To reproduce it: > * use the sample program, I just added connection options for SASL PLAIN > * let it send 10 messages or more to one destination > My setup: > * windows 10 pro > * go1.10.2 windows/amd64 > * qpid 0.24.0-rc1 > * go files and lib build from same git repository clone and branch > * visual studio 2015, release build, no errors > * Broker: Solace VMR 8.11.0.1029 with different durable queues as source and > target > I tried also qpid proton 0.23.0 earlier, but saw the same problem. > I tried SendAsync and SendSync, both in 10-50 go routines in > parallel.Finally, with SendForget my worker routines were soon blocked and > did not come back. > Best regards > Christoph > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8236) [Broker-J] [BDB HA] Changing of group name, address or node name in BDB HA virtual host node should be disallowed
[ https://issues.apache.org/jira/browse/QPID-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8236: - Summary: [Broker-J] [BDB HA] Changing of group name, address or node name in BDB HA virtual host node should be disallowed (was: [Broker-J] Changing of group name, address or node name in BDB HA virtual host node should be disallowed ) > [Broker-J] [BDB HA] Changing of group name, address or node name in BDB HA > virtual host node should be disallowed > -- > > Key: QPID-8236 > URL: https://issues.apache.org/jira/browse/QPID-8236 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-6.1.6, 0.32, qpid-java-6.0.8, > qpid-java-broker-7.0.6 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-6.1.7, qpid-java-broker-7.1.0, > qpid-java-broker-7.0.7 > > > The BDB HA Virtual Host Node group name, address or node name can be changed > using management interfaces, for example REST API. However, the change of > this attributes is not reflected in the underlying BDB JE infrastructure. In > fact, the change of group name, address or node name is unsupported by BDB > JE. The only way any of them can be changed is by resetting the group > information using BDB JE utility {{DbResetRepGroup}} which resets the group > to a single node. > The Qpid Broker should not allow to change group name, address or node name > attributes in BDB HA Virtual Host node via management API. > If group is changed, on next broker restart the impacted {{VHN}} fails to > start with the following error logged into broker logs: > {noformat} > ERROR [qtp699327636-161] (o.a.q.s.m.p.f.ExceptionHandlingFilter) - Unexpected > exception in servlet '/api/latest/virtualhostnode/node1': > java.lang.RuntimeException: Unexpected exception on environment creation > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.createEnvironmentInSeparateThread(ReplicatedEnvironmentFacade.java:1578) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.createEnvironment(ReplicatedEnvironmentFacade.java:1526) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacade.(ReplicatedEnvironmentFacade.java:288) > at > org.apache.qpid.server.store.berkeleydb.replication.ReplicatedEnvironmentFacadeFactory.createEnvironmentFacade(ReplicatedEnvironmentFacadeFactory.java:130) > at > org.apache.qpid.server.store.berkeleydb.BDBConfigurationStore.init(BDBConfigurationStore.java:120) > at > org.apache.qpid.server.virtualhostnode.berkeleydb.BDBHAVirtualHostNodeImpl.activate(BDBHAVirtualHostNodeImpl.java:338) > at > org.apache.qpid.server.virtualhostnode.AbstractVirtualHostNode.doActivate(AbstractVirtualHostNode.java:169) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1526) > at > org.apache.qpid.server.model.AbstractConfiguredObject.attainState(AbstractConfiguredObject.java:1505) > at > org.apache.qpid.server.model.AbstractConfiguredObject.attainStateIfOpenedOrReopenFailed(AbstractConfiguredObject.java:1489) > at > org.apache.qpid.server.model.AbstractConfiguredObject.access$1700(AbstractConfiguredObject.java:97) > at > org.apache.qpid.server.model.AbstractConfiguredObject$15.execute(AbstractConfiguredObject.java:1716) > at > org.apache.qpid.server.model.AbstractConfiguredObject$15.execute(AbstractConfiguredObject.java:1678) > at > org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:639) > at > org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:632) > at > org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:248) > at > org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper$1.run(TaskExecutorImpl.java:320) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:360) > at > org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper.call(TaskExecutorImpl.java:313) > at > com.google.common.util.concurrent.
[jira] [Updated] (QPID-8217) [Broker-J] Evaluation of maximum message size can result in unexpected value
[ https://issues.apache.org/jira/browse/QPID-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8217: - Fix Version/s: (was: qpid-java-broker-7.0.7) (was: qpid-java-broker-7.1.0) > [Broker-J] Evaluation of maximum message size can result in unexpected value > > > Key: QPID-8217 > URL: https://issues.apache.org/jira/browse/QPID-8217 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.0.2, > qpid-java-broker-7.0.0, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4, > qpid-java-broker-7.0.5, qpid-java-broker-7.0.6 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Trivial > > The maximum message size is evaluated as a minimum among context variable > values for maximum message size on {{Port}} and {{Broker}} . Thus, when > {{Broker}} maximum message size have value of {{10K}} and Port maximum > message size have value of {{100M}}, the maximum message size would be > {{10K}}. According to the rules for evaluation of context variables the > {{Port}} context variable value should override the {{Broker}} one. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8234) [Broker-J] Return amqp error "amqp:connection:forced" on opening connections to non-existing or not-active virtual hosts
[ https://issues.apache.org/jira/browse/QPID-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8234: - Fix Version/s: (was: qpid-java-broker-7.0.7) > [Broker-J] Return amqp error "amqp:connection:forced" on opening connections > to non-existing or not-active virtual hosts > > > Key: QPID-8234 > URL: https://issues.apache.org/jira/browse/QPID-8234 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.0.2, > qpid-java-broker-7.0.0, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4, > qpid-java-broker-7.0.5, qpid-java-broker-7.0.6 >Reporter: Alex Rudyy >Priority: Major > > On attempt to open connection to non-existing or not available virtual host, > it would be better to use {{amqp:connection:forced}} error conditions rather > than {{amqp:not-found}} > As per spec {{amqp:connection:forced}} is defined as {quote} An operator > intervened to close the connection for some reason. The client could retry at > some later date.{quote}. It allows retrying whilst {{amqp:not-found}} can be > interpreted on the client to stop reconnecting. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8239) [Broker-J] Release Qpid Broker-J 7.0.7
Alex Rudyy created QPID-8239: Summary: [Broker-J] Release Qpid Broker-J 7.0.7 Key: QPID-8239 URL: https://issues.apache.org/jira/browse/QPID-8239 Project: Qpid Issue Type: Task Components: Broker-J Reporter: Alex Rudyy Fix For: qpid-java-broker-7.0.7 Release Qpid Broker-J following instructions provided at [https://cwiki.apache.org/confluence/display/qpid/Releasing+Qpid+Broker-J] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8151) [Broker-J] Refresh mechanism that underpins unit tests
[ https://issues.apache.org/jira/browse/QPID-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-8151. -- Resolution: Fixed Closing old JIRA as the required work has been committed and reviewed long time ago. > [Broker-J] Refresh mechanism that underpins unit tests > -- > > Key: QPID-8151 > URL: https://issues.apache.org/jira/browse/QPID-8151 > Project: Qpid > Issue Type: Improvement > Components: Broker-J, Java Tests >Reporter: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > {{QpidTestCase}} was a home grown mechanism that was built around older > versions of Junit. The test exclusion mechanism is tricky with a number of > gotchas the harm developer productivity. > The test suite will be refactored to use more modern Junit facilities that > are already in use in the newer test-suites (protocol test suites etc). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8151) [Broker-J] Refresh mechanism that underpins unit tests
[ https://issues.apache.org/jira/browse/QPID-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8151: - Fix Version/s: qpid-java-broker-7.1.0 > [Broker-J] Refresh mechanism that underpins unit tests > -- > > Key: QPID-8151 > URL: https://issues.apache.org/jira/browse/QPID-8151 > Project: Qpid > Issue Type: Improvement > Components: Broker-J, Java Tests >Reporter: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > {{QpidTestCase}} was a home grown mechanism that was built around older > versions of Junit. The test exclusion mechanism is tricky with a number of > gotchas the harm developer productivity. > The test suite will be refactored to use more modern Junit facilities that > are already in use in the newer test-suites (protocol test suites etc). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8168) [Broker-J] Broker should flow to disk transient messages when heap usage reaches critical threshold in order to avoid running of heap memory due to consumption of heap by
[ https://issues.apache.org/jira/browse/QPID-8168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8168: - Fix Version/s: qpid-java-broker-7.1.0 > [Broker-J] Broker should flow to disk transient messages when heap usage > reaches critical threshold in order to avoid running of heap memory due to > consumption of heap by transient message metadata > - > > Key: QPID-8168 > URL: https://issues.apache.org/jira/browse/QPID-8168 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3, > qpid-java-broker-7.0.2, qpid-java-6.0.8, qpid-java-broker-7.0.0, > qpid-java-broker-7.0.1, qpid-java-broker-7.1.0 >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > The flow to disk is currently triggered when direct memory usage reaches > predefined threshold ({{broker.flowToDiskThreshold}} which is set to 75% of > direct memory size by default). However, in some situations (for example, > when direct memory size is big and heap memory size is small), the direct > memory threshold is not reached but the heap is fully occupied by transient > messages data, the broker runs out of heap memory. > The broker behaviour can be improved by triggering flow to disk when a heap > occupancy reaches the critical threshold in addition to direct memory usage > threshold. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8193) [Broker-J] Updating maximum / minimum TTL on a queue does not affect messages already in the queue (until restart)
[ https://issues.apache.org/jira/browse/QPID-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8193: - Fix Version/s: qpid-java-broker-7.1.0 > [Broker-J] Updating maximum / minimum TTL on a queue does not affect messages > already in the queue (until restart) > -- > > Key: QPID-8193 > URL: https://issues.apache.org/jira/browse/QPID-8193 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Rob Godfrey >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > Updating the maximum / minimum TTL on a queue does not change the calculated > expiration on queue entries (updateExpiration is only called from doEnqueue). > Expiration should be recalculated after minimum/maximum ttl is modified. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8214) Reduce the table names size in the JDBC configuration store to fit Oracle's 30 characters limitation
[ https://issues.apache.org/jira/browse/QPID-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605550#comment-16605550 ] ASF GitHub Bot commented on QPID-8214: -- Github user alex-rufous commented on the issue: https://github.com/apache/qpid-broker-j/pull/10 The PR was merged into master under revision [fbeb2084635c5b15bfeed25674513e2783457ccf](https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=fbeb208). I had forgotten to change commit message to close this PR from commit > Reduce the table names size in the JDBC configuration store to fit Oracle's > 30 characters limitation > > > Key: QPID-8214 > URL: https://issues.apache.org/jira/browse/QPID-8214 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.4 >Reporter: Olivier VERMEULEN >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > Attachments: > 0001-QPID-8214-Broker-J-JDBC-Reduce-the-sizes-of-table-na.patch > > > 'QPID_CONFIGURED_OBJECT_HIERARCHY' is already 32 characters long. > And we should also take into account that users can specify a table name > prefix. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-broker-j issue #10: QPID-8214: Reduce the sizes of table names in the J...
Github user alex-rufous commented on the issue: https://github.com/apache/qpid-broker-j/pull/10 The PR was merged into master under revision [fbeb2084635c5b15bfeed25674513e2783457ccf](https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=fbeb208). I had forgotten to change commit message to close this PR from commit --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8214) Reduce the table names size in the JDBC configuration store to fit Oracle's 30 characters limitation
[ https://issues.apache.org/jira/browse/QPID-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8214: - Fix Version/s: qpid-java-broker-7.1.0 > Reduce the table names size in the JDBC configuration store to fit Oracle's > 30 characters limitation > > > Key: QPID-8214 > URL: https://issues.apache.org/jira/browse/QPID-8214 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.4 >Reporter: Olivier VERMEULEN >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > Attachments: > 0001-QPID-8214-Broker-J-JDBC-Reduce-the-sizes-of-table-na.patch > > > 'QPID_CONFIGURED_OBJECT_HIERARCHY' is already 32 characters long. > And we should also take into account that users can specify a table name > prefix. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8196) [Broker-J] [WMC] Edit form controls are not populated with current values
[ https://issues.apache.org/jira/browse/QPID-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8196: - Fix Version/s: qpid-java-broker-7.1.0 > [Broker-J] [WMC] Edit form controls are not populated with current values > - > > Key: QPID-8196 > URL: https://issues.apache.org/jira/browse/QPID-8196 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.1.0, qpid-java-broker-7.0.4 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > Attachments: > 0001-QPID-8196-Broker-J-WMC-Make-sure-that-edit-form-cont.patch > > > The form for editing BDB HA VHN does not populate reliably the UI controls > with current attribute values. Some of the attribute controls can be left > unset. As result, on submitting the form, null/empty values can be sent as > part of update request to the broker. > User impact: > Editing of attributes cannot be done reliably from WVM, as when the issue > occurs, the update requests from WMC fail due to broker side validation. > There is a possibility of unexpected change of attribute value to null. > Work around: REST API can be used to change the attribute values. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8196) [Broker-J] [WMC] Edit form controls are not populated with current values
[ https://issues.apache.org/jira/browse/QPID-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8196: - Description: The form for editing BDB HA VHN does not populate reliably the UI controls with current attribute values. Some of the attribute controls can be left unset. As result, on submitting the form, null/empty values can be sent as part of update request to the broker. User impact: Editing of attributes cannot be done reliably from WVM, as when the issue occurs, the update requests from WMC fail due to broker side validation. There is a possibility of unexpected change of attribute value to null. Work around: REST API can be used to change the attribute values. was: The form for editing BDB HA VHN does not populate reliably the UI controls with current attribute values. Some of the attribute controls can be left unset. As result, on submitting the form, null/empty values can be sent as part of update request to the broker. User impact: Editing of attributes cannot be done reliably from WVM, as when the issue occurs, the update requests from VMC fail due to broker side validation. There is a possibility of unexpected change of attribute value to null. Work around: REST API can be used to change the attribute values. > [Broker-J] [WMC] Edit form controls are not populated with current values > - > > Key: QPID-8196 > URL: https://issues.apache.org/jira/browse/QPID-8196 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.1.0, qpid-java-broker-7.0.4 >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > Attachments: > 0001-QPID-8196-Broker-J-WMC-Make-sure-that-edit-form-cont.patch > > > The form for editing BDB HA VHN does not populate reliably the UI controls > with current attribute values. Some of the attribute controls can be left > unset. As result, on submitting the form, null/empty values can be sent as > part of update request to the broker. > User impact: > Editing of attributes cannot be done reliably from WVM, as when the issue > occurs, the update requests from WMC fail due to broker side validation. > There is a possibility of unexpected change of attribute value to null. > Work around: REST API can be used to change the attribute values. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8201) [Broker-J] [AMQP1.0] Queue backing temporary subscription deleted twice during link close
[ https://issues.apache.org/jira/browse/QPID-8201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8201: - Fix Version/s: qpid-java-broker-7.0.7 qpid-java-broker-7.1.0 > [Broker-J] [AMQP1.0] Queue backing temporary subscription deleted twice > during link close > - > > Key: QPID-8201 > URL: https://issues.apache.org/jira/browse/QPID-8201 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.4 >Reporter: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7 > > > Running the following code using the Qpid JMS Client (I am using master) that > creates a temporary topic subscription and then immediately closes the > consumer, exposes a defect in the Broker-J. Internally Broker-J is cleaning > up the queue backing the temporary subscription twice. The second attempt > fails, which causes the detach performative to carry a spurious {{error > amqp:not-found.}} > The Qpid JMS Client appears to ignore the error, so there may not be an > impact to applications using this client. I have not checked other AMQP 1.0 > clients. > > {code:java} > Context context = new InitialContext(); > ConnectionFactory factory = (ConnectionFactory) > context.lookup("myFactoryLookup"); > Destination topic = (Destination) context.lookup("myTopicLookup"); > Connection connection = factory.createConnection(System.getProperty("USER"), > System.getProperty("PASSWORD")); > Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE); > MessageConsumer messageConsumer = session.createConsumer(topic); > messageConsumer.close();{code} > > {noformat} > [154612396:0] -> Open{ > containerId='ID:29fbab21-96a9-45a9-ba6d-05b1744b9ce3:1', > hostname='localhost', maxFrameSize=1048576, channelMax=32767, > idleTimeOut=3, outgoingLocales=null, incomingLocales=null, > offeredCapabilities=null, desiredCapabilities=[sole-connection-for-container, > DELAYED_DELIVERY, ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, > version=0.33.0-SNAPSHOT, platform=JVM: 1.8.0_171, 25.171-b10, Oracle > Corporation, OS: Linux, 4.16.8-300.fc28.x86_64, amd64}} > [154612396:0] <- Open{ containerId='a73d8803-f5bd-46c8-90d3-b3ae6754e681', > hostname='null', maxFrameSize=262144, channelMax=255, idleTimeOut=0, > outgoingLocales=null, incomingLocales=null, > offeredCapabilities=[ANONYMOUS-RELAY, SHARED-SUBS, > sole-connection-for-container], desiredCapabilities=null, > properties={product=qpid, version=7.1.0-SNAPSHOT, qpid.build=, > qpid.instance_name=Broker, qpid.virtualhost_properties_supported=true, > sole-connection-detection-policy=0}} > [154612396:0] -> Begin{remoteChannel=null, nextOutgoingId=1, > incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, > offeredCapabilities=null, desiredCapabilities=null, properties=null} > [154612396:0] <- Begin{remoteChannel=0, nextOutgoingId=0, > incomingWindow=8192, outgoingWindow=2048, handleMax=4294967295, > offeredCapabilities=null, desiredCapabilities=null, properties=null} > [154612396:1] -> Begin{remoteChannel=null, nextOutgoingId=1, > incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, > offeredCapabilities=null, desiredCapabilities=null, properties=null} > [154612396:1] <- Begin{remoteChannel=1, nextOutgoingId=0, > incomingWindow=8192, outgoingWindow=2048, handleMax=4294967295, > offeredCapabilities=null, desiredCapabilities=null, properties=null} > [154612396:1] -> > Attach{name='qpid-jms:receiver:ID:1537beab-fd64-4d97-ae27-3b888ee072a6:1:1:1:foo', > handle=0, role=RECEIVER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, > source=Source{address='foo', durable=NONE, expiryPolicy=LINK_DETACH, > timeout=0, dynamic=false, dynamicNodeProperties=null, distributionMode=null, > filter=null, defaultOutcome=Modified{deliveryFailed=true, > undeliverableHere=null, messageAnnotations=null}, > outcomes=[amqp:accepted:list, amqp:rejected:list, amqp:released:list, > amqp:modified:list], capabilities=[topic]}, target=Target{address='null', > durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, > dynamicNodeProperties=null, capabilities=null}, unsettled=null, > incompleteUnsettled=false, initialDeliveryCount=null, maxMessageSize=null, > offeredCapabilities=null, desiredCapabilities=null, properties=null} > [154612396:1] <- > Attach{name='qpid-jms:receiver:ID:1537beab-fd64-4d97-ae27-3b888ee072a6:1:1:1:foo', > handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, > source=Source{address='foo', durable=NONE, expiryPolicy=LINK_DETACH, > timeout=0, dynamic=false, dynamicNodeProperties=null, distributionMode=copy, > filter=null, defaultOutcome=Modified{deliv
[jira] [Updated] (QPID-8231) [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from queue having attribute 'messageGroupKeyOverride' set to an empty string
[ https://issues.apache.org/jira/browse/QPID-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8231: - Fix Version/s: qpid-java-broker-7.0.7 qpid-java-broker-7.1.0 > [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from > queue having attribute 'messageGroupKeyOverride' set to an empty string > - > > Key: QPID-8231 > URL: https://issues.apache.org/jira/browse/QPID-8231 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-6.1.6, 0.32, qpid-java-6.0.8, > qpid-java-broker-7.0.6 >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7 > > > Broker crashes on consumption of messages from queue having attribute > 'messageGroupKeyOverride' set to an empty string. The following stack trace > is generated: > {noformat} > > # > # Unhandled Exception java.lang.IllegalArgumentException: Property name must > not be the empty string in Thread IO-/127.0.0.1:63421 > # > # Exiting > # > > java.lang.IllegalArgumentException: Property name must not be the empty string > at > org.apache.qpid.server.protocol.v0_8.FieldTable.checkPropertyName(FieldTable.java:787) > at > org.apache.qpid.server.protocol.v0_8.FieldTable.getProperty(FieldTable.java:98) > at > org.apache.qpid.server.protocol.v0_8.FieldTable.getObject(FieldTable.java:428) > at > org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1055) > at > org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1050) > at > org.apache.qpid.server.protocol.v0_8.MessageMetaData$MessageHeaderAdapter.getHeader(MessageMetaData.java:283) > at > org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.getGroupValue(AssignedConsumerMessageGroupManager.java:83) > at > org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.mightAssign(AssignedConsumerMessageGroupManager.java:61) > at > org.apache.qpid.server.queue.AbstractQueue.mightAssign(AbstractQueue.java:1335) > at > org.apache.qpid.server.queue.AbstractQueue.getNextAvailableEntry(AbstractQueue.java:2087) > at > org.apache.qpid.server.queue.AbstractQueue.consumerHasAvailableMessages(AbstractQueue.java:2234) > at > org.apache.qpid.server.queue.AbstractQueue.notifyConsumer(AbstractQueue.java:2268) > at > org.apache.qpid.server.queue.AbstractQueue.setNotifyWorkDesired(AbstractQueue.java:2245) > at > org.apache.qpid.server.queue.QueueConsumerImpl.setNotifyWorkDesired(QueueConsumerImpl.java:356) > at > org.apache.qpid.server.consumer.AbstractConsumerTarget.setNotifyWorkDesired(AbstractConsumerTarget.java:130) > at > org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.updateNotifyWorkDesired(ConsumerTarget_0_8.java:320) > at > org.apache.qpid.server.protocol.v0_8.AMQChannel.updateAllConsumerNotifyWorkDesired(AMQChannel.java:1495) > at > org.apache.qpid.server.protocol.v0_8.AMQChannel.receiveChannelFlow(AMQChannel.java:2319) > at > org.apache.qpid.server.protocol.v0_8.transport.ChannelFlowBody.process(ChannelFlowBody.java:98) > at > org.apache.qpid.server.protocol.v0_8.ServerDecoder.processMethod(ServerDecoder.java:126) > at > org.apache.qpid.server.protocol.v0_8.AMQDecoder.processFrame(AMQDecoder.java:203) > at > org.apache.qpid.server.protocol.v0_8.BrokerDecoder.doProcessFrame(BrokerDecoder.java:141) > at > org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processFrame(BrokerDecoder.java:65) > at > org.apache.qpid.server.protocol.v0_8.AMQDecoder.processInput(AMQDecoder.java:185) > at > org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:104) > at > org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:97) > at java.security.AccessController.doPrivileged(Native Method) > at > org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processAMQPFrames(BrokerDecoder.java:96) > at > org.apache.qpid.server.protocol.v0_8.AMQDecoder.decode(AMQDecoder.java:118) > at > org.apache.qpid.server.protocol.v0_8.ServerDecoder.decodeBuffer(ServerDecoder.java:44) > at > org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$1.run(AMQPConnection_0_8Impl.java:257) > at > org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$1.run(AMQPConnection_0_8Impl.java:249) > at java.security.AccessController.doPrivileged(Native Method) > at > org.apache.
[jira] [Updated] (QPID-8230) [Broker-J] Virtual Host children can be partially recovered and left in memory on failed Virtual Host startup
[ https://issues.apache.org/jira/browse/QPID-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8230: - Fix Version/s: qpid-java-broker-7.1.0 > [Broker-J] Virtual Host children can be partially recovered and left in > memory on failed Virtual Host startup > - > > Key: QPID-8230 > URL: https://issues.apache.org/jira/browse/QPID-8230 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.6 >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > > When startup of stopped Virtual Host fails (for example, due to defect > QPID-8229) some of its children could be recovered and stored in virtual host > internal data structures. The subsequent virtual host restarts can fail with > another error "409 - Child of type already exists with id of ". This > error masks the original error causing virtual host failure in first place. > No error is reported into the broker logs. If original error causing first > virtual host startup failure can be fixed, the VHN restart or Broker restart > can resolve "409 - Child of type already exists with id of " -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8233) [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet active should use connection-forced error
[ https://issues.apache.org/jira/browse/QPID-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8233: - Fix Version/s: qpid-java-broker-7.1.0 > [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet > active should use connection-forced error > --- > > Key: QPID-8233 > URL: https://issues.apache.org/jira/browse/QPID-8233 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.0.2, > qpid-java-broker-7.0.0, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4, > qpid-java-broker-7.0.5, qpid-java-broker-7.0.6 >Reporter: Rob Godfrey >Priority: Major > Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7 > > Attachments: QPID-8233.diff, apache-qpid-broker-j-7.0.3-bin.zip > > > Currently if a connection is made to a broker where a virtual host is in the > process of activating, the client received a "not-found" error with a > description "virtual host is not active". A client receiving this would not > expect that simply retrying is likely to lead to success. > Instead of sending "not-found" the broker should send "connection-forced" > which, while still inaccurate, at least indicates that the client should retry -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8232) [Broker-J] Disabling logging using log level OFF is not respected by the logging framework
[ https://issues.apache.org/jira/browse/QPID-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8232: - Fix Version/s: qpid-java-broker-7.1.0 > [Broker-J] Disabling logging using log level OFF is not respected by the > logging framework > --- > > Key: QPID-8232 > URL: https://issues.apache.org/jira/browse/QPID-8232 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.6 >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7 > > > When two logging rules created where one rule allows logging for the given > hierarchy and another rule disables specific logging for the logger from the > hierarchy declared in the first rule, the rule disabling the logging should > take precedence. > For example, when the one rule allows 'info' logging for loggers matching > "qpid.message.*" and another rule is added to turn off logging of log event > from logger "qpid.message.exchange.discardmsg", the logs from logger > "qpid.message.exchange.discardmsg" should not be appended. The current > implementation allows logging from disabled loggers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8238) [Broker-J] Improve performance of asynchronous publishing of transient messages into topic exchange having queues bound using non-overlapping selectors
[ https://issues.apache.org/jira/browse/QPID-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8238: - Fix Version/s: qpid-java-broker-7.0.7 > [Broker-J] Improve performance of asynchronous publishing of transient > messages into topic exchange having queues bound using non-overlapping > selectors > > > Key: QPID-8238 > URL: https://issues.apache.org/jira/browse/QPID-8238 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.6 >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7 > > Attachments: > 0001-QPID-8238-Use-java.lang.String-for-keys-and-values-i.patch > > > The performance of asynchronous publishing of transient messages into topic > exchange which routes messages into queues bound using non-overlapping > selectors is 2-3 times slower than performance of 0.32 broker. The > performance degradation is observed with AMQP 0.9, though, I suspect that the > AMQP 0-10 protocol could be affected as well. > I was running tests with 10 concurrent producers publishing messages on > separate connections using the same routing key into 10 different queues > (subscribers queues) bound to the exchange using non-overlapping selectors. > My testing showed that performance of 7.0 broker for this particular use case > was 2-3 times worse than performance of 0.32 broker. > The following factors contributed to degradation of performance: > • Copying data from direct memory into heap memory whilst decoding > message headers. Due to this factor, the decoding of message headers is > around twice slower. It seems it contributes around 70% to total performance > degradation > • The message routing algorithm is slower due to need to support a new > feature to route messages into bound exchanges (in addition to queues) using > replacement routing key. > • AMQ short strings caching contributes 5-10% to total performance > degradation. The caching was added to manage heap space more efficiently. > The numbers provided here could be inaccurate due instrumentation overhead > whilst profiling the issue. > Potentially, caching can be turned off but that will not improve performance > much. > On other hand, adding of additional caching of strings to amqp-short-strings > would improve the performance a bit. Whilst evaluating selectors, the fields > used in selector expressions are represented as java strings but they get > converted every time into amqp-short-strings when looking up for message > header values. If 10 queues are bound to the exchange using the same binding > key, the selector expression is evaluated 10 times for the incoming message. > Thus, all selector field names are get converted into amqp-short-strings 10 > times as well. It seems adding caching here can improve the performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8232) [Broker-J] Disabling logging using log level OFF is not respected by the logging framework
[ https://issues.apache.org/jira/browse/QPID-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8232: - Fix Version/s: qpid-java-broker-7.0.7 > [Broker-J] Disabling logging using log level OFF is not respected by the > logging framework > --- > > Key: QPID-8232 > URL: https://issues.apache.org/jira/browse/QPID-8232 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.6 >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.0.7 > > > When two logging rules created where one rule allows logging for the given > hierarchy and another rule disables specific logging for the logger from the > hierarchy declared in the first rule, the rule disabling the logging should > take precedence. > For example, when the one rule allows 'info' logging for loggers matching > "qpid.message.*" and another rule is added to turn off logging of log event > from logger "qpid.message.exchange.discardmsg", the logs from logger > "qpid.message.exchange.discardmsg" should not be appended. The current > implementation allows logging from disabled loggers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org