[GitHub] qpid-proton issue #160: WIP: option version of connection_options getters
Github user codecov-io commented on the issue: https://github.com/apache/qpid-proton/pull/160 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/160?src=pr=h1) Report > Merging [#160](https://codecov.io/gh/apache/qpid-proton/pull/160?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/ae96bced86c7e6c62655ee9b607ff57eabb056f1?src=pr=desc) will **decrease** coverage by `0.1%`. > The diff coverage is `57.44%`. [](https://codecov.io/gh/apache/qpid-proton/pull/160?src=pr=tree) ```diff @@Coverage Diff @@ ## master #160 +/- ## == - Coverage 86.53% 86.43% -0.11% == Files 252 253 +1 Lines 3077530817 +42 == + Hits2663226636 +4 - Misses 4143 4181 +38 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/160?src=pr=tree) | Coverage Π| | |---|---|---| | [cpp/include/proton/delivery\_mode.hpp](https://codecov.io/gh/apache/qpid-proton/pull/160/diff?src=pr=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2RlbGl2ZXJ5X21vZGUuaHBw) | `50% <ø> (ø)` | :arrow_up: | | [cpp/src/session\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/160/diff?src=pr=tree#diff-Y3BwL3NyYy9zZXNzaW9uX29wdGlvbnMuY3Bw) | `0% <0%> (ø)` | :arrow_up: | | [cpp/src/reconnect\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/160/diff?src=pr=tree#diff-Y3BwL3NyYy9yZWNvbm5lY3Rfb3B0aW9ucy5jcHA=) | `47.05% <0%> (-19.61%)` | :arrow_down: | | [cpp/src/session.cpp](https://codecov.io/gh/apache/qpid-proton/pull/160/diff?src=pr=tree#diff-Y3BwL3NyYy9zZXNzaW9uLmNwcA==) | `36.66% <100%> (+2.18%)` | :arrow_up: | | [cpp/src/proactor\_container\_impl.cpp](https://codecov.io/gh/apache/qpid-proton/pull/160/diff?src=pr=tree#diff-Y3BwL3NyYy9wcm9hY3Rvcl9jb250YWluZXJfaW1wbC5jcHA=) | `86.12% <100%> (ø)` | :arrow_up: | | [cpp/src/connection\_driver.cpp](https://codecov.io/gh/apache/qpid-proton/pull/160/diff?src=pr=tree#diff-Y3BwL3NyYy9jb25uZWN0aW9uX2RyaXZlci5jcHA=) | `84.84% <100%> (ø)` | :arrow_up: | | [cpp/src/node\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/160/diff?src=pr=tree#diff-Y3BwL3NyYy9ub2RlX29wdGlvbnMuY3Bw) | `61.11% <45.16%> (-9.02%)` | :arrow_down: | | [cpp/src/connection\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/160/diff?src=pr=tree#diff-Y3BwL3NyYy9jb25uZWN0aW9uX29wdGlvbnMuY3Bw) | `70.94% <54.71%> (-11.92%)` | :arrow_down: | | [cpp/src/receiver\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/160/diff?src=pr=tree#diff-Y3BwL3NyYy9yZWNlaXZlcl9vcHRpb25zLmNwcA==) | `70.68% <66.66%> (-10.02%)` | :arrow_down: | | [cpp/src/sender\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/160/diff?src=pr=tree#diff-Y3BwL3NyYy9zZW5kZXJfb3B0aW9ucy5jcHA=) | `64% <66.66%> (-2%)` | :arrow_down: | | ... and [4 more](https://codecov.io/gh/apache/qpid-proton/pull/160/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/160?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/160?src=pr=footer). Last update [ae96bce...73af00f](https://codecov.io/gh/apache/qpid-proton/pull/160?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #160: WIP: option version of connection_options getters
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/160 Here's the final version, I'll hold off till after release to take a bit of time to consider API impact. @astitcher @ssorj --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1134) Console tests should be skipped (instead of failing) if console is not installed
Ernest Allen created DISPATCH-1134: -- Summary: Console tests should be skipped (instead of failing) if console is not installed Key: DISPATCH-1134 URL: https://issues.apache.org/jira/browse/DISPATCH-1134 Project: Qpid Dispatch Issue Type: Bug Components: Tests Affects Versions: 1.3.0 Reporter: Ernest Allen Assignee: Ernest Allen If you don't build the console during a router build, then when you run the system tests the console should not be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPIDJMS-411) Improve output of the frame tracing loggers to include the binary payload
[ https://issues.apache.org/jira/browse/QPIDJMS-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPIDJMS-411: --- Summary: Improve output of the frame tracing loggers to include the binary payload (was: Improve out of the the frame tracing loggers to include the binary payload) > Improve output of the frame tracing loggers to include the binary payload > - > > Key: QPIDJMS-411 > URL: https://issues.apache.org/jira/browse/QPIDJMS-411 > Project: Qpid JMS > Issue Type: Improvement > Components: qpid-jms-client >Affects Versions: 0.36.0 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Minor > Fix For: 0.37.0 > > > When the 'amqp.traceFrames' option is enabled the tracing only includes the > TransportFrame content and not the optional payload data. Improve this > logging to include a string formatted representation of the payload data. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8245) [Broker-J] [AMQP 0-8..0-91] Decode FiledTable fields on demand
[
https://issues.apache.org/jira/browse/QPID-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632089#comment-16632089
]
Alex Rudyy commented on QPID-8245:
--
[~rgodfrey], I attached patch
{{0007-QPID-8245-Change-decoding-to-decode-only-value-for-t.patch}}
implementing the idea described in your comment above. Could you please have a
look in the patch?
In my patch I re-used existing field {{_properties}} to cache lazily decoded
properties . Your comments and the pseudo-code examples made me thinking that
you considered elimination of existing field {{_properties}} from the field
table. Thus, FiledTable would only have QBB and same caching map. Is it what
you intended to do?
> [Broker-J] [AMQP 0-8..0-91] Decode FiledTable fields on demand
> --
>
> Key: QPID-8245
> URL: https://issues.apache.org/jira/browse/QPID-8245
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.1.0
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0
>
> Attachments:
> 0001-QPID-8245-Broker-J-Stop-rellocating-message-headers-.patch,
> 0002-QPID-8245-Add-factory-methods-to-create-field-table-.patch,
> 0003-QPID-8245-Remove-FiledTable-setters-methods-modifyin.patch,
> 0004-QPID-8245-Decode-field-table-properties-when-require.patch,
> 0005-QPID-8245-Remove-methods-getXXX-in-order-to-simplify.patch,
> 0005-QPID-8245-Split-field-table-into-2-implementations.patch,
> 0006-QPID-8245-some-code-clean-up.patch,
> 0007-QPID-8245-Change-decoding-to-decode-only-value-for-t.patch
>
>
> At the moment all field table properties are decoded when decode
> functionality is invoked. For use cases when only some of the field table
> properties are queried, the decoding functionality can be changed to stop
> decoding on getting the requested property. Potentially, such approach can
> improve the performance of routing transient messages when destinations are
> bound to the routing exchange using selector filters. As filter expression
> contains only some properties, the decoding of message headers can be stopped
> on getting all fields specified in selector expression.
> The idea is illustrated by Rob Godfrey on
> [QPID-8238|https://issues.apache.org/jira/browse/QPID-8238?focusedCommentId=16601936=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16601936]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #160: WIP: option version of connection_options getters
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/160 > Perhaps we could have a C++11 only explicit bool conversion as well as is_set(). However we would need to experiment a bit as some of the options themselves are also bools so this might be confusing! I left it off because of the confusion. I could probably be persuaded but I'm not sure of the value - I think if (opt.is_set()) use(opt.get()) is clearer and not really harder to use than if (opt) use(opt.get()) > Another thing we should consider is throwing an exception if get() is called when the option is not set. No objection, I'll make it so. Technically it is a logic_error. Do you think we should add proton::logic_error, or fudge it and just throw proton::error? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8245) [Broker-J] [AMQP 0-8..0-91] Decode FiledTable fields on demand
[ https://issues.apache.org/jira/browse/QPID-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8245: - Attachment: 0007-QPID-8245-Change-decoding-to-decode-only-value-for-t.patch 0006-QPID-8245-some-code-clean-up.patch > [Broker-J] [AMQP 0-8..0-91] Decode FiledTable fields on demand > -- > > Key: QPID-8245 > URL: https://issues.apache.org/jira/browse/QPID-8245 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-7.1.0 >Reporter: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > Attachments: > 0001-QPID-8245-Broker-J-Stop-rellocating-message-headers-.patch, > 0002-QPID-8245-Add-factory-methods-to-create-field-table-.patch, > 0003-QPID-8245-Remove-FiledTable-setters-methods-modifyin.patch, > 0004-QPID-8245-Decode-field-table-properties-when-require.patch, > 0005-QPID-8245-Remove-methods-getXXX-in-order-to-simplify.patch, > 0005-QPID-8245-Split-field-table-into-2-implementations.patch, > 0006-QPID-8245-some-code-clean-up.patch, > 0007-QPID-8245-Change-decoding-to-decode-only-value-for-t.patch > > > At the moment all field table properties are decoded when decode > functionality is invoked. For use cases when only some of the field table > properties are queried, the decoding functionality can be changed to stop > decoding on getting the requested property. Potentially, such approach can > improve the performance of routing transient messages when destinations are > bound to the routing exchange using selector filters. As filter expression > contains only some properties, the decoding of message headers can be stopped > on getting all fields specified in selector expression. > The idea is illustrated by Rob Godfrey on > [QPID-8238|https://issues.apache.org/jira/browse/QPID-8238?focusedCommentId=16601936=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16601936] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #160: WIP: option version of connection_options getters
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/160 I definitely like making option a class in common rather than duplicating it. I think that this is the correct way to expose options in the API, but perhaps we could make the API a bit more easy to use. Perhaps we could have a C++11 only explicit bool conversion as well as is_set(). However we would need to experiment a bit as some of the options themselves are also bools so this might be confusing! Another thing we should consider is throwing an exception if get() is called when the option is not set. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1703) [cpp] Remove auto_settle from receiver options
[ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631970#comment-16631970 ] Alan Conway commented on PROTON-1703: - Un-assigning myself and linking this as "is contained by" to the master deprecation clean-up Jira PROTON-1943. Should be reviewed at the next release where we consider removing deprecated features. > [cpp] Remove auto_settle from receiver options > -- > > Key: PROTON-1703 > URL: https://issues.apache.org/jira/browse/PROTON-1703 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.19.0 >Reporter: Alan Conway >Priority: Minor > > auto_settle is a sender-only option, the receiver equivalent is auto_accept. > auto_settle is only used at messaging_adapter.cpp#L172, which applies only to > senders, it was included in the option list by mistake. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1943) Review features mark deprecated and consider removing them.
[ https://issues.apache.org/jira/browse/PROTON-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1943: --- Assignee: Justin Ross > Review features mark deprecated and consider removing them. > --- > > Key: PROTON-1943 > URL: https://issues.apache.org/jira/browse/PROTON-1943 > Project: Qpid Proton > Issue Type: Task >Reporter: Alan Conway >Assignee: Justin Ross >Priority: Major > > This Jira is a task for the next major release, to review all deprecated APIs > and possibly remove them. Any JIRAs relating to removal of deprecated APIs > should be linked to this one. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1943) Review features mark deprecated and consider removing them.
Alan Conway created PROTON-1943: --- Summary: Review features mark deprecated and consider removing them. Key: PROTON-1943 URL: https://issues.apache.org/jira/browse/PROTON-1943 Project: Qpid Proton Issue Type: Task Reporter: Alan Conway This Jira is a task for the next major release, to review all deprecated APIs and possibly remove them. Any JIRAs relating to removal of deprecated APIs should be linked to this one. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-1703) [cpp] Remove auto_settle from receiver options
[ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1703: --- Assignee: (was: Alan Conway) > [cpp] Remove auto_settle from receiver options > -- > > Key: PROTON-1703 > URL: https://issues.apache.org/jira/browse/PROTON-1703 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.19.0 >Reporter: Alan Conway >Priority: Minor > > auto_settle is a sender-only option, the receiver equivalent is auto_accept. > auto_settle is only used at messaging_adapter.cpp#L172, which applies only to > senders, it was included in the option list by mistake. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-1935) [cpp] Read a config file to get default connection parameters
[
https://issues.apache.org/jira/browse/PROTON-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Conway resolved PROTON-1935.
-
Resolution: Fixed
> [cpp] Read a config file to get default connection parameters
> --
>
> Key: PROTON-1935
> URL: https://issues.apache.org/jira/browse/PROTON-1935
> Project: Qpid Proton
> Issue Type: Improvement
> Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.26.0
>
>
> Implement no-argument C++ connect() to connect using information loaded from
> a config file located and formatted as follows:
>
> {code:java}
> # Connection Configuration {#connect_config}
> Proton clients can read default connection information from a
> configuration file.
> If the environment variable `MESSAGING_CONNECT_FILE` is set, it is the
> path to the file. Otherwise the client looks for a file named
> `connect.json` in the following locations, using the first one found:
> * Current working directory of client process.
> * `$HOME/.config/messaging/` - $HOME is user's home directory.
> * `/etc/messaging/`
> The configuration file is in JSON object format. Comments are allowed,
> as defined by the [JavaScript
> Minifier](https://www.crockford.com/javascript/jsmin.html)
> The file format is as follows. Properties are shown with their default
> values, all properties are optional.
> {
> "scheme": "amqp", // [string] URL scheme for connection. Use
> "amqps" for a TLS connection.
> "host": "localhost", // [string] DNS or IP address for connection.
> "port": "amqp", // [string] Defaults to be the same as the
> scheme.
> "user": null, // [string] Authentication user name
> "password": null, // [string] Authentication password
> "sasl": {
> "enable": true, // [boolean] Enable/disable SASL
> authentication
> "mechanisms": null, // [list] List of SASL mechanism names.
> If null the library determines the default list.
> "allow_insecure": false // [boolean] Allow mechanisms that send
> clear-text passwords, even on an unencrypted connection.
> }
> "tls": {
> // NOTE: This section is not final and will change.
> "enable": true, // boolean (true)
> "pem_cert_store": null, // string [file or dir or ?]
> (null)
> "pem_ca_cert_store": null, // string [file or dir or ?]
> (null)
> "pem_key_file": null, // string file path (null)
> "pkcs12_key_store": null, // string (null)
> "pkcs12_trust_store": null, // string (null)
> "key_password": null, // string (null)
> "verify_hostname": true // boolean (true)
> },
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-1940) [c] normalize encoding of multiple="true" fields
[ https://issues.apache.org/jira/browse/PROTON-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved PROTON-1940. - Resolution: Fixed > [c] normalize encoding of multiple="true" fields > > > Key: PROTON-1940 > URL: https://issues.apache.org/jira/browse/PROTON-1940 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-c-0.25.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.26.0 > > > The AMQP spec defines some frame fields as "multiple". > [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-types-v1.0-os.html#section-composite-type-representation] > "The _multiple_ attribute of a field description controls whether multiple > element values are permitted in the representation. A single element of the > type specified in the field description is always permitted. Multiple values > are represented by the use of an array where the type of the elements in the > array is the type defined in the field definition. Note that a null value and > a zero-length array (with a correct type for its elements) both describe an > absence of a value and MUST be treated as semantically identical. " > Proton accepts all legal values. This issue is to normalize values written by > proton: > * empty array becomes null > * array of one element becomes a single value > This is the most efficient encoding, and some clients (.NET) have problems > with multiple fields that contain an empty array rather than a null. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1831) [c] duplicate link names cause invalid read in pn_transport_unbind_handles
[ https://issues.apache.org/jira/browse/PROTON-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631833#comment-16631833 ] ASF GitHub Bot commented on PROTON-1831: Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/142 Merged, see JIRA > [c] duplicate link names cause invalid read in pn_transport_unbind_handles > -- > > Key: PROTON-1831 > URL: https://issues.apache.org/jira/browse/PROTON-1831 > Project: Qpid Proton > Issue Type: Bug >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > > See PROTON-1832 for the detail, this JIRA was inadvertently spammed with > comments for it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton pull request #151: Install tests
Github user alanconway closed the pull request at: https://github.com/apache/qpid-proton/pull/151 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #151: Install tests
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/151 Merged: 393f8a67 * PROTON-1798: [c, cpp, ruby] Installable tests for proton --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1940) [c] normalize encoding of multiple="true" fields
[ https://issues.apache.org/jira/browse/PROTON-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631838#comment-16631838 ] ASF subversion and git services commented on PROTON-1940: - Commit 5960f15df324daf04387066af55dbb2f79c68f71 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=5960f15 ] PROTON-1940: [c] normalize encoding of multiple="true" fields Append src to data after normalizing for "multiple" field encoding. AMQP composite field definitions can be declared "multiple", see: - http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-types-v1.0-os.html#doc-idp115568 - http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-types-v1.0-os.html#section-composite-type-representation Multiple fields allow redundant encoding of two cases: 1. empty: null or an empty array. 2. single-value: direct encoding of value, or array with one element For encoding compactness and inter-operability, normalize multiple field values to always use null for empty, and direct encoding for single value. > [c] normalize encoding of multiple="true" fields > > > Key: PROTON-1940 > URL: https://issues.apache.org/jira/browse/PROTON-1940 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-c-0.25.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.26.0 > > > The AMQP spec defines some frame fields as "multiple". > [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-types-v1.0-os.html#section-composite-type-representation] > "The _multiple_ attribute of a field description controls whether multiple > element values are permitted in the representation. A single element of the > type specified in the field description is always permitted. Multiple values > are represented by the use of an array where the type of the elements in the > array is the type defined in the field definition. Note that a null value and > a zero-length array (with a correct type for its elements) both describe an > absence of a value and MUST be treated as semantically identical. " > Proton accepts all legal values. This issue is to normalize values written by > proton: > * empty array becomes null > * array of one element becomes a single value > This is the most efficient encoding, and some clients (.NET) have problems > with multiple fields that contain an empty array rather than a null. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #159: PROTON-1940: [c] normalize encoding of multiple="tru...
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/159 Merged, if there are still objections to using a vfill code lets open a new issue --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1940) [c] normalize encoding of multiple="true" fields
[ https://issues.apache.org/jira/browse/PROTON-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631840#comment-16631840 ] ASF GitHub Bot commented on PROTON-1940: Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/159 > [c] normalize encoding of multiple="true" fields > > > Key: PROTON-1940 > URL: https://issues.apache.org/jira/browse/PROTON-1940 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-c-0.25.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.26.0 > > > The AMQP spec defines some frame fields as "multiple". > [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-types-v1.0-os.html#section-composite-type-representation] > "The _multiple_ attribute of a field description controls whether multiple > element values are permitted in the representation. A single element of the > type specified in the field description is always permitted. Multiple values > are represented by the use of an array where the type of the elements in the > array is the type defined in the field definition. Note that a null value and > a zero-length array (with a correct type for its elements) both describe an > absence of a value and MUST be treated as semantically identical. " > Proton accepts all legal values. This issue is to normalize values written by > proton: > * empty array becomes null > * array of one element becomes a single value > This is the most efficient encoding, and some clients (.NET) have problems > with multiple fields that contain an empty array rather than a null. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1940) [c] normalize encoding of multiple="true" fields
[ https://issues.apache.org/jira/browse/PROTON-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631841#comment-16631841 ] ASF GitHub Bot commented on PROTON-1940: Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/159 Merged, if there are still objections to using a vfill code lets open a new issue > [c] normalize encoding of multiple="true" fields > > > Key: PROTON-1940 > URL: https://issues.apache.org/jira/browse/PROTON-1940 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-c-0.25.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.26.0 > > > The AMQP spec defines some frame fields as "multiple". > [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-types-v1.0-os.html#section-composite-type-representation] > "The _multiple_ attribute of a field description controls whether multiple > element values are permitted in the representation. A single element of the > type specified in the field description is always permitted. Multiple values > are represented by the use of an array where the type of the elements in the > array is the type defined in the field definition. Note that a null value and > a zero-length array (with a correct type for its elements) both describe an > absence of a value and MUST be treated as semantically identical. " > Proton accepts all legal values. This issue is to normalize values written by > proton: > * empty array becomes null > * array of one element becomes a single value > This is the most efficient encoding, and some clients (.NET) have problems > with multiple fields that contain an empty array rather than a null. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton pull request #159: PROTON-1940: [c] normalize encoding of multip...
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/159 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton pull request #142: PROTON-1831: Incorrect open/close sequence fo...
Github user alanconway closed the pull request at: https://github.com/apache/qpid-proton/pull/142 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1831) [c] duplicate link names cause invalid read in pn_transport_unbind_handles
[ https://issues.apache.org/jira/browse/PROTON-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631834#comment-16631834 ] ASF GitHub Bot commented on PROTON-1831: Github user alanconway closed the pull request at: https://github.com/apache/qpid-proton/pull/142 > [c] duplicate link names cause invalid read in pn_transport_unbind_handles > -- > > Key: PROTON-1831 > URL: https://issues.apache.org/jira/browse/PROTON-1831 > Project: Qpid Proton > Issue Type: Bug >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > > See PROTON-1832 for the detail, this JIRA was inadvertently spammed with > comments for it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #142: PROTON-1831: Incorrect open/close sequence for same ...
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/142 Merged, see JIRA --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1798) Installed example self-tests for proton
[ https://issues.apache.org/jira/browse/PROTON-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631828#comment-16631828 ] ASF GitHub Bot commented on PROTON-1798: Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/151 Merged: 393f8a67 * PROTON-1798: [c, cpp, ruby] Installable tests for proton > Installed example self-tests for proton > --- > > Key: PROTON-1798 > URL: https://issues.apache.org/jira/browse/PROTON-1798 > Project: Qpid Proton > Issue Type: Test >Affects Versions: proton-c-0.21.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Labels: testing > Fix For: proton-c-0.26.0 > > > Install test scripts so that self-tests can be run on an installed package, > without access to the source tree. These tests will be a separate install > group. > > Initially the tests will consist of automatically building and running > installed examples, in future we can add unit tests etc. to the installed set. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton pull request #157: WIP: extract connection_options_impl for test...
Github user alanconway closed the pull request at: https://github.com/apache/qpid-proton/pull/157 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton issue #157: WIP: extract connection_options_impl for tests and i...
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/157 Dropped this approch, see #160 for a public API using proton::option --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton pull request #160: WIP: option version of connection_options ...
GitHub user alanconway opened a pull request: https://github.com/apache/qpid-proton/pull/160 WIP: option version of connection_options getters This is the template approach to option getters - memory safe. Needs to be extended to all the _options classes, but I want agreement on the approach and option clss before I complete the job. @astitcher @cliffjansen You can merge this pull request into a Git repository by running: $ git pull https://github.com/alanconway/qpid-proton cpp-options-get-opt Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/160.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #160 commit ad144301b3ac9fb03f45420344dc5b236654f768 Author: Alan Conway Date: 2018-09-26T20:11:56Z WIP: option version of connection_options getters --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
