[jira] [Commented] (PROTON-2105) Support Go modules
[
https://issues.apache.org/jira/browse/PROTON-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941458#comment-16941458
]
Roddie Kieley commented on PROTON-2105:
---
As there should be [one module with multiple
packages|https://golang.org/cmd/go/#hdr-Modules__module_versions__and_more],
having a go.mod file in the Qpid-proton directory itself as per this scratch
PROTON-2105
[go.mod|https://github.com/RoddieKieley/qpid-proton/blob/PROTON-2105/go.mod]
file works ok:
{noformat}
module github.com/roddiekieley/qpid-proton
go 1.13
{noformat}
with the following from the referring project
{noformat}
require github.com/roddiekieley/qpid-proton v0.0.0-20191001011843-ff30eeda56ab
{noformat}
where the v0.0.0-20191001011843-ff30eeda56ab was the specific PROTON-2105
branch commit that had the above go.mod. The specific amqp package was then
imported via:
{noformat}
import (
"github.com/roddiekieley/qpid-proton/go/src/qpid.apache.org/amqp"
)
{noformat}
While that works, it is a bit absolute and verbose even with the requisite
change to apache, so needs to be simplified some more.
> Support Go modules
> --
>
> Key: PROTON-2105
> URL: https://issues.apache.org/jira/browse/PROTON-2105
> Project: Qpid Proton
> Issue Type: Bug
> Components: go-binding
>Reporter: Ulf Lilleengen
>Assignee: Roddie Kieley
>Priority: Major
>
> As of Go 1.12, go module support is available. In order to manage
> dependencies using go modules, dependencies must also be using go modules.
> Therefore, adding a go.mod file to each module would allow qpid proton go
> bindings to be managed as a go module.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1430) qd.waypoint capability not recognised if encoded as array
[ https://issues.apache.org/jira/browse/DISPATCH-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941397#comment-16941397 ] ASF subversion and git services commented on DISPATCH-1430: --- Commit 2b849f2e17e657026bc2201e0ab396d1314d1c2d in qpid-dispatch's branch refs/heads/master from Gordon Sim [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2b849f2 ] DISPATCH-1430: handle array of capabilities as well as single symbol for qd.waypoint > qd.waypoint capability not recognised if encoded as array > - > > Key: DISPATCH-1430 > URL: https://issues.apache.org/jira/browse/DISPATCH-1430 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Priority: Major > > The qd.waypoint capability on a linkcurrently has to be specified as a single > symbol. Not all libraries will encode even a single capability in this way, > pusing instead an array with a single item. (Both are legitimate AMQP > encodings). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1428) route connection not indexed by 'connection' field of connector
[
https://issues.apache.org/jira/browse/DISPATCH-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941395#comment-16941395
]
ASF subversion and git services commented on DISPATCH-1428:
---
Commit ea32ab17c4d977edcc9f6cf7f1f52565cb7b440a in qpid-dispatch's branch
refs/heads/master from Gordon Sim
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=ea32ab1 ]
DISPATCH-1428: allow a route-container connection to be looked up by connector
name, even if the container id is the same as a connection from a different
connector
> route connection not indexed by 'connection' field of connector
> ---
>
> Key: DISPATCH-1428
> URL: https://issues.apache.org/jira/browse/DISPATCH-1428
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Priority: Major
>
> The connection established by a route-container connector will not be indexed
> by the 'connection' field of that connector if there is already an existing
> route-connection with the same container id but established by a different
> connector.
> E.g. start router on 5672 and a broker (or a separate router emulating a
> broker) on 5673, then:
> {noformat}
> for n in foo bar; do
> qdmanage CREATE --type connector --name $n role=route-container
> host=localhost port=5673;
> qdmanage CREATE --type linkRoute --name $n pattern=$n direction=in
> connection=$n;
> done;
> qdstat --linkroute
> {noformat}
> Only one of these link routes is active though both connections are
> established.
> The issues is that when the first connection is established, it indexes the
> qdr_conn_identifier_t by container-id and the connection label from the
> connector. When the second connection is established, it looks up first by
> container id, so adds itself to the qdr_conn_identifier_t created by the
> first connection. There is then no entry in the index for the connection
> label of the second connector, so the second link route can never be
> activated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1429) Autolink with address starting with double underscores gets converted to single underscore
[
https://issues.apache.org/jira/browse/DISPATCH-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941396#comment-16941396
]
ASF subversion and git services commented on DISPATCH-1429:
---
Commit 28613bb2df42d3249ec27c16063d4fb923a01ea5 in qpid-dispatch's branch
refs/heads/master from Gordon Sim
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=28613bb ]
DISPATCH-1429: reset iterator for address starting with _ if it does not match
one of the special types
> Autolink with address starting with double underscores gets converted to
> single underscore
> --
>
> Key: DISPATCH-1429
> URL: https://issues.apache.org/jira/browse/DISPATCH-1429
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Ulf Lilleengen
>Priority: Major
>
> I have the following in qdrouterd.conf:
>
> {code:java}
> address {
> prefix: __myqueue
> waypoint: true
> }
> autoLink {
> address: __myqueue
> direction: in
> containerId: c2
> }{code}
>
> Running the following command shows that address field gets converted from
> '__myqueue' to '_myqueue':
> {code:java}
> [lulf@pteppic ~]$ qdmanage QUERY --type=autoLink
> [
> {
> "name": "autoLink/0",
> "identity": "3",
> "type": "org.apache.qpid.dispatch.router.config.autoLink",
> "address": "_myqueue",
> "addr": "_myqueue",
> "direction": "in",
> "dir": "in",
> "phase": 1,
> "containerId": "c2",
> "operStatus": "inactive",
> "fallback": false
> }
> ]{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1433) system_tests_delivery_abort failing due to receiver connecting late
[
https://issues.apache.org/jira/browse/DISPATCH-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-1433.
-
Resolution: Fixed
> system_tests_delivery_abort failing due to receiver connecting late
> ---
>
> Key: DISPATCH-1433
> URL: https://issues.apache.org/jira/browse/DISPATCH-1433
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.9.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.10.0
>
>
> {noformat}
> "40: test_07_multicast_truncate_one_router
> (system_tests_delivery_abort.RouterTest) ... FAIL",
> "40: ",
> "40:
> ==",
> "40: FAIL: test_07_multicast_truncate_one_router
> (system_tests_delivery_abort.RouterTest)",
> "40:
> --",
> "40: Traceback (most recent call last):",
> "40: File
> \"/opt/qpid-dispatch-src/tests/system_tests_delivery_abort.py\", line 127, in
> test_07_multicast_truncate_one_router",
> "40: self.assertEqual(None, test.error)",
> "40: AssertionError: None != u\"Expected: [u'Send_Short_1',
> u'Aborted_Delivery', u'2', u'2', u'2', u'2', u'2', u'2', u'2', u'2', u'2',
> u'2', u'Send_Short_2', u'3', u'3', u'3', u'3', u'3', u'3', u'3', u'3', u'3',
> u'3', u'Send_Short_3'], Actuals: [u'Aborted_Delivery', u'2', u'2', u'2',
> u'2', u'2', u'2', u'2', u'2', u'2', u'2', u'Send_Short_2', u'3', u'3', u'3',
> u'3', u'3', u'3', u'3', u'3', u'3', u'3', u'Send_Short_3'], [u'Send_Short_1',
> u'Aborted_Delivery', u'2', u'2', u'2', u'2', u'2', u'2', u'2', u'2', u'2',
> u'2', u'Send_Short_2', u'3', u'3', u'3', u'3', u'3', u'3', u'3', u'3', u'3',
> u'3', u'Send_Short_3']\"",
> "40: ",
> "40:
> --",
> "40: Ran 7 tests in 15.769s",
> "40: ",
> "40: FAILED (failures=1)",
> "40/59 Test #40: system_tests_delivery_abort
> ...***Failed 15.93 sec",
> "test 41", {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1433) system_tests_delivery_abort failing due to receiver connecting late
[
https://issues.apache.org/jira/browse/DISPATCH-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941394#comment-16941394
]
ASF subversion and git services commented on DISPATCH-1433:
---
Commit c3fd202f5ce17cb553ea3fc4b04cde376fe86e5b in qpid-dispatch's branch
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c3fd202 ]
DISPATCH-1433 - Wait for the receivers to get created before starting to send
messages to them
> system_tests_delivery_abort failing due to receiver connecting late
> ---
>
> Key: DISPATCH-1433
> URL: https://issues.apache.org/jira/browse/DISPATCH-1433
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.9.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.10.0
>
>
> {noformat}
> "40: test_07_multicast_truncate_one_router
> (system_tests_delivery_abort.RouterTest) ... FAIL",
> "40: ",
> "40:
> ==",
> "40: FAIL: test_07_multicast_truncate_one_router
> (system_tests_delivery_abort.RouterTest)",
> "40:
> --",
> "40: Traceback (most recent call last):",
> "40: File
> \"/opt/qpid-dispatch-src/tests/system_tests_delivery_abort.py\", line 127, in
> test_07_multicast_truncate_one_router",
> "40: self.assertEqual(None, test.error)",
> "40: AssertionError: None != u\"Expected: [u'Send_Short_1',
> u'Aborted_Delivery', u'2', u'2', u'2', u'2', u'2', u'2', u'2', u'2', u'2',
> u'2', u'Send_Short_2', u'3', u'3', u'3', u'3', u'3', u'3', u'3', u'3', u'3',
> u'3', u'Send_Short_3'], Actuals: [u'Aborted_Delivery', u'2', u'2', u'2',
> u'2', u'2', u'2', u'2', u'2', u'2', u'2', u'Send_Short_2', u'3', u'3', u'3',
> u'3', u'3', u'3', u'3', u'3', u'3', u'3', u'Send_Short_3'], [u'Send_Short_1',
> u'Aborted_Delivery', u'2', u'2', u'2', u'2', u'2', u'2', u'2', u'2', u'2',
> u'2', u'Send_Short_2', u'3', u'3', u'3', u'3', u'3', u'3', u'3', u'3', u'3',
> u'3', u'Send_Short_3']\"",
> "40: ",
> "40:
> --",
> "40: Ran 7 tests in 15.769s",
> "40: ",
> "40: FAILED (failures=1)",
> "40/59 Test #40: system_tests_delivery_abort
> ...***Failed 15.93 sec",
> "test 41", {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1433) system_tests_delivery_abort failing due to receiver connecting late
Ganesh Murthy created DISPATCH-1433:
---
Summary: system_tests_delivery_abort failing due to receiver
connecting late
Key: DISPATCH-1433
URL: https://issues.apache.org/jira/browse/DISPATCH-1433
Project: Qpid Dispatch
Issue Type: Bug
Components: Tests
Affects Versions: 1.9.0
Reporter: Ganesh Murthy
Assignee: Ganesh Murthy
Fix For: 1.10.0
{noformat}
"40: test_07_multicast_truncate_one_router
(system_tests_delivery_abort.RouterTest) ... FAIL",
"40: ",
"40:
==",
"40: FAIL: test_07_multicast_truncate_one_router
(system_tests_delivery_abort.RouterTest)",
"40:
--",
"40: Traceback (most recent call last):",
"40: File
\"/opt/qpid-dispatch-src/tests/system_tests_delivery_abort.py\", line 127, in
test_07_multicast_truncate_one_router",
"40: self.assertEqual(None, test.error)",
"40: AssertionError: None != u\"Expected: [u'Send_Short_1',
u'Aborted_Delivery', u'2', u'2', u'2', u'2', u'2', u'2', u'2', u'2', u'2',
u'2', u'Send_Short_2', u'3', u'3', u'3', u'3', u'3', u'3', u'3', u'3', u'3',
u'3', u'Send_Short_3'], Actuals: [u'Aborted_Delivery', u'2', u'2', u'2', u'2',
u'2', u'2', u'2', u'2', u'2', u'2', u'Send_Short_2', u'3', u'3', u'3', u'3',
u'3', u'3', u'3', u'3', u'3', u'3', u'Send_Short_3'], [u'Send_Short_1',
u'Aborted_Delivery', u'2', u'2', u'2', u'2', u'2', u'2', u'2', u'2', u'2',
u'2', u'Send_Short_2', u'3', u'3', u'3', u'3', u'3', u'3', u'3', u'3', u'3',
u'3', u'Send_Short_3']\"",
"40: ",
"40:
--",
"40: Ran 7 tests in 15.769s",
"40: ",
"40: FAILED (failures=1)",
"40/59 Test #40: system_tests_delivery_abort
...***Failed 15.93 sec",
"test 41", {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on issue #576: optparse to argparse migration
codecov-io commented on issue #576: optparse to argparse migration URL: https://github.com/apache/qpid-dispatch/pull/576#issuecomment-536764810 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=h1) Report > Merging [#576](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/17f20fb58b32d07bb1f95067c7210819e24b4b5d?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #576 +/- ## == - Coverage 86.33% 86.32% -0.01% == Files 90 90 Lines 2035620356 == - Hits1757517573 -2 - Misses 2781 2783 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.7% <0%> (-0.76%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.15% <0%> (-0.19%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.09% <0%> (+0.11%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.1% <0%> (+0.12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=footer). Last update [17f20fb...65ba3d7](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] nicob87 opened a new pull request #576: optparse to argparse migration
nicob87 opened a new pull request #576: optparse to argparse migration URL: https://github.com/apache/qpid-dispatch/pull/576 Main reason to migrate from optparse to argparse is python documentation itself. - from: https://docs.python.org/2/library/optparse.html Deprecated since version 2.7: The optparse module is deprecated and will not be developed further; development will continue with the argparse module. - from: https://docs.python.org/2/library/argparse.html The argparse module improves on the standard library optparse module in a number of ways including: Handling positional arguments. Supporting sub-commands. Allowing alternative option prefixes like + and /. Handling zero-or-more and one-or-more style arguments. Producing more informative usage messages. Providing a much simpler interface for custom type and action. Note (from argparse doc): - Keep in mind that what was previously called options, now in the argparse context is called args. Regarding to the migration job done in this pr: - optarse library is removed from the source, all library argument parsing is now done with argparse. - version argument is now handled by argparse, that supports special version argument. - qdstat arguments: fully handled by argparse library. - qdmanage arguments: all optparse arguments are now migrated to argparse. - positional argument parsing (operation) remains "unmodified", in the future it may be changed so argparse also parsing positional arguments. - incompatible arguments (like -r, --all-routers) or (-c --all-entities) are now handled by the special "mutually_exclusive_group". - Help message is also handled by argparse. - Usage message is also handled by argparse. - some unittests created to test specifically the parsing. - some more could be added. - some unittests added to the "main" method in command.py module. - help messages could be customized, right now they are being printed with the default argparse format. qdstat_help: ``` usage: qdstat [-h] [-b URL] [-t SECS] [--ssl-certificate CERT] [--ssl-key KEY] [--ssl-trustfile TRUSTED-CA-DB] [--ssl-password PASSWORD] [--ssl-password-file SSL-PASSWORD-FILE] [--sasl-mechanisms SASL-MECHANISMS] [--sasl-username SASL-USERNAME] [--sasl-password SASL-PASSWORD] [--sasl-password-file SASL-PASSWORD-FILE] [--ssl-disable-peer-name-verify] [--version] [-v] [-g | -c | -l | -n | -e | -a | -m | --autolinks | --linkroutes | --log | --all-entities] [--all-routers | -r ROUTER-ID] [--limit LIMIT] optional arguments: -h, --helpshow this help message and exit --version show program's version number and exit -v, --verbose Show maximum detail --limit LIMIT Limit number of output rows Connection: Connection Options -b URL, --bus URL URL of the messaging bus to connect to default 0.0.0.0 -t SECS, --timeout SECS Maximum time to wait for connection in seconds default 5 --ssl-certificate CERT Client SSL certificate (PEM Format) --ssl-key KEY Client SSL private key (PEM Format) --ssl-trustfile TRUSTED-CA-DB Trusted Certificate Authority Database file (PEM Format) --ssl-password PASSWORD Certificate password, will be prompted if not specifed. --ssl-password-file SSL-PASSWORD-FILE Certificate password, will be prompted if not specifed. --sasl-mechanisms SASL-MECHANISMS Allowed sasl mechanisms to be supplied during the sasl handshake. --sasl-username SASL-USERNAME User name for SASL plain authentication --sasl-password SASL-PASSWORD Password for SASL plain authentication --sasl-password-file SASL-PASSWORD-FILE Password for SASL plain authentication --ssl-disable-peer-name-verify Disables SSL peer name verification. WARNING - This option is insecure and must not be used in production environments Display: Choose what kind of information you want to be displayed -g, --general Show General Router Stats -c, --connections Show Connections -l, --links Show Router Links -n, --nodes Show Router Nodes -e, --edgeShow edge connections -a, --address Show Router Addresses -m, --memory Show Router Memory Stats
[GitHub] [qpid-dispatch] nicob87 closed pull request #575: optparse to argparse migration
nicob87 closed pull request #575: optparse to argparse migration URL: https://github.com/apache/qpid-dispatch/pull/575 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-476) Improve send performance of anonymous fallback producer
[ https://issues.apache.org/jira/browse/QPIDJMS-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941270#comment-16941270 ] ASF subversion and git services commented on QPIDJMS-476: - Commit e04e3f847859cddecc4704d6a9c628cf435bf97f in qpid-jms's branch refs/heads/master from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-jms.git;h=e04e3f8 ] QPIDJMS-476 Enhance anonymous fallback producer to allow asynchronous sends Improves performance of anonymous fallback producer mode by allowing asynchronous sends and sends that reuse existing cache anonymous fallback producer instances avoiding the need for open -> send -> close on each send. > Improve send performance of anonymous fallback producer > --- > > Key: QPIDJMS-476 > URL: https://issues.apache.org/jira/browse/QPIDJMS-476 > Project: Qpid JMS > Issue Type: Improvement > Components: qpid-jms-client >Affects Versions: 0.46.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: 0.47.0 > > > For remotes that do not report support for the anonymous relay we implement a > fallback mechanism that creates a single sender link that is opened on send > and close on completion of the send (remote sends disposition). This > mechanism essentially makes ever send using the anonymous fallback mechanism > synchronous with the overhead of Attach -> Transfer -> Detach for each call > to send. We can improve this mechanism and also allow for asynchronous sends > both from the JMS 1.1 send methods and from the JMS completion send methods > as is currently done when the anonymous relay is supported. By allowing for > caching of sender links we can reduce the number of attach and detach cycles > for sends that encompass a fixed set of addresses as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPIDJMS-476) Improve send performance of anonymous fallback producer
Timothy A. Bish created QPIDJMS-476: --- Summary: Improve send performance of anonymous fallback producer Key: QPIDJMS-476 URL: https://issues.apache.org/jira/browse/QPIDJMS-476 Project: Qpid JMS Issue Type: Improvement Components: qpid-jms-client Affects Versions: 0.46.0 Reporter: Timothy A. Bish Assignee: Timothy A. Bish Fix For: 0.47.0 For remotes that do not report support for the anonymous relay we implement a fallback mechanism that creates a single sender link that is opened on send and close on completion of the send (remote sends disposition). This mechanism essentially makes ever send using the anonymous fallback mechanism synchronous with the overhead of Attach -> Transfer -> Detach for each call to send. We can improve this mechanism and also allow for asynchronous sends both from the JMS 1.1 send methods and from the JMS completion send methods as is currently done when the anonymous relay is supported. By allowing for caching of sender links we can reduce the number of attach and detach cycles for sends that encompass a fixed set of addresses as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1426) Repetitive receiver fail over causes memory leak
[
https://issues.apache.org/jira/browse/DISPATCH-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-1426.
-
Fix Version/s: 1.10.0
Resolution: Fixed
> Repetitive receiver fail over causes memory leak
>
>
> Key: DISPATCH-1426
> URL: https://issues.apache.org/jira/browse/DISPATCH-1426
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.8.0, 1.9.0
>Reporter: Ken Giusti
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.10.0
>
>
> I'm able to cause a slow memory leak by running a new test I'm creating for
> reproducing [DISPATCH-1406|https://github.com/apache/qpid-dispatch/pull/564]
> test for an extended time. Output of qdstat -m after test run:
> {{$ qdstat -m -b 127.0.0.1:22381
> Types
> typesize batch thread-max total in-threads
> rebal-in rebal-out
>
> ==
> qd_bitmask_t24 64 128 576448 1
>3
> qd_buffer_t 53664 128 2,240 2,240 8
>8
> qd_composed_field_t 64 64 128 256256 0
>0
> qd_composite_t 11264 128 320320 0
>0
> qd_connection_t 2,360 16 32 48 48 0
>0
> qd_connector_t 50464 128 64 64 0
>0
> qd_hash_handle_t16 64 128 128128 0
>0
> qd_hash_item_t 32 64 128 128128 0
>0
> qd_iterator_t 16064 128 4,224 4,224 4
>4
> qd_link_ref_t 24 64 128 320192 0
>2
> qd_link_t 10464 128 192192 0
>0
> qd_listener_t 44064 128 64 64 0
>0
> qd_log_entry_t 2,112 16 32 1,056 1,056 0
>0
> qd_management_context_t 56 64 128 128128 0
>0
> qd_message_content_t1,080 64 128 576576 0
>0
> qd_message_t16064 128 768704 2
>3
> qd_node_t 56 64 128 64 64 0
>0
> qd_parse_node_t 10464 128 128128 0
>0
> qd_parsed_field_t 88 64 128 1,664 1,664 0
>0
> qd_parsed_turbo_t 64 64 128 256256 0
>0
> qd_pn_free_link_session_t 32 64 128 64 64 0
>0
> qd_timer_t 56 64 128 128128 0
>0
> qdr_action_t16064 128 320192 24
>26
> qdr_address_config_t72 64 128 64 64 0
>0
> qdr_address_t 37664 128 64 64 0
>0
> qdr_connection_info_t 88 64 128 192192 0
>0
> qdr_connection_t56864 128 192192 0
>0
> qdr_connection_work_t 48 64 128 64 64 0
>0
> qdr_delivery_cleanup_t 32 64 128 384384 1
>1
> qdr_delivery_ref_t 24 64 128 256192 2
>3
> qdr_delivery_t 27264 128 640512 1
>3
> qdr_error_t 24 64 128 256256 0
>0
> qdr_field_t 40 64 128 768768 0
>0
> qdr_forward_deliver_info_t 32 64 128 64 64 0
>0
> qdr_general_work_t 12864 128 384384 2
>2
> qdr_link_ref_t 24 64 128 448448 0
>0
> qdr_link_t 51264 128 256256 0
>0
> qdr_link_work_t 48 64 128 448448 1
>1
> qdr_node_t 64 64 128 64 64 0
>0
> qdr_query_t 34464 128 128128 0
>0
> qdr_terminus_t 64 64 128 256256 0
>0
> qdtm_rou
[jira] [Updated] (PROTON-2112) segfault in epoll proactor shudown
[ https://issues.apache.org/jira/browse/PROTON-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clifford Jansen updated PROTON-2112: Attachment: bt.txt > segfault in epoll proactor shudown > -- > > Key: PROTON-2112 > URL: https://issues.apache.org/jira/browse/PROTON-2112 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.29.0 > Environment: Linux >Reporter: Clifford Jansen >Assignee: Clifford Jansen >Priority: Major > Attachments: bt.txt > > > If an epoll proactor is dealing with file descriptor resource starvation at > the time of shutdown, it can try to initiate new IO in conflict with other > shutting down activity. Specifically, when freeing a connection's socket, it > tries to resume any pause listeners. > I suspect there is a missing check somewhere to see if > proactor->shutting_down is set before attempting the resume. But it may > require a more thorough dismantling of the overflow listener list before > commencing to tear down straggling connections. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2112) segfault in epoll proactor shudown
Clifford Jansen created PROTON-2112: --- Summary: segfault in epoll proactor shudown Key: PROTON-2112 URL: https://issues.apache.org/jira/browse/PROTON-2112 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: proton-c-0.29.0 Environment: Linux Reporter: Clifford Jansen Assignee: Clifford Jansen If an epoll proactor is dealing with file descriptor resource starvation at the time of shutdown, it can try to initiate new IO in conflict with other shutting down activity. Specifically, when freeing a connection's socket, it tries to resume any pause listeners. I suspect there is a missing check somewhere to see if proactor->shutting_down is set before attempting the resume. But it may require a more thorough dismantling of the overflow listener list before commencing to tear down straggling connections. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1426) Repetitive receiver fail over causes memory leak
[
https://issues.apache.org/jira/browse/DISPATCH-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941027#comment-16941027
]
ASF GitHub Bot commented on DISPATCH-1426:
--
asfgit commented on pull request #573: DISPATCH-1426 - Added an abandoned
deliveries handler so all abandone…
URL: https://github.com/apache/qpid-dispatch/pull/573
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Repetitive receiver fail over causes memory leak
>
>
> Key: DISPATCH-1426
> URL: https://issues.apache.org/jira/browse/DISPATCH-1426
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.8.0, 1.9.0
>Reporter: Ken Giusti
>Assignee: Ganesh Murthy
>Priority: Major
>
> I'm able to cause a slow memory leak by running a new test I'm creating for
> reproducing [DISPATCH-1406|https://github.com/apache/qpid-dispatch/pull/564]
> test for an extended time. Output of qdstat -m after test run:
> {{$ qdstat -m -b 127.0.0.1:22381
> Types
> typesize batch thread-max total in-threads
> rebal-in rebal-out
>
> ==
> qd_bitmask_t24 64 128 576448 1
>3
> qd_buffer_t 53664 128 2,240 2,240 8
>8
> qd_composed_field_t 64 64 128 256256 0
>0
> qd_composite_t 11264 128 320320 0
>0
> qd_connection_t 2,360 16 32 48 48 0
>0
> qd_connector_t 50464 128 64 64 0
>0
> qd_hash_handle_t16 64 128 128128 0
>0
> qd_hash_item_t 32 64 128 128128 0
>0
> qd_iterator_t 16064 128 4,224 4,224 4
>4
> qd_link_ref_t 24 64 128 320192 0
>2
> qd_link_t 10464 128 192192 0
>0
> qd_listener_t 44064 128 64 64 0
>0
> qd_log_entry_t 2,112 16 32 1,056 1,056 0
>0
> qd_management_context_t 56 64 128 128128 0
>0
> qd_message_content_t1,080 64 128 576576 0
>0
> qd_message_t16064 128 768704 2
>3
> qd_node_t 56 64 128 64 64 0
>0
> qd_parse_node_t 10464 128 128128 0
>0
> qd_parsed_field_t 88 64 128 1,664 1,664 0
>0
> qd_parsed_turbo_t 64 64 128 256256 0
>0
> qd_pn_free_link_session_t 32 64 128 64 64 0
>0
> qd_timer_t 56 64 128 128128 0
>0
> qdr_action_t16064 128 320192 24
>26
> qdr_address_config_t72 64 128 64 64 0
>0
> qdr_address_t 37664 128 64 64 0
>0
> qdr_connection_info_t 88 64 128 192192 0
>0
> qdr_connection_t56864 128 192192 0
>0
> qdr_connection_work_t 48 64 128 64 64 0
>0
> qdr_delivery_cleanup_t 32 64 128 384384 1
>1
> qdr_delivery_ref_t 24 64 128 256192 2
>3
> qdr_delivery_t 27264 128 640512 1
>3
> qdr_error_t 24 64 128 256256 0
>0
> qdr_field_t 40 64 128 768768 0
>0
> qdr_forward_deliver_info_t 32 64 128 64 64 0
>0
> qdr_general_work_t 12864 128 384384 2
>2
> qdr_link_ref_t 24 64 128 448448 0
>0
>
[jira] [Commented] (DISPATCH-1426) Repetitive receiver fail over causes memory leak
[
https://issues.apache.org/jira/browse/DISPATCH-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941026#comment-16941026
]
ASF subversion and git services commented on DISPATCH-1426:
---
Commit 17f20fb58b32d07bb1f95067c7210819e24b4b5d in qpid-dispatch's branch
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=17f20fb ]
DISPATCH-1426 - Added an abandoned deliveries handler so all abandoned
deliveries are handled in a single place, right before the qd_link is freed.
This closes #573.
> Repetitive receiver fail over causes memory leak
>
>
> Key: DISPATCH-1426
> URL: https://issues.apache.org/jira/browse/DISPATCH-1426
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.8.0, 1.9.0
>Reporter: Ken Giusti
>Assignee: Ganesh Murthy
>Priority: Major
>
> I'm able to cause a slow memory leak by running a new test I'm creating for
> reproducing [DISPATCH-1406|https://github.com/apache/qpid-dispatch/pull/564]
> test for an extended time. Output of qdstat -m after test run:
> {{$ qdstat -m -b 127.0.0.1:22381
> Types
> typesize batch thread-max total in-threads
> rebal-in rebal-out
>
> ==
> qd_bitmask_t24 64 128 576448 1
>3
> qd_buffer_t 53664 128 2,240 2,240 8
>8
> qd_composed_field_t 64 64 128 256256 0
>0
> qd_composite_t 11264 128 320320 0
>0
> qd_connection_t 2,360 16 32 48 48 0
>0
> qd_connector_t 50464 128 64 64 0
>0
> qd_hash_handle_t16 64 128 128128 0
>0
> qd_hash_item_t 32 64 128 128128 0
>0
> qd_iterator_t 16064 128 4,224 4,224 4
>4
> qd_link_ref_t 24 64 128 320192 0
>2
> qd_link_t 10464 128 192192 0
>0
> qd_listener_t 44064 128 64 64 0
>0
> qd_log_entry_t 2,112 16 32 1,056 1,056 0
>0
> qd_management_context_t 56 64 128 128128 0
>0
> qd_message_content_t1,080 64 128 576576 0
>0
> qd_message_t16064 128 768704 2
>3
> qd_node_t 56 64 128 64 64 0
>0
> qd_parse_node_t 10464 128 128128 0
>0
> qd_parsed_field_t 88 64 128 1,664 1,664 0
>0
> qd_parsed_turbo_t 64 64 128 256256 0
>0
> qd_pn_free_link_session_t 32 64 128 64 64 0
>0
> qd_timer_t 56 64 128 128128 0
>0
> qdr_action_t16064 128 320192 24
>26
> qdr_address_config_t72 64 128 64 64 0
>0
> qdr_address_t 37664 128 64 64 0
>0
> qdr_connection_info_t 88 64 128 192192 0
>0
> qdr_connection_t56864 128 192192 0
>0
> qdr_connection_work_t 48 64 128 64 64 0
>0
> qdr_delivery_cleanup_t 32 64 128 384384 1
>1
> qdr_delivery_ref_t 24 64 128 256192 2
>3
> qdr_delivery_t 27264 128 640512 1
>3
> qdr_error_t 24 64 128 256256 0
>0
> qdr_field_t 40 64 128 768768 0
>0
> qdr_forward_deliver_info_t 32 64 128 64 64 0
>0
> qdr_general_work_t 12864 128 384384 2
>2
> qdr_link_ref_t 24 64 128 448448 0
>0
> qdr_link_t 51264 128 256256 0
>0
> qdr_link_work_t
[GitHub] [qpid-dispatch] asfgit closed pull request #573: DISPATCH-1426 - Added an abandoned deliveries handler so all abandone…
asfgit closed pull request #573: DISPATCH-1426 - Added an abandoned deliveries handler so all abandone… URL: https://github.com/apache/qpid-dispatch/pull/573 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #568: NO-JIRA: fix system tests to avoid over writing debug dump files
asfgit closed pull request #568: NO-JIRA: fix system tests to avoid over writing debug dump files URL: https://github.com/apache/qpid-dispatch/pull/568 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1426) Repetitive receiver fail over causes memory leak
[
https://issues.apache.org/jira/browse/DISPATCH-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940991#comment-16940991
]
ASF GitHub Bot commented on DISPATCH-1426:
--
kgiusti commented on pull request #573: DISPATCH-1426 - Added an abandoned
deliveries handler so all abandone…
URL: https://github.com/apache/qpid-dispatch/pull/573#discussion_r329594071
##
File path: src/router_node.c
##
@@ -102,8 +102,8 @@ static qdr_delivery_t
*qdr_node_delivery_qdr_from_pn(pn_delivery_t *dlv)
}
-static void qdr_node_reap_abandoned_deliveries(qdr_core_t *core, qd_link_t
*link)
-{
+void qd_link_abandoned_deliveries_handler(void *context, qd_link_t *link) {
Review comment:
Nit: Add a newline after the parameter list: the opening brace should be on
the next line by itself.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Repetitive receiver fail over causes memory leak
>
>
> Key: DISPATCH-1426
> URL: https://issues.apache.org/jira/browse/DISPATCH-1426
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.8.0, 1.9.0
>Reporter: Ken Giusti
>Assignee: Ganesh Murthy
>Priority: Major
>
> I'm able to cause a slow memory leak by running a new test I'm creating for
> reproducing [DISPATCH-1406|https://github.com/apache/qpid-dispatch/pull/564]
> test for an extended time. Output of qdstat -m after test run:
> {{$ qdstat -m -b 127.0.0.1:22381
> Types
> typesize batch thread-max total in-threads
> rebal-in rebal-out
>
> ==
> qd_bitmask_t24 64 128 576448 1
>3
> qd_buffer_t 53664 128 2,240 2,240 8
>8
> qd_composed_field_t 64 64 128 256256 0
>0
> qd_composite_t 11264 128 320320 0
>0
> qd_connection_t 2,360 16 32 48 48 0
>0
> qd_connector_t 50464 128 64 64 0
>0
> qd_hash_handle_t16 64 128 128128 0
>0
> qd_hash_item_t 32 64 128 128128 0
>0
> qd_iterator_t 16064 128 4,224 4,224 4
>4
> qd_link_ref_t 24 64 128 320192 0
>2
> qd_link_t 10464 128 192192 0
>0
> qd_listener_t 44064 128 64 64 0
>0
> qd_log_entry_t 2,112 16 32 1,056 1,056 0
>0
> qd_management_context_t 56 64 128 128128 0
>0
> qd_message_content_t1,080 64 128 576576 0
>0
> qd_message_t16064 128 768704 2
>3
> qd_node_t 56 64 128 64 64 0
>0
> qd_parse_node_t 10464 128 128128 0
>0
> qd_parsed_field_t 88 64 128 1,664 1,664 0
>0
> qd_parsed_turbo_t 64 64 128 256256 0
>0
> qd_pn_free_link_session_t 32 64 128 64 64 0
>0
> qd_timer_t 56 64 128 128128 0
>0
> qdr_action_t16064 128 320192 24
>26
> qdr_address_config_t72 64 128 64 64 0
>0
> qdr_address_t 37664 128 64 64 0
>0
> qdr_connection_info_t 88 64 128 192192 0
>0
> qdr_connection_t56864 128 192192 0
>0
> qdr_connection_work_t 48 64 128 64 64 0
>0
> qdr_delivery_cleanup_t 32 64 128 384384 1
>1
> qdr_delivery_ref_t 24 64 128 256192 2
>3
> qdr_delivery_t 27264 128 640512 1
>
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #573: DISPATCH-1426 - Added an abandoned deliveries handler so all abandone…
kgiusti commented on a change in pull request #573: DISPATCH-1426 - Added an
abandoned deliveries handler so all abandone…
URL: https://github.com/apache/qpid-dispatch/pull/573#discussion_r329594071
##
File path: src/router_node.c
##
@@ -102,8 +102,8 @@ static qdr_delivery_t
*qdr_node_delivery_qdr_from_pn(pn_delivery_t *dlv)
}
-static void qdr_node_reap_abandoned_deliveries(qdr_core_t *core, qd_link_t
*link)
-{
+void qd_link_abandoned_deliveries_handler(void *context, qd_link_t *link) {
Review comment:
Nit: Add a newline after the parameter list: the opening brace should be on
the next line by itself.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[ANNOUNCE] Apache Qpid JMS 0.46.0 released
The Apache Qpid (http://qpid.apache.org) community is pleased to announce the immediate availability of Apache Qpid JMS 0.46.0. This is the latest release of our newer JMS client supporting the Advanced Message Queuing Protocol 1.0 (AMQP 1.0, ISO/IEC 19464, http://www.amqp.org), based around the Apache Qpid Proton protocol engine and implementing the AMQP JMS Mapping as it evolves at OASIS. The release is available now from our website: http://qpid.apache.org/download.html Binaries are also available via Maven Central: http://qpid.apache.org/maven.html Release notes can be found at: http://qpid.apache.org/releases/qpid-jms-0.46.0/release-notes.html Thanks to all involved, Robbie - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
