[ 
https://issues.apache.org/jira/browse/PROTON-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941458#comment-16941458
 ] 

Roddie Kieley commented on PROTON-2105:
---------------------------------------

As there should be [one module with multiple 
packages|https://golang.org/cmd/go/#hdr-Modules__module_versions__and_more], 
having a go.mod file in the Qpid-proton directory itself as per this scratch 
PROTON-2105 
[go.mod|https://github.com/RoddieKieley/qpid-proton/blob/PROTON-2105/go.mod] 
file works ok:
{noformat}
module github.com/roddiekieley/qpid-proton

go 1.13
{noformat}

with the following from the referring project
{noformat}
require github.com/roddiekieley/qpid-proton v0.0.0-20191001011843-ff30eeda56ab
{noformat}

where the v0.0.0-20191001011843-ff30eeda56ab was the specific PROTON-2105 
branch commit that had the above go.mod. The specific amqp package was then 
imported via:

{noformat}
import (
  "github.com/roddiekieley/qpid-proton/go/src/qpid.apache.org/amqp"
)
{noformat}

While that works, it is a bit absolute and verbose even with the requisite 
change to apache, so needs to be simplified some more.

> Support Go modules
> ------------------
>
>                 Key: PROTON-2105
>                 URL: https://issues.apache.org/jira/browse/PROTON-2105
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: go-binding
>            Reporter: Ulf Lilleengen
>            Assignee: Roddie Kieley
>            Priority: Major
>
> As of Go 1.12, go module support is available. In order to manage 
> dependencies using go modules, dependencies must also be using go modules. 
> Therefore, adding a go.mod file to each module would allow qpid proton go 
> bindings to be managed as a go module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to