[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953339#comment-16953339
]
Roddie Kieley commented on DISPATCH-1384:
-
[~jdanek] I'm seeing 67% pass on master here and 69% with your jd_macos_tests
branch. Some % lost due to no saslpasswd2 executable being found, not sure how
much of the rest of the discrepancy is local environment at this point:
master
{code}
67% tests passed, 20 tests failed out of 61
Total Test time (real) = 987.86 sec
The following tests FAILED:
9 - unit_tests (SEGFAULT)
14 - system_tests_link_routes (Child aborted)
21 - system_tests_handle_failover (Failed)
24 - system_tests_policy (Child aborted)
26 - system_tests_protocol_settings (Failed)
27 - system_tests_qdmanage (Failed)
28 - system_tests_qdstat (Failed)
29 - system_tests_sasl_plain (Failed)
30 - system_tests_user_id (Failed)
31 - system_tests_user_id_proxy (Failed)
37 - system_tests_log_message_components (Failed)
39 - system_tests_auth_service_plugin (Failed)
40 - system_tests_authz_service_plugin (Failed)
43 - system_tests_topology_disposition (Failed)
49 - system_tests_bad_configuration (Failed)
50 - system_tests_ssl (Failed)
54 - system_tests_http (Failed)
56 - system_tests_core_client (Failed)
57 - system_tests_address_lookup (Child aborted)
59 - system_tests_multicast (Failed)
Errors while running CTest
{code}
jd_macos_tests
{code}
69% tests passed, 18 tests failed out of 59
Total Test time (real) = 892.27 sec
The following tests FAILED:
9 - unit_tests (SEGFAULT)
13 - system_tests_link_routes (Child aborted)
20 - system_tests_handle_failover (Failed)
23 - system_tests_policy (Child aborted)
25 - system_tests_protocol_settings (Failed)
26 - system_tests_qdmanage (Failed)
27 - system_tests_qdstat (Failed)
28 - system_tests_sasl_plain (Failed)
29 - system_tests_user_id (Failed)
30 - system_tests_user_id_proxy (Failed)
36 - system_tests_log_message_components (Failed)
38 - system_tests_auth_service_plugin (Failed)
39 - system_tests_authz_service_plugin (Failed)
42 - system_tests_topology_disposition (Failed)
49 - system_tests_ssl (Failed)
52 - system_tests_http (Failed)
55 - system_tests_core_client (Failed)
56 - system_tests_address_lookup (Child aborted)
{code}
I also noted that python crashes multiple times during the run. Outside of the
steps from the travis yaml is there any further specific configuration
expected, or exact versions needed to get the higher pass rate do you know?
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1282) Support for building on macOS
[ https://issues.apache.org/jira/browse/DISPATCH-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953282#comment-16953282 ] ASF GitHub Bot commented on DISPATCH-1282: -- RoddieKieley commented on issue #459: DISPATCH-1282 - Support for building on macOS URL: https://github.com/apache/qpid-dispatch/pull/459#issuecomment-542941865 @jdanekrh Sounds like it's about as good as it can be for the moment. I think the unittest2 issue resolution via a virtual environment was a reasonable way to go. Going to grab master now and see how it goes here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support for building on macOS > - > > Key: DISPATCH-1282 > URL: https://issues.apache.org/jira/browse/DISPATCH-1282 > Project: Qpid Dispatch > Issue Type: New Feature >Affects Versions: 1.5.0 >Reporter: Jiri Daněk >Priority: Major > Labels: macOS > > Currently, Dispatch compilation fails on "rt" library being unavailable. > All Dispatch dependencies (Qpid Proton, libwebsockets, ...) can be built on > macOS. > I am attaching a patch which allows to compile dispatch on OSX and run it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] RoddieKieley commented on issue #459: DISPATCH-1282 - Support for building on macOS
RoddieKieley commented on issue #459: DISPATCH-1282 - Support for building on macOS URL: https://github.com/apache/qpid-dispatch/pull/459#issuecomment-542941865 @jdanekrh Sounds like it's about as good as it can be for the moment. I think the unittest2 issue resolution via a virtual environment was a reasonable way to go. Going to grab master now and see how it goes here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1282) Support for building on macOS
[ https://issues.apache.org/jira/browse/DISPATCH-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953242#comment-16953242 ] ASF subversion and git services commented on DISPATCH-1282: --- Commit 44f40b8959c72566e88bfd3da44c203d15c288de in qpid-dispatch's branch refs/heads/master from Jiri Danek [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=44f40b8 ] DISPATCH-1282 - Use Python3 from MacPorts in Travis when on macOS > Support for building on macOS > - > > Key: DISPATCH-1282 > URL: https://issues.apache.org/jira/browse/DISPATCH-1282 > Project: Qpid Dispatch > Issue Type: New Feature >Affects Versions: 1.5.0 >Reporter: Jiri Daněk >Priority: Major > Labels: macOS > > Currently, Dispatch compilation fails on "rt" library being unavailable. > All Dispatch dependencies (Qpid Proton, libwebsockets, ...) can be built on > macOS. > I am attaching a patch which allows to compile dispatch on OSX and run it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1282) Support for building on macOS
[ https://issues.apache.org/jira/browse/DISPATCH-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953238#comment-16953238 ] ASF GitHub Bot commented on DISPATCH-1282: -- jdanekrh commented on pull request #459: DISPATCH-1282 - Support for building on macOS URL: https://github.com/apache/qpid-dispatch/pull/459 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support for building on macOS > - > > Key: DISPATCH-1282 > URL: https://issues.apache.org/jira/browse/DISPATCH-1282 > Project: Qpid Dispatch > Issue Type: New Feature >Affects Versions: 1.5.0 >Reporter: Jiri Daněk >Priority: Major > Labels: macOS > > Currently, Dispatch compilation fails on "rt" library being unavailable. > All Dispatch dependencies (Qpid Proton, libwebsockets, ...) can be built on > macOS. > I am attaching a patch which allows to compile dispatch on OSX and run it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh merged pull request #459: DISPATCH-1282 - Support for building on macOS
jdanekrh merged pull request #459: DISPATCH-1282 - Support for building on macOS URL: https://github.com/apache/qpid-dispatch/pull/459 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1282) Support for building on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953240#comment-16953240
]
ASF subversion and git services commented on DISPATCH-1282:
---
Commit 76ef8420f8b87e4c3699462998d05b8d9156c1c2 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=76ef842 ]
DISPATCH-1282 - Fix port checking in dispatch tests on macOS
On macOS, sockets cannot be reused after a failure
$ python
>>> import socket
>>> s = socket.socket()
>>> s.connect(('127.0.0.1', ))
Traceback (most recent call last):
File "", line 1, in
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py",
line 228, in meth
return getattr(self._sock,name)(*args)
socket.error: [Errno 61] Connection refused
>>> s.connect(('127.0.0.1', ))
Traceback (most recent call last):
File "", line 1, in
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py",
line 228, in meth
return getattr(self._sock,name)(*args)
socket.error: [Errno 22] Invalid argument
>>> s.close()
>>> s.connect(('127.0.0.1', ))
Traceback (most recent call last):
File "", line 1, in
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py",
line 228, in meth
return getattr(self._sock,name)(*args)
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py",
line 174, in _dummy
raise error(EBADF, 'Bad file descriptor')
socket.error: [Errno 9] Bad file descriptor
With this, the test failures in dispatch tests now are
89% tests passed, 6 tests failed out of 57
Total Test time (real) = 1747.39 sec
The following tests FAILED:
9 - unit_tests (SEGFAULT)
23 - system_tests_policy (Timeout)
28 - system_tests_sasl_plain (Failed)
38 - system_tests_auth_service_plugin (Failed)
39 - system_tests_authz_service_plugin (Failed)
48 - system_tests_bad_configuration (Failed)
> Support for building on macOS
> -
>
> Key: DISPATCH-1282
> URL: https://issues.apache.org/jira/browse/DISPATCH-1282
> Project: Qpid Dispatch
> Issue Type: New Feature
>Affects Versions: 1.5.0
>Reporter: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> Currently, Dispatch compilation fails on "rt" library being unavailable.
> All Dispatch dependencies (Qpid Proton, libwebsockets, ...) can be built on
> macOS.
> I am attaching a patch which allows to compile dispatch on OSX and run it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1282) Support for building on macOS
[ https://issues.apache.org/jira/browse/DISPATCH-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953239#comment-16953239 ] ASF subversion and git services commented on DISPATCH-1282: --- Commit 3db622312ecaf6b872af01c258f4687fdb5d9720 in qpid-dispatch's branch refs/heads/master from Jiri Danek [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=3db6223 ] DISPATCH-1282 - Support for building on macOS # Notes * macOS does not use -rt linker option * pthread_t on macOS is a typedef’d struct, not long * dlopen on macOS substitutes rpath for @rpath placeholder, it does not prepend it as on Linux Dispatch can be compiled and run on my macOS like this $ cmake .. -DProton_DIR=/Users/jdanek/projects/qpid-proton/build/install/lib/cmake/Proton -DCMAKE_INSTALL_PREFIX=install $ make install $ PYTHONPATH=install/lib/python2.7/site-packages/ install/sbin/qdrouterd > Support for building on macOS > - > > Key: DISPATCH-1282 > URL: https://issues.apache.org/jira/browse/DISPATCH-1282 > Project: Qpid Dispatch > Issue Type: New Feature >Affects Versions: 1.5.0 >Reporter: Jiri Daněk >Priority: Major > Labels: macOS > > Currently, Dispatch compilation fails on "rt" library being unavailable. > All Dispatch dependencies (Qpid Proton, libwebsockets, ...) can be built on > macOS. > I am attaching a patch which allows to compile dispatch on OSX and run it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1282) Support for building on macOS
[ https://issues.apache.org/jira/browse/DISPATCH-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953241#comment-16953241 ] ASF subversion and git services commented on DISPATCH-1282: --- Commit 83b4c836e94cb71156f3f9c405b66f2f65d2dbb3 in qpid-dispatch's branch refs/heads/master from Jiri Danek [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=83b4c83 ] DISPATCH-1282 - Add macOS to .travis.yml matrix # Observations - DYLD_FALLBACK_LIBRARY_PATH doesn't work on travis, see `csrutil status` - Cyrus SASL is not in Brew, it is in MacPorts, though - MacPorts require setting export COLUMNS=80` - The macOS build matrix row is set to never fail the build > Support for building on macOS > - > > Key: DISPATCH-1282 > URL: https://issues.apache.org/jira/browse/DISPATCH-1282 > Project: Qpid Dispatch > Issue Type: New Feature >Affects Versions: 1.5.0 >Reporter: Jiri Daněk >Priority: Major > Labels: macOS > > Currently, Dispatch compilation fails on "rt" library being unavailable. > All Dispatch dependencies (Qpid Proton, libwebsockets, ...) can be built on > macOS. > I am attaching a patch which allows to compile dispatch on OSX and run it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1282) Support for building on macOS
[ https://issues.apache.org/jira/browse/DISPATCH-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953221#comment-16953221 ] ASF GitHub Bot commented on DISPATCH-1282: -- jdanekrh commented on issue #459: DISPATCH-1282 - Support for building on macOS URL: https://github.com/apache/qpid-dispatch/pull/459#issuecomment-542911343 @RoddieKieley I spent some time with the build issues: python interpreter and libs detection, qpid proton python on macos, and unittest2. It turned out that I had the least issues when I installed Python 3.7 from MacPorts and put it on PATH. CMake then never failed to resolve both interpreter and libs correctly. Regarding unittest2, I put creating a virtual environment with it into .travis.yml. I think that is a reasonable way for actual users/developers to work with it. I did not find a way to get rid of the `install_name_tool -add_rpath` hack to be able to `import proton`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support for building on macOS > - > > Key: DISPATCH-1282 > URL: https://issues.apache.org/jira/browse/DISPATCH-1282 > Project: Qpid Dispatch > Issue Type: New Feature >Affects Versions: 1.5.0 >Reporter: Jiri Daněk >Priority: Major > Labels: macOS > > Currently, Dispatch compilation fails on "rt" library being unavailable. > All Dispatch dependencies (Qpid Proton, libwebsockets, ...) can be built on > macOS. > I am attaching a patch which allows to compile dispatch on OSX and run it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh commented on issue #459: DISPATCH-1282 - Support for building on macOS
jdanekrh commented on issue #459: DISPATCH-1282 - Support for building on macOS URL: https://github.com/apache/qpid-dispatch/pull/459#issuecomment-542911343 @RoddieKieley I spent some time with the build issues: python interpreter and libs detection, qpid proton python on macos, and unittest2. It turned out that I had the least issues when I installed Python 3.7 from MacPorts and put it on PATH. CMake then never failed to resolve both interpreter and libs correctly. Regarding unittest2, I put creating a virtual environment with it into .travis.yml. I think that is a reasonable way for actual users/developers to work with it. I did not find a way to get rid of the `install_name_tool -add_rpath` hack to be able to `import proton`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1411) Add timestamp and router name to header of qdstat output
[ https://issues.apache.org/jira/browse/DISPATCH-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1411. - Fix Version/s: 1.10.0 Resolution: Fixed > Add timestamp and router name to header of qdstat output > > > Key: DISPATCH-1411 > URL: https://issues.apache.org/jira/browse/DISPATCH-1411 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Labels: troubleshooting > Fix For: 1.10.0 > > > Add a timestamp and the router's id to the header of the output of qdstat. > This will allow us to correlate qdstat output with router log files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…
ganeshmurthy closed pull request #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1411) Add timestamp and router name to header of qdstat output
[ https://issues.apache.org/jira/browse/DISPATCH-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953205#comment-16953205 ] ASF subversion and git services commented on DISPATCH-1411: --- Commit b6d8bae8f8ee1337a32a5a720adc0a6def29349c in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=b6d8bae ] DISPATCH-1411 - Added UTC datetime and router id to all options of qdstat > Add timestamp and router name to header of qdstat output > > > Key: DISPATCH-1411 > URL: https://issues.apache.org/jira/browse/DISPATCH-1411 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Labels: troubleshooting > > Add a timestamp and the router's id to the header of the output of qdstat. > This will allow us to correlate qdstat output with router log files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1411) Add timestamp and router name to header of qdstat output
[ https://issues.apache.org/jira/browse/DISPATCH-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953208#comment-16953208 ] ASF GitHub Bot commented on DISPATCH-1411: -- ganeshmurthy commented on pull request #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add timestamp and router name to header of qdstat output > > > Key: DISPATCH-1411 > URL: https://issues.apache.org/jira/browse/DISPATCH-1411 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Labels: troubleshooting > > Add a timestamp and the router's id to the header of the output of qdstat. > This will allow us to correlate qdstat output with router log files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2118) connect_config_test/test_invalid fails with jsoncpp < 1.7.0
[
https://issues.apache.org/jira/browse/PROTON-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk resolved PROTON-2118.
Resolution: Fixed
> connect_config_test/test_invalid fails with jsoncpp < 1.7.0
> ---
>
> Key: PROTON-2118
> URL: https://issues.apache.org/jira/browse/PROTON-2118
> Project: Qpid Proton
> Issue Type: Test
> Components: cpp-binding
>Affects Versions: proton-c-0.29.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.30.0
>
>
> {noformat}
> 18: Test command: /usr/bin/python
> "/root/rpmbuild/BUILD/qpid-proton-0.29.0/scripts/env.py" "--"
> "PN_SASL_CONFIG_PATH=/root/rpmbuild/BUILD/qpid-proton-0.29.0/cpp/testdata/sasl-conf"
> "/root/rpmbuild/BUILD/qpid-proton-0.29.0/cpp/connect_config_test"
> 18: Test timeout computed to be: 1500
> 18: TEST: test_default_file()
> 18: TEST: test_addr()
> 18: TEST: test_invalid()
> 18: Error from reader: * Line 1, Column 2
> 18: Missing '}' or object member name
> 18: FAIL test_invalid()
> 18:
> /root/rpmbuild/BUILD/qpid-proton-0.29.0/cpp/src/connect_config_test.cpp:124:
> failed ASSERT_SUBSTRING(("Missing '}'"), e.what()) 'Missing '}'' not found in
> 'connection configuration: reader error'
> 18: TEST: test_default_connect().run()
> 18: TEST: test_almost_default_connect().run()
> 18: TEST: test_host_user_pass().run()
> 18: TEST: test_tls().run()
> 18: TEST: test_tls_default_fail().run()
> 18: TEST: test_tls_external().run()
> 18: TEST: test_tls_plain().run()
> 12/15 Test #18: cpp-connect_config_test ..***Failed0.89 sec
> {noformat}
> Seems to be caused by version of jsoncpp older than this commit which went to
> 1.7.0
> https://github.com/open-source-parsers/jsoncpp/commit/6b10ce8c0d07ea07861e82f65f17d9fd6abd658d
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2118) connect_config_test/test_invalid fails with jsoncpp < 1.7.0
[
https://issues.apache.org/jira/browse/PROTON-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated PROTON-2118:
---
Fix Version/s: proton-c-0.30.0
> connect_config_test/test_invalid fails with jsoncpp < 1.7.0
> ---
>
> Key: PROTON-2118
> URL: https://issues.apache.org/jira/browse/PROTON-2118
> Project: Qpid Proton
> Issue Type: Test
> Components: cpp-binding
>Affects Versions: proton-c-0.29.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.30.0
>
>
> {noformat}
> 18: Test command: /usr/bin/python
> "/root/rpmbuild/BUILD/qpid-proton-0.29.0/scripts/env.py" "--"
> "PN_SASL_CONFIG_PATH=/root/rpmbuild/BUILD/qpid-proton-0.29.0/cpp/testdata/sasl-conf"
> "/root/rpmbuild/BUILD/qpid-proton-0.29.0/cpp/connect_config_test"
> 18: Test timeout computed to be: 1500
> 18: TEST: test_default_file()
> 18: TEST: test_addr()
> 18: TEST: test_invalid()
> 18: Error from reader: * Line 1, Column 2
> 18: Missing '}' or object member name
> 18: FAIL test_invalid()
> 18:
> /root/rpmbuild/BUILD/qpid-proton-0.29.0/cpp/src/connect_config_test.cpp:124:
> failed ASSERT_SUBSTRING(("Missing '}'"), e.what()) 'Missing '}'' not found in
> 'connection configuration: reader error'
> 18: TEST: test_default_connect().run()
> 18: TEST: test_almost_default_connect().run()
> 18: TEST: test_host_user_pass().run()
> 18: TEST: test_tls().run()
> 18: TEST: test_tls_default_fail().run()
> 18: TEST: test_tls_external().run()
> 18: TEST: test_tls_plain().run()
> 12/15 Test #18: cpp-connect_config_test ..***Failed0.89 sec
> {noformat}
> Seems to be caused by version of jsoncpp older than this commit which went to
> 1.7.0
> https://github.com/open-source-parsers/jsoncpp/commit/6b10ce8c0d07ea07861e82f65f17d9fd6abd658d
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1452) Replace all run_qdmanage functions in system tests to use system_test.QdManager
Ganesh Murthy created DISPATCH-1452: --- Summary: Replace all run_qdmanage functions in system tests to use system_test.QdManager Key: DISPATCH-1452 URL: https://issues.apache.org/jira/browse/DISPATCH-1452 Project: Qpid Dispatch Issue Type: Improvement Components: Tests Affects Versions: 1.9.0 Reporter: Ganesh Murthy There are several run_qdmanage functions all over system tests. Replace those to use the system_test.py's Qdmanager class -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2119) [Python] Change API to better handle strings where symbols are required
[ https://issues.apache.org/jira/browse/PROTON-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kim van der Riet resolved PROTON-2119. -- Resolution: Fixed Pull request closed. > [Python] Change API to better handle strings where symbols are required > --- > > Key: PROTON-2119 > URL: https://issues.apache.org/jira/browse/PROTON-2119 > Project: Qpid Proton > Issue Type: Task > Components: python-binding >Reporter: Kim van der Riet >Priority: Major > > There are places in the Python API where the AMQP 1.0 specification requires > symbols, but the API accepts strings (and in come cases any type). Change the > API to better handle cases where strings are accepted so as to silently > "upgrade" them to symbols. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] kpvdr closed pull request #192: Changed Python API to better handle strings where symbo…
kpvdr closed pull request #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] kpvdr commented on issue #192: Changed Python API to better handle strings where symbo…
kpvdr commented on issue #192: Changed Python API to better handle strings where symbo… URL: https://github.com/apache/qpid-proton/pull/192#issuecomment-542843937 Changes squashed and merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2119) [Python] Change API to better handle strings where symbols are required
[ https://issues.apache.org/jira/browse/PROTON-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953109#comment-16953109 ] ASF subversion and git services commented on PROTON-2119: - Commit 5d9ff0017bf4a0057478a9820fd04ab8143620dd in qpid-proton's branch refs/heads/master from Kim van der Riet [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=5d9ff00 ] PROTON-2119: Added classes to better handle AMQP restricted types for symbol-only lists and dictionaries with symbol-only keys. > [Python] Change API to better handle strings where symbols are required > --- > > Key: PROTON-2119 > URL: https://issues.apache.org/jira/browse/PROTON-2119 > Project: Qpid Proton > Issue Type: Task > Components: python-binding >Reporter: Kim van der Riet >Priority: Major > > There are places in the Python API where the AMQP 1.0 specification requires > symbols, but the API accepts strings (and in come cases any type). Change the > API to better handle cases where strings are accepted so as to silently > "upgrade" them to symbols. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1445) Update saslPassword attribute in connector entity to use openssl style prefixes
[ https://issues.apache.org/jira/browse/DISPATCH-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953092#comment-16953092 ] ASF GitHub Bot commented on DISPATCH-1445: -- bhardesty commented on issue #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with … URL: https://github.com/apache/qpid-dispatch/pull/587#issuecomment-542833785 In ../docs/books/user-guide/modules/connecting-using-username-password-authentication.adoc, we show an example that uses the saslPassword attribute. It's technically still correct, but it uses the non-recommended clear text option. It might be worth changing it to use the file option, since that seems most conducive to production scenarios. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update saslPassword attribute in connector entity to use openssl style > prefixes > --- > > Key: DISPATCH-1445 > URL: https://issues.apache.org/jira/browse/DISPATCH-1445 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > Modify the saslPassword attribute of the connector entity to use env: file: > and pass: prefixes. Model this around the sslProfile's password field. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] bhardesty commented on issue #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with …
bhardesty commented on issue #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with … URL: https://github.com/apache/qpid-dispatch/pull/587#issuecomment-542833785 In ../docs/books/user-guide/modules/connecting-using-username-password-authentication.adoc, we show an example that uses the saslPassword attribute. It's technically still correct, but it uses the non-recommended clear text option. It might be worth changing it to use the file option, since that seems most conducive to production scenarios. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1445) Update saslPassword attribute in connector entity to use openssl style prefixes
[
https://issues.apache.org/jira/browse/DISPATCH-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953082#comment-16953082
]
ASF GitHub Bot commented on DISPATCH-1445:
--
bhardesty commented on pull request #587: DISPATCH-1445 - Modeled saslPassword
to be more or less in line with …
URL: https://github.com/apache/qpid-dispatch/pull/587#discussion_r335640689
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -1008,7 +1008,7 @@
"saslPassword": {
"type": "string",
"required": false,
-"description": "The password that the connector is using
to connect to a peer.",
+"description": "The password that the connector is using
to connect to a peer. Supports three prefixes namely - env:, file:, pass:.
env:var obtains the password from the environment variable var. Since the
environment of other processes is visible on certain platforms (e.g. ps under
certain Unix OSes) this option should be used with caution. file:absolutepath
obtains the password from the absolute path of the file containing the
password. This option is the safest since permissions can be set on the file.
pass:password or password with no prefix is used to directly specify the
password and should only be used where security is not important",
Review comment:
It's never easy to describe multiple values in paragraph format, but I think
this works a bit better:
The password that the connector is using to connect to a peer. You can
specify the password by specifying an environment variable that stores the
password, a file that stores the password, or by entering the password in clear
text. To use an environment variable, specify "saslPassword:
env:". Use this option with caution, because the
environment of other processes is visible on certain platforms (for example,
"ps" on certain Unix OSs). To use a file, specify "saslPassword:
file:". This option is the most secure, because
permissions can be set on the file that contains the password. To specify the
password in clear text, specify "saslPassword: pass:" or
"saslPassword: ". This option is insecure, so it should only be used
if security is not a concern.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update saslPassword attribute in connector entity to use openssl style
> prefixes
> ---
>
> Key: DISPATCH-1445
> URL: https://issues.apache.org/jira/browse/DISPATCH-1445
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.10.0
>
>
> Modify the saslPassword attribute of the connector entity to use env: file:
> and pass: prefixes. Model this around the sslProfile's password field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] bhardesty commented on a change in pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with …
bhardesty commented on a change in pull request #587: DISPATCH-1445 - Modeled
saslPassword to be more or less in line with …
URL: https://github.com/apache/qpid-dispatch/pull/587#discussion_r335640689
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -1008,7 +1008,7 @@
"saslPassword": {
"type": "string",
"required": false,
-"description": "The password that the connector is using
to connect to a peer.",
+"description": "The password that the connector is using
to connect to a peer. Supports three prefixes namely - env:, file:, pass:.
env:var obtains the password from the environment variable var. Since the
environment of other processes is visible on certain platforms (e.g. ps under
certain Unix OSes) this option should be used with caution. file:absolutepath
obtains the password from the absolute path of the file containing the
password. This option is the safest since permissions can be set on the file.
pass:password or password with no prefix is used to directly specify the
password and should only be used where security is not important",
Review comment:
It's never easy to describe multiple values in paragraph format, but I think
this works a bit better:
The password that the connector is using to connect to a peer. You can
specify the password by specifying an environment variable that stores the
password, a file that stores the password, or by entering the password in clear
text. To use an environment variable, specify "saslPassword:
env:". Use this option with caution, because the
environment of other processes is visible on certain platforms (for example,
"ps" on certain Unix OSs). To use a file, specify "saslPassword:
file:". This option is the most secure, because
permissions can be set on the file that contains the password. To specify the
password in clear text, specify "saslPassword: pass:" or
"saslPassword: ". This option is insecure, so it should only be used
if security is not a concern.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1416) Policy log could include denial counts on connection close
[ https://issues.apache.org/jira/browse/DISPATCH-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953074#comment-16953074 ] ASF GitHub Bot commented on DISPATCH-1416: -- ChugR commented on issue #572: DISPATCH-1416: Add policy denial counts to connection close log URL: https://github.com/apache/qpid-dispatch/pull/572#issuecomment-542828692 Merged at commit ff82055e This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Policy log could include denial counts on connection close > -- > > Key: DISPATCH-1416 > URL: https://issues.apache.org/jira/browse/DISPATCH-1416 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Policy Engine >Affects Versions: 1.8.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > Fix For: 1.10.0 > > > Currently the Policy module logs the number of active sessions, senders, > receivers, and nConnections(see below) on a connection when it is closed. > This list could be expanded to include the policy statistics block that > counts sessions, senders, and receiver denials. > nConnections is the current live number of total incoming connections managed > by policy and is not directly related to the current connection. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1416) Policy log could include denial counts on connection close
[ https://issues.apache.org/jira/browse/DISPATCH-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953075#comment-16953075 ] ASF GitHub Bot commented on DISPATCH-1416: -- ChugR commented on pull request #572: DISPATCH-1416: Add policy denial counts to connection close log URL: https://github.com/apache/qpid-dispatch/pull/572 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Policy log could include denial counts on connection close > -- > > Key: DISPATCH-1416 > URL: https://issues.apache.org/jira/browse/DISPATCH-1416 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Policy Engine >Affects Versions: 1.8.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > Fix For: 1.10.0 > > > Currently the Policy module logs the number of active sessions, senders, > receivers, and nConnections(see below) on a connection when it is closed. > This list could be expanded to include the policy statistics block that > counts sessions, senders, and receiver denials. > nConnections is the current live number of total incoming connections managed > by policy and is not directly related to the current connection. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR closed pull request #572: DISPATCH-1416: Add policy denial counts to connection close log
ChugR closed pull request #572: DISPATCH-1416: Add policy denial counts to connection close log URL: https://github.com/apache/qpid-dispatch/pull/572 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on issue #572: DISPATCH-1416: Add policy denial counts to connection close log
ChugR commented on issue #572: DISPATCH-1416: Add policy denial counts to connection close log URL: https://github.com/apache/qpid-dispatch/pull/572#issuecomment-542828692 Merged at commit ff82055e This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1416) Policy log could include denial counts on connection close
[ https://issues.apache.org/jira/browse/DISPATCH-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1416. - Fix Version/s: 1.10.0 Resolution: Fixed > Policy log could include denial counts on connection close > -- > > Key: DISPATCH-1416 > URL: https://issues.apache.org/jira/browse/DISPATCH-1416 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Policy Engine >Affects Versions: 1.8.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > Fix For: 1.10.0 > > > Currently the Policy module logs the number of active sessions, senders, > receivers, and nConnections(see below) on a connection when it is closed. > This list could be expanded to include the policy statistics block that > counts sessions, senders, and receiver denials. > nConnections is the current live number of total incoming connections managed > by policy and is not directly related to the current connection. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1416) Policy log could include denial counts on connection close
[ https://issues.apache.org/jira/browse/DISPATCH-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953066#comment-16953066 ] ASF subversion and git services commented on DISPATCH-1416: --- Commit ff82055ed34060e24d4a4626d3c4ba921c11bfbb in qpid-dispatch's branch refs/heads/master from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=ff82055 ] DISPATCH-1416: Add policy denial counts to connection close log > Policy log could include denial counts on connection close > -- > > Key: DISPATCH-1416 > URL: https://issues.apache.org/jira/browse/DISPATCH-1416 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Policy Engine >Affects Versions: 1.8.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > > Currently the Policy module logs the number of active sessions, senders, > receivers, and nConnections(see below) on a connection when it is closed. > This list could be expanded to include the policy statistics block that > counts sessions, senders, and receiver denials. > nConnections is the current live number of total incoming connections managed > by policy and is not directly related to the current connection. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on issue #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…
codecov-io commented on issue #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/589#issuecomment-542821238 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=h1) Report > Merging [#589](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/93ea0487ba3ec2b6d7db06815768fac8f0e8af87?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #589 +/- ## == - Coverage 86.33% 86.32% -0.02% == Files 90 90 Lines 2043720436 -1 == - Hits1764517642 -3 - Misses 2792 2794 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==) | `92.03% <0%> (-1.28%)` | :arrow_down: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `66.83% <0%> (-0.51%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.64% <0%> (-0.23%)` | :arrow_down: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j) | `86.46% <0%> (-0.13%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.97% <0%> (-0.12%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (+0.16%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `88.66% <0%> (+0.19%)` | :arrow_up: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `91.38% <0%> (+0.39%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=footer). Last update [93ea048...e498814](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1411) Add timestamp and router name to header of qdstat output
[ https://issues.apache.org/jira/browse/DISPATCH-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953059#comment-16953059 ] ASF GitHub Bot commented on DISPATCH-1411: -- codecov-io commented on issue #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/589#issuecomment-542821238 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=h1) Report > Merging [#589](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/93ea0487ba3ec2b6d7db06815768fac8f0e8af87?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #589 +/- ## == - Coverage 86.33% 86.32% -0.02% == Files 90 90 Lines 2043720436 -1 == - Hits1764517642 -3 - Misses 2792 2794 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==) | `92.03% <0%> (-1.28%)` | :arrow_down: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `66.83% <0%> (-0.51%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.64% <0%> (-0.23%)` | :arrow_down: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j) | `86.46% <0%> (-0.13%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.97% <0%> (-0.12%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (+0.16%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `88.66% <0%> (+0.19%)` | :arrow_up: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/589/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `91.38% <0%> (+0.39%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=footer). Last update [93ea048...e498814](https://codecov.io/gh/apache/qpid-dispatch/pull/589?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add timestamp and router name to header of qdstat output > > > Key: DISPATCH-1411 > URL: https://issues.apache.org/jira/browse/DISPATCH-1411 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Labels: troubleshooting > > Add a timestamp and the router's id to the header of the output of qdstat. > This will allow us to correlate qdstat output with router log files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1419) Add status to connector mgmt schema
[ https://issues.apache.org/jira/browse/DISPATCH-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953048#comment-16953048 ] ASF GitHub Bot commented on DISPATCH-1419: -- ganeshmurthy commented on pull request #566: DISPATCH-1419 - Added connectionStatus and connectionMsg fields to th… URL: https://github.com/apache/qpid-dispatch/pull/566 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add status to connector mgmt schema > --- > > Key: DISPATCH-1419 > URL: https://issues.apache.org/jira/browse/DISPATCH-1419 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > It would be very useful to be able to query a specific connector and > determine whether there is a connection triggered by that connector that is > active and if not ideally get the error message from the last connection > attempt. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #566: DISPATCH-1419 - Added connectionStatus and connectionMsg fields to th…
ganeshmurthy closed pull request #566: DISPATCH-1419 - Added connectionStatus and connectionMsg fields to th… URL: https://github.com/apache/qpid-dispatch/pull/566 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1419) Add status to connector mgmt schema
[ https://issues.apache.org/jira/browse/DISPATCH-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1419. - Fix Version/s: 1.10.0 Resolution: Fixed > Add status to connector mgmt schema > --- > > Key: DISPATCH-1419 > URL: https://issues.apache.org/jira/browse/DISPATCH-1419 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > It would be very useful to be able to query a specific connector and > determine whether there is a connection triggered by that connector that is > active and if not ideally get the error message from the last connection > attempt. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1419) Add status to connector mgmt schema
[ https://issues.apache.org/jira/browse/DISPATCH-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953046#comment-16953046 ] ASF subversion and git services commented on DISPATCH-1419: --- Commit f619309baa4353eff3f95afeb58200fb94a88ab0 in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=f619309 ] DISPATCH-1419 - Added connectionStatus and connectionMsg fields to the connector entity. These fields give more information about the state of the connection > Add status to connector mgmt schema > --- > > Key: DISPATCH-1419 > URL: https://issues.apache.org/jira/browse/DISPATCH-1419 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: Ganesh Murthy >Priority: Major > > It would be very useful to be able to query a specific connector and > determine whether there is a connection triggered by that connector that is > active and if not ideally get the error message from the last connection > attempt. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1411) Add timestamp and router name to header of qdstat output
[ https://issues.apache.org/jira/browse/DISPATCH-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953020#comment-16953020 ] ASF GitHub Bot commented on DISPATCH-1411: -- ganeshmurthy commented on pull request #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/589 …stat This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add timestamp and router name to header of qdstat output > > > Key: DISPATCH-1411 > URL: https://issues.apache.org/jira/browse/DISPATCH-1411 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Labels: troubleshooting > > Add a timestamp and the router's id to the header of the output of qdstat. > This will allow us to correlate qdstat output with router log files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…
ganeshmurthy opened a new pull request #589: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/589 …stat This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] nicob87 opened a new pull request #588: Pipeline hello world
nicob87 opened a new pull request #588: Pipeline hello world URL: https://github.com/apache/qpid-dispatch/pull/588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] nicob87 closed pull request #588: Pipeline hello world
nicob87 closed pull request #588: Pipeline hello world URL: https://github.com/apache/qpid-dispatch/pull/588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-477) update to Netty 4.1.42
[ https://issues.apache.org/jira/browse/QPIDJMS-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952957#comment-16952957 ] ASF subversion and git services commented on QPIDJMS-477: - Commit abcee37ca9ee292a6816791267e6ec783fbc8fb5 in qpid-jms's branch refs/heads/master from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-jms.git;h=abcee37 ] QPIDJMS-477: also update netty-tcnative test dep to 2.0.26 > update to Netty 4.1.42 > -- > > Key: QPIDJMS-477 > URL: https://issues.apache.org/jira/browse/QPIDJMS-477 > Project: Qpid JMS > Issue Type: Task > Components: qpid-jms-client >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 0.47.0 > > > update to Netty 4.1.42 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1445) Update saslPassword attribute in connector entity to use openssl style prefixes
[ https://issues.apache.org/jira/browse/DISPATCH-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952943#comment-16952943 ] ASF GitHub Bot commented on DISPATCH-1445: -- kgiusti commented on pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with … URL: https://github.com/apache/qpid-dispatch/pull/587#discussion_r335551241 ## File path: tests/system_tests_sasl_plain.py ## @@ -22,15 +22,31 @@ from __future__ import absolute_import from __future__ import print_function -import os -from subprocess import PIPE, Popen -from system_test import TestCase, Qdrouterd, main_module, DIR, TIMEOUT, SkipIfNeeded +import os, json +from subprocess import PIPE, STDOUT, Popen +from system_test import TestCase, Qdrouterd, main_module, DIR, TIMEOUT, SkipIfNeeded, Process from system_test import unittest from qpid_dispatch.management.client import Node from proton import SASL class RouterTestPlainSaslCommon(TestCase): +def run_qdmanage(self, cmd, input=None, expect=Process.EXIT_OK, Review comment: We've cut and pasted this code too many times. See system_test.py - class QdManager(). It wraps qdmanage and exports operations as methods. See system_tests_edge_router.py for an example. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update saslPassword attribute in connector entity to use openssl style > prefixes > --- > > Key: DISPATCH-1445 > URL: https://issues.apache.org/jira/browse/DISPATCH-1445 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > Modify the saslPassword attribute of the connector entity to use env: file: > and pass: prefixes. Model this around the sslProfile's password field. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with …
kgiusti commented on a change in pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with … URL: https://github.com/apache/qpid-dispatch/pull/587#discussion_r335551241 ## File path: tests/system_tests_sasl_plain.py ## @@ -22,15 +22,31 @@ from __future__ import absolute_import from __future__ import print_function -import os -from subprocess import PIPE, Popen -from system_test import TestCase, Qdrouterd, main_module, DIR, TIMEOUT, SkipIfNeeded +import os, json +from subprocess import PIPE, STDOUT, Popen +from system_test import TestCase, Qdrouterd, main_module, DIR, TIMEOUT, SkipIfNeeded, Process from system_test import unittest from qpid_dispatch.management.client import Node from proton import SASL class RouterTestPlainSaslCommon(TestCase): +def run_qdmanage(self, cmd, input=None, expect=Process.EXIT_OK, Review comment: We've cut and pasted this code too many times. See system_test.py - class QdManager(). It wraps qdmanage and exports operations as methods. See system_tests_edge_router.py for an example. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1441) optparse python library deprecated, migrate to argparse
[
https://issues.apache.org/jira/browse/DISPATCH-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952908#comment-16952908
]
ASF GitHub Bot commented on DISPATCH-1441:
--
codecov-io commented on issue #576: DISPATCH-1441: optparse to argparse
migration
URL: https://github.com/apache/qpid-dispatch/pull/576#issuecomment-536764810
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=h1)
Report
> Merging
[#576](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/69868bff4a867ec6ae7cd082e0246f85067744d0?src=pr&el=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=tree)
```diff
@@Coverage Diff @@
## master #576 +/- ##
==
+ Coverage 86.32% 86.33% +0.01%
==
Files 90 90
Lines 2043720437
==
+ Hits1764217645 +3
+ Misses 2795 2792 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.17% <0%> (-0.19%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.09% <0%> (+0.11%)` | :arrow_up: |
|
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j)
| `86.59% <0%> (+0.12%)` | :arrow_up: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `87.86% <0%> (+0.22%)` | :arrow_up: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `67.33% <0%> (+0.5%)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=footer).
Last update
[69868bf...93ea048](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> optparse python library deprecated, migrate to argparse
> ---
>
> Key: DISPATCH-1441
> URL: https://issues.apache.org/jira/browse/DISPATCH-1441
> Project: Qpid Dispatch
> Issue Type: New Feature
>Reporter: Nicolas
>Priority: Major
> Fix For: 1.10.0
>
>
> from: https://docs.python.org/2/library/optparse.html
> Deprecated since version 2.7: The
> [{{optparse}}|https://docs.python.org/2/library/optparse.html#module-optparse]
> module is deprecated and will not be developed further; development will
> continue with the
> [{{argparse}}|https://docs.python.org/2/library/argparse.html#module-argparse]
> module.
> A lot of the manual parsing that is being done manually is able to be done
> automatically by the argparse library. (like mutually exclusive options, etc).
> Automatic help and error messages may be better also just migrating the
> library.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #576: DISPATCH-1441: optparse to argparse migration
codecov-io edited a comment on issue #576: DISPATCH-1441: optparse to argparse migration URL: https://github.com/apache/qpid-dispatch/pull/576#issuecomment-536764810 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=h1) Report > Merging [#576](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/69868bff4a867ec6ae7cd082e0246f85067744d0?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #576 +/- ## == + Coverage 86.32% 86.33% +0.01% == Files 90 90 Lines 2043720437 == + Hits1764217645 +3 + Misses 2795 2792 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.17% <0%> (-0.19%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.09% <0%> (+0.11%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j) | `86.59% <0%> (+0.12%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.86% <0%> (+0.22%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/576/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `67.33% <0%> (+0.5%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=footer). Last update [69868bf...93ea048](https://codecov.io/gh/apache/qpid-dispatch/pull/576?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1441) optparse python library deprecated, migrate to argparse
[
https://issues.apache.org/jira/browse/DISPATCH-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-1441.
-
Fix Version/s: 1.10.0
Resolution: Fixed
> optparse python library deprecated, migrate to argparse
> ---
>
> Key: DISPATCH-1441
> URL: https://issues.apache.org/jira/browse/DISPATCH-1441
> Project: Qpid Dispatch
> Issue Type: New Feature
>Reporter: Nicolas
>Priority: Major
> Fix For: 1.10.0
>
>
> from: https://docs.python.org/2/library/optparse.html
> Deprecated since version 2.7: The
> [{{optparse}}|https://docs.python.org/2/library/optparse.html#module-optparse]
> module is deprecated and will not be developed further; development will
> continue with the
> [{{argparse}}|https://docs.python.org/2/library/argparse.html#module-argparse]
> module.
> A lot of the manual parsing that is being done manually is able to be done
> automatically by the argparse library. (like mutually exclusive options, etc).
> Automatic help and error messages may be better also just migrating the
> library.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1441) optparse python library deprecated, migrate to argparse
[
https://issues.apache.org/jira/browse/DISPATCH-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952894#comment-16952894
]
ASF subversion and git services commented on DISPATCH-1441:
---
Commit 93ea0487ba3ec2b6d7db06815768fac8f0e8af87 in qpid-dispatch's branch
refs/heads/master from Nicolas Brignone
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=93ea048 ]
DISPATCH-1441: optparse to argparse migration.
Readme also updated.
Some unittests created for the parsing.
All refactor is related to the library migration, as many features from argparse
as possible have been used.
> optparse python library deprecated, migrate to argparse
> ---
>
> Key: DISPATCH-1441
> URL: https://issues.apache.org/jira/browse/DISPATCH-1441
> Project: Qpid Dispatch
> Issue Type: New Feature
>Reporter: Nicolas
>Priority: Major
>
> from: https://docs.python.org/2/library/optparse.html
> Deprecated since version 2.7: The
> [{{optparse}}|https://docs.python.org/2/library/optparse.html#module-optparse]
> module is deprecated and will not be developed further; development will
> continue with the
> [{{argparse}}|https://docs.python.org/2/library/argparse.html#module-argparse]
> module.
> A lot of the manual parsing that is being done manually is able to be done
> automatically by the argparse library. (like mutually exclusive options, etc).
> Automatic help and error messages may be better also just migrating the
> library.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1441) optparse python library deprecated, migrate to argparse
[
https://issues.apache.org/jira/browse/DISPATCH-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952895#comment-16952895
]
ASF GitHub Bot commented on DISPATCH-1441:
--
asfgit commented on pull request #576: DISPATCH-1441: optparse to argparse
migration
URL: https://github.com/apache/qpid-dispatch/pull/576
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> optparse python library deprecated, migrate to argparse
> ---
>
> Key: DISPATCH-1441
> URL: https://issues.apache.org/jira/browse/DISPATCH-1441
> Project: Qpid Dispatch
> Issue Type: New Feature
>Reporter: Nicolas
>Priority: Major
>
> from: https://docs.python.org/2/library/optparse.html
> Deprecated since version 2.7: The
> [{{optparse}}|https://docs.python.org/2/library/optparse.html#module-optparse]
> module is deprecated and will not be developed further; development will
> continue with the
> [{{argparse}}|https://docs.python.org/2/library/argparse.html#module-argparse]
> module.
> A lot of the manual parsing that is being done manually is able to be done
> automatically by the argparse library. (like mutually exclusive options, etc).
> Automatic help and error messages may be better also just migrating the
> library.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit merged pull request #576: DISPATCH-1441: optparse to argparse migration
asfgit merged pull request #576: DISPATCH-1441: optparse to argparse migration URL: https://github.com/apache/qpid-dispatch/pull/576 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1411) Add timestamp and router name to header of qdstat output
[ https://issues.apache.org/jira/browse/DISPATCH-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952882#comment-16952882 ] ASF GitHub Bot commented on DISPATCH-1411: -- ganeshmurthy commented on pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add timestamp and router name to header of qdstat output > > > Key: DISPATCH-1411 > URL: https://issues.apache.org/jira/browse/DISPATCH-1411 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ganesh Murthy >Priority: Major > Labels: troubleshooting > > Add a timestamp and the router's id to the header of the output of qdstat. > This will allow us to correlate qdstat output with router log files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd…
ganeshmurthy closed pull request #586: DISPATCH-1411 - Added UTC datetime and router id to all options of qd… URL: https://github.com/apache/qpid-dispatch/pull/586 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on issue #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with …
codecov-io commented on issue #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with … URL: https://github.com/apache/qpid-dispatch/pull/587#issuecomment-542705429 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=h1) Report > Merging [#587](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/69868bff4a867ec6ae7cd082e0246f85067744d0?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #587 +/- ## == + Coverage 86.32% 86.33% +0.01% == Files 90 90 Lines 2043720445 +8 == + Hits1764217651 +9 + Misses 2795 2794 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/587/diff?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `92.02% <100%> (+0.53%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/587/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `88.27% <0%> (-0.2%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/587/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.86% <0%> (-0.12%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/587/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (-0.02%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/587/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.86% <0%> (+0.22%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=footer). Last update [69868bf...f93cd27](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1445) Update saslPassword attribute in connector entity to use openssl style prefixes
[ https://issues.apache.org/jira/browse/DISPATCH-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952832#comment-16952832 ] ASF GitHub Bot commented on DISPATCH-1445: -- codecov-io commented on issue #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with … URL: https://github.com/apache/qpid-dispatch/pull/587#issuecomment-542705429 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=h1) Report > Merging [#587](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/69868bff4a867ec6ae7cd082e0246f85067744d0?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #587 +/- ## == + Coverage 86.32% 86.33% +0.01% == Files 90 90 Lines 2043720445 +8 == + Hits1764217651 +9 + Misses 2795 2794 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/587/diff?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `92.02% <100%> (+0.53%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/587/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `88.27% <0%> (-0.2%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/587/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.86% <0%> (-0.12%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/587/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (-0.02%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/587/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.86% <0%> (+0.22%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=footer). Last update [69868bf...f93cd27](https://codecov.io/gh/apache/qpid-dispatch/pull/587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update saslPassword attribute in connector entity to use openssl style > prefixes > --- > > Key: DISPATCH-1445 > URL: https://issues.apache.org/jira/browse/DISPATCH-1445 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > Modify the saslPassword attribute of the connector entity to use env: file: > and pass: prefixes. Model this around the sslProfile's password field. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2119) [Python] Change API to better handle strings where symbols are required
[ https://issues.apache.org/jira/browse/PROTON-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952825#comment-16952825 ] ASF subversion and git services commented on PROTON-2119: - Commit 5d9ff0017bf4a0057478a9820fd04ab8143620dd in qpid-proton's branch refs/heads/PROTON-2119 from Kim van der Riet [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=5d9ff00 ] PROTON-2119: Added classes to better handle AMQP restricted types for symbol-only lists and dictionaries with symbol-only keys. > [Python] Change API to better handle strings where symbols are required > --- > > Key: PROTON-2119 > URL: https://issues.apache.org/jira/browse/PROTON-2119 > Project: Qpid Proton > Issue Type: Task > Components: python-binding >Reporter: Kim van der Riet >Priority: Major > > There are places in the Python API where the AMQP 1.0 specification requires > symbols, but the API accepts strings (and in come cases any type). Change the > API to better handle cases where strings are accepted so as to silently > "upgrade" them to symbols. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
