[jira] [Commented] (DISPATCH-1415) qdstat does not show process memory usage
[ https://issues.apache.org/jira/browse/DISPATCH-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035778#comment-17035778 ] ASF GitHub Bot commented on DISPATCH-1415: -- codecov-io commented on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric URL: https://github.com/apache/qpid-dispatch/pull/680#issuecomment-585394446 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=h1) Report > Merging [#680](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/b282a284d6853acd14386f33a60d8b079dec93ec?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #680 +/- ## == - Coverage 86.83% 86.81% -0.02% == Files 92 92 Lines 2104721069 +22 == + Hits1827718292 +15 - Misses 2770 2777 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `91.2% <100%> (+0.19%)` | :arrow_up: | | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2Rpc3BhdGNoLmM=) | `83.8% <90%> (+0.65%)` | :arrow_up: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `79.94% <0%> (-0.59%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.41% <0%> (-0.49%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.58% <0%> (-0.34%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.24% <0%> (ø)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.36% <0%> (+0.18%)` | :arrow_up: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.35% <0%> (+0.18%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=footer). Last update [b282a28...7ffdc61](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > qdstat does not show process memory usage > - > > Key: DISPATCH-1415 > URL: https://issues.apache.org/jira/browse/DISPATCH-1415 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Management Agent >Affects Versions: 1.8.0 >Reporter: Charles E. Rolke >Assignee: Ken Giusti >Priority: Major > Labels: troubleshooting > > *qdstat -m* shows managed memory usage but it does not show qdrouterd process > memory usage. An improvement would be to display process memory usage > somewhere via qdstat. > Often a memory leak (DISPATCH-1407) will be in objects not held in managed > memory. In these cases memory usage may grow unbounded but not be visible by > qdstat. > A new line or three could be added to qdstat -g or a new switch could be > added to qdstat. Good values to show are the standard columns from top: VI
[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
codecov-io edited a comment on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric URL: https://github.com/apache/qpid-dispatch/pull/680#issuecomment-585394446 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=h1) Report > Merging [#680](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/b282a284d6853acd14386f33a60d8b079dec93ec?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #680 +/- ## == - Coverage 86.83% 86.81% -0.02% == Files 92 92 Lines 2104721069 +22 == + Hits1827718292 +15 - Misses 2770 2777 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `91.2% <100%> (+0.19%)` | :arrow_up: | | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2Rpc3BhdGNoLmM=) | `83.8% <90%> (+0.65%)` | :arrow_up: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `79.94% <0%> (-0.59%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.41% <0%> (-0.49%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.58% <0%> (-0.34%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.24% <0%> (ø)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.36% <0%> (+0.18%)` | :arrow_up: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.35% <0%> (+0.18%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=footer). Last update [b282a28...7ffdc61](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2180) [python binding] on_released called when delivery is MODIFIED
Charles E. Rolke created PROTON-2180:
Summary: [python binding] on_released called when delivery is
MODIFIED
Key: PROTON-2180
URL: https://issues.apache.org/jira/browse/PROTON-2180
Project: Qpid Proton
Issue Type: Bug
Components: python-binding
Affects Versions: proton-c-0.28.0
Reporter: Charles E. Rolke
Reproducer:
qpid-dispatch self test system_tests_multicast: test_63_unsettled_3ack_outcomes
Description:
qpid-dispatch test code has an on_released method in class MulticastBase. The
comments are dated April 2, 2019 so the issue has been in play since then:
{quote}{color:#80}def {color}on_released({color:#94558d}self{color}, event):
{color:#808080}# for some reason Proton 'helpfully' calls on_released even
though the
{color}{color:#808080} # delivery state is actually MODIFIED
{color} {color:#80}if {color}event.delivery.remote_state ==
Delivery.MODIFIED:
{color:#80}return
{color}{color:#94558d}self{color}.on_modified(event)
{quote}
The self test today triggers the if statement six times on every run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1415) qdstat does not show process memory usage
[
https://issues.apache.org/jira/browse/DISPATCH-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035751#comment-17035751
]
ASF GitHub Bot commented on DISPATCH-1415:
--
ganeshmurthy commented on pull request #680: DISPATCH-1415, DISPATCH-1569: add
process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378371077
##
File path: tools/qdstat.in
##
@@ -325,6 +333,13 @@ class BusManager(Node):
rows.append(('Uptime',TimeLong(router.uptimeSeconds)))
except:
pass
+try:
Review comment:
Should this show in the output of qdstat -m instead of qdstat -g ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> qdstat does not show process memory usage
> -
>
> Key: DISPATCH-1415
> URL: https://issues.apache.org/jira/browse/DISPATCH-1415
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Management Agent
>Affects Versions: 1.8.0
>Reporter: Charles E. Rolke
>Assignee: Ken Giusti
>Priority: Major
> Labels: troubleshooting
>
> *qdstat -m* shows managed memory usage but it does not show qdrouterd process
> memory usage. An improvement would be to display process memory usage
> somewhere via qdstat.
> Often a memory leak (DISPATCH-1407) will be in objects not held in managed
> memory. In these cases memory usage may grow unbounded but not be visible by
> qdstat.
> A new line or three could be added to qdstat -g or a new switch could be
> added to qdstat. Good values to show are the standard columns from top: VIRT,
> RES, and SHR.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1415) qdstat does not show process memory usage
[
https://issues.apache.org/jira/browse/DISPATCH-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035750#comment-17035750
]
ASF GitHub Bot commented on DISPATCH-1415:
--
ganeshmurthy commented on pull request #680: DISPATCH-1415, DISPATCH-1569: add
process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378372489
##
File path: src/dispatch.c
##
@@ -379,3 +379,50 @@ void qd_dispatch_router_unlock(qd_dispatch_t *qd) {
sys_mutex_unlock(qd->router-
qdr_core_t* qd_dispatch_router_core(qd_dispatch_t *qd) {
return qd->router->router_core;
}
+
+
+/* qd_router_memory_usage
+ *
+ * Return the amount of memory currently provisioned by the qdrouterd process.
+ * This includes data, stack, and code memory. On systems supporting virtual
+ * memory this value may be larger than the physical RAM available on the
+ * platform.
+ *
+ * Return 0 if the memory usage cannot be determined.
+ */
+uint64_t qd_router_memory_usage()
+{
+// @TODO(kgiusti): only works for linux (what? doesn't everyone run linux?)
+
+// parse the VmSize value out of the /proc/[pid]/status file
+const pid_t my_pid = getpid();
+const char *status_template = "/proc/%ld/status";
+char status_path[64];
+if (snprintf(status_path, 64, status_template, (long int)my_pid) >= 64) {
Review comment:
Should we used the safe_snprintf instead of snprintf ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> qdstat does not show process memory usage
> -
>
> Key: DISPATCH-1415
> URL: https://issues.apache.org/jira/browse/DISPATCH-1415
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Management Agent
>Affects Versions: 1.8.0
>Reporter: Charles E. Rolke
>Assignee: Ken Giusti
>Priority: Major
> Labels: troubleshooting
>
> *qdstat -m* shows managed memory usage but it does not show qdrouterd process
> memory usage. An improvement would be to display process memory usage
> somewhere via qdstat.
> Often a memory leak (DISPATCH-1407) will be in objects not held in managed
> memory. In these cases memory usage may grow unbounded but not be visible by
> qdstat.
> A new line or three could be added to qdstat -g or a new switch could be
> added to qdstat. Good values to show are the standard columns from top: VIRT,
> RES, and SHR.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
ganeshmurthy commented on a change in pull request #680: DISPATCH-1415,
DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378372489
##
File path: src/dispatch.c
##
@@ -379,3 +379,50 @@ void qd_dispatch_router_unlock(qd_dispatch_t *qd) {
sys_mutex_unlock(qd->router-
qdr_core_t* qd_dispatch_router_core(qd_dispatch_t *qd) {
return qd->router->router_core;
}
+
+
+/* qd_router_memory_usage
+ *
+ * Return the amount of memory currently provisioned by the qdrouterd process.
+ * This includes data, stack, and code memory. On systems supporting virtual
+ * memory this value may be larger than the physical RAM available on the
+ * platform.
+ *
+ * Return 0 if the memory usage cannot be determined.
+ */
+uint64_t qd_router_memory_usage()
+{
+// @TODO(kgiusti): only works for linux (what? doesn't everyone run linux?)
+
+// parse the VmSize value out of the /proc/[pid]/status file
+const pid_t my_pid = getpid();
+const char *status_template = "/proc/%ld/status";
+char status_path[64];
+if (snprintf(status_path, 64, status_template, (long int)my_pid) >= 64) {
Review comment:
Should we used the safe_snprintf instead of snprintf ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
ganeshmurthy commented on a change in pull request #680: DISPATCH-1415,
DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378371077
##
File path: tools/qdstat.in
##
@@ -325,6 +333,13 @@ class BusManager(Node):
rows.append(('Uptime',TimeLong(router.uptimeSeconds)))
except:
pass
+try:
Review comment:
Should this show in the output of qdstat -m instead of qdstat -g ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)
[
https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035702#comment-17035702
]
ASF GitHub Bot commented on DISPATCH-1564:
--
ganeshmurthy commented on pull request #681: DISPATCH-1564 - Modified the way
ulong is displayed on the output of …
URL: https://github.com/apache/qpid-dispatch/pull/681
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Two system tests fail on Fedora 32(fedora:rawhide)
> --
>
> Key: DISPATCH-1564
> URL: https://issues.apache.org/jira/browse/DISPATCH-1564
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 1.10.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 22: Test command: /usr/bin/python "/main/qpid-dispatch/build/tests/run.py"
> "-m" "unittest" "-v" "system_tests_default_distribution"
> 22: Test timeout computed to be: 600
> 22: test_anonymous_sender
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_create_unavailable_receiver
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_create_unavailable_sender
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_general (system_tests_default_distribution.DefaultDistributionTest)
> ... FAIL
> 22:
> 22: ==
> 22: FAIL: test_general
> (system_tests_default_distribution.DefaultDistributionTest)
> 22: --
> 22: Traceback (most recent call last):
> 22: File "/main/qpid-dispatch/tests/system_tests_default_distribution.py",
> line 83, in test_general
> 22: self.assertTrue("Connections 1" in out)
> 22: AssertionError: False is not true
> {noformat}
> Another test failure
>
> {noformat}
> 28: Test command: /usr/bin/python "/main/qpid-dispatch/build/tests/run.py"
> "-m" "unittest" "-v" "system_tests_qdstat"
> 28: Test timeout computed to be: 600
> 28: test_all_entities (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_all_entities_all_routers
> (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_all_entities_all_routers_csv
> (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_all_entities_csv (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_link_priority (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_link_priority_csv (system_tests_qdstat.QdstatLinkPriorityTest) ...
> ERROR
> 28: test_links_all_routers (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_links_all_routers_csv (system_tests_qdstat.QdstatLinkPriorityTest)
> ... ok
> 28: test_ssl_cert_to_auth_fail_no_sasl_external
> (system_tests_qdstat.QdstatSslNoExternalTest) ... ok
> 28: test_ssl_trustfile_cert_to_auth_fail_no_sasl_external
> (system_tests_qdstat.QdstatSslNoExternalTest) ... ok
> 28: test_ssl_bad_trustfile_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_bad_trustfile_to_strict (system_tests_qdstat.QdstatSslTest) ...
> ok
> 28: test_ssl_bad_trustfile_to_unsecured (system_tests_qdstat.QdstatSslTest)
> ... ok
> 28: test_ssl_cert_explicit_external_to_auth
> (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_none (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_strict (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_unsecured (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none_to_strict (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none_to_unsecured (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_schema_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_schema_to_strict (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_schema_to_unsecured (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_scheme_to_none (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_trustfile_cert_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_trustfile_cert_to_strict (system_tests_qdstat.QdstatSslTest) ...
> ok
> 28: test_ssl_trustfile_cert_to_unsecured (system_tests_qdstat.QdstatSslTest)
> ... ok
> 28: test_ssl_trustfile_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_
[GitHub] [qpid-dispatch] codecov-io commented on issue #681: DISPATCH-1564 - Modified the way ulong is displayed on the output of …
codecov-io commented on issue #681: DISPATCH-1564 - Modified the way ulong is displayed on the output of … URL: https://github.com/apache/qpid-dispatch/pull/681#issuecomment-585411494 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/681?src=pr&el=h1) Report > Merging [#681](https://codecov.io/gh/apache/qpid-dispatch/pull/681?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/a56b28ccb1b552c5b2dc0872dcde1fa09c725cab?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/681?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #681 +/- ## == + Coverage 86.89% 86.89% +<.01% == Files 92 92 Lines 2104721046 -1 == Hits1828818288 + Misses 2759 2758 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/681?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/681/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.58% <0%> (-0.34%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/681/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.65% <0%> (-0.25%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/681/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.8% <0%> (-0.23%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/681/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.9% <0%> (+0.09%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/681/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.36% <0%> (+0.11%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/681/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `95.17% <0%> (+0.45%)` | :arrow_up: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/681/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `80.52% <0%> (+0.58%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/681?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/681?src=pr&el=footer). Last update [a56b28c...f65c805](https://codecov.io/gh/apache/qpid-dispatch/pull/681?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #681: DISPATCH-1564 - Modified the way ulong is displayed on the output of …
ganeshmurthy closed pull request #681: DISPATCH-1564 - Modified the way ulong is displayed on the output of … URL: https://github.com/apache/qpid-dispatch/pull/681 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)
[
https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035700#comment-17035700
]
ASF GitHub Bot commented on DISPATCH-1564:
--
codecov-io commented on issue #681: DISPATCH-1564 - Modified the way ulong is
displayed on the output of …
URL: https://github.com/apache/qpid-dispatch/pull/681#issuecomment-585411494
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/681?src=pr&el=h1)
Report
> Merging
[#681](https://codecov.io/gh/apache/qpid-dispatch/pull/681?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/a56b28ccb1b552c5b2dc0872dcde1fa09c725cab?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/681?src=pr&el=tree)
```diff
@@Coverage Diff @@
## master #681 +/- ##
==
+ Coverage 86.89% 86.89% +<.01%
==
Files 92 92
Lines 2104721046 -1
==
Hits1828818288
+ Misses 2759 2758 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/681?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/681/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `93.58% <0%> (-0.34%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/681/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.65% <0%> (-0.25%)` | :arrow_down: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/681/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `87.8% <0%> (-0.23%)` | :arrow_down: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/681/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `90.9% <0%> (+0.09%)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/681/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.36% <0%> (+0.11%)` | :arrow_up: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/681/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `95.17% <0%> (+0.45%)` | :arrow_up: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/681/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `80.52% <0%> (+0.58%)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/681?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/681?src=pr&el=footer).
Last update
[a56b28c...f65c805](https://codecov.io/gh/apache/qpid-dispatch/pull/681?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Two system tests fail on Fedora 32(fedora:rawhide)
> --
>
> Key: DISPATCH-1564
> URL: https://issues.apache.org/jira/browse/DISPATCH-1564
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 1.10.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 22: Test command: /usr/bin/python "/main/qpid-dispatch/build/tests/run.py"
> "-m" "unittest" "-v" "system_tests_default_distribution"
> 22: Test timeout computed to be: 600
> 22: test_anonymous_sender
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_create_unavailable_receiver
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_create_unavailable_sender
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_general (system_tests_default_distribution.DefaultDistributionTest)
> ... FAIL
> 22:
> 22: ==
> 22: FAIL: test
[GitHub] [qpid-dispatch] codecov-io commented on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
codecov-io commented on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric URL: https://github.com/apache/qpid-dispatch/pull/680#issuecomment-585394446 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=h1) Report > Merging [#680](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/b282a284d6853acd14386f33a60d8b079dec93ec?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #680 +/- ## == + Coverage 86.83% 86.86% +0.02% == Files 92 92 Lines 2104721069 +22 == + Hits1827718301 +24 + Misses 2770 2768 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `91.2% <100%> (+0.19%)` | :arrow_up: | | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2Rpc3BhdGNoLmM=) | `83.8% <90%> (+0.65%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.17% <0%> (-0.74%)` | :arrow_down: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `79.94% <0%> (-0.59%)` | :arrow_down: | | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `91.41% <0%> (-0.38%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.58% <0%> (-0.34%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.8% <0%> (-0.23%)` | :arrow_down: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j) | `86.63% <0%> (-0.13%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.12% <0%> (-0.12%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.36% <0%> (+0.18%)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=footer). Last update [b282a28...7694b99](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1415) qdstat does not show process memory usage
[ https://issues.apache.org/jira/browse/DISPATCH-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035673#comment-17035673 ] ASF GitHub Bot commented on DISPATCH-1415: -- codecov-io commented on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric URL: https://github.com/apache/qpid-dispatch/pull/680#issuecomment-585394446 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=h1) Report > Merging [#680](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/b282a284d6853acd14386f33a60d8b079dec93ec?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #680 +/- ## == + Coverage 86.83% 86.86% +0.02% == Files 92 92 Lines 2104721069 +22 == + Hits1827718301 +24 + Misses 2770 2768 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `91.2% <100%> (+0.19%)` | :arrow_up: | | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2Rpc3BhdGNoLmM=) | `83.8% <90%> (+0.65%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.17% <0%> (-0.74%)` | :arrow_down: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `79.94% <0%> (-0.59%)` | :arrow_down: | | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `91.41% <0%> (-0.38%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.58% <0%> (-0.34%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.8% <0%> (-0.23%)` | :arrow_down: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j) | `86.63% <0%> (-0.13%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.12% <0%> (-0.12%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.36% <0%> (+0.18%)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=footer). Last update [b282a28...7694b99](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > qdstat does not show process memory usage > - > > Key: DISPATCH-1415 > URL: https://issues.apache.org/jira/browse/DISPATCH-1415 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Management Agent >Affects Versions: 1.8.0 >Reporter: Charles E. Rolke >Assignee: Ken Giusti >Priority: Major > Labels: troubleshooting > > *qdstat -m* shows ma
[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
ganeshmurthy commented on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric URL: https://github.com/apache/qpid-dispatch/pull/680#issuecomment-585374303 Please push commits one by one so we can see the diff between each commit. You can squash all the commits before committing to master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1415) qdstat does not show process memory usage
[ https://issues.apache.org/jira/browse/DISPATCH-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035640#comment-17035640 ] ASF GitHub Bot commented on DISPATCH-1415: -- ganeshmurthy commented on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric URL: https://github.com/apache/qpid-dispatch/pull/680#issuecomment-585374303 Please push commits one by one so we can see the diff between each commit. You can squash all the commits before committing to master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > qdstat does not show process memory usage > - > > Key: DISPATCH-1415 > URL: https://issues.apache.org/jira/browse/DISPATCH-1415 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Management Agent >Affects Versions: 1.8.0 >Reporter: Charles E. Rolke >Assignee: Ken Giusti >Priority: Major > Labels: troubleshooting > > *qdstat -m* shows managed memory usage but it does not show qdrouterd process > memory usage. An improvement would be to display process memory usage > somewhere via qdstat. > Often a memory leak (DISPATCH-1407) will be in objects not held in managed > memory. In these cases memory usage may grow unbounded but not be visible by > qdstat. > A new line or three could be added to qdstat -g or a new switch could be > added to qdstat. Good values to show are the standard columns from top: VIRT, > RES, and SHR. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #681: DISPATCH-1564 - Modified the way ulong is displayed on the output of …
ganeshmurthy opened a new pull request #681: DISPATCH-1564 - Modified the way ulong is displayed on the output of … URL: https://github.com/apache/qpid-dispatch/pull/681 …qdstat This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)
[
https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035626#comment-17035626
]
ASF GitHub Bot commented on DISPATCH-1564:
--
ganeshmurthy commented on pull request #681: DISPATCH-1564 - Modified the way
ulong is displayed on the output of …
URL: https://github.com/apache/qpid-dispatch/pull/681
…qdstat
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Two system tests fail on Fedora 32(fedora:rawhide)
> --
>
> Key: DISPATCH-1564
> URL: https://issues.apache.org/jira/browse/DISPATCH-1564
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 1.10.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 22: Test command: /usr/bin/python "/main/qpid-dispatch/build/tests/run.py"
> "-m" "unittest" "-v" "system_tests_default_distribution"
> 22: Test timeout computed to be: 600
> 22: test_anonymous_sender
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_create_unavailable_receiver
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_create_unavailable_sender
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_general (system_tests_default_distribution.DefaultDistributionTest)
> ... FAIL
> 22:
> 22: ==
> 22: FAIL: test_general
> (system_tests_default_distribution.DefaultDistributionTest)
> 22: --
> 22: Traceback (most recent call last):
> 22: File "/main/qpid-dispatch/tests/system_tests_default_distribution.py",
> line 83, in test_general
> 22: self.assertTrue("Connections 1" in out)
> 22: AssertionError: False is not true
> {noformat}
> Another test failure
>
> {noformat}
> 28: Test command: /usr/bin/python "/main/qpid-dispatch/build/tests/run.py"
> "-m" "unittest" "-v" "system_tests_qdstat"
> 28: Test timeout computed to be: 600
> 28: test_all_entities (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_all_entities_all_routers
> (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_all_entities_all_routers_csv
> (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_all_entities_csv (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_link_priority (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_link_priority_csv (system_tests_qdstat.QdstatLinkPriorityTest) ...
> ERROR
> 28: test_links_all_routers (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_links_all_routers_csv (system_tests_qdstat.QdstatLinkPriorityTest)
> ... ok
> 28: test_ssl_cert_to_auth_fail_no_sasl_external
> (system_tests_qdstat.QdstatSslNoExternalTest) ... ok
> 28: test_ssl_trustfile_cert_to_auth_fail_no_sasl_external
> (system_tests_qdstat.QdstatSslNoExternalTest) ... ok
> 28: test_ssl_bad_trustfile_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_bad_trustfile_to_strict (system_tests_qdstat.QdstatSslTest) ...
> ok
> 28: test_ssl_bad_trustfile_to_unsecured (system_tests_qdstat.QdstatSslTest)
> ... ok
> 28: test_ssl_cert_explicit_external_to_auth
> (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_none (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_strict (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_unsecured (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none_to_strict (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none_to_unsecured (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_schema_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_schema_to_strict (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_schema_to_unsecured (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_scheme_to_none (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_trustfile_cert_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_trustfile_cert_to_strict (system_tests_qdstat.QdstatSslTest) ...
> ok
> 28: test_ssl_trustfile_cert_to_unsecured (system_tests_qdstat.QdstatSslTest)
> ... ok
> 28: test_ssl_trustfile_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28
[jira] [Commented] (QPIDJMS-490) Update slf4j to latest point release 1.7.30
[ https://issues.apache.org/jira/browse/QPIDJMS-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035627#comment-17035627 ] ASF subversion and git services commented on QPIDJMS-490: - Commit 63c15af8fef7969e25a193df8374246b4ad294eb in qpid-jms's branch refs/heads/master from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-jms.git;h=63c15af ] QPIDJMS-490 Update to slf4j 1.7.30 patch release > Update slf4j to latest point release 1.7.30 > --- > > Key: QPIDJMS-490 > URL: https://issues.apache.org/jira/browse/QPIDJMS-490 > Project: Qpid JMS > Issue Type: Task > Components: qpid-jms-client >Affects Versions: 0.48.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: 0.49.0 > > > Update the slf4j binding dependency to latest point release v1.7.30 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPIDJMS-490) Update slf4j to latest point release 1.7.30
Timothy A. Bish created QPIDJMS-490: --- Summary: Update slf4j to latest point release 1.7.30 Key: QPIDJMS-490 URL: https://issues.apache.org/jira/browse/QPIDJMS-490 Project: Qpid JMS Issue Type: Task Components: qpid-jms-client Affects Versions: 0.48.0 Reporter: Timothy A. Bish Assignee: Timothy A. Bish Fix For: 0.49.0 Update the slf4j binding dependency to latest point release v1.7.30 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPIDJMS-489) Update test dependencies
[ https://issues.apache.org/jira/browse/QPIDJMS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy A. Bish resolved QPIDJMS-489. - Resolution: Fixed > Update test dependencies > > > Key: QPIDJMS-489 > URL: https://issues.apache.org/jira/browse/QPIDJMS-489 > Project: Qpid JMS > Issue Type: Task > Components: qpid-jms-client >Affects Versions: 0.48.0 >Reporter: Timothy A. Bish >Priority: Minor > Fix For: 0.49.0 > > > Update ActiveMQ, JUnit, Jacoco and Mockito dependencies to latest patch > releases -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPIDJMS-489) Update test dependencies
[ https://issues.apache.org/jira/browse/QPIDJMS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy A. Bish updated QPIDJMS-489: Description: Update ActiveMQ, JUnit, Jacoco and Mockito dependencies to latest patch releases (was: Update JUnit and Mockito dependencies to latest patch releases) > Update test dependencies > > > Key: QPIDJMS-489 > URL: https://issues.apache.org/jira/browse/QPIDJMS-489 > Project: Qpid JMS > Issue Type: Task > Components: qpid-jms-client >Affects Versions: 0.48.0 >Reporter: Timothy A. Bish >Priority: Minor > Fix For: 0.49.0 > > > Update ActiveMQ, JUnit, Jacoco and Mockito dependencies to latest patch > releases -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-489) Update test dependencies
[ https://issues.apache.org/jira/browse/QPIDJMS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035621#comment-17035621 ] ASF subversion and git services commented on QPIDJMS-489: - Commit 8e2551a30d6876ae6224faa80a13126c59addb4d in qpid-jms's branch refs/heads/master from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-jms.git;h=8e2551a ] QPIDJMS-489 Update test dependencies to latest Junit, ActiveMQ, Mockito and Jacoco updates to latest point releases. > Update test dependencies > > > Key: QPIDJMS-489 > URL: https://issues.apache.org/jira/browse/QPIDJMS-489 > Project: Qpid JMS > Issue Type: Task > Components: qpid-jms-client >Affects Versions: 0.48.0 >Reporter: Timothy A. Bish >Priority: Minor > Fix For: 0.49.0 > > > Update JUnit and Mockito dependencies to latest patch releases -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPIDJMS-489) Update test dependencies
Timothy A. Bish created QPIDJMS-489: --- Summary: Update test dependencies Key: QPIDJMS-489 URL: https://issues.apache.org/jira/browse/QPIDJMS-489 Project: Qpid JMS Issue Type: Task Components: qpid-jms-client Affects Versions: 0.48.0 Reporter: Timothy A. Bish Fix For: 0.49.0 Update JUnit and Mockito dependencies to latest patch releases -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1572) Monitor the router's utilization of physical memory
Ken Giusti created DISPATCH-1572: Summary: Monitor the router's utilization of physical memory Key: DISPATCH-1572 URL: https://issues.apache.org/jira/browse/DISPATCH-1572 Project: Qpid Dispatch Issue Type: New Feature Components: Routing Engine, Tools Affects Versions: 1.10.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: Backlog This feature adds the ability for the router to monitor its provisioned VmSize verses the available physical memory. This feature can be used to detect when the system is running low on available memory. Steps can then be taken to limit the growth of memory (e.g. stop accepting client connections) or alert the user. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-485) AmqpJmsBytesMessageFacade does not copy the content-type
[ https://issues.apache.org/jira/browse/QPIDJMS-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035540#comment-17035540 ] ASF GitHub Bot commented on QPIDJMS-485: gemmellr commented on issue #34: QPIDJMS-485: copy of AMQP bytes message includes the content type URL: https://github.com/apache/qpid-jms/pull/34#issuecomment-585324499 I have made a different change via https://github.com/apache/qpid-jms/commit/a39599e376c82421e3e200188f46d3a652c4f63d to cover this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > AmqpJmsBytesMessageFacade does not copy the content-type > > > Key: QPIDJMS-485 > URL: https://issues.apache.org/jira/browse/QPIDJMS-485 > Project: Qpid JMS > Issue Type: Bug > Components: qpid-jms-client >Affects Versions: 0.48.0 >Reporter: Jens Kordowski >Priority: Major > > AmqpJmsBytesMessageFacade hardcodes the content-type during the > copy-operation to application/octet-stream > > Proposal to copy the content-type as well (in the AmqpJmsMessageFacade) and > fall-back to application/octet-stream if no content-type was set > > I don't see any reason, why the content-type is not copied as well -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-jms] gemmellr commented on issue #34: QPIDJMS-485: copy of AMQP bytes message includes the content type
gemmellr commented on issue #34: QPIDJMS-485: copy of AMQP bytes message includes the content type URL: https://github.com/apache/qpid-jms/pull/34#issuecomment-585324499 I have made a different change via https://github.com/apache/qpid-jms/commit/a39599e376c82421e3e200188f46d3a652c4f63d to cover this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-485) AmqpJmsBytesMessageFacade does not copy the content-type
[ https://issues.apache.org/jira/browse/QPIDJMS-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035525#comment-17035525 ] ASF subversion and git services commented on QPIDJMS-485: - Commit a39599e376c82421e3e200188f46d3a652c4f63d in qpid-jms's branch refs/heads/master from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-jms.git;h=a39599e ] QPIDJMS-485: move bytes message facade content-type handling to onSend, have copy simply copy > AmqpJmsBytesMessageFacade does not copy the content-type > > > Key: QPIDJMS-485 > URL: https://issues.apache.org/jira/browse/QPIDJMS-485 > Project: Qpid JMS > Issue Type: Bug > Components: qpid-jms-client >Affects Versions: 0.48.0 >Reporter: Jens Kordowski >Priority: Major > > AmqpJmsBytesMessageFacade hardcodes the content-type during the > copy-operation to application/octet-stream > > Proposal to copy the content-type as well (in the AmqpJmsMessageFacade) and > fall-back to application/octet-stream if no content-type was set > > I don't see any reason, why the content-type is not copied as well -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)
[
https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy reassigned DISPATCH-1564:
---
Assignee: Ganesh Murthy
> Two system tests fail on Fedora 32(fedora:rawhide)
> --
>
> Key: DISPATCH-1564
> URL: https://issues.apache.org/jira/browse/DISPATCH-1564
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 1.10.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 22: Test command: /usr/bin/python "/main/qpid-dispatch/build/tests/run.py"
> "-m" "unittest" "-v" "system_tests_default_distribution"
> 22: Test timeout computed to be: 600
> 22: test_anonymous_sender
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_create_unavailable_receiver
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_create_unavailable_sender
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_general (system_tests_default_distribution.DefaultDistributionTest)
> ... FAIL
> 22:
> 22: ==
> 22: FAIL: test_general
> (system_tests_default_distribution.DefaultDistributionTest)
> 22: --
> 22: Traceback (most recent call last):
> 22: File "/main/qpid-dispatch/tests/system_tests_default_distribution.py",
> line 83, in test_general
> 22: self.assertTrue("Connections 1" in out)
> 22: AssertionError: False is not true
> {noformat}
> Another test failure
>
> {noformat}
> 28: Test command: /usr/bin/python "/main/qpid-dispatch/build/tests/run.py"
> "-m" "unittest" "-v" "system_tests_qdstat"
> 28: Test timeout computed to be: 600
> 28: test_all_entities (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_all_entities_all_routers
> (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_all_entities_all_routers_csv
> (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_all_entities_csv (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_link_priority (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_link_priority_csv (system_tests_qdstat.QdstatLinkPriorityTest) ...
> ERROR
> 28: test_links_all_routers (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_links_all_routers_csv (system_tests_qdstat.QdstatLinkPriorityTest)
> ... ok
> 28: test_ssl_cert_to_auth_fail_no_sasl_external
> (system_tests_qdstat.QdstatSslNoExternalTest) ... ok
> 28: test_ssl_trustfile_cert_to_auth_fail_no_sasl_external
> (system_tests_qdstat.QdstatSslNoExternalTest) ... ok
> 28: test_ssl_bad_trustfile_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_bad_trustfile_to_strict (system_tests_qdstat.QdstatSslTest) ...
> ok
> 28: test_ssl_bad_trustfile_to_unsecured (system_tests_qdstat.QdstatSslTest)
> ... ok
> 28: test_ssl_cert_explicit_external_to_auth
> (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_none (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_strict (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_unsecured (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none_to_strict (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none_to_unsecured (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_schema_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_schema_to_strict (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_schema_to_unsecured (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_scheme_to_none (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_trustfile_cert_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_trustfile_cert_to_strict (system_tests_qdstat.QdstatSslTest) ...
> ok
> 28: test_ssl_trustfile_cert_to_unsecured (system_tests_qdstat.QdstatSslTest)
> ... ok
> 28: test_ssl_trustfile_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_trustfile_to_strict (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_trustfile_to_unsecured (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_bad_trustfile_to_auth
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_bad_trustfile_to_strict
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_bad_trustfile_to_unsecured
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_cert_explicit_external_to_auth
> (system_tests_qdstat.Qdstat
[jira] [Updated] (PROTON-2179) Include exception cause when String parse fails
[ https://issues.apache.org/jira/browse/PROTON-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-2179: --- Fix Version/s: proton-j-0.34.0 > Include exception cause when String parse fails > --- > > Key: PROTON-2179 > URL: https://issues.apache.org/jira/browse/PROTON-2179 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.2 > Environment: Broker: apache-artemis-2.11.0, apache-artemis-2.9.0 > Client: qpid-jms 0.48.0 >Reporter: Stefan Kinzel >Priority: Trivial > Fix For: proton-j-0.34.0 > > Attachments: artemis-cannot-parse-string-stacktrace.txt > > > These exceptions appear sporadically while sending Text-Messages (JSON) from > a qpid-jms-client to an apache artemis message-broker. They can not be > reproduced using the same message: A second attempt mostly works. > A stacktrace is attached. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2179) Include exception cause when String parse fails
[ https://issues.apache.org/jira/browse/PROTON-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved PROTON-2179. Resolution: Fixed > Include exception cause when String parse fails > --- > > Key: PROTON-2179 > URL: https://issues.apache.org/jira/browse/PROTON-2179 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.2 > Environment: Broker: apache-artemis-2.11.0, apache-artemis-2.9.0 > Client: qpid-jms 0.48.0 >Reporter: Stefan Kinzel >Priority: Trivial > Fix For: proton-j-0.34.0 > > Attachments: artemis-cannot-parse-string-stacktrace.txt > > > These exceptions appear sporadically while sending Text-Messages (JSON) from > a qpid-jms-client to an apache artemis message-broker. They can not be > reproduced using the same message: A second attempt mostly works. > A stacktrace is attached. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2179) Include exception cause when String parse fails
[ https://issues.apache.org/jira/browse/PROTON-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035519#comment-17035519 ] Robbie Gemmell commented on PROTON-2179: If the same message doesn't produce the same issue consistently, it seems more likely that the issue isnt proton-j but in the broker (or client). The exception being thrown is based on an originating failure from a CharsetDecoder rather than in proton-j itself and so suggests an issue with the delivery payload, or perhaps how it is being accessed in the broker. Without any any more detail on the payload there is little to look at in proton-j itself currently. Having the exception carry its actual cause would be useful though, and I have just made that change. Perhaps you can try using that in your env to see if it aids your diagnosis. Similarly you might try looking at the message payload actually sent+received (e.g inspect with wireshark) to observe that its as expected. > Include exception cause when String parse fails > --- > > Key: PROTON-2179 > URL: https://issues.apache.org/jira/browse/PROTON-2179 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.2 > Environment: Broker: apache-artemis-2.11.0, apache-artemis-2.9.0 > Client: qpid-jms 0.48.0 >Reporter: Stefan Kinzel >Priority: Trivial > Attachments: artemis-cannot-parse-string-stacktrace.txt > > > These exceptions appear sporadically while sending Text-Messages (JSON) from > a qpid-jms-client to an apache artemis message-broker. They can not be > reproduced using the same message: A second attempt mostly works. > A stacktrace is attached. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2179) Include exception cause when String parse fails
[ https://issues.apache.org/jira/browse/PROTON-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-2179: --- Priority: Trivial (was: Major) Summary: Include exception cause when String parse fails (was: IllegalArgumentException: Cannot parse String) > Include exception cause when String parse fails > --- > > Key: PROTON-2179 > URL: https://issues.apache.org/jira/browse/PROTON-2179 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.2 > Environment: Broker: apache-artemis-2.11.0, apache-artemis-2.9.0 > Client: qpid-jms 0.48.0 >Reporter: Stefan Kinzel >Priority: Trivial > Attachments: artemis-cannot-parse-string-stacktrace.txt > > > These exceptions appear sporadically while sending Text-Messages (JSON) from > a qpid-jms-client to an apache artemis message-broker. They can not be > reproduced using the same message: A second attempt mostly works. > A stacktrace is attached. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2179) IllegalArgumentException: Cannot parse String
[ https://issues.apache.org/jira/browse/PROTON-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035514#comment-17035514 ] ASF subversion and git services commented on PROTON-2179: - Commit a4ff2bc0a5f493a93d22ce8cdea7acb236aefdae in qpid-proton-j's branch refs/heads/master from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-proton-j.git;h=a4ff2bc ] PROTON-2179: pass the cause exception when throwing the IAE > IllegalArgumentException: Cannot parse String > - > > Key: PROTON-2179 > URL: https://issues.apache.org/jira/browse/PROTON-2179 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.2 > Environment: Broker: apache-artemis-2.11.0, apache-artemis-2.9.0 > Client: qpid-jms 0.48.0 >Reporter: Stefan Kinzel >Priority: Major > Attachments: artemis-cannot-parse-string-stacktrace.txt > > > These exceptions appear sporadically while sending Text-Messages (JSON) from > a qpid-jms-client to an apache artemis message-broker. They can not be > reproduced using the same message: A second attempt mostly works. > A stacktrace is attached. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-488) update to Netty 4.1.45
[ https://issues.apache.org/jira/browse/QPIDJMS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035502#comment-17035502 ] ASF subversion and git services commented on QPIDJMS-488: - Commit e80a5ef6dd7129a4f55b1e85ff5f117072e6d778 in qpid-jms's branch refs/heads/master from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-jms.git;h=e80a5ef ] QPIDJMS-488: update to Netty 4.1.45 > update to Netty 4.1.45 > -- > > Key: QPIDJMS-488 > URL: https://issues.apache.org/jira/browse/QPIDJMS-488 > Project: Qpid JMS > Issue Type: Task > Components: qpid-jms-client >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 0.49.0 > > > update to Netty 4.1.45 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-488) update to Netty 4.1.45
[ https://issues.apache.org/jira/browse/QPIDJMS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035503#comment-17035503 ] ASF subversion and git services commented on QPIDJMS-488: - Commit 458489ac08d0af0bd2a0025fc71c6c9c2906a290 in qpid-jms's branch refs/heads/master from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-jms.git;h=458489a ] QPIDJMS-488: also update test dep netty-tcnative-boringssl-static to 2.0.28 > update to Netty 4.1.45 > -- > > Key: QPIDJMS-488 > URL: https://issues.apache.org/jira/browse/QPIDJMS-488 > Project: Qpid JMS > Issue Type: Task > Components: qpid-jms-client >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 0.49.0 > > > update to Netty 4.1.45 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPIDJMS-488) update to Netty 4.1.45
Robbie Gemmell created QPIDJMS-488: -- Summary: update to Netty 4.1.45 Key: QPIDJMS-488 URL: https://issues.apache.org/jira/browse/QPIDJMS-488 Project: Qpid JMS Issue Type: Task Components: qpid-jms-client Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 0.49.0 update to Netty 4.1.45 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1415) qdstat does not show process memory usage
[
https://issues.apache.org/jira/browse/DISPATCH-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035489#comment-17035489
]
ASF GitHub Bot commented on DISPATCH-1415:
--
ChugR commented on pull request #680: DISPATCH-1415, DISPATCH-1569: add process
memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378355488
##
File path: tools/qdstat.in
##
@@ -728,6 +743,17 @@ class BusManager(Node):
dispRows = sorter.getSorted()
disp.formattedTable(title, heads, dispRows)
+# attempt to get the qdrouterd process memory usage
+# this may not be present on all platforms
+try:
+objects = self.query('org.apache.qpid.dispatch.router',
['memoryUsage'])
+mem = objects[0].memoryUsage
+except Exception:
+mem = 0
+
+if mem != 0:
+print("\nProcess memory usage: %s" % self._mem_as_mb_str(mem))
Review comment:
This doesn't print the MB unit specifier as in the -g table
This doesn't quote the values when --csv is in effect. I'd expect "Process
memory usage:","520.2 MB" in that case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> qdstat does not show process memory usage
> -
>
> Key: DISPATCH-1415
> URL: https://issues.apache.org/jira/browse/DISPATCH-1415
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Management Agent
>Affects Versions: 1.8.0
>Reporter: Charles E. Rolke
>Assignee: Ken Giusti
>Priority: Major
> Labels: troubleshooting
>
> *qdstat -m* shows managed memory usage but it does not show qdrouterd process
> memory usage. An improvement would be to display process memory usage
> somewhere via qdstat.
> Often a memory leak (DISPATCH-1407) will be in objects not held in managed
> memory. In these cases memory usage may grow unbounded but not be visible by
> qdstat.
> A new line or three could be added to qdstat -g or a new switch could be
> added to qdstat. Good values to show are the standard columns from top: VIRT,
> RES, and SHR.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
ChugR commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569:
add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378355488
##
File path: tools/qdstat.in
##
@@ -728,6 +743,17 @@ class BusManager(Node):
dispRows = sorter.getSorted()
disp.formattedTable(title, heads, dispRows)
+# attempt to get the qdrouterd process memory usage
+# this may not be present on all platforms
+try:
+objects = self.query('org.apache.qpid.dispatch.router',
['memoryUsage'])
+mem = objects[0].memoryUsage
+except Exception:
+mem = 0
+
+if mem != 0:
+print("\nProcess memory usage: %s" % self._mem_as_mb_str(mem))
Review comment:
This doesn't print the MB unit specifier as in the -g table
This doesn't quote the values when --csv is in effect. I'd expect "Process
memory usage:","520.2 MB" in that case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1415) qdstat does not show process memory usage
[
https://issues.apache.org/jira/browse/DISPATCH-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035484#comment-17035484
]
ASF GitHub Bot commented on DISPATCH-1415:
--
ChugR commented on pull request #680: DISPATCH-1415, DISPATCH-1569: add process
memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378351698
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -614,7 +614,12 @@
"type": "integer",
"graph": true,
"description": "The number of seconds since the router was
started."
-}
+},
+"memoryUsage": {
+"type": "integer",
+"graph": true,
+"description": "The current amount of memory in use by the
qdrouterd process in bytes. This includes memory provisioned for stack, data,
and code. This value is set to zero if the platform does not provide access to
the process memory size."
Review comment:
Could mention that the value corresponds to 'VmSize'.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> qdstat does not show process memory usage
> -
>
> Key: DISPATCH-1415
> URL: https://issues.apache.org/jira/browse/DISPATCH-1415
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Management Agent
>Affects Versions: 1.8.0
>Reporter: Charles E. Rolke
>Assignee: Ken Giusti
>Priority: Major
> Labels: troubleshooting
>
> *qdstat -m* shows managed memory usage but it does not show qdrouterd process
> memory usage. An improvement would be to display process memory usage
> somewhere via qdstat.
> Often a memory leak (DISPATCH-1407) will be in objects not held in managed
> memory. In these cases memory usage may grow unbounded but not be visible by
> qdstat.
> A new line or three could be added to qdstat -g or a new switch could be
> added to qdstat. Good values to show are the standard columns from top: VIRT,
> RES, and SHR.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
ChugR commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569:
add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378351698
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -614,7 +614,12 @@
"type": "integer",
"graph": true,
"description": "The number of seconds since the router was
started."
-}
+},
+"memoryUsage": {
+"type": "integer",
+"graph": true,
+"description": "The current amount of memory in use by the
qdrouterd process in bytes. This includes memory provisioned for stack, data,
and code. This value is set to zero if the platform does not provide access to
the process memory size."
Review comment:
Could mention that the value corresponds to 'VmSize'.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
kgiusti opened a new pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric URL: https://github.com/apache/qpid-dispatch/pull/680 Adding Ssorj as this patch surfaces a new management entity (memoryUsage) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1415) qdstat does not show process memory usage
[ https://issues.apache.org/jira/browse/DISPATCH-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035458#comment-17035458 ] ASF GitHub Bot commented on DISPATCH-1415: -- kgiusti commented on pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric URL: https://github.com/apache/qpid-dispatch/pull/680 Adding Ssorj as this patch surfaces a new management entity (memoryUsage) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > qdstat does not show process memory usage > - > > Key: DISPATCH-1415 > URL: https://issues.apache.org/jira/browse/DISPATCH-1415 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Management Agent >Affects Versions: 1.8.0 >Reporter: Charles E. Rolke >Assignee: Ken Giusti >Priority: Major > Labels: troubleshooting > > *qdstat -m* shows managed memory usage but it does not show qdrouterd process > memory usage. An improvement would be to display process memory usage > somewhere via qdstat. > Often a memory leak (DISPATCH-1407) will be in objects not held in managed > memory. In these cases memory usage may grow unbounded but not be visible by > qdstat. > A new line or three could be added to qdstat -g or a new switch could be > added to qdstat. Good values to show are the standard columns from top: VIRT, > RES, and SHR. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1571) Ability to retreive only certain type of link and connection
Gordon Sim created DISPATCH-1571: Summary: Ability to retreive only certain type of link and connection Key: DISPATCH-1571 URL: https://issues.apache.org/jira/browse/DISPATCH-1571 Project: Qpid Dispatch Issue Type: Improvement Reporter: Gordon Sim E.g. just inter-router links/connections or router-control links. In cases with large numbers of links or connections this would make simple checks more efficient. Could be a generic filtering capability or even just some specific calls for the different subtypes -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2179) IllegalArgumentException: Cannot parse String
Stefan Kinzel created PROTON-2179: - Summary: IllegalArgumentException: Cannot parse String Key: PROTON-2179 URL: https://issues.apache.org/jira/browse/PROTON-2179 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: proton-j-0.33.2 Environment: Broker: apache-artemis-2.11.0, apache-artemis-2.9.0 Client: qpid-jms 0.48.0 Reporter: Stefan Kinzel Attachments: artemis-cannot-parse-string-stacktrace.txt These exceptions appear sporadically while sending Text-Messages (JSON) from a qpid-jms-client to an apache artemis message-broker. They can not be reproduced using the same message: A second attempt mostly works. A stacktrace is attached. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1518) Add ability to turn on router trace logging for a specific connection
[ https://issues.apache.org/jira/browse/DISPATCH-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035364#comment-17035364 ] ASF GitHub Bot commented on DISPATCH-1518: -- ganeshmurthy commented on issue #676: DISPATCH-1518: Added ability to turn on protocol frame trace logging … URL: https://github.com/apache/qpid-dispatch/pull/676#issuecomment-585214485 @kgiusti @ChugR I have added a new commit to this PR which addresses your code review comments. Please take a look and comment This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add ability to turn on router trace logging for a specific connection > -- > > Key: DISPATCH-1518 > URL: https://issues.apache.org/jira/browse/DISPATCH-1518 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.11.0 > > > It would be nice to be able to turn on tracing per connection, e.g. something > like `qdmanage update --type=connection id=897644 tracing=true` > That way you could benefit from protocol level tracing on connections of > interest as and when needed. Perhaps also there could be some way of > specifying a policy for connection tracing, e.g. all connections whose > container id is 'foo' or who are connecting from 192.666.555.444 or similar. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #676: DISPATCH-1518: Added ability to turn on protocol frame trace logging …
ganeshmurthy commented on issue #676: DISPATCH-1518: Added ability to turn on protocol frame trace logging … URL: https://github.com/apache/qpid-dispatch/pull/676#issuecomment-585214485 @kgiusti @ChugR I have added a new commit to this PR which addresses your code review comments. Please take a look and comment This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1415) qdstat does not show process memory usage
[ https://issues.apache.org/jira/browse/DISPATCH-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned DISPATCH-1415: Assignee: Ken Giusti (was: Ganesh Murthy) > qdstat does not show process memory usage > - > > Key: DISPATCH-1415 > URL: https://issues.apache.org/jira/browse/DISPATCH-1415 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Management Agent >Affects Versions: 1.8.0 >Reporter: Charles E. Rolke >Assignee: Ken Giusti >Priority: Major > Labels: troubleshooting > > *qdstat -m* shows managed memory usage but it does not show qdrouterd process > memory usage. An improvement would be to display process memory usage > somewhere via qdstat. > Often a memory leak (DISPATCH-1407) will be in objects not held in managed > memory. In these cases memory usage may grow unbounded but not be visible by > qdstat. > A new line or three could be added to qdstat -g or a new switch could be > added to qdstat. Good values to show are the standard columns from top: VIRT, > RES, and SHR. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1566) safe_snpritf is not safe.
[
https://issues.apache.org/jira/browse/DISPATCH-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035318#comment-17035318
]
ASF GitHub Bot commented on DISPATCH-1566:
--
nicob87 commented on issue #679: DISPATCH-1566: fix safe_snptrintf
URL: https://github.com/apache/qpid-dispatch/pull/679#issuecomment-584812640
Test error is only in the RelWithDebInfo build, and it is in the tear down,
If I am not wrong it is not related to this pr.
```
51: ==
51: ERROR: tearDownClass (system_tests_edge_router.LinkRouteProxyTest)
51: --
51: Traceback (most recent call last):
51: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
line 691, in tearDownClass
51: cls.tester.teardown()
51: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
line 637, in teardown
51: raise RuntimeError("Errors during teardown: \n\n%s" %
"\n\n".join([str(e) for e in errors]))
51: RuntimeError: Errors during teardown:
51:
51: Process 14088 error: exit code 23, expected 0
51: qdrouterd -c EB1.conf -I /home/travis/build/apache/qpid-dispatch/python
51:
/home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_edge_router/LinkRouteProxyTest/setUpClass/EB1-8.cmd
51:
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> safe_snpritf is not safe.
> -
>
> Key: DISPATCH-1566
> URL: https://issues.apache.org/jira/browse/DISPATCH-1566
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.10.0
>Reporter: Nicolas
>Priority: Major
> Fix For: 1.11.0
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> {{/* */}}
> {{static inline int safe_snprintf(char *str, size_t size, const char *format,
> ...)}}
> {{{ }}{{}}}
> This function fails for size = 0, and ... inside it calls vsnprintf, without
> considering that in case of error vsnprintf returns a negative number.
> PR in progress.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] nicob87 removed a comment on issue #679: DISPATCH-1566: fix safe_snptrintf
nicob87 removed a comment on issue #679: DISPATCH-1566: fix safe_snptrintf
URL: https://github.com/apache/qpid-dispatch/pull/679#issuecomment-584812640
Test error is only in the RelWithDebInfo build, and it is in the tear down,
If I am not wrong it is not related to this pr.
```
51: ==
51: ERROR: tearDownClass (system_tests_edge_router.LinkRouteProxyTest)
51: --
51: Traceback (most recent call last):
51: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
line 691, in tearDownClass
51: cls.tester.teardown()
51: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
line 637, in teardown
51: raise RuntimeError("Errors during teardown: \n\n%s" %
"\n\n".join([str(e) for e in errors]))
51: RuntimeError: Errors during teardown:
51:
51: Process 14088 error: exit code 23, expected 0
51: qdrouterd -c EB1.conf -I /home/travis/build/apache/qpid-dispatch/python
51:
/home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_edge_router/LinkRouteProxyTest/setUpClass/EB1-8.cmd
51:
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
