[jira] [Updated] (PROTON-2255) [proton-c] unexpected incoming-window in begin frame when running Dispatch test in 32 bit system
[
https://issues.apache.org/jira/browse/PROTON-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell updated PROTON-2255:
---
Summary: [proton-c] unexpected incoming-window in begin frame when running
Dispatch test in 32 bit system (was: [proton-c] invalid incoming-window in
begin frame when running Dispatch test in 32 bit system)
> [proton-c] unexpected incoming-window in begin frame when running Dispatch
> test in 32 bit system
>
>
> Key: PROTON-2255
> URL: https://issues.apache.org/jira/browse/PROTON-2255
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.31.0
>Reporter: Ganesh Murthy
>Priority: Major
>
> system_tests_protocol_settings fails in Dispatch with the following error
>
> {noformat}
> ==
> FAIL: test_connector_default
> (system_tests_protocol_settings.ConnectorSettingsDefaultTest)
> --
> Traceback (most recent call last):
> File
> "/home/jenkins/workspace/rh-qpid-dispatch-dist-el6-32-master/build/BUILD/qpid-dispatch-1.13.0/tests/system_tests_protocol_settings.py",
> line 343, in test_connector_default
> self.assertTrue(" incoming-window=2147483647," in begin_lines[0])
> AssertionError: False is not True
> ==
> FAIL: test_max_frame_max_session_zero
> (system_tests_protocol_settings.MaxFrameMaxSessionFramesZeroTest)
> --
> Traceback (most recent call last):
> File
> "/home/jenkins/workspace/rh-qpid-dispatch-dist-el6-32-master/build/BUILD/qpid-dispatch-1.13.0/tests/system_tests_protocol_settings.py",
> line 287, in test_max_frame_max_session_zero
> self.assertTrue(" incoming-window=2147483647," in begin_lines[0])
> AssertionError: False is not True
> ==
> FAIL: test_max_session_frames_default
> (system_tests_protocol_settings.MaxSessionFramesDefaultTest)
> --
> Traceback (most recent call last):
> File
> "/home/jenkins/workspace/rh-qpid-dispatch-dist-el6-32-master/build/BUILD/qpid-dispatch-1.13.0/tests/system_tests_protocol_settings.py",
> line 249, in test_max_session_frames_default
> self.assertTrue(" incoming-window=2147483647," in begin_lines[0])
> AssertionError: False is not True {noformat}
>
> The actual line in the log is
> {noformat}
> 2020-07-30 12:47:53.727396 -0400 PROTOCOL (trace) [3]:FRAME: 0 <-
> @begin(17) [next-outgoing-id=0, incoming-window=131071,
> outgoing-window=2147483647]
> (/root/project/build/BUILD/qpid-dispatch-1.13.0/src/server.c:112) {noformat}
>
> The test is expecting to see the incoming-window to be 2147483647 but instead
> gets 131071.
> This could be a possible issue with the way the incoming-window is logged but
> really not sure.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2255) [proton-c] unexpected incoming-window in begin frame when running Dispatch test in 32 bit system
[
https://issues.apache.org/jira/browse/PROTON-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170654#comment-17170654
]
Robbie Gemmell commented on PROTON-2255:
Tweaked the title as the frame log does not look to be 'invalid', just rather
unexpected as it appears to show a different behaviour, on the wire or in the
logging, where no difference would be expected.
Small note: the log line is presumably from the first test failure assert, as
it looks to be going in the wrong direction for the other tests (though they
may still have such a log output, arriving from the client side, as both could
be affected by an issue in proton).
> [proton-c] unexpected incoming-window in begin frame when running Dispatch
> test in 32 bit system
>
>
> Key: PROTON-2255
> URL: https://issues.apache.org/jira/browse/PROTON-2255
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.31.0
>Reporter: Ganesh Murthy
>Priority: Major
>
> system_tests_protocol_settings fails in Dispatch with the following error
>
> {noformat}
> ==
> FAIL: test_connector_default
> (system_tests_protocol_settings.ConnectorSettingsDefaultTest)
> --
> Traceback (most recent call last):
> File
> "/home/jenkins/workspace/rh-qpid-dispatch-dist-el6-32-master/build/BUILD/qpid-dispatch-1.13.0/tests/system_tests_protocol_settings.py",
> line 343, in test_connector_default
> self.assertTrue(" incoming-window=2147483647," in begin_lines[0])
> AssertionError: False is not True
> ==
> FAIL: test_max_frame_max_session_zero
> (system_tests_protocol_settings.MaxFrameMaxSessionFramesZeroTest)
> --
> Traceback (most recent call last):
> File
> "/home/jenkins/workspace/rh-qpid-dispatch-dist-el6-32-master/build/BUILD/qpid-dispatch-1.13.0/tests/system_tests_protocol_settings.py",
> line 287, in test_max_frame_max_session_zero
> self.assertTrue(" incoming-window=2147483647," in begin_lines[0])
> AssertionError: False is not True
> ==
> FAIL: test_max_session_frames_default
> (system_tests_protocol_settings.MaxSessionFramesDefaultTest)
> --
> Traceback (most recent call last):
> File
> "/home/jenkins/workspace/rh-qpid-dispatch-dist-el6-32-master/build/BUILD/qpid-dispatch-1.13.0/tests/system_tests_protocol_settings.py",
> line 249, in test_max_session_frames_default
> self.assertTrue(" incoming-window=2147483647," in begin_lines[0])
> AssertionError: False is not True {noformat}
>
> The actual line in the log is
> {noformat}
> 2020-07-30 12:47:53.727396 -0400 PROTOCOL (trace) [3]:FRAME: 0 <-
> @begin(17) [next-outgoing-id=0, incoming-window=131071,
> outgoing-window=2147483647]
> (/root/project/build/BUILD/qpid-dispatch-1.13.0/src/server.c:112) {noformat}
>
> The test is expecting to see the incoming-window to be 2147483647 but instead
> gets 131071.
> This could be a possible issue with the way the incoming-window is logged but
> really not sure.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (QPID-8427) [Broker-J] Housekeeping task threw StackOverflowError
[
https://issues.apache.org/jira/browse/QPID-8427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Vavricka closed QPID-8427.
Fix Version/s: qpid-java-broker-7.1.7
Resolution: Implemented
> [Broker-J] Housekeeping task threw StackOverflowError
> -
>
> Key: QPID-8427
> URL: https://issues.apache.org/jira/browse/QPID-8427
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.1.5
>Reporter: Tomas Vavricka
>Priority: Major
> Fix For: qpid-java-broker-7.1.7
>
>
> Broker crashed when performing housekeeping task.
> {noformat}
> 2020-03-10 20:14:41,539 ERROR [virtualhost-default-pool-1]
> (o.a.q.s.u.HousekeepingExecutor) - Housekeeping task threw an exception:
> java.lang.StackOverflowError: null
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> ...
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8427) [Broker-J] Housekeeping task threw StackOverflowError
[
https://issues.apache.org/jira/browse/QPID-8427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170718#comment-17170718
]
Tomas Vavricka commented on QPID-8427:
--
It looks like it. Issue was not reproduced in v8.0.0 so far. I close this Jira
as it is not relevant anymore.
> [Broker-J] Housekeeping task threw StackOverflowError
> -
>
> Key: QPID-8427
> URL: https://issues.apache.org/jira/browse/QPID-8427
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.1.5
>Reporter: Tomas Vavricka
>Priority: Major
>
> Broker crashed when performing housekeeping task.
> {noformat}
> 2020-03-10 20:14:41,539 ERROR [virtualhost-default-pool-1]
> (o.a.q.s.u.HousekeepingExecutor) - Housekeeping task threw an exception:
> java.lang.StackOverflowError: null
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> ...
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> at
> org.apache.qpid.server.util.StateChangeListenerEntry.add(StateChangeListenerEntry.java:57)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2255) [proton-c] unexpected incoming-window in begin frame when running Dispatch test in 32 bit system
[
https://issues.apache.org/jira/browse/PROTON-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170750#comment-17170750
]
Charles E. Rolke commented on PROTON-2255:
--
It would be good to know exactly what went over the wire independent of what
Proton says in a trace log. Proton is the most authoritative AMQP decoder I
know of. But in this environment a verification would help assess if there is
or is not a Proton issue here.
> [proton-c] unexpected incoming-window in begin frame when running Dispatch
> test in 32 bit system
>
>
> Key: PROTON-2255
> URL: https://issues.apache.org/jira/browse/PROTON-2255
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.31.0
>Reporter: Ganesh Murthy
>Priority: Major
>
> system_tests_protocol_settings fails in Dispatch with the following error
>
> {noformat}
> ==
> FAIL: test_connector_default
> (system_tests_protocol_settings.ConnectorSettingsDefaultTest)
> --
> Traceback (most recent call last):
> File
> "/home/jenkins/workspace/rh-qpid-dispatch-dist-el6-32-master/build/BUILD/qpid-dispatch-1.13.0/tests/system_tests_protocol_settings.py",
> line 343, in test_connector_default
> self.assertTrue(" incoming-window=2147483647," in begin_lines[0])
> AssertionError: False is not True
> ==
> FAIL: test_max_frame_max_session_zero
> (system_tests_protocol_settings.MaxFrameMaxSessionFramesZeroTest)
> --
> Traceback (most recent call last):
> File
> "/home/jenkins/workspace/rh-qpid-dispatch-dist-el6-32-master/build/BUILD/qpid-dispatch-1.13.0/tests/system_tests_protocol_settings.py",
> line 287, in test_max_frame_max_session_zero
> self.assertTrue(" incoming-window=2147483647," in begin_lines[0])
> AssertionError: False is not True
> ==
> FAIL: test_max_session_frames_default
> (system_tests_protocol_settings.MaxSessionFramesDefaultTest)
> --
> Traceback (most recent call last):
> File
> "/home/jenkins/workspace/rh-qpid-dispatch-dist-el6-32-master/build/BUILD/qpid-dispatch-1.13.0/tests/system_tests_protocol_settings.py",
> line 249, in test_max_session_frames_default
> self.assertTrue(" incoming-window=2147483647," in begin_lines[0])
> AssertionError: False is not True {noformat}
>
> The actual line in the log is
> {noformat}
> 2020-07-30 12:47:53.727396 -0400 PROTOCOL (trace) [3]:FRAME: 0 <-
> @begin(17) [next-outgoing-id=0, incoming-window=131071,
> outgoing-window=2147483647]
> (/root/project/build/BUILD/qpid-dispatch-1.13.0/src/server.c:112) {noformat}
>
> The test is expecting to see the incoming-window to be 2147483647 but instead
> gets 131071.
> This could be a possible issue with the way the incoming-window is logged but
> really not sure.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8458) [Broker-J] Remove RewriteServlet from HTTP management
Tomas Vavricka created QPID-8458: Summary: [Broker-J] Remove RewriteServlet from HTTP management Key: QPID-8458 URL: https://issues.apache.org/jira/browse/QPID-8458 Project: Qpid Issue Type: Improvement Components: Broker-J Affects Versions: qpid-java-broker-9.0.0 Reporter: Tomas Vavricka RewriteServlet can be removed and api docs paths without / at the end can be handled by ApiDocsServlet. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] vavrtom opened a new pull request #53: [Broker-J] Remove RewriteServlet from HTTP management
vavrtom opened a new pull request #53: URL: https://github.com/apache/qpid-broker-j/pull/53 Implementation of https://issues.apache.org/jira/browse/QPID-8458. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8458) [Broker-J] Remove RewriteServlet from HTTP management
[ https://issues.apache.org/jira/browse/QPID-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Vavricka updated QPID-8458: - Description: RewriteServlet can be removed and api docs paths without '/' at the end can be handled by ApiDocsServlet. was: RewriteServlet can be removed and api docs paths without / at the end can be handled by ApiDocsServlet. > [Broker-J] Remove RewriteServlet from HTTP management > - > > Key: QPID-8458 > URL: https://issues.apache.org/jira/browse/QPID-8458 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-9.0.0 >Reporter: Tomas Vavricka >Priority: Minor > > RewriteServlet can be removed and api docs paths without '/' at the end can > be handled by ApiDocsServlet. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1728) Enforce SASL dependency in build metadata
[ https://issues.apache.org/jira/browse/DISPATCH-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170840#comment-17170840 ] Ganesh Murthy commented on DISPATCH-1728: - The router tests (for example system_tests_sasl_plain.py) uses a proton python binding function called SASL.extended() (which in turn calls pn_sasl_extended()) to skip the tests like seen here - [https://github.com/apache/qpid-dispatch/blob/master/tests/system_tests_sasl_plain.py#L80] In Proton, in the cases where SASL libraries are not available, the cyrus_stub.c is included as seen here [https://github.com/apache/qpid-proton/blob/master/c/CMakeLists.txt#L100] In the case here [https://gist.github.com/ssorj/80b79856ee233aab2067c88f967273f6] since proton is directly installed, the SASL.extended() returns true and the Dispatch tests start executing. [~jross] Dispatch CMakeLists.txt must do the same thing as being done in the Proton CMakeLists.txt to skip the tests instead of using Proton's SASL.extended() function. Please let me know what you think. > Enforce SASL dependency in build metadata > - > > Key: DISPATCH-1728 > URL: https://issues.apache.org/jira/browse/DISPATCH-1728 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Justin Ross >Assignee: Ganesh Murthy >Priority: Major > > The tests require Cyrus SASL and the SASL plain mechanism. Those should be > expressed as dependencies in cmake or in a pre-test dependency check. > Otherwise, you can build the project and start running the tests before you > find out you are missing them. > A dockerfile that shows the problem: > https://gist.github.com/ssorj/80b79856ee233aab2067c88f967273f6 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] gemmellr commented on pull request #809: DISPATCH-1739 Add GitHub Action w/ sharding and bubblewrap
gemmellr commented on pull request #809: URL: https://github.com/apache/qpid-dispatch/pull/809#issuecomment-668642821 > Note that ctest -j2 results in test log lines being mixed up in stdout. Refer to the output XML report or use grep (grep for lines starting with the test number) to get understandable logs. Or not use -j2? How much of a difference does it make? You commented later its mainly for excercising bwrap and is more useful on Travis. > Using four shards, as adding more does not help much. Presumably due to all the setup costs relative to the time spent on tests, or the fact 1 shard is clearly longer than others and maybe still ends up that way? Also, did you try less than 4? I see one of them has a test run around twice as long as most others, so unless all the long-running tests are perfectly spaced to fall in that shard, is it possible having less shards might actually distribute the test time more evenly such that it isnt much slower overall (if at all; it could even be faster if the tests group better), while giving less different output areas to look at (not personally a huge fan of the sharding, significantly complicates the build config and results, may point to some inefficient tests that it seems needed to begin with) > I also couldn't find a way to use here the artifacts that the Proton pipeline is building. I think thats fine, possibly even preferable. Its not that lengthy a build, and its likely to eventually want different versions as e.g the Travis tests use. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1739) Use GitHub Actions w/ sharding and bubblewrap for some fast CI
[
https://issues.apache.org/jira/browse/DISPATCH-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170841#comment-17170841
]
ASF GitHub Bot commented on DISPATCH-1739:
--
gemmellr commented on pull request #809:
URL: https://github.com/apache/qpid-dispatch/pull/809#issuecomment-668642821
> Note that ctest -j2 results in test log lines being mixed up in stdout.
Refer to the output XML report or use grep (grep for lines starting with
the test number) to get understandable logs.
Or not use -j2? How much of a difference does it make? You commented later
its mainly for excercising bwrap and is more useful on Travis.
> Using four shards, as adding more does not help much.
Presumably due to all the setup costs relative to the time spent on tests,
or the fact 1 shard is clearly longer than others and maybe still ends up that
way?
Also, did you try less than 4? I see one of them has a test run around twice
as long as most others, so unless all the long-running tests are perfectly
spaced to fall in that shard, is it possible having less shards might actually
distribute the test time more evenly such that it isnt much slower overall (if
at all; it could even be faster if the tests group better), while giving less
different output areas to look at (not personally a huge fan of the sharding,
significantly complicates the build config and results, may point to some
inefficient tests that it seems needed to begin with)
> I also couldn't find a way to use here the artifacts that the Proton
pipeline is building.
I think thats fine, possibly even preferable. Its not that lengthy a build,
and its likely to eventually want different versions as e.g the Travis tests
use.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use GitHub Actions w/ sharding and bubblewrap for some fast CI
> --
>
> Key: DISPATCH-1739
> URL: https://issues.apache.org/jira/browse/DISPATCH-1739
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 1.12.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.13.0
>
>
> GitHub Actions is a task runner associated with a GitHub project. It is
> conceptually similar to Travis, except that it has some extra features, and
> the waits for computational resources are much shorter (currently).
> Sharding is a technique to speed up the execution of tests. Instead of
> running the tests on one machine one after another, copy the build directory
> over to multiple machines, say two, and have the first execute the
> odd-numbered and the second one the even-numbered tests. With luck (if
> copying the build directory is relatively fast, and the tests all take
> approximately the same time), this will cut the execution time in half.
> Bubblewrap (https://github.com/containers/bubblewrap) is a sandboxing tool
> available on Ubuntu and other systems. It is similar to systemd-nspawn except
> it does not require sudo or user namespace support in the kernel. It is
> similar to docker, except it does not use images, instead it selectively
> mounts directories from the host. Bubblewrap can create an isolated network
> namespace, which allows running multiple tests at the same time, each in its
> own bubblewrap sandbox, and they don't clash on ports. With bubblewrap,
> running {{ctest -j4}} is safe.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1741) Update console dependency for yargs-parser to avoid security warning
Ernest Allen created DISPATCH-1741: -- Summary: Update console dependency for yargs-parser to avoid security warning Key: DISPATCH-1741 URL: https://issues.apache.org/jira/browse/DISPATCH-1741 Project: Qpid Dispatch Issue Type: Bug Components: Console Affects Versions: 1.13.0 Reporter: Ernest Allen Assignee: Ernest Allen A new security vulnerability was identified with the released version of yargs-parser. The dependency path is react-scripts > webpack-dev-server > yargs > yargs-parser Since react-scripts has not been updated to require the version of yargs-parser that fixes the vulnerability, the package-lock.json file needs to be updated manually to require yargs-parser version 13.1.2 See https://github.com/facebook/create-react-app/issues/9033 for a discussion on the issue with react-scripts. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1741) Update console dependency for yargs-parser to avoid security warning
[ https://issues.apache.org/jira/browse/DISPATCH-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170844#comment-17170844 ] ASF subversion and git services commented on DISPATCH-1741: --- Commit 2ca875c1591216896bb5442fd03b02ff8940f4b6 in qpid-dispatch's branch refs/heads/master from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2ca875c ] DISPATCH-1741: Manually bump console's yargs-parser depdency to version 13.1.2 to fix security vunerability > Update console dependency for yargs-parser to avoid security warning > > > Key: DISPATCH-1741 > URL: https://issues.apache.org/jira/browse/DISPATCH-1741 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.13.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > A new security vulnerability was identified with the released version of > yargs-parser. > The dependency path is > react-scripts > webpack-dev-server > yargs > yargs-parser > Since react-scripts has not been updated to require the version of > yargs-parser that fixes the vulnerability, the package-lock.json file needs > to be updated manually to require yargs-parser version 13.1.2 > See https://github.com/facebook/create-react-app/issues/9033 for a discussion > on the issue with react-scripts. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1741) Update console dependency for yargs-parser to avoid security warning
[ https://issues.apache.org/jira/browse/DISPATCH-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen resolved DISPATCH-1741. Fix Version/s: 1.13.0 Resolution: Fixed Manually updated the package-lock.json file to use version 13.1.2 of yargs-parser. npm audit now finds 0 vulnerabilities. > Update console dependency for yargs-parser to avoid security warning > > > Key: DISPATCH-1741 > URL: https://issues.apache.org/jira/browse/DISPATCH-1741 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.13.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.13.0 > > > A new security vulnerability was identified with the released version of > yargs-parser. > The dependency path is > react-scripts > webpack-dev-server > yargs > yargs-parser > Since react-scripts has not been updated to require the version of > yargs-parser that fixes the vulnerability, the package-lock.json file needs > to be updated manually to require yargs-parser version 13.1.2 > See https://github.com/facebook/create-react-app/issues/9033 for a discussion > on the issue with react-scripts. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1568) Add unittest framework for testing C code
[ https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170849#comment-17170849 ] ASF subversion and git services commented on DISPATCH-1568: --- Commit f796aa143892e172232821c1906eba4ed3f2f0a8 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-table-4.12.1 from Jiri Danek [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=f796aa1 ] DISPATCH-1568 Update RuntimeChecks to work with C++ code > Add unittest framework for testing C code > - > > Key: DISPATCH-1568 > URL: https://issues.apache.org/jira/browse/DISPATCH-1568 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tests >Reporter: Nicolas >Priority: Major > Fix For: 1.13.0 > > Original Estimate: 336h > Remaining Estimate: 336h > > Right now we are not using any framework for easily write c unit-test when > developing (or later). > The idea is to research available libraries, pick one and try to include in > our workflow. > preliminary candidates: > [https://github.com/google/googletest] > [https://github.com/catchorg/Catch2] > [https://github.com/catchorg/Catch2/tree/Catch1.x] <- Actually, Qpid Proton > is using this one (old catch2) > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1732) segfault when connecting to multitenant listener with policy but no hostname in open
[
https://issues.apache.org/jira/browse/DISPATCH-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170853#comment-17170853
]
ASF subversion and git services commented on DISPATCH-1732:
---
Commit 8dd77e3e56ba55a3b48dd3bb225fdff7bfd6d2cc in qpid-dispatch's branch
refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-table-4.12.1
from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8dd77e3 ]
DISPATCH-1732: Policy multitenant vhost check if Open.hostname is absent
Null hostname causes segfault. Add self test to verify fix.
> segfault when connecting to multitenant listener with policy but no hostname
> in open
> -
>
> Key: DISPATCH-1732
> URL: https://issues.apache.org/jira/browse/DISPATCH-1732
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Policy Engine
>Affects Versions: 1.13.0
>Reporter: Gordon Sim
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
>
> Start router with following config file and then run qpid-receive against it
> (which by default does not set a hostname in open).
>
> {noformat}
> [
> ["listener", { "host": "0.0.0.0", "port": 5672, "multiTenant": true ,
> "policyVhost": "myhost"}],
> ["policy", {"enableVhostPolicy": true }],
> ["vhost", { "hostname": "myhost", "allowUnknownUser": true,
> "groups":{"$default":{"remoteHosts":"*","sources":"*","targets":"*","allowDynamicSource":true,"allowAnonymousSender":true}}}]
> ] {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-960) TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on a listener
[ https://issues.apache.org/jira/browse/DISPATCH-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170855#comment-17170855 ] ASF subversion and git services commented on DISPATCH-960: -- Commit 97ac13417d77cd2f8a90acb837747abee438ed20 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-table-4.12.1 from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=97ac134 ] DISPATCH-960 Use getservbyname on macOS (getservbyname_r not available) (#804) > TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on > a listener > --- > > Key: DISPATCH-960 > URL: https://issues.apache.org/jira/browse/DISPATCH-960 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.0.1, 1.12.0 >Reporter: Fernando Giorgetti >Assignee: Fernando Giorgetti >Priority: Major > Fix For: 1.13.0 > > Attachments: dispatch-960-reproducer.tar.gz > > > The default configuration for the dispatch router contains a default listener > set up to use 'port: amqp'. > If you change the default listener to use 'http: yes' and starts the router, > it causes an issue as the service name (amqp) is not resolved, and so the > router attempts to listen to port 0 (random), causing an unpredictable > behavior. > > A reproducer is attached to this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-960) TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on a listener
[ https://issues.apache.org/jira/browse/DISPATCH-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170854#comment-17170854 ] ASF subversion and git services commented on DISPATCH-960: -- Commit 13ea6033647bfc177cd0689541ce40b28568c3a6 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-table-4.12.1 from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=13ea603 ] DISPATCH-960 Handle invalid configs when resolving port (#802) > TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on > a listener > --- > > Key: DISPATCH-960 > URL: https://issues.apache.org/jira/browse/DISPATCH-960 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.0.1, 1.12.0 >Reporter: Fernando Giorgetti >Assignee: Fernando Giorgetti >Priority: Major > Fix For: 1.13.0 > > Attachments: dispatch-960-reproducer.tar.gz > > > The default configuration for the dispatch router contains a default listener > set up to use 'port: amqp'. > If you change the default listener to use 'http: yes' and starts the router, > it causes an issue as the service name (amqp) is not resolved, and so the > router attempts to listen to port 0 (random), causing an unpredictable > behavior. > > A reproducer is attached to this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1726) Upgrade dependencies using dependabot PRs before the 1.13.0 release
[ https://issues.apache.org/jira/browse/DISPATCH-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170856#comment-17170856 ] ASF subversion and git services commented on DISPATCH-1726: --- Commit 6e71b31d8b843e02d47d114c4e92eaf298722cbf in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-table-4.12.1 from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=6e71b31 ] DISPATCH-1726 Bump elliptic from 6.5.2 to 6.5.3 in /console/react (#807) > Upgrade dependencies using dependabot PRs before the 1.13.0 release > --- > > Key: DISPATCH-1726 > URL: https://issues.apache.org/jira/browse/DISPATCH-1726 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.12.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: 1.13.0 > > > Scope of the issue: The dependencies updated here should be only > devDependencies, or nonessential minor updates, and possibly security issues, > if any. Large updates, (such as d3) that require adapting to a different API > (sometimes significantly different, as in d3) are out of scope. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1568) Add unittest framework for testing C code
[ https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170851#comment-17170851 ] ASF subversion and git services commented on DISPATCH-1568: --- Commit c540d2c54cadbec0397821885317f2a89a1da115 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-table-4.12.1 from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c540d2c ] DISPATCH-1568: make license text and related files more specific > Add unittest framework for testing C code > - > > Key: DISPATCH-1568 > URL: https://issues.apache.org/jira/browse/DISPATCH-1568 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tests >Reporter: Nicolas >Priority: Major > Fix For: 1.13.0 > > Original Estimate: 336h > Remaining Estimate: 336h > > Right now we are not using any framework for easily write c unit-test when > developing (or later). > The idea is to research available libraries, pick one and try to include in > our workflow. > preliminary candidates: > [https://github.com/google/googletest] > [https://github.com/catchorg/Catch2] > [https://github.com/catchorg/Catch2/tree/Catch1.x] <- Actually, Qpid Proton > is using this one (old catch2) > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1741) Update console dependency for yargs-parser to avoid security warning
[ https://issues.apache.org/jira/browse/DISPATCH-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170857#comment-17170857 ] ASF subversion and git services commented on DISPATCH-1741: --- Commit 2ca875c1591216896bb5442fd03b02ff8940f4b6 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-table-4.12.1 from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2ca875c ] DISPATCH-1741: Manually bump console's yargs-parser depdency to version 13.1.2 to fix security vunerability > Update console dependency for yargs-parser to avoid security warning > > > Key: DISPATCH-1741 > URL: https://issues.apache.org/jira/browse/DISPATCH-1741 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.13.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.13.0 > > > A new security vulnerability was identified with the released version of > yargs-parser. > The dependency path is > react-scripts > webpack-dev-server > yargs > yargs-parser > Since react-scripts has not been updated to require the version of > yargs-parser that fixes the vulnerability, the package-lock.json file needs > to be updated manually to require yargs-parser version 13.1.2 > See https://github.com/facebook/create-react-app/issues/9033 for a discussion > on the issue with react-scripts. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1568) Add unittest framework for testing C code
[ https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170848#comment-17170848 ] ASF subversion and git services commented on DISPATCH-1568: --- Commit 3d26b4da995f275a3eb4c96745d03f73efc55571 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-table-4.12.1 from Jiri Danek [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=3d26b4d ] DISPATCH-1568 c-unittests: replace #define with C++ const, use SUBCASEs more > Add unittest framework for testing C code > - > > Key: DISPATCH-1568 > URL: https://issues.apache.org/jira/browse/DISPATCH-1568 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tests >Reporter: Nicolas >Priority: Major > Fix For: 1.13.0 > > Original Estimate: 336h > Remaining Estimate: 336h > > Right now we are not using any framework for easily write c unit-test when > developing (or later). > The idea is to research available libraries, pick one and try to include in > our workflow. > preliminary candidates: > [https://github.com/google/googletest] > [https://github.com/catchorg/Catch2] > [https://github.com/catchorg/Catch2/tree/Catch1.x] <- Actually, Qpid Proton > is using this one (old catch2) > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1568) Add unittest framework for testing C code
[ https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170850#comment-17170850 ] ASF subversion and git services commented on DISPATCH-1568: --- Commit 2654cf1517a9d25b29e1e5c3cac5ff9d0a6985be in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-table-4.12.1 from Jiri Danek [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2654cf1 ] DISPATCH-1568 Add LICENSE.txt for doctest > Add unittest framework for testing C code > - > > Key: DISPATCH-1568 > URL: https://issues.apache.org/jira/browse/DISPATCH-1568 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tests >Reporter: Nicolas >Priority: Major > Fix For: 1.13.0 > > Original Estimate: 336h > Remaining Estimate: 336h > > Right now we are not using any framework for easily write c unit-test when > developing (or later). > The idea is to research available libraries, pick one and try to include in > our workflow. > preliminary candidates: > [https://github.com/google/googletest] > [https://github.com/catchorg/Catch2] > [https://github.com/catchorg/Catch2/tree/Catch1.x] <- Actually, Qpid Proton > is using this one (old catch2) > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #809: DISPATCH-1739 Add GitHub Action w/ sharding and bubblewrap
jiridanek commented on pull request #809: URL: https://github.com/apache/qpid-dispatch/pull/809#issuecomment-668651509 > Or not use -j2? Probably. I'll leave -DUSE_BWRAP=ON and remove the -j2. > Also, did you try less than 4? Yes, there is about 1 min improvement in total time between 3 and 4. I did not try 2. There is the Python tox test, that is the most lengthy one. It is essentially running the other tests on py27 and then 36. I was thinking of giving it a shard of its own, but it seemed to me overly elaborate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1739) Use GitHub Actions w/ sharding and bubblewrap for some fast CI
[
https://issues.apache.org/jira/browse/DISPATCH-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170859#comment-17170859
]
ASF GitHub Bot commented on DISPATCH-1739:
--
jiridanek commented on pull request #809:
URL: https://github.com/apache/qpid-dispatch/pull/809#issuecomment-668651509
> Or not use -j2?
Probably. I'll leave -DUSE_BWRAP=ON and remove the -j2.
> Also, did you try less than 4?
Yes, there is about 1 min improvement in total time between 3 and 4. I did
not try 2.
There is the Python tox test, that is the most lengthy one. It is
essentially running the other tests on py27 and then 36. I was thinking of
giving it a shard of its own, but it seemed to me overly elaborate.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use GitHub Actions w/ sharding and bubblewrap for some fast CI
> --
>
> Key: DISPATCH-1739
> URL: https://issues.apache.org/jira/browse/DISPATCH-1739
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 1.12.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.13.0
>
>
> GitHub Actions is a task runner associated with a GitHub project. It is
> conceptually similar to Travis, except that it has some extra features, and
> the waits for computational resources are much shorter (currently).
> Sharding is a technique to speed up the execution of tests. Instead of
> running the tests on one machine one after another, copy the build directory
> over to multiple machines, say two, and have the first execute the
> odd-numbered and the second one the even-numbered tests. With luck (if
> copying the build directory is relatively fast, and the tests all take
> approximately the same time), this will cut the execution time in half.
> Bubblewrap (https://github.com/containers/bubblewrap) is a sandboxing tool
> available on Ubuntu and other systems. It is similar to systemd-nspawn except
> it does not require sudo or user namespace support in the kernel. It is
> similar to docker, except it does not use images, instead it selectively
> mounts directories from the host. Bubblewrap can create an isolated network
> namespace, which allows running multiple tests at the same time, each in its
> own bubblewrap sandbox, and they don't clash on ports. With bubblewrap,
> running {{ctest -j4}} is safe.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek edited a comment on pull request #809: DISPATCH-1739 Add GitHub Action w/ sharding and bubblewrap
jiridanek edited a comment on pull request #809: URL: https://github.com/apache/qpid-dispatch/pull/809#issuecomment-668651509 > Or not use -j2? Probably. I'll leave -DUSE_BWRAP=ON and remove the -j2. On Travis it cuts the total time in half. Here, most time savings is by doing the shards. > Also, did you try less than 4? Yes, there is about 1 min improvement in total time between 3 and 4. I did not try 2. There is the Python tox test, that is the most lengthy one. It is essentially running the other tests on py27 and then 36. I was thinking of giving it a shard of its own, but it seemed to me overly elaborate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1739) Use GitHub Actions w/ sharding and bubblewrap for some fast CI
[
https://issues.apache.org/jira/browse/DISPATCH-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170860#comment-17170860
]
ASF GitHub Bot commented on DISPATCH-1739:
--
jiridanek edited a comment on pull request #809:
URL: https://github.com/apache/qpid-dispatch/pull/809#issuecomment-668651509
> Or not use -j2?
Probably. I'll leave -DUSE_BWRAP=ON and remove the -j2. On Travis it cuts
the total time in half. Here, most time savings is by doing the shards.
> Also, did you try less than 4?
Yes, there is about 1 min improvement in total time between 3 and 4. I did
not try 2.
There is the Python tox test, that is the most lengthy one. It is
essentially running the other tests on py27 and then 36. I was thinking of
giving it a shard of its own, but it seemed to me overly elaborate.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use GitHub Actions w/ sharding and bubblewrap for some fast CI
> --
>
> Key: DISPATCH-1739
> URL: https://issues.apache.org/jira/browse/DISPATCH-1739
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 1.12.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.13.0
>
>
> GitHub Actions is a task runner associated with a GitHub project. It is
> conceptually similar to Travis, except that it has some extra features, and
> the waits for computational resources are much shorter (currently).
> Sharding is a technique to speed up the execution of tests. Instead of
> running the tests on one machine one after another, copy the build directory
> over to multiple machines, say two, and have the first execute the
> odd-numbered and the second one the even-numbered tests. With luck (if
> copying the build directory is relatively fast, and the tests all take
> approximately the same time), this will cut the execution time in half.
> Bubblewrap (https://github.com/containers/bubblewrap) is a sandboxing tool
> available on Ubuntu and other systems. It is similar to systemd-nspawn except
> it does not require sudo or user namespace support in the kernel. It is
> similar to docker, except it does not use images, instead it selectively
> mounts directories from the host. Bubblewrap can create an isolated network
> namespace, which allows running multiple tests at the same time, each in its
> own bubblewrap sandbox, and they don't clash on ports. With bubblewrap,
> running {{ctest -j4}} is safe.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #808: DISPATCH-1737: Log config file json as-modified when json parse fails
asfgit closed pull request #808: URL: https://github.com/apache/qpid-dispatch/pull/808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1737) Policy config parse errors report wrong line and column numbers
[ https://issues.apache.org/jira/browse/DISPATCH-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170868#comment-17170868 ] ASF GitHub Bot commented on DISPATCH-1737: -- asfgit closed pull request #808: URL: https://github.com/apache/qpid-dispatch/pull/808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Policy config parse errors report wrong line and column numbers > > > Key: DISPATCH-1737 > URL: https://issues.apache.org/jira/browse/DISPATCH-1737 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.12.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > > Config files may be written in _router config_ format or _json_ format. > Either way the file data is reorganized internally into _json_ format. After > the data is reorganized then the original text formatting is lost. If there > is a json parse error then the json errors showing line and column numbers > are for the reformatted text and can not be correlated to the original input. > This issue adds error logs in the event of a config parse error. The logs > show the config data as it was presented to the json parser. Users may then > see specifically where the config parsing failed with respect to their > original input. > This issue is different from DISPATCH-1707. Fixing this issue will aid in > debugging and fixing that issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1737) Policy config parse errors report wrong line and column numbers
[ https://issues.apache.org/jira/browse/DISPATCH-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170866#comment-17170866 ] ASF subversion and git services commented on DISPATCH-1737: --- Commit 578164f5ed4b84eeb31c71148cb3ba4843451248 in qpid-dispatch's branch refs/heads/master from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=578164f ] DISPATCH-1737: Log config file json as-modified when json parse fails When config file json parsing fails then the parser prints a line and column number of the offending input. Since the original input is modified by the config process the reported line and column numbers are not useful. This patch logs the input that json was given when parsing fails. The parser failure line and column numbers directly relate to logged json input lines and syntax errors may be identifed with some authority. This closes #808 > Policy config parse errors report wrong line and column numbers > > > Key: DISPATCH-1737 > URL: https://issues.apache.org/jira/browse/DISPATCH-1737 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.12.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > > Config files may be written in _router config_ format or _json_ format. > Either way the file data is reorganized internally into _json_ format. After > the data is reorganized then the original text formatting is lost. If there > is a json parse error then the json errors showing line and column numbers > are for the reformatted text and can not be correlated to the original input. > This issue adds error logs in the event of a config parse error. The logs > show the config data as it was presented to the json parser. Users may then > see specifically where the config parsing failed with respect to their > original input. > This issue is different from DISPATCH-1707. Fixing this issue will aid in > debugging and fixing that issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1741) Update console dependency for yargs-parser to avoid security warning
[ https://issues.apache.org/jira/browse/DISPATCH-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170882#comment-17170882 ] ASF subversion and git services commented on DISPATCH-1741: --- Commit c9bfd071ac2ba5515aaf5e51c7cf224a667210ac in qpid-dispatch's branch refs/heads/master from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c9bfd07 ] DISPATCH-1741: Regenerated package-lock.json for console and updated yargs-parser. The previous version of package-lock.json broke npm test > Update console dependency for yargs-parser to avoid security warning > > > Key: DISPATCH-1741 > URL: https://issues.apache.org/jira/browse/DISPATCH-1741 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.13.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.13.0 > > > A new security vulnerability was identified with the released version of > yargs-parser. > The dependency path is > react-scripts > webpack-dev-server > yargs > yargs-parser > Since react-scripts has not been updated to require the version of > yargs-parser that fixes the vulnerability, the package-lock.json file needs > to be updated manually to require yargs-parser version 13.1.2 > See https://github.com/facebook/create-react-app/issues/9033 for a discussion > on the issue with react-scripts. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1568) Add unittest framework for testing C code
[ https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170893#comment-17170893 ] ASF subversion and git services commented on DISPATCH-1568: --- Commit 2654cf1517a9d25b29e1e5c3cac5ff9d0a6985be in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-icons-4.5.0 from Jiri Danek [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2654cf1 ] DISPATCH-1568 Add LICENSE.txt for doctest > Add unittest framework for testing C code > - > > Key: DISPATCH-1568 > URL: https://issues.apache.org/jira/browse/DISPATCH-1568 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tests >Reporter: Nicolas >Priority: Major > Fix For: 1.13.0 > > Original Estimate: 336h > Remaining Estimate: 336h > > Right now we are not using any framework for easily write c unit-test when > developing (or later). > The idea is to research available libraries, pick one and try to include in > our workflow. > preliminary candidates: > [https://github.com/google/googletest] > [https://github.com/catchorg/Catch2] > [https://github.com/catchorg/Catch2/tree/Catch1.x] <- Actually, Qpid Proton > is using this one (old catch2) > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-960) TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on a listener
[ https://issues.apache.org/jira/browse/DISPATCH-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170896#comment-17170896 ] ASF subversion and git services commented on DISPATCH-960: -- Commit 13ea6033647bfc177cd0689541ce40b28568c3a6 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-icons-4.5.0 from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=13ea603 ] DISPATCH-960 Handle invalid configs when resolving port (#802) > TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on > a listener > --- > > Key: DISPATCH-960 > URL: https://issues.apache.org/jira/browse/DISPATCH-960 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.0.1, 1.12.0 >Reporter: Fernando Giorgetti >Assignee: Fernando Giorgetti >Priority: Major > Fix For: 1.13.0 > > Attachments: dispatch-960-reproducer.tar.gz > > > The default configuration for the dispatch router contains a default listener > set up to use 'port: amqp'. > If you change the default listener to use 'http: yes' and starts the router, > it causes an issue as the service name (amqp) is not resolved, and so the > router attempts to listen to port 0 (random), causing an unpredictable > behavior. > > A reproducer is attached to this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1737) Policy config parse errors report wrong line and column numbers
[ https://issues.apache.org/jira/browse/DISPATCH-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170891#comment-17170891 ] ASF subversion and git services commented on DISPATCH-1737: --- Commit 578164f5ed4b84eeb31c71148cb3ba4843451248 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-charts-6.6.0 from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=578164f ] DISPATCH-1737: Log config file json as-modified when json parse fails When config file json parsing fails then the parser prints a line and column number of the offending input. Since the original input is modified by the config process the reported line and column numbers are not useful. This patch logs the input that json was given when parsing fails. The parser failure line and column numbers directly relate to logged json input lines and syntax errors may be identifed with some authority. This closes #808 > Policy config parse errors report wrong line and column numbers > > > Key: DISPATCH-1737 > URL: https://issues.apache.org/jira/browse/DISPATCH-1737 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.12.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > > Config files may be written in _router config_ format or _json_ format. > Either way the file data is reorganized internally into _json_ format. After > the data is reorganized then the original text formatting is lost. If there > is a json parse error then the json errors showing line and column numbers > are for the reformatted text and can not be correlated to the original input. > This issue adds error logs in the event of a config parse error. The logs > show the config data as it was presented to the json parser. Users may then > see specifically where the config parsing failed with respect to their > original input. > This issue is different from DISPATCH-1707. Fixing this issue will aid in > debugging and fixing that issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1741) Update console dependency for yargs-parser to avoid security warning
[ https://issues.apache.org/jira/browse/DISPATCH-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170901#comment-17170901 ] ASF subversion and git services commented on DISPATCH-1741: --- Commit c9bfd071ac2ba5515aaf5e51c7cf224a667210ac in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-icons-4.5.0 from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c9bfd07 ] DISPATCH-1741: Regenerated package-lock.json for console and updated yargs-parser. The previous version of package-lock.json broke npm test > Update console dependency for yargs-parser to avoid security warning > > > Key: DISPATCH-1741 > URL: https://issues.apache.org/jira/browse/DISPATCH-1741 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.13.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.13.0 > > > A new security vulnerability was identified with the released version of > yargs-parser. > The dependency path is > react-scripts > webpack-dev-server > yargs > yargs-parser > Since react-scripts has not been updated to require the version of > yargs-parser that fixes the vulnerability, the package-lock.json file needs > to be updated manually to require yargs-parser version 13.1.2 > See https://github.com/facebook/create-react-app/issues/9033 for a discussion > on the issue with react-scripts. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1568) Add unittest framework for testing C code
[ https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170894#comment-17170894 ] ASF subversion and git services commented on DISPATCH-1568: --- Commit c540d2c54cadbec0397821885317f2a89a1da115 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-icons-4.5.0 from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c540d2c ] DISPATCH-1568: make license text and related files more specific > Add unittest framework for testing C code > - > > Key: DISPATCH-1568 > URL: https://issues.apache.org/jira/browse/DISPATCH-1568 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tests >Reporter: Nicolas >Priority: Major > Fix For: 1.13.0 > > Original Estimate: 336h > Remaining Estimate: 336h > > Right now we are not using any framework for easily write c unit-test when > developing (or later). > The idea is to research available libraries, pick one and try to include in > our workflow. > preliminary candidates: > [https://github.com/google/googletest] > [https://github.com/catchorg/Catch2] > [https://github.com/catchorg/Catch2/tree/Catch1.x] <- Actually, Qpid Proton > is using this one (old catch2) > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-960) TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on a listener
[ https://issues.apache.org/jira/browse/DISPATCH-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170897#comment-17170897 ] ASF subversion and git services commented on DISPATCH-960: -- Commit 97ac13417d77cd2f8a90acb837747abee438ed20 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-icons-4.5.0 from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=97ac134 ] DISPATCH-960 Use getservbyname on macOS (getservbyname_r not available) (#804) > TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on > a listener > --- > > Key: DISPATCH-960 > URL: https://issues.apache.org/jira/browse/DISPATCH-960 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.0.1, 1.12.0 >Reporter: Fernando Giorgetti >Assignee: Fernando Giorgetti >Priority: Major > Fix For: 1.13.0 > > Attachments: dispatch-960-reproducer.tar.gz > > > The default configuration for the dispatch router contains a default listener > set up to use 'port: amqp'. > If you change the default listener to use 'http: yes' and starts the router, > it causes an issue as the service name (amqp) is not resolved, and so the > router attempts to listen to port 0 (random), causing an unpredictable > behavior. > > A reproducer is attached to this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1737) Policy config parse errors report wrong line and column numbers
[ https://issues.apache.org/jira/browse/DISPATCH-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170900#comment-17170900 ] ASF subversion and git services commented on DISPATCH-1737: --- Commit 578164f5ed4b84eeb31c71148cb3ba4843451248 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-icons-4.5.0 from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=578164f ] DISPATCH-1737: Log config file json as-modified when json parse fails When config file json parsing fails then the parser prints a line and column number of the offending input. Since the original input is modified by the config process the reported line and column numbers are not useful. This patch logs the input that json was given when parsing fails. The parser failure line and column numbers directly relate to logged json input lines and syntax errors may be identifed with some authority. This closes #808 > Policy config parse errors report wrong line and column numbers > > > Key: DISPATCH-1737 > URL: https://issues.apache.org/jira/browse/DISPATCH-1737 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.12.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > > Config files may be written in _router config_ format or _json_ format. > Either way the file data is reorganized internally into _json_ format. After > the data is reorganized then the original text formatting is lost. If there > is a json parse error then the json errors showing line and column numbers > are for the reformatted text and can not be correlated to the original input. > This issue adds error logs in the event of a config parse error. The logs > show the config data as it was presented to the json parser. Users may then > see specifically where the config parsing failed with respect to their > original input. > This issue is different from DISPATCH-1707. Fixing this issue will aid in > debugging and fixing that issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1732) segfault when connecting to multitenant listener with policy but no hostname in open
[
https://issues.apache.org/jira/browse/DISPATCH-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170895#comment-17170895
]
ASF subversion and git services commented on DISPATCH-1732:
---
Commit 8dd77e3e56ba55a3b48dd3bb225fdff7bfd6d2cc in qpid-dispatch's branch
refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-icons-4.5.0
from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8dd77e3 ]
DISPATCH-1732: Policy multitenant vhost check if Open.hostname is absent
Null hostname causes segfault. Add self test to verify fix.
> segfault when connecting to multitenant listener with policy but no hostname
> in open
> -
>
> Key: DISPATCH-1732
> URL: https://issues.apache.org/jira/browse/DISPATCH-1732
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Policy Engine
>Affects Versions: 1.13.0
>Reporter: Gordon Sim
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
>
> Start router with following config file and then run qpid-receive against it
> (which by default does not set a hostname in open).
>
> {noformat}
> [
> ["listener", { "host": "0.0.0.0", "port": 5672, "multiTenant": true ,
> "policyVhost": "myhost"}],
> ["policy", {"enableVhostPolicy": true }],
> ["vhost", { "hostname": "myhost", "allowUnknownUser": true,
> "groups":{"$default":{"remoteHosts":"*","sources":"*","targets":"*","allowDynamicSource":true,"allowAnonymousSender":true}}}]
> ] {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1741) Update console dependency for yargs-parser to avoid security warning
[ https://issues.apache.org/jira/browse/DISPATCH-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170892#comment-17170892 ] ASF subversion and git services commented on DISPATCH-1741: --- Commit c9bfd071ac2ba5515aaf5e51c7cf224a667210ac in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-charts-6.6.0 from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c9bfd07 ] DISPATCH-1741: Regenerated package-lock.json for console and updated yargs-parser. The previous version of package-lock.json broke npm test > Update console dependency for yargs-parser to avoid security warning > > > Key: DISPATCH-1741 > URL: https://issues.apache.org/jira/browse/DISPATCH-1741 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.13.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.13.0 > > > A new security vulnerability was identified with the released version of > yargs-parser. > The dependency path is > react-scripts > webpack-dev-server > yargs > yargs-parser > Since react-scripts has not been updated to require the version of > yargs-parser that fixes the vulnerability, the package-lock.json file needs > to be updated manually to require yargs-parser version 13.1.2 > See https://github.com/facebook/create-react-app/issues/9033 for a discussion > on the issue with react-scripts. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-960) TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on a listener
[ https://issues.apache.org/jira/browse/DISPATCH-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170888#comment-17170888 ] ASF subversion and git services commented on DISPATCH-960: -- Commit 97ac13417d77cd2f8a90acb837747abee438ed20 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-charts-6.6.0 from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=97ac134 ] DISPATCH-960 Use getservbyname on macOS (getservbyname_r not available) (#804) > TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on > a listener > --- > > Key: DISPATCH-960 > URL: https://issues.apache.org/jira/browse/DISPATCH-960 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.0.1, 1.12.0 >Reporter: Fernando Giorgetti >Assignee: Fernando Giorgetti >Priority: Major > Fix For: 1.13.0 > > Attachments: dispatch-960-reproducer.tar.gz > > > The default configuration for the dispatch router contains a default listener > set up to use 'port: amqp'. > If you change the default listener to use 'http: yes' and starts the router, > it causes an issue as the service name (amqp) is not resolved, and so the > router attempts to listen to port 0 (random), causing an unpredictable > behavior. > > A reproducer is attached to this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1568) Add unittest framework for testing C code
[ https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170885#comment-17170885 ] ASF subversion and git services commented on DISPATCH-1568: --- Commit c540d2c54cadbec0397821885317f2a89a1da115 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-charts-6.6.0 from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c540d2c ] DISPATCH-1568: make license text and related files more specific > Add unittest framework for testing C code > - > > Key: DISPATCH-1568 > URL: https://issues.apache.org/jira/browse/DISPATCH-1568 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tests >Reporter: Nicolas >Priority: Major > Fix For: 1.13.0 > > Original Estimate: 336h > Remaining Estimate: 336h > > Right now we are not using any framework for easily write c unit-test when > developing (or later). > The idea is to research available libraries, pick one and try to include in > our workflow. > preliminary candidates: > [https://github.com/google/googletest] > [https://github.com/catchorg/Catch2] > [https://github.com/catchorg/Catch2/tree/Catch1.x] <- Actually, Qpid Proton > is using this one (old catch2) > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1741) Update console dependency for yargs-parser to avoid security warning
[ https://issues.apache.org/jira/browse/DISPATCH-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170899#comment-17170899 ] ASF subversion and git services commented on DISPATCH-1741: --- Commit 2ca875c1591216896bb5442fd03b02ff8940f4b6 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-icons-4.5.0 from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2ca875c ] DISPATCH-1741: Manually bump console's yargs-parser depdency to version 13.1.2 to fix security vunerability > Update console dependency for yargs-parser to avoid security warning > > > Key: DISPATCH-1741 > URL: https://issues.apache.org/jira/browse/DISPATCH-1741 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.13.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.13.0 > > > A new security vulnerability was identified with the released version of > yargs-parser. > The dependency path is > react-scripts > webpack-dev-server > yargs > yargs-parser > Since react-scripts has not been updated to require the version of > yargs-parser that fixes the vulnerability, the package-lock.json file needs > to be updated manually to require yargs-parser version 13.1.2 > See https://github.com/facebook/create-react-app/issues/9033 for a discussion > on the issue with react-scripts. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-960) TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on a listener
[ https://issues.apache.org/jira/browse/DISPATCH-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170887#comment-17170887 ] ASF subversion and git services commented on DISPATCH-960: -- Commit 13ea6033647bfc177cd0689541ce40b28568c3a6 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-charts-6.6.0 from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=13ea603 ] DISPATCH-960 Handle invalid configs when resolving port (#802) > TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on > a listener > --- > > Key: DISPATCH-960 > URL: https://issues.apache.org/jira/browse/DISPATCH-960 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.0.1, 1.12.0 >Reporter: Fernando Giorgetti >Assignee: Fernando Giorgetti >Priority: Major > Fix For: 1.13.0 > > Attachments: dispatch-960-reproducer.tar.gz > > > The default configuration for the dispatch router contains a default listener > set up to use 'port: amqp'. > If you change the default listener to use 'http: yes' and starts the router, > it causes an issue as the service name (amqp) is not resolved, and so the > router attempts to listen to port 0 (random), causing an unpredictable > behavior. > > A reproducer is attached to this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1726) Upgrade dependencies using dependabot PRs before the 1.13.0 release
[ https://issues.apache.org/jira/browse/DISPATCH-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170898#comment-17170898 ] ASF subversion and git services commented on DISPATCH-1726: --- Commit 6e71b31d8b843e02d47d114c4e92eaf298722cbf in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-icons-4.5.0 from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=6e71b31 ] DISPATCH-1726 Bump elliptic from 6.5.2 to 6.5.3 in /console/react (#807) > Upgrade dependencies using dependabot PRs before the 1.13.0 release > --- > > Key: DISPATCH-1726 > URL: https://issues.apache.org/jira/browse/DISPATCH-1726 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.12.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: 1.13.0 > > > Scope of the issue: The dependencies updated here should be only > devDependencies, or nonessential minor updates, and possibly security issues, > if any. Large updates, (such as d3) that require adapting to a different API > (sometimes significantly different, as in d3) are out of scope. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1741) Update console dependency for yargs-parser to avoid security warning
[ https://issues.apache.org/jira/browse/DISPATCH-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170890#comment-17170890 ] ASF subversion and git services commented on DISPATCH-1741: --- Commit 2ca875c1591216896bb5442fd03b02ff8940f4b6 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-charts-6.6.0 from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2ca875c ] DISPATCH-1741: Manually bump console's yargs-parser depdency to version 13.1.2 to fix security vunerability > Update console dependency for yargs-parser to avoid security warning > > > Key: DISPATCH-1741 > URL: https://issues.apache.org/jira/browse/DISPATCH-1741 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.13.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.13.0 > > > A new security vulnerability was identified with the released version of > yargs-parser. > The dependency path is > react-scripts > webpack-dev-server > yargs > yargs-parser > Since react-scripts has not been updated to require the version of > yargs-parser that fixes the vulnerability, the package-lock.json file needs > to be updated manually to require yargs-parser version 13.1.2 > See https://github.com/facebook/create-react-app/issues/9033 for a discussion > on the issue with react-scripts. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1726) Upgrade dependencies using dependabot PRs before the 1.13.0 release
[ https://issues.apache.org/jira/browse/DISPATCH-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170889#comment-17170889 ] ASF subversion and git services commented on DISPATCH-1726: --- Commit 6e71b31d8b843e02d47d114c4e92eaf298722cbf in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-charts-6.6.0 from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=6e71b31 ] DISPATCH-1726 Bump elliptic from 6.5.2 to 6.5.3 in /console/react (#807) > Upgrade dependencies using dependabot PRs before the 1.13.0 release > --- > > Key: DISPATCH-1726 > URL: https://issues.apache.org/jira/browse/DISPATCH-1726 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.12.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: 1.13.0 > > > Scope of the issue: The dependencies updated here should be only > devDependencies, or nonessential minor updates, and possibly security issues, > if any. Large updates, (such as d3) that require adapting to a different API > (sometimes significantly different, as in d3) are out of scope. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1568) Add unittest framework for testing C code
[ https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170884#comment-17170884 ] ASF subversion and git services commented on DISPATCH-1568: --- Commit 2654cf1517a9d25b29e1e5c3cac5ff9d0a6985be in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-charts-6.6.0 from Jiri Danek [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2654cf1 ] DISPATCH-1568 Add LICENSE.txt for doctest > Add unittest framework for testing C code > - > > Key: DISPATCH-1568 > URL: https://issues.apache.org/jira/browse/DISPATCH-1568 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tests >Reporter: Nicolas >Priority: Major > Fix For: 1.13.0 > > Original Estimate: 336h > Remaining Estimate: 336h > > Right now we are not using any framework for easily write c unit-test when > developing (or later). > The idea is to research available libraries, pick one and try to include in > our workflow. > preliminary candidates: > [https://github.com/google/googletest] > [https://github.com/catchorg/Catch2] > [https://github.com/catchorg/Catch2/tree/Catch1.x] <- Actually, Qpid Proton > is using this one (old catch2) > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1732) segfault when connecting to multitenant listener with policy but no hostname in open
[
https://issues.apache.org/jira/browse/DISPATCH-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170886#comment-17170886
]
ASF subversion and git services commented on DISPATCH-1732:
---
Commit 8dd77e3e56ba55a3b48dd3bb225fdff7bfd6d2cc in qpid-dispatch's branch
refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-charts-6.6.0
from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8dd77e3 ]
DISPATCH-1732: Policy multitenant vhost check if Open.hostname is absent
Null hostname causes segfault. Add self test to verify fix.
> segfault when connecting to multitenant listener with policy but no hostname
> in open
> -
>
> Key: DISPATCH-1732
> URL: https://issues.apache.org/jira/browse/DISPATCH-1732
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Policy Engine
>Affects Versions: 1.13.0
>Reporter: Gordon Sim
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
>
> Start router with following config file and then run qpid-receive against it
> (which by default does not set a hostname in open).
>
> {noformat}
> [
> ["listener", { "host": "0.0.0.0", "port": 5672, "multiTenant": true ,
> "policyVhost": "myhost"}],
> ["policy", {"enableVhostPolicy": true }],
> ["vhost", { "hostname": "myhost", "allowUnknownUser": true,
> "groups":{"$default":{"remoteHosts":"*","sources":"*","targets":"*","allowDynamicSource":true,"allowAnonymousSender":true}}}]
> ] {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] gemmellr commented on a change in pull request #809: DISPATCH-1739 Add GitHub Action w/ sharding and bubblewrap
gemmellr commented on a change in pull request #809:
URL: https://github.com/apache/qpid-dispatch/pull/809#discussion_r465144356
##
File path: .github/workflows/build.yaml
##
@@ -0,0 +1,165 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Build
+
+on: [push, pull_request]
+
+jobs:
+ build:
+runs-on: ${{ matrix.os }}
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+env:
+ BuildType: ${{matrix.buildType}}
+ ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
+ DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
+ InstallPrefix: ${{github.workspace}}/install
+ ProtonCMakeExtraArgs: '-DBUILD_BINDINGS=python'
+ DispatchCMakeExtraArgs: ''
+steps:
+ - uses: actions/checkout@v2
+with:
+ repository: 'apache/qpid-proton'
+ ref: 'master'
+ path: 'qpid-proton'
+ - uses: actions/checkout@v2
+with:
+ path: 'qpid-dispatch'
+ - name: actions/cache@v2 node-modules
+uses: actions/cache@v2
+env:
+ cache-name: cache-node-modules
+with:
+ path: ~/.npm
+ key: ${{ runner.os }}-build-${{ env.cache-name }}-${{
hashFiles('**/package-lock.json') }}
+ restore-keys: |
+${{ runner.os }}-build-${{ env.cache-name }}-
+${{ runner.os }}-build-
+${{ runner.os }}-
+ - name: Create Build and Install directories
+run: mkdir -p "${ProtonBuildDir}" "${DispatchBuildDir}"
"{InstallPrefix}"
+shell: bash
+ - name: Setup python
+uses: actions/setup-python@v2
+with:
+ python-version: 3.6
+ architecture: x64
+ - name: Install python dependencies
+run: |
+ python -m pip install --upgrade pip
+ python -m pip install setuptools wheel tox
+ - name: Install Linux dependencies
+if: ${{ runner.os == 'Linux' }}
+run: |
+ sudo apt install -y swig ninja-build libpython3-dev libsasl2-dev
libjsoncpp-dev libwebsockets-dev xz-utils
+ - name: qpid-proton cmake configure
+working-directory: ${{env.ProtonBuildDir}}
+run: cmake "${{github.workspace}}/qpid-proton"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-DBUILD_TESTING=OFF" "-DENABLE_FUZZ_TESTING=OFF" "-GNinja"
${ProtonCMakeExtraArgs}
+shell: bash
+ - name: qpid-proton cmake build/install
+run: cmake --build "${ProtonBuildDir}" --config ${BuildType} -t install
+shell: bash
+ - name: qpid-dispatch cmake configure
+working-directory: ${{env.DispatchBuildDir}}
+run: cmake "${{github.workspace}}/qpid-dispatch"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-GNinja" "-DUSE_BWRAP=ON" ${DispatchCMakeExtraArgs}
+shell: bash
+ - name: qpid-dispatch cmake build/install
+run: cmake --build "${DispatchBuildDir}" --config ${BuildType} -t
install
+shell: bash
+ # github actions/upload-artifact@v2 does not preserve file permissions
(executable)
+ - name: Compress build
+working-directory: ${{github.workspace}}
+run: tar --xz -cf /tmp/archive.tar.xz --exclude '*.o' --exclude
'*.pyc' --exclude '.git' --exclude='qpid-dispatch/build/console' qpid-dispatch
install qpid-proton/build/python/pkgs
+ - name: Upload archive
+uses: actions/upload-artifact@v2
+with:
+ name: qpid_dispatch_wrk_${{matrix.os}}_${{matrix.buildType}}
+ path: /tmp/archive.tar.xz
+ test:
+name: "Test (${{matrix.os}}, shard ${{matrix.shard}} of ${{matrix.shards}}"
+runs-on: ${{ matrix.os }}
+needs: [build]
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+shard: [1, 2, 3, 4]
+shards: [4]
+env:
+ BuildType: ${{matrix.buildType}}
+ ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
+ DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
+ InstallPrefix: ${{github.workspace}}/install
+ PKG_CONFIG_PATH: ${{matrix.pkg_config_
[jira] [Commented] (DISPATCH-1739) Use GitHub Actions w/ sharding and bubblewrap for some fast CI
[
https://issues.apache.org/jira/browse/DISPATCH-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170912#comment-17170912
]
ASF GitHub Bot commented on DISPATCH-1739:
--
gemmellr commented on a change in pull request #809:
URL: https://github.com/apache/qpid-dispatch/pull/809#discussion_r465144356
##
File path: .github/workflows/build.yaml
##
@@ -0,0 +1,165 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Build
+
+on: [push, pull_request]
+
+jobs:
+ build:
+runs-on: ${{ matrix.os }}
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+env:
+ BuildType: ${{matrix.buildType}}
+ ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
+ DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
+ InstallPrefix: ${{github.workspace}}/install
+ ProtonCMakeExtraArgs: '-DBUILD_BINDINGS=python'
+ DispatchCMakeExtraArgs: ''
+steps:
+ - uses: actions/checkout@v2
+with:
+ repository: 'apache/qpid-proton'
+ ref: 'master'
+ path: 'qpid-proton'
+ - uses: actions/checkout@v2
+with:
+ path: 'qpid-dispatch'
+ - name: actions/cache@v2 node-modules
+uses: actions/cache@v2
+env:
+ cache-name: cache-node-modules
+with:
+ path: ~/.npm
+ key: ${{ runner.os }}-build-${{ env.cache-name }}-${{
hashFiles('**/package-lock.json') }}
+ restore-keys: |
+${{ runner.os }}-build-${{ env.cache-name }}-
+${{ runner.os }}-build-
+${{ runner.os }}-
+ - name: Create Build and Install directories
+run: mkdir -p "${ProtonBuildDir}" "${DispatchBuildDir}"
"{InstallPrefix}"
+shell: bash
+ - name: Setup python
+uses: actions/setup-python@v2
+with:
+ python-version: 3.6
+ architecture: x64
+ - name: Install python dependencies
+run: |
+ python -m pip install --upgrade pip
+ python -m pip install setuptools wheel tox
+ - name: Install Linux dependencies
+if: ${{ runner.os == 'Linux' }}
+run: |
+ sudo apt install -y swig ninja-build libpython3-dev libsasl2-dev
libjsoncpp-dev libwebsockets-dev xz-utils
+ - name: qpid-proton cmake configure
+working-directory: ${{env.ProtonBuildDir}}
+run: cmake "${{github.workspace}}/qpid-proton"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-DBUILD_TESTING=OFF" "-DENABLE_FUZZ_TESTING=OFF" "-GNinja"
${ProtonCMakeExtraArgs}
+shell: bash
+ - name: qpid-proton cmake build/install
+run: cmake --build "${ProtonBuildDir}" --config ${BuildType} -t install
+shell: bash
+ - name: qpid-dispatch cmake configure
+working-directory: ${{env.DispatchBuildDir}}
+run: cmake "${{github.workspace}}/qpid-dispatch"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-GNinja" "-DUSE_BWRAP=ON" ${DispatchCMakeExtraArgs}
+shell: bash
+ - name: qpid-dispatch cmake build/install
+run: cmake --build "${DispatchBuildDir}" --config ${BuildType} -t
install
+shell: bash
+ # github actions/upload-artifact@v2 does not preserve file permissions
(executable)
+ - name: Compress build
+working-directory: ${{github.workspace}}
+run: tar --xz -cf /tmp/archive.tar.xz --exclude '*.o' --exclude
'*.pyc' --exclude '.git' --exclude='qpid-dispatch/build/console' qpid-dispatch
install qpid-proton/build/python/pkgs
+ - name: Upload archive
+uses: actions/upload-artifact@v2
+with:
+ name: qpid_dispatch_wrk_${{matrix.os}}_${{matrix.buildType}}
+ path: /tmp/archive.tar.xz
+ test:
+name: "Test (${{matrix.os}}, shard ${{matrix.shard}} of ${{matrix.shards}}"
+runs-on: ${{ matrix.os }}
+needs: [build]
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+shard: [1, 2, 3, 4]
+shards: [4]
+env:
+
[GitHub] [qpid-dispatch] jiridanek opened a new pull request #810: NO-JIRA Disable automatic rebase in dependabot.yml
jiridanek opened a new pull request #810: URL: https://github.com/apache/qpid-dispatch/pull/810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #809: DISPATCH-1739 Add GitHub Action w/ sharding and bubblewrap
jiridanek commented on a change in pull request #809:
URL: https://github.com/apache/qpid-dispatch/pull/809#discussion_r465170038
##
File path: .github/workflows/build.yaml
##
@@ -0,0 +1,165 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Build
+
+on: [push, pull_request]
+
+jobs:
+ build:
+runs-on: ${{ matrix.os }}
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+env:
+ BuildType: ${{matrix.buildType}}
+ ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
+ DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
+ InstallPrefix: ${{github.workspace}}/install
+ ProtonCMakeExtraArgs: '-DBUILD_BINDINGS=python'
+ DispatchCMakeExtraArgs: ''
+steps:
+ - uses: actions/checkout@v2
+with:
+ repository: 'apache/qpid-proton'
+ ref: 'master'
+ path: 'qpid-proton'
+ - uses: actions/checkout@v2
+with:
+ path: 'qpid-dispatch'
+ - name: actions/cache@v2 node-modules
+uses: actions/cache@v2
+env:
+ cache-name: cache-node-modules
+with:
+ path: ~/.npm
+ key: ${{ runner.os }}-build-${{ env.cache-name }}-${{
hashFiles('**/package-lock.json') }}
+ restore-keys: |
+${{ runner.os }}-build-${{ env.cache-name }}-
+${{ runner.os }}-build-
+${{ runner.os }}-
+ - name: Create Build and Install directories
+run: mkdir -p "${ProtonBuildDir}" "${DispatchBuildDir}"
"{InstallPrefix}"
+shell: bash
+ - name: Setup python
+uses: actions/setup-python@v2
+with:
+ python-version: 3.6
+ architecture: x64
+ - name: Install python dependencies
+run: |
+ python -m pip install --upgrade pip
+ python -m pip install setuptools wheel tox
+ - name: Install Linux dependencies
+if: ${{ runner.os == 'Linux' }}
+run: |
+ sudo apt install -y swig ninja-build libpython3-dev libsasl2-dev
libjsoncpp-dev libwebsockets-dev xz-utils
+ - name: qpid-proton cmake configure
+working-directory: ${{env.ProtonBuildDir}}
+run: cmake "${{github.workspace}}/qpid-proton"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-DBUILD_TESTING=OFF" "-DENABLE_FUZZ_TESTING=OFF" "-GNinja"
${ProtonCMakeExtraArgs}
+shell: bash
+ - name: qpid-proton cmake build/install
+run: cmake --build "${ProtonBuildDir}" --config ${BuildType} -t install
+shell: bash
+ - name: qpid-dispatch cmake configure
+working-directory: ${{env.DispatchBuildDir}}
+run: cmake "${{github.workspace}}/qpid-dispatch"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-GNinja" "-DUSE_BWRAP=ON" ${DispatchCMakeExtraArgs}
+shell: bash
+ - name: qpid-dispatch cmake build/install
+run: cmake --build "${DispatchBuildDir}" --config ${BuildType} -t
install
+shell: bash
+ # github actions/upload-artifact@v2 does not preserve file permissions
(executable)
+ - name: Compress build
+working-directory: ${{github.workspace}}
+run: tar --xz -cf /tmp/archive.tar.xz --exclude '*.o' --exclude
'*.pyc' --exclude '.git' --exclude='qpid-dispatch/build/console' qpid-dispatch
install qpid-proton/build/python/pkgs
+ - name: Upload archive
+uses: actions/upload-artifact@v2
+with:
+ name: qpid_dispatch_wrk_${{matrix.os}}_${{matrix.buildType}}
+ path: /tmp/archive.tar.xz
+ test:
+name: "Test (${{matrix.os}}, shard ${{matrix.shard}} of ${{matrix.shards}}"
+runs-on: ${{ matrix.os }}
+needs: [build]
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+shard: [1, 2, 3, 4]
+shards: [4]
+env:
+ BuildType: ${{matrix.buildType}}
+ ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
+ DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
+ InstallPrefix: ${{github.workspace}}/install
+ PKG_CONFIG_PATH: ${{matrix.pkg_config
[jira] [Commented] (DISPATCH-1739) Use GitHub Actions w/ sharding and bubblewrap for some fast CI
[
https://issues.apache.org/jira/browse/DISPATCH-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170923#comment-17170923
]
ASF GitHub Bot commented on DISPATCH-1739:
--
jiridanek commented on a change in pull request #809:
URL: https://github.com/apache/qpid-dispatch/pull/809#discussion_r465170038
##
File path: .github/workflows/build.yaml
##
@@ -0,0 +1,165 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Build
+
+on: [push, pull_request]
+
+jobs:
+ build:
+runs-on: ${{ matrix.os }}
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+env:
+ BuildType: ${{matrix.buildType}}
+ ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
+ DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
+ InstallPrefix: ${{github.workspace}}/install
+ ProtonCMakeExtraArgs: '-DBUILD_BINDINGS=python'
+ DispatchCMakeExtraArgs: ''
+steps:
+ - uses: actions/checkout@v2
+with:
+ repository: 'apache/qpid-proton'
+ ref: 'master'
+ path: 'qpid-proton'
+ - uses: actions/checkout@v2
+with:
+ path: 'qpid-dispatch'
+ - name: actions/cache@v2 node-modules
+uses: actions/cache@v2
+env:
+ cache-name: cache-node-modules
+with:
+ path: ~/.npm
+ key: ${{ runner.os }}-build-${{ env.cache-name }}-${{
hashFiles('**/package-lock.json') }}
+ restore-keys: |
+${{ runner.os }}-build-${{ env.cache-name }}-
+${{ runner.os }}-build-
+${{ runner.os }}-
+ - name: Create Build and Install directories
+run: mkdir -p "${ProtonBuildDir}" "${DispatchBuildDir}"
"{InstallPrefix}"
+shell: bash
+ - name: Setup python
+uses: actions/setup-python@v2
+with:
+ python-version: 3.6
+ architecture: x64
+ - name: Install python dependencies
+run: |
+ python -m pip install --upgrade pip
+ python -m pip install setuptools wheel tox
+ - name: Install Linux dependencies
+if: ${{ runner.os == 'Linux' }}
+run: |
+ sudo apt install -y swig ninja-build libpython3-dev libsasl2-dev
libjsoncpp-dev libwebsockets-dev xz-utils
+ - name: qpid-proton cmake configure
+working-directory: ${{env.ProtonBuildDir}}
+run: cmake "${{github.workspace}}/qpid-proton"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-DBUILD_TESTING=OFF" "-DENABLE_FUZZ_TESTING=OFF" "-GNinja"
${ProtonCMakeExtraArgs}
+shell: bash
+ - name: qpid-proton cmake build/install
+run: cmake --build "${ProtonBuildDir}" --config ${BuildType} -t install
+shell: bash
+ - name: qpid-dispatch cmake configure
+working-directory: ${{env.DispatchBuildDir}}
+run: cmake "${{github.workspace}}/qpid-dispatch"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-GNinja" "-DUSE_BWRAP=ON" ${DispatchCMakeExtraArgs}
+shell: bash
+ - name: qpid-dispatch cmake build/install
+run: cmake --build "${DispatchBuildDir}" --config ${BuildType} -t
install
+shell: bash
+ # github actions/upload-artifact@v2 does not preserve file permissions
(executable)
+ - name: Compress build
+working-directory: ${{github.workspace}}
+run: tar --xz -cf /tmp/archive.tar.xz --exclude '*.o' --exclude
'*.pyc' --exclude '.git' --exclude='qpid-dispatch/build/console' qpid-dispatch
install qpid-proton/build/python/pkgs
+ - name: Upload archive
+uses: actions/upload-artifact@v2
+with:
+ name: qpid_dispatch_wrk_${{matrix.os}}_${{matrix.buildType}}
+ path: /tmp/archive.tar.xz
+ test:
+name: "Test (${{matrix.os}}, shard ${{matrix.shard}} of ${{matrix.shards}}"
+runs-on: ${{ matrix.os }}
+needs: [build]
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+shard: [1, 2, 3, 4]
+shards: [4]
+env:
+
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #809: DISPATCH-1739 Add GitHub Action w/ sharding and bubblewrap
jiridanek commented on a change in pull request #809:
URL: https://github.com/apache/qpid-dispatch/pull/809#discussion_r465170348
##
File path: .github/workflows/build.yaml
##
@@ -0,0 +1,165 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Build
+
+on: [push, pull_request]
+
+jobs:
+ build:
+runs-on: ${{ matrix.os }}
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+env:
+ BuildType: ${{matrix.buildType}}
+ ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
+ DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
+ InstallPrefix: ${{github.workspace}}/install
+ ProtonCMakeExtraArgs: '-DBUILD_BINDINGS=python'
+ DispatchCMakeExtraArgs: ''
+steps:
+ - uses: actions/checkout@v2
+with:
+ repository: 'apache/qpid-proton'
+ ref: 'master'
+ path: 'qpid-proton'
+ - uses: actions/checkout@v2
+with:
+ path: 'qpid-dispatch'
+ - name: actions/cache@v2 node-modules
+uses: actions/cache@v2
+env:
+ cache-name: cache-node-modules
+with:
+ path: ~/.npm
+ key: ${{ runner.os }}-build-${{ env.cache-name }}-${{
hashFiles('**/package-lock.json') }}
+ restore-keys: |
+${{ runner.os }}-build-${{ env.cache-name }}-
+${{ runner.os }}-build-
+${{ runner.os }}-
+ - name: Create Build and Install directories
+run: mkdir -p "${ProtonBuildDir}" "${DispatchBuildDir}"
"{InstallPrefix}"
+shell: bash
+ - name: Setup python
+uses: actions/setup-python@v2
+with:
+ python-version: 3.6
+ architecture: x64
+ - name: Install python dependencies
+run: |
+ python -m pip install --upgrade pip
+ python -m pip install setuptools wheel tox
+ - name: Install Linux dependencies
+if: ${{ runner.os == 'Linux' }}
+run: |
+ sudo apt install -y swig ninja-build libpython3-dev libsasl2-dev
libjsoncpp-dev libwebsockets-dev xz-utils
+ - name: qpid-proton cmake configure
+working-directory: ${{env.ProtonBuildDir}}
+run: cmake "${{github.workspace}}/qpid-proton"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-DBUILD_TESTING=OFF" "-DENABLE_FUZZ_TESTING=OFF" "-GNinja"
${ProtonCMakeExtraArgs}
+shell: bash
+ - name: qpid-proton cmake build/install
+run: cmake --build "${ProtonBuildDir}" --config ${BuildType} -t install
+shell: bash
+ - name: qpid-dispatch cmake configure
+working-directory: ${{env.DispatchBuildDir}}
+run: cmake "${{github.workspace}}/qpid-dispatch"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-GNinja" "-DUSE_BWRAP=ON" ${DispatchCMakeExtraArgs}
+shell: bash
+ - name: qpid-dispatch cmake build/install
+run: cmake --build "${DispatchBuildDir}" --config ${BuildType} -t
install
+shell: bash
+ # github actions/upload-artifact@v2 does not preserve file permissions
(executable)
+ - name: Compress build
+working-directory: ${{github.workspace}}
+run: tar --xz -cf /tmp/archive.tar.xz --exclude '*.o' --exclude
'*.pyc' --exclude '.git' --exclude='qpid-dispatch/build/console' qpid-dispatch
install qpid-proton/build/python/pkgs
+ - name: Upload archive
+uses: actions/upload-artifact@v2
+with:
+ name: qpid_dispatch_wrk_${{matrix.os}}_${{matrix.buildType}}
+ path: /tmp/archive.tar.xz
+ test:
+name: "Test (${{matrix.os}}, shard ${{matrix.shard}} of ${{matrix.shards}}"
+runs-on: ${{ matrix.os }}
+needs: [build]
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+shard: [1, 2, 3, 4]
+shards: [4]
+env:
+ BuildType: ${{matrix.buildType}}
+ ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
+ DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
+ InstallPrefix: ${{github.workspace}}/install
+ PKG_CONFIG_PATH: ${{matrix.pkg_config
[jira] [Commented] (DISPATCH-1739) Use GitHub Actions w/ sharding and bubblewrap for some fast CI
[
https://issues.apache.org/jira/browse/DISPATCH-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170924#comment-17170924
]
ASF GitHub Bot commented on DISPATCH-1739:
--
jiridanek commented on a change in pull request #809:
URL: https://github.com/apache/qpid-dispatch/pull/809#discussion_r465170348
##
File path: .github/workflows/build.yaml
##
@@ -0,0 +1,165 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Build
+
+on: [push, pull_request]
+
+jobs:
+ build:
+runs-on: ${{ matrix.os }}
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+env:
+ BuildType: ${{matrix.buildType}}
+ ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
+ DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
+ InstallPrefix: ${{github.workspace}}/install
+ ProtonCMakeExtraArgs: '-DBUILD_BINDINGS=python'
+ DispatchCMakeExtraArgs: ''
+steps:
+ - uses: actions/checkout@v2
+with:
+ repository: 'apache/qpid-proton'
+ ref: 'master'
+ path: 'qpid-proton'
+ - uses: actions/checkout@v2
+with:
+ path: 'qpid-dispatch'
+ - name: actions/cache@v2 node-modules
+uses: actions/cache@v2
+env:
+ cache-name: cache-node-modules
+with:
+ path: ~/.npm
+ key: ${{ runner.os }}-build-${{ env.cache-name }}-${{
hashFiles('**/package-lock.json') }}
+ restore-keys: |
+${{ runner.os }}-build-${{ env.cache-name }}-
+${{ runner.os }}-build-
+${{ runner.os }}-
+ - name: Create Build and Install directories
+run: mkdir -p "${ProtonBuildDir}" "${DispatchBuildDir}"
"{InstallPrefix}"
+shell: bash
+ - name: Setup python
+uses: actions/setup-python@v2
+with:
+ python-version: 3.6
+ architecture: x64
+ - name: Install python dependencies
+run: |
+ python -m pip install --upgrade pip
+ python -m pip install setuptools wheel tox
+ - name: Install Linux dependencies
+if: ${{ runner.os == 'Linux' }}
+run: |
+ sudo apt install -y swig ninja-build libpython3-dev libsasl2-dev
libjsoncpp-dev libwebsockets-dev xz-utils
+ - name: qpid-proton cmake configure
+working-directory: ${{env.ProtonBuildDir}}
+run: cmake "${{github.workspace}}/qpid-proton"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-DBUILD_TESTING=OFF" "-DENABLE_FUZZ_TESTING=OFF" "-GNinja"
${ProtonCMakeExtraArgs}
+shell: bash
+ - name: qpid-proton cmake build/install
+run: cmake --build "${ProtonBuildDir}" --config ${BuildType} -t install
+shell: bash
+ - name: qpid-dispatch cmake configure
+working-directory: ${{env.DispatchBuildDir}}
+run: cmake "${{github.workspace}}/qpid-dispatch"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-GNinja" "-DUSE_BWRAP=ON" ${DispatchCMakeExtraArgs}
+shell: bash
+ - name: qpid-dispatch cmake build/install
+run: cmake --build "${DispatchBuildDir}" --config ${BuildType} -t
install
+shell: bash
+ # github actions/upload-artifact@v2 does not preserve file permissions
(executable)
+ - name: Compress build
+working-directory: ${{github.workspace}}
+run: tar --xz -cf /tmp/archive.tar.xz --exclude '*.o' --exclude
'*.pyc' --exclude '.git' --exclude='qpid-dispatch/build/console' qpid-dispatch
install qpid-proton/build/python/pkgs
+ - name: Upload archive
+uses: actions/upload-artifact@v2
+with:
+ name: qpid_dispatch_wrk_${{matrix.os}}_${{matrix.buildType}}
+ path: /tmp/archive.tar.xz
+ test:
+name: "Test (${{matrix.os}}, shard ${{matrix.shard}} of ${{matrix.shards}}"
+runs-on: ${{ matrix.os }}
+needs: [build]
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+shard: [1, 2, 3, 4]
+shards: [4]
+env:
+
[GitHub] [qpid-dispatch] jiridanek merged pull request #810: NO-JIRA Disable automatic rebase in dependabot.yml
jiridanek merged pull request #810: URL: https://github.com/apache/qpid-dispatch/pull/810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1741) Update console dependency for yargs-parser to avoid security warning
[ https://issues.apache.org/jira/browse/DISPATCH-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170939#comment-17170939 ] ASF subversion and git services commented on DISPATCH-1741: --- Commit c9bfd071ac2ba5515aaf5e51c7cf224a667210ac in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/patternfly-4.23.3 from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c9bfd07 ] DISPATCH-1741: Regenerated package-lock.json for console and updated yargs-parser. The previous version of package-lock.json broke npm test > Update console dependency for yargs-parser to avoid security warning > > > Key: DISPATCH-1741 > URL: https://issues.apache.org/jira/browse/DISPATCH-1741 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.13.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.13.0 > > > A new security vulnerability was identified with the released version of > yargs-parser. > The dependency path is > react-scripts > webpack-dev-server > yargs > yargs-parser > Since react-scripts has not been updated to require the version of > yargs-parser that fixes the vulnerability, the package-lock.json file needs > to be updated manually to require yargs-parser version 13.1.2 > See https://github.com/facebook/create-react-app/issues/9033 for a discussion > on the issue with react-scripts. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] gemmellr commented on a change in pull request #809: DISPATCH-1739 Add GitHub Action w/ sharding and bubblewrap
gemmellr commented on a change in pull request #809:
URL: https://github.com/apache/qpid-dispatch/pull/809#discussion_r465181148
##
File path: .github/workflows/build.yaml
##
@@ -0,0 +1,165 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Build
+
+on: [push, pull_request]
+
+jobs:
+ build:
+runs-on: ${{ matrix.os }}
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+env:
+ BuildType: ${{matrix.buildType}}
+ ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
+ DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
+ InstallPrefix: ${{github.workspace}}/install
+ ProtonCMakeExtraArgs: '-DBUILD_BINDINGS=python'
+ DispatchCMakeExtraArgs: ''
+steps:
+ - uses: actions/checkout@v2
+with:
+ repository: 'apache/qpid-proton'
+ ref: 'master'
+ path: 'qpid-proton'
+ - uses: actions/checkout@v2
+with:
+ path: 'qpid-dispatch'
+ - name: actions/cache@v2 node-modules
+uses: actions/cache@v2
+env:
+ cache-name: cache-node-modules
+with:
+ path: ~/.npm
+ key: ${{ runner.os }}-build-${{ env.cache-name }}-${{
hashFiles('**/package-lock.json') }}
+ restore-keys: |
+${{ runner.os }}-build-${{ env.cache-name }}-
+${{ runner.os }}-build-
+${{ runner.os }}-
+ - name: Create Build and Install directories
+run: mkdir -p "${ProtonBuildDir}" "${DispatchBuildDir}"
"{InstallPrefix}"
+shell: bash
+ - name: Setup python
+uses: actions/setup-python@v2
+with:
+ python-version: 3.6
+ architecture: x64
+ - name: Install python dependencies
+run: |
+ python -m pip install --upgrade pip
+ python -m pip install setuptools wheel tox
+ - name: Install Linux dependencies
+if: ${{ runner.os == 'Linux' }}
+run: |
+ sudo apt install -y swig ninja-build libpython3-dev libsasl2-dev
libjsoncpp-dev libwebsockets-dev xz-utils
+ - name: qpid-proton cmake configure
+working-directory: ${{env.ProtonBuildDir}}
+run: cmake "${{github.workspace}}/qpid-proton"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-DBUILD_TESTING=OFF" "-DENABLE_FUZZ_TESTING=OFF" "-GNinja"
${ProtonCMakeExtraArgs}
+shell: bash
+ - name: qpid-proton cmake build/install
+run: cmake --build "${ProtonBuildDir}" --config ${BuildType} -t install
+shell: bash
+ - name: qpid-dispatch cmake configure
+working-directory: ${{env.DispatchBuildDir}}
+run: cmake "${{github.workspace}}/qpid-dispatch"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-GNinja" "-DUSE_BWRAP=ON" ${DispatchCMakeExtraArgs}
+shell: bash
+ - name: qpid-dispatch cmake build/install
+run: cmake --build "${DispatchBuildDir}" --config ${BuildType} -t
install
+shell: bash
+ # github actions/upload-artifact@v2 does not preserve file permissions
(executable)
+ - name: Compress build
+working-directory: ${{github.workspace}}
+run: tar --xz -cf /tmp/archive.tar.xz --exclude '*.o' --exclude
'*.pyc' --exclude '.git' --exclude='qpid-dispatch/build/console' qpid-dispatch
install qpid-proton/build/python/pkgs
+ - name: Upload archive
+uses: actions/upload-artifact@v2
+with:
+ name: qpid_dispatch_wrk_${{matrix.os}}_${{matrix.buildType}}
+ path: /tmp/archive.tar.xz
+ test:
+name: "Test (${{matrix.os}}, shard ${{matrix.shard}} of ${{matrix.shards}}"
+runs-on: ${{ matrix.os }}
+needs: [build]
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+shard: [1, 2, 3, 4]
+shards: [4]
+env:
+ BuildType: ${{matrix.buildType}}
+ ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
+ DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
+ InstallPrefix: ${{github.workspace}}/install
+ PKG_CONFIG_PATH: ${{matrix.pkg_config_
[jira] [Commented] (DISPATCH-1726) Upgrade dependencies using dependabot PRs before the 1.13.0 release
[ https://issues.apache.org/jira/browse/DISPATCH-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170936#comment-17170936 ] ASF subversion and git services commented on DISPATCH-1726: --- Commit 6e71b31d8b843e02d47d114c4e92eaf298722cbf in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/patternfly-4.23.3 from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=6e71b31 ] DISPATCH-1726 Bump elliptic from 6.5.2 to 6.5.3 in /console/react (#807) > Upgrade dependencies using dependabot PRs before the 1.13.0 release > --- > > Key: DISPATCH-1726 > URL: https://issues.apache.org/jira/browse/DISPATCH-1726 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.12.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: 1.13.0 > > > Scope of the issue: The dependencies updated here should be only > devDependencies, or nonessential minor updates, and possibly security issues, > if any. Large updates, (such as d3) that require adapting to a different API > (sometimes significantly different, as in d3) are out of scope. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-960) TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on a listener
[ https://issues.apache.org/jira/browse/DISPATCH-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170934#comment-17170934 ] ASF subversion and git services commented on DISPATCH-960: -- Commit 13ea6033647bfc177cd0689541ce40b28568c3a6 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/patternfly-4.23.3 from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=13ea603 ] DISPATCH-960 Handle invalid configs when resolving port (#802) > TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on > a listener > --- > > Key: DISPATCH-960 > URL: https://issues.apache.org/jira/browse/DISPATCH-960 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.0.1, 1.12.0 >Reporter: Fernando Giorgetti >Assignee: Fernando Giorgetti >Priority: Major > Fix For: 1.13.0 > > Attachments: dispatch-960-reproducer.tar.gz > > > The default configuration for the dispatch router contains a default listener > set up to use 'port: amqp'. > If you change the default listener to use 'http: yes' and starts the router, > it causes an issue as the service name (amqp) is not resolved, and so the > router attempts to listen to port 0 (random), causing an unpredictable > behavior. > > A reproducer is attached to this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1741) Update console dependency for yargs-parser to avoid security warning
[ https://issues.apache.org/jira/browse/DISPATCH-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170941#comment-17170941 ] ASF subversion and git services commented on DISPATCH-1741: --- Commit c9bfd071ac2ba5515aaf5e51c7cf224a667210ac in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-table-4.12.1 from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c9bfd07 ] DISPATCH-1741: Regenerated package-lock.json for console and updated yargs-parser. The previous version of package-lock.json broke npm test > Update console dependency for yargs-parser to avoid security warning > > > Key: DISPATCH-1741 > URL: https://issues.apache.org/jira/browse/DISPATCH-1741 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.13.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.13.0 > > > A new security vulnerability was identified with the released version of > yargs-parser. > The dependency path is > react-scripts > webpack-dev-server > yargs > yargs-parser > Since react-scripts has not been updated to require the version of > yargs-parser that fixes the vulnerability, the package-lock.json file needs > to be updated manually to require yargs-parser version 13.1.2 > See https://github.com/facebook/create-react-app/issues/9033 for a discussion > on the issue with react-scripts. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1732) segfault when connecting to multitenant listener with policy but no hostname in open
[
https://issues.apache.org/jira/browse/DISPATCH-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170933#comment-17170933
]
ASF subversion and git services commented on DISPATCH-1732:
---
Commit 8dd77e3e56ba55a3b48dd3bb225fdff7bfd6d2cc in qpid-dispatch's branch
refs/heads/dependabot/npm_and_yarn/console/react/patternfly/patternfly-4.23.3
from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8dd77e3 ]
DISPATCH-1732: Policy multitenant vhost check if Open.hostname is absent
Null hostname causes segfault. Add self test to verify fix.
> segfault when connecting to multitenant listener with policy but no hostname
> in open
> -
>
> Key: DISPATCH-1732
> URL: https://issues.apache.org/jira/browse/DISPATCH-1732
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Policy Engine
>Affects Versions: 1.13.0
>Reporter: Gordon Sim
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
>
> Start router with following config file and then run qpid-receive against it
> (which by default does not set a hostname in open).
>
> {noformat}
> [
> ["listener", { "host": "0.0.0.0", "port": 5672, "multiTenant": true ,
> "policyVhost": "myhost"}],
> ["policy", {"enableVhostPolicy": true }],
> ["vhost", { "hostname": "myhost", "allowUnknownUser": true,
> "groups":{"$default":{"remoteHosts":"*","sources":"*","targets":"*","allowDynamicSource":true,"allowAnonymousSender":true}}}]
> ] {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1741) Update console dependency for yargs-parser to avoid security warning
[ https://issues.apache.org/jira/browse/DISPATCH-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170937#comment-17170937 ] ASF subversion and git services commented on DISPATCH-1741: --- Commit 2ca875c1591216896bb5442fd03b02ff8940f4b6 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/patternfly-4.23.3 from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2ca875c ] DISPATCH-1741: Manually bump console's yargs-parser depdency to version 13.1.2 to fix security vunerability > Update console dependency for yargs-parser to avoid security warning > > > Key: DISPATCH-1741 > URL: https://issues.apache.org/jira/browse/DISPATCH-1741 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.13.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.13.0 > > > A new security vulnerability was identified with the released version of > yargs-parser. > The dependency path is > react-scripts > webpack-dev-server > yargs > yargs-parser > Since react-scripts has not been updated to require the version of > yargs-parser that fixes the vulnerability, the package-lock.json file needs > to be updated manually to require yargs-parser version 13.1.2 > See https://github.com/facebook/create-react-app/issues/9033 for a discussion > on the issue with react-scripts. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1737) Policy config parse errors report wrong line and column numbers
[ https://issues.apache.org/jira/browse/DISPATCH-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170938#comment-17170938 ] ASF subversion and git services commented on DISPATCH-1737: --- Commit 578164f5ed4b84eeb31c71148cb3ba4843451248 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/patternfly-4.23.3 from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=578164f ] DISPATCH-1737: Log config file json as-modified when json parse fails When config file json parsing fails then the parser prints a line and column number of the offending input. Since the original input is modified by the config process the reported line and column numbers are not useful. This patch logs the input that json was given when parsing fails. The parser failure line and column numbers directly relate to logged json input lines and syntax errors may be identifed with some authority. This closes #808 > Policy config parse errors report wrong line and column numbers > > > Key: DISPATCH-1737 > URL: https://issues.apache.org/jira/browse/DISPATCH-1737 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.12.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > > Config files may be written in _router config_ format or _json_ format. > Either way the file data is reorganized internally into _json_ format. After > the data is reorganized then the original text formatting is lost. If there > is a json parse error then the json errors showing line and column numbers > are for the reformatted text and can not be correlated to the original input. > This issue adds error logs in the event of a config parse error. The logs > show the config data as it was presented to the json parser. Users may then > see specifically where the config parsing failed with respect to their > original input. > This issue is different from DISPATCH-1707. Fixing this issue will aid in > debugging and fixing that issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-960) TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on a listener
[ https://issues.apache.org/jira/browse/DISPATCH-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170935#comment-17170935 ] ASF subversion and git services commented on DISPATCH-960: -- Commit 97ac13417d77cd2f8a90acb837747abee438ed20 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/patternfly-4.23.3 from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=97ac134 ] DISPATCH-960 Use getservbyname on macOS (getservbyname_r not available) (#804) > TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on > a listener > --- > > Key: DISPATCH-960 > URL: https://issues.apache.org/jira/browse/DISPATCH-960 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.0.1, 1.12.0 >Reporter: Fernando Giorgetti >Assignee: Fernando Giorgetti >Priority: Major > Fix For: 1.13.0 > > Attachments: dispatch-960-reproducer.tar.gz > > > The default configuration for the dispatch router contains a default listener > set up to use 'port: amqp'. > If you change the default listener to use 'http: yes' and starts the router, > it causes an issue as the service name (amqp) is not resolved, and so the > router attempts to listen to port 0 (random), causing an unpredictable > behavior. > > A reproducer is attached to this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1737) Policy config parse errors report wrong line and column numbers
[ https://issues.apache.org/jira/browse/DISPATCH-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170940#comment-17170940 ] ASF subversion and git services commented on DISPATCH-1737: --- Commit 578164f5ed4b84eeb31c71148cb3ba4843451248 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/react-table-4.12.1 from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=578164f ] DISPATCH-1737: Log config file json as-modified when json parse fails When config file json parsing fails then the parser prints a line and column number of the offending input. Since the original input is modified by the config process the reported line and column numbers are not useful. This patch logs the input that json was given when parsing fails. The parser failure line and column numbers directly relate to logged json input lines and syntax errors may be identifed with some authority. This closes #808 > Policy config parse errors report wrong line and column numbers > > > Key: DISPATCH-1737 > URL: https://issues.apache.org/jira/browse/DISPATCH-1737 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.12.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > > Config files may be written in _router config_ format or _json_ format. > Either way the file data is reorganized internally into _json_ format. After > the data is reorganized then the original text formatting is lost. If there > is a json parse error then the json errors showing line and column numbers > are for the reformatted text and can not be correlated to the original input. > This issue adds error logs in the event of a config parse error. The logs > show the config data as it was presented to the json parser. Users may then > see specifically where the config parsing failed with respect to their > original input. > This issue is different from DISPATCH-1707. Fixing this issue will aid in > debugging and fixing that issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1568) Add unittest framework for testing C code
[ https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170932#comment-17170932 ] ASF subversion and git services commented on DISPATCH-1568: --- Commit c540d2c54cadbec0397821885317f2a89a1da115 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/patternfly/patternfly-4.23.3 from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c540d2c ] DISPATCH-1568: make license text and related files more specific > Add unittest framework for testing C code > - > > Key: DISPATCH-1568 > URL: https://issues.apache.org/jira/browse/DISPATCH-1568 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tests >Reporter: Nicolas >Priority: Major > Fix For: 1.13.0 > > Original Estimate: 336h > Remaining Estimate: 336h > > Right now we are not using any framework for easily write c unit-test when > developing (or later). > The idea is to research available libraries, pick one and try to include in > our workflow. > preliminary candidates: > [https://github.com/google/googletest] > [https://github.com/catchorg/Catch2] > [https://github.com/catchorg/Catch2/tree/Catch1.x] <- Actually, Qpid Proton > is using this one (old catch2) > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1739) Use GitHub Actions w/ sharding and bubblewrap for some fast CI
[
https://issues.apache.org/jira/browse/DISPATCH-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170942#comment-17170942
]
ASF GitHub Bot commented on DISPATCH-1739:
--
gemmellr commented on a change in pull request #809:
URL: https://github.com/apache/qpid-dispatch/pull/809#discussion_r465181148
##
File path: .github/workflows/build.yaml
##
@@ -0,0 +1,165 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Build
+
+on: [push, pull_request]
+
+jobs:
+ build:
+runs-on: ${{ matrix.os }}
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+env:
+ BuildType: ${{matrix.buildType}}
+ ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
+ DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
+ InstallPrefix: ${{github.workspace}}/install
+ ProtonCMakeExtraArgs: '-DBUILD_BINDINGS=python'
+ DispatchCMakeExtraArgs: ''
+steps:
+ - uses: actions/checkout@v2
+with:
+ repository: 'apache/qpid-proton'
+ ref: 'master'
+ path: 'qpid-proton'
+ - uses: actions/checkout@v2
+with:
+ path: 'qpid-dispatch'
+ - name: actions/cache@v2 node-modules
+uses: actions/cache@v2
+env:
+ cache-name: cache-node-modules
+with:
+ path: ~/.npm
+ key: ${{ runner.os }}-build-${{ env.cache-name }}-${{
hashFiles('**/package-lock.json') }}
+ restore-keys: |
+${{ runner.os }}-build-${{ env.cache-name }}-
+${{ runner.os }}-build-
+${{ runner.os }}-
+ - name: Create Build and Install directories
+run: mkdir -p "${ProtonBuildDir}" "${DispatchBuildDir}"
"{InstallPrefix}"
+shell: bash
+ - name: Setup python
+uses: actions/setup-python@v2
+with:
+ python-version: 3.6
+ architecture: x64
+ - name: Install python dependencies
+run: |
+ python -m pip install --upgrade pip
+ python -m pip install setuptools wheel tox
+ - name: Install Linux dependencies
+if: ${{ runner.os == 'Linux' }}
+run: |
+ sudo apt install -y swig ninja-build libpython3-dev libsasl2-dev
libjsoncpp-dev libwebsockets-dev xz-utils
+ - name: qpid-proton cmake configure
+working-directory: ${{env.ProtonBuildDir}}
+run: cmake "${{github.workspace}}/qpid-proton"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-DBUILD_TESTING=OFF" "-DENABLE_FUZZ_TESTING=OFF" "-GNinja"
${ProtonCMakeExtraArgs}
+shell: bash
+ - name: qpid-proton cmake build/install
+run: cmake --build "${ProtonBuildDir}" --config ${BuildType} -t install
+shell: bash
+ - name: qpid-dispatch cmake configure
+working-directory: ${{env.DispatchBuildDir}}
+run: cmake "${{github.workspace}}/qpid-dispatch"
"-DCMAKE_INSTALL_PREFIX=${InstallPrefix}" "-DCMAKE_BUILD_TYPE=${BuildType}"
"-GNinja" "-DUSE_BWRAP=ON" ${DispatchCMakeExtraArgs}
+shell: bash
+ - name: qpid-dispatch cmake build/install
+run: cmake --build "${DispatchBuildDir}" --config ${BuildType} -t
install
+shell: bash
+ # github actions/upload-artifact@v2 does not preserve file permissions
(executable)
+ - name: Compress build
+working-directory: ${{github.workspace}}
+run: tar --xz -cf /tmp/archive.tar.xz --exclude '*.o' --exclude
'*.pyc' --exclude '.git' --exclude='qpid-dispatch/build/console' qpid-dispatch
install qpid-proton/build/python/pkgs
+ - name: Upload archive
+uses: actions/upload-artifact@v2
+with:
+ name: qpid_dispatch_wrk_${{matrix.os}}_${{matrix.buildType}}
+ path: /tmp/archive.tar.xz
+ test:
+name: "Test (${{matrix.os}}, shard ${{matrix.shard}} of ${{matrix.shards}}"
+runs-on: ${{ matrix.os }}
+needs: [build]
+strategy:
+ fail-fast: false
+ matrix:
+os: [ubuntu-20.04]
+buildType: [RelWithDebInfo]
+shard: [1, 2, 3, 4]
+shards: [4]
+env:
+
[jira] [Created] (DISPATCH-1742) Plugin-API for protocol adaptors
Ted Ross created DISPATCH-1742: -- Summary: Plugin-API for protocol adaptors Key: DISPATCH-1742 URL: https://issues.apache.org/jira/browse/DISPATCH-1742 Project: Qpid Dispatch Issue Type: New Feature Reporter: Ted Ross Assignee: Ted Ross Fix For: Backlog This Jira tracks the creation of a protocol-adaptor API to be used in Qpid Dispatch Router to implement protocol access from non-AMQP protocols. These adaptors run in the I/O thread pool and use the services of the router-core via the router-core API. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1743) Add HTTP/2 support to the router
Ganesh Murthy created DISPATCH-1743: --- Summary: Add HTTP/2 support to the router Key: DISPATCH-1743 URL: https://issues.apache.org/jira/browse/DISPATCH-1743 Project: Qpid Dispatch Issue Type: New Feature Components: Container Reporter: Ganesh Murthy Assignee: Ganesh Murthy Add new feature to support HTTP/2 protocol on the router. This feature involves the introduction of new entities to the router called httpListener and httpConnector. The httpListener will accept HTTP/2 connections and make an outbound connection using the httpConnector. The router will use AMQP to route the messages. The router will act as a protocol bridge. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1744) Add HTTP/1.1 support to the router
Ganesh Murthy created DISPATCH-1744: --- Summary: Add HTTP/1.1 support to the router Key: DISPATCH-1744 URL: https://issues.apache.org/jira/browse/DISPATCH-1744 Project: Qpid Dispatch Issue Type: New Feature Components: Container Reporter: Ganesh Murthy Assignee: Ken Giusti Add new feature to support HTTP/1.1 protocol on the router. This feature involves the introduction of new entities to the router called httpListener and httpConnector. The httpListener will accept HTTP/1.1 connections and make an outbound connection using the httpConnector. The router will use AMQP to route the messages. The router will act as a protocol bridge. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1654) tcp protocol bridging (ingress and egress)
[ https://issues.apache.org/jira/browse/DISPATCH-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170960#comment-17170960 ] Gordon Sim commented on DISPATCH-1654: -- See also DISPATCH-1742 > tcp protocol bridging (ingress and egress) > -- > > Key: DISPATCH-1654 > URL: https://issues.apache.org/jira/browse/DISPATCH-1654 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1653) http protocol bridging (ingress and egress)
[ https://issues.apache.org/jira/browse/DISPATCH-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170961#comment-17170961 ] Gordon Sim commented on DISPATCH-1653: -- See also DISPATCH-1742 > http protocol bridging (ingress and egress) > --- > > Key: DISPATCH-1653 > URL: https://issues.apache.org/jira/browse/DISPATCH-1653 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1735) system_tests_management failing on Fedora 32
[
https://issues.apache.org/jira/browse/DISPATCH-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170984#comment-17170984
]
Ganesh Murthy commented on DISPATCH-1735:
-
I am on Fedora 32
{noformat}
[gmurthy@localhost qpid-dispatch]$ python --version
Python 3.8.3
[gmurthy@localhost qpid-dispatch]$ {noformat}
I added the following to python_embedded.c
{noformat}
[gmurthy@localhost qpid-dispatch]$ git diff src/python_embedded.c
diff --git a/src/python_embedded.c b/src/python_embedded.c
index 7265eb29..60bae6df 100644
--- a/src/python_embedded.c
+++ b/src/python_embedded.c
@@ -656,6 +656,17 @@ static void qd_io_rx_handler(void *context, qd_message_t
*msg, int link_id, int
iter_to_py_attr(qd_message_field_iterator(msg,
QD_FIELD_APPLICATION_PROPERTIES), py_iter_parse, py_msg, "properties");
iter_to_py_attr(qd_message_field_iterator(msg, QD_FIELD_BODY),
py_iter_parse, py_msg, "body");
+
+PyObject* properties_map = PyObject_GetAttrString(py_msg, "properties");
+PyObject* data = PyDict_GetItemString(properties_map, "data");
+if (data) {
+if (PyBytes_CheckExact(data)) {
+printf ("BATMAN qd_io_rx_handler PyBytes_CheckExact is True\n");
+}
+}
+
PyObject *value = PyObject_CallFunction(self->handler, "Oil", py_msg,
link_id, inter_router_cost);
Py_DECREF(py_msg);
[gmurthy@localhost qpid-dispatch]$
{noformat}
And I see the output
{noformat}
BATMAN qd_io_rx_handler PyBytes_CheckExact is True {noformat}
So, the C code is doing the right thing here by setting the the type of the
value in the dict to byte. The python code is called using the following line
{noformat}
PyObject *value = PyObject_CallFunction(self->handler, "Oil", py_msg, link_id,
inter_router_cost); {noformat}
which in turn calls this function -
[https://github.com/apache/qpid-dispatch/blob/1.12.0/python/qpid_dispatch_internal/management/agent.py#L821]
When you try to get the type of key 'data' in request.properties, it prints
In summary, I think the Python object API (PyObject*) has a bug. This test does
not fail in Python 3.6
{noformat}
{noformat}
> system_tests_management failing on Fedora 32
>
>
> Key: DISPATCH-1735
> URL: https://issues.apache.org/jira/browse/DISPATCH-1735
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 19: ==
> 19: FAIL: test_dummy (system_tests_management.ManagementTest)
> 19: Test all operations on the dummy test entity
> 19: --
> 19: Traceback (most recent call last):
> 19: File
> "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_management.py",
> line 347, in test_dummy
> 19: self.assertEqual(
> 19: AssertionError: {'operation': 'callme', 'type': 'org.apache[58
> chars]tes'} != {'type': 'org.apache.qpid.dispatch.dummy', [57 chars]y/0'}
> 19: - {'data': b'bytes',
> 19: ? -
> 19:
> 19: + {'data': 'bytes',
> 19:'identity': 'dummy/0',
> 19:'operation': 'callme',
> 19:'type': 'org.apache.qpid.dispatch.dummy'}
> 19:
> 19: --
> 19: Ran 21 tests in 9.483s
> 19:
> 19: FAILED (failures=1)
> 1/1 Test #19: system_tests_management ..***Failed9.69 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-1735) system_tests_management failing on Fedora 32
[
https://issues.apache.org/jira/browse/DISPATCH-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170984#comment-17170984
]
Ganesh Murthy edited comment on DISPATCH-1735 at 8/4/20, 5:57 PM:
--
I am on Fedora 32
{noformat}
[gmurthy@localhost qpid-dispatch]$ python --version
Python 3.8.3
[gmurthy@localhost qpid-dispatch]$ {noformat}
I added the following to python_embedded.c
{noformat}
[gmurthy@localhost qpid-dispatch]$ git diff src/python_embedded.c
diff --git a/src/python_embedded.c b/src/python_embedded.c
index 7265eb29..60bae6df 100644
--- a/src/python_embedded.c
+++ b/src/python_embedded.c
@@ -656,6 +656,17 @@ static void qd_io_rx_handler(void *context, qd_message_t
*msg, int link_id, int
iter_to_py_attr(qd_message_field_iterator(msg,
QD_FIELD_APPLICATION_PROPERTIES), py_iter_parse, py_msg, "properties");
iter_to_py_attr(qd_message_field_iterator(msg, QD_FIELD_BODY),
py_iter_parse, py_msg, "body");
+
+PyObject* properties_map = PyObject_GetAttrString(py_msg, "properties");
+PyObject* data = PyDict_GetItemString(properties_map, "data");
+if (data) {
+if (PyBytes_CheckExact(data)) {
+printf ("BATMAN qd_io_rx_handler PyBytes_CheckExact is True\n");
+}
+}
+
PyObject *value = PyObject_CallFunction(self->handler, "Oil", py_msg,
link_id, inter_router_cost);
Py_DECREF(py_msg);
[gmurthy@localhost qpid-dispatch]$
{noformat}
When I run the failing test -
{noformat}
/usr/bin/python "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py"
"-m" "unittest" "-v" "system_tests_management.ManagementTest.test_dummy"
{noformat}
I see the output
{noformat}
BATMAN qd_io_rx_handler PyBytes_CheckExact is True {noformat}
So, the C code is doing the right thing here by setting the the type of the
value in the dict to byte. The python code is called from the c code (in
python_embedded.c) using the following line
{noformat}
PyObject *value = PyObject_CallFunction(self->handler, "Oil", py_msg, link_id,
inter_router_cost); {noformat}
which in turn calls this function -
[https://github.com/apache/qpid-dispatch/blob/1.12.0/python/qpid_dispatch_internal/management/agent.py#L821]
When you try to get the type of key 'data' in request.properties, it prints
In summary, I think the Python object API (PyObject*) has a bug. This test does
not fail in Python 3.6
{noformat}
{noformat}
was (Author: ganeshmurthy):
I am on Fedora 32
{noformat}
[gmurthy@localhost qpid-dispatch]$ python --version
Python 3.8.3
[gmurthy@localhost qpid-dispatch]$ {noformat}
I added the following to python_embedded.c
{noformat}
[gmurthy@localhost qpid-dispatch]$ git diff src/python_embedded.c
diff --git a/src/python_embedded.c b/src/python_embedded.c
index 7265eb29..60bae6df 100644
--- a/src/python_embedded.c
+++ b/src/python_embedded.c
@@ -656,6 +656,17 @@ static void qd_io_rx_handler(void *context, qd_message_t
*msg, int link_id, int
iter_to_py_attr(qd_message_field_iterator(msg,
QD_FIELD_APPLICATION_PROPERTIES), py_iter_parse, py_msg, "properties");
iter_to_py_attr(qd_message_field_iterator(msg, QD_FIELD_BODY),
py_iter_parse, py_msg, "body");
+
+PyObject* properties_map = PyObject_GetAttrString(py_msg, "properties");
+PyObject* data = PyDict_GetItemString(properties_map, "data");
+if (data) {
+if (PyBytes_CheckExact(data)) {
+printf ("BATMAN qd_io_rx_handler PyBytes_CheckExact is True\n");
+}
+}
+
PyObject *value = PyObject_CallFunction(self->handler, "Oil", py_msg,
link_id, inter_router_cost);
Py_DECREF(py_msg);
[gmurthy@localhost qpid-dispatch]$
{noformat}
And I see the output
{noformat}
BATMAN qd_io_rx_handler PyBytes_CheckExact is True {noformat}
So, the C code is doing the right thing here by setting the the type of the
value in the dict to byte. The python code is called using the following line
{noformat}
PyObject *value = PyObject_CallFunction(self->handler, "Oil", py_msg, link_id,
inter_router_cost); {noformat}
which in turn calls this function -
[https://github.com/apache/qpid-dispatch/blob/1.12.0/python/qpid_dispatch_internal/management/agent.py#L821]
When you try to get the type of key 'data' in request.properties, it prints
In summary, I think the Python object API (PyObject*) has a bug. This test does
not fail in Python 3.6
{noformat}
{noformat}
> system_tests_management failing on Fedora 32
>
>
> Key: DISPATCH-1735
> URL: https://issues.apache.org/jira/browse/DISPATCH-1735
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 19: ==
> 19
[jira] [Commented] (DISPATCH-1743) Add HTTP/2 support to the router
[ https://issues.apache.org/jira/browse/DISPATCH-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171002#comment-17171002 ] Ganesh Murthy commented on DISPATCH-1743: - See also DISPATCH-1742 > Add HTTP/2 support to the router > > > Key: DISPATCH-1743 > URL: https://issues.apache.org/jira/browse/DISPATCH-1743 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Add new feature to support HTTP/2 protocol on the router. > This feature involves the introduction of new entities to the router called > httpListener and httpConnector. The httpListener will accept HTTP/2 > connections and make an outbound connection using the httpConnector. > The router will use AMQP to route the messages. The router will act as a > protocol bridge. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1744) Add HTTP/1.1 support to the router
[ https://issues.apache.org/jira/browse/DISPATCH-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171003#comment-17171003 ] Ganesh Murthy commented on DISPATCH-1744: - See also DISPATCH-1742 > Add HTTP/1.1 support to the router > -- > > Key: DISPATCH-1744 > URL: https://issues.apache.org/jira/browse/DISPATCH-1744 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Container >Reporter: Ganesh Murthy >Assignee: Ken Giusti >Priority: Major > > Add new feature to support HTTP/1.1 protocol on the router. > This feature involves the introduction of new entities to the router called > httpListener and httpConnector. The httpListener will accept HTTP/1.1 > connections and make an outbound connection using the httpConnector. > The router will use AMQP to route the messages. The router will act as a > protocol bridge. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-1653) http protocol bridging (ingress and egress)
[ https://issues.apache.org/jira/browse/DISPATCH-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171004#comment-17171004 ] Ganesh Murthy edited comment on DISPATCH-1653 at 8/4/20, 6:03 PM: -- This has been split out into two Jiras (one for HTTP/2 and one for HTTP/1.1 https://issues.apache.org/jira/browse/DISPATCH-1744 https://issues.apache.org/jira/browse/DISPATCH-1743 was (Author: ganeshmurthy): This has been split out into two Jiras https://issues.apache.org/jira/browse/DISPATCH-1744 https://issues.apache.org/jira/browse/DISPATCH-1743 > http protocol bridging (ingress and egress) > --- > > Key: DISPATCH-1653 > URL: https://issues.apache.org/jira/browse/DISPATCH-1653 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1653) http protocol bridging (ingress and egress)
[ https://issues.apache.org/jira/browse/DISPATCH-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171004#comment-17171004 ] Ganesh Murthy commented on DISPATCH-1653: - This has been split out into two Jiras https://issues.apache.org/jira/browse/DISPATCH-1744 https://issues.apache.org/jira/browse/DISPATCH-1743 > http protocol bridging (ingress and egress) > --- > > Key: DISPATCH-1653 > URL: https://issues.apache.org/jira/browse/DISPATCH-1653 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #806: DISPATCH-1736 - Removed skip_test flag that was wrongly added in comm…
asfgit closed pull request #806: URL: https://github.com/apache/qpid-dispatch/pull/806 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1736) system_tests_protocol_settings should not skip any tests
[ https://issues.apache.org/jira/browse/DISPATCH-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171029#comment-17171029 ] ASF subversion and git services commented on DISPATCH-1736: --- Commit ab97ddf2bc799d6c45aef7141b2089f2591ea15f in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=ab97ddf ] DISPATCH-1736 - Removed skip_test flag that was wrongly added in commit 4a173e1ec0f7e0e8f9d7d37b9549d4f9c9d37fb0. This test should run all arches, 32 or 64 bit. This closes #806. > system_tests_protocol_settings should not skip any tests > > > Key: DISPATCH-1736 > URL: https://issues.apache.org/jira/browse/DISPATCH-1736 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > As part of commit 4a173e1ec0f7e0e8f9d7d37b9549d4f9c9d37fb0, a skip_test flag > was wrongly added to skip the tests on 32 bit machines. This flag must be > removed and no tests must be skipped. This test should work on all arches 32 > and 64 bit -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1736) system_tests_protocol_settings should not skip any tests
[ https://issues.apache.org/jira/browse/DISPATCH-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171030#comment-17171030 ] ASF GitHub Bot commented on DISPATCH-1736: -- asfgit closed pull request #806: URL: https://github.com/apache/qpid-dispatch/pull/806 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > system_tests_protocol_settings should not skip any tests > > > Key: DISPATCH-1736 > URL: https://issues.apache.org/jira/browse/DISPATCH-1736 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > As part of commit 4a173e1ec0f7e0e8f9d7d37b9549d4f9c9d37fb0, a skip_test flag > was wrongly added to skip the tests on 32 bit machines. This flag must be > removed and no tests must be skipped. This test should work on all arches 32 > and 64 bit -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1736) system_tests_protocol_settings should not skip any tests
[ https://issues.apache.org/jira/browse/DISPATCH-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1736. - Fix Version/s: 1.13.0 Resolution: Fixed > system_tests_protocol_settings should not skip any tests > > > Key: DISPATCH-1736 > URL: https://issues.apache.org/jira/browse/DISPATCH-1736 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.13.0 > > > As part of commit 4a173e1ec0f7e0e8f9d7d37b9549d4f9c9d37fb0, a skip_test flag > was wrongly added to skip the tests on 32 bit machines. This flag must be > removed and no tests must be skipped. This test should work on all arches 32 > and 64 bit -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (DISPATCH-1653) http protocol bridging (ingress and egress)
[ https://issues.apache.org/jira/browse/DISPATCH-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim closed DISPATCH-1653. Resolution: Duplicate > http protocol bridging (ingress and egress) > --- > > Key: DISPATCH-1653 > URL: https://issues.apache.org/jira/browse/DISPATCH-1653 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Gordon Sim >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1733) system_tests_open_properties failure due to qdr_connection_t leak
[
https://issues.apache.org/jira/browse/DISPATCH-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171042#comment-17171042
]
ASF subversion and git services commented on DISPATCH-1733:
---
Commit 283e9a513a01c5bc4108bda432f2004b764c5dd0 in qpid-dispatch's branch
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=283e9a5 ]
DISPATCH-1733 - Free leaking qdr_connection_t when the router core action has
been discarded. This closes #803
> system_tests_open_properties failure due to qdr_connection_t leak
> -
>
> Key: DISPATCH-1733
> URL: https://issues.apache.org/jira/browse/DISPATCH-1733
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Priority: Major
> Labels: Leak
>
> {noformat}
> 67: ==
> 67: ERROR: test_01_verify_listener_properties
> (system_tests_open_properties.OpenPropertiesConfigTest)
> 67: --
> 67: Traceback (most recent call last):
> 67: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_open_properties.py",
> line 197, in test_01_verify_listener_properties
> 67: self._valid_properties_check(OpenPropertiesClient)
> 67: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_open_properties.py",
> line 194, in _valid_properties_check
> 67: router.teardown()
> 67: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 538, in teardown
> 67: raise teardown_exc
> 67: RuntimeError: Process 14125 error: exit code -6, expected 0
> 67: qdrouterd -c Router2.conf -I
> /home/travis/build/apache/qpid-dispatch/python
> 67:
> /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_open_properties/OpenPropertiesConfigTest/test_01_verify_listener_properties/Router2-15.cmd
> 67:
> 67: ERROR: Aborted due to unexpected alloc pool leak of type
> 'qdr_connection_t'
> 67:
> 67: alloc.c: Items of type 'qdr_connection_t' remain allocated at shutdown: 1
> 67: Leak: 2020-07-30 10:22:26.902114 + type: qdr_connection_t address:
> 0x1818e10
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0x842)
> [0x7f09cefafd6c]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(new_qdr_connection_t+0x38)
> [0x7f09cf00ad3b]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qdr_connection_opened+0x79)
> [0x7f09cf00b19a]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x1026d4)
> [0x7f09cf0626d4]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x103557)
> [0x7f09cf063557]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x5ecee)
> [0x7f09cefbecee]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(policy_notify_opened+0x3d)
> [0x7f09cefbedfd]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_policy_amqp_open+0x67f)
> [0x7f09cefea388]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_container_handle_event+0x117)
> [0x7f09cefbfea6]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x10efa0)
> [0x7f09cf06efa0]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1733) system_tests_open_properties failure due to qdr_connection_t leak
[
https://issues.apache.org/jira/browse/DISPATCH-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171043#comment-17171043
]
ASF GitHub Bot commented on DISPATCH-1733:
--
asfgit closed pull request #803:
URL: https://github.com/apache/qpid-dispatch/pull/803
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_open_properties failure due to qdr_connection_t leak
> -
>
> Key: DISPATCH-1733
> URL: https://issues.apache.org/jira/browse/DISPATCH-1733
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Priority: Major
> Labels: Leak
>
> {noformat}
> 67: ==
> 67: ERROR: test_01_verify_listener_properties
> (system_tests_open_properties.OpenPropertiesConfigTest)
> 67: --
> 67: Traceback (most recent call last):
> 67: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_open_properties.py",
> line 197, in test_01_verify_listener_properties
> 67: self._valid_properties_check(OpenPropertiesClient)
> 67: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_open_properties.py",
> line 194, in _valid_properties_check
> 67: router.teardown()
> 67: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 538, in teardown
> 67: raise teardown_exc
> 67: RuntimeError: Process 14125 error: exit code -6, expected 0
> 67: qdrouterd -c Router2.conf -I
> /home/travis/build/apache/qpid-dispatch/python
> 67:
> /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_open_properties/OpenPropertiesConfigTest/test_01_verify_listener_properties/Router2-15.cmd
> 67:
> 67: ERROR: Aborted due to unexpected alloc pool leak of type
> 'qdr_connection_t'
> 67:
> 67: alloc.c: Items of type 'qdr_connection_t' remain allocated at shutdown: 1
> 67: Leak: 2020-07-30 10:22:26.902114 + type: qdr_connection_t address:
> 0x1818e10
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0x842)
> [0x7f09cefafd6c]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(new_qdr_connection_t+0x38)
> [0x7f09cf00ad3b]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qdr_connection_opened+0x79)
> [0x7f09cf00b19a]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x1026d4)
> [0x7f09cf0626d4]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x103557)
> [0x7f09cf063557]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x5ecee)
> [0x7f09cefbecee]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(policy_notify_opened+0x3d)
> [0x7f09cefbedfd]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_policy_amqp_open+0x67f)
> [0x7f09cefea388]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_container_handle_event+0x117)
> [0x7f09cefbfea6]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x10efa0)
> [0x7f09cf06efa0]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #803: DISPATCH-1733 - Free leaking qdr_connection_t when the router core ac…
asfgit closed pull request #803: URL: https://github.com/apache/qpid-dispatch/pull/803 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1733) system_tests_open_properties failure due to qdr_connection_t leak
[
https://issues.apache.org/jira/browse/DISPATCH-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-1733.
-
Fix Version/s: 1.13.0
Assignee: Ganesh Murthy
Resolution: Fixed
> system_tests_open_properties failure due to qdr_connection_t leak
> -
>
> Key: DISPATCH-1733
> URL: https://issues.apache.org/jira/browse/DISPATCH-1733
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Labels: Leak
> Fix For: 1.13.0
>
>
> {noformat}
> 67: ==
> 67: ERROR: test_01_verify_listener_properties
> (system_tests_open_properties.OpenPropertiesConfigTest)
> 67: --
> 67: Traceback (most recent call last):
> 67: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_open_properties.py",
> line 197, in test_01_verify_listener_properties
> 67: self._valid_properties_check(OpenPropertiesClient)
> 67: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_open_properties.py",
> line 194, in _valid_properties_check
> 67: router.teardown()
> 67: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 538, in teardown
> 67: raise teardown_exc
> 67: RuntimeError: Process 14125 error: exit code -6, expected 0
> 67: qdrouterd -c Router2.conf -I
> /home/travis/build/apache/qpid-dispatch/python
> 67:
> /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_open_properties/OpenPropertiesConfigTest/test_01_verify_listener_properties/Router2-15.cmd
> 67:
> 67: ERROR: Aborted due to unexpected alloc pool leak of type
> 'qdr_connection_t'
> 67:
> 67: alloc.c: Items of type 'qdr_connection_t' remain allocated at shutdown: 1
> 67: Leak: 2020-07-30 10:22:26.902114 + type: qdr_connection_t address:
> 0x1818e10
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0x842)
> [0x7f09cefafd6c]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(new_qdr_connection_t+0x38)
> [0x7f09cf00ad3b]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qdr_connection_opened+0x79)
> [0x7f09cf00b19a]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x1026d4)
> [0x7f09cf0626d4]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x103557)
> [0x7f09cf063557]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x5ecee)
> [0x7f09cefbecee]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(policy_notify_opened+0x3d)
> [0x7f09cefbedfd]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_policy_amqp_open+0x67f)
> [0x7f09cefea388]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_container_handle_event+0x117)
> [0x7f09cefbfea6]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x10efa0)
> [0x7f09cf06efa0]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1707) Policy config file fails with cryptic error if trailing brace on wrong line
[
https://issues.apache.org/jira/browse/DISPATCH-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles E. Rolke reassigned DISPATCH-1707:
--
Assignee: Charles E. Rolke
> Policy config file fails with cryptic error if trailing brace on wrong line
> ---
>
> Key: DISPATCH-1707
> URL: https://issues.apache.org/jira/browse/DISPATCH-1707
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Management Agent, Policy Engine
>Affects Versions: 1.12.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
>
> If a policy vhost in a config file is specified like this
> {code:java}
> vhost {
> hostname: 0.0.0.0
> allowUnknownUser: true
> groups: {
> "$default": {
> "users": "*",
> "remoteHosts": "*",
> "allowDynamicSource": true,
> "allowAnonymousSender": true,
> "sources": "*",
> "targets": "*"}
> }
> }
> {code}
> then it works fine. Buf if the trailing brace after _targets_ is on a line by
> itself
> {code:java}
> vhost {
> hostname: 0.0.0.0
> allowUnknownUser: true
> groups: {
> "$default": {
> "users": "*",
> "remoteHosts": "*",
> "allowDynamicSource": true,
> "allowAnonymousSender": true,
> "sources": "*",
> "targets": "*"
> }
> }
> }
> {code}
>
> then it fails with a confusing message that does not pinpoint what is wrong.
> {code:java}
> > qdrouterd -c permissive-info.conf
> 2020-07-08 11:18:36.907041 -0400 ERROR (error) Python: Exception: Cannot load
> configuration file permissive-info.conf: Expecting ',' delimiter: line 46
> column 3 (char 723)
> 2020-07-08 11:18:36.907563 -0400 ERROR (error) Traceback (most recent call
> last):
> File
> "/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
> line 61, in __init__
> self.load(filename, raw_json)
> File
> "/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
> line 221, in load
> self.load(f, raw_json)
> File
> "/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
> line 223, in load
> sections = self._parserawjson(source) if raw_json else self._parse(source)
> File
> "/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
> line 193, in _parse
> sections = json.loads(js_text)
> File "/usr/lib64/python3.7/json/__init__.py", line 348, in loads
> return _default_decoder.decode(s)
> File "/usr/lib64/python3.7/json/decoder.py", line 337, in decode
> obj, end = self.raw_decode(s, idx=_w(s, 0).end())
> File "/usr/lib64/python3.7/json/decoder.py", line 353, in raw_decode
> obj, end = self.scan_once(s, idx)
> json.decoder.JSONDecodeError: Expecting ',' delimiter: line 46 column 3 (char
> 723)
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File
> "/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
> line 251, in configure_dispatch
> config = Config(filename)
> File
> "/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
> line 64, in __init__
> % (filename, e))
> Exception: Cannot load configuration file permissive-info.conf: Expecting ','
> delimiter: line 46 column 3 (char 723)
> 2020-07-08 11:18:36.907599 -0400 MAIN (critical) Router start-up failed:
> Python: Exception: Cannot load configuration file permissive-info.conf:
> Expecting ',' delimiter: line 46 column 3 (char 723)
> qdrouterd: Python: Exception: Cannot load configuration file
> permissive-info.conf: Expecting ',' delimiter: line 46 column 3 (char 723)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-1728) Enforce SASL dependency in build metadata
[ https://issues.apache.org/jira/browse/DISPATCH-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170840#comment-17170840 ] Ganesh Murthy edited comment on DISPATCH-1728 at 8/4/20, 6:53 PM: -- The router tests (for example system_tests_sasl_plain.py) uses a proton python binding function called SASL.extended() (which in turn calls pn_sasl_extended()) to skip the tests like seen here - [https://github.com/apache/qpid-dispatch/blob/master/tests/system_tests_sasl_plain.py#L80] In the Proton build, in cases where SASL libraries are not available, the cyrus_stub.c is included as seen here [https://github.com/apache/qpid-proton/blob/master/c/CMakeLists.txt#L100] In the case here [https://gist.github.com/ssorj/80b79856ee233aab2067c88f967273f6] since proton is directly installed, the SASL.extended() returns true and the Dispatch tests start executing. [~jross] Dispatch CMakeLists.txt must do the same thing as being done in the Proton CMakeLists.txt to skip the tests instead of using Proton's SASL.extended() function. Please let me know what you think. was (Author: ganeshmurthy): The router tests (for example system_tests_sasl_plain.py) uses a proton python binding function called SASL.extended() (which in turn calls pn_sasl_extended()) to skip the tests like seen here - [https://github.com/apache/qpid-dispatch/blob/master/tests/system_tests_sasl_plain.py#L80] In Proton, in the cases where SASL libraries are not available, the cyrus_stub.c is included as seen here [https://github.com/apache/qpid-proton/blob/master/c/CMakeLists.txt#L100] In the case here [https://gist.github.com/ssorj/80b79856ee233aab2067c88f967273f6] since proton is directly installed, the SASL.extended() returns true and the Dispatch tests start executing. [~jross] Dispatch CMakeLists.txt must do the same thing as being done in the Proton CMakeLists.txt to skip the tests instead of using Proton's SASL.extended() function. Please let me know what you think. > Enforce SASL dependency in build metadata > - > > Key: DISPATCH-1728 > URL: https://issues.apache.org/jira/browse/DISPATCH-1728 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Justin Ross >Assignee: Ganesh Murthy >Priority: Major > > The tests require Cyrus SASL and the SASL plain mechanism. Those should be > expressed as dependencies in cmake or in a pre-test dependency check. > Otherwise, you can build the project and start running the tests before you > find out you are missing them. > A dockerfile that shows the problem: > https://gist.github.com/ssorj/80b79856ee233aab2067c88f967273f6 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-1728) Enforce SASL dependency in build metadata
[ https://issues.apache.org/jira/browse/DISPATCH-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170840#comment-17170840 ] Ganesh Murthy edited comment on DISPATCH-1728 at 8/4/20, 6:54 PM: -- The router tests (for example system_tests_sasl_plain.py) uses a proton python binding function called SASL.extended() (which in turn calls pn_sasl_extended()) to skip the tests like seen here - [https://github.com/apache/qpid-dispatch/blob/master/tests/system_tests_sasl_plain.py#L80] In the Proton build, in cases where SASL libraries are not available, the cyrus_stub.c is included as seen here [https://github.com/apache/qpid-proton/blob/master/c/CMakeLists.txt#L100] In the case here [https://gist.github.com/ssorj/80b79856ee233aab2067c88f967273f6] since proton is directly installed, the SASL.extended() returns true and the Dispatch tests start executing even though the SASL libraries are not present and they start failing. [~jross] Dispatch CMakeLists.txt must do the same thing as being done in the Proton CMakeLists.txt to skip the tests instead of using Proton's SASL.extended() function. Please let me know what you think. was (Author: ganeshmurthy): The router tests (for example system_tests_sasl_plain.py) uses a proton python binding function called SASL.extended() (which in turn calls pn_sasl_extended()) to skip the tests like seen here - [https://github.com/apache/qpid-dispatch/blob/master/tests/system_tests_sasl_plain.py#L80] In the Proton build, in cases where SASL libraries are not available, the cyrus_stub.c is included as seen here [https://github.com/apache/qpid-proton/blob/master/c/CMakeLists.txt#L100] In the case here [https://gist.github.com/ssorj/80b79856ee233aab2067c88f967273f6] since proton is directly installed, the SASL.extended() returns true and the Dispatch tests start executing. [~jross] Dispatch CMakeLists.txt must do the same thing as being done in the Proton CMakeLists.txt to skip the tests instead of using Proton's SASL.extended() function. Please let me know what you think. > Enforce SASL dependency in build metadata > - > > Key: DISPATCH-1728 > URL: https://issues.apache.org/jira/browse/DISPATCH-1728 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Justin Ross >Assignee: Ganesh Murthy >Priority: Major > > The tests require Cyrus SASL and the SASL plain mechanism. Those should be > expressed as dependencies in cmake or in a pre-test dependency check. > Otherwise, you can build the project and start running the tests before you > find out you are missing them. > A dockerfile that shows the problem: > https://gist.github.com/ssorj/80b79856ee233aab2067c88f967273f6 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1742) Plugin-API for protocol adaptors
[ https://issues.apache.org/jira/browse/DISPATCH-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171053#comment-17171053 ] ASF subversion and git services commented on DISPATCH-1742: --- Commit bcc2ddff7e20c7c8981d91a8ebe388a6de15eb2f in qpid-dispatch's branch refs/heads/dev-protocol-adaptors from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=bcc2ddf ] DISPATCH-1742 Dataplane: Fixups from rebase to master. > Plugin-API for protocol adaptors > > > Key: DISPATCH-1742 > URL: https://issues.apache.org/jira/browse/DISPATCH-1742 > Project: Qpid Dispatch > Issue Type: New Feature >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: Backlog > > > This Jira tracks the creation of a protocol-adaptor API to be used in Qpid > Dispatch Router to implement protocol access from non-AMQP protocols. These > adaptors run in the I/O thread pool and use the services of the router-core > via the router-core API. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1707) Policy config file fails with cryptic error if trailing brace on wrong line
[
https://issues.apache.org/jira/browse/DISPATCH-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171057#comment-17171057
]
ASF GitHub Bot commented on DISPATCH-1707:
--
ChugR opened a new pull request #811:
URL: https://github.com/apache/qpid-dispatch/pull/811
This patch reorganizes the parse accounting for json fields embedded
in a dispatch-config formatted config file. Policy vhost groups hold
doubly-nested maps and those need to be detected and retired as they
come and go.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Policy config file fails with cryptic error if trailing brace on wrong line
> ---
>
> Key: DISPATCH-1707
> URL: https://issues.apache.org/jira/browse/DISPATCH-1707
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Management Agent, Policy Engine
>Affects Versions: 1.12.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
>
> If a policy vhost in a config file is specified like this
> {code:java}
> vhost {
> hostname: 0.0.0.0
> allowUnknownUser: true
> groups: {
> "$default": {
> "users": "*",
> "remoteHosts": "*",
> "allowDynamicSource": true,
> "allowAnonymousSender": true,
> "sources": "*",
> "targets": "*"}
> }
> }
> {code}
> then it works fine. Buf if the trailing brace after _targets_ is on a line by
> itself
> {code:java}
> vhost {
> hostname: 0.0.0.0
> allowUnknownUser: true
> groups: {
> "$default": {
> "users": "*",
> "remoteHosts": "*",
> "allowDynamicSource": true,
> "allowAnonymousSender": true,
> "sources": "*",
> "targets": "*"
> }
> }
> }
> {code}
>
> then it fails with a confusing message that does not pinpoint what is wrong.
> {code:java}
> > qdrouterd -c permissive-info.conf
> 2020-07-08 11:18:36.907041 -0400 ERROR (error) Python: Exception: Cannot load
> configuration file permissive-info.conf: Expecting ',' delimiter: line 46
> column 3 (char 723)
> 2020-07-08 11:18:36.907563 -0400 ERROR (error) Traceback (most recent call
> last):
> File
> "/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
> line 61, in __init__
> self.load(filename, raw_json)
> File
> "/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
> line 221, in load
> self.load(f, raw_json)
> File
> "/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
> line 223, in load
> sections = self._parserawjson(source) if raw_json else self._parse(source)
> File
> "/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
> line 193, in _parse
> sections = json.loads(js_text)
> File "/usr/lib64/python3.7/json/__init__.py", line 348, in loads
> return _default_decoder.decode(s)
> File "/usr/lib64/python3.7/json/decoder.py", line 337, in decode
> obj, end = self.raw_decode(s, idx=_w(s, 0).end())
> File "/usr/lib64/python3.7/json/decoder.py", line 353, in raw_decode
> obj, end = self.scan_once(s, idx)
> json.decoder.JSONDecodeError: Expecting ',' delimiter: line 46 column 3 (char
> 723)
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File
> "/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
> line 251, in configure_dispatch
> config = Config(filename)
> File
> "/opt/local/lib/qpid-dispatch/python/qpid_dispatch_internal/management/config.py",
> line 64, in __init__
> % (filename, e))
> Exception: Cannot load configuration file permissive-info.conf: Expecting ','
> delimiter: line 46 column 3 (char 723)
> 2020-07-08 11:18:36.907599 -0400 MAIN (critical) Router start-up failed:
> Python: Exception: Cannot load configuration file permissive-info.conf:
> Expecting ',' delimiter: line 46 column 3 (char 723)
> qdrouterd: Python: Exception: Cannot load configuration file
> permissive-info.conf: Expecting ',' delimiter: line 46 column 3 (char 723)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR opened a new pull request #811: DISPATCH-1707: Accept trailing brace on separate line
ChugR opened a new pull request #811: URL: https://github.com/apache/qpid-dispatch/pull/811 This patch reorganizes the parse accounting for json fields embedded in a dispatch-config formatted config file. Policy vhost groups hold doubly-nested maps and those need to be detected and retired as they come and go. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1737) Policy config parse errors report wrong line and column numbers
[ https://issues.apache.org/jira/browse/DISPATCH-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles E. Rolke resolved DISPATCH-1737. Fix Version/s: 1.13.0 Resolution: Fixed Fixed at Commit 578164f > Policy config parse errors report wrong line and column numbers > > > Key: DISPATCH-1737 > URL: https://issues.apache.org/jira/browse/DISPATCH-1737 > Project: Qpid Dispatch > Issue Type: Bug > Components: Management Agent >Affects Versions: 1.12.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > Fix For: 1.13.0 > > > Config files may be written in _router config_ format or _json_ format. > Either way the file data is reorganized internally into _json_ format. After > the data is reorganized then the original text formatting is lost. If there > is a json parse error then the json errors showing line and column numbers > are for the reformatted text and can not be correlated to the original input. > This issue adds error logs in the event of a config parse error. The logs > show the config data as it was presented to the json parser. Users may then > see specifically where the config parsing failed with respect to their > original input. > This issue is different from DISPATCH-1707. Fixing this issue will aid in > debugging and fixing that issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ted-ross closed pull request #751: Adaptor-plugin refactoring for multi-protocol data plane
ted-ross closed pull request #751: URL: https://github.com/apache/qpid-dispatch/pull/751 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-1728) Enforce SASL dependency in build metadata
[ https://issues.apache.org/jira/browse/DISPATCH-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170840#comment-17170840 ] Ganesh Murthy edited comment on DISPATCH-1728 at 8/4/20, 7:09 PM: -- The router tests (for example system_tests_sasl_plain.py) uses a proton python binding function called SASL.extended() (which in turn calls pn_sasl_extended()) to skip the tests like seen here - [https://github.com/apache/qpid-dispatch/blob/master/tests/system_tests_sasl_plain.py#L80] In the Proton build, in cases where SASL libraries are not available, the cyrus_stub.c is included as seen here [https://github.com/apache/qpid-proton/blob/master/c/CMakeLists.txt#L100] cyrus_stub.c has a pn_sasl_extended() function that returns false In the case here [https://gist.github.com/ssorj/80b79856ee233aab2067c88f967273f6] since proton is directly installed, the SASL.extended() returns true and the Dispatch tests start executing even though the SASL libraries are not present and they start failing. [~jross] Dispatch CMakeLists.txt must do the same thing as being done in the Proton CMakeLists.txt to skip the tests instead of using Proton's SASL.extended() function. Please let me know what you think. was (Author: ganeshmurthy): The router tests (for example system_tests_sasl_plain.py) uses a proton python binding function called SASL.extended() (which in turn calls pn_sasl_extended()) to skip the tests like seen here - [https://github.com/apache/qpid-dispatch/blob/master/tests/system_tests_sasl_plain.py#L80] In the Proton build, in cases where SASL libraries are not available, the cyrus_stub.c is included as seen here [https://github.com/apache/qpid-proton/blob/master/c/CMakeLists.txt#L100] In the case here [https://gist.github.com/ssorj/80b79856ee233aab2067c88f967273f6] since proton is directly installed, the SASL.extended() returns true and the Dispatch tests start executing even though the SASL libraries are not present and they start failing. [~jross] Dispatch CMakeLists.txt must do the same thing as being done in the Proton CMakeLists.txt to skip the tests instead of using Proton's SASL.extended() function. Please let me know what you think. > Enforce SASL dependency in build metadata > - > > Key: DISPATCH-1728 > URL: https://issues.apache.org/jira/browse/DISPATCH-1728 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Justin Ross >Assignee: Ganesh Murthy >Priority: Major > > The tests require Cyrus SASL and the SASL plain mechanism. Those should be > expressed as dependencies in cmake or in a pre-test dependency check. > Otherwise, you can build the project and start running the tests before you > find out you are missing them. > A dockerfile that shows the problem: > https://gist.github.com/ssorj/80b79856ee233aab2067c88f967273f6 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] asfgit closed pull request #260: PROTON-335: Add access to link attach properties (C and Python)
asfgit closed pull request #260: URL: https://github.com/apache/qpid-proton/pull/260 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-335) Need a means of specifying and reading link properties
[ https://issues.apache.org/jira/browse/PROTON-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171071#comment-17171071 ] ASF GitHub Bot commented on PROTON-335: --- asfgit closed pull request #260: URL: https://github.com/apache/qpid-proton/pull/260 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Need a means of specifying and reading link properties > -- > > Key: PROTON-335 > URL: https://issues.apache.org/jira/browse/PROTON-335 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-0.4, proton-c-0.29.0 >Reporter: Gordon Sim >Assignee: Ken Giusti >Priority: Minor > Labels: api > Fix For: proton-c-0.32.0 > > > There are some cases where it may be beneficial to use link properties (since > link capabilities do not allow for key-value pairs, they can't easily convey > a desired configurable value and the properties on a terminus refer to the > dynamically created node not the link or the terminus itself). > (I've set this to minor since major feels a little strong, but I do think its > important ultimately for the engine to expose all the extension points from > the protocol.) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
