[GitHub] [qpid-dispatch] jiridanek commented on pull request #880: WIP: unittest for starting router and adding autoLink
jiridanek commented on pull request #880: URL: https://github.com/apache/qpid-dispatch/pull/880#issuecomment-834840551  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #1198: NO-JIRA Workaround apt-get issues and update clang to 12 in Travis CI
jiridanek merged pull request #1198: URL: https://github.com/apache/qpid-dispatch/pull/1198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2109) Shutdown crash: member access within null pointer of type 'struct qdr_node_t'
[
https://issues.apache.org/jira/browse/DISPATCH-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated DISPATCH-2109:
-
Description:
https://travis-ci.com/github/apache/qpid-dispatch/jobs/503812980#L4578
{code}
28:
/home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530:17:
runtime error: member access within null pointer of type 'struct qdr_node_t'
28: #0 0x3ff9628d5bd in qdr_set_cost_CT
/home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530
28: #1 0x3ff9627e7cb in qdr_core_free
/home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:251
28: #2 0x3ff962e13f9 in qd_router_free
/home/travis/build/apache/qpid-dispatch/src/router_node.c:2160
28: #3 0x3ff9617979d in qd_dispatch_free
/home/travis/build/apache/qpid-dispatch/src/dispatch.c:375
28: #4 0x3ff9617979d in qd_dispatch_free
/home/travis/build/apache/qpid-dispatch/src/dispatch.c:363
28: #5 0x2aa23604fa9 in main_process
/home/travis/build/apache/qpid-dispatch/router/src/main.c:119
28: #6 0x2aa23604a23 in main
/home/travis/build/apache/qpid-dispatch/router/src/main.c:369
28: #7 0x3ff94faa5f9 in __libc_start_main
(/lib/s390x-linux-gnu/libc.so.6+0x2a5f9)
28: #8 0x2aa23604d23
(/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x4d23)
{code}
was:
{code}
28:
/home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530:17:
runtime error: member access within null pointer of type 'struct qdr_node_t'
28: #0 0x3ff9628d5bd in qdr_set_cost_CT
/home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530
28: #1 0x3ff9627e7cb in qdr_core_free
/home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:251
28: #2 0x3ff962e13f9 in qd_router_free
/home/travis/build/apache/qpid-dispatch/src/router_node.c:2160
28: #3 0x3ff9617979d in qd_dispatch_free
/home/travis/build/apache/qpid-dispatch/src/dispatch.c:375
28: #4 0x3ff9617979d in qd_dispatch_free
/home/travis/build/apache/qpid-dispatch/src/dispatch.c:363
28: #5 0x2aa23604fa9 in main_process
/home/travis/build/apache/qpid-dispatch/router/src/main.c:119
28: #6 0x2aa23604a23 in main
/home/travis/build/apache/qpid-dispatch/router/src/main.c:369
28: #7 0x3ff94faa5f9 in __libc_start_main
(/lib/s390x-linux-gnu/libc.so.6+0x2a5f9)
28: #8 0x2aa23604d23
(/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x4d23)
{code}
> Shutdown crash: member access within null pointer of type 'struct qdr_node_t'
> -
>
> Key: DISPATCH-2109
> URL: https://issues.apache.org/jira/browse/DISPATCH-2109
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/503812980#L4578
> {code}
> 28:
> /home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530:17:
> runtime error: member access within null pointer of type 'struct qdr_node_t'
> 28: #0 0x3ff9628d5bd in qdr_set_cost_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530
> 28: #1 0x3ff9627e7cb in qdr_core_free
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:251
> 28: #2 0x3ff962e13f9 in qd_router_free
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2160
> 28: #3 0x3ff9617979d in qd_dispatch_free
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:375
> 28: #4 0x3ff9617979d in qd_dispatch_free
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:363
> 28: #5 0x2aa23604fa9 in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:119
> 28: #6 0x2aa23604a23 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> 28: #7 0x3ff94faa5f9 in __libc_start_main
> (/lib/s390x-linux-gnu/libc.so.6+0x2a5f9)
> 28: #8 0x2aa23604d23
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x4d23)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1203: NO-JIRA: produce a zip file with router logs if GitHub Action fails
jiridanek commented on pull request #1203: URL: https://github.com/apache/qpid-dispatch/pull/1203#issuecomment-834831883 See the `Artifacts (4)` dropdown at https://github.com/jiridanek/qpid-dispatch/runs/2531478762 for an example of failed job with downloadable logs. The size in the list (1.12 GB) is a size after extracting the archive. The zip is about 50 MB only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1203: NO-JIRA: produce a zip file with router logs if GitHub Action fails
codecov-commenter commented on pull request #1203: URL: https://github.com/apache/qpid-dispatch/pull/1203#issuecomment-834827855 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1203?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1203](https://codecov.io/gh/apache/qpid-dispatch/pull/1203?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0091f91) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/4663aad44243295ae9e166475d905f74a4e5a896?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4663aad) will **increase** coverage by `0.10%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1203?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1203 +/- ## == + Coverage 84.27% 84.38% +0.10% == Files 113 113 Lines 2800428004 == + Hits2360123630 +29 + Misses 4403 4374 -29 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1203?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1203/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `86.60% <0.00%> (+0.07%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1203/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.46% <0.00%> (+0.16%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1203/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `84.86% <0.00%> (+0.29%)` | :arrow_up: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1203/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `70.32% <0.00%> (+0.38%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1203/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.83% <0.00%> (+0.39%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1203/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.18% <0.00%> (+0.86%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1203/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `87.23% <0.00%> (+0.96%)` | :arrow_up: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1203/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85.14% <0.00%> (+0.99%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1203/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `82.84% <0.00%> (+4.14%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1203?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn
[jira] [Commented] (DISPATCH-2056) AddressSanitizer: use-after-poison in qdr_connection_set_context during system_tests_tcp_adaptor, system_tests_http2
[ https://issues.apache.org/jira/browse/DISPATCH-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341051#comment-17341051 ] ASF GitHub Bot commented on DISPATCH-2056: -- codecov-commenter commented on pull request #1202: URL: https://github.com/apache/qpid-dispatch/pull/1202#issuecomment-834816096 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1202?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1202](https://codecov.io/gh/apache/qpid-dispatch/pull/1202?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0ed6cb2) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/4663aad44243295ae9e166475d905f74a4e5a896?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4663aad) will **increase** coverage by `0.05%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1202?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1202 +/- ## == + Coverage 84.27% 84.33% +0.05% == Files 113 113 Lines 2800428004 == + Hits2360123617 +16 + Misses 4403 4387 -16 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1202?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.10% <0.00%> (-0.22%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `86.60% <0.00%> (+0.07%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.77% <0.00%> (+0.09%)` | :arrow_up: | | [src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=) | `85.28% <0.00%> (+0.12%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `87.08% <0.00%> (+0.21%)` | :arrow_up: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `70.29% <0.00%> (+0.35%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.83% <0.00%> (+0.39%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `87.23% <0.00%> (+0.96%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1202?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`,
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1202: DISPATCH-2056: Set the connection context to zero before freeing qdr_…
codecov-commenter commented on pull request #1202: URL: https://github.com/apache/qpid-dispatch/pull/1202#issuecomment-834816096 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1202?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1202](https://codecov.io/gh/apache/qpid-dispatch/pull/1202?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0ed6cb2) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/4663aad44243295ae9e166475d905f74a4e5a896?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4663aad) will **increase** coverage by `0.05%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1202?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1202 +/- ## == + Coverage 84.27% 84.33% +0.05% == Files 113 113 Lines 2800428004 == + Hits2360123617 +16 + Misses 4403 4387 -16 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1202?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.10% <0.00%> (-0.22%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `86.60% <0.00%> (+0.07%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.77% <0.00%> (+0.09%)` | :arrow_up: | | [src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=) | `85.28% <0.00%> (+0.12%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `87.08% <0.00%> (+0.21%)` | :arrow_up: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `70.29% <0.00%> (+0.35%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.83% <0.00%> (+0.39%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1202/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `87.23% <0.00%> (+0.96%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1202?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1202?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update
[jira] [Commented] (DISPATCH-2056) AddressSanitizer: use-after-poison in qdr_connection_set_context during system_tests_tcp_adaptor, system_tests_http2
[
https://issues.apache.org/jira/browse/DISPATCH-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341044#comment-17341044
]
ASF subversion and git services commented on DISPATCH-2056:
---
Commit 5a1abe94cdaa9acdb770a3cbc3057b71d8e983a0 in qpid-dispatch's branch
refs/heads/1.16.x from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=5a1abe9 ]
DISPATCH-2056: Do not reference qdr connection after it is closed
This closes #1201
(cherry picked from commit cff75f9fceff73f7be0cdb2d6590f3a95e4c4281)
> AddressSanitizer: use-after-poison in qdr_connection_set_context during
> system_tests_tcp_adaptor, system_tests_http2
>
>
> Key: DISPATCH-2056
> URL: https://issues.apache.org/jira/browse/DISPATCH-2056
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.16.0
>
>
> The pool poison PR is new and untried, so this report needs to be taken with
> a portion of healthy scepticism.
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/49397#L30319
> {noformat}
> 72: =
> 3216172: ==18570==ERROR: AddressSanitizer: use-after-poison on address
> 0x6186fb18 at pc 0x7ffa2c7dab05 bp 0x7ffa226d1190 sp 0x7ffa226d1188
> 3216272: WRITE of size 8 at 0x6186fb18 thread T4
> 3216372: #0 0x7ffa2c7dab04 in qdr_connection_set_context
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162:28
> 3216472: #1 0x7ffa2c6de93c in handle_disconnected
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:364:9
> 3216572: #2 0x7ffa2c6de93c in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:655:9
> 3216672: #3 0x7ffa2c908291 in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c
> 3216772: #4 0x7ffa2c901c6f in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122:23
> 3216872: #5 0x7ffa2c363608 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 3216972: #6 0x7ffa2bb8e292 in clone
> (/lib/x86_64-linux-gnu/libc.so.6+0x122292)
> 3217072:
> 3217172: 0x6186fb18 is located 664 bytes inside of 832-byte region
> [0x6186f880,0x6186fbc0)
> 3217272: allocated by thread T4 here:
> 3217372: #0 0x496f97 in posix_memalign
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x496f97)
> 3217472: #1 0x7ffa2c6eff9e in qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:398:13
> 3217572: #2 0x7ffa2c7d4c8e in new_qdr_connection_t
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:44:1
> 3217672: #3 0x7ffa2c7d4c8e in qdr_connection_opened
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:89:32
> 3217772: #4 0x7ffa2c6e16f7 in qdr_tcp_open_server_side_connection
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:761:30
> 3217872: #5 0x7ffa2c6df1c0 in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:625:17
> 3217972: #6 0x7ffa2c908291 in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c
> 3218072: #7 0x7ffa2c901c6f in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122:23
> 3218172: #8 0x7ffa2c363608 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 3218272:
> 3218372: Thread T4 created by T0 here:
> 3218472: #0 0x480f0a in pthread_create
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x480f0a)
> 3218572: #1 0x7ffa2c7a7b9d in sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:183:5
> 3218672: #2 0x7ffa2c90152e in qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1485:22
> 3218772: #3 0x4c7bbb in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:115:5
> 3218872: #4 0x4c6876 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369:9
> 3218972: #5 0x7ffa2ba930b2 in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
> 3219072:
> 3219172: SUMMARY: AddressSanitizer: use-after-poison
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162:28
> in qdr_connection_set_context
> 3219272: Shadow bytes around the buggy address:
> 3219372: 0x0c3080005f10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 3219472: 0x0c3080005f20: 00 00 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219572: 0x0c3080005f30: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219672: 0x0c3080005f40: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
[jira] [Resolved] (DISPATCH-2056) AddressSanitizer: use-after-poison in qdr_connection_set_context during system_tests_tcp_adaptor, system_tests_http2
[
https://issues.apache.org/jira/browse/DISPATCH-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles E. Rolke resolved DISPATCH-2056.
Fix Version/s: 1.16.0
Resolution: Fixed
Fixed at commit cff75f9f
> AddressSanitizer: use-after-poison in qdr_connection_set_context during
> system_tests_tcp_adaptor, system_tests_http2
>
>
> Key: DISPATCH-2056
> URL: https://issues.apache.org/jira/browse/DISPATCH-2056
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.16.0
>
>
> The pool poison PR is new and untried, so this report needs to be taken with
> a portion of healthy scepticism.
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/49397#L30319
> {noformat}
> 72: =
> 3216172: ==18570==ERROR: AddressSanitizer: use-after-poison on address
> 0x6186fb18 at pc 0x7ffa2c7dab05 bp 0x7ffa226d1190 sp 0x7ffa226d1188
> 3216272: WRITE of size 8 at 0x6186fb18 thread T4
> 3216372: #0 0x7ffa2c7dab04 in qdr_connection_set_context
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162:28
> 3216472: #1 0x7ffa2c6de93c in handle_disconnected
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:364:9
> 3216572: #2 0x7ffa2c6de93c in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:655:9
> 3216672: #3 0x7ffa2c908291 in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c
> 3216772: #4 0x7ffa2c901c6f in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122:23
> 3216872: #5 0x7ffa2c363608 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 3216972: #6 0x7ffa2bb8e292 in clone
> (/lib/x86_64-linux-gnu/libc.so.6+0x122292)
> 3217072:
> 3217172: 0x6186fb18 is located 664 bytes inside of 832-byte region
> [0x6186f880,0x6186fbc0)
> 3217272: allocated by thread T4 here:
> 3217372: #0 0x496f97 in posix_memalign
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x496f97)
> 3217472: #1 0x7ffa2c6eff9e in qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:398:13
> 3217572: #2 0x7ffa2c7d4c8e in new_qdr_connection_t
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:44:1
> 3217672: #3 0x7ffa2c7d4c8e in qdr_connection_opened
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:89:32
> 3217772: #4 0x7ffa2c6e16f7 in qdr_tcp_open_server_side_connection
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:761:30
> 3217872: #5 0x7ffa2c6df1c0 in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:625:17
> 3217972: #6 0x7ffa2c908291 in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c
> 3218072: #7 0x7ffa2c901c6f in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122:23
> 3218172: #8 0x7ffa2c363608 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 3218272:
> 3218372: Thread T4 created by T0 here:
> 3218472: #0 0x480f0a in pthread_create
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x480f0a)
> 3218572: #1 0x7ffa2c7a7b9d in sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:183:5
> 3218672: #2 0x7ffa2c90152e in qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1485:22
> 3218772: #3 0x4c7bbb in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:115:5
> 3218872: #4 0x4c6876 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369:9
> 3218972: #5 0x7ffa2ba930b2 in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
> 3219072:
> 3219172: SUMMARY: AddressSanitizer: use-after-poison
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162:28
> in qdr_connection_set_context
> 3219272: Shadow bytes around the buggy address:
> 3219372: 0x0c3080005f10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 3219472: 0x0c3080005f20: 00 00 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219572: 0x0c3080005f30: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219672: 0x0c3080005f40: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219772: 0x0c3080005f50: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219872: =>0x0c3080005f60: f7 f7 f7[f7]f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219972: 0x0c3080005f70: f7 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa
> 3220072: 0x0c3080005f80: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
>
[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1203: NO-JIRA: produce a zip file with router logs if GitHub Action fails
jiridanek opened a new pull request #1203: URL: https://github.com/apache/qpid-dispatch/pull/1203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2056) AddressSanitizer: use-after-poison in qdr_connection_set_context during system_tests_tcp_adaptor, system_tests_http2
[
https://issues.apache.org/jira/browse/DISPATCH-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341039#comment-17341039
]
ASF GitHub Bot commented on DISPATCH-2056:
--
asfgit closed pull request #1201:
URL: https://github.com/apache/qpid-dispatch/pull/1201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> AddressSanitizer: use-after-poison in qdr_connection_set_context during
> system_tests_tcp_adaptor, system_tests_http2
>
>
> Key: DISPATCH-2056
> URL: https://issues.apache.org/jira/browse/DISPATCH-2056
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Priority: Major
>
> The pool poison PR is new and untried, so this report needs to be taken with
> a portion of healthy scepticism.
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/49397#L30319
> {noformat}
> 72: =
> 3216172: ==18570==ERROR: AddressSanitizer: use-after-poison on address
> 0x6186fb18 at pc 0x7ffa2c7dab05 bp 0x7ffa226d1190 sp 0x7ffa226d1188
> 3216272: WRITE of size 8 at 0x6186fb18 thread T4
> 3216372: #0 0x7ffa2c7dab04 in qdr_connection_set_context
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162:28
> 3216472: #1 0x7ffa2c6de93c in handle_disconnected
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:364:9
> 3216572: #2 0x7ffa2c6de93c in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:655:9
> 3216672: #3 0x7ffa2c908291 in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c
> 3216772: #4 0x7ffa2c901c6f in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122:23
> 3216872: #5 0x7ffa2c363608 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 3216972: #6 0x7ffa2bb8e292 in clone
> (/lib/x86_64-linux-gnu/libc.so.6+0x122292)
> 3217072:
> 3217172: 0x6186fb18 is located 664 bytes inside of 832-byte region
> [0x6186f880,0x6186fbc0)
> 3217272: allocated by thread T4 here:
> 3217372: #0 0x496f97 in posix_memalign
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x496f97)
> 3217472: #1 0x7ffa2c6eff9e in qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:398:13
> 3217572: #2 0x7ffa2c7d4c8e in new_qdr_connection_t
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:44:1
> 3217672: #3 0x7ffa2c7d4c8e in qdr_connection_opened
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:89:32
> 3217772: #4 0x7ffa2c6e16f7 in qdr_tcp_open_server_side_connection
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:761:30
> 3217872: #5 0x7ffa2c6df1c0 in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:625:17
> 3217972: #6 0x7ffa2c908291 in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c
> 3218072: #7 0x7ffa2c901c6f in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122:23
> 3218172: #8 0x7ffa2c363608 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 3218272:
> 3218372: Thread T4 created by T0 here:
> 3218472: #0 0x480f0a in pthread_create
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x480f0a)
> 3218572: #1 0x7ffa2c7a7b9d in sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:183:5
> 3218672: #2 0x7ffa2c90152e in qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1485:22
> 3218772: #3 0x4c7bbb in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:115:5
> 3218872: #4 0x4c6876 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369:9
> 3218972: #5 0x7ffa2ba930b2 in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
> 3219072:
> 3219172: SUMMARY: AddressSanitizer: use-after-poison
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162:28
> in qdr_connection_set_context
> 3219272: Shadow bytes around the buggy address:
> 3219372: 0x0c3080005f10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 3219472: 0x0c3080005f20: 00 00 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219572: 0x0c3080005f30: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219672: 0x0c3080005f40: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219772: 0x0c3080005f50: f7 f7 f7
[GitHub] [qpid-dispatch] asfgit closed pull request #1201: DISPATCH-2056: Do not reference qdr connection after it is closed
asfgit closed pull request #1201: URL: https://github.com/apache/qpid-dispatch/pull/1201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2056) AddressSanitizer: use-after-poison in qdr_connection_set_context during system_tests_tcp_adaptor, system_tests_http2
[
https://issues.apache.org/jira/browse/DISPATCH-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341038#comment-17341038
]
ASF subversion and git services commented on DISPATCH-2056:
---
Commit cff75f9fceff73f7be0cdb2d6590f3a95e4c4281 in qpid-dispatch's branch
refs/heads/main from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=cff75f9 ]
DISPATCH-2056: Do not reference qdr connection after it is closed
This closes #1201
> AddressSanitizer: use-after-poison in qdr_connection_set_context during
> system_tests_tcp_adaptor, system_tests_http2
>
>
> Key: DISPATCH-2056
> URL: https://issues.apache.org/jira/browse/DISPATCH-2056
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Priority: Major
>
> The pool poison PR is new and untried, so this report needs to be taken with
> a portion of healthy scepticism.
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/49397#L30319
> {noformat}
> 72: =
> 3216172: ==18570==ERROR: AddressSanitizer: use-after-poison on address
> 0x6186fb18 at pc 0x7ffa2c7dab05 bp 0x7ffa226d1190 sp 0x7ffa226d1188
> 3216272: WRITE of size 8 at 0x6186fb18 thread T4
> 3216372: #0 0x7ffa2c7dab04 in qdr_connection_set_context
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162:28
> 3216472: #1 0x7ffa2c6de93c in handle_disconnected
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:364:9
> 3216572: #2 0x7ffa2c6de93c in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:655:9
> 3216672: #3 0x7ffa2c908291 in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c
> 3216772: #4 0x7ffa2c901c6f in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122:23
> 3216872: #5 0x7ffa2c363608 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 3216972: #6 0x7ffa2bb8e292 in clone
> (/lib/x86_64-linux-gnu/libc.so.6+0x122292)
> 3217072:
> 3217172: 0x6186fb18 is located 664 bytes inside of 832-byte region
> [0x6186f880,0x6186fbc0)
> 3217272: allocated by thread T4 here:
> 3217372: #0 0x496f97 in posix_memalign
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x496f97)
> 3217472: #1 0x7ffa2c6eff9e in qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:398:13
> 3217572: #2 0x7ffa2c7d4c8e in new_qdr_connection_t
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:44:1
> 3217672: #3 0x7ffa2c7d4c8e in qdr_connection_opened
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:89:32
> 3217772: #4 0x7ffa2c6e16f7 in qdr_tcp_open_server_side_connection
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:761:30
> 3217872: #5 0x7ffa2c6df1c0 in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:625:17
> 3217972: #6 0x7ffa2c908291 in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c
> 3218072: #7 0x7ffa2c901c6f in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122:23
> 3218172: #8 0x7ffa2c363608 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 3218272:
> 3218372: Thread T4 created by T0 here:
> 3218472: #0 0x480f0a in pthread_create
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x480f0a)
> 3218572: #1 0x7ffa2c7a7b9d in sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:183:5
> 3218672: #2 0x7ffa2c90152e in qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1485:22
> 3218772: #3 0x4c7bbb in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:115:5
> 3218872: #4 0x4c6876 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369:9
> 3218972: #5 0x7ffa2ba930b2 in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
> 3219072:
> 3219172: SUMMARY: AddressSanitizer: use-after-poison
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162:28
> in qdr_connection_set_context
> 3219272: Shadow bytes around the buggy address:
> 3219372: 0x0c3080005f10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 3219472: 0x0c3080005f20: 00 00 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219572: 0x0c3080005f30: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219672: 0x0c3080005f40: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219772: 0x0c3080005f50: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219872:
[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #1198: NO-JIRA Workaround apt-get issues and update clang to 12 in Travis CI
ganeshmurthy commented on pull request #1198: URL: https://github.com/apache/qpid-dispatch/pull/1198#issuecomment-834777968 With this change, the build that we marked as allowed to fail has passed. By that, I mean that there was a test failure but the build got past the past clang failure. I think we can go ahead and delete this build from the allowed failures and then push up this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2056) AddressSanitizer: use-after-poison in qdr_connection_set_context during system_tests_tcp_adaptor, system_tests_http2
[
https://issues.apache.org/jira/browse/DISPATCH-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341029#comment-17341029
]
ASF GitHub Bot commented on DISPATCH-2056:
--
ganeshmurthy opened a new pull request #1202:
URL: https://github.com/apache/qpid-dispatch/pull/1202
…connection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> AddressSanitizer: use-after-poison in qdr_connection_set_context during
> system_tests_tcp_adaptor, system_tests_http2
>
>
> Key: DISPATCH-2056
> URL: https://issues.apache.org/jira/browse/DISPATCH-2056
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Priority: Major
>
> The pool poison PR is new and untried, so this report needs to be taken with
> a portion of healthy scepticism.
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/49397#L30319
> {noformat}
> 72: =
> 3216172: ==18570==ERROR: AddressSanitizer: use-after-poison on address
> 0x6186fb18 at pc 0x7ffa2c7dab05 bp 0x7ffa226d1190 sp 0x7ffa226d1188
> 3216272: WRITE of size 8 at 0x6186fb18 thread T4
> 3216372: #0 0x7ffa2c7dab04 in qdr_connection_set_context
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162:28
> 3216472: #1 0x7ffa2c6de93c in handle_disconnected
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:364:9
> 3216572: #2 0x7ffa2c6de93c in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:655:9
> 3216672: #3 0x7ffa2c908291 in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c
> 3216772: #4 0x7ffa2c901c6f in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122:23
> 3216872: #5 0x7ffa2c363608 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 3216972: #6 0x7ffa2bb8e292 in clone
> (/lib/x86_64-linux-gnu/libc.so.6+0x122292)
> 3217072:
> 3217172: 0x6186fb18 is located 664 bytes inside of 832-byte region
> [0x6186f880,0x6186fbc0)
> 3217272: allocated by thread T4 here:
> 3217372: #0 0x496f97 in posix_memalign
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x496f97)
> 3217472: #1 0x7ffa2c6eff9e in qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:398:13
> 3217572: #2 0x7ffa2c7d4c8e in new_qdr_connection_t
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:44:1
> 3217672: #3 0x7ffa2c7d4c8e in qdr_connection_opened
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:89:32
> 3217772: #4 0x7ffa2c6e16f7 in qdr_tcp_open_server_side_connection
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:761:30
> 3217872: #5 0x7ffa2c6df1c0 in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:625:17
> 3217972: #6 0x7ffa2c908291 in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c
> 3218072: #7 0x7ffa2c901c6f in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122:23
> 3218172: #8 0x7ffa2c363608 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 3218272:
> 3218372: Thread T4 created by T0 here:
> 3218472: #0 0x480f0a in pthread_create
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x480f0a)
> 3218572: #1 0x7ffa2c7a7b9d in sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:183:5
> 3218672: #2 0x7ffa2c90152e in qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1485:22
> 3218772: #3 0x4c7bbb in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:115:5
> 3218872: #4 0x4c6876 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369:9
> 3218972: #5 0x7ffa2ba930b2 in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
> 3219072:
> 3219172: SUMMARY: AddressSanitizer: use-after-poison
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162:28
> in qdr_connection_set_context
> 3219272: Shadow bytes around the buggy address:
> 3219372: 0x0c3080005f10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 3219472: 0x0c3080005f20: 00 00 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219572: 0x0c3080005f30: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219672: 0x0c3080005f40: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219772:
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1202: DISPATCH-2056: Set the connection context to zero before freeing qdr_…
ganeshmurthy opened a new pull request #1202: URL: https://github.com/apache/qpid-dispatch/pull/1202 …connection -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR opened a new pull request #1201: DISPATCH-2056: Do not reference qdr connection after it is closed
ChugR opened a new pull request #1201: URL: https://github.com/apache/qpid-dispatch/pull/1201 See https://issues.apache.org/jira/browse/DISPATCH-2056 for consequences of referring to the connection after scheduling connection close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2056) AddressSanitizer: use-after-poison in qdr_connection_set_context during system_tests_tcp_adaptor, system_tests_http2
[
https://issues.apache.org/jira/browse/DISPATCH-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341026#comment-17341026
]
ASF GitHub Bot commented on DISPATCH-2056:
--
ChugR opened a new pull request #1201:
URL: https://github.com/apache/qpid-dispatch/pull/1201
See https://issues.apache.org/jira/browse/DISPATCH-2056 for consequences of
referring to the connection after scheduling connection close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> AddressSanitizer: use-after-poison in qdr_connection_set_context during
> system_tests_tcp_adaptor, system_tests_http2
>
>
> Key: DISPATCH-2056
> URL: https://issues.apache.org/jira/browse/DISPATCH-2056
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Priority: Major
>
> The pool poison PR is new and untried, so this report needs to be taken with
> a portion of healthy scepticism.
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/49397#L30319
> {noformat}
> 72: =
> 3216172: ==18570==ERROR: AddressSanitizer: use-after-poison on address
> 0x6186fb18 at pc 0x7ffa2c7dab05 bp 0x7ffa226d1190 sp 0x7ffa226d1188
> 3216272: WRITE of size 8 at 0x6186fb18 thread T4
> 3216372: #0 0x7ffa2c7dab04 in qdr_connection_set_context
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162:28
> 3216472: #1 0x7ffa2c6de93c in handle_disconnected
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:364:9
> 3216572: #2 0x7ffa2c6de93c in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:655:9
> 3216672: #3 0x7ffa2c908291 in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c
> 3216772: #4 0x7ffa2c901c6f in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122:23
> 3216872: #5 0x7ffa2c363608 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 3216972: #6 0x7ffa2bb8e292 in clone
> (/lib/x86_64-linux-gnu/libc.so.6+0x122292)
> 3217072:
> 3217172: 0x6186fb18 is located 664 bytes inside of 832-byte region
> [0x6186f880,0x6186fbc0)
> 3217272: allocated by thread T4 here:
> 3217372: #0 0x496f97 in posix_memalign
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x496f97)
> 3217472: #1 0x7ffa2c6eff9e in qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:398:13
> 3217572: #2 0x7ffa2c7d4c8e in new_qdr_connection_t
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:44:1
> 3217672: #3 0x7ffa2c7d4c8e in qdr_connection_opened
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:89:32
> 3217772: #4 0x7ffa2c6e16f7 in qdr_tcp_open_server_side_connection
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:761:30
> 3217872: #5 0x7ffa2c6df1c0 in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:625:17
> 3217972: #6 0x7ffa2c908291 in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c
> 3218072: #7 0x7ffa2c901c6f in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122:23
> 3218172: #8 0x7ffa2c363608 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
> 3218272:
> 3218372: Thread T4 created by T0 here:
> 3218472: #0 0x480f0a in pthread_create
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x480f0a)
> 3218572: #1 0x7ffa2c7a7b9d in sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:183:5
> 3218672: #2 0x7ffa2c90152e in qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1485:22
> 3218772: #3 0x4c7bbb in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:115:5
> 3218872: #4 0x4c6876 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369:9
> 3218972: #5 0x7ffa2ba930b2 in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
> 3219072:
> 3219172: SUMMARY: AddressSanitizer: use-after-poison
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162:28
> in qdr_connection_set_context
> 3219272: Shadow bytes around the buggy address:
> 3219372: 0x0c3080005f10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 3219472: 0x0c3080005f20: 00 00 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 3219572: 0x0c3080005f30: f7 f7 f7 f7 f7 f7
[jira] [Comment Edited] (DISPATCH-2109) Shutdown crash: member access within null pointer of type 'struct qdr_node_t'
[
https://issues.apache.org/jira/browse/DISPATCH-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341022#comment-17341022
]
Jiri Daněk edited comment on DISPATCH-2109 at 5/7/21, 8:21 PM:
---
The problem seems to be that if outstanding actions are handled later during
the shutdown process, some of the actions may want to touch things that were
already freed. The only thing I can think of is to handle the actions twice
(because finalizing modules can generate additional actions that then have to
be processed). The fail looks to be rare, and it is only on main, not on
release branch. Maybe it can be addressed after 1.16 is out and there is a bit
of time for this?
was (Author: jdanek):
The problem seems to be that if outstanding actions are handled later during
the shutdown process, some of the actions may want to touch things that were
already freed. The only thing I can think of is to handle the actions twice
(because finalizing modules can generate additional actions that then have to
be processed). The fail looks to be rare, maybe it can be addressed after 1.16
is out and there is a bit of time for this?
> Shutdown crash: member access within null pointer of type 'struct qdr_node_t'
> -
>
> Key: DISPATCH-2109
> URL: https://issues.apache.org/jira/browse/DISPATCH-2109
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> {code}
> 28:
> /home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530:17:
> runtime error: member access within null pointer of type 'struct qdr_node_t'
> 28: #0 0x3ff9628d5bd in qdr_set_cost_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530
> 28: #1 0x3ff9627e7cb in qdr_core_free
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:251
> 28: #2 0x3ff962e13f9 in qd_router_free
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2160
> 28: #3 0x3ff9617979d in qd_dispatch_free
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:375
> 28: #4 0x3ff9617979d in qd_dispatch_free
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:363
> 28: #5 0x2aa23604fa9 in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:119
> 28: #6 0x2aa23604a23 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> 28: #7 0x3ff94faa5f9 in __libc_start_main
> (/lib/s390x-linux-gnu/libc.so.6+0x2a5f9)
> 28: #8 0x2aa23604d23
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x4d23)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2109) Shutdown crash: member access within null pointer of type 'struct qdr_node_t'
[
https://issues.apache.org/jira/browse/DISPATCH-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341022#comment-17341022
]
Jiri Daněk commented on DISPATCH-2109:
--
The problem seems to be that if outstanding actions are handled later during
the shutdown process, some of the actions may want to touch things that were
already freed. The only thing I can think of is to handle the actions twice
(because finalizing modules can generate additional actions that then have to
be processed). The fail looks to be rare, maybe it can be addressed after 1.16
is out and there is a bit of time for this?
> Shutdown crash: member access within null pointer of type 'struct qdr_node_t'
> -
>
> Key: DISPATCH-2109
> URL: https://issues.apache.org/jira/browse/DISPATCH-2109
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> {code}
> 28:
> /home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530:17:
> runtime error: member access within null pointer of type 'struct qdr_node_t'
> 28: #0 0x3ff9628d5bd in qdr_set_cost_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530
> 28: #1 0x3ff9627e7cb in qdr_core_free
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:251
> 28: #2 0x3ff962e13f9 in qd_router_free
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2160
> 28: #3 0x3ff9617979d in qd_dispatch_free
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:375
> 28: #4 0x3ff9617979d in qd_dispatch_free
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:363
> 28: #5 0x2aa23604fa9 in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:119
> 28: #6 0x2aa23604a23 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> 28: #7 0x3ff94faa5f9 in __libc_start_main
> (/lib/s390x-linux-gnu/libc.so.6+0x2a5f9)
> 28: #8 0x2aa23604d23
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x4d23)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2109) Shutdown crash: member access within null pointer of type 'struct qdr_node_t'
Jiri Daněk created DISPATCH-2109:
Summary: Shutdown crash: member access within null pointer of type
'struct qdr_node_t'
Key: DISPATCH-2109
URL: https://issues.apache.org/jira/browse/DISPATCH-2109
Project: Qpid Dispatch
Issue Type: Bug
Affects Versions: 1.17.0
Reporter: Jiri Daněk
Assignee: Jiri Daněk
{code}
28:
/home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530:17:
runtime error: member access within null pointer of type 'struct qdr_node_t'
28: #0 0x3ff9628d5bd in qdr_set_cost_CT
/home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530
28: #1 0x3ff9627e7cb in qdr_core_free
/home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:251
28: #2 0x3ff962e13f9 in qd_router_free
/home/travis/build/apache/qpid-dispatch/src/router_node.c:2160
28: #3 0x3ff9617979d in qd_dispatch_free
/home/travis/build/apache/qpid-dispatch/src/dispatch.c:375
28: #4 0x3ff9617979d in qd_dispatch_free
/home/travis/build/apache/qpid-dispatch/src/dispatch.c:363
28: #5 0x2aa23604fa9 in main_process
/home/travis/build/apache/qpid-dispatch/router/src/main.c:119
28: #6 0x2aa23604a23 in main
/home/travis/build/apache/qpid-dispatch/router/src/main.c:369
28: #7 0x3ff94faa5f9 in __libc_start_main
(/lib/s390x-linux-gnu/libc.so.6+0x2a5f9)
28: #8 0x2aa23604d23
(/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x4d23)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1200: NO-JIRA: Added info about the -j flag so tests can execute faster
jiridanek commented on a change in pull request #1200: URL: https://github.com/apache/qpid-dispatch/pull/1200#discussion_r628465112 ## File path: README ## @@ -134,6 +134,13 @@ option. Example: ctest --timeout 1500 -VV +The Dispatch test suite has a number of tests. To shorten execution time of the test suite, use the -j2 flag. Example: + +ctest -j2 -VV + +The integer following the -j specifies the maximum number of concurrent jobs that are used to execute the tests. +Higher numbers could lead to unexpected test failures. Review comment: "... due to machine overload, which then causes missed timeouts in tests." Users should know that the tests themselves run concurrently just fine (or they should run fine), it's only the hardware which is not keeping up. "Reasonable value to use on a powerful developer laptop which provides good speed while does not suffer from spurious failures is `-j6`" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1200: NO-JIRA: Added info about the -j flag so tests can execute faster
jiridanek commented on a change in pull request #1200: URL: https://github.com/apache/qpid-dispatch/pull/1200#discussion_r628465112 ## File path: README ## @@ -134,6 +134,13 @@ option. Example: ctest --timeout 1500 -VV +The Dispatch test suite has a number of tests. To shorten execution time of the test suite, use the -j2 flag. Example: + +ctest -j2 -VV + +The integer following the -j specifies the maximum number of concurrent jobs that are used to execute the tests. +Higher numbers could lead to unexpected test failures. Review comment: "... due to machine overload, which then causes missed timeouts in tests." Users should know that the tests themselves run concurrently just fine (or they should), it's only the hardware which is not keeping up. "Reasonable value to use on a powerful developer laptop which provides good speed while does not suffer from spurious failures is `-j6`" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1595) Python tests define on_modified handler when proton has none
[ https://issues.apache.org/jira/browse/DISPATCH-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341015#comment-17341015 ] ASF GitHub Bot commented on DISPATCH-1595: -- jiridanek commented on a change in pull request #1197: URL: https://github.com/apache/qpid-dispatch/pull/1197#discussion_r628463490 ## File path: tests/system_test.py ## @@ -1107,15 +1107,10 @@ def on_accepted(self, event): event.delivery.settle() def on_released(self, event): -# for some reason Proton 'helpfully' calls on_released even though the -# delivery state is actually MODIFIED if event.delivery.remote_state == Delivery.MODIFIED: -return self.on_modified(event) Review comment: This makes the handlers work the way they "should've been" done in Proton, imo. I thought that it was a reasonable improved thing to do. But ok, the Proton orthodoxy prevails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Python tests define on_modified handler when proton has none > > > Key: DISPATCH-1595 > URL: https://issues.apache.org/jira/browse/DISPATCH-1595 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.10.0 >Reporter: Charles E. Rolke >Priority: Major > > Proton python deliberately lumps modified and released dispositions into the > on_released callback. There is no on_modified callback. > system_tests.py and system_tests_multicast.py mistakenly add an on_modifed > callback that does not override anything and is never called by proton. > See https://issues.apache.org/jira/browse/PROTON-2180 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1197: DISPATCH-1595: Remove all python test on_modified event handlers
jiridanek commented on a change in pull request #1197: URL: https://github.com/apache/qpid-dispatch/pull/1197#discussion_r628463490 ## File path: tests/system_test.py ## @@ -1107,15 +1107,10 @@ def on_accepted(self, event): event.delivery.settle() def on_released(self, event): -# for some reason Proton 'helpfully' calls on_released even though the -# delivery state is actually MODIFIED if event.delivery.remote_state == Delivery.MODIFIED: -return self.on_modified(event) Review comment: This makes the handlers work the way they "should've been" done in Proton, imo. I thought that it was a reasonable improved thing to do. But ok, the Proton orthodoxy prevails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1200: NO-JIRA: Added info about the -j flag so tests can execute faster
ganeshmurthy opened a new pull request #1200: URL: https://github.com/apache/qpid-dispatch/pull/1200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2380) frame tracing issues/improvements
[ https://issues.apache.org/jira/browse/PROTON-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341014#comment-17341014 ] ASF subversion and git services commented on PROTON-2380: - Commit 1ad760faed44f261fd59e3714eebb498a55c77c7 in qpid-protonj2's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=1ad760f ] PROTON-2380 Fix formatting issue in log of Transfer with its payload > frame tracing issues/improvements > - > > Key: PROTON-2380 > URL: https://issues.apache.org/jira/browse/PROTON-2380 > Project: Qpid Proton > Issue Type: Bug > Components: protonj2 >Affects Versions: protonj2-1.0.0-M1 >Reporter: Robbie Gemmell >Assignee: Timothy A. Bish >Priority: Major > > Running the HelloWorld example against Broker-J 8.0.4 with PN_TRACE_FRM=true > style frame trace enabled shows some areas for improvement. > * Nothing distinguishes the connection it applies to (e.g in other cases we > log include the memory address), limiting value in multi-connection use > cases. > * The run ultimately resulted in exposing a broker bug (QPID-8523), causing > connection closure with explanation, but the attach frame trace itself didnt > show the issue at all, instead implying a value was sent (printing > initialDeliveryCount=0). Some way of distinguishing actual vs default (in > code terms) values received, and possibly how many fields were populated, > would be useful. > * Some binary bits will just print out the buffer class/sizes etc. > * The initial SASL header is prefixed 'AMQP' which is debatable (both ways, > since its only a header). May be simpler to say SASL to show transition. Or > drop the prefix. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2106) [HTTP2] coverity errors
[
https://issues.apache.org/jira/browse/DISPATCH-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341012#comment-17341012
]
ASF GitHub Bot commented on DISPATCH-2106:
--
ganeshmurthy opened a new pull request #1199:
URL: https://github.com/apache/qpid-dispatch/pull/1199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [HTTP2] coverity errors
> ---
>
> Key: DISPATCH-2106
> URL: https://issues.apache.org/jira/browse/DISPATCH-2106
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> [View in coverity
> website|https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrYzWbMPmorD7XnOuZAY1PF5CxqEeKRARa-2FNIb9NgRx3I5GnaWT0ahntmzOiTsHYFJfTdXTXBeRPsUiGGEXnaDOWhxJ_w8xEUxas-2FGH82wkNPpeCiA-2Fca9GedKFqh2wBbuF5Hks63KpvdX8ua9OXCPRTdvgaN6wJ5z4C2sTXqY04L5a3RYdertN1-2FB9NA8Tq25x2C2-2FoQQRuU8G6vQ74tNg63oy771wTuBf5ZOuYWNDRy5qbjfRja-2BwLS4djseUaLyw5quDN7aSOVQvEqSp1q6Uu3Ga1HzY-2Bf7-2BNxQQEWi9jRLdrWg-3D-3D]
> {{** CID 370602: Control flow issues (DEADCODE)
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:
> 1942 in qdr_http_deliver()
>
> *** CID 370602: Control flow issues (DEADCODE)
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:
> 1942 in qdr_http_deliver()
> 1936 if (stream_data->status == QD_STREAM_FULLY_CLOSED && disp ==
> PN_ACCEPTED) {
> 1937 qd_log(http2_adaptor->log_source, QD_LOG_TRACE,
> "[C%"PRIu64"][S%"PRId32"] qdr_http_deliver - calling free_http2_stream_data",
> conn->conn_id, stream_data->stream_id);
> 1938 free_http2_stream_data(stream_data, false);
> 1939 }
> 1940 return disp;
> 1941 }
> >>> CID 370602: Control flow issues (DEADCODE)
> >>> Execution cannot reach this statement: "return 0UL;".
> 1942 return 0;
> 1943 }
> 1944
> 1945
> 1946 static int handle_incoming_http(qdr_http2_connection_t *conn)
> 1947 {
> ** CID 363441: API usage errors (PRINTF_ARGS)
>
> *** CID 363441: API usage errors (PRINTF_ARGS)
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:
> 283 in write_buffers()
> 277 i ++;
> 278
> 279 }
> 280
> 281 if (i >0) {
> 282 size_t num_buffers_written =
> pn_raw_connection_write_buffers(session_data->conn->pn_raw_conn, raw_buffers,
> num_buffs);
> >>> CID 363441: API usage errors (PRINTF_ARGS)
> >>> Argument "num_buffers_written" to format specifier "%i" was expected
> >>> to have type "int" but has type "unsigned long".
> 283 qd_log(http2_adaptor->log_source, QD_LOG_TRACE, "[C%"PRIu64"]
> Written %i buffer(s) and %i bytes in write_buffers() using
> pn_raw_connection_write_buffers()", conn->conn_id, num_buffers_written,
> total_bytes);
> 284 if (num_buffs != num_buffers_written) {
> 285 //TODO - This is not good.
> 286 }
> 287 return num_buffers_written;
> 288 }
> ** CID 363429:(PRINTF_ARGS)
>
> *** CID 363429:(PRINTF_ARGS)
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:
> 2481 in handle_connection_event()
> 2475 if (written > 0 && !conn->ingress && !conn->first_pinged) {
> 2476 // Send a PING frame 4 seconds after opening an egress
> connection.
> 2477 qd_timer_schedule(conn->ping_timer, PING_INTERVAL *
> 1000);
> 2478 conn->first_pinged = true;
> 2479 }
> 2480
> >>> CID 363429:(PRINTF_ARGS)
> >>> Argument "written" to format specifier "%i" was expected to have type
> >>> "int" but has type "unsigned long".
> 2481 qd_log(log, QD_LOG_TRACE, "[C%"PRIu64"]
> PN_RAW_CONNECTION_WRITTEN Wrote %i bytes, DEQ_SIZE(session_data->buffs) =
> %zu", conn->conn_id, written, DEQ_SIZE(conn->session_data->buffs));
> 2482 restart_streams(conn);
> 2483 break;
> 2484 }
> 2485 default:
> 2486 break;
>
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1199: DISPATCH-2106, DISPATCH-2107: Coverity fixes for main branch
ganeshmurthy opened a new pull request #1199: URL: https://github.com/apache/qpid-dispatch/pull/1199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2380) frame tracing issues/improvements
[ https://issues.apache.org/jira/browse/PROTON-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341009#comment-17341009 ] ASF subversion and git services commented on PROTON-2380: - Commit f538027250cebad9940551a364f7e9dccc5cdf29 in qpid-protonj2's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=f538027 ] PROTON-2380 Improve the exception message for missing mandatory fields > frame tracing issues/improvements > - > > Key: PROTON-2380 > URL: https://issues.apache.org/jira/browse/PROTON-2380 > Project: Qpid Proton > Issue Type: Bug > Components: protonj2 >Affects Versions: protonj2-1.0.0-M1 >Reporter: Robbie Gemmell >Assignee: Timothy A. Bish >Priority: Major > > Running the HelloWorld example against Broker-J 8.0.4 with PN_TRACE_FRM=true > style frame trace enabled shows some areas for improvement. > * Nothing distinguishes the connection it applies to (e.g in other cases we > log include the memory address), limiting value in multi-connection use > cases. > * The run ultimately resulted in exposing a broker bug (QPID-8523), causing > connection closure with explanation, but the attach frame trace itself didnt > show the issue at all, instead implying a value was sent (printing > initialDeliveryCount=0). Some way of distinguishing actual vs default (in > code terms) values received, and possibly how many fields were populated, > would be useful. > * Some binary bits will just print out the buffer class/sizes etc. > * The initial SASL header is prefixed 'AMQP' which is debatable (both ways, > since its only a header). May be simpler to say SASL to show transition. Or > drop the prefix. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek merged pull request #311: NO-JIRA Workaround Travis CI package installation issues
jiridanek merged pull request #311: URL: https://github.com/apache/qpid-proton/pull/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on pull request #311: NO-JIRA Workaround Travis CI package installation issues
jiridanek commented on pull request #311: URL: https://github.com/apache/qpid-proton/pull/311#issuecomment-834609012 @gemmellr @astitcher looks like this worked. Should be merged quickly, before they break something else! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-2341) Cannot build Dispatch using the Debian PPA Proton packages
[
https://issues.apache.org/jira/browse/PROTON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340911#comment-17340911
]
Kim van der Riet edited comment on PROTON-2341 at 5/7/21, 4:01 PM:
---
According to the debian/control file:
{{Package: libqpid-proton-proactor1-dev}}
Provides: libqpid-proton-proactor-dev
{{Depends: libqpid-proton11-dev (>= ${binary:Version}),
libqpid-proton-proactor1 (= ${binary:Version}), $\{misc:Depends}}}
{{...}}
and is missing a dep on {{libqpid-proton-core10-dev}} which provides the
missing file.
was (Author: kpvdr):
According to the debian/control file:
{{Package: libqpid-proton-proactor1-dev}}
\{{ Provides: libqpid-proton-proactor-dev}}
{{Depends: libqpid-proton11-dev (>= ${binary:Version}),
libqpid-proton-proactor1 (= ${binary:Version}), $\{misc:Depends}}}
{{...}}
and is missing a dep on {{libqpid-proton-core10-dev}} which provides the
missing file.
> Cannot build Dispatch using the Debian PPA Proton packages
> --
>
> Key: PROTON-2341
> URL: https://issues.apache.org/jira/browse/PROTON-2341
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c, release
>Affects Versions: proton-c-0.33.0
> Environment: Ubuntu Focal
>Reporter: Jiri Daněk
>Assignee: Irina Boverman
>Priority: Major
>
> I am installing Proton from PPA
> {noformat}
> $ sudo add-apt-repository ppa:qpid/testing && sudo apt-get update
> $ sudo apt install -y libqpid-proton-proactor1-dev python3-qpid-proton
> {noformat}
> I run Dispatch compilation, but I get error
> {noformat}
> -- Found Proton:
> optimized;/usr/lib/x86_64-linux-gnu/libqpid-proton.so;debug;/usr/lib/x86_64-linux-gnu/libqpid-proton.so
> (found version "0.33.0")
> {noformat}
> (notice that the .so mentioned in this cmake output does not actually exist
> in the package, there it is named with extra .10 at the end.)
> {noformat}
> [...]
> [ 81%] Building C object
> src/CMakeFiles/qpid-dispatch.dir/http-libwebsockets.c.o
> [ 83%] Building C object
> src/CMakeFiles/qpid-dispatch.dir/adaptors/http2/http2_adaptor.c.o
> make[3]: *** No rule to make target
> '/usr/lib/x86_64-linux-gnu/libqpid-proton-core.so', needed by
> 'src/libqpid-dispatch.so'. Stop.
> make[2]: *** [CMakeFiles/Makefile2:1072:
> src/CMakeFiles/qpid-dispatch.dir/all] Error 2
> make[1]: *** [CMakeFiles/Makefile2:1296: docs/CMakeFiles/docs.dir/rule] Error
> 2
> make: *** [Makefile:662: docs] Error 2
> Error: Process completed with exit code 2.
> {noformat}
> To workaround this, I have to do
> {noformat}
> sudo ln -s /usr/lib/x86_64-linux-gnu/libqpid-proton-core.so.10
> /usr/lib/x86_64-linux-gnu/libqpid-proton-core.so
> {noformat}
> and then the build succeeds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-2341) Cannot build Dispatch using the Debian PPA Proton packages
[
https://issues.apache.org/jira/browse/PROTON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340911#comment-17340911
]
Kim van der Riet edited comment on PROTON-2341 at 5/7/21, 4:01 PM:
---
According to the debian/control file:
{{Package: libqpid-proton-proactor1-dev}}
\{{ Provides: libqpid-proton-proactor-dev}}
{{Depends: libqpid-proton11-dev (>= ${binary:Version}),
libqpid-proton-proactor1 (= ${binary:Version}), $\{misc:Depends}}}
{{...}}
and is missing a dep on {{libqpid-proton-core10-dev}} which provides the
missing file.
was (Author: kpvdr):
According to the debian/control file:
Package: libqpid-proton-proactor1-dev
Provides: libqpid-proton-proactor-dev
> Cannot build Dispatch using the Debian PPA Proton packages
> --
>
> Key: PROTON-2341
> URL: https://issues.apache.org/jira/browse/PROTON-2341
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c, release
>Affects Versions: proton-c-0.33.0
> Environment: Ubuntu Focal
>Reporter: Jiri Daněk
>Assignee: Irina Boverman
>Priority: Major
>
> I am installing Proton from PPA
> {noformat}
> $ sudo add-apt-repository ppa:qpid/testing && sudo apt-get update
> $ sudo apt install -y libqpid-proton-proactor1-dev python3-qpid-proton
> {noformat}
> I run Dispatch compilation, but I get error
> {noformat}
> -- Found Proton:
> optimized;/usr/lib/x86_64-linux-gnu/libqpid-proton.so;debug;/usr/lib/x86_64-linux-gnu/libqpid-proton.so
> (found version "0.33.0")
> {noformat}
> (notice that the .so mentioned in this cmake output does not actually exist
> in the package, there it is named with extra .10 at the end.)
> {noformat}
> [...]
> [ 81%] Building C object
> src/CMakeFiles/qpid-dispatch.dir/http-libwebsockets.c.o
> [ 83%] Building C object
> src/CMakeFiles/qpid-dispatch.dir/adaptors/http2/http2_adaptor.c.o
> make[3]: *** No rule to make target
> '/usr/lib/x86_64-linux-gnu/libqpid-proton-core.so', needed by
> 'src/libqpid-dispatch.so'. Stop.
> make[2]: *** [CMakeFiles/Makefile2:1072:
> src/CMakeFiles/qpid-dispatch.dir/all] Error 2
> make[1]: *** [CMakeFiles/Makefile2:1296: docs/CMakeFiles/docs.dir/rule] Error
> 2
> make: *** [Makefile:662: docs] Error 2
> Error: Process completed with exit code 2.
> {noformat}
> To workaround this, I have to do
> {noformat}
> sudo ln -s /usr/lib/x86_64-linux-gnu/libqpid-proton-core.so.10
> /usr/lib/x86_64-linux-gnu/libqpid-proton-core.so
> {noformat}
> and then the build succeeds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2341) Cannot build Dispatch using the Debian PPA Proton packages
[
https://issues.apache.org/jira/browse/PROTON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340911#comment-17340911
]
Kim van der Riet commented on PROTON-2341:
--
According to the debian/control file:
Package: libqpid-proton-proactor1-dev
Provides: libqpid-proton-proactor-dev
> Cannot build Dispatch using the Debian PPA Proton packages
> --
>
> Key: PROTON-2341
> URL: https://issues.apache.org/jira/browse/PROTON-2341
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c, release
>Affects Versions: proton-c-0.33.0
> Environment: Ubuntu Focal
>Reporter: Jiri Daněk
>Assignee: Irina Boverman
>Priority: Major
>
> I am installing Proton from PPA
> {noformat}
> $ sudo add-apt-repository ppa:qpid/testing && sudo apt-get update
> $ sudo apt install -y libqpid-proton-proactor1-dev python3-qpid-proton
> {noformat}
> I run Dispatch compilation, but I get error
> {noformat}
> -- Found Proton:
> optimized;/usr/lib/x86_64-linux-gnu/libqpid-proton.so;debug;/usr/lib/x86_64-linux-gnu/libqpid-proton.so
> (found version "0.33.0")
> {noformat}
> (notice that the .so mentioned in this cmake output does not actually exist
> in the package, there it is named with extra .10 at the end.)
> {noformat}
> [...]
> [ 81%] Building C object
> src/CMakeFiles/qpid-dispatch.dir/http-libwebsockets.c.o
> [ 83%] Building C object
> src/CMakeFiles/qpid-dispatch.dir/adaptors/http2/http2_adaptor.c.o
> make[3]: *** No rule to make target
> '/usr/lib/x86_64-linux-gnu/libqpid-proton-core.so', needed by
> 'src/libqpid-dispatch.so'. Stop.
> make[2]: *** [CMakeFiles/Makefile2:1072:
> src/CMakeFiles/qpid-dispatch.dir/all] Error 2
> make[1]: *** [CMakeFiles/Makefile2:1296: docs/CMakeFiles/docs.dir/rule] Error
> 2
> make: *** [Makefile:662: docs] Error 2
> Error: Process completed with exit code 2.
> {noformat}
> To workaround this, I have to do
> {noformat}
> sudo ln -s /usr/lib/x86_64-linux-gnu/libqpid-proton-core.so.10
> /usr/lib/x86_64-linux-gnu/libqpid-proton-core.so
> {noformat}
> and then the build succeeds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-2341) Cannot build Dispatch using the Debian PPA Proton packages
[
https://issues.apache.org/jira/browse/PROTON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340911#comment-17340911
]
Kim van der Riet edited comment on PROTON-2341 at 5/7/21, 3:58 PM:
---
According to the debian/control file:
Package: libqpid-proton-proactor1-dev
Provides: libqpid-proton-proactor-dev
was (Author: kpvdr):
According to the debian/control file:
Package: libqpid-proton-proactor1-dev
Provides: libqpid-proton-proactor-dev
> Cannot build Dispatch using the Debian PPA Proton packages
> --
>
> Key: PROTON-2341
> URL: https://issues.apache.org/jira/browse/PROTON-2341
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c, release
>Affects Versions: proton-c-0.33.0
> Environment: Ubuntu Focal
>Reporter: Jiri Daněk
>Assignee: Irina Boverman
>Priority: Major
>
> I am installing Proton from PPA
> {noformat}
> $ sudo add-apt-repository ppa:qpid/testing && sudo apt-get update
> $ sudo apt install -y libqpid-proton-proactor1-dev python3-qpid-proton
> {noformat}
> I run Dispatch compilation, but I get error
> {noformat}
> -- Found Proton:
> optimized;/usr/lib/x86_64-linux-gnu/libqpid-proton.so;debug;/usr/lib/x86_64-linux-gnu/libqpid-proton.so
> (found version "0.33.0")
> {noformat}
> (notice that the .so mentioned in this cmake output does not actually exist
> in the package, there it is named with extra .10 at the end.)
> {noformat}
> [...]
> [ 81%] Building C object
> src/CMakeFiles/qpid-dispatch.dir/http-libwebsockets.c.o
> [ 83%] Building C object
> src/CMakeFiles/qpid-dispatch.dir/adaptors/http2/http2_adaptor.c.o
> make[3]: *** No rule to make target
> '/usr/lib/x86_64-linux-gnu/libqpid-proton-core.so', needed by
> 'src/libqpid-dispatch.so'. Stop.
> make[2]: *** [CMakeFiles/Makefile2:1072:
> src/CMakeFiles/qpid-dispatch.dir/all] Error 2
> make[1]: *** [CMakeFiles/Makefile2:1296: docs/CMakeFiles/docs.dir/rule] Error
> 2
> make: *** [Makefile:662: docs] Error 2
> Error: Process completed with exit code 2.
> {noformat}
> To workaround this, I have to do
> {noformat}
> sudo ln -s /usr/lib/x86_64-linux-gnu/libqpid-proton-core.so.10
> /usr/lib/x86_64-linux-gnu/libqpid-proton-core.so
> {noformat}
> and then the build succeeds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #311: NO-JIRA fix travis build?
codecov-commenter edited a comment on pull request #311: URL: https://github.com/apache/qpid-proton/pull/311#issuecomment-834548088 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#311](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (82a894b) into [main](https://codecov.io/gh/apache/qpid-proton/commit/08b301a97c834e002d41ee852bba1288fe83b936?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (08b301a) will **decrease** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main #311 +/- ## == - Coverage 69.20% 69.17% -0.04% == Files 352 352 Lines 6956469557 -7 == - Hits4814448114 -30 - Misses 2142021443 +23 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | `84.57% <0.00%> (-1.37%)` | :arrow_down: | | [c/src/core/transport.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS90cmFuc3BvcnQuYw==) | `90.22% <0.00%> (-0.06%)` | :arrow_down: | | [c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=) | `83.68% <0.00%> (-0.06%)` | :arrow_down: | | [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | `82.49% <0.00%> (+0.06%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [08b301a...82a894b](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #311: NO-JIRA fix travis build?
codecov-commenter edited a comment on pull request #311: URL: https://github.com/apache/qpid-proton/pull/311#issuecomment-834548088 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#311](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (82a894b) into [main](https://codecov.io/gh/apache/qpid-proton/commit/08b301a97c834e002d41ee852bba1288fe83b936?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (08b301a) will **increase** coverage by `19.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #311 +/- ## === + Coverage 69.20% 88.34% +19.13% === Files 352 47 -305 Lines 69564 2394-67170 === - Hits48144 2115-46029 + Misses 21420 279-21141 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [cpp/examples/ssl.cpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL3NzbC5jcHA=) | | | | [cpp/src/data.cpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9kYXRhLmNwcA==) | | | | [cpp/src/object\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9vYmplY3RfdGVzdC5jcHA=) | | | | [cpp/include/proton/receiver.hpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3JlY2VpdmVyLmhwcA==) | | | | [c/examples/send-ssl.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9leGFtcGxlcy9zZW5kLXNzbC5j) | | | | [cpp/src/reconnect\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9yZWNvbm5lY3Rfb3B0aW9ucy5jcHA=) | | | | [cpp/include/proton/codec/unordered\_map.hpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2NvZGVjL3Vub3JkZXJlZF9tYXAuaHBw) | | | | [cpp/src/contexts.hpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9jb250ZXh0cy5ocHA=) | | | | [c/src/messenger/subscription.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvbWVzc2VuZ2VyL3N1YnNjcmlwdGlvbi5j) | | | | [build/c/src/extra/url.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YnVpbGQvYy9zcmMvZXh0cmEvdXJsLmM=) | | | | ... and [295 more](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn
[GitHub] [qpid-proton] codecov-commenter commented on pull request #311: NO-JIRA fix travis build?
codecov-commenter commented on pull request #311: URL: https://github.com/apache/qpid-proton/pull/311#issuecomment-834548088 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#311](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (82a894b) into [main](https://codecov.io/gh/apache/qpid-proton/commit/08b301a97c834e002d41ee852bba1288fe83b936?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (08b301a) will **increase** coverage by `14.98%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #311 +/- ## === + Coverage 69.20% 84.19% +14.98% === Files 352 46 -306 Lines 69564 2341-67223 === - Hits48144 1971-46173 + Misses 21420 370-21050 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [ruby/lib/core/message.rb](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9tZXNzYWdlLnJi) | `56.47% <0.00%> (-32.36%)` | :arrow_down: | | [ruby/lib/util/error\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvdXRpbC9lcnJvcl9oYW5kbGVyLnJi) | `59.37% <0.00%> (-28.13%)` | :arrow_down: | | [ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==) | `76.52% <0.00%> (-19.57%)` | :arrow_down: | | [ruby/lib/codec/mapping.rb](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29kZWMvbWFwcGluZy5yYg==) | `88.17% <0.00%> (-1.08%)` | :arrow_down: | | [cpp/src/data.cpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9kYXRhLmNwcA==) | | | | [c/src/core/util.h](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS91dGlsLmg=) | | | | [cpp/src/proton\_bits.cpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9wcm90b25fYml0cy5jcHA=) | | | | [cpp/include/proton/type\_id.hpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3R5cGVfaWQuaHBw) | | | | [build/c/src/core/autodetect.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YnVpbGQvYy9zcmMvY29yZS9hdXRvZGV0ZWN0LmM=) | | | | [cpp/src/returned.cpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9yZXR1cm5lZC5jcHA=) | | | | ... and [300 more](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | | -- [Continue to review full report at
[jira] [Resolved] (DISPATCH-2104) qdstat --autolinks showing int32(0) in output
[
https://issues.apache.org/jira/browse/DISPATCH-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti resolved DISPATCH-2104.
--
Fix Version/s: (was: 1.17.0)
1.16.0
Resolution: Fixed
> qdstat --autolinks showing int32(0) in output
> -
>
> Key: DISPATCH-2104
> URL: https://issues.apache.org/jira/browse/DISPATCH-2104
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Management Agent
>Affects Versions: 1.15.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.16.0
>
>
> {code:java}
> AutoLinks
> addrdir phs extAddr link statuslastErr
> =
> 0.0.0.0/queue.waypoint in int32(1) inactive
> 0.0.0.0/queue.waypoint out int32(0) inactive
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2104) qdstat --autolinks showing int32(0) in output
[
https://issues.apache.org/jira/browse/DISPATCH-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340886#comment-17340886
]
ASF GitHub Bot commented on DISPATCH-2104:
--
asfgit merged pull request #1195:
URL: https://github.com/apache/qpid-dispatch/pull/1195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> qdstat --autolinks showing int32(0) in output
> -
>
> Key: DISPATCH-2104
> URL: https://issues.apache.org/jira/browse/DISPATCH-2104
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Management Agent
>Affects Versions: 1.15.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.17.0
>
>
> {code:java}
> AutoLinks
> addrdir phs extAddr link statuslastErr
> =
> 0.0.0.0/queue.waypoint in int32(1) inactive
> 0.0.0.0/queue.waypoint out int32(0) inactive
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2108) TCP adaptor should aggregate statistics for listener and connector
Charles E. Rolke created DISPATCH-2108: -- Summary: TCP adaptor should aggregate statistics for listener and connector Key: DISPATCH-2108 URL: https://issues.apache.org/jira/browse/DISPATCH-2108 Project: Qpid Dispatch Issue Type: Bug Components: Protocol Adaptors Affects Versions: 1.16.0 Reporter: Charles E. Rolke Fix For: 1.17.0 For each tcpListener and tcpConnector provide a summary of traffic * number of connections * bytes in * bytes out aggregated across all the to and from the listener/connector objects. Optionally provide rollup info from all the live connections * last in seconds * last out seconds -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit merged pull request #1195: DISPATCH-2104: Fix display of plain number in qdstat
asfgit merged pull request #1195: URL: https://github.com/apache/qpid-dispatch/pull/1195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2104) qdstat --autolinks showing int32(0) in output
[
https://issues.apache.org/jira/browse/DISPATCH-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340885#comment-17340885
]
ASF subversion and git services commented on DISPATCH-2104:
---
Commit ee7a828df4cb83e46103c65e7cb5df401e7ac572 in qpid-dispatch's branch
refs/heads/1.16.x from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=ee7a828 ]
DISPATCH-2104: Fix display of plain number in qdstat
This closes #1193
(cherry picked from commit a5267f599ab00b2ca4e0c6583f0f7064ec36aa87)
> qdstat --autolinks showing int32(0) in output
> -
>
> Key: DISPATCH-2104
> URL: https://issues.apache.org/jira/browse/DISPATCH-2104
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Management Agent
>Affects Versions: 1.15.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.17.0
>
>
> {code:java}
> AutoLinks
> addrdir phs extAddr link statuslastErr
> =
> 0.0.0.0/queue.waypoint in int32(1) inactive
> 0.0.0.0/queue.waypoint out int32(0) inactive
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1198: NO-JIRA Update clang up to 12 in Travis CI
jiridanek opened a new pull request #1198: URL: https://github.com/apache/qpid-dispatch/pull/1198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2039) Memory pool should be manually poisoned so that ASAN works with it
[ https://issues.apache.org/jira/browse/DISPATCH-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-2039: - Fix Version/s: 1.17.0 > Memory pool should be manually poisoned so that ASAN works with it > -- > > Key: DISPATCH-2039 > URL: https://issues.apache.org/jira/browse/DISPATCH-2039 > Project: Qpid Dispatch > Issue Type: Wish >Affects Versions: 1.15.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Minor > Fix For: 1.17.0 > > > From https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning > bq. A user may poison/unpoison a region of memory manually. Use this feature > with caution. In many cases good old malloc+free is a better way to find heap > bugs than using custom allocators with manual poisoning. > As far as I can tell, it is nowadays not possible to turn off the pool > allocation and use malloc/free, because the pool mechanism also implements > the weak pointers and ref counters. That means giving hints to ASAN is the > only way to discover memory bugs of the type (if what Chuck speculated is > true) of DISPATCH-2032. > bq. If you have a custom allocation arena, the typical workflow would be to > poison the entire arena first, and then unpoison allocated chunks of memory > leaving poisoned redzones between them. The allocated chunks should start > with 8-aligned addresses. > Alternatively, the current memory debugging machinery for the pool could take > care of it on its own... but using ASAN seems sensible to me. > http://blog.hostilefork.com/poison-memory-without-asan/ > h3. Nice to have extra features (which won't be implemented at first) > * redzones, there should be chunks of poison on either end of a returned > memory, to detect invalid accesses out of bounds; this means deliberate waste > of memory (I am thinking 3x increase, to make implementation easy) > * quarantine, returned chunks should be kept in the pool for some time before > they are returned as new allocations, to catch use-after-free; this policy > goes against performance considerations > h3. Open issues > Is it necessary to lock around the poison macros? I did not understand the > thread safety note in API comment fully. > h3. One thought > Actually, setting a limit on free_list length == 0 would effectively disable > pool and turn the calls into simple wrappers over malloc/free. It would be > enough to make this configurable at build time. Then asan should work just > fine without poison. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2039) Memory pool should be manually poisoned so that ASAN works with it
[ https://issues.apache.org/jira/browse/DISPATCH-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk resolved DISPATCH-2039. -- Resolution: Fixed > Memory pool should be manually poisoned so that ASAN works with it > -- > > Key: DISPATCH-2039 > URL: https://issues.apache.org/jira/browse/DISPATCH-2039 > Project: Qpid Dispatch > Issue Type: Wish >Affects Versions: 1.15.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Minor > Fix For: 1.17.0 > > > From https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning > bq. A user may poison/unpoison a region of memory manually. Use this feature > with caution. In many cases good old malloc+free is a better way to find heap > bugs than using custom allocators with manual poisoning. > As far as I can tell, it is nowadays not possible to turn off the pool > allocation and use malloc/free, because the pool mechanism also implements > the weak pointers and ref counters. That means giving hints to ASAN is the > only way to discover memory bugs of the type (if what Chuck speculated is > true) of DISPATCH-2032. > bq. If you have a custom allocation arena, the typical workflow would be to > poison the entire arena first, and then unpoison allocated chunks of memory > leaving poisoned redzones between them. The allocated chunks should start > with 8-aligned addresses. > Alternatively, the current memory debugging machinery for the pool could take > care of it on its own... but using ASAN seems sensible to me. > http://blog.hostilefork.com/poison-memory-without-asan/ > h3. Nice to have extra features (which won't be implemented at first) > * redzones, there should be chunks of poison on either end of a returned > memory, to detect invalid accesses out of bounds; this means deliberate waste > of memory (I am thinking 3x increase, to make implementation easy) > * quarantine, returned chunks should be kept in the pool for some time before > they are returned as new allocations, to catch use-after-free; this policy > goes against performance considerations > h3. Open issues > Is it necessary to lock around the poison macros? I did not understand the > thread safety note in API comment fully. > h3. One thought > Actually, setting a limit on free_list length == 0 would effectively disable > pool and turn the calls into simple wrappers over malloc/free. It would be > enough to make this configurable at build time. Then asan should work just > fine without poison. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-2039) Memory pool should be manually poisoned so that ASAN works with it
[ https://issues.apache.org/jira/browse/DISPATCH-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk reassigned DISPATCH-2039: Assignee: Jiri Daněk > Memory pool should be manually poisoned so that ASAN works with it > -- > > Key: DISPATCH-2039 > URL: https://issues.apache.org/jira/browse/DISPATCH-2039 > Project: Qpid Dispatch > Issue Type: Wish >Affects Versions: 1.15.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Minor > > From https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning > bq. A user may poison/unpoison a region of memory manually. Use this feature > with caution. In many cases good old malloc+free is a better way to find heap > bugs than using custom allocators with manual poisoning. > As far as I can tell, it is nowadays not possible to turn off the pool > allocation and use malloc/free, because the pool mechanism also implements > the weak pointers and ref counters. That means giving hints to ASAN is the > only way to discover memory bugs of the type (if what Chuck speculated is > true) of DISPATCH-2032. > bq. If you have a custom allocation arena, the typical workflow would be to > poison the entire arena first, and then unpoison allocated chunks of memory > leaving poisoned redzones between them. The allocated chunks should start > with 8-aligned addresses. > Alternatively, the current memory debugging machinery for the pool could take > care of it on its own... but using ASAN seems sensible to me. > http://blog.hostilefork.com/poison-memory-without-asan/ > h3. Nice to have extra features (which won't be implemented at first) > * redzones, there should be chunks of poison on either end of a returned > memory, to detect invalid accesses out of bounds; this means deliberate waste > of memory (I am thinking 3x increase, to make implementation easy) > * quarantine, returned chunks should be kept in the pool for some time before > they are returned as new allocations, to catch use-after-free; this policy > goes against performance considerations > h3. Open issues > Is it necessary to lock around the poison macros? I did not understand the > thread safety note in API comment fully. > h3. One thought > Actually, setting a limit on free_list length == 0 would effectively disable > pool and turn the calls into simple wrappers over malloc/free. It would be > enough to make this configurable at build time. Then asan should work just > fine without poison. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2039) Memory pool should be manually poisoned so that ASAN works with it
[ https://issues.apache.org/jira/browse/DISPATCH-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340879#comment-17340879 ] ASF subversion and git services commented on DISPATCH-2039: --- Commit 4663aad44243295ae9e166475d905f74a4e5a896 in qpid-dispatch's branch refs/heads/main from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=4663aad ] DISPATCH-2039 Poison the memory pool so that ASAN works better with it (#1118) When there is a read or write to the poisoned area, the error message looks like ``` ==15792==ERROR: AddressSanitizer: use-after-poison on address 0x61134dd8 at pc 0x7fdaa75fc713 bp 0x7fff2d0c8d80 sp 0x7fff2d0c8d78 14: WRITE of size 8 at 0x61134dd8 thread T0 14: #0 0x7fdaa75fc712 in qd_hash_internal_remove_item /home/jdanek/repos/qpid/qpid-dispatch/cmake-build-debug-asan/../src/hash.c:131:30 14: #1 0x7fdaa75fb51d in qd_hash_free /home/jdanek/repos/qpid/qpid-dispatch/cmake-build-debug-asan/../src/hash.c:146:13 [...] ``` > Memory pool should be manually poisoned so that ASAN works with it > -- > > Key: DISPATCH-2039 > URL: https://issues.apache.org/jira/browse/DISPATCH-2039 > Project: Qpid Dispatch > Issue Type: Wish >Affects Versions: 1.15.0 >Reporter: Jiri Daněk >Priority: Minor > > From https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning > bq. A user may poison/unpoison a region of memory manually. Use this feature > with caution. In many cases good old malloc+free is a better way to find heap > bugs than using custom allocators with manual poisoning. > As far as I can tell, it is nowadays not possible to turn off the pool > allocation and use malloc/free, because the pool mechanism also implements > the weak pointers and ref counters. That means giving hints to ASAN is the > only way to discover memory bugs of the type (if what Chuck speculated is > true) of DISPATCH-2032. > bq. If you have a custom allocation arena, the typical workflow would be to > poison the entire arena first, and then unpoison allocated chunks of memory > leaving poisoned redzones between them. The allocated chunks should start > with 8-aligned addresses. > Alternatively, the current memory debugging machinery for the pool could take > care of it on its own... but using ASAN seems sensible to me. > http://blog.hostilefork.com/poison-memory-without-asan/ > h3. Nice to have extra features (which won't be implemented at first) > * redzones, there should be chunks of poison on either end of a returned > memory, to detect invalid accesses out of bounds; this means deliberate waste > of memory (I am thinking 3x increase, to make implementation easy) > * quarantine, returned chunks should be kept in the pool for some time before > they are returned as new allocations, to catch use-after-free; this policy > goes against performance considerations > h3. Open issues > Is it necessary to lock around the poison macros? I did not understand the > thread safety note in API comment fully. > h3. One thought > Actually, setting a limit on free_list length == 0 would effectively disable > pool and turn the calls into simple wrappers over malloc/free. It would be > enough to make this configurable at build time. Then asan should work just > fine without poison. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2039) Memory pool should be manually poisoned so that ASAN works with it
[ https://issues.apache.org/jira/browse/DISPATCH-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340880#comment-17340880 ] ASF GitHub Bot commented on DISPATCH-2039: -- jiridanek merged pull request #1118: URL: https://github.com/apache/qpid-dispatch/pull/1118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Memory pool should be manually poisoned so that ASAN works with it > -- > > Key: DISPATCH-2039 > URL: https://issues.apache.org/jira/browse/DISPATCH-2039 > Project: Qpid Dispatch > Issue Type: Wish >Affects Versions: 1.15.0 >Reporter: Jiri Daněk >Priority: Minor > > From https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning > bq. A user may poison/unpoison a region of memory manually. Use this feature > with caution. In many cases good old malloc+free is a better way to find heap > bugs than using custom allocators with manual poisoning. > As far as I can tell, it is nowadays not possible to turn off the pool > allocation and use malloc/free, because the pool mechanism also implements > the weak pointers and ref counters. That means giving hints to ASAN is the > only way to discover memory bugs of the type (if what Chuck speculated is > true) of DISPATCH-2032. > bq. If you have a custom allocation arena, the typical workflow would be to > poison the entire arena first, and then unpoison allocated chunks of memory > leaving poisoned redzones between them. The allocated chunks should start > with 8-aligned addresses. > Alternatively, the current memory debugging machinery for the pool could take > care of it on its own... but using ASAN seems sensible to me. > http://blog.hostilefork.com/poison-memory-without-asan/ > h3. Nice to have extra features (which won't be implemented at first) > * redzones, there should be chunks of poison on either end of a returned > memory, to detect invalid accesses out of bounds; this means deliberate waste > of memory (I am thinking 3x increase, to make implementation easy) > * quarantine, returned chunks should be kept in the pool for some time before > they are returned as new allocations, to catch use-after-free; this policy > goes against performance considerations > h3. Open issues > Is it necessary to lock around the poison macros? I did not understand the > thread safety note in API comment fully. > h3. One thought > Actually, setting a limit on free_list length == 0 would effectively disable > pool and turn the calls into simple wrappers over malloc/free. It would be > enough to make this configurable at build time. Then asan should work just > fine without poison. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #1118: DISPATCH-2039 Poison the memory pool so that ASAN works better with it
jiridanek merged pull request #1118: URL: https://github.com/apache/qpid-dispatch/pull/1118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1595) Python tests define on_modified handler when proton has none
[ https://issues.apache.org/jira/browse/DISPATCH-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340877#comment-17340877 ] ASF GitHub Bot commented on DISPATCH-1595: -- ChugR opened a new pull request #1197: URL: https://github.com/apache/qpid-dispatch/pull/1197 There is no on_modified event in proton python MessagingHandler. Proton conflates Delivery.MODIFIED and Delivery.RELEASED state handling and delivers both states in the on_released handler. This patch makes the dispatch handler model precisely reflect the proton handler model. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Python tests define on_modified handler when proton has none > > > Key: DISPATCH-1595 > URL: https://issues.apache.org/jira/browse/DISPATCH-1595 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.10.0 >Reporter: Charles E. Rolke >Priority: Major > > Proton python deliberately lumps modified and released dispositions into the > on_released callback. There is no on_modified callback. > system_tests.py and system_tests_multicast.py mistakenly add an on_modifed > callback that does not override anything and is never called by proton. > See https://issues.apache.org/jira/browse/PROTON-2180 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR opened a new pull request #1197: DISPATCH-1595: Remove all python test on_modified event handlers
ChugR opened a new pull request #1197: URL: https://github.com/apache/qpid-dispatch/pull/1197 There is no on_modified event in proton python MessagingHandler. Proton conflates Delivery.MODIFIED and Delivery.RELEASED state handling and delivers both states in the on_released handler. This patch makes the dispatch handler model precisely reflect the proton handler model. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-2107) [libwebsockets] coverity error
[
https://issues.apache.org/jira/browse/DISPATCH-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti reassigned DISPATCH-2107:
Assignee: Ken Giusti
> [libwebsockets] coverity error
> --
>
> Key: DISPATCH-2107
> URL: https://issues.apache.org/jira/browse/DISPATCH-2107
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Trivial
> Fix For: 1.17.0
>
>
> {{*** CID 370603: API usage errors (PRINTF_ARGS)}}
> {{ /home/kgiusti/work/dispatch/qpid-dispatch/src/http-libwebsockets.c: 698 in
> callback_metrics()}}
> {{ 692 }}}
> {{ 693 }}}
> {{ 694 }}
> {{ 695 int alloc_cur = 0;}}
> {{ 696 while (alloc_cur < allocator_metrics_length) {}}
> {{ 697 if (write_allocator_metric(, end,
> _metrics[alloc_cur])) {}}
> {{ >>> CID 370603: API usage errors (PRINTF_ARGS)}}
> {{ >>> Argument "alloc_cur" to format specifier "%lu" was expected to
> have type "unsigned long" but has type "int".}}
> {{ 698 qd_log(hs->log, QD_LOG_DEBUG, "wrote allocator
> metric %lu of %lu", alloc_cur, allocator_metrics_length);}}
> {{ 699 alloc_cur++;}}
> {{ 700 } else {}}
> {{ 701 qd_log(hs->log, QD_LOG_WARNING, "insufficient
> space in buffer");}}
> {{ 702 break;}}
> {{ 703 }}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2107) [libwebsockets] coverity error
Ken Giusti created DISPATCH-2107:
Summary: [libwebsockets] coverity error
Key: DISPATCH-2107
URL: https://issues.apache.org/jira/browse/DISPATCH-2107
Project: Qpid Dispatch
Issue Type: Bug
Components: Protocol Adaptors
Affects Versions: 1.16.0
Reporter: Ken Giusti
Fix For: 1.17.0
{{*** CID 370603: API usage errors (PRINTF_ARGS)}}
{{ /home/kgiusti/work/dispatch/qpid-dispatch/src/http-libwebsockets.c: 698 in
callback_metrics()}}
{{ 692 }}}
{{ 693 }}}
{{ 694 }}
{{ 695 int alloc_cur = 0;}}
{{ 696 while (alloc_cur < allocator_metrics_length) {}}
{{ 697 if (write_allocator_metric(, end,
_metrics[alloc_cur])) {}}
{{ >>> CID 370603: API usage errors (PRINTF_ARGS)}}
{{ >>> Argument "alloc_cur" to format specifier "%lu" was expected to have
type "unsigned long" but has type "int".}}
{{ 698 qd_log(hs->log, QD_LOG_DEBUG, "wrote allocator
metric %lu of %lu", alloc_cur, allocator_metrics_length);}}
{{ 699 alloc_cur++;}}
{{ 700 } else {}}
{{ 701 qd_log(hs->log, QD_LOG_WARNING, "insufficient space
in buffer");}}
{{ 702 break;}}
{{ 703 }}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2106) [HTTP2] coverity errors
Ken Giusti created DISPATCH-2106:
Summary: [HTTP2] coverity errors
Key: DISPATCH-2106
URL: https://issues.apache.org/jira/browse/DISPATCH-2106
Project: Qpid Dispatch
Issue Type: Bug
Components: Protocol Adaptors
Affects Versions: 1.16.0
Reporter: Ken Giusti
Assignee: Ganesh Murthy
Fix For: 1.17.0
[View in coverity
website|https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrYzWbMPmorD7XnOuZAY1PF5CxqEeKRARa-2FNIb9NgRx3I5GnaWT0ahntmzOiTsHYFJfTdXTXBeRPsUiGGEXnaDOWhxJ_w8xEUxas-2FGH82wkNPpeCiA-2Fca9GedKFqh2wBbuF5Hks63KpvdX8ua9OXCPRTdvgaN6wJ5z4C2sTXqY04L5a3RYdertN1-2FB9NA8Tq25x2C2-2FoQQRuU8G6vQ74tNg63oy771wTuBf5ZOuYWNDRy5qbjfRja-2BwLS4djseUaLyw5quDN7aSOVQvEqSp1q6Uu3Ga1HzY-2Bf7-2BNxQQEWi9jRLdrWg-3D-3D]
{{** CID 370602: Control flow issues (DEADCODE)
/home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:
1942 in qdr_http_deliver()
*** CID 370602: Control flow issues (DEADCODE)
/home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:
1942 in qdr_http_deliver()
1936 if (stream_data->status == QD_STREAM_FULLY_CLOSED && disp ==
PN_ACCEPTED) {
1937 qd_log(http2_adaptor->log_source, QD_LOG_TRACE,
"[C%"PRIu64"][S%"PRId32"] qdr_http_deliver - calling free_http2_stream_data",
conn->conn_id, stream_data->stream_id);
1938 free_http2_stream_data(stream_data, false);
1939 }
1940 return disp;
1941 }
>>> CID 370602: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "return 0UL;".
1942 return 0;
1943 }
1944
1945
1946 static int handle_incoming_http(qdr_http2_connection_t *conn)
1947 {
** CID 363441: API usage errors (PRINTF_ARGS)
*** CID 363441: API usage errors (PRINTF_ARGS)
/home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:
283 in write_buffers()
277 i ++;
278
279 }
280
281 if (i >0) {
282 size_t num_buffers_written =
pn_raw_connection_write_buffers(session_data->conn->pn_raw_conn, raw_buffers,
num_buffs);
>>> CID 363441: API usage errors (PRINTF_ARGS)
>>> Argument "num_buffers_written" to format specifier "%i" was expected to
>>> have type "int" but has type "unsigned long".
283 qd_log(http2_adaptor->log_source, QD_LOG_TRACE, "[C%"PRIu64"]
Written %i buffer(s) and %i bytes in write_buffers() using
pn_raw_connection_write_buffers()", conn->conn_id, num_buffers_written,
total_bytes);
284 if (num_buffs != num_buffers_written) {
285 //TODO - This is not good.
286 }
287 return num_buffers_written;
288 }
** CID 363429:(PRINTF_ARGS)
*** CID 363429:(PRINTF_ARGS)
/home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:
2481 in handle_connection_event()
2475 if (written > 0 && !conn->ingress && !conn->first_pinged) {
2476 // Send a PING frame 4 seconds after opening an egress
connection.
2477 qd_timer_schedule(conn->ping_timer, PING_INTERVAL * 1000);
2478 conn->first_pinged = true;
2479 }
2480
>>> CID 363429:(PRINTF_ARGS)
>>> Argument "written" to format specifier "%i" was expected to have type
>>> "int" but has type "unsigned long".
2481 qd_log(log, QD_LOG_TRACE, "[C%"PRIu64"]
PN_RAW_CONNECTION_WRITTEN Wrote %i bytes, DEQ_SIZE(session_data->buffs) = %zu",
conn->conn_id, written, DEQ_SIZE(conn->session_data->buffs));
2482 restart_streams(conn);
2483 break;
2484 }
2485 default:
2486 break;
/home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:
2458 in handle_connection_event()
2452 }
2453 case PN_RAW_CONNECTION_WRITTEN: {
2454 pn_raw_buffer_t buffs[WRITE_BUFFERS];
2455 size_t n;
2456 size_t written = 0;
2457 if (conn->pn_raw_conn == 0) {
>>> CID 363429:(PRINTF_ARGS)
>>> This argument was not used by the format string: "written".
2458 qd_log(log, QD_LOG_TRACE, "[C%"PRIu64"]
PN_RAW_CONNECTION_WRITTEN, No pn_raw_conn", conn->conn_id, written);
2459 break;
2460 }
2461 while ( (n =
pn_raw_connection_take_written_buffers(conn->pn_raw_conn, buffs,
WRITE_BUFFERS)) ) {
2462 for (size_t i = 0; i < n; ++i) {
2463
[jira] [Commented] (DISPATCH-1595) Python tests define on_modified handler when proton has none
[ https://issues.apache.org/jira/browse/DISPATCH-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340865#comment-17340865 ] ASF GitHub Bot commented on DISPATCH-1595: -- ChugR closed pull request #1196: URL: https://github.com/apache/qpid-dispatch/pull/1196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Python tests define on_modified handler when proton has none > > > Key: DISPATCH-1595 > URL: https://issues.apache.org/jira/browse/DISPATCH-1595 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.10.0 >Reporter: Charles E. Rolke >Priority: Major > > Proton python deliberately lumps modified and released dispositions into the > on_released callback. There is no on_modified callback. > system_tests.py and system_tests_multicast.py mistakenly add an on_modifed > callback that does not override anything and is never called by proton. > See https://issues.apache.org/jira/browse/PROTON-2180 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1595) Python tests define on_modified handler when proton has none
[ https://issues.apache.org/jira/browse/DISPATCH-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340864#comment-17340864 ] ASF GitHub Bot commented on DISPATCH-1595: -- ChugR commented on pull request #1196: URL: https://github.com/apache/qpid-dispatch/pull/1196#issuecomment-834442926 Whoops. bad pr for sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Python tests define on_modified handler when proton has none > > > Key: DISPATCH-1595 > URL: https://issues.apache.org/jira/browse/DISPATCH-1595 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.10.0 >Reporter: Charles E. Rolke >Priority: Major > > Proton python deliberately lumps modified and released dispositions into the > on_released callback. There is no on_modified callback. > system_tests.py and system_tests_multicast.py mistakenly add an on_modifed > callback that does not override anything and is never called by proton. > See https://issues.apache.org/jira/browse/PROTON-2180 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR closed pull request #1196: DISPATCH-1595: Remove all python test on_modified event handlers
ChugR closed pull request #1196: URL: https://github.com/apache/qpid-dispatch/pull/1196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on pull request #1196: DISPATCH-1595: Remove all python test on_modified event handlers
ChugR commented on pull request #1196: URL: https://github.com/apache/qpid-dispatch/pull/1196#issuecomment-834442926 Whoops. bad pr for sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1595) Python tests define on_modified handler when proton has none
[ https://issues.apache.org/jira/browse/DISPATCH-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340863#comment-17340863 ] ASF GitHub Bot commented on DISPATCH-1595: -- ChugR opened a new pull request #1196: URL: https://github.com/apache/qpid-dispatch/pull/1196 There is no on_modified event in proton python MessagingHandler. Proton conflates Delivery.MODIFIED and Delivery.RELEASED state handling and delivers both states in the on_released handler. This patch makes the dispatch handler model precisely reflect the proton handler model. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Python tests define on_modified handler when proton has none > > > Key: DISPATCH-1595 > URL: https://issues.apache.org/jira/browse/DISPATCH-1595 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.10.0 >Reporter: Charles E. Rolke >Priority: Major > > Proton python deliberately lumps modified and released dispositions into the > on_released callback. There is no on_modified callback. > system_tests.py and system_tests_multicast.py mistakenly add an on_modifed > callback that does not override anything and is never called by proton. > See https://issues.apache.org/jira/browse/PROTON-2180 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR opened a new pull request #1196: DISPATCH-1595: Remove all python test on_modified event handlers
ChugR opened a new pull request #1196: URL: https://github.com/apache/qpid-dispatch/pull/1196 There is no on_modified event in proton python MessagingHandler. Proton conflates Delivery.MODIFIED and Delivery.RELEASED state handling and delivers both states in the on_released handler. This patch makes the dispatch handler model precisely reflect the proton handler model. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2104) qdstat --autolinks showing int32(0) in output
[
https://issues.apache.org/jira/browse/DISPATCH-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340859#comment-17340859
]
ASF GitHub Bot commented on DISPATCH-2104:
--
kgiusti opened a new pull request #1195:
URL: https://github.com/apache/qpid-dispatch/pull/1195
This closes #1193
(cherry picked from commit a5267f599ab00b2ca4e0c6583f0f7064ec36aa87)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> qdstat --autolinks showing int32(0) in output
> -
>
> Key: DISPATCH-2104
> URL: https://issues.apache.org/jira/browse/DISPATCH-2104
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Management Agent
>Affects Versions: 1.15.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.17.0
>
>
> {code:java}
> AutoLinks
> addrdir phs extAddr link statuslastErr
> =
> 0.0.0.0/queue.waypoint in int32(1) inactive
> 0.0.0.0/queue.waypoint out int32(0) inactive
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #1195: DISPATCH-2104: Fix display of plain number in qdstat
kgiusti opened a new pull request #1195: URL: https://github.com/apache/qpid-dispatch/pull/1195 This closes #1193 (cherry picked from commit a5267f599ab00b2ca4e0c6583f0f7064ec36aa87) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2104) qdstat --autolinks showing int32(0) in output
[
https://issues.apache.org/jira/browse/DISPATCH-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340836#comment-17340836
]
ASF GitHub Bot commented on DISPATCH-2104:
--
asfgit closed pull request #1193:
URL: https://github.com/apache/qpid-dispatch/pull/1193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> qdstat --autolinks showing int32(0) in output
> -
>
> Key: DISPATCH-2104
> URL: https://issues.apache.org/jira/browse/DISPATCH-2104
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Management Agent
>Affects Versions: 1.15.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.17.0
>
>
> {code:java}
> AutoLinks
> addrdir phs extAddr link statuslastErr
> =
> 0.0.0.0/queue.waypoint in int32(1) inactive
> 0.0.0.0/queue.waypoint out int32(0) inactive
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2104) qdstat --autolinks showing int32(0) in output
[
https://issues.apache.org/jira/browse/DISPATCH-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340834#comment-17340834
]
ASF subversion and git services commented on DISPATCH-2104:
---
Commit a5267f599ab00b2ca4e0c6583f0f7064ec36aa87 in qpid-dispatch's branch
refs/heads/main from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=a5267f5 ]
DISPATCH-2104: Fix display of plain number in qdstat
This closes #1193
> qdstat --autolinks showing int32(0) in output
> -
>
> Key: DISPATCH-2104
> URL: https://issues.apache.org/jira/browse/DISPATCH-2104
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Management Agent
>Affects Versions: 1.15.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.17.0
>
>
> {code:java}
> AutoLinks
> addrdir phs extAddr link statuslastErr
> =
> 0.0.0.0/queue.waypoint in int32(1) inactive
> 0.0.0.0/queue.waypoint out int32(0) inactive
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1193: DISPATCH-2104: Fix display of plain number
asfgit closed pull request #1193: URL: https://github.com/apache/qpid-dispatch/pull/1193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1917) Thread race accessing connector->conn_msg buffer (TSAN)
[
https://issues.apache.org/jira/browse/DISPATCH-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti resolved DISPATCH-1917.
--
Fix Version/s: (was: 1.17.0)
1.16.0
Resolution: Fixed
> Thread race accessing connector->conn_msg buffer (TSAN)
> ---
>
> Key: DISPATCH-1917
> URL: https://issues.apache.org/jira/browse/DISPATCH-1917
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Labels: race-condition
> Fix For: 1.16.0
>
>
> qd_connector_t holds a buffer for connection related mgmt messages
> (conn_msg[300]).
> One thread can read it buffer content while another thread can write it:
> {noformat}
> 14: WARNING: ThreadSanitizer: data race (pid=63992)
> 14: Read of size 8 at 0x7b440140 by main thread (mutexes: write M13,
> write M312, write M9):
> 14: #0 strlen (libtsan.so.0+0x32c4f)
> 14: #1 PyUnicode_FromString (libpython3.8.so.1.0+0xf8a58)
> 14: #2 qd_entity_refresh_connector
> /home/kgiusti/work/dispatch/qpid-dispatch/src/connection_manager.c:868
> (libqpid-dispatch.so+0x68522)
> 14: #3 ffi_call_unix64 (libffi.so.6+0x6aef)
> 14: #4 qdr_forward_on_message
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/forwarder.c:336
> (libqpid-dispatch.so+0xb083c)
> 14: #5 qdr_general_handler
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:887
> (libqpid-dispatch.so+0xb9189)
> 14: #6 qd_timer_visit
> /home/kgiusti/work/dispatch/qpid-dispatch/src/timer.c:201
> (libqpid-dispatch.so+0xe60c7)
> 14: #7 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1008
> (libqpid-dispatch.so+0xe01ae)
> 14: #8 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1122
> (libqpid-dispatch.so+0xe2aa7)
> 14: #9 qd_server_run
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1484
> (libqpid-dispatch.so+0xe352f)
> 14: #10 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:113
> (qdrouterd+0x40287c)
> 14: #11 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
> 14:
> 14: Previous write of size 8 at 0x7b440140 by thread T3:
> 14: #0 strcpy (libtsan.so.0+0x45ac1)
> 14: #1 AMQP_opened_handler
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1241
> (libqpid-dispatch.so+0xdad01)
> 14: #2 AMQP_outbound_opened_handler
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1402
> (libqpid-dispatch.so+0xdba43)
> 14: #3 notify_opened
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:273
> (libqpid-dispatch.so+0x69fa3)
> 14: #4 policy_notify_opened
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:284
> (libqpid-dispatch.so+0x69fa3)
> 14: #5 qd_policy_amqp_open_connector
> /home/kgiusti/work/dispatch/qpid-dispatch/src/policy.c:1371
> (libqpid-dispatch.so+0x881fa)
> 14: #6 qd_container_handle_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:511
> (libqpid-dispatch.so+0x6c984)
> 14: #7 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1097
> (libqpid-dispatch.so+0xe0211)
> 14: #8 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1122
> (libqpid-dispatch.so+0xe2a34)
> 14: #9 _thread_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172
> (libqpid-dispatch.so+0x8c5f2)
> 14: #10 (libtsan.so.0+0x2d33f)
> 14:
> 14: Location is heap block of size 300 at 0x7b440140 allocated by main
> thread:
> 14: #0 malloc (libtsan.so.0+0x304d3)
> 14: #1 qd_server_connector
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1657
> (libqpid-dispatch.so+0xe49d4)
> 14: #2 qd_dispatch_configure_connector
> /home/kgiusti/work/dispatch/qpid-dispatch/src/connection_manager.c:878
> (libqpid-dispatch.so+0x6856d)
> 14: #3 ffi_call_unix64 (libffi.so.6+0x6aef)
> 14: #4 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> 14: #5 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
> 14:
> 14: Mutex M13 (0x7b100340) created at:
> 14: #0 pthread_mutex_init (libtsan.so.0+0x4a7c6)
> 14: #1 sys_mutex
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:43
> (libqpid-dispatch.so+0x8c64c)
> 14: #2 qd_python_initialize
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:56
> (libqpid-dispatch.so+0x8ebb3)
> 14: #3 qd_dispatch
> /home/kgiusti/work/dispatch/qpid-dispatch/src/dispatch.c:108
> (libqpid-dispatch.so+0x6e526)
> 14: #4 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:90
> (qdrouterd+0x4027b9)
> 14: #5 main
[jira] [Resolved] (DISPATCH-2099) [TCP] crash in qd_message_stream_data_release() on connection close
[ https://issues.apache.org/jira/browse/DISPATCH-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-2099. -- Resolution: Fixed > [TCP] crash in qd_message_stream_data_release() on connection close > --- > > Key: DISPATCH-2099 > URL: https://issues.apache.org/jira/browse/DISPATCH-2099 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Priority: Blocker > Fix For: 1.16.0 > > > backtrace: > Thread 1 "qdrouterd" received signal SIGSEGV, Segmentation fault. > qd_message_stream_data_release (stream_data=0x7fffe00b44c8) at > /build/qpid-dispatch-src/src/message.c:2627 > #0 qd_message_stream_data_release (stream_data=0x7fffe00b44c8) at > /build/qpid-dispatch-src/src/message.c:2627 > #1 0x77f2e135 in flush_outgoing_buffs > (conn=conn@entry=0x7fffe00e4a88) at > /build/qpid-dispatch-src/src/adaptors/tcp_adaptor.c:431 > #2 0x77f30317 in handle_disconnected (conn=0x7fffe00e4a88) > at /build/qpid-dispatch-src/src/adaptors/tcp_adaptor.c:497 > 2627/build/qpid-dispatch-src/src/message.c: No such file or > directory. > #3 handle_connection_event (e=0x7fffe8023600, qd_server= out>, context=0x7fffe00e4a88) at > /build/qpid-dispatch-src/src/adaptors/tcp_adaptor.c:800 > #4 0x77f80941 in handle_event_with_context > (context=, qd_server=, e=) at > /build/qpid-dispatch-src/src/server.c:802 > #5 do_handle_raw_connection_event (qd_server=, > e=) at /build/qpid-dispatch-src/src/server.c:808 > #6 handle (qd_server=qd_server@entry=0x407620, > e=e@entry=0x7fffe8023600, pn_conn=pn_conn@entry=0x0, ctx=ctx@entry=0x0) at > /build/qpid-dispatch-src/src/server.c:1088 > #7 0x77f81978 in thread_run (arg=arg@entry=0x407620) at > /build/qpid-dispatch-src/src/server.c:1120 > #8 0x77f82000 in qd_server_run (qd=) at > /build/qpid-dispatch-src/src/server.c:1487 > #9 0x004026b2 in main_process (config_path=0x7fffe96c > "/tmp/qdrouterd.conf", python_pkgdir=, test_hooks= out>, fd=2) at /build/qpid-dispatch-src/router/src/main.c:115 > #10 0x00402400 in main (argc=3, argv=0x7fffe658) at > /build/qpid-dispatch-src/router/src/main.c:369 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2082) Leak of qd_delivery_state_t in system_tests_http1_over_tcp
[
https://issues.apache.org/jira/browse/DISPATCH-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti updated DISPATCH-2082:
-
Labels: leak (was: )
> Leak of qd_delivery_state_t in system_tests_http1_over_tcp
> --
>
> Key: DISPATCH-2082
> URL: https://issues.apache.org/jira/browse/DISPATCH-2082
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Labels: leak
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501211928#L11775
> This is PR build for pool poisoning, but the issue should be in no way
> related to that.
> {noformat}
> 71: Router INT.A debug dump file:
> 71:
> 71: alloc.c: Items of type 'qd_buffer_t' remain allocated at shutdown: 17
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_message_t' remain allocated at shutdown: 2
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_message_content_t' remain allocated at
> shutdown: 2 (SUPPRESSED)
> 71: alloc.c: Items of type 'qdr_delivery_t' remain allocated at shutdown: 2
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_delivery_state_t' remain allocated at
> shutdown: 1
> 71: Leak: 2021-04-26 20:06:52.908660 + type: qd_delivery_state_t address:
> 0x6127b9d0
> 71: qdrouterd(backtrace+0x5b) [0x45356b]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0xa68)
> [0x7f38cf658ee8]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_delivery_state+0x28)
> [0x7f38cf69ad48]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x2f6248)
> [0x7f38cf644248]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x525402)
> [0x7f38cf873402]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x51ede0)
> [0x7f38cf86cde0]
> 71: /lib/x86_64-linux-gnu/libpthread.so.0(+0x9609) [0x7f38cf2c5609]
> 71: /lib/x86_64-linux-gnu/libc.so.6(clone+0x43) [0x7f38ceaf0293]
> {noformat}
> {noformat}
> 71: ==
> 71: ERROR: tearDownClass
> (system_tests_http1_over_tcp.Http1OverTcpOneRouterTest)
> 71: --
> 71: Traceback (most recent call last):
> 71: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 865, in tearDownClass
> 71: cls.tester.teardown()
> 71: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 808, in teardown
> 71: raise RuntimeError("Errors during teardown: \n\n%s" %
> "\n\n".join([str(e) for e in errors]))
> 71: RuntimeError: Errors during teardown:
> 71:
> 71: Process 18806 error: exit code -6, expected 0
> 71: qdrouterd -c INT.A.conf -I /home/travis/build/apache/qpid-dispatch/python
> 71:
> /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_http1_over_tcp/Http1OverTcpOneRouterTest/setUpClass/INT.A-4.cmd
> 71:
> 71: ERROR: Aborted due to unexpected alloc pool leak of type
> 'qd_delivery_state_t'
> 71:
> 71:
> 71: --
> 71: Ran 12 tests in 32.652s
> 71:
> 71: FAILED (errors=1)
> 71/74 Test #71: system_tests_http1_over_tcp ...***Failed
> 32.78 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2082) Leak of qd_delivery_state_t in system_tests_http1_over_tcp
[
https://issues.apache.org/jira/browse/DISPATCH-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti updated DISPATCH-2082:
-
Component/s: Router Node
> Leak of qd_delivery_state_t in system_tests_http1_over_tcp
> --
>
> Key: DISPATCH-2082
> URL: https://issues.apache.org/jira/browse/DISPATCH-2082
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Labels: leak
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501211928#L11775
> This is PR build for pool poisoning, but the issue should be in no way
> related to that.
> {noformat}
> 71: Router INT.A debug dump file:
> 71:
> 71: alloc.c: Items of type 'qd_buffer_t' remain allocated at shutdown: 17
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_message_t' remain allocated at shutdown: 2
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_message_content_t' remain allocated at
> shutdown: 2 (SUPPRESSED)
> 71: alloc.c: Items of type 'qdr_delivery_t' remain allocated at shutdown: 2
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_delivery_state_t' remain allocated at
> shutdown: 1
> 71: Leak: 2021-04-26 20:06:52.908660 + type: qd_delivery_state_t address:
> 0x6127b9d0
> 71: qdrouterd(backtrace+0x5b) [0x45356b]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0xa68)
> [0x7f38cf658ee8]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_delivery_state+0x28)
> [0x7f38cf69ad48]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x2f6248)
> [0x7f38cf644248]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x525402)
> [0x7f38cf873402]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x51ede0)
> [0x7f38cf86cde0]
> 71: /lib/x86_64-linux-gnu/libpthread.so.0(+0x9609) [0x7f38cf2c5609]
> 71: /lib/x86_64-linux-gnu/libc.so.6(clone+0x43) [0x7f38ceaf0293]
> {noformat}
> {noformat}
> 71: ==
> 71: ERROR: tearDownClass
> (system_tests_http1_over_tcp.Http1OverTcpOneRouterTest)
> 71: --
> 71: Traceback (most recent call last):
> 71: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 865, in tearDownClass
> 71: cls.tester.teardown()
> 71: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 808, in teardown
> 71: raise RuntimeError("Errors during teardown: \n\n%s" %
> "\n\n".join([str(e) for e in errors]))
> 71: RuntimeError: Errors during teardown:
> 71:
> 71: Process 18806 error: exit code -6, expected 0
> 71: qdrouterd -c INT.A.conf -I /home/travis/build/apache/qpid-dispatch/python
> 71:
> /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_http1_over_tcp/Http1OverTcpOneRouterTest/setUpClass/INT.A-4.cmd
> 71:
> 71: ERROR: Aborted due to unexpected alloc pool leak of type
> 'qd_delivery_state_t'
> 71:
> 71:
> 71: --
> 71: Ran 12 tests in 32.652s
> 71:
> 71: FAILED (errors=1)
> 71/74 Test #71: system_tests_http1_over_tcp ...***Failed
> 32.78 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2082) Leak of qd_delivery_state_t in system_tests_http1_over_tcp
[
https://issues.apache.org/jira/browse/DISPATCH-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti updated DISPATCH-2082:
-
Issue Type: Bug (was: Test)
> Leak of qd_delivery_state_t in system_tests_http1_over_tcp
> --
>
> Key: DISPATCH-2082
> URL: https://issues.apache.org/jira/browse/DISPATCH-2082
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501211928#L11775
> This is PR build for pool poisoning, but the issue should be in no way
> related to that.
> {noformat}
> 71: Router INT.A debug dump file:
> 71:
> 71: alloc.c: Items of type 'qd_buffer_t' remain allocated at shutdown: 17
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_message_t' remain allocated at shutdown: 2
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_message_content_t' remain allocated at
> shutdown: 2 (SUPPRESSED)
> 71: alloc.c: Items of type 'qdr_delivery_t' remain allocated at shutdown: 2
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_delivery_state_t' remain allocated at
> shutdown: 1
> 71: Leak: 2021-04-26 20:06:52.908660 + type: qd_delivery_state_t address:
> 0x6127b9d0
> 71: qdrouterd(backtrace+0x5b) [0x45356b]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0xa68)
> [0x7f38cf658ee8]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_delivery_state+0x28)
> [0x7f38cf69ad48]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x2f6248)
> [0x7f38cf644248]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x525402)
> [0x7f38cf873402]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x51ede0)
> [0x7f38cf86cde0]
> 71: /lib/x86_64-linux-gnu/libpthread.so.0(+0x9609) [0x7f38cf2c5609]
> 71: /lib/x86_64-linux-gnu/libc.so.6(clone+0x43) [0x7f38ceaf0293]
> {noformat}
> {noformat}
> 71: ==
> 71: ERROR: tearDownClass
> (system_tests_http1_over_tcp.Http1OverTcpOneRouterTest)
> 71: --
> 71: Traceback (most recent call last):
> 71: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 865, in tearDownClass
> 71: cls.tester.teardown()
> 71: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 808, in teardown
> 71: raise RuntimeError("Errors during teardown: \n\n%s" %
> "\n\n".join([str(e) for e in errors]))
> 71: RuntimeError: Errors during teardown:
> 71:
> 71: Process 18806 error: exit code -6, expected 0
> 71: qdrouterd -c INT.A.conf -I /home/travis/build/apache/qpid-dispatch/python
> 71:
> /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_http1_over_tcp/Http1OverTcpOneRouterTest/setUpClass/INT.A-4.cmd
> 71:
> 71: ERROR: Aborted due to unexpected alloc pool leak of type
> 'qd_delivery_state_t'
> 71:
> 71:
> 71: --
> 71: Ran 12 tests in 32.652s
> 71:
> 71: FAILED (errors=1)
> 71/74 Test #71: system_tests_http1_over_tcp ...***Failed
> 32.78 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Reopened] (DISPATCH-2082) Leak of qd_delivery_state_t in system_tests_http1_over_tcp
[
https://issues.apache.org/jira/browse/DISPATCH-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti reopened DISPATCH-2082:
--
This error has been added to the alloc pool suppression list only.
It still needs to be fixed.
> Leak of qd_delivery_state_t in system_tests_http1_over_tcp
> --
>
> Key: DISPATCH-2082
> URL: https://issues.apache.org/jira/browse/DISPATCH-2082
> Project: Qpid Dispatch
> Issue Type: Test
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501211928#L11775
> This is PR build for pool poisoning, but the issue should be in no way
> related to that.
> {noformat}
> 71: Router INT.A debug dump file:
> 71:
> 71: alloc.c: Items of type 'qd_buffer_t' remain allocated at shutdown: 17
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_message_t' remain allocated at shutdown: 2
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_message_content_t' remain allocated at
> shutdown: 2 (SUPPRESSED)
> 71: alloc.c: Items of type 'qdr_delivery_t' remain allocated at shutdown: 2
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_delivery_state_t' remain allocated at
> shutdown: 1
> 71: Leak: 2021-04-26 20:06:52.908660 + type: qd_delivery_state_t address:
> 0x6127b9d0
> 71: qdrouterd(backtrace+0x5b) [0x45356b]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0xa68)
> [0x7f38cf658ee8]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_delivery_state+0x28)
> [0x7f38cf69ad48]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x2f6248)
> [0x7f38cf644248]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x525402)
> [0x7f38cf873402]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x51ede0)
> [0x7f38cf86cde0]
> 71: /lib/x86_64-linux-gnu/libpthread.so.0(+0x9609) [0x7f38cf2c5609]
> 71: /lib/x86_64-linux-gnu/libc.so.6(clone+0x43) [0x7f38ceaf0293]
> {noformat}
> {noformat}
> 71: ==
> 71: ERROR: tearDownClass
> (system_tests_http1_over_tcp.Http1OverTcpOneRouterTest)
> 71: --
> 71: Traceback (most recent call last):
> 71: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 865, in tearDownClass
> 71: cls.tester.teardown()
> 71: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 808, in teardown
> 71: raise RuntimeError("Errors during teardown: \n\n%s" %
> "\n\n".join([str(e) for e in errors]))
> 71: RuntimeError: Errors during teardown:
> 71:
> 71: Process 18806 error: exit code -6, expected 0
> 71: qdrouterd -c INT.A.conf -I /home/travis/build/apache/qpid-dispatch/python
> 71:
> /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_http1_over_tcp/Http1OverTcpOneRouterTest/setUpClass/INT.A-4.cmd
> 71:
> 71: ERROR: Aborted due to unexpected alloc pool leak of type
> 'qd_delivery_state_t'
> 71:
> 71:
> 71: --
> 71: Ran 12 tests in 32.652s
> 71:
> 71: FAILED (errors=1)
> 71/74 Test #71: system_tests_http1_over_tcp ...***Failed
> 32.78 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1679) leak: qd_connector_t and qd_timer_t
[ https://issues.apache.org/jira/browse/DISPATCH-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-1679. -- Resolution: Fixed > leak: qd_connector_t and qd_timer_t > --- > > Key: DISPATCH-1679 > URL: https://issues.apache.org/jira/browse/DISPATCH-1679 > Project: Qpid Dispatch > Issue Type: Bug > Components: Routing Engine >Affects Versions: 1.12.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: leak > Fix For: 1.16.0 > > > Every unit test that involves use of a connector leaks the connector and a > related qd_timer_t. These leak warnings overwhelm other warnings in the test > output. > The qd_connector_t is reference counted. It also contains a qd_timer_t. > From initial debug the reference count is never dropping below 1. > It appears that every time the timer is scheduled the refcount is > incremented. This appears to be an attempt to prevent the deletion of the > qd_connector_t while the timer is outstanding. This appears likely to be the > source of the outstanding ref count. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2046) Panic in handle due to deleted connector.
[
https://issues.apache.org/jira/browse/DISPATCH-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti resolved DISPATCH-2046.
--
Resolution: Fixed
> Panic in handle due to deleted connector.
> -
>
> Key: DISPATCH-2046
> URL: https://issues.apache.org/jira/browse/DISPATCH-2046
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Routing Engine
>Affects Versions: 1.15.0
>Reporter: Alex Ward
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 1.16.0
>
>
> I am seeing a segv at line 1063 due to ctx->connector being 0 in
> server.c:handle().
> {code:java}
> (ugdb-x86_64-7.11-261) p ctx
> $6 = (qd_connection_t *) 0x802e55890
> (ugdb-x86_64-7.11-261) p *ctx
> $7 = {prev = 0x8023df490, next = 0x802e7a890, name = 0x0, server =
> 0x80220d0c0, opened = false, closed = false, closed_locally = false, enqueued
> = 0, timer = 0x0, pn_conn = 0x8023ec050, pn_sessions = {0x0 times>}, ssl = 0x0, listener = 0x0, connector = 0x0, connector_lock =
> 0x8023e6600, context = 0x0, user_context = 0x0, link_context = 0x0,
> connection_id = 12, user_id = 0x0, free_user_id = false, policy_settings =
> 0x0, n_sessions = 0, n_senders = 0, n_receivers = 0, open_container = 0x0,
> deferred_calls = {head = 0x0, tail = 0x0, scratch = 0x0, size = 0},
> deferred_call_lock = 0x8023e65c0, policy_counted = false, role = 0x801a17660
> "route-container", free_link_session_list = {head = 0x0, tail = 0x0, scratch
> = 0x0, size = 0}, strip_annotations_in = false, strip_annotations_out =
> false, wake = 0x8005d6e20 , rhost = '\000' times>, rhost_port = '\000' }
> {code}
> As the comment at the start of handle() states, there is only one event being
> handled at a time, but it doesn’t look like there is anything to stop someone
> clearing ctx->connector between lines 1055 and 1063. The python code seems to
> be coming in and deleting the connector while handle() is using it.
> [https://github.com/apache/qpid-dispatch/blob/main/src/server.c]
> {code:java}
> 989 /* Events involving a connection or listener are serialized by the
> proactor so
> 990 * only one event per connection / listener will be processed at a time.
>
> 991 */
> 992 static bool handle(qd_server_t *qd_server, pn_event_t *e,
> pn_connection_t *pn_conn, qd_connection_t *ctx)
> 993 {
>
> 994 if (pn_conn && qdr_is_authentication_service_connection(pn_conn)) {
>
> 995 qdr_handle_authentication_service_connection_event(e);
>
> 996 return true;
>
> 997 }
>
> 998
>
> 999 switch (pn_event_type(e)) {
> …
> 1051 case PN_TRANSPORT_ERROR:
>
> 1052 {
>
> 1053 pn_transport_t *transport = pn_event_transport(e);
>
> 1054 pn_condition_t* condition = transport ?
> pn_transport_condition(transport) : NULL;
> 1055 if (ctx && ctx->connector) { /* Outgoing connection */
>
> 1056 qd_increment_conn_index(ctx);
>
> 1057 const qd_server_config_t *config =
> >connector->config;
> 1058 ctx->connector->state = CXTR_STATE_FAILED;
>
> 1059 char conn_msg[300];
>
> 1060 if (condition && pn_condition_is_set(condition)) {
>
> 1061 qd_format_string(conn_msg, 300, "[C%"PRIu64"]
> Connection to %s failed: %s %s", ctx->connection_id, config->host_port,
>
> 1062 pn_condition_get_name(condition),
> pn_condition_get_description(condition));
> 1063 strcpy(ctx->connector->conn_msg, conn_msg);
> {code}
> Another thread is at line 1063 in qd_connection_manager_delete_connector so
> it
[jira] [Updated] (DISPATCH-1679) leak: qd_connector_t and qd_timer_t
[ https://issues.apache.org/jira/browse/DISPATCH-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-1679: - Fix Version/s: (was: Backlog) 1.16.0 > leak: qd_connector_t and qd_timer_t > --- > > Key: DISPATCH-1679 > URL: https://issues.apache.org/jira/browse/DISPATCH-1679 > Project: Qpid Dispatch > Issue Type: Bug > Components: Routing Engine >Affects Versions: 1.12.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: leak > Fix For: 1.16.0 > > > Every unit test that involves use of a connector leaks the connector and a > related qd_timer_t. These leak warnings overwhelm other warnings in the test > output. > The qd_connector_t is reference counted. It also contains a qd_timer_t. > From initial debug the reference count is never dropping below 1. > It appears that every time the timer is scheduled the refcount is > incremented. This appears to be an attempt to prevent the deletion of the > qd_connector_t while the timer is outstanding. This appears likely to be the > source of the outstanding ref count. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1679) leak: qd_connector_t and qd_timer_t
[ https://issues.apache.org/jira/browse/DISPATCH-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340792#comment-17340792 ] ASF subversion and git services commented on DISPATCH-1679: --- Commit e4ebecfa27f98fd62a78fb2991076c23a2cc2362 in qpid-dispatch's branch refs/heads/1.16.x from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=e4ebecf ] DISPATCH-1679: Make qd_timer_cancel and qd_timer_free synchronous This patch makes the qd_timer_cancel() and qd_timer_free() routines block if the timer callback is currently running on another thread. This ensures that the callback is not executing when these calls return. It includes a fix to the HTTP1 adapter to avoid freeing its timer while holding the adaptor lock. This closes #1170 (cherry picked from commit 34b3c116dc97f9a1d7caf00fcea0e5e5144e6c45) Needed by fix for blocker JIRA DISPATCH-2046 > leak: qd_connector_t and qd_timer_t > --- > > Key: DISPATCH-1679 > URL: https://issues.apache.org/jira/browse/DISPATCH-1679 > Project: Qpid Dispatch > Issue Type: Bug > Components: Routing Engine >Affects Versions: 1.12.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: leak > Fix For: Backlog > > > Every unit test that involves use of a connector leaks the connector and a > related qd_timer_t. These leak warnings overwhelm other warnings in the test > output. > The qd_connector_t is reference counted. It also contains a qd_timer_t. > From initial debug the reference count is never dropping below 1. > It appears that every time the timer is scheduled the refcount is > incremented. This appears to be an attempt to prevent the deletion of the > qd_connector_t while the timer is outstanding. This appears likely to be the > source of the outstanding ref count. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2046) Panic in handle due to deleted connector.
[
https://issues.apache.org/jira/browse/DISPATCH-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340793#comment-17340793
]
ASF subversion and git services commented on DISPATCH-2046:
---
Commit e4ebecfa27f98fd62a78fb2991076c23a2cc2362 in qpid-dispatch's branch
refs/heads/1.16.x from Ken Giusti
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=e4ebecf ]
DISPATCH-1679: Make qd_timer_cancel and qd_timer_free synchronous
This patch makes the qd_timer_cancel() and qd_timer_free() routines
block if the timer callback is currently running on another thread.
This ensures that the callback is not executing when these calls
return.
It includes a fix to the HTTP1 adapter to avoid freeing its timer
while holding the adaptor lock.
This closes #1170
(cherry picked from commit 34b3c116dc97f9a1d7caf00fcea0e5e5144e6c45)
Needed by fix for blocker JIRA DISPATCH-2046
> Panic in handle due to deleted connector.
> -
>
> Key: DISPATCH-2046
> URL: https://issues.apache.org/jira/browse/DISPATCH-2046
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Routing Engine
>Affects Versions: 1.15.0
>Reporter: Alex Ward
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 1.16.0
>
>
> I am seeing a segv at line 1063 due to ctx->connector being 0 in
> server.c:handle().
> {code:java}
> (ugdb-x86_64-7.11-261) p ctx
> $6 = (qd_connection_t *) 0x802e55890
> (ugdb-x86_64-7.11-261) p *ctx
> $7 = {prev = 0x8023df490, next = 0x802e7a890, name = 0x0, server =
> 0x80220d0c0, opened = false, closed = false, closed_locally = false, enqueued
> = 0, timer = 0x0, pn_conn = 0x8023ec050, pn_sessions = {0x0 times>}, ssl = 0x0, listener = 0x0, connector = 0x0, connector_lock =
> 0x8023e6600, context = 0x0, user_context = 0x0, link_context = 0x0,
> connection_id = 12, user_id = 0x0, free_user_id = false, policy_settings =
> 0x0, n_sessions = 0, n_senders = 0, n_receivers = 0, open_container = 0x0,
> deferred_calls = {head = 0x0, tail = 0x0, scratch = 0x0, size = 0},
> deferred_call_lock = 0x8023e65c0, policy_counted = false, role = 0x801a17660
> "route-container", free_link_session_list = {head = 0x0, tail = 0x0, scratch
> = 0x0, size = 0}, strip_annotations_in = false, strip_annotations_out =
> false, wake = 0x8005d6e20 , rhost = '\000' times>, rhost_port = '\000' }
> {code}
> As the comment at the start of handle() states, there is only one event being
> handled at a time, but it doesn’t look like there is anything to stop someone
> clearing ctx->connector between lines 1055 and 1063. The python code seems to
> be coming in and deleting the connector while handle() is using it.
> [https://github.com/apache/qpid-dispatch/blob/main/src/server.c]
> {code:java}
> 989 /* Events involving a connection or listener are serialized by the
> proactor so
> 990 * only one event per connection / listener will be processed at a time.
>
> 991 */
> 992 static bool handle(qd_server_t *qd_server, pn_event_t *e,
> pn_connection_t *pn_conn, qd_connection_t *ctx)
> 993 {
>
> 994 if (pn_conn && qdr_is_authentication_service_connection(pn_conn)) {
>
> 995 qdr_handle_authentication_service_connection_event(e);
>
> 996 return true;
>
> 997 }
>
> 998
>
> 999 switch (pn_event_type(e)) {
> …
> 1051 case PN_TRANSPORT_ERROR:
>
> 1052 {
>
> 1053 pn_transport_t *transport = pn_event_transport(e);
>
> 1054 pn_condition_t* condition = transport ?
> pn_transport_condition(transport) : NULL;
> 1055 if (ctx && ctx->connector) { /* Outgoing connection */
>
> 1056 qd_increment_conn_index(ctx);
>
> 1057 const qd_server_config_t *config =
> >connector->config;
> 1058 ctx->connector->state = CXTR_STATE_FAILED;
>
[jira] [Commented] (DISPATCH-2046) Panic in handle due to deleted connector.
[
https://issues.apache.org/jira/browse/DISPATCH-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340794#comment-17340794
]
ASF subversion and git services commented on DISPATCH-2046:
---
Commit dd319e527127fc2d13ad8ff11b9a07d265f2309f in qpid-dispatch's branch
refs/heads/1.16.x from Ken Giusti
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=dd319e5 ]
DISPATCH-2046: prevent crash when accessing connector pointer
DISPATCH-1679: fix qd_connector_t leak
DISPATCH-1917: fix race when accessing connector->conn_msg buffer
This closes #1176
(cherry picked from commit 8545a425cd8ee86beffdc97464fd4d4a20618a05)
> Panic in handle due to deleted connector.
> -
>
> Key: DISPATCH-2046
> URL: https://issues.apache.org/jira/browse/DISPATCH-2046
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Routing Engine
>Affects Versions: 1.15.0
>Reporter: Alex Ward
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 1.16.0
>
>
> I am seeing a segv at line 1063 due to ctx->connector being 0 in
> server.c:handle().
> {code:java}
> (ugdb-x86_64-7.11-261) p ctx
> $6 = (qd_connection_t *) 0x802e55890
> (ugdb-x86_64-7.11-261) p *ctx
> $7 = {prev = 0x8023df490, next = 0x802e7a890, name = 0x0, server =
> 0x80220d0c0, opened = false, closed = false, closed_locally = false, enqueued
> = 0, timer = 0x0, pn_conn = 0x8023ec050, pn_sessions = {0x0 times>}, ssl = 0x0, listener = 0x0, connector = 0x0, connector_lock =
> 0x8023e6600, context = 0x0, user_context = 0x0, link_context = 0x0,
> connection_id = 12, user_id = 0x0, free_user_id = false, policy_settings =
> 0x0, n_sessions = 0, n_senders = 0, n_receivers = 0, open_container = 0x0,
> deferred_calls = {head = 0x0, tail = 0x0, scratch = 0x0, size = 0},
> deferred_call_lock = 0x8023e65c0, policy_counted = false, role = 0x801a17660
> "route-container", free_link_session_list = {head = 0x0, tail = 0x0, scratch
> = 0x0, size = 0}, strip_annotations_in = false, strip_annotations_out =
> false, wake = 0x8005d6e20 , rhost = '\000' times>, rhost_port = '\000' }
> {code}
> As the comment at the start of handle() states, there is only one event being
> handled at a time, but it doesn’t look like there is anything to stop someone
> clearing ctx->connector between lines 1055 and 1063. The python code seems to
> be coming in and deleting the connector while handle() is using it.
> [https://github.com/apache/qpid-dispatch/blob/main/src/server.c]
> {code:java}
> 989 /* Events involving a connection or listener are serialized by the
> proactor so
> 990 * only one event per connection / listener will be processed at a time.
>
> 991 */
> 992 static bool handle(qd_server_t *qd_server, pn_event_t *e,
> pn_connection_t *pn_conn, qd_connection_t *ctx)
> 993 {
>
> 994 if (pn_conn && qdr_is_authentication_service_connection(pn_conn)) {
>
> 995 qdr_handle_authentication_service_connection_event(e);
>
> 996 return true;
>
> 997 }
>
> 998
>
> 999 switch (pn_event_type(e)) {
> …
> 1051 case PN_TRANSPORT_ERROR:
>
> 1052 {
>
> 1053 pn_transport_t *transport = pn_event_transport(e);
>
> 1054 pn_condition_t* condition = transport ?
> pn_transport_condition(transport) : NULL;
> 1055 if (ctx && ctx->connector) { /* Outgoing connection */
>
> 1056 qd_increment_conn_index(ctx);
>
> 1057 const qd_server_config_t *config =
> >connector->config;
> 1058 ctx->connector->state = CXTR_STATE_FAILED;
>
> 1059 char conn_msg[300];
>
> 1060 if (condition && pn_condition_is_set(condition)) {
>
> 1061
[jira] [Commented] (DISPATCH-1679) leak: qd_connector_t and qd_timer_t
[ https://issues.apache.org/jira/browse/DISPATCH-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340795#comment-17340795 ] ASF subversion and git services commented on DISPATCH-1679: --- Commit dd319e527127fc2d13ad8ff11b9a07d265f2309f in qpid-dispatch's branch refs/heads/1.16.x from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=dd319e5 ] DISPATCH-2046: prevent crash when accessing connector pointer DISPATCH-1679: fix qd_connector_t leak DISPATCH-1917: fix race when accessing connector->conn_msg buffer This closes #1176 (cherry picked from commit 8545a425cd8ee86beffdc97464fd4d4a20618a05) > leak: qd_connector_t and qd_timer_t > --- > > Key: DISPATCH-1679 > URL: https://issues.apache.org/jira/browse/DISPATCH-1679 > Project: Qpid Dispatch > Issue Type: Bug > Components: Routing Engine >Affects Versions: 1.12.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: leak > Fix For: Backlog > > > Every unit test that involves use of a connector leaks the connector and a > related qd_timer_t. These leak warnings overwhelm other warnings in the test > output. > The qd_connector_t is reference counted. It also contains a qd_timer_t. > From initial debug the reference count is never dropping below 1. > It appears that every time the timer is scheduled the refcount is > incremented. This appears to be an attempt to prevent the deletion of the > qd_connector_t while the timer is outstanding. This appears likely to be the > source of the outstanding ref count. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2082) Leak of qd_delivery_state_t in system_tests_http1_over_tcp
[
https://issues.apache.org/jira/browse/DISPATCH-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340800#comment-17340800
]
ASF subversion and git services commented on DISPATCH-2082:
---
Commit 160019e7a1c7e8a29261b26ce79fff4fa18b28f3 in qpid-dispatch's branch
refs/heads/1.16.x from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=160019e ]
DISPATCH-2082: Added qd_delivery_state_t to leaking_types arrary. This closes
#1175.
(cherry picked from commit 84186ce0084f044a1e43689c4c0b648838305dbc)
> Leak of qd_delivery_state_t in system_tests_http1_over_tcp
> --
>
> Key: DISPATCH-2082
> URL: https://issues.apache.org/jira/browse/DISPATCH-2082
> Project: Qpid Dispatch
> Issue Type: Test
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501211928#L11775
> This is PR build for pool poisoning, but the issue should be in no way
> related to that.
> {noformat}
> 71: Router INT.A debug dump file:
> 71:
> 71: alloc.c: Items of type 'qd_buffer_t' remain allocated at shutdown: 17
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_message_t' remain allocated at shutdown: 2
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_message_content_t' remain allocated at
> shutdown: 2 (SUPPRESSED)
> 71: alloc.c: Items of type 'qdr_delivery_t' remain allocated at shutdown: 2
> (SUPPRESSED)
> 71: alloc.c: Items of type 'qd_delivery_state_t' remain allocated at
> shutdown: 1
> 71: Leak: 2021-04-26 20:06:52.908660 + type: qd_delivery_state_t address:
> 0x6127b9d0
> 71: qdrouterd(backtrace+0x5b) [0x45356b]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0xa68)
> [0x7f38cf658ee8]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_delivery_state+0x28)
> [0x7f38cf69ad48]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x2f6248)
> [0x7f38cf644248]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x525402)
> [0x7f38cf873402]
> 71:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x51ede0)
> [0x7f38cf86cde0]
> 71: /lib/x86_64-linux-gnu/libpthread.so.0(+0x9609) [0x7f38cf2c5609]
> 71: /lib/x86_64-linux-gnu/libc.so.6(clone+0x43) [0x7f38ceaf0293]
> {noformat}
> {noformat}
> 71: ==
> 71: ERROR: tearDownClass
> (system_tests_http1_over_tcp.Http1OverTcpOneRouterTest)
> 71: --
> 71: Traceback (most recent call last):
> 71: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 865, in tearDownClass
> 71: cls.tester.teardown()
> 71: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 808, in teardown
> 71: raise RuntimeError("Errors during teardown: \n\n%s" %
> "\n\n".join([str(e) for e in errors]))
> 71: RuntimeError: Errors during teardown:
> 71:
> 71: Process 18806 error: exit code -6, expected 0
> 71: qdrouterd -c INT.A.conf -I /home/travis/build/apache/qpid-dispatch/python
> 71:
> /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_http1_over_tcp/Http1OverTcpOneRouterTest/setUpClass/INT.A-4.cmd
> 71:
> 71: ERROR: Aborted due to unexpected alloc pool leak of type
> 'qd_delivery_state_t'
> 71:
> 71:
> 71: --
> 71: Ran 12 tests in 32.652s
> 71:
> 71: FAILED (errors=1)
> 71/74 Test #71: system_tests_http1_over_tcp ...***Failed
> 32.78 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2033) Rare flaky failure in system_tests_qdstat: out.count('UTC') != 1
[
https://issues.apache.org/jira/browse/DISPATCH-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340798#comment-17340798
]
ASF subversion and git services commented on DISPATCH-2033:
---
Commit b8d0881ebb99d7a6d81ac648555ad6b87808cc2c in qpid-dispatch's branch
refs/heads/1.16.x from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=b8d0881 ]
DISPATCH-2033: Wait for routers to talk to each other before starting the
tests. This closes #1185
(cherry picked from commit 68c08365628360ace9b9a32f02357eea3eda4adc)
> Rare flaky failure in system_tests_qdstat: out.count('UTC') != 1
>
>
> Key: DISPATCH-2033
> URL: https://issues.apache.org/jira/browse/DISPATCH-2033
> Project: Qpid Dispatch
> Issue Type: Test
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Minor
> Fix For: 1.16.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/495411108#L4787
> {noformat}
> 30: ==
> 30: FAIL: test_links_all_routers (system_tests_qdstat.QdstatLinkPriorityTest)
> 30: --
> 30: Traceback (most recent call last):
> 30: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_qdstat.py", line
> 657, in test_links_all_routers
> 30: self._test_links_all_routers(['--links', '--all-routers'])
> 30: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_qdstat.py", line
> 651, in _test_links_all_routers
> 30: self.assertTrue(out.count('UTC') == 1)
> 30: AssertionError: False is not true
> 30:
> 30: --
> 30: Ran 85 tests in 58.048s
> 30:
> 30: FAILED (failures=1)
> 30/73 Test #30: system_tests_qdstat ...***Failed
> 58.16 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2049) system_tests_multi_phase fails in test_17_multiphase_3
[
https://issues.apache.org/jira/browse/DISPATCH-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340799#comment-17340799
]
ASF subversion and git services commented on DISPATCH-2049:
---
Commit fb2b2d18db7a40a879fc27364ad46c9e05bfd708 in qpid-dispatch's branch
refs/heads/1.16.x from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=fb2b2d1 ]
DISPATCH-2049: Increased helloMaxAgeSeconds to 10 to give router enough time to
respond to HELLO message. This closes #1184.
(cherry picked from commit 422666ddf06996b290a264678d43562ef7e4cb7a)
> system_tests_multi_phase fails in test_17_multiphase_3
> --
>
> Key: DISPATCH-2049
> URL: https://issues.apache.org/jira/browse/DISPATCH-2049
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.15.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> {noformat}
> 60: ==
> 60: FAIL: test_17_multiphase_3 (system_tests_multi_phase.RouterTest)
> 60: --
> 60: Traceback (most recent call last):
> 60: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_multi_phase.py",
> line 244, in test_17_multiphase_3
> 60: self.assertEqual(None, test.error)
> 60: AssertionError: None != u'Timeout Expired - n_tx=300, n_rx=296,
> n_thru=[300, 300, 300, 300, 296, 296, 296, 296, 296]'
> 60:
> 60: --
> 60: Ran 17 tests in 218.404s {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2099) [TCP] crash in qd_message_stream_data_release() on connection close
[ https://issues.apache.org/jira/browse/DISPATCH-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340797#comment-17340797 ] ASF subversion and git services commented on DISPATCH-2099: --- Commit 2e977cae4ac4634c3a71c5f1f5e3f64757fc28be in qpid-dispatch's branch refs/heads/1.16.x from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2e977ca ] DISPATCH-2099: flush stream_data before releasing deliveries This closes #1183 (cherry picked from commit 18ac55448fea287339a6cc4bdbfd076ae9b6dd46) > [TCP] crash in qd_message_stream_data_release() on connection close > --- > > Key: DISPATCH-2099 > URL: https://issues.apache.org/jira/browse/DISPATCH-2099 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Priority: Blocker > Fix For: 1.16.0 > > > backtrace: > Thread 1 "qdrouterd" received signal SIGSEGV, Segmentation fault. > qd_message_stream_data_release (stream_data=0x7fffe00b44c8) at > /build/qpid-dispatch-src/src/message.c:2627 > #0 qd_message_stream_data_release (stream_data=0x7fffe00b44c8) at > /build/qpid-dispatch-src/src/message.c:2627 > #1 0x77f2e135 in flush_outgoing_buffs > (conn=conn@entry=0x7fffe00e4a88) at > /build/qpid-dispatch-src/src/adaptors/tcp_adaptor.c:431 > #2 0x77f30317 in handle_disconnected (conn=0x7fffe00e4a88) > at /build/qpid-dispatch-src/src/adaptors/tcp_adaptor.c:497 > 2627/build/qpid-dispatch-src/src/message.c: No such file or > directory. > #3 handle_connection_event (e=0x7fffe8023600, qd_server= out>, context=0x7fffe00e4a88) at > /build/qpid-dispatch-src/src/adaptors/tcp_adaptor.c:800 > #4 0x77f80941 in handle_event_with_context > (context=, qd_server=, e=) at > /build/qpid-dispatch-src/src/server.c:802 > #5 do_handle_raw_connection_event (qd_server=, > e=) at /build/qpid-dispatch-src/src/server.c:808 > #6 handle (qd_server=qd_server@entry=0x407620, > e=e@entry=0x7fffe8023600, pn_conn=pn_conn@entry=0x0, ctx=ctx@entry=0x0) at > /build/qpid-dispatch-src/src/server.c:1088 > #7 0x77f81978 in thread_run (arg=arg@entry=0x407620) at > /build/qpid-dispatch-src/src/server.c:1120 > #8 0x77f82000 in qd_server_run (qd=) at > /build/qpid-dispatch-src/src/server.c:1487 > #9 0x004026b2 in main_process (config_path=0x7fffe96c > "/tmp/qdrouterd.conf", python_pkgdir=, test_hooks= out>, fd=2) at /build/qpid-dispatch-src/router/src/main.c:115 > #10 0x00402400 in main (argc=3, argv=0x7fffe658) at > /build/qpid-dispatch-src/router/src/main.c:369 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1917) Thread race accessing connector->conn_msg buffer (TSAN)
[
https://issues.apache.org/jira/browse/DISPATCH-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340796#comment-17340796
]
ASF subversion and git services commented on DISPATCH-1917:
---
Commit dd319e527127fc2d13ad8ff11b9a07d265f2309f in qpid-dispatch's branch
refs/heads/1.16.x from Ken Giusti
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=dd319e5 ]
DISPATCH-2046: prevent crash when accessing connector pointer
DISPATCH-1679: fix qd_connector_t leak
DISPATCH-1917: fix race when accessing connector->conn_msg buffer
This closes #1176
(cherry picked from commit 8545a425cd8ee86beffdc97464fd4d4a20618a05)
> Thread race accessing connector->conn_msg buffer (TSAN)
> ---
>
> Key: DISPATCH-1917
> URL: https://issues.apache.org/jira/browse/DISPATCH-1917
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Labels: race-condition
> Fix For: 1.17.0
>
>
> qd_connector_t holds a buffer for connection related mgmt messages
> (conn_msg[300]).
> One thread can read it buffer content while another thread can write it:
> {noformat}
> 14: WARNING: ThreadSanitizer: data race (pid=63992)
> 14: Read of size 8 at 0x7b440140 by main thread (mutexes: write M13,
> write M312, write M9):
> 14: #0 strlen (libtsan.so.0+0x32c4f)
> 14: #1 PyUnicode_FromString (libpython3.8.so.1.0+0xf8a58)
> 14: #2 qd_entity_refresh_connector
> /home/kgiusti/work/dispatch/qpid-dispatch/src/connection_manager.c:868
> (libqpid-dispatch.so+0x68522)
> 14: #3 ffi_call_unix64 (libffi.so.6+0x6aef)
> 14: #4 qdr_forward_on_message
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/forwarder.c:336
> (libqpid-dispatch.so+0xb083c)
> 14: #5 qdr_general_handler
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:887
> (libqpid-dispatch.so+0xb9189)
> 14: #6 qd_timer_visit
> /home/kgiusti/work/dispatch/qpid-dispatch/src/timer.c:201
> (libqpid-dispatch.so+0xe60c7)
> 14: #7 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1008
> (libqpid-dispatch.so+0xe01ae)
> 14: #8 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1122
> (libqpid-dispatch.so+0xe2aa7)
> 14: #9 qd_server_run
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1484
> (libqpid-dispatch.so+0xe352f)
> 14: #10 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:113
> (qdrouterd+0x40287c)
> 14: #11 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
> 14:
> 14: Previous write of size 8 at 0x7b440140 by thread T3:
> 14: #0 strcpy (libtsan.so.0+0x45ac1)
> 14: #1 AMQP_opened_handler
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1241
> (libqpid-dispatch.so+0xdad01)
> 14: #2 AMQP_outbound_opened_handler
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1402
> (libqpid-dispatch.so+0xdba43)
> 14: #3 notify_opened
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:273
> (libqpid-dispatch.so+0x69fa3)
> 14: #4 policy_notify_opened
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:284
> (libqpid-dispatch.so+0x69fa3)
> 14: #5 qd_policy_amqp_open_connector
> /home/kgiusti/work/dispatch/qpid-dispatch/src/policy.c:1371
> (libqpid-dispatch.so+0x881fa)
> 14: #6 qd_container_handle_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:511
> (libqpid-dispatch.so+0x6c984)
> 14: #7 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1097
> (libqpid-dispatch.so+0xe0211)
> 14: #8 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1122
> (libqpid-dispatch.so+0xe2a34)
> 14: #9 _thread_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172
> (libqpid-dispatch.so+0x8c5f2)
> 14: #10 (libtsan.so.0+0x2d33f)
> 14:
> 14: Location is heap block of size 300 at 0x7b440140 allocated by main
> thread:
> 14: #0 malloc (libtsan.so.0+0x304d3)
> 14: #1 qd_server_connector
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1657
> (libqpid-dispatch.so+0xe49d4)
> 14: #2 qd_dispatch_configure_connector
> /home/kgiusti/work/dispatch/qpid-dispatch/src/connection_manager.c:878
> (libqpid-dispatch.so+0x6856d)
> 14: #3 ffi_call_unix64 (libffi.so.6+0x6aef)
> 14: #4 main_process
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95
> (qdrouterd+0x40281c)
> 14: #5 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367
> (qdrouterd+0x4024fc)
> 14:
> 14: Mutex M13 (0x7b100340) created at:
> 14: #0 pthread_mutex_init (libtsan.so.0+0x4a7c6)
> 14: #1 sys_mutex
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:43
>
[GitHub] [qpid-dispatch] asfgit merged pull request #1190: 1.16.x update
asfgit merged pull request #1190: URL: https://github.com/apache/qpid-dispatch/pull/1190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2049) system_tests_multi_phase fails in test_17_multiphase_3
[
https://issues.apache.org/jira/browse/DISPATCH-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340784#comment-17340784
]
ASF GitHub Bot commented on DISPATCH-2049:
--
jiridanek merged pull request #1194:
URL: https://github.com/apache/qpid-dispatch/pull/1194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_multi_phase fails in test_17_multiphase_3
> --
>
> Key: DISPATCH-2049
> URL: https://issues.apache.org/jira/browse/DISPATCH-2049
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.15.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> {noformat}
> 60: ==
> 60: FAIL: test_17_multiphase_3 (system_tests_multi_phase.RouterTest)
> 60: --
> 60: Traceback (most recent call last):
> 60: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_multi_phase.py",
> line 244, in test_17_multiphase_3
> 60: self.assertEqual(None, test.error)
> 60: AssertionError: None != u'Timeout Expired - n_tx=300, n_rx=296,
> n_thru=[300, 300, 300, 300, 296, 296, 296, 296, 296]'
> 60:
> 60: --
> 60: Ran 17 tests in 218.404s {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2049) system_tests_multi_phase fails in test_17_multiphase_3
[
https://issues.apache.org/jira/browse/DISPATCH-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340783#comment-17340783
]
ASF subversion and git services commented on DISPATCH-2049:
---
Commit c29684b9ce1912b3a67b778e1bd4db808cd438c4 in qpid-dispatch's branch
refs/heads/main from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c29684b ]
DISPATCH 2021, DISPATCH-2049: report the entire client error string in
assertion message (#1194)
TestCase#assertEqual truncates the diff when arguments differ.
assertIsNone prints the argument in full when it is not None.
> system_tests_multi_phase fails in test_17_multiphase_3
> --
>
> Key: DISPATCH-2049
> URL: https://issues.apache.org/jira/browse/DISPATCH-2049
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.15.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> {noformat}
> 60: ==
> 60: FAIL: test_17_multiphase_3 (system_tests_multi_phase.RouterTest)
> 60: --
> 60: Traceback (most recent call last):
> 60: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_multi_phase.py",
> line 244, in test_17_multiphase_3
> 60: self.assertEqual(None, test.error)
> 60: AssertionError: None != u'Timeout Expired - n_tx=300, n_rx=296,
> n_thru=[300, 300, 300, 300, 296, 296, 296, 296, 296]'
> 60:
> 60: --
> 60: Ran 17 tests in 218.404s {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #1194: DISPATCH 2021, DISPATCH-2049: report the entire client error string in assertion message
jiridanek merged pull request #1194: URL: https://github.com/apache/qpid-dispatch/pull/1194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek opened a new pull request #311: NO-JIRA fix travis build?
jiridanek opened a new pull request #311: URL: https://github.com/apache/qpid-proton/pull/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1189: NO-JIRA: Temporarily removed build due to following error:
jiridanek commented on pull request #1189: URL: https://github.com/apache/qpid-dispatch/pull/1189#issuecomment-834318533 I'll try to apply the downgrade in Proton, to see what happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] gemmellr edited a comment on pull request #1189: NO-JIRA: Temporarily removed build due to following error:
gemmellr edited a comment on pull request #1189: URL: https://github.com/apache/qpid-dispatch/pull/1189#issuecomment-834301700 FWIW this describes the issue and a workaround (they preinstalled a libc package version on their build node images, but that package release was then cancelled, and some stuff like clang and valgrind still require the old version...workaround is downgrade some affected bits until they get round to it): https://travis-ci.community/t/clang-10-was-recently-broken-on-linux-unmet-dependencies-for-clang-10-clang-tidy-10-valgrind/11527/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] gemmellr commented on pull request #1189: NO-JIRA: Temporarily removed build due to following error:
gemmellr commented on pull request #1189: URL: https://github.com/apache/qpid-dispatch/pull/1189#issuecomment-834301700 FWIW this describes the issue and a workaround (they preinstalled a libc package version on their build node images, but that package release was then cancelled, and some stuff like valgrind still require the old version...workaround is downgrade some affected bits until they get round to it): https://travis-ci.community/t/clang-10-was-recently-broken-on-linux-unmet-dependencies-for-clang-10-clang-tidy-10-valgrind/11527/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2105) [s390s] Compilation failure on Ubuntu Xenial: argument 1 range [18446744071562067968, 18446744073709551615] exceeds maximum object size 9223372036854775807 [-Werror=al
Jiri Daněk created DISPATCH-2105:
Summary: [s390s] Compilation failure on Ubuntu Xenial: argument 1
range [18446744071562067968, 18446744073709551615] exceeds maximum object size
9223372036854775807 [-Werror=alloc-size-larger-than=]
Key: DISPATCH-2105
URL: https://issues.apache.org/jira/browse/DISPATCH-2105
Project: Qpid Dispatch
Issue Type: Bug
Affects Versions: 1.16.0
Reporter: Jiri Daněk
https://travis-ci.com/github/apache/qpid-dispatch/jobs/503619678#L1658
{code}
[ 19%] Building C object src/CMakeFiles/qpid-dispatch.dir/connection_manager.c.o
/home/travis/build/apache/qpid-dispatch/src/connection_manager.c: In function
‘qd_entity_refresh_connector’:
/home/travis/build/apache/qpid-dispatch/src/connection_manager.c:804:10: error:
argument 1 range [18446744071562067968, 18446744073709551615] exceeds maximum
object size 9223372036854775807 [-Werror=alloc-size-larger-than=]
char failover_info[arr_length + 1];
^
/home/travis/build/apache/qpid-dispatch/src/connection_manager.c:804:10: note:
in a call to built-in allocation function ‘__builtin_alloca_with_align’
cc1: all warnings being treated as errors
src/CMakeFiles/qpid-dispatch.dir/build.make:439: recipe for target
'src/CMakeFiles/qpid-dispatch.dir/connection_manager.c.o' failed
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-848) Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in router_core/route_tables.c:149
[ https://issues.apache.org/jira/browse/DISPATCH-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340646#comment-17340646 ] ASF GitHub Bot commented on DISPATCH-848: - codecov-commenter edited a comment on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-824182600 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1052](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (671ba8e) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/5c8b2d4fae2d96bf56f787055cbbd340bdad3477?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5c8b2d4) will **decrease** coverage by `0.05%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1052 +/- ## == - Coverage 84.36% 84.30% -0.06% == Files 113 113 Lines 2800428019 +15 == - Hits2362623622 -4 - Misses 4378 4397 +19 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2Rpc3BhdGNoLmM=) | `83.88% <100.00%> (+0.07%)` | :arrow_up: | | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `69.55% <100.00%> (+1.12%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `85.87% <100.00%> (-1.53%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.68% <100.00%> (ø)` | | | [src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==) | `88.34% <100.00%> (+0.37%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-2.96%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.10% <0.00%> (-0.87%)` | :arrow_down: | | [src/hash.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2hhc2guYw==) | `79.53% <0.00%> (-0.47%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `70.17% <0.00%> (-0.36%)` | :arrow_down: | | ... and [7
[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1052: DISPATCH-848, DISPATCH-1962 Fix leak of IoAdapter_init
codecov-commenter edited a comment on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-824182600 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1052](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (671ba8e) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/5c8b2d4fae2d96bf56f787055cbbd340bdad3477?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5c8b2d4) will **decrease** coverage by `0.05%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1052 +/- ## == - Coverage 84.36% 84.30% -0.06% == Files 113 113 Lines 2800428019 +15 == - Hits2362623622 -4 - Misses 4378 4397 +19 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2Rpc3BhdGNoLmM=) | `83.88% <100.00%> (+0.07%)` | :arrow_up: | | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `69.55% <100.00%> (+1.12%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `85.87% <100.00%> (-1.53%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.68% <100.00%> (ø)` | | | [src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==) | `88.34% <100.00%> (+0.37%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-2.96%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.10% <0.00%> (-0.87%)` | :arrow_down: | | [src/hash.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2hhc2guYw==) | `79.53% <0.00%> (-0.47%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `70.17% <0.00%> (-0.36%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/apache/qpid-dispatch/pull/1052/diff?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | | -- [Continue to review full report at
