[jira] [Resolved] (QPID-8520) [Broker-J] ReadPendingException thrown by Broker-J intermittently
[
https://issues.apache.org/jira/browse/QPID-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy resolved QPID-8520.
--
Resolution: Fixed
> [Broker-J] ReadPendingException thrown by Broker-J intermittently
> -
>
> Key: QPID-8520
> URL: https://issues.apache.org/jira/browse/QPID-8520
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.2
> Environment: Broker-J 8.0.2
> Spring Boot 3.2.2
> Docker Engine v20.10.5
> Testcontainers 1.15.1
>Reporter: Kyrre
>Priority: Major
> Fix For: qpid-java-broker-8.0.5
>
>
> Our project is using the HTTPS management interface, using a REST client.
> We've wrapped our qpid instance in a Docker container using testcontainers,
> and have a test that sets up and tears down different elements we utilise in
> our system with asserts that things are as we expected, all this over HTTPS
> between the local machine and the container. This works splendidly, except
> for the fact that we see intermittent errors in the test of the type
> {quote}java.nio.channels.ReadPendingException: null
> at org.eclipse.jetty.io.FillInterest.register(FillInterest.java:58)
> at
> org.eclipse.jetty.io.AbstractEndPoint.fillInterested(AbstractEndPoint.java:362)
> at
> org.eclipse.jetty.io.AbstractConnection.fillInterested(AbstractConnection.java:134)
> at org.eclipse.jetty.server.HttpConnection.onOpen(HttpConnection.java:505)
> at org.eclipse.jetty.io.ssl.SslConnection.onOpen(SslConnection.java:357)
> at
> org.apache.qpid.server.management.plugin.portunification.TlsOrPlainConnectionFactory$PlainOrTlsConnection.onOpen(TlsOrPlainConnectionFactory.java:166)
> at
> org.eclipse.jetty.io.SelectorManager.connectionOpened(SelectorManager.java:324)
> at
> org.eclipse.jetty.io.ManagedSelector.createEndPoint(ManagedSelector.java:368)
> at org.eclipse.jetty.io.ManagedSelector.access$2000(ManagedSelector.java:62)
> at org.eclipse.jetty.io.ManagedSelector$Accept.run(ManagedSelector.java:853)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:938)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at java.lang.Thread.run(Thread.java:745)
> {quote}
> This occurs directly after these log lines:
> {quote}2021-04-22 13:42:23,709 WARN [qtp1875836959-116]
> (o.e.j.i.FillInterest) - Read pending for null prevented
> AC.ReadCB@108ec429{HttpConnection@108ec429::DecryptedEndPoint@7cbac9d1{l=/172.17.0.3:443,r=/172.17.0.1:36566,OPEN,fill=-,flush=-,to=2/3}}
> 2021-04-22 13:42:23,721 WARN [qtp1875836959-116] (o.e.j.i.SelectorManager) -
> Exception while notifying connection
> PlainOrTlsConnection@2fb30f4a<-org.apache.qpid.server.management.plugin.portunification.MarkableEndPoint@46d4f493
> {quote}
> From the client side log:
> {quote}org.springframework.web.client.ResourceAccessException: I/O error on
> POST request for
> "https://localhost:49201/api/latest/queue/default/localhost/": Remote host
> terminated the handshake; nested exception is
> javax.net.ssl.SSLHandshakeException: Remote host terminated the handshake
> {quote}
> I am fully aware that this might be a bit too little to go by, but I have
> tried in to create a reproducible code snippet, but cannot find a way to make
> the error occur in a stable and reproducible way. I am also aware that this
> might be caused by a number of other things, but figured thia would be a good
> start to try to find out what to do about it.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8520) ReadPendingException thrown by Broker-J intermittently
[
https://issues.apache.org/jira/browse/QPID-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363211#comment-17363211
]
ASF subversion and git services commented on QPID-8520:
---
Commit 7368075c69cce683e6d599e4ac7c18da6deed3cc in qpid-broker-j's branch
refs/heads/8.0.x from Alex Rudyy
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=7368075 ]
QPID-8520: Substitute TlsOrPlainConnectionFactory with jetty
OptionalSslConnectionFactory
> ReadPendingException thrown by Broker-J intermittently
> --
>
> Key: QPID-8520
> URL: https://issues.apache.org/jira/browse/QPID-8520
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.2
> Environment: Broker-J 8.0.2
> Spring Boot 3.2.2
> Docker Engine v20.10.5
> Testcontainers 1.15.1
>Reporter: Kyrre
>Priority: Major
> Fix For: qpid-java-broker-8.0.5
>
>
> Our project is using the HTTPS management interface, using a REST client.
> We've wrapped our qpid instance in a Docker container using testcontainers,
> and have a test that sets up and tears down different elements we utilise in
> our system with asserts that things are as we expected, all this over HTTPS
> between the local machine and the container. This works splendidly, except
> for the fact that we see intermittent errors in the test of the type
> {quote}java.nio.channels.ReadPendingException: null
> at org.eclipse.jetty.io.FillInterest.register(FillInterest.java:58)
> at
> org.eclipse.jetty.io.AbstractEndPoint.fillInterested(AbstractEndPoint.java:362)
> at
> org.eclipse.jetty.io.AbstractConnection.fillInterested(AbstractConnection.java:134)
> at org.eclipse.jetty.server.HttpConnection.onOpen(HttpConnection.java:505)
> at org.eclipse.jetty.io.ssl.SslConnection.onOpen(SslConnection.java:357)
> at
> org.apache.qpid.server.management.plugin.portunification.TlsOrPlainConnectionFactory$PlainOrTlsConnection.onOpen(TlsOrPlainConnectionFactory.java:166)
> at
> org.eclipse.jetty.io.SelectorManager.connectionOpened(SelectorManager.java:324)
> at
> org.eclipse.jetty.io.ManagedSelector.createEndPoint(ManagedSelector.java:368)
> at org.eclipse.jetty.io.ManagedSelector.access$2000(ManagedSelector.java:62)
> at org.eclipse.jetty.io.ManagedSelector$Accept.run(ManagedSelector.java:853)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:938)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at java.lang.Thread.run(Thread.java:745)
> {quote}
> This occurs directly after these log lines:
> {quote}2021-04-22 13:42:23,709 WARN [qtp1875836959-116]
> (o.e.j.i.FillInterest) - Read pending for null prevented
> AC.ReadCB@108ec429{HttpConnection@108ec429::DecryptedEndPoint@7cbac9d1{l=/172.17.0.3:443,r=/172.17.0.1:36566,OPEN,fill=-,flush=-,to=2/3}}
> 2021-04-22 13:42:23,721 WARN [qtp1875836959-116] (o.e.j.i.SelectorManager) -
> Exception while notifying connection
> PlainOrTlsConnection@2fb30f4a<-org.apache.qpid.server.management.plugin.portunification.MarkableEndPoint@46d4f493
> {quote}
> From the client side log:
> {quote}org.springframework.web.client.ResourceAccessException: I/O error on
> POST request for
> "https://localhost:49201/api/latest/queue/default/localhost/": Remote host
> terminated the handshake; nested exception is
> javax.net.ssl.SSLHandshakeException: Remote host terminated the handshake
> {quote}
> I am fully aware that this might be a bit too little to go by, but I have
> tried in to create a reproducible code snippet, but cannot find a way to make
> the error occur in a stable and reproducible way. I am also aware that this
> might be caused by a number of other things, but figured thia would be a good
> start to try to find out what to do about it.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8520) [Broker-J] ReadPendingException thrown by Broker-J intermittently
[
https://issues.apache.org/jira/browse/QPID-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-8520:
-
Summary: [Broker-J] ReadPendingException thrown by Broker-J intermittently
(was: ReadPendingException thrown by Broker-J intermittently)
> [Broker-J] ReadPendingException thrown by Broker-J intermittently
> -
>
> Key: QPID-8520
> URL: https://issues.apache.org/jira/browse/QPID-8520
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.2
> Environment: Broker-J 8.0.2
> Spring Boot 3.2.2
> Docker Engine v20.10.5
> Testcontainers 1.15.1
>Reporter: Kyrre
>Priority: Major
> Fix For: qpid-java-broker-8.0.5
>
>
> Our project is using the HTTPS management interface, using a REST client.
> We've wrapped our qpid instance in a Docker container using testcontainers,
> and have a test that sets up and tears down different elements we utilise in
> our system with asserts that things are as we expected, all this over HTTPS
> between the local machine and the container. This works splendidly, except
> for the fact that we see intermittent errors in the test of the type
> {quote}java.nio.channels.ReadPendingException: null
> at org.eclipse.jetty.io.FillInterest.register(FillInterest.java:58)
> at
> org.eclipse.jetty.io.AbstractEndPoint.fillInterested(AbstractEndPoint.java:362)
> at
> org.eclipse.jetty.io.AbstractConnection.fillInterested(AbstractConnection.java:134)
> at org.eclipse.jetty.server.HttpConnection.onOpen(HttpConnection.java:505)
> at org.eclipse.jetty.io.ssl.SslConnection.onOpen(SslConnection.java:357)
> at
> org.apache.qpid.server.management.plugin.portunification.TlsOrPlainConnectionFactory$PlainOrTlsConnection.onOpen(TlsOrPlainConnectionFactory.java:166)
> at
> org.eclipse.jetty.io.SelectorManager.connectionOpened(SelectorManager.java:324)
> at
> org.eclipse.jetty.io.ManagedSelector.createEndPoint(ManagedSelector.java:368)
> at org.eclipse.jetty.io.ManagedSelector.access$2000(ManagedSelector.java:62)
> at org.eclipse.jetty.io.ManagedSelector$Accept.run(ManagedSelector.java:853)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:938)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at java.lang.Thread.run(Thread.java:745)
> {quote}
> This occurs directly after these log lines:
> {quote}2021-04-22 13:42:23,709 WARN [qtp1875836959-116]
> (o.e.j.i.FillInterest) - Read pending for null prevented
> AC.ReadCB@108ec429{HttpConnection@108ec429::DecryptedEndPoint@7cbac9d1{l=/172.17.0.3:443,r=/172.17.0.1:36566,OPEN,fill=-,flush=-,to=2/3}}
> 2021-04-22 13:42:23,721 WARN [qtp1875836959-116] (o.e.j.i.SelectorManager) -
> Exception while notifying connection
> PlainOrTlsConnection@2fb30f4a<-org.apache.qpid.server.management.plugin.portunification.MarkableEndPoint@46d4f493
> {quote}
> From the client side log:
> {quote}org.springframework.web.client.ResourceAccessException: I/O error on
> POST request for
> "https://localhost:49201/api/latest/queue/default/localhost/": Remote host
> terminated the handshake; nested exception is
> javax.net.ssl.SSLHandshakeException: Remote host terminated the handshake
> {quote}
> I am fully aware that this might be a bit too little to go by, but I have
> tried in to create a reproducible code snippet, but cannot find a way to make
> the error occur in a stable and reproducible way. I am also aware that this
> might be caused by a number of other things, but figured thia would be a good
> start to try to find out what to do about it.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8520) ReadPendingException thrown by Broker-J intermittently
[
https://issues.apache.org/jira/browse/QPID-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363209#comment-17363209
]
ASF subversion and git services commented on QPID-8520:
---
Commit 71eb57ef893bc19cad5880996611d095d3a27325 in qpid-broker-j's branch
refs/heads/main from Alex Rudyy
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=71eb57e ]
QPID-8520: [Broker-J] Substitute TlsOrPlainConnectionFactory with jetty
OptionalSslConnectionFactory
> ReadPendingException thrown by Broker-J intermittently
> --
>
> Key: QPID-8520
> URL: https://issues.apache.org/jira/browse/QPID-8520
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.2
> Environment: Broker-J 8.0.2
> Spring Boot 3.2.2
> Docker Engine v20.10.5
> Testcontainers 1.15.1
>Reporter: Kyrre
>Priority: Major
> Fix For: qpid-java-broker-8.0.5
>
>
> Our project is using the HTTPS management interface, using a REST client.
> We've wrapped our qpid instance in a Docker container using testcontainers,
> and have a test that sets up and tears down different elements we utilise in
> our system with asserts that things are as we expected, all this over HTTPS
> between the local machine and the container. This works splendidly, except
> for the fact that we see intermittent errors in the test of the type
> {quote}java.nio.channels.ReadPendingException: null
> at org.eclipse.jetty.io.FillInterest.register(FillInterest.java:58)
> at
> org.eclipse.jetty.io.AbstractEndPoint.fillInterested(AbstractEndPoint.java:362)
> at
> org.eclipse.jetty.io.AbstractConnection.fillInterested(AbstractConnection.java:134)
> at org.eclipse.jetty.server.HttpConnection.onOpen(HttpConnection.java:505)
> at org.eclipse.jetty.io.ssl.SslConnection.onOpen(SslConnection.java:357)
> at
> org.apache.qpid.server.management.plugin.portunification.TlsOrPlainConnectionFactory$PlainOrTlsConnection.onOpen(TlsOrPlainConnectionFactory.java:166)
> at
> org.eclipse.jetty.io.SelectorManager.connectionOpened(SelectorManager.java:324)
> at
> org.eclipse.jetty.io.ManagedSelector.createEndPoint(ManagedSelector.java:368)
> at org.eclipse.jetty.io.ManagedSelector.access$2000(ManagedSelector.java:62)
> at org.eclipse.jetty.io.ManagedSelector$Accept.run(ManagedSelector.java:853)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:938)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at java.lang.Thread.run(Thread.java:745)
> {quote}
> This occurs directly after these log lines:
> {quote}2021-04-22 13:42:23,709 WARN [qtp1875836959-116]
> (o.e.j.i.FillInterest) - Read pending for null prevented
> AC.ReadCB@108ec429{HttpConnection@108ec429::DecryptedEndPoint@7cbac9d1{l=/172.17.0.3:443,r=/172.17.0.1:36566,OPEN,fill=-,flush=-,to=2/3}}
> 2021-04-22 13:42:23,721 WARN [qtp1875836959-116] (o.e.j.i.SelectorManager) -
> Exception while notifying connection
> PlainOrTlsConnection@2fb30f4a<-org.apache.qpid.server.management.plugin.portunification.MarkableEndPoint@46d4f493
> {quote}
> From the client side log:
> {quote}org.springframework.web.client.ResourceAccessException: I/O error on
> POST request for
> "https://localhost:49201/api/latest/queue/default/localhost/": Remote host
> terminated the handshake; nested exception is
> javax.net.ssl.SSLHandshakeException: Remote host terminated the handshake
> {quote}
> I am fully aware that this might be a bit too little to go by, but I have
> tried in to create a reproducible code snippet, but cannot find a way to make
> the error occur in a stable and reproducible way. I am also aware that this
> might be caused by a number of other things, but figured thia would be a good
> start to try to find out what to do about it.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8520) ReadPendingException thrown by Broker-J intermittently
[
https://issues.apache.org/jira/browse/QPID-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363210#comment-17363210
]
ASF subversion and git services commented on QPID-8520:
---
Commit 9b396b409899283cce14d6a2253c73865faededa in qpid-broker-j's branch
refs/heads/main from Alex Rudyy
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=9b396b4 ]
QPID-8520: [Broker-J] Remove Qpid port-unification support for Jetty
> ReadPendingException thrown by Broker-J intermittently
> --
>
> Key: QPID-8520
> URL: https://issues.apache.org/jira/browse/QPID-8520
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.2
> Environment: Broker-J 8.0.2
> Spring Boot 3.2.2
> Docker Engine v20.10.5
> Testcontainers 1.15.1
>Reporter: Kyrre
>Priority: Major
> Fix For: qpid-java-broker-8.0.5
>
>
> Our project is using the HTTPS management interface, using a REST client.
> We've wrapped our qpid instance in a Docker container using testcontainers,
> and have a test that sets up and tears down different elements we utilise in
> our system with asserts that things are as we expected, all this over HTTPS
> between the local machine and the container. This works splendidly, except
> for the fact that we see intermittent errors in the test of the type
> {quote}java.nio.channels.ReadPendingException: null
> at org.eclipse.jetty.io.FillInterest.register(FillInterest.java:58)
> at
> org.eclipse.jetty.io.AbstractEndPoint.fillInterested(AbstractEndPoint.java:362)
> at
> org.eclipse.jetty.io.AbstractConnection.fillInterested(AbstractConnection.java:134)
> at org.eclipse.jetty.server.HttpConnection.onOpen(HttpConnection.java:505)
> at org.eclipse.jetty.io.ssl.SslConnection.onOpen(SslConnection.java:357)
> at
> org.apache.qpid.server.management.plugin.portunification.TlsOrPlainConnectionFactory$PlainOrTlsConnection.onOpen(TlsOrPlainConnectionFactory.java:166)
> at
> org.eclipse.jetty.io.SelectorManager.connectionOpened(SelectorManager.java:324)
> at
> org.eclipse.jetty.io.ManagedSelector.createEndPoint(ManagedSelector.java:368)
> at org.eclipse.jetty.io.ManagedSelector.access$2000(ManagedSelector.java:62)
> at org.eclipse.jetty.io.ManagedSelector$Accept.run(ManagedSelector.java:853)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:938)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at java.lang.Thread.run(Thread.java:745)
> {quote}
> This occurs directly after these log lines:
> {quote}2021-04-22 13:42:23,709 WARN [qtp1875836959-116]
> (o.e.j.i.FillInterest) - Read pending for null prevented
> AC.ReadCB@108ec429{HttpConnection@108ec429::DecryptedEndPoint@7cbac9d1{l=/172.17.0.3:443,r=/172.17.0.1:36566,OPEN,fill=-,flush=-,to=2/3}}
> 2021-04-22 13:42:23,721 WARN [qtp1875836959-116] (o.e.j.i.SelectorManager) -
> Exception while notifying connection
> PlainOrTlsConnection@2fb30f4a<-org.apache.qpid.server.management.plugin.portunification.MarkableEndPoint@46d4f493
> {quote}
> From the client side log:
> {quote}org.springframework.web.client.ResourceAccessException: I/O error on
> POST request for
> "https://localhost:49201/api/latest/queue/default/localhost/": Remote host
> terminated the handshake; nested exception is
> javax.net.ssl.SSLHandshakeException: Remote host terminated the handshake
> {quote}
> I am fully aware that this might be a bit too little to go by, but I have
> tried in to create a reproducible code snippet, but cannot find a way to make
> the error occur in a stable and reproducible way. I am also aware that this
> might be caused by a number of other things, but figured thia would be a good
> start to try to find out what to do about it.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2161) HTTP/1.x server connection hangs if client disconnects during response message
[ https://issues.apache.org/jira/browse/DISPATCH-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-2161. -- Resolution: Fixed > HTTP/1.x server connection hangs if client disconnects during response message > -- > > Key: DISPATCH-2161 > URL: https://issues.apache.org/jira/browse/DISPATCH-2161 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Labels: HTTP/1.x > Fix For: 1.17.0 > > > While running a single-router configuration against the _wrk_ HTTP load > generator, if the HTTP client drops the connection before the server has > completed the response then the server becomes unreachable. In other words > the connection to the HTTP server becomes blocked indefinitely and requires a > restart of the connection to recover. > To reproduce use the nginx/wrk 1 router configuration from: > [https://github.com/kgiusti/dispatch-tester/tree/master/benchmarks/test-configurations/http1-perf] > > Run the wrk test for a short period with a large response message: > > wrk -c 2 -t 2 -d4s http://127.0.0.1:8000/t1M.html > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2167) HTTP/1.x server connection hangs if client request is aborted
[ https://issues.apache.org/jira/browse/DISPATCH-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-2167. -- Resolution: Fixed > HTTP/1.x server connection hangs if client request is aborted > - > > Key: DISPATCH-2167 > URL: https://issues.apache.org/jira/browse/DISPATCH-2167 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Fix For: 1.17.0 > > > If an HTTP client connection drops before the entire client request message > has arrived the router properly aborts the message. > The adaptor on the server-facing side does not detect the abort and simply > hangs the connection (blocks) indefinitely. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2161) HTTP/1.x server connection hangs if client disconnects during response message
[ https://issues.apache.org/jira/browse/DISPATCH-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363201#comment-17363201 ] ASF GitHub Bot commented on DISPATCH-2161: -- asfgit closed pull request #1251: URL: https://github.com/apache/qpid-dispatch/pull/1251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > HTTP/1.x server connection hangs if client disconnects during response message > -- > > Key: DISPATCH-2161 > URL: https://issues.apache.org/jira/browse/DISPATCH-2161 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Labels: HTTP/1.x > Fix For: 1.17.0 > > > While running a single-router configuration against the _wrk_ HTTP load > generator, if the HTTP client drops the connection before the server has > completed the response then the server becomes unreachable. In other words > the connection to the HTTP server becomes blocked indefinitely and requires a > restart of the connection to recover. > To reproduce use the nginx/wrk 1 router configuration from: > [https://github.com/kgiusti/dispatch-tester/tree/master/benchmarks/test-configurations/http1-perf] > > Run the wrk test for a short period with a large response message: > > wrk -c 2 -t 2 -d4s http://127.0.0.1:8000/t1M.html > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2167) HTTP/1.x server connection hangs if client request is aborted
[ https://issues.apache.org/jira/browse/DISPATCH-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363200#comment-17363200 ] ASF subversion and git services commented on DISPATCH-2167: --- Commit 4770312a4bbb61d544ed7562c15e6810067293dc in qpid-dispatch's branch refs/heads/main from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=4770312 ] DISPATCH-2161, DISPATCH-2167: handle various client close errors This closes #1251 > HTTP/1.x server connection hangs if client request is aborted > - > > Key: DISPATCH-2167 > URL: https://issues.apache.org/jira/browse/DISPATCH-2167 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Fix For: 1.17.0 > > > If an HTTP client connection drops before the entire client request message > has arrived the router properly aborts the message. > The adaptor on the server-facing side does not detect the abort and simply > hangs the connection (blocks) indefinitely. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2161) HTTP/1.x server connection hangs if client disconnects during response message
[ https://issues.apache.org/jira/browse/DISPATCH-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363199#comment-17363199 ] ASF subversion and git services commented on DISPATCH-2161: --- Commit 4770312a4bbb61d544ed7562c15e6810067293dc in qpid-dispatch's branch refs/heads/main from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=4770312 ] DISPATCH-2161, DISPATCH-2167: handle various client close errors This closes #1251 > HTTP/1.x server connection hangs if client disconnects during response message > -- > > Key: DISPATCH-2161 > URL: https://issues.apache.org/jira/browse/DISPATCH-2161 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Blocker > Labels: HTTP/1.x > Fix For: 1.17.0 > > > While running a single-router configuration against the _wrk_ HTTP load > generator, if the HTTP client drops the connection before the server has > completed the response then the server becomes unreachable. In other words > the connection to the HTTP server becomes blocked indefinitely and requires a > restart of the connection to recover. > To reproduce use the nginx/wrk 1 router configuration from: > [https://github.com/kgiusti/dispatch-tester/tree/master/benchmarks/test-configurations/http1-perf] > > Run the wrk test for a short period with a large response message: > > wrk -c 2 -t 2 -d4s http://127.0.0.1:8000/t1M.html > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1251: DISPATCH-2161, DISPATCH-2167: handle various client close errors
asfgit closed pull request #1251: URL: https://github.com/apache/qpid-dispatch/pull/1251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1977) [http2] adaptor must not call proton functions after pn_raw_connection_close
[ https://issues.apache.org/jira/browse/DISPATCH-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1977. - Resolution: Fixed > [http2] adaptor must not call proton functions after pn_raw_connection_close > > > Key: DISPATCH-1977 > URL: https://issues.apache.org/jira/browse/DISPATCH-1977 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Charles E. Rolke >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.17.0 > > > Http2 adaptor code may have the same problem as DISPATCH-1968 TCP adaptor > code. > The rule is never to call pn_raw_connection_wake or > pn_raw_connection_write_buffers after calling pn_raw_connection_close. > The trigger for the failure, at least in the tcp adaptor case, is to close > the server-side connection while the client-side connection is sending to it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1977) [http2] adaptor must not call proton functions after pn_raw_connection_close
[ https://issues.apache.org/jira/browse/DISPATCH-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363187#comment-17363187 ] ASF subversion and git services commented on DISPATCH-1977: --- Commit d2987b015afa580d04c16939ed7f063c9c03c015 in qpid-dispatch's branch refs/heads/main from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=d2987b0 ] DISPATCH-1977: Introduced atomics raw_closed_read and raw_closed_write in http2 adaptor. Also made raw_closed_write and raw_closed_read as atomics in tcp_adaptor. This closes #1253. > [http2] adaptor must not call proton functions after pn_raw_connection_close > > > Key: DISPATCH-1977 > URL: https://issues.apache.org/jira/browse/DISPATCH-1977 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Charles E. Rolke >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.17.0 > > > Http2 adaptor code may have the same problem as DISPATCH-1968 TCP adaptor > code. > The rule is never to call pn_raw_connection_wake or > pn_raw_connection_write_buffers after calling pn_raw_connection_close. > The trigger for the failure, at least in the tcp adaptor case, is to close > the server-side connection while the client-side connection is sending to it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1977) [http2] adaptor must not call proton functions after pn_raw_connection_close
[ https://issues.apache.org/jira/browse/DISPATCH-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363188#comment-17363188 ] ASF GitHub Bot commented on DISPATCH-1977: -- asfgit closed pull request #1253: URL: https://github.com/apache/qpid-dispatch/pull/1253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [http2] adaptor must not call proton functions after pn_raw_connection_close > > > Key: DISPATCH-1977 > URL: https://issues.apache.org/jira/browse/DISPATCH-1977 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Charles E. Rolke >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.17.0 > > > Http2 adaptor code may have the same problem as DISPATCH-1968 TCP adaptor > code. > The rule is never to call pn_raw_connection_wake or > pn_raw_connection_write_buffers after calling pn_raw_connection_close. > The trigger for the failure, at least in the tcp adaptor case, is to close > the server-side connection while the client-side connection is sending to it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1253: DISPATCH-1977: Introduced atomics raw_closed_read and raw_closed_writ…
asfgit closed pull request #1253: URL: https://github.com/apache/qpid-dispatch/pull/1253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1977) [http2] adaptor must not call proton functions after pn_raw_connection_close
[ https://issues.apache.org/jira/browse/DISPATCH-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363178#comment-17363178 ] ASF GitHub Bot commented on DISPATCH-1977: -- ganeshmurthy commented on a change in pull request #1253: URL: https://github.com/apache/qpid-dispatch/pull/1253#discussion_r651234648 ## File path: include/qpid/dispatch/atomic.h ## @@ -205,6 +205,9 @@ static inline void sys_atomic_destroy(sys_atomic_t *ref) #endif +#defineSET_ATOMIC_FLAG(flag) sys_atomic_set(flag, 1) Review comment: Introduced a CLEAR_ATOMIC_FLAG macro and the http adaptor now uses it to clear the flags once a new connection to the server is established. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [http2] adaptor must not call proton functions after pn_raw_connection_close > > > Key: DISPATCH-1977 > URL: https://issues.apache.org/jira/browse/DISPATCH-1977 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Charles E. Rolke >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.17.0 > > > Http2 adaptor code may have the same problem as DISPATCH-1968 TCP adaptor > code. > The rule is never to call pn_raw_connection_wake or > pn_raw_connection_write_buffers after calling pn_raw_connection_close. > The trigger for the failure, at least in the tcp adaptor case, is to close > the server-side connection while the client-side connection is sending to it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1977) [http2] adaptor must not call proton functions after pn_raw_connection_close
[
https://issues.apache.org/jira/browse/DISPATCH-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363179#comment-17363179
]
ASF GitHub Bot commented on DISPATCH-1977:
--
ganeshmurthy commented on a change in pull request #1253:
URL: https://github.com/apache/qpid-dispatch/pull/1253#discussion_r651234955
##
File path: src/adaptors/http2/http2_adaptor.c
##
@@ -2426,6 +2436,8 @@ static void handle_connection_event(pn_event_t *e,
qd_server_t *qd_server, void
send_settings_frame(conn);
qd_log(log, QD_LOG_INFO, "[C%"PRIu64"] Accepted Ingress
((PN_RAW_CONNECTION_CONNECTED)) from %s", conn->conn_id, conn->remote_address);
} else {
+sys_atomic_init(&conn->raw_closed_read, 0);
Review comment:
Re-init was wrong. Now uses CLEAR_ATOMIC_FLAG
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [http2] adaptor must not call proton functions after pn_raw_connection_close
>
>
> Key: DISPATCH-1977
> URL: https://issues.apache.org/jira/browse/DISPATCH-1977
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.15.0
>Reporter: Charles E. Rolke
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> Http2 adaptor code may have the same problem as DISPATCH-1968 TCP adaptor
> code.
> The rule is never to call pn_raw_connection_wake or
> pn_raw_connection_write_buffers after calling pn_raw_connection_close.
> The trigger for the failure, at least in the tcp adaptor case, is to close
> the server-side connection while the client-side connection is sending to it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1253: DISPATCH-1977: Introduced atomics raw_closed_read and raw_closed_writ…
ganeshmurthy commented on a change in pull request #1253:
URL: https://github.com/apache/qpid-dispatch/pull/1253#discussion_r651234955
##
File path: src/adaptors/http2/http2_adaptor.c
##
@@ -2426,6 +2436,8 @@ static void handle_connection_event(pn_event_t *e,
qd_server_t *qd_server, void
send_settings_frame(conn);
qd_log(log, QD_LOG_INFO, "[C%"PRIu64"] Accepted Ingress
((PN_RAW_CONNECTION_CONNECTED)) from %s", conn->conn_id, conn->remote_address);
} else {
+sys_atomic_init(&conn->raw_closed_read, 0);
Review comment:
Re-init was wrong. Now uses CLEAR_ATOMIC_FLAG
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1253: DISPATCH-1977: Introduced atomics raw_closed_read and raw_closed_writ…
ganeshmurthy commented on a change in pull request #1253: URL: https://github.com/apache/qpid-dispatch/pull/1253#discussion_r651234648 ## File path: include/qpid/dispatch/atomic.h ## @@ -205,6 +205,9 @@ static inline void sys_atomic_destroy(sys_atomic_t *ref) #endif +#defineSET_ATOMIC_FLAG(flag) sys_atomic_set(flag, 1) Review comment: Introduced a CLEAR_ATOMIC_FLAG macro and the http adaptor now uses it to clear the flags once a new connection to the server is established. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1977) [http2] adaptor must not call proton functions after pn_raw_connection_close
[
https://issues.apache.org/jira/browse/DISPATCH-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363168#comment-17363168
]
ASF GitHub Bot commented on DISPATCH-1977:
--
kgiusti commented on a change in pull request #1253:
URL: https://github.com/apache/qpid-dispatch/pull/1253#discussion_r651216579
##
File path: src/adaptors/http2/http2_adaptor.c
##
@@ -2426,6 +2436,8 @@ static void handle_connection_event(pn_event_t *e,
qd_server_t *qd_server, void
send_settings_frame(conn);
qd_log(log, QD_LOG_INFO, "[C%"PRIu64"] Accepted Ingress
((PN_RAW_CONNECTION_CONNECTED)) from %s", conn->conn_id, conn->remote_address);
} else {
+sys_atomic_init(&conn->raw_closed_read, 0);
Review comment:
Why re-init? Won't this destroy the existing state?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [http2] adaptor must not call proton functions after pn_raw_connection_close
>
>
> Key: DISPATCH-1977
> URL: https://issues.apache.org/jira/browse/DISPATCH-1977
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.15.0
>Reporter: Charles E. Rolke
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> Http2 adaptor code may have the same problem as DISPATCH-1968 TCP adaptor
> code.
> The rule is never to call pn_raw_connection_wake or
> pn_raw_connection_write_buffers after calling pn_raw_connection_close.
> The trigger for the failure, at least in the tcp adaptor case, is to close
> the server-side connection while the client-side connection is sending to it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1253: DISPATCH-1977: Introduced atomics raw_closed_read and raw_closed_writ…
kgiusti commented on a change in pull request #1253:
URL: https://github.com/apache/qpid-dispatch/pull/1253#discussion_r651216579
##
File path: src/adaptors/http2/http2_adaptor.c
##
@@ -2426,6 +2436,8 @@ static void handle_connection_event(pn_event_t *e,
qd_server_t *qd_server, void
send_settings_frame(conn);
qd_log(log, QD_LOG_INFO, "[C%"PRIu64"] Accepted Ingress
((PN_RAW_CONNECTION_CONNECTED)) from %s", conn->conn_id, conn->remote_address);
} else {
+sys_atomic_init(&conn->raw_closed_read, 0);
Review comment:
Why re-init? Won't this destroy the existing state?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1977) [http2] adaptor must not call proton functions after pn_raw_connection_close
[ https://issues.apache.org/jira/browse/DISPATCH-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363156#comment-17363156 ] ASF GitHub Bot commented on DISPATCH-1977: -- kgiusti commented on a change in pull request #1253: URL: https://github.com/apache/qpid-dispatch/pull/1253#discussion_r651207009 ## File path: include/qpid/dispatch/atomic.h ## @@ -205,6 +205,9 @@ static inline void sys_atomic_destroy(sys_atomic_t *ref) #endif +#defineSET_ATOMIC_FLAG(flag) sys_atomic_set(flag, 1) Review comment: Why not a CLEAR_ATOMIC_FLAG? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [http2] adaptor must not call proton functions after pn_raw_connection_close > > > Key: DISPATCH-1977 > URL: https://issues.apache.org/jira/browse/DISPATCH-1977 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Charles E. Rolke >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.17.0 > > > Http2 adaptor code may have the same problem as DISPATCH-1968 TCP adaptor > code. > The rule is never to call pn_raw_connection_wake or > pn_raw_connection_write_buffers after calling pn_raw_connection_close. > The trigger for the failure, at least in the tcp adaptor case, is to close > the server-side connection while the client-side connection is sending to it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1253: DISPATCH-1977: Introduced atomics raw_closed_read and raw_closed_writ…
kgiusti commented on a change in pull request #1253: URL: https://github.com/apache/qpid-dispatch/pull/1253#discussion_r651207009 ## File path: include/qpid/dispatch/atomic.h ## @@ -205,6 +205,9 @@ static inline void sys_atomic_destroy(sys_atomic_t *ref) #endif +#defineSET_ATOMIC_FLAG(flag) sys_atomic_set(flag, 1) Review comment: Why not a CLEAR_ATOMIC_FLAG? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-2122) Data race on alloc pool descriptor initialization
[ https://issues.apache.org/jira/browse/DISPATCH-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] michael goulish reassigned DISPATCH-2122: - Assignee: michael goulish (was: Ken Giusti) > Data race on alloc pool descriptor initialization > - > > Key: DISPATCH-2122 > URL: https://issues.apache.org/jira/browse/DISPATCH-2122 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.16.0 >Reporter: Ken Giusti >Assignee: michael goulish >Priority: Major > Labels: race-condition, tsan > Fix For: 1.17.0 > > > 65: WARNING: ThreadSanitizer: data race (pid=566240) > 65: Read of size 4 at 0x7f67599ae2c0 by thread T4: > 65: #0 qd_alloc > /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:324 > (libqpid-dispatch.so+0x6a1f2) > 65: #1 new_qd_link_ref_t > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:76 > (libqpid-dispatch.so+0x79ae5) > 65: #2 qdr_node_connect_deliveries > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:67 > (libqpid-dispatch.so+0x121a78) > 65: #3 CORE_link_deliver > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1971 > (libqpid-dispatch.so+0x127f1c) > 65: #4 qdr_link_process_deliveries > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:178 > (libqpid-dispatch.so+0x1045c6) > 65: #5 CORE_link_push > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1920 > (libqpid-dispatch.so+0x127d00) > 65: #6 qdr_connection_process > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:414 > (libqpid-dispatch.so+0xc4bec) > 65: #7 AMQP_writable_conn_handler > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:299 > (libqpid-dispatch.so+0x122d42) > 65: #8 writable_handler > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:395 > (libqpid-dispatch.so+0x7b2e2) > 65: #9 qd_container_handle_event > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:747 > (libqpid-dispatch.so+0x7cfd5) > 65: #10 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 > (libqpid-dispatch.so+0x130537) > 65: #11 thread_run > /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 > (libqpid-dispatch.so+0x13063a) > 65: #12 _thread_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0xad37a) > 65: #13 (libtsan.so.0+0x2d33f) > 65: > 65: Previous write of size 4 at 0x7f67599ae2c0 by thread T2 (mutexes: write > M10): > 65: #0 qd_alloc_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:307 > (libqpid-dispatch.so+0x6a14b) > 65: #1 qd_alloc > /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:325 > (libqpid-dispatch.so+0x6a20b) > 65: #2 new_qd_link_ref_t > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:76 > (libqpid-dispatch.so+0x79ae5) > 65: #3 qdr_node_connect_deliveries > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:67 > (libqpid-dispatch.so+0x121a78) > 65: #4 CORE_link_deliver > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1971 > (libqpid-dispatch.so+0x127f1c) > 65: #5 qdr_link_process_deliveries > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:178 > (libqpid-dispatch.so+0x1045c6) > 65: #6 CORE_link_push > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1920 > (libqpid-dispatch.so+0x127d00) > 65: #7 qdr_connection_process > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:414 > (libqpid-dispatch.so+0xc4bec) > 65: #8 AMQP_writable_conn_handler > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:299 > (libqpid-dispatch.so+0x122d42) > 65: #9 writable_handler > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:395 > (libqpid-dispatch.so+0x7b2e2) > 65: #10 qd_container_handle_event > /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:747 > (libqpid-dispatch.so+0x7cfd5) > 65: #11 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 > (libqpid-dispatch.so+0x130537) > 65: #12 thread_run > /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 > (libqpid-dispatch.so+0x13063a) > 65: #13 _thread_init > /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 > (libqpid-dispatch.so+0xad37a) > 65: #14 (libtsan.so.0+0x2d33f) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2170) system_tests_tcp_adaptor fails with ASAN leak of pn_data_t object
[
https://issues.apache.org/jira/browse/DISPATCH-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2170.
-
Fix Version/s: 1.17.0
Resolution: Fixed
> system_tests_tcp_adaptor fails with ASAN leak of pn_data_t object
> -
>
> Key: DISPATCH-2170
> URL: https://issues.apache.org/jira/browse/DISPATCH-2170
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Protocol Adaptors
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/512858013#L12911
>
> {noformat}
> 71:
> 71:
> 71: =
> 71: ==16660==ERROR: LeakSanitizer: detected memory leaks
> 71:
> 71: Indirect leak of 288 byte(s) in 1 object(s) allocated from:
> 71: #0 0x7f28fa9c3961 in realloc
> (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98961)
> 71: #1 0x7f28f7f1108a in pni_mem_subreallocate
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/memory.c:275
> 71: #2 0x7f28f7f0cdf2 in pni_data_grow.lto_priv.446
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:428
> 71: #3 0x7f28f7f09674 in pni_data_new
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1228
> 71: #4 0x7f28f7f0a11d in pni_data_add
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1518
> 71: #5 0x7f28f7f0a2d6 in pn_data_put_map
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1572
> 71: #6 0x7f28fa0dab52 in qdr_tcp_conn_properties
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:679
> 71: #7 0x7f28fa0dae38 in qdr_tcp_connection_ingress_accept
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:697
> 71: #8 0x7f28fa0db71d in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:773
> 71: #9 0x7f28fa2a3026 in handle_event_with_context
> /home/travis/build/apache/qpid-dispatch/src/server.c:802
> 71: #10 0x7f28fa2a3068 in do_handle_raw_connection_event
> /home/travis/build/apache/qpid-dispatch/src/server.c:808
> 71: #11 0x7f28fa2a64fd in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c:1089
> 71: #12 0x7f28fa2a675e in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1121
> 71: #13 0x7f28fa182e4b in _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> 71: #14 0x7f28f9b406b9 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9)
> 71:
> 71: Indirect leak of 288 byte(s) in 1 object(s) allocated from:
> 71: #0 0x7f28fa9c3961 in realloc
> (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98961)
> 71: #1 0x7f28f7f1108a in pni_mem_subreallocate
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/memory.c:275
> 71: #2 0x7f28f7f0cdf2 in pni_data_grow.lto_priv.446
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:428
> 71: #3 0x7f28f7f09674 in pni_data_new
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1228
> 71: #4 0x7f28f7f0a11d in pni_data_add
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1518
> 71: #5 0x7f28f7f0a2d6 in pn_data_put_map
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1572
> 71: #6 0x7f28fa0dab52 in qdr_tcp_conn_properties
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:679
> 71: #7 0x7f28fa0dae38 in qdr_tcp_connection_ingress_accept
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:697
> 71: #8 0x7f28fa0db71d in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:773
> 71: #9 0x7f28fa2a3026 in handle_event_with_context
> /home/travis/build/apache/qpid-dispatch/src/server.c:802
> 71: #10 0x7f28fa2a3068 in do_handle_raw_connection_event
> /home/travis/build/apache/qpid-dispatch/src/server.c:808
> 71: #11 0x7f28fa2a64fd in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c:1089
> 71: #12 0x7f28fa2a675e in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1121
> 71: #13 0x7f28fa2ac01a in qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1501
> 71: #14 0x401dc0 in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:115
> 71: #15 0x403927 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> 71: #16 0x7f28f8a8282f in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
> 71:
> 71: Indirect leak of 288 byte(s) in 1 object(s) allocated from:
> 71: #0 0x7f28fa9c3961 in r
[jira] [Commented] (DISPATCH-2170) system_tests_tcp_adaptor fails with ASAN leak of pn_data_t object
[
https://issues.apache.org/jira/browse/DISPATCH-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363035#comment-17363035
]
ASF GitHub Bot commented on DISPATCH-2170:
--
asfgit closed pull request #1257:
URL: https://github.com/apache/qpid-dispatch/pull/1257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_tcp_adaptor fails with ASAN leak of pn_data_t object
> -
>
> Key: DISPATCH-2170
> URL: https://issues.apache.org/jira/browse/DISPATCH-2170
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Protocol Adaptors
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/512858013#L12911
>
> {noformat}
> 71:
> 71:
> 71: =
> 71: ==16660==ERROR: LeakSanitizer: detected memory leaks
> 71:
> 71: Indirect leak of 288 byte(s) in 1 object(s) allocated from:
> 71: #0 0x7f28fa9c3961 in realloc
> (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98961)
> 71: #1 0x7f28f7f1108a in pni_mem_subreallocate
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/memory.c:275
> 71: #2 0x7f28f7f0cdf2 in pni_data_grow.lto_priv.446
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:428
> 71: #3 0x7f28f7f09674 in pni_data_new
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1228
> 71: #4 0x7f28f7f0a11d in pni_data_add
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1518
> 71: #5 0x7f28f7f0a2d6 in pn_data_put_map
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1572
> 71: #6 0x7f28fa0dab52 in qdr_tcp_conn_properties
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:679
> 71: #7 0x7f28fa0dae38 in qdr_tcp_connection_ingress_accept
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:697
> 71: #8 0x7f28fa0db71d in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:773
> 71: #9 0x7f28fa2a3026 in handle_event_with_context
> /home/travis/build/apache/qpid-dispatch/src/server.c:802
> 71: #10 0x7f28fa2a3068 in do_handle_raw_connection_event
> /home/travis/build/apache/qpid-dispatch/src/server.c:808
> 71: #11 0x7f28fa2a64fd in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c:1089
> 71: #12 0x7f28fa2a675e in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1121
> 71: #13 0x7f28fa182e4b in _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> 71: #14 0x7f28f9b406b9 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9)
> 71:
> 71: Indirect leak of 288 byte(s) in 1 object(s) allocated from:
> 71: #0 0x7f28fa9c3961 in realloc
> (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98961)
> 71: #1 0x7f28f7f1108a in pni_mem_subreallocate
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/memory.c:275
> 71: #2 0x7f28f7f0cdf2 in pni_data_grow.lto_priv.446
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:428
> 71: #3 0x7f28f7f09674 in pni_data_new
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1228
> 71: #4 0x7f28f7f0a11d in pni_data_add
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1518
> 71: #5 0x7f28f7f0a2d6 in pn_data_put_map
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1572
> 71: #6 0x7f28fa0dab52 in qdr_tcp_conn_properties
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:679
> 71: #7 0x7f28fa0dae38 in qdr_tcp_connection_ingress_accept
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:697
> 71: #8 0x7f28fa0db71d in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:773
> 71: #9 0x7f28fa2a3026 in handle_event_with_context
> /home/travis/build/apache/qpid-dispatch/src/server.c:802
> 71: #10 0x7f28fa2a3068 in do_handle_raw_connection_event
> /home/travis/build/apache/qpid-dispatch/src/server.c:808
> 71: #11 0x7f28fa2a64fd in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c:1089
> 71: #12 0x7f28fa2a675e in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1121
> 71: #13 0x7f28fa2ac01a in qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1501
> 71: #14 0x401dc0 in main_process
> /home/travis/build/apache/qpi
[GitHub] [qpid-dispatch] asfgit closed pull request #1257: DISPATCH-2170: Free the tcp_conn_properties pn_data_t object when fre…
asfgit closed pull request #1257: URL: https://github.com/apache/qpid-dispatch/pull/1257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2170) system_tests_tcp_adaptor fails with ASAN leak of pn_data_t object
[
https://issues.apache.org/jira/browse/DISPATCH-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363034#comment-17363034
]
ASF subversion and git services commented on DISPATCH-2170:
---
Commit cc3a53d21382459baa62b2c9381ee69998a6351b in qpid-dispatch's branch
refs/heads/main from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=cc3a53d ]
DISPATCH-2170: Free the tcp_conn_properties pn_data_t object when freeing the
qdr_tcp_connection_t object. This closes #1257
> system_tests_tcp_adaptor fails with ASAN leak of pn_data_t object
> -
>
> Key: DISPATCH-2170
> URL: https://issues.apache.org/jira/browse/DISPATCH-2170
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Protocol Adaptors
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/512858013#L12911
>
> {noformat}
> 71:
> 71:
> 71: =
> 71: ==16660==ERROR: LeakSanitizer: detected memory leaks
> 71:
> 71: Indirect leak of 288 byte(s) in 1 object(s) allocated from:
> 71: #0 0x7f28fa9c3961 in realloc
> (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98961)
> 71: #1 0x7f28f7f1108a in pni_mem_subreallocate
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/memory.c:275
> 71: #2 0x7f28f7f0cdf2 in pni_data_grow.lto_priv.446
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:428
> 71: #3 0x7f28f7f09674 in pni_data_new
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1228
> 71: #4 0x7f28f7f0a11d in pni_data_add
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1518
> 71: #5 0x7f28f7f0a2d6 in pn_data_put_map
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1572
> 71: #6 0x7f28fa0dab52 in qdr_tcp_conn_properties
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:679
> 71: #7 0x7f28fa0dae38 in qdr_tcp_connection_ingress_accept
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:697
> 71: #8 0x7f28fa0db71d in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:773
> 71: #9 0x7f28fa2a3026 in handle_event_with_context
> /home/travis/build/apache/qpid-dispatch/src/server.c:802
> 71: #10 0x7f28fa2a3068 in do_handle_raw_connection_event
> /home/travis/build/apache/qpid-dispatch/src/server.c:808
> 71: #11 0x7f28fa2a64fd in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c:1089
> 71: #12 0x7f28fa2a675e in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1121
> 71: #13 0x7f28fa182e4b in _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> 71: #14 0x7f28f9b406b9 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9)
> 71:
> 71: Indirect leak of 288 byte(s) in 1 object(s) allocated from:
> 71: #0 0x7f28fa9c3961 in realloc
> (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98961)
> 71: #1 0x7f28f7f1108a in pni_mem_subreallocate
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/memory.c:275
> 71: #2 0x7f28f7f0cdf2 in pni_data_grow.lto_priv.446
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:428
> 71: #3 0x7f28f7f09674 in pni_data_new
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1228
> 71: #4 0x7f28f7f0a11d in pni_data_add
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1518
> 71: #5 0x7f28f7f0a2d6 in pn_data_put_map
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1572
> 71: #6 0x7f28fa0dab52 in qdr_tcp_conn_properties
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:679
> 71: #7 0x7f28fa0dae38 in qdr_tcp_connection_ingress_accept
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:697
> 71: #8 0x7f28fa0db71d in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:773
> 71: #9 0x7f28fa2a3026 in handle_event_with_context
> /home/travis/build/apache/qpid-dispatch/src/server.c:802
> 71: #10 0x7f28fa2a3068 in do_handle_raw_connection_event
> /home/travis/build/apache/qpid-dispatch/src/server.c:808
> 71: #11 0x7f28fa2a64fd in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c:1089
> 71: #12 0x7f28fa2a675e in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1121
> 71: #13 0x7f28fa2ac01a in qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1501
> 71: #14 0x401dc0 in main_process
> /home/travis/build/apache/qpid-dispatch/r
[jira] [Resolved] (DISPATCH-2169) [http2] data race is http2 adaptor in qdr_http_activate
[
https://issues.apache.org/jira/browse/DISPATCH-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2169.
-
Fix Version/s: 1.17.0
Resolution: Fixed
> [http2] data race is http2 adaptor in qdr_http_activate
> ---
>
> Key: DISPATCH-2169
> URL: https://issues.apache.org/jira/browse/DISPATCH-2169
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.17.0
>
>
> {noformat}
> 69: WARNING: ThreadSanitizer: data race (pid=14763)
> 69: Read of size 8 at 0x7b485ea0 by thread T1 (mutexes: write M239):
> 69: #0 qdr_http_activate
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:1632
> (libqpid-dispatch.so+0xf6007)
> 69: #1 qdr_activate_connections_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:89
> (libqpid-dispatch.so+0xcab64)
> 69: #2 router_core_thread
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:247
> (libqpid-dispatch.so+0xcab64)
> 69: #3 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (libqpid-dispatch.so+0x97156)
> 69: #4 (libtsan.so.0+0x2d1af)
> 69:
> 69: Previous write of size 8 at 0x7b485ea0 by thread T4:
> 69: #0 http_connector_establish
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:1655
> (libqpid-dispatch.so+0xf69b6)
> 69: #1 egress_conn_timer_handler
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2314
> (libqpid-dispatch.so+0xf69b6)
> 69: #2 egress_conn_timer_handler
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2303
> (libqpid-dispatch.so+0xf69b6)
> 69: #3 qd_timer_visit
> /home/travis/build/apache/qpid-dispatch/src/timer.c:317
> (libqpid-dispatch.so+0xf25b2)
> 69: #4 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1006
> (libqpid-dispatch.so+0xed50e)
> 69: #5 thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1121
> (libqpid-dispatch.so+0xf0e67)
> 69: #6 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (libqpid-dispatch.so+0x97156)
> 69: #7 (libtsan.so.0+0x2d1af)
> 69:
> 69: Location is heap block of size 384 at 0x7b485e80 allocated by main
> thread:
> 69: #0 posix_memalign (libtsan.so.0+0x3048d)
> 69: #1 qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396
> (libqpid-dispatch.so+0x61584)
> 69: #2 new_qdr_http2_connection_t
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:52
> (libqpid-dispatch.so+0xf8f25)
> 69: #3 qdr_http_connection_egress
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2353
> (libqpid-dispatch.so+0x101905)
> 69: #4 qd_http2_configure_connector
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2632
> (libqpid-dispatch.so+0x102a1c)
> 69: #5 qd_dispatch_configure_http_connector
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http_common.c:172
> (libqpid-dispatch.so+0x4003d)
> 69: #6 (libffi.so.7+0x6ff4)
> 69: #7 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:97
> (qdrouterd+0x2bb2)
> 69: #8 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2882)
> 69:
> 69: Mutex M239 (0x7b100940) created at:
> 69: #0 pthread_mutex_init (libtsan.so.0+0x4a636)
> 69: #1 sys_mutex
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:43
> (libqpid-dispatch.so+0x971bf)
> 69: #2 qd_server
> /home/travis/build/apache/qpid-dispatch/src/server.c:1358
> (libqpid-dispatch.so+0xef05f)
> 69: #3 qd_dispatch_prepare
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:333
> (libqpid-dispatch.so+0x77f3a)
> 69: #4 (libffi.so.7+0x6ff4)
> 69: #5 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:97
> (qdrouterd+0x2bb2)
> 69: #6 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2882)
> 69:
> 69: Thread T1 (tid=14765, running) created by main thread at:
> 69: #0 pthread_create (libtsan.so.0+0x5ea99)
> 69: #1 sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181
> (libqpid-dispatch.so+0x97712)
> 69: #2 qdr_core
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:124
> (libqpid-dispatch.so+0xc4e1e)
> 69: #3 qd_router_setup_late
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2122
> (libqpid-dispatch.so+0xe89ec)
> 69: #4 (libffi.so.7+0x6
[jira] [Commented] (DISPATCH-2169) [http2] data race is http2 adaptor in qdr_http_activate
[
https://issues.apache.org/jira/browse/DISPATCH-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363011#comment-17363011
]
ASF GitHub Bot commented on DISPATCH-2169:
--
asfgit closed pull request #1256:
URL: https://github.com/apache/qpid-dispatch/pull/1256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [http2] data race is http2 adaptor in qdr_http_activate
> ---
>
> Key: DISPATCH-2169
> URL: https://issues.apache.org/jira/browse/DISPATCH-2169
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 69: WARNING: ThreadSanitizer: data race (pid=14763)
> 69: Read of size 8 at 0x7b485ea0 by thread T1 (mutexes: write M239):
> 69: #0 qdr_http_activate
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:1632
> (libqpid-dispatch.so+0xf6007)
> 69: #1 qdr_activate_connections_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:89
> (libqpid-dispatch.so+0xcab64)
> 69: #2 router_core_thread
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:247
> (libqpid-dispatch.so+0xcab64)
> 69: #3 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (libqpid-dispatch.so+0x97156)
> 69: #4 (libtsan.so.0+0x2d1af)
> 69:
> 69: Previous write of size 8 at 0x7b485ea0 by thread T4:
> 69: #0 http_connector_establish
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:1655
> (libqpid-dispatch.so+0xf69b6)
> 69: #1 egress_conn_timer_handler
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2314
> (libqpid-dispatch.so+0xf69b6)
> 69: #2 egress_conn_timer_handler
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2303
> (libqpid-dispatch.so+0xf69b6)
> 69: #3 qd_timer_visit
> /home/travis/build/apache/qpid-dispatch/src/timer.c:317
> (libqpid-dispatch.so+0xf25b2)
> 69: #4 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1006
> (libqpid-dispatch.so+0xed50e)
> 69: #5 thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1121
> (libqpid-dispatch.so+0xf0e67)
> 69: #6 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (libqpid-dispatch.so+0x97156)
> 69: #7 (libtsan.so.0+0x2d1af)
> 69:
> 69: Location is heap block of size 384 at 0x7b485e80 allocated by main
> thread:
> 69: #0 posix_memalign (libtsan.so.0+0x3048d)
> 69: #1 qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396
> (libqpid-dispatch.so+0x61584)
> 69: #2 new_qdr_http2_connection_t
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:52
> (libqpid-dispatch.so+0xf8f25)
> 69: #3 qdr_http_connection_egress
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2353
> (libqpid-dispatch.so+0x101905)
> 69: #4 qd_http2_configure_connector
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2632
> (libqpid-dispatch.so+0x102a1c)
> 69: #5 qd_dispatch_configure_http_connector
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http_common.c:172
> (libqpid-dispatch.so+0x4003d)
> 69: #6 (libffi.so.7+0x6ff4)
> 69: #7 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:97
> (qdrouterd+0x2bb2)
> 69: #8 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2882)
> 69:
> 69: Mutex M239 (0x7b100940) created at:
> 69: #0 pthread_mutex_init (libtsan.so.0+0x4a636)
> 69: #1 sys_mutex
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:43
> (libqpid-dispatch.so+0x971bf)
> 69: #2 qd_server
> /home/travis/build/apache/qpid-dispatch/src/server.c:1358
> (libqpid-dispatch.so+0xef05f)
> 69: #3 qd_dispatch_prepare
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:333
> (libqpid-dispatch.so+0x77f3a)
> 69: #4 (libffi.so.7+0x6ff4)
> 69: #5 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:97
> (qdrouterd+0x2bb2)
> 69: #6 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2882)
> 69:
> 69: Thread T1 (tid=14765, running) created by main thread at:
> 69: #0 pthread_create (libtsan.so.0+0x5ea99)
> 69: #1 sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181
[jira] [Resolved] (DISPATCH-2097) [console] GUI displays many connections to pseudo-host egress-dispatch
[ https://issues.apache.org/jira/browse/DISPATCH-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen resolved DISPATCH-2097. Resolution: Fixed - Reproduced problem with attached zip files. - Applied [~chug]'s fix. - Modified console to ignore connections with 'qd.adaptor' defined - Built and restarted routers - The problem no longer happens. > [console] GUI displays many connections to pseudo-host egress-dispatch > -- > > Key: DISPATCH-2097 > URL: https://issues.apache.org/jira/browse/DISPATCH-2097 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console, Protocol Adaptors >Reporter: Charles E. Rolke >Assignee: Ernest Allen >Priority: Major > Fix For: 1.17.0 > > Attachments: D-2097.zip, DISPATCH-2097_Screenshot.png > > > In a network of 12 routers each router has a TCP Listener and Connector > defined. There are no TCP adaptor connections in progress. > The GUI topology page shows a green receiver host named _egress-dispatch_. > Every router has a line drawn to this host. That's 12 lines going to the same > little circle and its seriously confuses the topology page. > The egress-dispatch host and connections to it are purely for housekeeping > purposes and are not involved in any activity that in important enough to be > shown on the main page as it is. > This host and connections to it should be hidden. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2169) [http2] data race is http2 adaptor in qdr_http_activate
[
https://issues.apache.org/jira/browse/DISPATCH-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363009#comment-17363009
]
ASF subversion and git services commented on DISPATCH-2169:
---
Commit b7b841e24ff660a38cfd4cd497e269bc061bd155 in qpid-dispatch's branch
refs/heads/main from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=b7b841e ]
DISPATCH-2169: Added lock protection around call to creating a new
pn_raw_connection(). This closes #1256
> [http2] data race is http2 adaptor in qdr_http_activate
> ---
>
> Key: DISPATCH-2169
> URL: https://issues.apache.org/jira/browse/DISPATCH-2169
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 69: WARNING: ThreadSanitizer: data race (pid=14763)
> 69: Read of size 8 at 0x7b485ea0 by thread T1 (mutexes: write M239):
> 69: #0 qdr_http_activate
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:1632
> (libqpid-dispatch.so+0xf6007)
> 69: #1 qdr_activate_connections_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:89
> (libqpid-dispatch.so+0xcab64)
> 69: #2 router_core_thread
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:247
> (libqpid-dispatch.so+0xcab64)
> 69: #3 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (libqpid-dispatch.so+0x97156)
> 69: #4 (libtsan.so.0+0x2d1af)
> 69:
> 69: Previous write of size 8 at 0x7b485ea0 by thread T4:
> 69: #0 http_connector_establish
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:1655
> (libqpid-dispatch.so+0xf69b6)
> 69: #1 egress_conn_timer_handler
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2314
> (libqpid-dispatch.so+0xf69b6)
> 69: #2 egress_conn_timer_handler
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2303
> (libqpid-dispatch.so+0xf69b6)
> 69: #3 qd_timer_visit
> /home/travis/build/apache/qpid-dispatch/src/timer.c:317
> (libqpid-dispatch.so+0xf25b2)
> 69: #4 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1006
> (libqpid-dispatch.so+0xed50e)
> 69: #5 thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1121
> (libqpid-dispatch.so+0xf0e67)
> 69: #6 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (libqpid-dispatch.so+0x97156)
> 69: #7 (libtsan.so.0+0x2d1af)
> 69:
> 69: Location is heap block of size 384 at 0x7b485e80 allocated by main
> thread:
> 69: #0 posix_memalign (libtsan.so.0+0x3048d)
> 69: #1 qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396
> (libqpid-dispatch.so+0x61584)
> 69: #2 new_qdr_http2_connection_t
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:52
> (libqpid-dispatch.so+0xf8f25)
> 69: #3 qdr_http_connection_egress
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2353
> (libqpid-dispatch.so+0x101905)
> 69: #4 qd_http2_configure_connector
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2632
> (libqpid-dispatch.so+0x102a1c)
> 69: #5 qd_dispatch_configure_http_connector
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http_common.c:172
> (libqpid-dispatch.so+0x4003d)
> 69: #6 (libffi.so.7+0x6ff4)
> 69: #7 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:97
> (qdrouterd+0x2bb2)
> 69: #8 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2882)
> 69:
> 69: Mutex M239 (0x7b100940) created at:
> 69: #0 pthread_mutex_init (libtsan.so.0+0x4a636)
> 69: #1 sys_mutex
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:43
> (libqpid-dispatch.so+0x971bf)
> 69: #2 qd_server
> /home/travis/build/apache/qpid-dispatch/src/server.c:1358
> (libqpid-dispatch.so+0xef05f)
> 69: #3 qd_dispatch_prepare
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:333
> (libqpid-dispatch.so+0x77f3a)
> 69: #4 (libffi.so.7+0x6ff4)
> 69: #5 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:97
> (qdrouterd+0x2bb2)
> 69: #6 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2882)
> 69:
> 69: Thread T1 (tid=14765, running) created by main thread at:
> 69: #0 pthread_create (libtsan.so.0+0x5ea99)
> 69: #1 sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181
> (libqpid-dispatch.so+0x97712
[GitHub] [qpid-dispatch] asfgit closed pull request #1256: DISPATCH-2169: Added lock protection around call to creating a new pn…
asfgit closed pull request #1256: URL: https://github.com/apache/qpid-dispatch/pull/1256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2097) [console] GUI displays many connections to pseudo-host egress-dispatch
[ https://issues.apache.org/jira/browse/DISPATCH-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363003#comment-17363003 ] ASF subversion and git services commented on DISPATCH-2097: --- Commit d5889bc3d1ba0f7c7db82d29dea49a931d072c0d in qpid-dispatch's branch refs/heads/main from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=d5889bc ] DISPATCH-2097: Console ignores connections with property 'qd.adaptor' defined. > [console] GUI displays many connections to pseudo-host egress-dispatch > -- > > Key: DISPATCH-2097 > URL: https://issues.apache.org/jira/browse/DISPATCH-2097 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console, Protocol Adaptors >Reporter: Charles E. Rolke >Assignee: Ernest Allen >Priority: Major > Fix For: 1.17.0 > > Attachments: D-2097.zip, DISPATCH-2097_Screenshot.png > > > In a network of 12 routers each router has a TCP Listener and Connector > defined. There are no TCP adaptor connections in progress. > The GUI topology page shows a green receiver host named _egress-dispatch_. > Every router has a line drawn to this host. That's 12 lines going to the same > little circle and its seriously confuses the topology page. > The egress-dispatch host and connections to it are purely for housekeeping > purposes and are not involved in any activity that in important enough to be > shown on the main page as it is. > This host and connections to it should be hidden. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2171) [http2] The activation lock held for too long in handle_disconnected
Ganesh Murthy created DISPATCH-2171: --- Summary: [http2] The activation lock held for too long in handle_disconnected Key: DISPATCH-2171 URL: https://issues.apache.org/jira/browse/DISPATCH-2171 Project: Qpid Dispatch Issue Type: Improvement Components: Protocol Adaptors Affects Versions: 1.16.0 Reporter: Ganesh Murthy Assignee: Ganesh Murthy The activation lock needs to held when doing two things # When the conn->pn_raw_conn is cleared # When the context on the qdr_connection is cleared. Refactor this function to hold the lock only when doing the above two steps. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] Dedeepya-T opened a new pull request #92: QPID-8523:[Broker-J] set initital delivery count on attach
Dedeepya-T opened a new pull request #92: URL: https://github.com/apache/qpid-broker-j/pull/92 Set initial delivery count to zero -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8523) [Broker-J] refusing-attach while rejecting consumer does not set required initial-delivery-count field
[
https://issues.apache.org/jira/browse/QPID-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362949#comment-17362949
]
ASF GitHub Bot commented on QPID-8523:
--
Dedeepya-T opened a new pull request #92:
URL: https://github.com/apache/qpid-broker-j/pull/92
Set initial delivery count to zero
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Broker-J] refusing-attach while rejecting consumer does not set required
> initial-delivery-count field
> --
>
> Key: QPID-8523
> URL: https://issues.apache.org/jira/browse/QPID-8523
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.4
>Reporter: Robbie Gemmell
>Priority: Major
>
> Attempting to create a consumer link from e.g. a non-existing address results
> in refusal of the link, which in case of a consumer is done by sending a
> 'response' attach with null source to indicate the terminus wasnt created,
> followed by a detach with the error.
> The broker does send an attach without a source, but it omits the
> initialDeliveryCount value from the attach, which the spec says is required
> when role=SENDER ("This MUST NOT be null if role is sender, and it is ignored
> if the role is receiver."). Protocol libraries validating such required
> values will run afoul of this, leading to decode error that can bring the
> connection down unnecessarily.
> From looking at the wire encoding, it appears only the first 3 fields (name,
> handle, role) of the attach are being set, with the rest unpopulated and thus
> being equivalent to null or any default they may have.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] gemmellr commented on a change in pull request #319: [WIP] Add the OpenTelemetry cpp library dependency.
gemmellr commented on a change in pull request #319: URL: https://github.com/apache/qpid-proton/pull/319#discussion_r650868825 ## File path: cpp/CMakeLists.txt ## @@ -37,7 +37,7 @@ else() endif() # Check for OPENTELEMETRY-CPP for distributed tracing -find_package(opentelemetry-cpp) +find_package(opentelemetry-cpp CONFIG REQUIRED) Review comment: I'll need to defer to the folks with cmake experience at this point to suggest on the specific approach, I dont actually know myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #319: [WIP] Add the OpenTelemetry cpp library dependency.
DreamPearl commented on a change in pull request #319: URL: https://github.com/apache/qpid-proton/pull/319#discussion_r650862845 ## File path: cpp/CMakeLists.txt ## @@ -37,7 +37,7 @@ else() endif() # Check for OPENTELEMETRY-CPP for distributed tracing -find_package(opentelemetry-cpp) +find_package(opentelemetry-cpp CONFIG REQUIRED) Review comment: Done! I've deleted the `REQUIRED`. But this time I've changed the `cmake_dependent_option` to `option`. `option` will also work right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] gemmellr commented on a change in pull request #319: [WIP] Add the OpenTelemetry cpp library dependency.
gemmellr commented on a change in pull request #319: URL: https://github.com/apache/qpid-proton/pull/319#discussion_r650861029 ## File path: cpp/CMakeLists.txt ## @@ -37,7 +37,7 @@ else() endif() # Check for OPENTELEMETRY-CPP for distributed tracing -find_package(opentelemetry-cpp) +find_package(opentelemetry-cpp CONFIG REQUIRED) Review comment: Yep, I noted that it mostly seemed optional already apart from the find. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on a change in pull request #319: [WIP] Add the OpenTelemetry cpp library dependency.
jiridanek commented on a change in pull request #319: URL: https://github.com/apache/qpid-proton/pull/319#discussion_r650856478 ## File path: cpp/CMakeLists.txt ## @@ -37,7 +37,7 @@ else() endif() # Check for OPENTELEMETRY-CPP for distributed tracing -find_package(opentelemetry-cpp) +find_package(opentelemetry-cpp CONFIG REQUIRED) Review comment: should be enough to delete the `REQUIRED`. There already is the `cmake_dependent_option` thing for this, for dealing with the optionality below in the file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] gemmellr commented on a change in pull request #319: [WIP] Add the OpenTelemetry cpp library dependency.
gemmellr commented on a change in pull request #319: URL: https://github.com/apache/qpid-proton/pull/319#discussion_r650848950 ## File path: cpp/CMakeLists.txt ## @@ -37,7 +37,7 @@ else() endif() # Check for OPENTELEMETRY-CPP for distributed tracing -find_package(opentelemetry-cpp) +find_package(opentelemetry-cpp CONFIG REQUIRED) Review comment: I would doubt it generally, but especially since its not yet even in a released state. I had suggested on IRC shortly before your comment the next step would be to make it optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on a change in pull request #319: [WIP] Add the OpenTelemetry cpp library dependency.
jiridanek commented on a change in pull request #319: URL: https://github.com/apache/qpid-proton/pull/319#discussion_r650846438 ## File path: cpp/CMakeLists.txt ## @@ -37,7 +37,7 @@ else() endif() # Check for OPENTELEMETRY-CPP for distributed tracing -find_package(opentelemetry-cpp) +find_package(opentelemetry-cpp CONFIG REQUIRED) Review comment: Is it going to be `REQUIRED`? I am all for it (less possible build configurations), but I imagine some users might want to build Proton without opentelemtry cpp. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8535) [Broker-J] Add a switch to ignore SNI host errors
[ https://issues.apache.org/jira/browse/QPID-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362806#comment-17362806 ] ASF GitHub Bot commented on QPID-8535: -- asfgit closed pull request #91: URL: https://github.com/apache/qpid-broker-j/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Broker-J] Add a switch to ignore SNI host errors > - > > Key: QPID-8535 > URL: https://issues.apache.org/jira/browse/QPID-8535 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-8.0.3 >Reporter: Dedeepya >Priority: Major > Fix For: qpid-java-broker-8.0.5 > > > While qpid proton client connects using TLS to broker, it sets the virtual > host name as SNI in the header during the SSL handshake. When VH name > contains an underscore, broker fails to create SNI name as it considers > underscore as an invalid character, as a result SSL handshake failure occurs. > Adding a switch to bypass SNIhostname errors and proceed with SSL handshake > would allow the client to continue broker with SSL handshake even when SNI is > incorrect -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] asfgit closed pull request #91: QPID-8535:[Broker-J]Add flag to ignore invlaid SNI header
asfgit closed pull request #91: URL: https://github.com/apache/qpid-broker-j/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8530) [Broker-J] Duplicated functionality of the Selector::wakeup method in SelectorThread
[
https://issues.apache.org/jira/browse/QPID-8530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362802#comment-17362802
]
ASF GitHub Bot commented on QPID-8530:
--
asfgit closed pull request #90:
URL: https://github.com/apache/qpid-broker-j/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Broker-J] Duplicated functionality of the Selector::wakeup method in
> SelectorThread
>
>
> Key: QPID-8530
> URL: https://issues.apache.org/jira/browse/QPID-8530
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Reporter: Marek Laca
>Priority: Minor
> Labels: Broker, Java, Thread, selector
>
> It is stated in Java documentation of the
> [Selector::wakeup|https://docs.oracle.com/javase/7/docs/api/java/nio/channels/Selector.html#wakeup()]
> method that:
> {code:none}
> Causes the first selection operation that has not yet returned to return
> immediately.
> If another thread is currently blocked in an invocation of the select() or
> select(long) methods then that invocation will return immediately. If no
> selection operation is currently in progress then the next invocation of one
> of these methods will return immediately unless the selectNow() method is
> invoked in the meantime. In any case the value returned by that invocation
> may be non-zero. Subsequent invocations of the select() or select(long)
> methods will block as usual unless this method is invoked again in the
> meantime.
> Invoking this method more than once between two successive selection
> operations has the same effect as invoking it just once.
> {code}
> SelectorThread.SelectionTask inner class in Java broker duplicates build in
> functionality of the Selector::wakeup method, what complicates the
> implementation. If the class attributes '_inSelect' and '_wakeups' were
> removed then the code of SelectorThread.SelectionTask class would be
> simplified. The wakeup method could be directly executed, there is no need
> for another checks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] asfgit closed pull request #90: QPID-8530: [Broker-J] Duplicated functionality of the Selector::wakeup method in SelectorThread
asfgit closed pull request #90: URL: https://github.com/apache/qpid-broker-j/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8484) [Broker-J] Reimplementation of the limit number of connections per user
[
https://issues.apache.org/jira/browse/QPID-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362788#comment-17362788
]
ASF GitHub Bot commented on QPID-8484:
--
mklaca commented on a change in pull request #76:
URL: https://github.com/apache/qpid-broker-j/pull/76#discussion_r649950920
##
File path:
broker-core/src/main/java/org/apache/qpid/server/model/NamedAddressSpace.java
##
@@ -48,8 +49,13 @@
boolean registerConnection(AMQPConnection connection,
final ConnectionEstablishmentPolicy
connectionEstablishmentPolicy);
+
void deregisterConnection(AMQPConnection connection);
+default ConnectionSlot requestConnectionSlot(AMQPConnection connection)
Review comment:
ConnectionSlot is a crucial part of the solution, see my last comment.
##
File path:
broker-core/src/main/java/org/apache/qpid/server/security/limit/ConnectionSlot.java
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.qpid.server.security.limit;
+
+import java.util.Optional;
+
+@FunctionalInterface
+public interface ConnectionSlot extends Runnable
Review comment:
ConnectionSlot is a crucial part of the solution, it can be used as
delete task.
##
File path:
broker-core/src/main/java/org/apache/qpid/server/security/limit/ConnectionLimiter.java
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.qpid.server.security.limit;
+
+import java.util.Optional;
+
+import org.apache.qpid.server.security.limit.ConnectionSlot.FreeSlot;
+import org.apache.qpid.server.transport.AMQPConnection;
+
+public interface ConnectionLimiter
+{
+ConnectionSlot register(AMQPConnection connection);
+
+ConnectionLimiter append(ConnectionLimiter limiter);
+
+static CachedLimiter noLimits()
+{
+return NoLimits.INSTANCE;
+}
+
+static CachedLimiter blockEveryone()
+{
+return BlockEveryone.INSTANCE;
+}
+
+static CachedLimiter cacheConnectionRegistration(ConnectionLimiter
limiter) {
+if (limiter instanceof CachedLimiter) {
+return (CachedLimiter) limiter;
+}
+return new CachedConnectionLimiterImpl(limiter);
+}
+
+interface CachedLimiter extends ConnectionLimiter
+{
+ConnectionLimiter underlyingLimiter();
+
+@Override
+default ConnectionLimiter append(ConnectionLimiter limiter) {
+return underlyingLimiter().append(limiter);
+}
+}
+
+final class NoLimits implements CachedLimiter
Review comment:
Because NoLimits is a CachedLimiter.
##
File path:
broker-core/src/main/java/org/apache/qpid/server/security/limit/ConnectionLimiter.java
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * soft
[GitHub] [qpid-broker-j] mklaca commented on a change in pull request #76: QPID-8484: [Broker-J] Reimplementation of the limit number of connections per user
mklaca commented on a change in pull request #76:
URL: https://github.com/apache/qpid-broker-j/pull/76#discussion_r649950920
##
File path:
broker-core/src/main/java/org/apache/qpid/server/model/NamedAddressSpace.java
##
@@ -48,8 +49,13 @@
boolean registerConnection(AMQPConnection connection,
final ConnectionEstablishmentPolicy
connectionEstablishmentPolicy);
+
void deregisterConnection(AMQPConnection connection);
+default ConnectionSlot requestConnectionSlot(AMQPConnection connection)
Review comment:
ConnectionSlot is a crucial part of the solution, see my last comment.
##
File path:
broker-core/src/main/java/org/apache/qpid/server/security/limit/ConnectionSlot.java
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.qpid.server.security.limit;
+
+import java.util.Optional;
+
+@FunctionalInterface
+public interface ConnectionSlot extends Runnable
Review comment:
ConnectionSlot is a crucial part of the solution, it can be used as
delete task.
##
File path:
broker-core/src/main/java/org/apache/qpid/server/security/limit/ConnectionLimiter.java
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.qpid.server.security.limit;
+
+import java.util.Optional;
+
+import org.apache.qpid.server.security.limit.ConnectionSlot.FreeSlot;
+import org.apache.qpid.server.transport.AMQPConnection;
+
+public interface ConnectionLimiter
+{
+ConnectionSlot register(AMQPConnection connection);
+
+ConnectionLimiter append(ConnectionLimiter limiter);
+
+static CachedLimiter noLimits()
+{
+return NoLimits.INSTANCE;
+}
+
+static CachedLimiter blockEveryone()
+{
+return BlockEveryone.INSTANCE;
+}
+
+static CachedLimiter cacheConnectionRegistration(ConnectionLimiter
limiter) {
+if (limiter instanceof CachedLimiter) {
+return (CachedLimiter) limiter;
+}
+return new CachedConnectionLimiterImpl(limiter);
+}
+
+interface CachedLimiter extends ConnectionLimiter
+{
+ConnectionLimiter underlyingLimiter();
+
+@Override
+default ConnectionLimiter append(ConnectionLimiter limiter) {
+return underlyingLimiter().append(limiter);
+}
+}
+
+final class NoLimits implements CachedLimiter
Review comment:
Because NoLimits is a CachedLimiter.
##
File path:
broker-core/src/main/java/org/apache/qpid/server/security/limit/ConnectionLimiter.java
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the L
[jira] [Commented] (DISPATCH-2170) system_tests_tcp_adaptor fails with ASAN leak of pn_data_t object
[
https://issues.apache.org/jira/browse/DISPATCH-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362776#comment-17362776
]
ASF GitHub Bot commented on DISPATCH-2170:
--
ganeshmurthy opened a new pull request #1257:
URL: https://github.com/apache/qpid-dispatch/pull/1257
…eing the qdr_tcp_connection_t object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_tcp_adaptor fails with ASAN leak of pn_data_t object
> -
>
> Key: DISPATCH-2170
> URL: https://issues.apache.org/jira/browse/DISPATCH-2170
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Protocol Adaptors
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/512858013#L12911
>
> {noformat}
> 71:
> 71:
> 71: =
> 71: ==16660==ERROR: LeakSanitizer: detected memory leaks
> 71:
> 71: Indirect leak of 288 byte(s) in 1 object(s) allocated from:
> 71: #0 0x7f28fa9c3961 in realloc
> (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98961)
> 71: #1 0x7f28f7f1108a in pni_mem_subreallocate
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/memory.c:275
> 71: #2 0x7f28f7f0cdf2 in pni_data_grow.lto_priv.446
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:428
> 71: #3 0x7f28f7f09674 in pni_data_new
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1228
> 71: #4 0x7f28f7f0a11d in pni_data_add
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1518
> 71: #5 0x7f28f7f0a2d6 in pn_data_put_map
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1572
> 71: #6 0x7f28fa0dab52 in qdr_tcp_conn_properties
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:679
> 71: #7 0x7f28fa0dae38 in qdr_tcp_connection_ingress_accept
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:697
> 71: #8 0x7f28fa0db71d in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:773
> 71: #9 0x7f28fa2a3026 in handle_event_with_context
> /home/travis/build/apache/qpid-dispatch/src/server.c:802
> 71: #10 0x7f28fa2a3068 in do_handle_raw_connection_event
> /home/travis/build/apache/qpid-dispatch/src/server.c:808
> 71: #11 0x7f28fa2a64fd in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c:1089
> 71: #12 0x7f28fa2a675e in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1121
> 71: #13 0x7f28fa182e4b in _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> 71: #14 0x7f28f9b406b9 in start_thread
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9)
> 71:
> 71: Indirect leak of 288 byte(s) in 1 object(s) allocated from:
> 71: #0 0x7f28fa9c3961 in realloc
> (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98961)
> 71: #1 0x7f28f7f1108a in pni_mem_subreallocate
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/memory.c:275
> 71: #2 0x7f28f7f0cdf2 in pni_data_grow.lto_priv.446
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:428
> 71: #3 0x7f28f7f09674 in pni_data_new
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1228
> 71: #4 0x7f28f7f0a11d in pni_data_add
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1518
> 71: #5 0x7f28f7f0a2d6 in pn_data_put_map
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/core/codec.c:1572
> 71: #6 0x7f28fa0dab52 in qdr_tcp_conn_properties
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:679
> 71: #7 0x7f28fa0dae38 in qdr_tcp_connection_ingress_accept
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:697
> 71: #8 0x7f28fa0db71d in handle_connection_event
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:773
> 71: #9 0x7f28fa2a3026 in handle_event_with_context
> /home/travis/build/apache/qpid-dispatch/src/server.c:802
> 71: #10 0x7f28fa2a3068 in do_handle_raw_connection_event
> /home/travis/build/apache/qpid-dispatch/src/server.c:808
> 71: #11 0x7f28fa2a64fd in handle
> /home/travis/build/apache/qpid-dispatch/src/server.c:1089
> 71: #12 0x7f28fa2a675e in thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1121
> 71: #13 0x7f28fa2ac01a in qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1501
> 71: #14 0x401dc0
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1257: DISPATCH-2170: Free the tcp_conn_properties pn_data_t object when fre…
ganeshmurthy opened a new pull request #1257: URL: https://github.com/apache/qpid-dispatch/pull/1257 …eing the qdr_tcp_connection_t object -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1255: DISPATCH-1797: Added a retry to qdmanage to make sure we give enough …
asfgit closed pull request #1255: URL: https://github.com/apache/qpid-dispatch/pull/1255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1797) test_yy_query_many_links fails in system_tests_qdmanage
[
https://issues.apache.org/jira/browse/DISPATCH-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362754#comment-17362754
]
ASF GitHub Bot commented on DISPATCH-1797:
--
asfgit closed pull request #1255:
URL: https://github.com/apache/qpid-dispatch/pull/1255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> test_yy_query_many_links fails in system_tests_qdmanage
> ---
>
> Key: DISPATCH-1797
> URL: https://issues.apache.org/jira/browse/DISPATCH-1797
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.14.0, 1.17.0
> Environment: rhel 6
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.16.0
>
>
> Failure on rhel 6
>
> {noformat}
> ==
> FAIL: test_yy_query_many_links (system_tests_qdmanage.QdmanageTest)
> --
> Traceback (most recent call last):
> File "/opt/qpid-dispatch-src/tests/system_tests_qdmanage.py", line 575, in
> test_yy_query_many_links
> self.assertEqual(out_links, COUNT)
> AssertionError: 4998 !=
> 5000--
> Ran 34 tests in 159.088sFAILED (failures=1) {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2170) system_tests_tcp_adaptor fails with ASAN leak of pn_data_t object
[ https://issues.apache.org/jira/browse/DISPATCH-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362745#comment-17362745 ] ASF GitHub Bot commented on DISPATCH-2170: -- codecov-commenter commented on pull request #1257: URL: https://github.com/apache/qpid-dispatch/pull/1257#issuecomment-859650551 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1257?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1257](https://codecov.io/gh/apache/qpid-dispatch/pull/1257?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (52b8e61) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/0c2a5d9c2b0e6b716912101465cb661590d433b6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0c2a5d9) will **increase** coverage by `0.03%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1257 +/- ## == + Coverage 84.66% 84.69% +0.03% == Files 113 113 Lines 2805928065 +6 == + Hits2375623771 +15 + Misses 4303 4294 -9 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `76.53% <100.00%> (+0.16%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `92.64% <0.00%> (-0.40%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.53% <0.00%> (-0.22%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.18% <0.00%> (-0.15%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.83% <0.00%> (+0.09%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.57% <0.00%> (+0.09%)` | :arrow_up: | | [src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=) | `85.15% <0.00%> (+0.12%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.51% <0.00%> (+0.18%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1257: DISPATCH-2170: Free the tcp_conn_properties pn_data_t object when fre…
codecov-commenter commented on pull request #1257: URL: https://github.com/apache/qpid-dispatch/pull/1257#issuecomment-859650551 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1257?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1257](https://codecov.io/gh/apache/qpid-dispatch/pull/1257?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (52b8e61) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/0c2a5d9c2b0e6b716912101465cb661590d433b6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0c2a5d9) will **increase** coverage by `0.03%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1257 +/- ## == + Coverage 84.66% 84.69% +0.03% == Files 113 113 Lines 2805928065 +6 == + Hits2375623771 +15 + Misses 4303 4294 -9 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `76.53% <100.00%> (+0.16%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `92.64% <0.00%> (-0.40%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.53% <0.00%> (-0.22%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.18% <0.00%> (-0.15%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.83% <0.00%> (+0.09%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.57% <0.00%> (+0.09%)` | :arrow_up: | | [src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=) | `85.15% <0.00%> (+0.12%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.51% <0.00%> (+0.18%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `84.86% <0.00%> (+0.29%)` | :arrow_up: | | [src/router\_core/router\
