[jira] [Resolved] (PROTON-2454) Singular body section not always cleared when bulk adding multiple sections

[Timothy A. Bish (Jira)]

 [ 
https://issues.apache.org/jira/browse/PROTON-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy A. Bish resolved PROTON-2454.
-
Resolution: Fixed

> Singular body section not always cleared when bulk adding multiple sections
> ---
>
> Key: PROTON-2454
> URL: https://issues.apache.org/jira/browse/PROTON-2454
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: protonj2
>Affects Versions: protonj2-1.0.0-M3
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Minor
> Fix For: protonj2-1.0.0-M4
>
>
> When assigning a collection of body section to a message via the 
> 'bodySections(collection)' API a previous single valued section set via the 
> 'body(section)' should always be cleared.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-2454) Singular body section not always cleared when bulk adding multiple sections

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PROTON-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437651#comment-17437651
 ] 

ASF subversion and git services commented on PROTON-2454:
-

Commit 8b416088dbeada18f58a8573194cb86593f07562 in qpid-protonj2's branch 
refs/heads/main from Timothy Bish
[ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=8b41608 ]

PROTON-2454 Clear body when bodySections is called in all cases

Adding a collection of body sections should clear any previous singular
or collection assigned value always.

> Singular body section not always cleared when bulk adding multiple sections
> ---
>
> Key: PROTON-2454
> URL: https://issues.apache.org/jira/browse/PROTON-2454
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: protonj2
>Affects Versions: protonj2-1.0.0-M3
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Minor
> Fix For: protonj2-1.0.0-M4
>
>
> When assigning a collection of body section to a message via the 
> 'bodySections(collection)' API a previous single valued section set via the 
> 'body(section)' should always be cleared.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-2454) Singular body section not always cleared when bulk adding multiple sections

[Timothy A. Bish (Jira)]

Timothy A. Bish created PROTON-2454:
---

 Summary: Singular body section not always cleared when bulk adding 
multiple sections
 Key: PROTON-2454
 URL: https://issues.apache.org/jira/browse/PROTON-2454
 Project: Qpid Proton
  Issue Type: Bug
  Components: protonj2
Affects Versions: protonj2-1.0.0-M3
Reporter: Timothy A. Bish
Assignee: Timothy A. Bish
 Fix For: protonj2-1.0.0-M4


When assigning a collection of body section to a message via the 
'bodySections(collection)' API a previous single valued section set via the 
'body(section)' should always be cleared.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1958) Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437607#comment-17437607
 ] 

ASF GitHub Bot commented on DISPATCH-1958:
--

kgiusti commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-957878563


   hmmm...  I wonder if it would be simpler to make QD_MEMORY_STATS 
non-configurable?  IOW, get rid of the flag and just always provide memory 
statistics.  It's pretty obvious we haven't tested QD_MEMORY_STATS=OFF as part 
of our CI.
   
   Just an opinion, thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`
> 
>
> Key: DISPATCH-1958
> URL: https://issues.apache.org/jira/browse/DISPATCH-1958
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tools
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> From the README
> {noformat}
> -DQD_MEMORY_STATS=
> --
> Dispatch will track memory pool usage statistics if this is enabled.
> {noformat}
> So the statistics may not be always available, depending on the way 
> Dispatch is compiled.
> Allocator metrics get reported as 0. I see that {{qdmanage}} works just fine, 
> but {{qdstat}} is throwing an error in such case:
> {noformat}
> $ qdstat -m
> 2021-02-04 15:08:19.288818 UTC
> Standalone_v++jCPCjYiQcGo3
> TypeError: unsupported operand type(s) for *: 'int32' and 'NoneType'
> {noformat}
> Found during PR review by [~fgiorget].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-dispatch] kgiusti commented on pull request #1416: DISPATCH-1958: Fixed error in qdstat when memory stats are turned off…

[GitBox]

kgiusti commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-957878563


   hmmm...  I wonder if it would be simpler to make QD_MEMORY_STATS 
non-configurable?  IOW, get rid of the flag and just always provide memory 
statistics.  It's pretty obvious we haven't tested QD_MEMORY_STATS=OFF as part 
of our CI.
   
   Just an opinion, thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1958) Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437606#comment-17437606
 ] 

ASF GitHub Bot commented on DISPATCH-1958:
--

ted-ross commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-958124314


   > > hmmm... I wonder if it would be simpler to make QD_MEMORY_STATS 
non-configurable? IOW, get rid of the flag and just always provide memory 
statistics. It's pretty obvious we haven't tested QD_MEMORY_STATS=OFF as part 
of our CI.
   > > Just an opinion, thoughts?
   > 
   > I am all for getting rid of the flag once and for all and always provide 
memory statistics but first I want to understand why this flag was introduced 
in the first place ? If we decide to keep this flag, we need to augment CI 
(preferably GHA) to test with QD_MEMORY_STATS=OFF. That will add _yet another_ 
build type to the already long list of tests we run, so I am inclined to say 
let's just get rid of this flag.
   > 
   > @ted-ross what do you think ?
   
   +1 on removing the flag.  This was first introduced due to concern that the 
stats collection might be costly.  I don't believe that it has been identified 
as a performance/memory bottleneck in any of the investigations we've done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`
> 
>
> Key: DISPATCH-1958
> URL: https://issues.apache.org/jira/browse/DISPATCH-1958
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tools
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> From the README
> {noformat}
> -DQD_MEMORY_STATS=
> --
> Dispatch will track memory pool usage statistics if this is enabled.
> {noformat}
> So the statistics may not be always available, depending on the way 
> Dispatch is compiled.
> Allocator metrics get reported as 0. I see that {{qdmanage}} works just fine, 
> but {{qdstat}} is throwing an error in such case:
> {noformat}
> $ qdstat -m
> 2021-02-04 15:08:19.288818 UTC
> Standalone_v++jCPCjYiQcGo3
> TypeError: unsupported operand type(s) for *: 'int32' and 'NoneType'
> {noformat}
> Found during PR review by [~fgiorget].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-dispatch] ted-ross commented on pull request #1416: DISPATCH-1958: Fixed error in qdstat when memory stats are turned off…

[GitBox]

ted-ross commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-958124314


   > > hmmm... I wonder if it would be simpler to make QD_MEMORY_STATS 
non-configurable? IOW, get rid of the flag and just always provide memory 
statistics. It's pretty obvious we haven't tested QD_MEMORY_STATS=OFF as part 
of our CI.
   > > Just an opinion, thoughts?
   > 
   > I am all for getting rid of the flag once and for all and always provide 
memory statistics but first I want to understand why this flag was introduced 
in the first place ? If we decide to keep this flag, we need to augment CI 
(preferably GHA) to test with QD_MEMORY_STATS=OFF. That will add _yet another_ 
build type to the already long list of tests we run, so I am inclined to say 
let's just get rid of this flag.
   > 
   > @ted-ross what do you think ?
   
   +1 on removing the flag.  This was first introduced due to concern that the 
stats collection might be costly.  I don't believe that it has been identified 
as a performance/memory bottleneck in any of the investigations we've done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1958) Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437604#comment-17437604
 ] 

ASF GitHub Bot commented on DISPATCH-1958:
--

ganeshmurthy opened a new pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416


   … (-DQD_MEMORY_STATS=OFF)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`
> 
>
> Key: DISPATCH-1958
> URL: https://issues.apache.org/jira/browse/DISPATCH-1958
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tools
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> From the README
> {noformat}
> -DQD_MEMORY_STATS=
> --
> Dispatch will track memory pool usage statistics if this is enabled.
> {noformat}
> So the statistics may not be always available, depending on the way 
> Dispatch is compiled.
> Allocator metrics get reported as 0. I see that {{qdmanage}} works just fine, 
> but {{qdstat}} is throwing an error in such case:
> {noformat}
> $ qdstat -m
> 2021-02-04 15:08:19.288818 UTC
> Standalone_v++jCPCjYiQcGo3
> TypeError: unsupported operand type(s) for *: 'int32' and 'NoneType'
> {noformat}
> Found during PR review by [~fgiorget].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-552) JMS 2 Completion threads shouldn't scale with the number of sessions

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437601#comment-17437601
 ] 

ASF GitHub Bot commented on QPIDJMS-552:


franz1981 edited a comment on pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957253435






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JMS 2 Completion threads shouldn't scale with the number of sessions
> 
>
> Key: QPIDJMS-552
> URL: https://issues.apache.org/jira/browse/QPIDJMS-552
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 1.3.0
>Reporter: Francesco Nigro
>Priority: Major
>
> JMS 2 Completion threads are now tied to be one per JMS Session ie a client 
> application with N JMS sessions need N completion threads to handle the 
> completion events.
> Given that the asynchronous model of JMS 2 allows users to have few threads 
> handling many JMS sessions, should be better to reduce the amount of 
> completion threads without exceeding the number of available cores and 
> shrink/grow according to the completion event processing load.
> If the user confine a connection in a thread handling many JMS sessions and 
> the completion events are issued by the same Netty thread in sequence, if the 
> completion processing for a JMS Session is fast enough, next JMS Sessions can 
> reuse existing completion threads instead of using a new one.
> This model save using too many completion threads for users tasks that are 
> supposed to be very fast: if the user task cause a specific JMS Session 
> completion thread to block, the expectation is that the system should be able 
> to create a new completion thread to handle other JMS Session completion 
> events, as expected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

[GitBox]

franz1981 edited a comment on pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957253435






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-552) JMS 2 Completion threads shouldn't scale with the number of sessions

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437595#comment-17437595
 ] 

ASF GitHub Bot commented on QPIDJMS-552:


gemmellr commented on pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957323951


   I think single completion at a time is the way to go, at least by default, 
it just shouldn't really be a concern when using it whether the callback 
execution is fair or not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JMS 2 Completion threads shouldn't scale with the number of sessions
> 
>
> Key: QPIDJMS-552
> URL: https://issues.apache.org/jira/browse/QPIDJMS-552
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 1.3.0
>Reporter: Francesco Nigro
>Priority: Major
>
> JMS 2 Completion threads are now tied to be one per JMS Session ie a client 
> application with N JMS sessions need N completion threads to handle the 
> completion events.
> Given that the asynchronous model of JMS 2 allows users to have few threads 
> handling many JMS sessions, should be better to reduce the amount of 
> completion threads without exceeding the number of available cores and 
> shrink/grow according to the completion event processing load.
> If the user confine a connection in a thread handling many JMS sessions and 
> the completion events are issued by the same Netty thread in sequence, if the 
> completion processing for a JMS Session is fast enough, next JMS Sessions can 
> reuse existing completion threads instead of using a new one.
> This model save using too many completion threads for users tasks that are 
> supposed to be very fast: if the user task cause a specific JMS Session 
> completion thread to block, the expectation is that the system should be able 
> to create a new completion thread to handle other JMS Session completion 
> events, as expected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-jms] gemmellr commented on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

[GitBox]

gemmellr commented on pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957323951


   I think single completion at a time is the way to go, at least by default, 
it just shouldn't really be a concern when using it whether the callback 
execution is fair or not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-552) JMS 2 Completion threads shouldn't scale with the number of sessions

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437593#comment-17437593
 ] 

ASF GitHub Bot commented on QPIDJMS-552:


franz1981 commented on pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957253435






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JMS 2 Completion threads shouldn't scale with the number of sessions
> 
>
> Key: QPIDJMS-552
> URL: https://issues.apache.org/jira/browse/QPIDJMS-552
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 1.3.0
>Reporter: Francesco Nigro
>Priority: Major
>
> JMS 2 Completion threads are now tied to be one per JMS Session ie a client 
> application with N JMS sessions need N completion threads to handle the 
> completion events.
> Given that the asynchronous model of JMS 2 allows users to have few threads 
> handling many JMS sessions, should be better to reduce the amount of 
> completion threads without exceeding the number of available cores and 
> shrink/grow according to the completion event processing load.
> If the user confine a connection in a thread handling many JMS sessions and 
> the completion events are issued by the same Netty thread in sequence, if the 
> completion processing for a JMS Session is fast enough, next JMS Sessions can 
> reuse existing completion threads instead of using a new one.
> This model save using too many completion threads for users tasks that are 
> supposed to be very fast: if the user task cause a specific JMS Session 
> completion thread to block, the expectation is that the system should be able 
> to create a new completion thread to handle other JMS Session completion 
> events, as expected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1958) Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437591#comment-17437591
 ] 

ASF GitHub Bot commented on DISPATCH-1958:
--

ganeshmurthy commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-957887593






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`
> 
>
> Key: DISPATCH-1958
> URL: https://issues.apache.org/jira/browse/DISPATCH-1958
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tools
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> From the README
> {noformat}
> -DQD_MEMORY_STATS=
> --
> Dispatch will track memory pool usage statistics if this is enabled.
> {noformat}
> So the statistics may not be always available, depending on the way 
> Dispatch is compiled.
> Allocator metrics get reported as 0. I see that {{qdmanage}} works just fine, 
> but {{qdstat}} is throwing an error in such case:
> {noformat}
> $ qdstat -m
> 2021-02-04 15:08:19.288818 UTC
> Standalone_v++jCPCjYiQcGo3
> TypeError: unsupported operand type(s) for *: 'int32' and 'NoneType'
> {noformat}
> Found during PR review by [~fgiorget].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-jms] franz1981 commented on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

[GitBox]

franz1981 commented on pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957253435






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #1416: DISPATCH-1958: Fixed error in qdstat when memory stats are turned off…

[GitBox]

ganeshmurthy commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-957887593






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1958) Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437559#comment-17437559
 ] 

ASF GitHub Bot commented on DISPATCH-1958:
--

ganeshmurthy commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-958128206


   > Let's do this the simple way and remove the flag.
   
   Sounds good. I will add a commit to this PR removing the flag. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`
> 
>
> Key: DISPATCH-1958
> URL: https://issues.apache.org/jira/browse/DISPATCH-1958
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tools
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> From the README
> {noformat}
> -DQD_MEMORY_STATS=
> --
> Dispatch will track memory pool usage statistics if this is enabled.
> {noformat}
> So the statistics may not be always available, depending on the way 
> Dispatch is compiled.
> Allocator metrics get reported as 0. I see that {{qdmanage}} works just fine, 
> but {{qdstat}} is throwing an error in such case:
> {noformat}
> $ qdstat -m
> 2021-02-04 15:08:19.288818 UTC
> Standalone_v++jCPCjYiQcGo3
> TypeError: unsupported operand type(s) for *: 'int32' and 'NoneType'
> {noformat}
> Found during PR review by [~fgiorget].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #1416: DISPATCH-1958: Fixed error in qdstat when memory stats are turned off…

[GitBox]

ganeshmurthy commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-958128206


   > Let's do this the simple way and remove the flag.
   
   Sounds good. I will add a commit to this PR removing the flag. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1958) Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437556#comment-17437556
 ] 

ASF GitHub Bot commented on DISPATCH-1958:
--

ted-ross commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-958124314


   > > hmmm... I wonder if it would be simpler to make QD_MEMORY_STATS 
non-configurable? IOW, get rid of the flag and just always provide memory 
statistics. It's pretty obvious we haven't tested QD_MEMORY_STATS=OFF as part 
of our CI.
   > > Just an opinion, thoughts?
   > 
   > I am all for getting rid of the flag once and for all and always provide 
memory statistics but first I want to understand why this flag was introduced 
in the first place ? If we decide to keep this flag, we need to augment CI 
(preferably GHA) to test with QD_MEMORY_STATS=OFF. That will add _yet another_ 
build type to the already long list of tests we run, so I am inclined to say 
let's just get rid of this flag.
   > 
   > @ted-ross what do you think ?
   
   +1 on removing the flag.  This was first introduced due to concern that the 
stats collection might be costly.  I don't believe that it has been identified 
as a performance/memory bottleneck in any of the investigations we've done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`
> 
>
> Key: DISPATCH-1958
> URL: https://issues.apache.org/jira/browse/DISPATCH-1958
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tools
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> From the README
> {noformat}
> -DQD_MEMORY_STATS=
> --
> Dispatch will track memory pool usage statistics if this is enabled.
> {noformat}
> So the statistics may not be always available, depending on the way 
> Dispatch is compiled.
> Allocator metrics get reported as 0. I see that {{qdmanage}} works just fine, 
> but {{qdstat}} is throwing an error in such case:
> {noformat}
> $ qdstat -m
> 2021-02-04 15:08:19.288818 UTC
> Standalone_v++jCPCjYiQcGo3
> TypeError: unsupported operand type(s) for *: 'int32' and 'NoneType'
> {noformat}
> Found during PR review by [~fgiorget].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-dispatch] ted-ross commented on pull request #1416: DISPATCH-1958: Fixed error in qdstat when memory stats are turned off…

[GitBox]

ted-ross commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-958124314


   > > hmmm... I wonder if it would be simpler to make QD_MEMORY_STATS 
non-configurable? IOW, get rid of the flag and just always provide memory 
statistics. It's pretty obvious we haven't tested QD_MEMORY_STATS=OFF as part 
of our CI.
   > > Just an opinion, thoughts?
   > 
   > I am all for getting rid of the flag once and for all and always provide 
memory statistics but first I want to understand why this flag was introduced 
in the first place ? If we decide to keep this flag, we need to augment CI 
(preferably GHA) to test with QD_MEMORY_STATS=OFF. That will add _yet another_ 
build type to the already long list of tests we run, so I am inclined to say 
let's just get rid of this flag.
   > 
   > @ted-ross what do you think ?
   
   +1 on removing the flag.  This was first introduced due to concern that the 
stats collection might be costly.  I don't believe that it has been identified 
as a performance/memory bottleneck in any of the investigations we've done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2144) Fatal Python error: _PyMem_DebugMalloc: Python memory allocator called without holding the GIL

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2144:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Fatal Python error: _PyMem_DebugMalloc: Python memory allocator called 
> without holding the GIL
> --
>
> Key: DISPATCH-2144
> URL: https://issues.apache.org/jira/browse/DISPATCH-2144
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Policy Engine
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.19.0
>
>
> To reproduce, install python3-debug on Fedora, then use it to build and run 
> Dispatch
> https://github.com/jiridanek/qpid-dispatch/runs/2629007367?check_suite_focus=true#step:25:7044
> {noformat}
> 25: Router QDR.Policy output file:
> 25: 
> 25: 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/python/qpid_dispatch_internal/policy/policy_util.py:65:
>  ResourceWarning: unclosed  family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0, 
> laddr=('::', 0, 0, 0)>
> 25:   if is_ipv6_enabled():
> 25: ResourceWarning: Enable tracemalloc to get the object allocation traceback
> 25: Fatal Python error: _PyMem_DebugMalloc: Python memory allocator called 
> without holding the GIL
> 25: Python runtime state: initialized
> 25: 
> 25: Thread 0x7f0e8fffcec0 (most recent call first):
> 25: 
> {noformat}
> Unrelated error in the same log that I noticed at random
> {noformat}
> 23: E   /builddir/build/BUILD/Python-3.9.5/Modules/gcmodule.c:114: 
> gc_decref: Assertion "gc_get_refs(g) > 0" failed: refcount is too small
> 23: E   Enable tracemalloc to get the memory block allocation 
> traceback
> 23: E   
> 23: E   object address  : 0x7fd3e1b90cd0
> 23: E   object refcount : 117
> 23: E   object type : 0x7b695c30
> 23: E   object type name: Agent
> 23: E   object repr : 
> 
> 23: E   
> 23: E   Fatal Python error: _PyObject_AssertFailed: 
> _PyObject_AssertFailed
> 23: E   Python runtime state: initialized
> 23: E   
> 23: E   Current thread 0x7fd3e39e3ec0 (most recent call first):
> 23: E   
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2102) Shutdown crash when console connected

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2102:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Shutdown crash when console connected
> -
>
> Key: DISPATCH-2102
> URL: https://issues.apache.org/jira/browse/DISPATCH-2102
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Charles E. Rolke
>Assignee: Ernest Allen
>Priority: Major
> Fix For: 1.19.0
>
>
> h2. code
> Proton git branch main @ 08b301a9. Dispatch git branch main @ 68c08365
> This is post-1.16.x branch point. Expect that problem exists on 1.16.x branch 
> also.
> h2. configuation
> Standard 12-node Crosslane network, with 12 echo servers and 144 listeners
> h2. INTA config
> No specification of worker threads in router conf file
> h2. Test that failed
>  * Connected a console to INTA_http
>  * Run a bunch of echo servers and clients. They all worked ok.
>  * kill  : all local routers on taj
> h2. Backtrace
> {code:java}
>  gdb qdrouterd core.qdrouterd.1140630
> GNU gdb (GDB) Fedora 9.1-6.fc32
> Copyright (C) 2020 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later 
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> Type "show copying" and "show warranty" for details.
> This GDB was configured as "x86_64-redhat-linux-gnu".
> Type "show configuration" for configuration details.
> For bug reporting instructions, please see:
> .
> Find the GDB manual and other documentation resources online at:
>  .
> For help, type "help".
> Type "apropos word" to search for commands related to "word"...
> Reading symbols from qdrouterd...
> [New LWP 1140659]
> [New LWP 1140630]
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library "/usr/lib64/libthread_db.so.1".
> Core was generated by `qdrouterd -c INTA.conf'.
> Program terminated with signal SIGABRT, Aborted.
> #0 0x7f368c5b69e5 in raise () from /usr/lib64/libc.so.6
> [Current thread is 1 (Thread 0x7f367e5df700 (LWP 1140659))]
> Missing separate debuginfos, use: dnf debuginfo-install 
> cyrus-sasl-gssapi-2.1.27-4.fc32.x86_64 cyrus-sasl-lib-2.1.27-4.fc32.x86_64 
> cyrus-sasl-md5-2.1.27-4.fc32.x86_64 cyrus-sasl-plain-2.1.27-4.fc32.x86_64 
> glibc-2.31-4.fc32.x86_64 keyutils-libs-1.6-4.fc32.x86_64 
> krb5-libs-1.18.2-29.fc32.x86_64 libcom_err-1.45.5-3.fc32.x86_64 
> libdb-5.3.28-40.fc32.x86_64 libev-4.31-2.fc32.x86_64 
> libffi-3.1-24.fc32.x86_64 libgcc-10.2.1-9.fc32.x86_64 
> libselinux-3.0-5.fc32.x86_64 libuv-1.39.0-1.fc32.x86_64 
> libwebsockets-3.2.2-2.fc32.x86_64 libxcrypt-4.4.17-1.fc32.x86_64 
> openssl-libs-1.1.1g-1.fc32.x86_64 pcre2-10.35-8.fc32.x86_64 
> python3-libs-3.8.6-1.fc32.x86_64 zlib-1.2.11-21.fc32.x86_64
> (gdb) bt
> #0 0x7f368c5b69e5 in raise () from /usr/lib64/libc.so.6
> #1 0x7f368c59f895 in abort () from /usr/lib64/libc.so.6
> #2 0x7f368c59f769 in __assert_fail_base.cold () from /usr/lib64/libc.so.6
> #3 0x7f368c5aee76 in __assert_fail () from /usr/lib64/libc.so.6
> #4 0x7f368cc01e5b in sys_mutex_lock (mutex=0x1238ec0) at 
> /home/chug/git/qpid-dispatch/src/posix/threading.c:58
> #5 0x7f368cc54289 in work_push (hs=0x12e0730, w=...) at 
> /home/chug/git/qpid-dispatch/src/http-libwebsockets.c:234
> #6 0x7f368cc54bf3 in connection_wake (qd_conn=0x7f3670018910) at 
> /home/chug/git/qpid-dispatch/src/http-libwebsockets.c:419
> #7 0x7f368cc51892 in qd_server_activate (ctx=0x7f3670018910) at 
> /home/chug/git/qpid-dispatch/src/server.c:1520
> #8 0x7f368cc4a1f7 in CORE_connection_activate (context=0x1319d90, 
> conn=0x7f3670034510) at /home/chug/git/qpid-dispatch/src/router_node.c:1679
> #9 0x7f368cc2f144 in qdr_activate_connections_CT (core=0x135e460) at 
> /home/chug/git/qpid-dispatch/src/router_core/router_core_thread.c:89
> #10 0x7f368cc2fa41 in router_core_thread (arg=0x135e460) at 
> /home/chug/git/qpid-dispatch/src/router_core/router_core_thread.c:247
> #11 0x7f368cc02159 in _thread_init (arg=0x13d1a20) at 
> /home/chug/git/qpid-dispatch/src/posix/threading.c:172
> #12 0x7f368cb05432 in start_thread () from /usr/lib64/libpthread.so.0
> #13 0x7f368c67b913 in clone () from /usr/lib64/libc.so.6
>  
> (gdb) thread apply all bt
> Thread 2 (Thread 0x7f368bd882c0 (LWP 1140630)):
> #0 0x7f368cb56c89 in pn_session_get_context (session=0x7f36700f1dc0) at 
> /home/chug/git/qpid-proton/c/src/core/engine.c:297
> #1 0x7f368cbe23aa in qd_session_from_pn (pn_ssn=0x7f36700f1dc0) at 
> /home/chug/git/qpid-dispatch/include/qpid/disp

[jira] [Updated] (DISPATCH-2021) [libuv] system_tests_topology test_01_topology_failover sometimes fails with wrong message trace

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2021:

Fix Version/s: (was: 1.18.0)
   1.19.0

> [libuv] system_tests_topology test_01_topology_failover sometimes fails with 
> wrong message trace
> 
>
> Key: DISPATCH-2021
> URL: https://issues.apache.org/jira/browse/DISPATCH-2021
> Project: Qpid Dispatch
>  Issue Type: Test
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Priority: Major
>  Labels: macOS
> Fix For: 1.19.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/494093992#L4002
> {noformat}
> 45: ==
> 45: FAIL: test_01_topology_failover (system_tests_topology.TopologyTests)
> 45: --
> 45: Traceback (most recent call last):
> 45: File 
> "/Users/travis/build/apache/qpid-dispatch/tests/system_tests_topology.py", 
> line 284, in test_01_topology_failover
> 45: self.assertEqual(None, test.error)
> 45: AssertionError: None != "expected trace ['0/A', '0/C', '0/B'] but[36 
> chars]/B']"
> 45: 
> 45: --
> 45: Ran 3 tests in 38.117s
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2180) Race: timer freeing qd_message_t during cleanup conflict with I/O threads

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2180:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Race: timer freeing qd_message_t during cleanup conflict with I/O threads
> -
>
> Key: DISPATCH-2180
> URL: https://issues.apache.org/jira/browse/DISPATCH-2180
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Critical
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> This is a PR build, but I think it is unlikely the build changes in PR caused 
> this.
> https://github.com/apache/qpid-dispatch/pull/1267/checks?check_run_id=2872865196#step:25:804
> {noformat}
>  26: Router EA1 output file:
> 26: 
> 26: ==
> 26: WARNING: ThreadSanitizer: data race (pid=1865)
> 26:   Read of size 8 at 0x7b480001b600 by thread T2:
> 26: #0 qd_alloc_sequence 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/alloc_pool.c:525
>  (qdrouterd+0x44df98)
> 26: #1 cleanup_link 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:359
>  (qdrouterd+0x462da3)
> 26: #2 qd_link_free 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:1000
>  (qdrouterd+0x4632b5)
> 26: #3 qd_link_free 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:991
>  (qdrouterd+0x463392)
> 26: #4 AMQP_link_detach_handler 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:1142
>  (qdrouterd+0x4dc8f1)
> 26: #5 AMQP_link_detach_handler 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:1095
>  (qdrouterd+0x4dc8f1)
> 26: #6 close_links 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:336
>  (qdrouterd+0x463419)
> 26: #7 qd_container_handle_event 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:528
>  (qdrouterd+0x4643f3)
> 26: #8 handle 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1096 
> (qdrouterd+0x4e1c51)
> 26: #9 thread_run 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1121 
> (qdrouterd+0x4e3f0b)
> 26: #10 _thread_init 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
>  (qdrouterd+0x4868bd)
> 26: 
> 26:   Previous write of size 8 at 0x7b480001b600 by main thread:
> 26: #0 qd_dealloc 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/alloc_pool.c:477
>  (qdrouterd+0x44d6d6)
> 26: #1 free_qd_message_t 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/message.c:91 
> (qdrouterd+0x472a1b)
> 26: #2 qd_message_free 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/message.c:1091
>  (qdrouterd+0x472a1b)
> 26: #3 qdr_do_message_to_addr_free 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core_thread.c:102
>  (qdrouterd+0x4bcfa6)
> 26: #4 qdr_general_handler 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core.c:942
>  (qdrouterd+0x4b5bc3)
> 26: #5 qd_timer_visit 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/timer.c:316 
> (qdrouterd+0x4e6bb5)
> 26: #6 handle 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1006 
> (qdrouterd+0x4e1be6)
> 26: #7 thread_run 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1121 
> (qdrouterd+0x4e4005)
> 26: #8 qd_server_run 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1501 
> (qdrouterd+0x4e4c11)
> 26: #9 main_process 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:115
>  (qdrouterd+0x426ccc)
> 26: #10 main 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
>  (qdrouterd+0x42622c)
> 26: 
> 26:   Location is heap block of size 384 at 0x7b480001b600 allocated by 
> thread T1:
> 26: #0 posix_memalign  (libtsan.so.0+0x32a23)
> 26: #1 qd_alloc 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/alloc_pool.c:396
>  (qdrouterd+0x44c6d4)
> 26: #2 new_qd_message_t 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/message.c:91 
> (qdrouterd+0x475a3d)
> 26: #3 qd_message_copy 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/message.c:1099
>  (qdrouterd+0x475a3d)
> 26: #4 qdr_forward_on_message_CT 
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/forwarder.c:401
>  (qdrouterd+0x4af41b)
> 26: #5 qdr_forward_to_subscriber_CT 
> /home/runner/work/

[jira] [Updated] (DISPATCH-2007) Need better allocation of sessions across inter-router links

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2007:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Need better allocation of sessions across inter-router links
> 
>
> Key: DISPATCH-2007
> URL: https://issues.apache.org/jira/browse/DISPATCH-2007
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.19.0
>
>
> Inter-router connections establish several links for passing traffic between 
> routers.  Session allocation across the links is currently:
>  * one session dedicated to both router control links
>  * one session for EACH priority link pair (in/out) - 10 sessions total
>  * one session used by all link route links
>  * one session used by all streaming link
> There is an issue with sharing the session in the case of streaming & link 
> routes.  Due to the way session flow control works all links on the session 
> share bandwidth.  This means one slow link can force flow control on all of 
> its peer links on the session.
> Proton allows for at most 32K sessions per connection.  We should make an 
> attempt to use dedicated sessions for link route and streaming links, sharing 
> only when the number of link route + streaming links exceeds the proton 
> limit. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2084) Leak of qdr_terminus_t in system_tests_link_route_credit

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2084:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Leak of qdr_terminus_t in system_tests_link_route_credit
> 
>
> Key: DISPATCH-2084
> URL: https://issues.apache.org/jira/browse/DISPATCH-2084
> Project: Qpid Dispatch
>  Issue Type: Test
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Priority: Major
>  Labels: macOS
> Fix For: 1.19.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501204452#L2718
> {noformat}
> 16: Leak: 2021-04-26 18:52:24.682533 + type: qdr_terminus_t address: 
> 0x612b91d0
> 16: 0   libqpid-dispatch.dylib  0x00010ebd8ca0 qd_alloc + 4240
> 16: 1   libqpid-dispatch.dylib  0x00010eddb99c qdr_terminus + 
> 44
> 16: 2   libqpid-dispatch.dylib  0x00010ee4f68b 
> AMQP_outgoing_link_handler + 251
> 16: 3   libqpid-dispatch.dylib  0x00010ee6e7c7 handle + 455
> 16: 4   libqpid-dispatch.dylib  0x00010ee673f4 thread_run + 
> 340
> 16: 5   libqpid-dispatch.dylib  0x00010ee66bcb qd_server_run 
> + 1291
> 16: 6   qdrouterd   0x00010eb2596f main_process + 
> 191
> 16: 7   qdrouterd   0x00010eb2427c main + 1260
> 16: 8   libdyld.dylib   0x7fff7e5a13d5 start + 1
> 16: 
> 16: Leak: 2021-04-26 18:52:24.682539 + type: qdr_terminus_t address: 
> 0x612b9050
> 16: 0   libqpid-dispatch.dylib  0x00010ebd8ca0 qd_alloc + 4240
> 16: 1   libqpid-dispatch.dylib  0x00010eddb99c qdr_terminus + 
> 44
> 16: 2   libqpid-dispatch.dylib  0x00010ee4f69f 
> AMQP_outgoing_link_handler + 271
> 16: 3   libqpid-dispatch.dylib  0x00010ee6e7c7 handle + 455
> 16: 4   libqpid-dispatch.dylib  0x00010ee673f4 thread_run + 
> 340
> 16: 5   libqpid-dispatch.dylib  0x00010ee66bcb qd_server_run 
> + 1291
> 16: 6   qdrouterd   0x00010eb2596f main_process + 
> 191
> 16: 7   qdrouterd   0x00010eb2427c main + 1260
> 16: 8   libdyld.dylib   0x7fff7e5a13d5 start + 1
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2069) ThreadSanitizer: data race at qdr_core_free in system_tests_policy

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2069:

Fix Version/s: (was: 1.18.0)
   1.19.0

> ThreadSanitizer: data race at qdr_core_free in system_tests_policy
> --
>
> Key: DISPATCH-2069
> URL: https://issues.apache.org/jira/browse/DISPATCH-2069
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> {code}
> TSAN_OPTIONS=second_deadlock_stack=1 router/qdrouterd -c 
> ./tests/system_test.dir/system_tests_policy/LoadPolicyFromFolder/setUpClass/conn-limit-router.conf
>  -I /home/jdanek/repos/qpid/qpid-dispatch/python
> {code}
> {noformat}
> ==
> WARNING: ThreadSanitizer: data race (pid=5929)
>   Write of size 1 at 0x7b6400031b20 by main thread:
> #0 qdr_core_free ../src/router_core/router_core.c:138 
> (libqpid-dispatch.so+0xc18f4)
> #1 qd_router_free ../src/router_node.c:2157 (libqpid-dispatch.so+0xe3bde)
> #2 qd_dispatch_free ../src/dispatch.c:372 (libqpid-dispatch.so+0x71387)
> #3 main_process ../router/src/main.c:119 (qdrouterd+0x40263a)
> #4 main ../router/src/main.c:369 (qdrouterd+0x4032ae)
>   Previous read of size 1 at 0x7b6400031b20 by thread T1:
> #0 router_core_thread ../src/router_core/router_core_thread.c:210 
> (libqpid-dispatch.so+0xc41ce)
> #1 _thread_init ../src/posix/threading.c:172 (libqpid-dispatch.so+0x8f3cf)
> #2   (libtsan.so.0+0x30f0f)
>   Location is heap block of size 1160 at 0x7b6400031b00 allocated by main 
> thread:
> #0 malloc  (libtsan.so.0+0x33dc1)
> #1 qd_malloc ../include/qpid/dispatch/ctools.h:229 
> (libqpid-dispatch.so+0xbd690)
> #2 qdr_core ../src/router_core/router_core.c:71 
> (libqpid-dispatch.so+0xbd690)
> #3 qd_router_setup_late ../src/router_node.c:2119 
> (libqpid-dispatch.so+0xe3a56)
> #4 ffi_call_unix64  (libffi.so.7+0x7abc)
> #5 main_process ../router/src/main.c:97 (qdrouterd+0x4025ae)
> #6 main ../router/src/main.c:369 (qdrouterd+0x4032ae)
>   Thread T1 (tid=5931, running) created by main thread at:
> #0 pthread_create  (libtsan.so.0+0x5cba2)
> #1 sys_thread ../src/posix/threading.c:181 (libqpid-dispatch.so+0x8f89b)
> #2 qdr_core ../src/router_core/router_core.c:122 
> (libqpid-dispatch.so+0xbd91b)
> #3 qd_router_setup_late ../src/router_node.c:2119 
> (libqpid-dispatch.so+0xe3a56)
> #4 ffi_call_unix64  (libffi.so.7+0x7abc)
> #5 main_process ../router/src/main.c:97 (qdrouterd+0x4025ae)
> #6 main ../router/src/main.c:369 (qdrouterd+0x4032ae)
> SUMMARY: ThreadSanitizer: data race ../src/router_core/router_core.c:138 in 
> qdr_core_free
> ==
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-1844) sys_mutex leak detected by LeakSanitizer ASAN (shutdown)

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1844:

Fix Version/s: (was: 1.18.0)
   1.19.0

> sys_mutex leak detected by LeakSanitizer ASAN (shutdown)
> 
>
> Key: DISPATCH-1844
> URL: https://issues.apache.org/jira/browse/DISPATCH-1844
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Protocol Adaptors, Router Node
>Affects Versions: 1.14.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Minor
>  Labels: HTTP/1.x, lsan
> Fix For: 1.19.0
>
>
> The LSAN (ASAN) leak sanitizer occasionally detects a leak of sys_mutex items 
> that are used by the qd_message_t content:
>  
> {noformat}
> 70: ==1475684==ERROR: LeakSanitizer: detected memory leaks 
> 70: 
> 70: Direct leak of 128 byte(s) in 2 object(s) allocated from: 
> 70: #0 0x7f52044ebbf5 in __interceptor_posix_memalign 
> (/lib64/libasan.so.5+0x10ebf5) 
> 70: #1 0x7f5203b7e2cc in sys_mutex 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:41 
> 70: #2 0x7f5203b31b0f in qd_message 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/message.c:1012 
> 70: #3 0x7f5203a9edae in _server_rx_headers_done_cb 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http1/http1_server.c:862
>  
> 70: #4 0x7f5203a64d2a in process_headers_done 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http1/http1_codec.c:831
>  
> 70: #5 0x7f5203a66411 in parse_header 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http1/http1_codec.c:911
>  
> 70: #6 0x7f5203a6d065 in decode_incoming 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http1/http1_codec.c:1301
>  
> 70: #7 0x7f5203a6e09a in h1_codec_connection_rx_data 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http1/http1_codec.c:1346
>  
> 70: #8 0x7f5203a9a3fe in _handle_connection_events 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http1/http1_server.c:562
>  
> 70: #9 0x7f5203ceb754 in handle_event_with_context 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:804 
> 70: #10 0x7f5203ceb796 in do_handle_raw_connection_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:810 
> 70: #11 0x7f5203ceffe5 in handle 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1090 
> 70: #12 0x7f5203cf0297 in thread_run 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1122 
> 70: #13 0x7f5203cf770f in qd_server_run 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1484 
> 70: #14 0x4026f8 in main_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:113 
> 70: #15 0x404576 in main 
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367 
> 70: #16 0x7f52025761a2 in __libc_start_main (/lib64/libc.so.6+0x271a2)
> {noformat}
> This leak is easily triggered by the HTTP1 adaptor but can also be triggered 
> using plain AMQP.
> This is a shutdown leak.  This occurs when a qdr_delivery_t is left on the 
> link's updated_deliveries list at the point where the shutdown occurs.
> Since this is a shutdown leak I will add a suppression to the lsan.supp list 
> for now - this Jira remains open until the issue is actually fixed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-1935) Interrouter streaming links accumulate credit

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1935:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Interrouter streaming links accumulate credit
> -
>
> Key: DISPATCH-1935
> URL: https://issues.apache.org/jira/browse/DISPATCH-1935
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.14.0
>Reporter: Charles E. Rolke
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.19.0
>
>
> After running a few tests with TCP adaptor and two routers some inter-router 
> streaming links have a credit of 251 when the capacity is 250. This is 
> exposed by normal self tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2070) Data race when incrementing severity_histogram from logging calls

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2070:

Fix Version/s: (was: 1.18.0)
   Backlog

> Data race when incrementing severity_histogram from logging calls
> -
>
> Key: DISPATCH-2070
> URL: https://issues.apache.org/jira/browse/DISPATCH-2070
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Michael Goulish
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: Backlog
>
>
> {noformat}
> % TSAN_OPTIONS=second_deadlock_stack=1 router/qdrouterd -c 
> ./tests/system_test.dir/system_tests_policy/LoadPolicyFromFolder/setUpClass/conn-limit-router.conf
>  -I /home/jdanek/repos/qpid/qpid-dispatch/python
> ==
> WARNING: ThreadSanitizer: data race (pid=14373)
>   Read of size 8 at 0x7b1c06d0 by thread T1:
> #0 qd_vlog_impl ../src/log.c:420 (libqpid-dispatch.so+0x791c4)
> #1 qd_log_impl ../src/log.c:456 (libqpid-dispatch.so+0x795e8)
> #2 qdr_subscribe_CT ../src/router_core/route_tables.c:633 
> (libqpid-dispatch.so+0xc5d7e)
> #3 router_core_thread ../src/router_core/router_core_thread.c:239 
> (libqpid-dispatch.so+0xc40d7)
> #4 _thread_init ../src/posix/threading.c:172 (libqpid-dispatch.so+0x8f3cf)
> #5   (libtsan.so.0+0x30f0f)
>   Previous write of size 8 at 0x7b1c06d0 by main thread (mutexes: write 
> M14):
> #0 qd_vlog_impl ../src/log.c:420 (libqpid-dispatch.so+0x791d4)
> #1 qd_log_impl ../src/log.c:456 (libqpid-dispatch.so+0x795e8)
> #2 qdr_protocol_adaptor ../src/router_core/router_core.c:1050 
> (libqpid-dispatch.so+0xc2f81)
> #3 qd_router_setup_late ../src/router_node.c:2121 
> (libqpid-dispatch.so+0xe3b03)
> #4 ffi_call_unix64  (libffi.so.7+0x7abc)
> #5 main_process ../router/src/main.c:97 (qdrouterd+0x4025ae)
> #6 main ../router/src/main.c:369 (qdrouterd+0x4032ae)
>   Location is heap block of size 104 at 0x7b1c0690 allocated by main 
> thread:
> #0 malloc  (libtsan.so.0+0x33dc1)
> #1 qd_malloc ../include/qpid/dispatch/ctools.h:229 
> (libqpid-dispatch.so+0x78763)
> #2 qd_log_source_lh ../src/log.c:367 (libqpid-dispatch.so+0x78763)
> #3 qd_log_entity ../src/log.c:545 (libqpid-dispatch.so+0x79c7e)
> #4 ffi_call_unix64  (libffi.so.7+0x7abc)
> #5 main_process ../router/src/main.c:97 (qdrouterd+0x4025ae)
> #6 main ../router/src/main.c:369 (qdrouterd+0x4032ae)
>   Mutex M14 (0x7b100300) created at:
> #0 pthread_mutex_init  (libtsan.so.0+0x4a764)
> #1 sys_mutex ../src/posix/threading.c:43 (libqpid-dispatch.so+0x8f447)
> #2 qd_python_initialize ../src/python_embedded.c:54 
> (libqpid-dispatch.so+0x91ea4)
> #3 qd_dispatch ../src/dispatch.c:111 (libqpid-dispatch.so+0x71595)
> #4 main_process ../router/src/main.c:92 (qdrouterd+0x40254d)
> #5 main ../router/src/main.c:369 (qdrouterd+0x4032ae)
>   Thread T1 (tid=14376, running) created by main thread at:
> #0 pthread_create  (libtsan.so.0+0x5cba2)
> #1 sys_thread ../src/posix/threading.c:181 (libqpid-dispatch.so+0x8f89b)
> #2 qdr_core ../src/router_core/router_core.c:122 
> (libqpid-dispatch.so+0xbd91b)
> #3 qd_router_setup_late ../src/router_node.c:2119 
> (libqpid-dispatch.so+0xe3a56)
> #4 ffi_call_unix64  (libffi.so.7+0x7abc)
> #5 main_process ../router/src/main.c:97 (qdrouterd+0x4025ae)
> #6 main ../router/src/main.c:369 (qdrouterd+0x4032ae)
> SUMMARY: ThreadSanitizer: data race ../src/log.c:420 in qd_vlog_impl
> {noformat}
> The racy operation is
> {code}
> source->severity_histogram[level_index]++;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2127) message content races between readers and writers

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2127:

Fix Version/s: (was: 1.18.0)
   1.19.0

> message content races between readers and writers
> -
>
> Key: DISPATCH-2127
> URL: https://issues.apache.org/jira/browse/DISPATCH-2127
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> TSAN complains about races between the sending and receiving threads 
> accessing the message's context fields:
>  
> content->aborted flag
> content->qd_input_holdoff
>  
> 65: WARNING: ThreadSanitizer: data race (pid=569024) 
> 65: Write of size 1 at 0x7b64000bdab4 by thread T3 (mutexes: write 
> M381533902092816192): 
> 65: #0 qd_message_receive 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/message.c:1533 
> (libqpid-dispatch.so+0x93b63) 
> 65: #1 AMQP_rx_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:466 
> (libqpid-dispatch.so+0x1233ed) 
> 65: #2 do_receive 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:227 
> (libqpid-dispatch.so+0x7a99b) 
> 65: #3 qd_container_handle_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:737 
> (libqpid-dispatch.so+0x7cf4f) 
> 65: #4 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0x130537) 
> 65: #5 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 65: #6 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #7   (libtsan.so.0+0x2d33f) 
> 65: 
> 65: Previous read of size 1 at 0x7b64000bdab4 by thread T2: 
> 65: #0 qd_message_send 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/message.c:1885 
> (libqpid-dispatch.so+0x95b5d) 
> 65: #1 CORE_link_deliver 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1985 
> (libqpid-dispatch.so+0x127f9f) 
> 65: #2 qdr_link_process_deliveries 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:178 
> (libqpid-dispatch.so+0x1045c6) 
> 65: #3 CORE_link_push 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1920 
> (libqpid-dispatch.so+0x127d00) 
> 65: #4 qdr_connection_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:414 
> (libqpid-dispatch.so+0xc4bec) 
> 65: #5 AMQP_writable_conn_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:299 
> (libqpid-dispatch.so+0x122d42) 
> 65: #6 writable_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:395 
> (libqpid-dispatch.so+0x7b2e2) 
> 65: #7 qd_container_handle_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:747 
> (libqpid-dispatch.so+0x7cfd5) 
> 65: #8 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0x130537) 
> 65: #9 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 65: #10 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #11   (libtsan.so.0+0x2d33f)
>  
> 65: == 
> 65: WARNING: ThreadSanitizer: data race (pid=569024) 
> 65: Write of size 1 at 0x7b6400057cb4 by thread T3 (mutexes: write M49320): 
> 65: #0 qd_message_receive 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/message.c:1533 
> (libqpid-dispatch.so+0x93b63) 
> 65: #1 AMQP_rx_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:466 
> (libqpid-dispatch.so+0x1233ed) 
> 65: #2 deferred_AMQP_rx_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:913 
> (libqpid-dispatch.so+0x1245cb) 
> 65: #3 invoke_deferred_calls 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:789 
> (libqpid-dispatch.so+0x12eba3) 
> 65: #4 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1046 
> (libqpid-dispatch.so+0x12ffa5) 
> 65: #5 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 65: #6 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #7   (libtsan.so.0+0x2d33f) 
> 65: 
> 65: Previous read of size 1 at 0x7b6400057cb4 by thread T2: 
> 65: #0 qd_message_send 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/message.c:1984 
> (libqpid-dispatch.so+0x95bdb) 
> 65: #1 CORE_link_deliver 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1985 
> (libqpid-dispatch.so+0x127f9f) 
> 65: #2 qdr_link_process_deliveries 
> /home/kgiusti/work/dispatc

[jira] [Updated] (DISPATCH-2096) Did not get expected Aborted_Delivery in system_tests_delivery_abort

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2096:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Did not get expected Aborted_Delivery in system_tests_delivery_abort
> 
>
> Key: DISPATCH-2096
> URL: https://issues.apache.org/jira/browse/DISPATCH-2096
> Project: Qpid Dispatch
>  Issue Type: Test
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
> https://travis-ci.com/github/jiridanek/qpid-dispatch/jobs/502247232#L5800
> {noformat}
> 44: ==
> 44: FAIL: test_02_message_route_truncated_two_routers 
> (system_tests_delivery_abort.RouterTest)
> 44: --
> 44: Traceback (most recent call last):
> 44:   File 
> "/home/travis/build/jiridanek/qpid-dispatch/tests/system_tests_delivery_abort.py",
>  line 81, in test_02_message_route_truncated_two_routers
> 44: self.assertIsNone(test.error, msg=test.error)
> 44: AssertionError: "Expected: ['Send_Short_1', 'Aborted_Delivery', '2', '2', 
> '2', '2', '2', '2', '2', '2', '2', '2', 'Send_Short_2', '3', '3', '3', '3', 
> '3', '3', '3', '3', '3', '3', 'Send_Short_3'], Actual: ['Send_Short_1', '2', 
> '2', '2', '2', '2', '2', '2', '2', '2', '2', 'Send_Short_2', '3', '3', '3', 
> '3', '3', '3', '3', '3', '3', '3', 'Send_Short_3']" is not None :
>  Expected: ['Send_Short_1', 'Aborted_Delivery', '2', '2', '2', '2', '2', '2', 
> '2', '2', '2', '2', 'Send_Short_2', '3', '3', '3', '3', '3', '3', '3', '3', 
> '3', '3', 'Send_Short_3'],
>  Actual: ['Send_Short_1', '2', '2', '2', '2', '2', '2', '2', '2', '2', '2', 
> 'Send_Short_2', '3', '3', '3', '3', '3', '3', '3', '3', '3', '3', 
> 'Send_Short_3']
> 44: 
> 44: --
> 44: Ran 7 tests in 6.095s
> 44: 
> 44: FAILED (failures=1)
> 44/74 Test #44: system_tests_delivery_abort ...***Failed  
>   6.22 sec
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-1892) http1 json aggregation does not handle large messages

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1892:

Fix Version/s: (was: 1.18.0)
   1.19.0

> http1 json aggregation does not handle large messages
> -
>
> Key: DISPATCH-1892
> URL: https://issues.apache.org/jira/browse/DISPATCH-1892
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Protocol Adaptors
> Environment: At some point above 8k the conversion of the message 
> into a python message is truncating data.
>Reporter: Gordon Sim
>Assignee: Ken Giusti
>Priority: Major
>  Labels: HTTP/1.x
> Fix For: 1.19.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-1821) Double-free in qd_entity_configure_policy on error

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1821:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Double-free in qd_entity_configure_policy on error
> --
>
> Key: DISPATCH-1821
> URL: https://issues.apache.org/jira/browse/DISPATCH-1821
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Policy Engine
>Affects Versions: 1.14.0
>Reporter: Jiri Daněk
>Assignee: Charles E. Rolke
>Priority: Trivial
>  Labels: clang-analyzer
> Fix For: 1.19.0
>
>
> As far as I can tell, this double-free is near impossible in normal operation 
> of the router. Below, it is reproduced using a test, which passes in a value 
> for that cannot be converted to a Python bool. There is no way for a 
> legitimate user to make this happen.
> Regarding a fix, I am not sure what the router should do when it detect 
> invalid configuration. Freeing qd->policy is IMO not the right response, 
> because that is normally freed in qd_dispatch_free. Printing an error and 
> carying on (that now happens for {{maxConnections < 0}}) does not seem right 
> to me either (but it's probably needed in case the config is changed through 
> remote management interface),
> {noformat}
> 2020-11-02 09:48:51.887312 +0100 ROUTER_CORE (info) In-process subscription 
> L/$management
> 2020-11-02 09:48:51.939210 +0100 ERROR (error) Python: NotImplementedError: 
> 2020-11-02 09:48:51.941666 +0100 ERROR (error) Traceback (most recent call 
> last):
>   File "test_module", line 3, in __bool__
> NotImplementedError
> =
> ==27615==ERROR: AddressSanitizer: attempting double-free on 0x60201810 in 
> thread T0:
> #0 0x7f876d5191d7 in __interceptor_free 
> (/nix/store/zhbhxp4jgalycwffildy2bwcgmrsmayk-gcc-9.2.0-lib/lib/libasan.so.5+0x10a1d7)
> #1 0x7f876cd33b95 in qd_policy_free ../src/policy.c:136
> #2 0x7f876cd347cf in qd_entity_configure_policy ../src/policy.c:178
> #3 0x4ef6a6 in _DOCTEST_ANON_FUNC_6 
> ../tests/c_unittests/test_policy.cpp:75
> #4 0x493edd in doctest::Context::run() ../tests/c_unittests/doctest.h:5849
> #5 0x4974e9 in main ../tests/c_unittests/doctest.h:5933
> #6 0x7f876b610d8a in __libc_start_main 
> (/nix/store/xg6ilb9g9zhi2zg1dpi4zcp288rhnvns-glibc-2.30/lib/libc.so.6+0x23d8a)
> #7 0x43cd99 in _start 
> (/home/jdanek/repos/qpid/qpid-dispatch/cmake-build-debug/tests/c_unittests/c_unittests+0x43cd99)
> 0x60201810 is located 0 bytes inside of 5-byte region 
> [0x60201810,0x60201815)
> freed by thread T0 here:
> #0 0x7f876d5191d7 in __interceptor_free 
> (/nix/store/zhbhxp4jgalycwffildy2bwcgmrsmayk-gcc-9.2.0-lib/lib/libasan.so.5+0x10a1d7)
> #1 0x7f876cd347c3 in qd_entity_configure_policy ../src/policy.c:177
> #2 0x4ef6a6 in _DOCTEST_ANON_FUNC_6 
> ../tests/c_unittests/test_policy.cpp:75
> #3 0x493edd in doctest::Context::run() ../tests/c_unittests/doctest.h:5849
> #4 0x4974e9 in main ../tests/c_unittests/doctest.h:5933
> #5 0x7f876b610d8a in __libc_start_main 
> (/nix/store/xg6ilb9g9zhi2zg1dpi4zcp288rhnvns-glibc-2.30/lib/libc.so.6+0x23d8a)
> previously allocated by thread T0 here:
> #0 0x7f876d4a40b5 in strdup 
> (/nix/store/zhbhxp4jgalycwffildy2bwcgmrsmayk-gcc-9.2.0-lib/lib/libasan.so.5+0x950b5)
> #1 0x7f876cec8c99 in py_string_2_c ../src/python_utils.c:35
> #2 0x7f876cce21e2 in qd_entity_get_string ../src/entity.c:49
> #3 0x7f876cce2b5f in qd_entity_opt_string ../src/entity.c:84
> #4 0x7f876cd341b0 in qd_entity_configure_policy ../src/policy.c:161
> #5 0x4ef6a6 in _DOCTEST_ANON_FUNC_6 
> ../tests/c_unittests/test_policy.cpp:75
> #6 0x493edd in doctest::Context::run() ../tests/c_unittests/doctest.h:5849
> #7 0x4974e9 in main ../tests/c_unittests/doctest.h:5933
> #8 0x7f876b610d8a in __libc_start_main 
> (/nix/store/xg6ilb9g9zhi2zg1dpi4zcp288rhnvns-glibc-2.30/lib/libc.so.6+0x23d8a)
> SUMMARY: AddressSanitizer: double-free 
> (/nix/store/zhbhxp4jgalycwffildy2bwcgmrsmayk-gcc-9.2.0-lib/lib/libasan.so.5+0x10a1d7)
>  in __interceptor_free
> ==27615==ABORTING
> Process finished with exit code 1
> {noformat}
> The test which follows is currently missing PY decrefs. 
> {noformat}
> #include 
> #include 
> #include "helpers.hpp"
> #include "qdr_doctest.h"
> extern "C" {
> #include 
> #include 
> #include 
> #include 
> #include 
> #include 
> #include 
> }
> TEST_CASE("policy") {
> std::thread([]() {
> WithNoMemoryLeaks leaks{};
> QDR   qdr;
> qdr.start();
> qdr.wait();
> {
> auto qd = qdr.qd;
> PyObject *module = Py_CompileString(
> // language: Python
> 

[jira] [Updated] (DISPATCH-1745) Link routing does not propagate link properties

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1745:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Link routing does not propagate link properties
> ---
>
> Key: DISPATCH-1745
> URL: https://issues.apache.org/jira/browse/DISPATCH-1745
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.12.0
>Reporter: Ken Giusti
>Priority: Major
> Fix For: 1.19.0
>
>
> This requires proton to provide access to link properties.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-1910) Edge router asserts when interior router connection denied by policy

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1910:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Edge router asserts when interior router connection denied by policy
> 
>
> Key: DISPATCH-1910
> URL: https://issues.apache.org/jira/browse/DISPATCH-1910
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.14.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.19.0
>
> Attachments: B.conf, EB.conf
>
>
> Running routers with the attached configurations causes the edge router to 
> assert.
> {code:java}
> > qdrouterd -c B.conf &
> [1] 99723
> > qdrouterd -c EB.conf
> qdrouterd: 
> /home/chug/git/qpid-dispatch/src/router_core/modules/edge_router/addr_proxy.c:318:
>  on_conn_event: Assertion `addr->edge_inlink == 0' failed.
> Aborted (core dumped)
> {code}
> This could be a case of an overly aggressive assert. Removing the assert 
> requires analysis of possible structure leaks. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2122) Data race on alloc pool descriptor initialization

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2122:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Data race on alloc pool descriptor initialization
> -
>
> Key: DISPATCH-2122
> URL: https://issues.apache.org/jira/browse/DISPATCH-2122
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: michael goulish
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> 65: WARNING: ThreadSanitizer: data race (pid=566240) 
> 65: Read of size 4 at 0x7f67599ae2c0 by thread T4: 
> 65: #0 qd_alloc 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:324 
> (libqpid-dispatch.so+0x6a1f2) 
> 65: #1 new_qd_link_ref_t 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:76 
> (libqpid-dispatch.so+0x79ae5) 
> 65: #2 qdr_node_connect_deliveries 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:67 
> (libqpid-dispatch.so+0x121a78) 
> 65: #3 CORE_link_deliver 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1971 
> (libqpid-dispatch.so+0x127f1c) 
> 65: #4 qdr_link_process_deliveries 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:178 
> (libqpid-dispatch.so+0x1045c6) 
> 65: #5 CORE_link_push 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1920 
> (libqpid-dispatch.so+0x127d00) 
> 65: #6 qdr_connection_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:414 
> (libqpid-dispatch.so+0xc4bec) 
> 65: #7 AMQP_writable_conn_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:299 
> (libqpid-dispatch.so+0x122d42) 
> 65: #8 writable_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:395 
> (libqpid-dispatch.so+0x7b2e2) 
> 65: #9 qd_container_handle_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:747 
> (libqpid-dispatch.so+0x7cfd5) 
> 65: #10 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0x130537) 
> 65: #11 thread_run 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 65: #12 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #13   (libtsan.so.0+0x2d33f) 
> 65: 
> 65: Previous write of size 4 at 0x7f67599ae2c0 by thread T2 (mutexes: write 
> M10): 
> 65: #0 qd_alloc_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:307 
> (libqpid-dispatch.so+0x6a14b) 
> 65: #1 qd_alloc 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:325 
> (libqpid-dispatch.so+0x6a20b) 
> 65: #2 new_qd_link_ref_t 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:76 
> (libqpid-dispatch.so+0x79ae5) 
> 65: #3 qdr_node_connect_deliveries 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:67 
> (libqpid-dispatch.so+0x121a78) 
> 65: #4 CORE_link_deliver 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1971 
> (libqpid-dispatch.so+0x127f1c) 
> 65: #5 qdr_link_process_deliveries 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:178 
> (libqpid-dispatch.so+0x1045c6) 
> 65: #6 CORE_link_push 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1920 
> (libqpid-dispatch.so+0x127d00) 
> 65: #7 qdr_connection_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:414 
> (libqpid-dispatch.so+0xc4bec) 
> 65: #8 AMQP_writable_conn_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:299 
> (libqpid-dispatch.so+0x122d42) 
> 65: #9 writable_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:395 
> (libqpid-dispatch.so+0x7b2e2) 
> 65: #10 qd_container_handle_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:747 
> (libqpid-dispatch.so+0x7cfd5) 
> 65: #11 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0x130537) 
> 65: #12 thread_run 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 65: #13 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #14   (libtsan.so.0+0x2d33f)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2123) qd_entity_refresh_allocator race in alloc_pool.c

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2123:

Fix Version/s: (was: 1.18.0)
   1.19.0

> qd_entity_refresh_allocator race in alloc_pool.c
> 
>
> Key: DISPATCH-2123
> URL: https://issues.apache.org/jira/browse/DISPATCH-2123
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.19.0
>
>
> qd_entity_refresh_allocator walks all the descriptors reading their contents. 
>  This can happen while the descriptors are being written to during normal 
> pool operations.
>  
> Example:
>  
> 5: WARNING: ThreadSanitizer: data race (pid=566878) 
> 65: Read of size 8 at 0x7b0c0d10 by main thread (mutexes: write M13, 
> write M286, write M9): 
> 65: #0 qd_entity_refresh_allocator 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:700 
> (libqpid-dispatch.so+0x6cdec) 
> 65: #1 ffi_call_unix64  (libffi.so.6+0x6aef) 
> 65: #2 qdr_forward_on_message 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/forwarder.c:336 
> (libqpid-dispatch.so+0xe4ff5) 
> 65: #3 qdr_general_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:929 
> (libqpid-dispatch.so+0xf83f6) 
> 65: #4 qd_timer_visit 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/timer.c:317 
> (libqpid-dispatch.so+0x135b52) 
> 65: #5 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1006 
> (libqpid-dispatch.so+0x12fc8d) 
> 65: #6 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 65: #7 qd_server_run 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1501 
> (libqpid-dispatch.so+0x1328de) 
> 65: #8 main_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:115 
> (qdrouterd+0x40271a) 
> 65: #9 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 
> (qdrouterd+0x403557) 
> 65: 
> 65: Previous write of size 8 at 0x7b0c0d10 by thread T1 (mutexes: write 
> M305): 
> 65: #0 qd_dealloc 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:494 
> (libqpid-dispatch.so+0x6bacd) 
> 65: #1 free_qdr_action_t 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:33
>  (libqpid-dispatch.so+0xf9a35) 
> 65: #2 router_core_thread 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:240
>  (libqpid-dispatch.so+0xfb2ba) 
> 65: #3 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #4   (libtsan.so.0+0x2d33f)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2135) data race accessing Q2 holdoff state

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2135:

Fix Version/s: (was: 1.18.0)
   1.19.0

> data race accessing Q2 holdoff state
> 
>
> Key: DISPATCH-2135
> URL: https://issues.apache.org/jira/browse/DISPATCH-2135
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> qd_message_Q2_holdoff_disable() modifies the disable_q2_holdoff flag without 
> holding the message content lock.  In the below trace the holdoff is being 
> disabled by the timer thread while being read by an I/O thread:
>  
> 74: WARNING: ThreadSanitizer: data race (pid=643055) 
> 74: Write of size 1 at 0x7b64000658b5 by thread T2: 
> 74: #0 qd_message_Q2_holdoff_disable 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/message.c:2876 
> (libqpid-dispatch.so+0x9a2bc) 
> 74: #1 qdr_tcp_deliver 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1405 
> (libqpid-dispatch.so+0x65f91) 
> 74: #2 qdr_link_process_deliveries 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:178 
> (libqpid-dispatch.so+0x1045c6) 
> 74: #3 qdr_tcp_push 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1392 
> (libqpid-dispatch.so+0x65e9b) 
> 74: #4 qdr_connection_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:414 
> (libqpid-dispatch.so+0xc4bec) 
> 74: #5 on_activate 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:155 
> (libqpid-dispatch.so+0x5e251) 
> 74: #6 qd_timer_visit 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/timer.c:317 
> (libqpid-dispatch.so+0x135b52) 
> 74: #7 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1006 
> (libqpid-dispatch.so+0x12fc8d) 
> 74: #8 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 74: #9 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 74: #10   (libtsan.so.0+0x2d33f) 
> 74: 
> 74: Previous read of size 1 at 0x7b64000658b5 by thread T3 (mutexes: write 
> M2644): 
> 74: #0 qd_message_Q2_holdoff_should_block 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/message.c:2885 
> (libqpid-dispatch.so+0x9a327) 
> 74: #1 qd_message_extend 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/message.c:2400 
> (libqpid-dispatch.so+0x97eda) 
> 74: #2 qd_message_stream_data_append 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/message.c:2965 
> (libqpid-dispatch.so+0x9a7ae) 
> 74: #3 handle_incoming 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:393 
> (libqpid-dispatch.so+0x5fb17) 
> 74: #4 handle_connection_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:850 
> (libqpid-dispatch.so+0x6232c) 
> 74: #5 handle_event_with_context 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:802 
> (libqpid-dispatch.so+0x12ecb6) 
> 74: #6 do_handle_raw_connection_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:808 
> (libqpid-dispatch.so+0x12ed08) 
> 74: #7 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1089 
> (libqpid-dispatch.so+0x1304e6) 
> 74: #8 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 74: #9 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 74: #10   (libtsan.so.0+0x2d33f)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2128) delivery_tracker core process walks link->undelivered unlocked

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2128:

Fix Version/s: (was: 1.18.0)
   1.19.0

> delivery_tracker core process walks link->undelivered unlocked
> --
>
> Key: DISPATCH-2128
> URL: https://issues.apache.org/jira/browse/DISPATCH-2128
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> While core thread walks the qdr_link_t->undelivered list, the I/O thread can 
> modify it:
>  
> 5: WARNING: ThreadSanitizer: data race (pid=569945) 
> 65: Write of size 8 at 0x7b5800066158 by thread T3 (mutexes: write M380): 
> 65: #0 qdr_link_process_deliveries 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:212 
> (libqpid-dispatch.so+0x104875) 
> 65: #1 CORE_link_push 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1920 
> (libqpid-dispatch.so+0x127d00) 
> 65: #2 qdr_connection_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:414 
> (libqpid-dispatch.so+0xc4bec) 
> 65: #3 AMQP_writable_conn_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:299 
> (libqpid-dispatch.so+0x122d42) 
> 65: #4 writable_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:395 
> (libqpid-dispatch.so+0x7b2e2) 
> 65: #5 qd_container_handle_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:747 
> (libqpid-dispatch.so+0x7cfd5) 
> 65: #6 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0x130537) 
> 65: #7 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 65: #8 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #9   (libtsan.so.0+0x2d33f) 
> 65: 
> 65: Previous read of size 8 at 0x7b5800066158 by thread T1: 
> 65: #0 process_link_CT 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/modules/stuck_delivery_detection/delivery_tracker.c:64
>  (libq\
> pid-dispatch.so+0x11b745) 
> 65: #1 action_handler_CT 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/modules/stuck_delivery_detection/delivery_tracker.c:115
>  (l\
> ibqpid-dispatch.so+0x11bbe8) 
> 65: #2 router_core_process_background_action_LH 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:192
>  (libqpid-d\
> ispatch.so+0xfadfd) 
> 65: #3 router_core_thread 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:220
>  (libqpid-dispatch.so+0xfaf4b) 
> 65: #4 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #5   (libtsan.so.0+0x2d33f)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2126) qdr_delivery_t->settled flag race

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2126:

Fix Version/s: (was: 1.18.0)
   1.19.0

> qdr_delivery_t->settled flag race
> -
>
> Key: DISPATCH-2126
> URL: https://issues.apache.org/jira/browse/DISPATCH-2126
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> I/O thread reads the qdr_delivery_t->settled flag while calling the 
> delivery_update_handler, while core thread is updating it while processing 
> multicast.
> {noformat}
> 5: WARNING: ThreadSanitizer: data race (pid=568299) 
> 65: Read of size 1 at 0x7b58131c by thread T4: 
> 65: #0 qdr_connection_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:403 
> (libqpid-dispatch.so+0xc4a30) 
> 65: #1 AMQP_writable_conn_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:299 
> (libqpid-dispatch.so+0x122d42) 
> 65: #2 writable_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:395 
> (libqpid-dispatch.so+0x7b2e2) 
> 65: #3 qd_container_handle_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:747 
> (libqpid-dispatch.so+0x7cfd5) 
> 65: #4 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0x130537) 
> 65: #5 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 65: #6 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #7   (libtsan.so.0+0x2d33f) 
> 65: 
> 65: Previous write of size 1 at 0x7b58131c by thread T1: 
> 65: #0 qdr_delivery_mcast_inbound_update_CT 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c:853 
> (libqpid-dispatch.so+0xd\
> 97bb) 
> 65: #1 qdr_update_delivery_CT 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c:671 
> (libqpid-dispatch.so+0xd8f22) 
> 65: #2 router_core_thread 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239
>  (libqpid-dispatch.so+0xfb2ae) 
> 65: #3 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #4   (libtsan.so.0+0x2d33f) 
> 65: 
> 65: Location is heap block of size 512 at 0x7b581200 allocated by thread 
> T2: 
> 65: #0 posix_memalign  (libtsan.so.0+0x3061d) 
> 65: #1 qd_alloc 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:396 
> (libqpid-dispatch.so+0x6ab9c) 
> 65: #2 new_qdr_delivery_t 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c:24 
> (libqpid-dispatch.so+0xd5ddd) 
> 65: #3 qdr_link_deliver 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:47 
> (libqpid-dispatch.so+0x1038d9) 
> 65: #4 AMQP_rx_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:868 
> (libqpid-dispatch.so+0x124406) 
> 65: #5 do_receive 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:227 
> (libqpid-dispatch.so+0x7a99b) 
> 65: #6 qd_container_handle_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:737 
> (libqpid-dispatch.so+0x7cf4f) 
> 65: #7 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0x130537) 
> 65: #8 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 65: #9 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #10   (libtsan.so.0+0x2d33f)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2124) qdr_link_t->drain_mode flag race

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2124:

Fix Version/s: (was: 1.18.0)
   1.19.0

> qdr_link_t->drain_mode flag race
> 
>
> Key: DISPATCH-2124
> URL: https://issues.apache.org/jira/browse/DISPATCH-2124
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> Read/write race between I/O and Core threads accessing qdr_link_t->drain_mode:
> {noformat}
> 65: WARNING: ThreadSanitizer: data race (pid=567321) 
> 65: Write of size 1 at 0x7b58000529f8 by thread T1: 
> 65: #0 qdr_link_flow_CT 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:416 
> (libqpid-dispatch.so+0x106190) 
> 65: #1 router_core_thread 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239
>  (libqpid-dispatch.so+0xfb2ae) 
> 65: #2 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #3   (libtsan.so.0+0x2d33f) 
> 65: 
> 65: Previous read of size 1 at 0x7b58000529f8 by main thread: 
> 65: #0 qdr_link_flow 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:348 
> (libqpid-dispatch.so+0x105d52) 
> 65: #1 AMQP_link_flow_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1057 
> (libqpid-dispatch.so+0x124aaf) 
> 65: #2 qd_container_handle_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:729 
> (libqpid-dispatch.so+0x7cf01) 
> 65: #3 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0x130537) 
> 65: #4 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 65: #5 qd_server_run 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1501 
> (libqpid-dispatch.so+0x1328de) 
> 65: #6 main_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:115 
> (qdrouterd+0x40271a) 
> 65: #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 
> (qdrouterd+0x403557)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-1967) TCP adaptor connections not counted against policy global count

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1967:

Fix Version/s: (was: 1.18.0)
   1.19.0

> TCP adaptor connections not counted against policy global count
> ---
>
> Key: DISPATCH-1967
> URL: https://issues.apache.org/jira/browse/DISPATCH-1967
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Policy Engine, Protocol Adaptors
>Affects Versions: 1.15.0
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.19.0
>
>
> After many thousand TCP connections the router Policy Status shows 
> _Connections Processed = 1_. That connection is the management connection 
> that read the count.
> Adaptor connections must be counted by policy and subjected to global count 
> limits.
> This same problem probably exists in the other protocol adaptors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-1891) http1 multicast does not handle chunked content

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1891:

Fix Version/s: (was: 1.18.0)
   1.19.0

> http1 multicast does not handle chunked content
> ---
>
> Key: DISPATCH-1891
> URL: https://issues.apache.org/jira/browse/DISPATCH-1891
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Protocol Adaptors
>Reporter: Gordon Sim
>Assignee: Ken Giusti
>Priority: Major
>  Labels: HTTP/1.x
> Fix For: 1.19.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2078) system_tests_authz_service_plugin mysteriously broken on GitHub Actions CI

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2078:

Fix Version/s: (was: 1.18.0)
   Backlog

> system_tests_authz_service_plugin mysteriously broken on GitHub Actions CI
> --
>
> Key: DISPATCH-2078
> URL: https://issues.apache.org/jira/browse/DISPATCH-2078
> Project: Qpid Dispatch
>  Issue Type: Test
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: Backlog
>
>
> https://github.com/apache/qpid-dispatch/runs/2426474351#step:9:2155
> {noformat}
> 43: 
> 43: test_authorized 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzTest) ... FAIL
> 43: test_dynamic_source_anonymous_sender 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzTest) ... FAIL
> 43: test_unauthorized 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzTest) ... FAIL
> 43: test_unauthorized_anonymous_sender_target 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzTest) ... FAIL
> 43: test_wildcard 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzTest) ... FAIL
> 43: 
> 43: Router router output file:
> 43: 
> 43: 2021-04-24 11:12:31.013358 + AGENT (warning) Attribute 
> 'saslConfigPath' of entity 'router' has been deprecated. Use 'saslConfigDir' 
> instead
> 43: -
> 43: Suppressions used:
> 43:   count  bytes template
> 43:   1  7 ^load_server_config$
> 43:   1 32 ^qd_policy_c_counts_alloc$
> 43:   1 56 qdr_core_subscribe
> 43:  12   6656 ^_PyObject_Realloc
> 43: 550 870562 ^PyObject_Malloc$
> 43:   1 32 ^PyThread_allocate_lock$
> 43:   4   9897 ^PyMem_Malloc$
> 43:   1856 ^_PyObject_GC_Resize$
> 43: -
> 43: 
> 43: 
> 43: 
> 43: 
> 43: ==
> 43: FAIL: test_authorized 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzDeprecatedTest)
> 43: --
> 43: Traceback (most recent call last):
> 43:   File 
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_test.py",
>  line 924, in wrap
> 43: return f(*args, **kwargs)
> 43:   File 
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_authz_service_plugin.py",
>  line 97, in test_authorized
> 43: self.assertEqual(1, client.sent)
> 43: AssertionError: 1 != 0
> 43: 
> 43: ==
> 43: FAIL: test_dynamic_source_anonymous_sender 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzDeprecatedTest)
> 43: --
> 43: Traceback (most recent call last):
> 43:   File 
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_test.py",
>  line 924, in wrap
> 43: return f(*args, **kwargs)
> 43:   File 
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_authz_service_plugin.py",
>  line 129, in test_dynamic_source_anonymous_sender
> 43: self.assertEqual(1, client.accepted)
> 43: AssertionError: 1 != 0
> 43: 
> 43: ==
> 43: FAIL: test_unauthorized 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzDeprecatedTest)
> 43: --
> 43: Traceback (most recent call last):
> 43:   File 
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_test.py",
>  line 924, in wrap
> 43: return f(*args, **kwargs)
> 43:   File 
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_authz_service_plugin.py",
>  line 109, in test_unauthorized
> 43: self.assertEqual(2, len(client.errors))
> 43: AssertionError: 2 != 0
> 43: 
> 43: ==
> 43: FAIL: test_unauthorized_anonymous_sender_target 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzDeprecatedTest)
> 43: --
> 43: Traceback (most recent call last):
> 43:   File 
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_test.py",
>  line 924, in wrap
> 43: return f(*args, **kwargs)
> 43:   File 
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_authz_service_plugin.py",
>  line 140, in test_unauthorized_anonymous_sender_target
> 43: self.assertEqual(1, client.r

[jira] [Updated] (DISPATCH-1978) TCP adaptor wake-after-close fix needs a self test

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1978:

Fix Version/s: (was: 1.18.0)
   1.19.0

> TCP adaptor wake-after-close fix needs a self test
> --
>
> Key: DISPATCH-1978
> URL: https://issues.apache.org/jira/browse/DISPATCH-1978
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.19.0
>
>
> Code for DISPATCH-1968 in commit 5d27cfa has no self test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2138) qdr_link_t->detach_received flag race

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2138:

Fix Version/s: (was: 1.18.0)
   1.19.0

> qdr_link_t->detach_received flag race
> -
>
> Key: DISPATCH-2138
> URL: https://issues.apache.org/jira/browse/DISPATCH-2138
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> Race between I/O thread and Core over reading/writing the 
> qdr_link_t->detach_received flag:
>  
> -DCMAKE_BUILD_TYPE=RelWithDebInfo
> -DRUNTIME_CHECK=tsan
> ctest -V -R system_tests_one_router:
> 21: WARNING: ThreadSanitizer: data race (pid=14179)
> 21: Read of size 1 at 0x7b540012c172 by thread T3 (mutexes: write 
> M548167088305615232):
> 21: #0 qdr_connection_process 
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:441 
> (libqpid-dispatch.so+0xa81a7)
> 21: #1 AMQP_writable_conn_handler 
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:299 
> (libqpid-dispatch.so+0xe3e41)
> 21: #2 writable_handler 
> /home/travis/build/apache/qpid-dispatch/src/container.c:395 
> (libqpid-dispatch.so+0x76264)
> 21: #3 qd_container_handle_event 
> /home/travis/build/apache/qpid-dispatch/src/container.c:747 
> (libqpid-dispatch.so+0x76264)
> 21: #4 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0xed0f1)
> 21: #5 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0xf0a9c)
> 21: #6 _thread_init 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0x96f56)
> 21: #7   (libtsan.so.0+0x2d1af)
> 21: Previous write of size 1 at 0x7b540012c172 by thread T1:
> 21: #0 qdr_link_inbound_detach_CT 
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1980 
> (libqpid-dispatch.so+0xad1eb)
> 21: #1 router_core_thread 
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:239
>  (libqpid-dispatch.so+0xca685)
> 21: #2 _thread_init 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0x96f56)
> 21: #3   (libtsan.so.0+0x2d1af)
> 21: Mutex M548167088305615232 is already destroyed.
> 21: SUMMARY: ThreadSanitizer: data race 
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:441 in 
> qdr_connection_process



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2134) qdr_link_process_initial_delivery_CT race clearing link pointer

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2134:

Fix Version/s: (was: 1.18.0)
   1.19.0

> qdr_link_process_initial_delivery_CT race clearing link pointer
> ---
>
> Key: DISPATCH-2134
> URL: https://issues.apache.org/jira/browse/DISPATCH-2134
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> TSAN detects a race between an I/O thread clearing a deliveries' safe pointer 
> to its owning link while the core thread is setting the same safe pointer
>  
> {noformat}
> 70: WARNING: ThreadSanitizer: data race (pid=644088) 
> 70: Write of size 8 at 0x7b50feb0 by thread T1: 
> 70: #0 qd_alloc_set_safe_ptr 
> /home/kgiusti/work/dispatch/qpid-dispatch/include/qpid/dispatch/alloc_pool.h:96
>  (libqpid-dispatch.so+0xeed90) 
> 70: #1 set_safe_ptr_qdr_link_t 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:35 
> (libqpid-dispatch.so+0xef449) 
> 70: #2 qdr_link_process_initial_delivery_CT 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:1678 
> (libqpid-dispatch.so+0xcccbe) 
> 70: #3 qdr_link_inbound_first_attach_CT 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:1801 
> (libqpid-dispatch.so+0xcd6cb) 
> 70: #4 router_core_thread 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239
>  (libqpid-dispatch.so+0xfb2ae) 
> 70: #5 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 70: #6   (libtsan.so.0+0x2d33f) 
> 70: 
> 70: Previous write of size 8 at 0x7b50feb0 by thread T3 (mutexes: write 
> M333): 
> 70: #0 qd_nullify_safe_ptr 
> /home/kgiusti/work/dispatch/qpid-dispatch/include/qpid/dispatch/alloc_pool.h:91
>  (libqpid-dispatch.so+0x103843) 
> 70: #1 qdr_link_process_deliveries 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:239 
> (libqpid-dispatch.so+0x105033) 
> 70: #2 qdr_http_push 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:1607
>  (libqpid-dispatch.so+0x147bfd) 
> 70: #3 qdr_connection_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:414 
> (libqpid-dispatch.so+0xc4bec) 
> 70: #4 handle_connection_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2435
>  (libqpid-dispatch.so+0x14ee55) 
> 70: #5 handle_event_with_context 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:802 
> (libqpid-dispatch.so+0x12ecb6) 
> 70: #6 do_handle_raw_connection_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:808 
> (libqpid-dispatch.so+0x12ed08) 
> 70: #7 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1089 
> (libqpid-dispatch.so+0x1304e6) 
> 70: #8 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 70: #9 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 70: #10   (libtsan.so.0+0x2d33f)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2057) TSAN data race from qdr_core_unbind_address_link_CT in system_tests_edge_router

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2057:

Fix Version/s: (was: 1.18.0)
   1.19.0

> TSAN data race from qdr_core_unbind_address_link_CT in 
> system_tests_edge_router
> ---
>
> Key: DISPATCH-2057
> URL: https://issues.apache.org/jira/browse/DISPATCH-2057
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/498899790#L6312
> {noformat}
> 54: ==
> 54: WARNING: ThreadSanitizer: data race (pid=16195)
> 54:   Write of size 8 at 0x7b54000ae908 by thread T1:
> 54: #0 qdr_core_unbind_address_link_CT 
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:685 
> (libqpid-dispatch.so+0xc4a83)
> 54: #1 del_inlink 
> /home/travis/build/apache/qpid-dispatch/src/router_core/modules/edge_router/addr_proxy.c:174
>  (libqpid-dispatch.so+0xd2af0)
> 54: #2 on_addr_event 
> /home/travis/build/apache/qpid-dispatch/src/router_core/modules/edge_router/addr_proxy.c:426
>  (libqpid-dispatch.so+0xd3102)
> 54: #3 qdrc_event_addr_raise 
> /home/travis/build/apache/qpid-dispatch/src/router_core/core_events.c:125 
> (libqpid-dispatch.so+0xace11)
> 54: #4 qdr_core_unbind_address_link_CT 
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:697 
> (libqpid-dispatch.so+0xc4bf7)
> 54: #5 qdr_link_inbound_detach_CT 
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:2070 
> (libqpid-dispatch.so+0xab5b4)
> 54: #6 router_core_thread 
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:240
>  (libqpid-dispatch.so+0xc81e5)
> 54: #7 _thread_init 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:174 
> (libqpid-dispatch.so+0x94ea6)
> 54: #8   (libtsan.so.0+0x2d1af)
> 54: 
> 54:   Previous read of size 8 at 0x7b54000ae908 by thread T4:
> 54: #0 qdr_link_is_anonymous 
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:526 
> (libqpid-dispatch.so+0xa68e2)
> 54: #1 AMQP_rx_handler 
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:640 
> (libqpid-dispatch.so+0xe372b)
> 54: #2 do_receive 
> /home/travis/build/apache/qpid-dispatch/src/container.c:227 
> (libqpid-dispatch.so+0x74584)
> 54: #3 qd_container_handle_event 
> /home/travis/build/apache/qpid-dispatch/src/container.c:737 
> (libqpid-dispatch.so+0x74584)
> 54: #4 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1097 
> (libqpid-dispatch.so+0xea531)
> 54: #5 thread_run 
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122 
> (libqpid-dispatch.so+0xec41c)
> 54: #6 _thread_init 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:174 
> (libqpid-dispatch.so+0x94ea6)
> 54: #7   (libtsan.so.0+0x2d1af)
> 54: 
> 54:   Location is heap block of size 576 at 0x7b54000ae880 allocated by 
> thread T4:
> 54: #0 posix_memalign  (libtsan.so.0+0x3048d)
> 54: #1 qd_alloc 
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396 
> (libqpid-dispatch.so+0x5f5f4)
> 54: #2 new_qdr_link_t 
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:33 
> (libqpid-dispatch.so+0xc17e5)
> 54: #3 qdr_link_first_attach 
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:581 
> (libqpid-dispatch.so+0xa6acb)
> 54: #4 AMQP_incoming_link_handler 
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:964 
> (libqpid-dispatch.so+0xe19d2)
> 54: #5 qd_container_handle_event 
> /home/travis/build/apache/qpid-dispatch/src/container.c:729 
> (libqpid-dispatch.so+0x74078)
> 54: #6 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1097 
> (libqpid-dispatch.so+0xea531)
> 54: #7 thread_run 
> /home/travis/build/apache/qpid-dispatch/src/server.c:1122 
> (libqpid-dispatch.so+0xec398)
> 54: #8 _thread_init 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:174 
> (libqpid-dispatch.so+0x94ea6)
> 54: #9   (libtsan.so.0+0x2d1af)
> 54: 
> 54:   Thread T1 (tid=16197, running) created by main thread at:
> 54: #0 pthread_create  (libtsan.so.0+0x5ea99)
> 54: #1 sys_thread 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:183 
> (libqpid-dispatch.so+0x95462)
> 54: #2 qdr_core 
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:122 
> (libqpid-dispatch.so+0xc295e)
> 54: #3 qd_router_setup_late 
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2111 
> (libqpid-dispatch.so+0xe5

[jira] [Updated] (DISPATCH-2130) python lock inversion deadlock

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2130:

Fix Version/s: (was: 1.18.0)
   1.19.0

> python lock inversion deadlock
> --
>
> Key: DISPATCH-2130
> URL: https://issues.apache.org/jira/browse/DISPATCH-2130
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>  Labels: deadlock, tsan
> Fix For: 1.19.0
>
>
> The python lock is a top-level lock: no other locks should be held when 
> taking the python lock.
> The python lock is held for as long as the thread is running in python.  The 
> python code often calls back into C, which takes locks as necessary (timers, 
> server lock, whatever).
> Debug code should be added to enforce this.
> TSAN deadlock trace:
> 21: Mutex M253 acquired here while holding mutex M13 in main thread: 
> 21: #0 pthread_mutex_lock  (libtsan.so.0+0x528ac) 
> lock> 
> 21: #1 sys_mutex_lock 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57 
> (libqpid-dispatch.so+0xacee5) 
> 21: #2 qd_timer_schedule 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/timer.c:216 
> (libqpid-dispatch.so+0x1350fe) 
> 21: #3 qd_router_setup_late 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:2144 
> (libqpid-dispatch.so+0x128656) 
> 21: #4 ffi_call_unix64  (libffi.so.6+0x6aef) 
> 21: #5 main_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:97 
> (qdrouterd+0x402697) 
> 21: #6 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 
> (qdrouterd+0x403557) 
> 21: 
> 21: Mutex M13 previously acquired by the same thread here: 
> 21: #0 pthread_mutex_lock  (libtsan.so.0+0x528ac) 
>  
> 21: #1 sys_mutex_lock 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57 
> (libqpid-dispatch.so+0xacee5) 
> 21: #2 qd_python_lock 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:902 
> (libqpid-dispatch.so+0xb070e) 
> 21: #3 qd_dispatch_load_config 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/dispatch.c:129 
> (libqpid-dispatch.so+0x80ad2) 
> 21: #4 main_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:97 
> (qdrouterd+0x402697) 
> 21: #5 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 
> (qdrouterd+0x403557) 
>  
> --- 
>  
> 21: Mutex M13 acquired here while holding mutex M253 in thread T4: 
> 21: #0 pthread_mutex_lock  (libtsan.so.0+0x528ac) 
>  
> 21: #1 sys_mutex_lock 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57 
> (libqpid-dispatch.so+0xacee5) 
> 21: #2 qd_python_lock 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:902 
> (libqpid-dispatch.so+0xb070e) 
> 21: #3 qd_policy_socket_close 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/policy.c:296 
> (libqpid-dispatch.so+0xa3a8e) 
> 21: #4 qd_connection_free 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:925 
> (libqpid-dispatch.so+0x12f703) 
> 21: #5 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1127 
> (libqpid-dispatch.so+0x13069e) 
> 21: #6 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 21: #7   (libtsan.so.0+0x2d33f) 
> 21: 
> 21: Mutex M253 previously acquired by the same thread here: 
> 21: #0 pthread_mutex_lock  (libtsan.so.0+0x528ac) 
> lock> 
> 21: #1 sys_mutex_lock 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:57 
> (libqpid-dispatch.so+0xacee5) 
> 21: #2 qd_connection_free 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:920 
> (libqpid-dispatch.so+0x12f48f) 
> 21: #3 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1127 
> (libqpid-dispatch.so+0x13069e) 
> 21: #4 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 21: #5   (libtsan.so.0+0x2d33f)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2143) race getting/setting qdr_delivery_t->disposition

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2143:

Fix Version/s: (was: 1.18.0)
   1.19.0

> race getting/setting qdr_delivery_t->disposition
> 
>
> Key: DISPATCH-2143
> URL: https://issues.apache.org/jira/browse/DISPATCH-2143
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> 62: test_999_check_for_leaks (system_tests_multicast.MulticastLinearTest) ... 
> ok
> 62: WARNING: ThreadSanitizer: data race (pid=16451)
> 62: Write of size 8 at 0x7b4400019568 by thread T1:
> 62: #0 qdr_delivery_mcast_outbound_disposition_CT 
> /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:989 
> (libqpid-dispatch.so+0xb59ef)
> 62: #1 qdr_delivery_mcast_outbound_update_CT 
> /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:1015 
> (libqpid-dispatch.so+0xb59ef)
> 62: #2 qdr_update_delivery_CT 
> /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:680 
> (libqpid-dispatch.so+0xb6475)
> 62: #3 router_core_thread 
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:239
>  (libqpid-dispatch.so+0xca645)
> 62: #4 _thread_init 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0x96f16)
> 62: #5   (libtsan.so.0+0x2d1af)
> 62: Previous read of size 8 at 0x7b4400019568 by thread T2:
> 62: #0 qdr_connection_process 
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:403 
> (libqpid-dispatch.so+0xa7fbd)
> 62: #1 AMQP_writable_conn_handler 
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:299 
> (libqpid-dispatch.so+0xe3e01)
> 62: #2 writable_handler 
> /home/travis/build/apache/qpid-dispatch/src/container.c:395 
> (libqpid-dispatch.so+0x76264)
> 62: #3 qd_container_handle_event 
> /home/travis/build/apache/qpid-dispatch/src/container.c:747 
> (libqpid-dispatch.so+0x76264)
> 62: #4 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0xed0b1)
> 62: #5 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0xf0a5c)
> 62: #6 _thread_init 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0x96f16)
> 62: #7   (libtsan.so.0+0x2d1af)
> 62: Location is heap block of size 320 at 0x7b4400019500 allocated by thread 
> T2:
> 62: #0 posix_memalign  (libtsan.so.0+0x3048d)
> 62: #1 qd_alloc /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396 
> (libqpid-dispatch.so+0x614c4)
> 62: #2 new_qdr_delivery_t 
> /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:24 
> (libqpid-dispatch.so+0xb25e5)
> 62: #3 qdr_link_deliver_to 
> /home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:82 
> (libqpid-dispatch.so+0xd046d)
> 62: #4 AMQP_rx_handler 
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:818 
> (libqpid-dispatch.so+0xe62df)
> 62: #5 do_receive /home/travis/build/apache/qpid-dispatch/src/container.c:227 
> (libqpid-dispatch.so+0x76574)
> 62: #6 qd_container_handle_event 
> /home/travis/build/apache/qpid-dispatch/src/container.c:737 
> (libqpid-dispatch.so+0x76574)
> 62: #7 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0xed0b1)
> 62: #8 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0xf0a5c)
> 62: #9 _thread_init 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0x96f16)
> 62: #10   (libtsan.so.0+0x2d1af)
> 62: Thread T1 (tid=16453, running) created by main thread at:
> 62: #0 pthread_create  (libtsan.so.0+0x5ea99)
> 62: #1 sys_thread 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 
> (libqpid-dispatch.so+0x974d2)
> 62: #2 qdr_core 
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:124 
> (libqpid-dispatch.so+0xc4bee)
> 62: #3 qd_router_setup_late 
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2123 
> (libqpid-dispatch.so+0xe865c)
> 62: #4   (libffi.so.7+0x6ff4)
> 62: #5 main_process 
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:97 
> (qdrouterd+0x2bb2)
> 62: #6 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 
> (qdrouterd+0x2882)
> 62: Thread T2 (tid=16454, running) created by main thread at:
> 62: #0 pthread_create  (libtsan.so.0+0x5ea99)
> 62: #1 sys_thread 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 
> (libqpid-dispatch.so+0x974d2)
> 62: #2 qd_server_run 
> /home/travis/build/apache/qpid-dispatch/src/

[jira] [Updated] (DISPATCH-2140) race setting/reading qdr_connection_t context

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2140:

Fix Version/s: (was: 1.18.0)
   1.19.0

> race setting/reading qdr_connection_t context
> -
>
> Key: DISPATCH-2140
> URL: https://issues.apache.org/jira/browse/DISPATCH-2140
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> 69: test_008_put_10 (system_tests_http1_over_tcp.Http1OverTcpOneRouterTest) 
> ... ok
> 69: WARNING: ThreadSanitizer: data race (pid=17014)
> 69: Read of size 8 at 0x7b5400089a10 by thread T1:
> 69: #0 qdr_connection_get_context 
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:237 
> (libqpid-dispatch.so+0xa7587)
> 69: #1 qdr_tcp_activate 
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:1573 
> (libqpid-dispatch.so+0x596f8)
> 69: #2 qdr_activate_connections_CT 
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:89
>  (libqpid-dispatch.so+0xca7d4)
> 69: #3 router_core_thread 
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:247
>  (libqpid-dispatch.so+0xca7d4)
> 69: #4 _thread_init 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0x96f16)
> 69: #5   (libtsan.so.0+0x2d1af)
> 69: Previous write of size 8 at 0x7b5400089a10 by thread T2:
> 69: #0 qdr_connection_set_context 
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162 
> (libqpid-dispatch.so+0xa72ea)
> 69: #1 handle_disconnected 
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:499 
> (libqpid-dispatch.so+0x5d2a8)
> 69: #2 handle_connection_event 
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:804 
> (libqpid-dispatch.so+0x5d2a8)
> 69: #3 handle_event_with_context 
> /home/travis/build/apache/qpid-dispatch/src/server.c:802 
> (libqpid-dispatch.so+0xed109)
> 69: #4 do_handle_raw_connection_event 
> /home/travis/build/apache/qpid-dispatch/src/server.c:808 
> (libqpid-dispatch.so+0xed109)
> 69: #5 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1089 
> (libqpid-dispatch.so+0xed109)
> 69: #6 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0xf0ad7)
> 69: #7 _thread_init 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0x96f16)
> 69: #8   (libtsan.so.0+0x2d1af)
> 69: Location is heap block of size 640 at 0x7b5400089800 allocated by thread 
> T4:
> 69: #0 posix_memalign  (libtsan.so.0+0x3048d)
> 69: #1 qd_alloc /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396 
> (libqpid-dispatch.so+0x614c4)
> 69: #2 new_qdr_connection_t 
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:44 
> (libqpid-dispatch.so+0xa6895)
> 69: #3 qdr_connection_opened 
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:89 
> (libqpid-dispatch.so+0xa6ca6)
> 69: #4 qdr_tcp_connection_ingress_accept 
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:701 
> (libqpid-dispatch.so+0x5cb8a)
> 69: #5 handle_connection_event 
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:759 
> (libqpid-dispatch.so+0x5cb8a)
> 69: #6 handle_event_with_context 
> /home/travis/build/apache/qpid-dispatch/src/server.c:802 
> (libqpid-dispatch.so+0xed109)
> 69: #7 do_handle_raw_connection_event 
> /home/travis/build/apache/qpid-dispatch/src/server.c:808 
> (libqpid-dispatch.so+0xed109)
> 69: #8 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1089 
> (libqpid-dispatch.so+0xed109)
> 69: #9 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0xf0ad7)
> 69: #10 _thread_init 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0x96f16)
> 69: #11   (libtsan.so.0+0x2d1af)
> 69: Thread T1 (tid=17016, running) created by main thread at:
> 69: #0 pthread_create  (libtsan.so.0+0x5ea99)
> 69: #1 sys_thread 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 
> (libqpid-dispatch.so+0x974d2)
> 69: #2 qdr_core 
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:124 
> (libqpid-dispatch.so+0xc4bee)
> 69: #3 qd_router_setup_late 
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2123 
> (libqpid-dispatch.so+0xe865c)
> 69: #4   (libffi.so.7+0x6ff4)
> 69: #5 main_process 
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:97 
> (qdrouterd+0x2bb2)
> 69: #6 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 

[jira] [Updated] (DISPATCH-2141) race moving qdr_delivery_state_t

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2141:

Fix Version/s: (was: 1.18.0)
   1.19.0

> race moving qdr_delivery_state_t
> 
>
> Key: DISPATCH-2141
> URL: https://issues.apache.org/jira/browse/DISPATCH-2141
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> Start 70: system_tests_tcp_adaptor
> 70: Test command: /usr/bin/python3.8 
> "/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest" 
> "-v" "system_tests_tcp_adaptor"
> 70: WARNING: ThreadSanitizer: data race (pid=17034)
> 70: Write of size 8 at 0x7b4400031f28 by thread T1 (mutexes: write M2555):
> 70: #0 qdr_delivery_move_delivery_state_CT 
> /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:1263 
> (libqpid-dispatch.so+0xb60a8)
> 70: #1 qdr_delivery_anycast_update_CT 
> /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:728 
> (libqpid-dispatch.so+0xb6228)
> 70: #2 qdr_update_delivery_CT 
> /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:688 
> (libqpid-dispatch.so+0xb6228)
> 70: #3 router_core_thread 
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:239
>  (libqpid-dispatch.so+0xca645)
> 70: #4 _thread_init 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0x96f16)
> 70: #5   (libtsan.so.0+0x2d1af)
> 70: Previous read of size 8 at 0x7b4400031f28 by thread T4:
> 70: #0 qdr_connection_process 
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:403 
> (libqpid-dispatch.so+0xa7fbd)
> 70: #1 handle_connection_event 
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:855 
> (libqpid-dispatch.so+0x5d621)
> 70: #2 handle_event_with_context 
> /home/travis/build/apache/qpid-dispatch/src/server.c:802 
> (libqpid-dispatch.so+0xed109)
> 70: #3 do_handle_raw_connection_event 
> /home/travis/build/apache/qpid-dispatch/src/server.c:808 
> (libqpid-dispatch.so+0xed109)
> 70: #4 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1089 
> (libqpid-dispatch.so+0xed109)
> 70: #5 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0xf0ad7)
> 70: #6 _thread_init 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0x96f16)
> 70: #7   (libtsan.so.0+0x2d1af)
> 70: Location is heap block of size 320 at 0x7b4400031ec0 allocated by thread 
> T3:
> 70: #0 posix_memalign  (libtsan.so.0+0x3048d)
> 70: #1 qd_alloc /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396 
> (libqpid-dispatch.so+0x614c4)
> 70: #2 new_qdr_delivery_t 
> /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:24 
> (libqpid-dispatch.so+0xb25e5)
> 70: #3 qdr_link_deliver 
> /home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:47 
> (libqpid-dispatch.so+0xd013d)
> 70: #4 AMQP_rx_handler 
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:868 
> (libqpid-dispatch.so+0xe6571)
> 70: #5 do_receive /home/travis/build/apache/qpid-dispatch/src/container.c:227 
> (libqpid-dispatch.so+0x76574)
> 70: #6 qd_container_handle_event 
> /home/travis/build/apache/qpid-dispatch/src/container.c:737 
> (libqpid-dispatch.so+0x76574)
> 70: #7 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0xed0b1)
> 70: #8 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0xf09d8)
> 70: #9 _thread_init 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0x96f16)
> 70: #10   (libtsan.so.0+0x2d1af)
> 70: Mutex M2555 (0x7b158600) created at:
> 70: #0 pthread_mutex_init  (libtsan.so.0+0x4a636)
> 70: #1 sys_mutex 
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:43 
> (libqpid-dispatch.so+0x96f7f)
> 70: #2 qdr_link_deliver 
> /home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:62 
> (libqpid-dispatch.so+0xd02b1)
> 70: #3 handle_incoming 
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:360 
> (libqpid-dispatch.so+0x5c38e)
> 70: #4 qdr_tcp_flow 
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:1325 
> (libqpid-dispatch.so+0x5de0d)
> 70: #5 qdr_connection_process 
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:422 
> (libqpid-dispatch.so+0xa8493)
> 70: #6 handle_connection_event 
> /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:840 
> (libqpid-dispatch.so+0x5c9a9)
> 70: #7 handle_event_with_context 
> /home/t

[jira] [Updated] (DISPATCH-2129) shutdown race accessing core->running flag

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2129:

Fix Version/s: (was: 1.18.0)
   1.19.0

> shutdown race accessing core->running flag
> --
>
> Key: DISPATCH-2129
> URL: https://issues.apache.org/jira/browse/DISPATCH-2129
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Michael Goulish
>Priority: Minor
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> Low priority, but nice to clean up so we can remove the suppression for 
> qdr_core_free.
> The core->running flag is set false by the main thread during shutdown.  The 
> flag is checked by the core thread as an indication that the core thread 
> should exit its main loop.
> A non-racy approach would be to instead have the main thread queue an action 
> to the core thread to cause it to exit the main loop (by setting the 
> core->running flag to false).
> {noformat}
> 65: WARNING: ThreadSanitizer: data race (pid=613021) 
> 65: Write of size 1 at 0x7b6400035220 by main thread: 
> 65: #0 qdr_core_free 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:140 
> (libqpid-dispatch.so+0xf0484) 
> 65: #1 qd_router_free 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:2160 
> (libqpid-dispatch.so+0x12870e) 
> 65: #2 qd_dispatch_free 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/dispatch.c:375 
> (libqpid-dispatch.so+0x81dfd) 
> 65: #3 main_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:119 
> (qdrouterd+0x402750) 
> 65: #4 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 
> (qdrouterd+0x403557) 
> 65: 
> 65: Previous read of size 1 at 0x7b6400035220 by thread T1: 
> 65: #0 router_core_thread 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:210
>  (libqpid-dispatch.so+0xfb416) 
> 65: #1 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #2   (libtsan.so.0+0x2d33f)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2101) [console] TCP clients/servers/traffic not shown

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2101:

Fix Version/s: (was: 1.18.0)
   1.19.0

> [console] TCP clients/servers/traffic not shown
> ---
>
> Key: DISPATCH-2101
> URL: https://issues.apache.org/jira/browse/DISPATCH-2101
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Console, Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Charles E. Rolke
>Assignee: Ernest Allen
>Priority: Major
> Fix For: 1.19.0
>
>
> TCP connections are not shown on the topology page and are not included in 
> any statistics.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2125) qdr_link_t->stalled_outbound flag race

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2125:

Fix Version/s: (was: 1.18.0)
   1.19.0

> qdr_link_t->stalled_outbound flag race
> --
>
> Key: DISPATCH-2125
> URL: https://issues.apache.org/jira/browse/DISPATCH-2125
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> Read/write race between I/O and core threads accessing 
> qdr_link_t->stalled_outbound flag:
>  
> 65: WARNING: ThreadSanitizer: data race (pid=566878) 
> 65: Write of size 1 at 0x7b58000a7ef9 by thread T4: 
> 65: #0 qdr_link_stalled_outbound 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:552 
> (libqpid-dispatch.so+0xc5a8e) 
> 65: #1 CORE_link_second_attach 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1747 
> (libqpid-dispatch.so+0x1277ac) 
> 65: #2 qdr_connection_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:355 
> (libqpid-dispatch.so+0xc43f3) 
> 65: #3 AMQP_writable_conn_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:299 
> (libqpid-dispatch.so+0x122d42) 
> 65: #4 writable_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:395 
> (libqpid-dispatch.so+0x7b2e2) 
> 65: #5 qd_container_handle_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:747 
> (libqpid-dispatch.so+0x7cfd5) 
> 65: #6 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0x130537) 
> 65: #7 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 65: #8 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #9   (libtsan.so.0+0x2d33f) 
> 65: 
> 65: Previous read of size 1 at 0x7b58000a7ef9 by thread T1: 
> 65: #0 qdr_link_flow_CT 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:422 
> (libqpid-dispatch.so+0x1061b0) 
> 65: #1 router_core_thread 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239
>  (libqpid-dispatch.so+0xfb2ae) 
> 65: #2 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 65: #3   (libtsan.so.0+0x2d33f)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2206) ASAN use-after-free of qdr_link_t by I/O thread

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2206:

Fix Version/s: (was: 1.18.0)
   1.19.0

> ASAN use-after-free of qdr_link_t by I/O thread
> ---
>
> Key: DISPATCH-2206
> URL: https://issues.apache.org/jira/browse/DISPATCH-2206
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.1
>Reporter: Ken Giusti
>Priority: Major
>  Labels: asan
> Fix For: 1.19.0
>
>
> [https://github.com/apache/qpid-dispatch/blob/main/src/router_core/connections.c#L1344]
>  
> {{27: ==3859==ERROR: AddressSanitizer: use-after-poison on address 
> 0x61700017e030 at pc 0x56212343cdac bp 0x7f9d33c40c90 sp 0x7f9d33c40c80 }}
> {{ }}{{}}
> 27: READ of size 8 at 0x61700017e030 thread T2 
> {{}}{{}}{{}}{{}}{{}}{{}}{{}}{{}}{{}}{{}}{{}}{{}}{{ }}{{}}
> 27:  #0 0x56212343cdab in qdr_link_get_context 
> ../src/router_core/connections.c:498 
> {{}}{{ }}{{}}
> 27:  #1 0x56212352ec25 in CORE_link_second_attach ../src/router_node.c:1729 
> {{}}{{ }}{{}}
> 27:  #2 0x5621234388df in qdr_connection_process 
> ../src/router_core/connections.c:355 
> {{}}{{ }}{{}}
> 27:  #3 0x56212338eccf in writable_handler ../src/container.c:396 
> {{}}{{ }}{{}}
> 27:  #4 0x56212338eccf in qd_container_handle_event ../src/container.c:748 
> {{}}{{ }}{{}}
> 27:  #5 0x562123547289 in handle ../src/server.c:1108 
> {{}}{{ }}{{}}
> 27:  #6 0x562123554c9f in thread_run ../src/server.c:1133 
> {{}}{{ }}{{}}
> 27:  #7 0x7f9d3ba6c608 in start_thread 
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608) 
> {{}}{{ }}{{}}
> 27:  #8 0x7f9d3ac33292 in __clone (/lib/x86_64-linux-gnu/libc.so.6+0x122292) 
> {{}}{{ }}{{}}
> 27:  
> {{}}{{ }}{{}}
> 27: 0x61700017e030 is located 176 bytes inside of 704-byte region 
> [0x61700017df80,0x61700017e240) 
> {{}}{{ }}{{}}
> 27: allocated by thread T2 here: 
> {{}}{{ }}{{}}
> 27:  #0 0x7f9d3bfd9aa5 in posix_memalign 
> (/lib/x86_64-linux-gnu/libasan.so.5+0x10eaa5) 
> {{}}{{ }}{{}}
> 27:  #1 0x5621233247b0 in qd_alloc ../src/alloc_pool.c:396 
> {{}}{{ }}{{}}
> 27:  #2 0x56212343d4c9 in qdr_link_first_attach 
> ../src/router_core/connections.c:592 
> {{}}{{ }}{{}}
> 27:  #3 0x56212352dde9 in AMQP_outgoing_link_handler 
> ../src/router_node.c:1018 
> {{}}{{ }}{{}}
> 27:  #4 0x562123547289 in handle ../src/server.c:1108 
> {{}}{{ }}{{}}
> 27:  #5 0x562123554c9f in thread_run ../src/server.c:1133 
> {{}}{{ }}{{}}
> 27:  #6 0x7f9d3ba6c608 in start_thread 
> (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608) 
> {{}}{{ }}{{}}
> 27:  
> {{}}{{ }}{{}}
> 27: Thread T2 created by T0 here: 
> {{}}{{ }}{{}}
> 27:  #0 0x7f9d3bf05805 in pthread_create 
> (/lib/x86_64-linux-gnu/libasan.so.5+0x3a805) 
> {{}}{{ }}{{}}
> 27:  #1 0x562123403bcf in sys_thread ../src/posix/threading.c:181 
> {{}}{{ }}{{}}
> 27:  #2 0x56212355541e in qd_server_run ../src/server.c:1522 
> {{}}{{ }}{{}}
> 27:  #3 0x56212359f46c in main_process ../router/src/main.c:115 
> {{}}{{ }}{{}}
> 27:  #4 0x56212329bc50 in main ../router/src/main.c:369 
> {{}}{{ }}{{}}
> 27:  #5 0x7f9d3ab380b2 in __libc_start_main 
> (/lib/x86_64-linux-gnu/libc.so.6+0x270b2) 
> {{}}{{ }}{{}}
> 27:  
> {{}}{{ }}{{}}
> 27: SUMMARY: AddressSanitizer: use-after-poison 
> ../src/router_core/connections.c:498 in qdr_link_get_context 
> {{}}{{ }}{{}}
> 27: Shadow bytes around the buggy address: 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027bb0: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027bc0: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027bd0: f7 f7 f7 f7 f7 f7 f7 00 fa fa fa fa fa fa fa fa 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027be0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027bf0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
> {{}}{{ }}{{}}
> 27: =>0x0c2e80027c00: 00 00 f7 f7 f7 f7[f7]f7 f7 f7 f7 f7 f7 f7 f7 f7 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027c10: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027c20: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027c30: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027c40: f7 f7 f7 f7 f7 f7 f7 00 fa fa fa fa fa fa fa fa 
> {{}}{{ }}{{}}
> 27:  0x0c2e80027c50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 
> {{}}{{ }}{{}}
> 27: Shadow byte legend (one shadow byte represents 8 application bytes): 
> {{}}{{ }}{{}}
> 27:  Addressable: 00 
> {{}}{{ }}{{}}
> 27:  Partially addressable: 01 02 03 04 05 06 07 
> {{}}{{ }}{{}}
> 27:  Heap left redzone: fa 
> {{}}{{ }}{{}}
> 27:  Freed heap region: fd 
> {{}}{{ }}{{}}
> 27:  Stack left redzone: f1 
> {{}}{{ }}{{}}
> 27:  Stack mid redzone: f2 
> {{}}{{ }}{{}}
> 27:  Stack right r

[jira] [Updated] (DISPATCH-2234) Update JavaScript console packages for the 1.18.0 release

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2234:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Update JavaScript console packages for the 1.18.0 release
> -
>
> Key: DISPATCH-2234
> URL: https://issues.apache.org/jira/browse/DISPATCH-2234
> Project: Qpid Dispatch
>  Issue Type: Task
>  Components: Console
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2131) I/O thread data race in qdr_record_link_credit

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2131:

Fix Version/s: (was: 1.18.0)
   1.19.0

> I/O thread data race in qdr_record_link_credit
> --
>
> Key: DISPATCH-2131
> URL: https://issues.apache.org/jira/browse/DISPATCH-2131
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> qdr_record_link_credit is called by the I/O and writes to the qdr_core and 
> qdr_link, etc structures as they are being read/written by the Core thread.
> {noformat}
> 50: WARNING: ThreadSanitizer: data race (pid=627672) 
> 50: Read of size 4 at 0x7b580009beec by thread T1: 
> 50: #0 qdr_agent_write_column_CT 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/agent_link.c:278 
> (libqpid-dispatch.so+0xbfc8b) 
> 50: #1 qdr_agent_write_link_CT 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/agent_link.c:302 
> (libqpid-dispatch.so+0xbfe0f) 
> 50: #2 qdra_link_get_next_CT 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/agent_link.c:382 
> (libqpid-dispatch.so+0xc01d9) 
> 50: #3 qdrh_query_get_next_CT 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/agent.c:566 
> (libqpid-dispatch.so+0xb4fac) 
> 50: #4 router_core_thread 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239
>  (libqpid-dispatch.so+0xfb2ae) 
> 50: #5 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 50: #6   (libtsan.so.0+0x2d33f) 
> 50: 
> 50: Previous write of size 4 at 0x7b580009beec by thread T4: 
> 50: #0 qdr_record_link_credit 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:273 
> (libqpid-dispatch.so+0xc3a7c) 
> 50: #1 qdr_connection_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:463 
> (libqpid-dispatch.so+0xc554d) 
> 50: #2 AMQP_writable_conn_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:299 
> (libqpid-dispatch.so+0x122d42) 
> 50: #3 writable_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:395 
> (libqpid-dispatch.so+0x7b2e2) 
> 50: #4 qd_container_handle_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:747 
> (libqpid-dispatch.so+0x7cfd5) 
> 50: #5 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0x130537) 
> 50: #6 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 50: #7 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 50: #8   (libtsan.so.0+0x2d33f) 
>  
> - 
>  
> 62: Read of size 4 at 0x7b64000352c8 by thread T3: 
> 62: #0 qdr_record_link_credit 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:260 
> (libqpid-dispatch.so+0xc3978) 
> 62: #1 qdr_connection_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:463 
> (libqpid-dispatch.so+0xc554d) 
> 62: #2 AMQP_writable_conn_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:299 
> (libqpid-dispatch.so+0x122d42) 
> 62: #3 writable_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:395 
> (libqpid-dispatch.so+0x7b2e2) 
> 62: #4 qd_container_handle_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:747 
> (libqpid-dispatch.so+0x7cfd5) 
> 62: #5 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0x130537) 
> 62: #6 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 62: #7 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 62: #8   (libtsan.so.0+0x2d33f) 
> 62: 
> 62: Previous write of size 4 at 0x7b64000352c8 by thread T1: 
> 62: #0 qdr_process_tick_CT 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/core_timer.c:111 
> (libqpid-dispatch.so+0x10a860) 
> 62: #1 router_core_thread 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239
>  (libqpid-dispatch.so+0xfb2ae) 
> 62: #2 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 62: #3   (libtsan.so.0+0x2d33f)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: d

[jira] [Updated] (DISPATCH-2132) core->uptime_ticks races

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2132:

Fix Version/s: (was: 1.18.0)
   1.19.0

> core->uptime_ticks races
> 
>
> Key: DISPATCH-2132
> URL: https://issues.apache.org/jira/browse/DISPATCH-2132
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Minor
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> TSAN flags many races while accessing core->uptime_ticks.  Likely harmless.  
> Replace core->uptime_ticks with atomic integer.
>  
> Example:
> 30: WARNING: ThreadSanitizer: data race (pid=632294) 
> 30: Read of size 4 at 0x7b64000352c8 by thread T3: 
> 30: #0 qdr_link_first_attach 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:608 
> (libqpid-dispatch.so+0xc5ee8) 
> 30: #1 AMQP_incoming_link_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:985 
> (libqpid-dispatch.so+0x1247f4) 
> 30: #2 setup_incoming_link 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:205 
> (libqpid-dispatch.so+0x7a7f8) 
> 30: #3 qd_container_handle_event 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:670 
> (libqpid-dispatch.so+0x7c935) 
> 30: #4 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 
> (libqpid-dispatch.so+0x130537) 
> 30: #5 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 30: #6 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 30: #7   (libtsan.so.0+0x2d33f) 
> 30: 
> 30: Previous write of size 4 at 0x7b64000352c8 by thread T1: 
> 30: #0 qdr_process_tick_CT 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/core_timer.c:111 
> (libqpid-dispatch.so+0x10a860) 
> 30: #1 router_core_thread 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239
>  (libqpid-dispatch.so+0xfb2ae) 
> 30: #2 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 30: #3   (libtsan.so.0+0x2d33f)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2265) TCP and HTTP adaptor: client connection leak on close if no connector present

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2265:

Fix Version/s: (was: 1.18.0)
   1.19.0

> TCP and HTTP adaptor: client connection leak on close if no connector present
> -
>
> Key: DISPATCH-2265
> URL: https://issues.apache.org/jira/browse/DISPATCH-2265
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Protocol Adaptors
>Affects Versions: 1.17.0
>Reporter: Ken Giusti
>Priority: Major
> Fix For: 1.19.0
>
>
> Create a router with a tcpListener.  Connect a client to the listener (I used 
> Telnet).  Disconnect the client.  qdstat -l shows the in link for the service 
> as still present.  AFAIKT there was no DISCONNECT event.
> I used an edge router to reproduce this.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-1890) need tests for http1 multicast

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1890:

Fix Version/s: (was: 1.18.0)
   1.19.0

> need tests for http1 multicast
> --
>
> Key: DISPATCH-1890
> URL: https://issues.apache.org/jira/browse/DISPATCH-1890
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Protocol Adaptors
>Reporter: Gordon Sim
>Assignee: Ken Giusti
>Priority: Major
>  Labels: HTTP/1.x
> Fix For: 1.19.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-1861) TCP adaptor server addresses take long time to propagate

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1861:

Fix Version/s: (was: 1.18.0)
   Backlog

> TCP adaptor server addresses take long time to propagate
> 
>
> Key: DISPATCH-1861
> URL: https://issues.apache.org/jira/browse/DISPATCH-1861
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Protocol Adaptors, Routing Engine
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: Backlog
>
>
> In a linear three-node interior router network it may take up to four seconds 
> for addresses of TCP servers to be known by all routers.
> {code:java}
> 1: 2020-12-02 11:33:59.253744 TCP_TEST Launching echo server 'ECHO_SERVER 
> TcpAdaptor ES_INTA'
> 71: 2020-12-02 11:33:59.254190 TCP_TEST Launching echo server 'ECHO_SERVER 
> TcpAdaptor ES_INTB'
> 71: 2020-12-02 11:33:59.254634 TCP_TEST Launching echo server 'ECHO_SERVER 
> TcpAdaptor ES_INTC'
> 71: 2020-12-02 11:33:59.512729 TCP_TEST waiting server addresses to 
> propagate. Router INTA sees only 1 of 3 addresses
> 71: 2020-12-02 11:34:00.005271 TCP_TEST waiting server addresses to 
> propagate. Router INTC sees only 2 of 3 addresses
> 71: 2020-12-02 11:34:00.520471 TCP_TEST waiting server addresses to 
> propagate. Router INTC sees only 2 of 3 addresses
> 71: 2020-12-02 11:34:01.018307 TCP_TEST waiting server addresses to 
> propagate. Router INTC sees only 2 of 3 addresses
> 71: 2020-12-02 11:34:01.516244 TCP_TEST waiting server addresses to 
> propagate. Router INTC sees only 2 of 3 addresses
> 71: 2020-12-02 11:34:02.017805 TCP_TEST waiting server addresses to 
> propagate. Router INTC sees only 2 of 3 addresses
> 71: 2020-12-02 11:34:02.520519 TCP_TEST waiting server addresses to 
> propagate. Router INTC sees only 2 of 3 addresses
> 71: test_01_tcp_basic_connectivity (system_tests_tcp_adaptor.TcpAdaptor)
> 71: 2020-12-02 11:34:03.018219 TCP_TEST test_01_tcp_basic_connectivity Start 
> test_01_tcp_INTA_INTA
> 71: 2020-12-02 11:34:03.018389 TCP_TEST test_01_tcp_INTA_INTA Start 
> do_tcp_echo_n_routers
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.18.0 release

[Ganesh Murthy (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437519#comment-17437519
 ] 

Ganesh Murthy commented on DISPATCH-2234:
-

Is this strictly required for 1.18.0 ? If we can postpone this to 1.19.0, 
please move this one to 1.19.0

> Update JavaScript console packages for the 1.18.0 release
> -
>
> Key: DISPATCH-2234
> URL: https://issues.apache.org/jira/browse/DISPATCH-2234
> Project: Qpid Dispatch
>  Issue Type: Task
>  Components: Console
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1958) Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437516#comment-17437516
 ] 

ASF GitHub Bot commented on DISPATCH-1958:
--

kgiusti commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-957878563


   hmmm...  I wonder if it would be simpler to make QD_MEMORY_STATS 
non-configurable?  IOW, get rid of the flag and just always provide memory 
statistics.  It's pretty obvious we haven't tested QD_MEMORY_STATS=OFF as part 
of our CI.
   
   Just an opinion, thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`
> 
>
> Key: DISPATCH-1958
> URL: https://issues.apache.org/jira/browse/DISPATCH-1958
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tools
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> From the README
> {noformat}
> -DQD_MEMORY_STATS=
> --
> Dispatch will track memory pool usage statistics if this is enabled.
> {noformat}
> So the statistics may not be always available, depending on the way 
> Dispatch is compiled.
> Allocator metrics get reported as 0. I see that {{qdmanage}} works just fine, 
> but {{qdstat}} is throwing an error in such case:
> {noformat}
> $ qdstat -m
> 2021-02-04 15:08:19.288818 UTC
> Standalone_v++jCPCjYiQcGo3
> TypeError: unsupported operand type(s) for *: 'int32' and 'NoneType'
> {noformat}
> Found during PR review by [~fgiorget].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-dispatch] kgiusti commented on pull request #1416: DISPATCH-1958: Fixed error in qdstat when memory stats are turned off…

[GitBox]

kgiusti commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-957878563


   hmmm...  I wonder if it would be simpler to make QD_MEMORY_STATS 
non-configurable?  IOW, get rid of the flag and just always provide memory 
statistics.  It's pretty obvious we haven't tested QD_MEMORY_STATS=OFF as part 
of our CI.
   
   Just an opinion, thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-2085) system_tests_fallback_dest failure - addr_proxy.c:323: on_conn_event: Assertion `addr->edge_outlink == 0' failed

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437515#comment-17437515
 ] 

ASF GitHub Bot commented on DISPATCH-2085:
--

kgiusti merged pull request #1415:
URL: https://github.com/apache/qpid-dispatch/pull/1415


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> system_tests_fallback_dest failure - addr_proxy.c:323: on_conn_event: 
> Assertion `addr->edge_outlink == 0' failed
> 
>
> Key: DISPATCH-2085
> URL: https://issues.apache.org/jira/browse/DISPATCH-2085
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.18.0
>
>
> First spotted on s390x, 
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501153572#L6607
> {noformat}
> 62: Router EA2 output file:
> 62: 
> 62: 2021-04-26 16:56:05.615255 + AGENT (warning) Attribute 'dir' of 
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 62: 2021-04-26 16:56:05.615411 + AGENT (warning) Attribute 'dir' of 
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 62: qdrouterd: 
> /home/travis/build/apache/qpid-dispatch/src/router_core/modules/edge_router/addr_proxy.c:323:
>  on_conn_event: Assertion `addr->edge_outlink == 0' failed.
> 62: 
> 62: 
> 62: 
> 62: Router EA2 command file:
> 62: 
> 62: qdrouterd -c EA2.conf -I /home/travis/build/apache/qpid-dispatch/python
> 62: pid=14036
> 62: 
> 62: 
> 62: 
> 62: Router EA2 log file tail:
> 62: 
> 62: 2021-04-26 16:58:05.686184 + ROUTER_CORE (trace) Core action 
> 'link_detach' 
> (/home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:238)
> 62: 2021-04-26 16:58:05.686235 + ROUTER_CORE (info) [C4][L12] Link lost: 
> del=1 presett=1 psdrop=0 acc=0 rej=0 rel=0 mod=0 delay1=0 delay10=0 
> blocked=no 
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1074)
> 62: 2021-04-26 16:58:05.686281 + ROUTER_CORE (trace) Core action 
> 'connection_closed' 
> (/home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:238)
> 62: 2021-04-26 16:58:05.686346 + ROUTER_CORE (info) [C4] Connection 
> Closed 
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1557)
> 62: 2021-04-26 16:58:05.705484 + SERVER (trace) Accepting connection on 
> 0.0.0.0:23020 (/home/travis/build/apache/qpid-dispatch/src/server.c:852)
> 62: 2021-04-26 16:58:05.705577 + SERVER (trace) [C5]: Accepting incoming 
> connection to '0.0.0.0:23020' 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:606)
> 62: 2021-04-26 16:58:05.705691 + POLICY (trace) ALLOW Connection 
> '127.0.0.1' based on global connection count. nConnections= 1 
> (/home/travis/build/apache/qpid-dispatch/src/policy.c:271)
> 62: 2021-04-26 16:58:05.705782 + SERVER (info) [C5] Accepted connection 
> to 0.0.0.0:23020 from 127.0.0.1:37922 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:750)
> 62: 2021-04-26 16:58:05.706152 + PROTOCOL (trace) [C5]:FRAME:   <- SASL 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706180 + PROTOCOL (trace) [C5]:FRAME:   -> SASL 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706590 + PROTOCOL (trace) [C5]:FRAME: 0 -> 
> @sasl-mechanisms(64) [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]] 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706949 + PROTOCOL (trace) [C5]:FRAME: 0 <- 
> @sasl-init(65) [mechanism=:ANONYMOUS, 
> initial-response=b"anonymous@travis-job-apache-qpid-dispatch-501153572"] 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707025 + PROTOCOL (trace) [C5]:FRAME: 0 -> 
> @sasl-outcome(68) [code=0] 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707319 + PROTOCOL (trace) [C5]:FRAME:   <- AMQP 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707363 + PROTOCOL (trace) [C5]:FRAME: 0 <- 
> @open(16) [container-id="ac3fab39-661e-44f4-8361-5866a600788d", 
> hostname="0.0.0.0", channel-max=32767] 
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707432 + PROTOCOL (trace) [C5]:FRAME: 0 <- 
> @begin(17) [next-outgoing-id=0, incoming-window=2147483647, 
> outgo

[jira] [Commented] (DISPATCH-1958) Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437511#comment-17437511
 ] 

ASF GitHub Bot commented on DISPATCH-1958:
--

ganeshmurthy opened a new pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416


   … (-DQD_MEMORY_STATS=OFF)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`
> 
>
> Key: DISPATCH-1958
> URL: https://issues.apache.org/jira/browse/DISPATCH-1958
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tools
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> From the README
> {noformat}
> -DQD_MEMORY_STATS=
> --
> Dispatch will track memory pool usage statistics if this is enabled.
> {noformat}
> So the statistics may not be always available, depending on the way 
> Dispatch is compiled.
> Allocator metrics get reported as 0. I see that {{qdmanage}} works just fine, 
> but {{qdstat}} is throwing an error in such case:
> {noformat}
> $ qdstat -m
> 2021-02-04 15:08:19.288818 UTC
> Standalone_v++jCPCjYiQcGo3
> TypeError: unsupported operand type(s) for *: 'int32' and 'NoneType'
> {noformat}
> Found during PR review by [~fgiorget].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-dispatch] kgiusti merged pull request #1415: DISPATCH-2085: remove bad assertion in addr_proxy connection handler

[GitBox]

kgiusti merged pull request #1415:
URL: https://github.com/apache/qpid-dispatch/pull/1415


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-552) JMS 2 Completion threads shouldn't scale with the number of sessions

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437509#comment-17437509
 ] 

ASF GitHub Bot commented on QPIDJMS-552:


franz1981 edited a comment on pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957253435






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JMS 2 Completion threads shouldn't scale with the number of sessions
> 
>
> Key: QPIDJMS-552
> URL: https://issues.apache.org/jira/browse/QPIDJMS-552
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 1.3.0
>Reporter: Francesco Nigro
>Priority: Major
>
> JMS 2 Completion threads are now tied to be one per JMS Session ie a client 
> application with N JMS sessions need N completion threads to handle the 
> completion events.
> Given that the asynchronous model of JMS 2 allows users to have few threads 
> handling many JMS sessions, should be better to reduce the amount of 
> completion threads without exceeding the number of available cores and 
> shrink/grow according to the completion event processing load.
> If the user confine a connection in a thread handling many JMS sessions and 
> the completion events are issued by the same Netty thread in sequence, if the 
> completion processing for a JMS Session is fast enough, next JMS Sessions can 
> reuse existing completion threads instead of using a new one.
> This model save using too many completion threads for users tasks that are 
> supposed to be very fast: if the user task cause a specific JMS Session 
> completion thread to block, the expectation is that the system should be able 
> to create a new completion thread to handle other JMS Session completion 
> events, as expected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

[GitBox]

franz1981 edited a comment on pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957253435






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-552) JMS 2 Completion threads shouldn't scale with the number of sessions

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437501#comment-17437501
 ] 

ASF GitHub Bot commented on QPIDJMS-552:


franz1981 commented on pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957253435






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JMS 2 Completion threads shouldn't scale with the number of sessions
> 
>
> Key: QPIDJMS-552
> URL: https://issues.apache.org/jira/browse/QPIDJMS-552
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 1.3.0
>Reporter: Francesco Nigro
>Priority: Major
>
> JMS 2 Completion threads are now tied to be one per JMS Session ie a client 
> application with N JMS sessions need N completion threads to handle the 
> completion events.
> Given that the asynchronous model of JMS 2 allows users to have few threads 
> handling many JMS sessions, should be better to reduce the amount of 
> completion threads without exceeding the number of available cores and 
> shrink/grow according to the completion event processing load.
> If the user confine a connection in a thread handling many JMS sessions and 
> the completion events are issued by the same Netty thread in sequence, if the 
> completion processing for a JMS Session is fast enough, next JMS Sessions can 
> reuse existing completion threads instead of using a new one.
> This model save using too many completion threads for users tasks that are 
> supposed to be very fast: if the user task cause a specific JMS Session 
> completion thread to block, the expectation is that the system should be able 
> to create a new completion thread to handle other JMS Session completion 
> events, as expected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-552) JMS 2 Completion threads shouldn't scale with the number of sessions

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/QPIDJMS-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437493#comment-17437493
 ] 

ASF GitHub Bot commented on QPIDJMS-552:


gemmellr commented on pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957323951


   I think single completion at a time is the way to go, at least by default, 
it just shouldn't really be a concern when using it whether the callback 
execution is fair or not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JMS 2 Completion threads shouldn't scale with the number of sessions
> 
>
> Key: QPIDJMS-552
> URL: https://issues.apache.org/jira/browse/QPIDJMS-552
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 1.3.0
>Reporter: Francesco Nigro
>Priority: Major
>
> JMS 2 Completion threads are now tied to be one per JMS Session ie a client 
> application with N JMS sessions need N completion threads to handle the 
> completion events.
> Given that the asynchronous model of JMS 2 allows users to have few threads 
> handling many JMS sessions, should be better to reduce the amount of 
> completion threads without exceeding the number of available cores and 
> shrink/grow according to the completion event processing load.
> If the user confine a connection in a thread handling many JMS sessions and 
> the completion events are issued by the same Netty thread in sequence, if the 
> completion processing for a JMS Session is fast enough, next JMS Sessions can 
> reuse existing completion threads instead of using a new one.
> This model save using too many completion threads for users tasks that are 
> supposed to be very fast: if the user task cause a specific JMS Session 
> completion thread to block, the expectation is that the system should be able 
> to create a new completion thread to handle other JMS Session completion 
> events, as expected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-jms] franz1981 commented on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

[GitBox]

franz1981 commented on pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957253435






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1958) Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437500#comment-17437500
 ] 

ASF GitHub Bot commented on DISPATCH-1958:
--

ganeshmurthy commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-957887593


   > hmmm... I wonder if it would be simpler to make QD_MEMORY_STATS 
non-configurable? IOW, get rid of the flag and just always provide memory 
statistics. It's pretty obvious we haven't tested QD_MEMORY_STATS=OFF as part 
of our CI.
   > 
   > Just an opinion, thoughts?
   
   I am all for getting rid of the flag once and for all and always provide 
memory statistics but first I want to understand why this flag was introduced 
in the first place ? 
   If we decide to keep this flag, we need to augment CI (preferably GHA) to 
test with QD_MEMORY_STATS=OFF. That will add *yet another* build type to the 
already long list of tests we run, so I am inclined to say let's just get rid 
of this flag.
   
   @ted-ross  what do you think ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`
> 
>
> Key: DISPATCH-1958
> URL: https://issues.apache.org/jira/browse/DISPATCH-1958
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tools
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> From the README
> {noformat}
> -DQD_MEMORY_STATS=
> --
> Dispatch will track memory pool usage statistics if this is enabled.
> {noformat}
> So the statistics may not be always available, depending on the way 
> Dispatch is compiled.
> Allocator metrics get reported as 0. I see that {{qdmanage}} works just fine, 
> but {{qdstat}} is throwing an error in such case:
> {noformat}
> $ qdstat -m
> 2021-02-04 15:08:19.288818 UTC
> Standalone_v++jCPCjYiQcGo3
> TypeError: unsupported operand type(s) for *: 'int32' and 'NoneType'
> {noformat}
> Found during PR review by [~fgiorget].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #1416: DISPATCH-1958: Fixed error in qdstat when memory stats are turned off…

[GitBox]

ganeshmurthy commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-957887593


   > hmmm... I wonder if it would be simpler to make QD_MEMORY_STATS 
non-configurable? IOW, get rid of the flag and just always provide memory 
statistics. It's pretty obvious we haven't tested QD_MEMORY_STATS=OFF as part 
of our CI.
   > 
   > Just an opinion, thoughts?
   
   I am all for getting rid of the flag once and for all and always provide 
memory statistics but first I want to understand why this flag was introduced 
in the first place ? 
   If we decide to keep this flag, we need to augment CI (preferably GHA) to 
test with QD_MEMORY_STATS=OFF. That will add *yet another* build type to the 
already long list of tests we run, so I am inclined to say let's just get rid 
of this flag.
   
   @ted-ross  what do you think ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-2406) [cpp] Use of reconnect_options::failover_urls triggers -Wdeprecated-declarations in examples/cpp/reconnect_client.cpp

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/PROTON-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437497#comment-17437497
 ] 

ASF GitHub Bot commented on PROTON-2406:


cliffjansen commented on pull request #337:
URL: https://github.com/apache/qpid-proton/pull/337#issuecomment-956502433


   As I read the documentation for reconnect_url() and failover_urls() I 
implicitly expect the same intention for:
   
 - default reconnect timing options
 - change via update_options()
   
   even though it is only explicitly spelled out for the former and may not 
make sense in all permutations for the latter.  Perhaps the documentation 
should be made explicit for failover_urls().
   
   Regardless, I think I would expect this example to have no reference to 
reconnect_options unless non-default values were being set and no call made to 
connection::reconnect().
   
   The segfault appears to be from a missing argument where argc is one short 
to catch the expected number of input parameters.  However, it may also be a 
failing in the library to not robustly handle an empty vector properly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [cpp] Use of reconnect_options::failover_urls triggers 
> -Wdeprecated-declarations in examples/cpp/reconnect_client.cpp
> -
>
> Key: PROTON-2406
> URL: https://issues.apache.org/jira/browse/PROTON-2406
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding, examples
>Affects Versions: proton-c-0.36.0
>Reporter: Jiri Daněk
>Assignee: Rakhi Kumari
>Priority: Minor
> Fix For: proton-c-0.37.0
>
>
> {noformat}
> [ 56%] Building CXX object 
> CMakeFiles/reconnect_client.dir/reconnect_client.cpp.o
> /usr/share/proton/examples/cpp/reconnect_client.cpp: In member function 
> ‘virtual void reconnect_client::on_container_start(proton::container&)’:
> /usr/share/proton/examples/cpp/reconnect_client.cpp:59:35: warning: 
> ‘proton::reconnect_options& proton::reconnect_options::failover_urls(const 
> std::vector >&)’ is deprecated (declared at 
> /usr/include/proton/reconnect_options.hpp:82): use 
> connection_options::failover_urls() [-Wdeprecated-declarations]
>  ro.failover_urls(failovers);
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-proton] cliffjansen commented on pull request #337: PROTON-2406: [cpp] Replace uses of deprecated reconnect_options::failover_urls with conn…

[GitBox]

cliffjansen commented on pull request #337:
URL: https://github.com/apache/qpid-proton/pull/337#issuecomment-956502433


   As I read the documentation for reconnect_url() and failover_urls() I 
implicitly expect the same intention for:
   
 - default reconnect timing options
 - change via update_options()
   
   even though it is only explicitly spelled out for the former and may not 
make sense in all permutations for the latter.  Perhaps the documentation 
should be made explicit for failover_urls().
   
   Regardless, I think I would expect this example to have no reference to 
reconnect_options unless non-default values were being set and no call made to 
connection::reconnect().
   
   The segfault appears to be from a missing argument where argc is one short 
to catch the expected number of input parameters.  However, it may also be a 
failing in the library to not robustly handle an empty vector properly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-jms] gemmellr commented on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

[GitBox]

gemmellr commented on pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957323951


   I think single completion at a time is the way to go, at least by default, 
it just shouldn't really be a concern when using it whether the callback 
execution is fair or not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-2247) "Received MAU from an unknown router" error message must include unknown router id

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437491#comment-17437491
 ] 

ASF GitHub Bot commented on DISPATCH-2247:
--

asfgit merged pull request #1414:
URL: https://github.com/apache/qpid-dispatch/pull/1414


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> "Received MAU from an unknown router" error message must include unknown 
> router id
> --
>
> Key: DISPATCH-2247
> URL: https://issues.apache.org/jira/browse/DISPATCH-2247
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Routing Engine
>Affects Versions: 1.17.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> Sometimes the router prints out the following error -
> {noformat}
> Received MAU from an unknown router {noformat}
> It would be nice if it print out the router id received in the MAU, like so
> {noformat}
> Received MAU from an unknown router with id QDR.A {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-dispatch] asfgit merged pull request #1414: DISPATCH-2247: Added router id to log message

[GitBox]

asfgit merged pull request #1414:
URL: https://github.com/apache/qpid-dispatch/pull/1414


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2093) [tcp] TCP deliveries are counted as modified

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2093:

Fix Version/s: (was: 1.18.0)
   1.19.0

> [tcp] TCP deliveries are counted as modified
> 
>
> Key: DISPATCH-2093
> URL: https://issues.apache.org/jira/browse/DISPATCH-2093
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Protocol Adaptors
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.19.0
>
>
> TCP deliveries that pass over inter router links are being counted as 
> 'modified' once the TCP connections complete.   Since the inter router links 
> survive much longer than the TCP links, the "modified" counters are visible 
> long after TCP i done.
>  
> Proposed fix:
> Add to void handle_disconnected(qdr_tcp_connection_t* conn):
> {{qd_log(tcp_adaptor->log_source, QD_LOG_DEBUG, "[C%"PRIu64"][L%"PRIu64"] 
> handle_disconnected - close outstream", conn->conn_id, conn->outgoing_id);}}
> {{+ qdr_delivery_remote_state_updated(tcp_adaptor->core,}}
> {{+   conn->outstream,}}
> {{+   PN_ACCEPTED,}}
> {{+   true, // settled,}}
> {{+   0, // delivery state}}
> {{+   false);}}
> {{qdr_delivery_decref(tcp_adaptor->core, conn->outstream, 
> "tcp-adaptor.handle_disconnected - outstream");}}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2092) [tools] Scraper does not expose TCP adaptor information

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2092:

Fix Version/s: (was: 1.18.0)
   Backlog

> [tools] Scraper does not expose TCP adaptor information
> ---
>
> Key: DISPATCH-2092
> URL: https://issues.apache.org/jira/browse/DISPATCH-2092
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: Backlog
>
>
> * TCP pseudo connections are not shown in the Connections summary
> This means that single connection data cannot be isolated in data display.
> There is no per-connection statistics summary. Scraper could display
> bytes in, bytes out, opened time, last in time, last out time.
> Enhancement could be number of and total duration of window closed events
>  * TCP connections go in pairs - scraper could correlate those pairs
>  * Scraper could locate and match client ingress and server egress facts 
> across
> multiple router network.
> These additions are fundamental; undoubtedly there are more.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2071) system_tests_authz_service_plugin test failure

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2071:

Fix Version/s: (was: 1.18.0)
   Backlog

> system_tests_authz_service_plugin test failure
> --
>
> Key: DISPATCH-2071
> URL: https://issues.apache.org/jira/browse/DISPATCH-2071
> Project: Qpid Dispatch
>  Issue Type: Test
>  Components: Tests
>Reporter: Ganesh Murthy
>Priority: Major
> Fix For: Backlog
>
>
> {noformat}
>   Start 43: system_tests_authz_service_plugin
> 43: Test command: /usr/bin/bwrap "--bind" "/" "/" "--unshare-net" "--dev" 
> "/dev" "--die-with-parent" "--" 
> "/opt/hostedtoolcache/Python/3.7.10/x64/bin/python3.7" 
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/run.py"
>  "-m" "unittest" "-v" "system_tests_authz_service_plugin"
> 43: Test timeout computed to be: 600
> 43: test_authorized 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzDeprecatedTest) ... 
> FAIL
> 43: test_dynamic_source_anonymous_sender 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzDeprecatedTest) ... 
> FAIL
> 43: test_unauthorized 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzDeprecatedTest) ... 
> FAIL
> 43: test_unauthorized_anonymous_sender_target 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzDeprecatedTest) ... 
> FAIL
> 43: test_wildcard 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzDeprecatedTest) ... 
> FAIL
> 43: 
> 43: Router router output file:
> 43: 
> 43: 2021-04-21 16:46:23.573220 + AGENT (warning) Attribute 
> 'authSslProfile' of entity 'authServicePlugin' has been deprecated. Use 
> 'sslProfile' instead
> 43: 2021-04-21 16:46:23.573958 + AGENT (warning) Attribute 
> 'saslConfigPath' of entity 'router' has been deprecated. Use 'saslConfigDir' 
> instead
> 43: -
> 43: Suppressions used:
> 43:   count  bytes template
> 43:   1  7 ^load_server_config$
> 43:   1 56 qdr_core_subscribe
> 43:  12   6656 ^_PyObject_Realloc
> 43: 540 864794 ^PyObject_Malloc$
> 43:   1 32 ^PyThread_allocate_lock$
> 43:   4   9897 ^PyMem_Malloc$
> 43:   1856 ^_PyObject_GC_Resize$
> 43: -
> 43: 
> 43: 
> 43: 
> 43: test_authorized 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzTest) ... FAIL
> 43: test_dynamic_source_anonymous_sender 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzTest) ... FAIL
> 43: test_unauthorized 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzTest) ... FAIL
> 43: test_unauthorized_anonymous_sender_target 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzTest) ... FAIL
> 43: test_wildcard 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzTest) ... FAIL
> 43: 
> 43: Router router output file:
> 43: 
> 43: 2021-04-21 16:46:24.058982 + AGENT (warning) Attribute 
> 'saslConfigPath' of entity 'router' has been deprecated. Use 'saslConfigDir' 
> instead
> 43: -
> 43: Suppressions used:
> 43:   count  bytes template
> 43:   1  7 ^load_server_config$
> 43:   1 32 ^qd_policy_c_counts_alloc$
> 43:   1 56 qdr_core_subscribe
> 43:  12   6656 ^_PyObject_Realloc
> 43: 550 870562 ^PyObject_Malloc$
> 43:   1 32 ^PyThread_allocate_lock$
> 43:   4   9897 ^PyMem_Malloc$
> 43:   1856 ^_PyObject_GC_Resize$
> 43: -
> 43: 
> 43: 
> 43: 
> 43: 
> 43: ==
> 43: FAIL: test_authorized 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzDeprecatedTest)
> 43: --
> 43: Traceback (most recent call last):
> 43:   File 
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_test.py",
>  line 924, in wrap
> 43: return f(*args, **kwargs)
> 43:   File 
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_authz_service_plugin.py",
>  line 97, in test_authorized
> 43: self.assertEqual(1, client.sent)
> 43: AssertionError: 1 != 0
> 43: 
> 43: ==
> 43: FAIL: test_dynamic_source_anonymous_sender 
> (system_tests_authz_service_plugin.AuthServicePluginAuthzDeprecatedTest)
> 43: --
> 43: Traceback (most recent call last):
> 43:   File 
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_test

[jira] [Updated] (DISPATCH-2133) qd_log_enabled() race

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2133:

Fix Version/s: (was: 1.18.0)
   1.19.0

> qd_log_enabled() race
> -
>
> Key: DISPATCH-2133
> URL: https://issues.apache.org/jira/browse/DISPATCH-2133
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Michael Goulish
>Priority: Minor
>  Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> TSAN flags qd_log_enabled() as a race since it reads the source mask without 
> holding the source lock.
> Mostly harmless - adding synchronizing overhead not likely worth it.
> Masking qd_log_enabled() for now.
>  
> 20: WARNING: ThreadSanitizer: data race (pid=637946) 
> 20: Write of size 4 at 0x7b1c0018 by main thread (mutexes: write M13, 
> write M11): 
> 20: #0 qd_log_entity /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:634 
> (libqpid-dispatch.so+0x8dbe0) 
> 20: #1 ffi_call_unix64  (libffi.so.6+0x6aef) 
> 20: #2 qdr_forward_on_message 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/forwarder.c:336 
> (libqpid-dispatch.so+0xe4ff5) 
> 20: #3 qdr_general_handler 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:929 
> (libqpid-dispatch.so+0xf83f6) 
> 20: #4 qd_timer_visit 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/timer.c:317 
> (libqpid-dispatch.so+0x135b52) 
> 20: #5 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1006 
> (libqpid-dispatch.so+0x12fc8d) 
> 20: #6 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 
> (libqpid-dispatch.so+0x13063a) 
> 20: #7 qd_server_run 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1501 
> (libqpid-dispatch.so+0x1328de) 
> 20: #8 main_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:115 
> (qdrouterd+0x40271a) 
> 20: #9 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 
> (qdrouterd+0x403557) 
> 20: 
> 20: Previous read of size 4 at 0x7b1c0018 by thread T2: 
> 20: #0 qd_log_enabled /home/kgiusti/work/dispatch/qpid-dispatch/src/log.c:404 
> (libqpid-dispatch.so+0x8cb49) 
> 20: #1 transport_tracer 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:111 
> (libqpid-dispatch.so+0x12ac43) 
> 20: #2 pni_tracer_to_log_sink 
> /home/kgiusti/work/proton/qpid-proton/c/src/core/transport.c:2874 
> (libqpid-proton-core.so.10+0x22185) 
> 20: #3 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad37a) 
> 20: #4   (libtsan.so.0+0x2d33f)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-1903) Remote upload of certificate files for new TLS configurations

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1903:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Remote upload of certificate files for new TLS configurations
> -
>
> Key: DISPATCH-1903
> URL: https://issues.apache.org/jira/browse/DISPATCH-1903
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Container
>Reporter: Ted Ross
>Assignee: Ted Ross
>Priority: Major
> Fix For: 1.19.0
>
>
> Currently, when using the management protocol to create new SSL-profiles, 
> those profiles must access certificate files that are already placed in the 
> file system.  In other words, in order to create an SSL-profile on a running 
> router, files must first be placed on the file system in a location 
> accessible by the router.  This may be problematic in cases where the router 
> is remote from the managing agent, or when containerization limits access to 
> the router's underlying file system.
> This new feature allows a managing agent to remotely inject files into a 
> running router to be stored in temporary file storage.  These files are 
> usable in sslProfile management entities (by specifying the files without an 
> absolute path).  The temporary files are removed from the file system on 
> router shutdown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2036) TCP adaptor deliveries reported as "stuck" by delayed delivery detection

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2036:

Fix Version/s: (was: 1.18.0)
   1.19.0

> TCP adaptor deliveries reported as "stuck" by delayed delivery detection
> 
>
> Key: DISPATCH-2036
> URL: https://issues.apache.org/jira/browse/DISPATCH-2036
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Protocol Adaptors
>Affects Versions: 1.15.0
>Reporter: Ken Giusti
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.19.0
>
>
> Since TCP adaptor uses long lived deliveries the delayed delivery detection 
> logic flags these deliveries as stuck.  This occurs on each intermediate 
> router as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-1915) Remove deprecated Proton Url python class

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1915:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Remove deprecated Proton Url python class
> -
>
> Key: DISPATCH-1915
> URL: https://issues.apache.org/jira/browse/DISPATCH-1915
> Project: Qpid Dispatch
>  Issue Type: Task
>  Components: Routing Engine, Tools
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Priority: Major
> Fix For: 1.19.0
>
>
> This has been deprecated since Proton 0.27.0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2137) multiple data races in the SASL plugin

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2137:

Fix Version/s: (was: 1.18.0)
   Backlog

> multiple data races in the SASL plugin
> --
>
> Key: DISPATCH-2137
> URL: https://issues.apache.org/jira/browse/DISPATCH-2137
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.16.0
>Reporter: Ken Giusti
>Assignee: Ganesh Murthy
>Priority: Critical
>  Labels: race-condition, tsan
> Fix For: Backlog
>
>
> 44: WARNING: ThreadSanitizer: data race (pid=652787) 
> 44: Read of size 1 at 0x7b32ddc0 by main thread: 
> 44: #0 remote_sasl_prepare 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/remote_sasl.c:344 
> (libqpid-dispatch.so+0xab480) 
> 44: #1 pni_sasl_impl_prepare_write 
> /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:219 
> (libqpid-proton-core.so.10+0x2895b) 
> 44: #2 pn_output_write_sasl 
> /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:691 
> (libqpid-proton-core.so.10+0x2895b) 
> 44: #3 qd_server_run 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1501 
> (libqpid-dispatch.so+0x132935) 
> 44: #4 main_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:115 
> (qdrouterd+0x40271a) 
> 44: #5 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 
> (qdrouterd+0x403557) 
> 44: 
> 44: Previous write of size 1 at 0x7b32ddc0 by thread T4: 
> 44: #0 notify_downstream 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/remote_sasl.c:276 
> (libqpid-dispatch.so+0xaaf79) 
> 44: #1 remote_sasl_process_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/remote_sasl.c:445 
> (libqpid-dispatch.so+0xabb75) 
> 44: #2 pni_sasl_impl_process_init 
> /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:224 
> (libqpid-proton-core.so.10+0x297b5) 
> 44: #3 pn_do_init /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:903 
> (libqpid-proton-core.so.10+0x297b5) 
> 44: #4 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad38a) 
> 44: #5   (libtsan.so.0+0x2d33f)
>  
> 
> 44: Read of size 8 at 0x7b32dda8 by main thread: 
> 44: #0 remote_sasl_prepare 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/remote_sasl.c:345 
> (libqpid-dispatch.so+0xab4a5) 
> 44: #1 pni_sasl_impl_prepare_write 
> /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:219 
> (libqpid-proton-core.so.10+0x2895b) 
> 44: #2 pn_output_write_sasl 
> /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:691 
> (libqpid-proton-core.so.10+0x2895b) 
> 44: #3 qd_server_run 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1501 
> (libqpid-dispatch.so+0x132935) 
> 44: #4 main_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:115 
> (qdrouterd+0x40271a) 
> 44: #5 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 
> (qdrouterd+0x403557) 
> 44: 
> 44: Previous write of size 8 at 0x7b32dda8 by thread T4: 
> 44: #0 remote_sasl_process_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/remote_sasl.c:443 
> (libqpid-dispatch.so+0xabb40) 
> 44: #1 pni_sasl_impl_process_init 
> /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:224 
> (libqpid-proton-core.so.10+0x297b5) 
> 44: #2 pn_do_init /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:903 
> (libqpid-proton-core.so.10+0x297b5) 
> 44: #3 _thread_init 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 
> (libqpid-dispatch.so+0xad38a) 
> 44: #4   (libtsan.so.0+0x2d33f)
>  
> --
> 44: Read of size 8 at 0x7b0418b0 by main thread: 
> 44: #0 strlen  (libtsan.so.0+0x32c4f) 
> 44: #1 pn_strdup /home/kgiusti/work/proton/qpid-proton/c/src/core/util.c:122 
> (libqpid-proton-core.so.10+0x26b3c) 
> 44: #2 pnx_sasl_set_selected_mechanism 
> /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:147 
> (libqpid-proton-core.so.10+0x26b3c) 
> 44: #3 pni_sasl_impl_prepare_write 
> /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:219 
> (libqpid-proton-core.so.10+0x2895b) 
> 44: #4 pn_output_write_sasl 
> /home/kgiusti/work/proton/qpid-proton/c/src/sasl/sasl.c:691 
> (libqpid-proton-core.so.10+0x2895b) 
> 44: #5 qd_server_run 
> /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1501 
> (libqpid-dispatch.so+0x132935) 
> 44: #6 main_process 
> /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:115 
> (qdrouterd+0x40271a) 
> 44: #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 
> (qdrouterd+0x403557) 
> 44: 
> 44: Previous write of size 8 at 0x7b0418b0 by thread T4: 
> 44: #0 malloc  (libtsan.so.0+0x304d3) 
> 44: #1 __GI___strdup 
> /usr/src/debug

[jira] [Updated] (DISPATCH-1992) [tcp] Use PN_RAW_CONNECTION_DRAIN_BUFFERS in tcp adaptor

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1992:

Fix Version/s: (was: 1.18.0)
   1.19.0

> [tcp] Use PN_RAW_CONNECTION_DRAIN_BUFFERS in tcp adaptor
> 
>
> Key: DISPATCH-1992
> URL: https://issues.apache.org/jira/browse/DISPATCH-1992
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Protocol Adaptors
>Reporter: Ganesh Murthy
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.19.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-1994) [http2] Use PN_RAW_CONNECTION_DRAIN_BUFFERS in http2 adaptor

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1994:

Fix Version/s: (was: 1.18.0)
   1.19.0

> [http2] Use PN_RAW_CONNECTION_DRAIN_BUFFERS in http2 adaptor
> 
>
> Key: DISPATCH-1994
> URL: https://issues.apache.org/jira/browse/DISPATCH-1994
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Protocol Adaptors
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Minor
> Fix For: 1.19.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-1993) [http1] Use PN_RAW_CONNECTION_DRAIN_BUFFERS in http1 adaptor

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-1993:

Fix Version/s: (was: 1.18.0)
   1.19.0

> [http1] Use PN_RAW_CONNECTION_DRAIN_BUFFERS in http1 adaptor
> 
>
> Key: DISPATCH-1993
> URL: https://issues.apache.org/jira/browse/DISPATCH-1993
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Protocol Adaptors
>Reporter: Ganesh Murthy
>Assignee: Ken Giusti
>Priority: Minor
>  Labels: HTTP/1.x
> Fix For: 1.19.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-1957) Leaked objects in system_tests_delivery_abort

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy resolved DISPATCH-1957.
-
Resolution: Fixed

> Leaked objects in system_tests_delivery_abort
> -
>
> Key: DISPATCH-1957
> URL: https://issues.apache.org/jira/browse/DISPATCH-1957
> Project: Qpid Dispatch
>  Issue Type: Test
>Affects Versions: 1.15.0
> Environment: rhel 8
>Reporter: Ganesh Murthy
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.18.0
>
>
> There are several leaked objects shown in the following test output. These 
> seem to be router shutdown leaks. We need to come up with a strategy to 
> systematically take care of these kinds of leaks.
> {noformat}
> Stacktracetest_01_message_route_truncated_one_router 
> (system_tests_delivery_abort.RouterTest) ... ok
> test_02_message_route_truncated_two_routers 
> (system_tests_delivery_abort.RouterTest) ... ok
> test_03_link_route_truncated_one_router 
> (system_tests_delivery_abort.RouterTest) ... ok
> test_04_link_route_truncated_two_routers 
> (system_tests_delivery_abort.RouterTest) ... ok
> test_05_message_route_abort_one_router 
> (system_tests_delivery_abort.RouterTest) ... ok
> test_06_message_route_abort_two_routers 
> (system_tests_delivery_abort.RouterTest) ... ok
> test_07_multicast_truncate_one_router 
> (system_tests_delivery_abort.RouterTest) ... ok
> Router B debug dump file:
> 
> alloc.c: Items of type 'qd_iterator_t' remain allocated at shutdown: 10 
> (SUPPRESSED)
> alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1 
> (SUPPRESSED)
> alloc.c: Items of type 'qd_bitmask_t' remain allocated at shutdown: 1
> Leak: 2021-02-11 11:17:27.438173 -0500 type: qd_bitmask_t address: 0x2c80010
> /opt/qpid-dispatch-src/build/src/libqpid-dispatch.so(qd_alloc+0x20c) 
> [0x7f615186bf67]
> /opt/qpid-dispatch-src/build/src/libqpid-dispatch.so(new_qd_bitmask_t+0x26) 
> [0x7f615186d58c]
> /opt/qpid-dispatch-src/build/src/libqpid-dispatch.so(qd_bitmask+0x10) 
> [0x7f615186d66a]
> /opt/qpid-dispatch-src/build/src/libqpid-dispatch.so(qd_tracemask_create+0x1e)
>  [0x7f61518e58c6]
> /opt/qpid-dispatch-src/build/src/libqpid-dispatch.so(+0xbcbc1) 
> [0x7f61518d8bc1]
> /opt/qpid-dispatch-src/build/src/libqpid-dispatch.so(+0xbd88f) 
> [0x7f61518d988f]
> /opt/qpid-dispatch-src/build/src/libqpid-dispatch.so(+0x59763) 
> [0x7f6151875763]
> /opt/qpid-dispatch-src/build/src/libqpid-dispatch.so(qd_container_handle_event+0xd09)
>  [0x7f6151876f42]
> /opt/qpid-dispatch-src/build/src/libqpid-dispatch.so(+0xc6296) 
> [0x7f61518e2296]
> /opt/qpid-dispatch-src/build/src/libqpid-dispatch.so(+0xc636c) 
> [0x7f61518e236c]
> alloc.c: Items of type 'qd_buffer_t' remain allocated at shutdown: 5 
> (SUPPRESSED)
> alloc.c: Items of type 'qd_parsed_field_t' remain allocated at shutdown: 4 
> (SUPPRESSED)
> alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1 
> (SUPPRESSED)
> alloc.c: Items of type 'qd_message_t' remain allocated at shutdown: 2 
> (SUPPRESSED)
> alloc.c: Items of type 'qd_message_content_t' remain allocated at shutdown: 1 
> (SUPPRESSED)
> alloc.c: Items of type 'qdr_delivery_t' remain allocated at shutdown: 2 
> (SUPPRESSED)
> alloc.c: Items of type 'qd_link_ref_t' remain allocated at shutdown: 1 
> (SUPPRESSED)
> 
> Router B output file:
> 
> ERROR: Aborted due to unexpected alloc pool leak of type 'qd_bitmask_t'
> 
> Router B command file:
> 
> qdrouterd -c B.conf -I /opt/qpid-dispatch-src/python
> pid=12488
> 
> Router B log file tail:
> 
> 2021-02-11 11:17:29.457738 -0500 ROUTER_CORE (debug) [C9][L38][D118] Delivery 
> outcome : is accepted (0x24) 
> (/opt/qpid-dispatch-src/src/router_core/delivery.c:395)
> 2021-02-11 11:17:29.457753 -0500 ROUTER_CORE (trace) Core action 
> 'update_delivery' 
> (/opt/qpid-dispatch-src/src/router_core/router_core_thread.c:238)
> 2021-02-11 11:17:29.457762 -0500 ROUTER_CORE (debug) [C1][L16][D117] Delivery 
> incref:rc:4  qdr_delivery_anycast_update_CT - prevent peer from being 
> freed (/opt/qpid-dispatch-src/src/router_core/delivery.c:113)
> 2021-02-11 11:17:29.457771 -0500 ROUTER_CORE (trace) [C9][L38][D119] :in 
> qdr_delivery_unlink_peers_CT out: [C1][L16][D117] 
> (/opt/qpid-dispatch-src/src/router_core/delivery.c:542)
> 2021-02-11 11:17:29.457781 -0500 ROUTER_CORE (debug) [C9][L38][D119] Delivery 
> decref_CT: rc:2 qdr_delivery_unlink_peers_CT - unlinked from peer (delivery) 
> (/opt/qpid-dispatch-src/src/router_core/delivery.c:640)
> 2021-02-11 11:17:29.457794 -0500 ROUTER_CORE (debug) [C1][L16][D117] Delivery 
> decref_CT: rc:3 qdr_delivery_unlink_peers_CT - unlinked from delivery (peer) 
> (/opt/qpid-dispatch-src/src/router_core/delivery.c:640)
> 2021-02-11 11:17:29.457807 -0500 ROUTER_CORE (debug) [C1][L16][D117] D

[jira] [Updated] (DISPATCH-2000) Consider increasing default internal buffer size

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2000:

Fix Version/s: (was: 1.18.0)
   1.19.0

> Consider increasing default internal buffer size
> 
>
> Key: DISPATCH-2000
> URL: https://issues.apache.org/jira/browse/DISPATCH-2000
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Charles E. Rolke
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.19.0
>
>
> Tests with the TCP adaptor and a 4k-byte buffer size show _significant 
> throughput increases_ with _otherwise minimal code changes_. For this 
> discussion, assume that the new buffer size will be 4k bytes.
> Note: This discussion nearly parallels the discussion of increasing hard 
> drive sector size to 4K. See [Transition to Advanced Format 4K Sector Hard 
> Drives 
> |[https://www.seagate.com/tech-insights/advanced-format-4k-sector-hard-drives-master-ti/].]
>  The pros and cons of increasing the size for disk drives and for 
> qpid-dispatch are pretty much the same.
> Dispatch has never had anything but 512-byte internal buffers. This lends a 
> lot of weight for keeping the current setting. However, from day one the self 
> tests exercise various buffer sizes from 1-byte to 1-bytes and the tests 
> have worked fine. This is a positive indication that physically the buffer 
> functions and buffer management proper would work with any buffer size.
> Logically there are some other issues. These must be understood and 
> considered before moving forward with any change.
>  * Expect total memory usage to go up due to unused buffer space with small 
> messages
>  * Expect total memory usage to go down due to more efficient buffer use with 
> large messages
>  * Policy implements Q2 throttling with a buffer count limit. If that limit 
> is not adjusted then flow control will not take effect until 8x as much AMQP 
> session data has been buffered.
> Adjusting the buffer size from 512 to 4096 must happen either at compile time 
> or at run time very early, before qd_router_setup_late() is called, when 
> buffers start being created and buffer size cannot be changed any more. A 
> pull request is in the works that adds a --4k-buffer switch to the command 
> line to simplify testing with the larger buffer size.
> I expect that going to 4K buffers will have a performance improvement 
> certainly for the TCP adaptor but also for the other protocol adaptors and 
> for AMQP as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2000) Consider increasing default internal buffer size

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2000:

Priority: Major  (was: Critical)

> Consider increasing default internal buffer size
> 
>
> Key: DISPATCH-2000
> URL: https://issues.apache.org/jira/browse/DISPATCH-2000
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Router Node
>Affects Versions: 1.15.0
>Reporter: Charles E. Rolke
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> Tests with the TCP adaptor and a 4k-byte buffer size show _significant 
> throughput increases_ with _otherwise minimal code changes_. For this 
> discussion, assume that the new buffer size will be 4k bytes.
> Note: This discussion nearly parallels the discussion of increasing hard 
> drive sector size to 4K. See [Transition to Advanced Format 4K Sector Hard 
> Drives 
> |[https://www.seagate.com/tech-insights/advanced-format-4k-sector-hard-drives-master-ti/].]
>  The pros and cons of increasing the size for disk drives and for 
> qpid-dispatch are pretty much the same.
> Dispatch has never had anything but 512-byte internal buffers. This lends a 
> lot of weight for keeping the current setting. However, from day one the self 
> tests exercise various buffer sizes from 1-byte to 1-bytes and the tests 
> have worked fine. This is a positive indication that physically the buffer 
> functions and buffer management proper would work with any buffer size.
> Logically there are some other issues. These must be understood and 
> considered before moving forward with any change.
>  * Expect total memory usage to go up due to unused buffer space with small 
> messages
>  * Expect total memory usage to go down due to more efficient buffer use with 
> large messages
>  * Policy implements Q2 throttling with a buffer count limit. If that limit 
> is not adjusted then flow control will not take effect until 8x as much AMQP 
> session data has been buffered.
> Adjusting the buffer size from 512 to 4096 must happen either at compile time 
> or at run time very early, before qd_router_setup_late() is called, when 
> buffers start being created and buffer size cannot be changed any more. A 
> pull request is in the works that adds a --4k-buffer switch to the command 
> line to simplify testing with the larger buffer size.
> I expect that going to 4K buffers will have a performance improvement 
> certainly for the TCP adaptor but also for the other protocol adaptors and 
> for AMQP as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-2005) [http2] grpc performance test with buoyantio lot slower with router in the middle

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-2005:

Fix Version/s: (was: 1.18.0)
   1.19.0

> [http2] grpc performance test with buoyantio lot slower with router in the 
> middle
> -
>
> Key: DISPATCH-2005
> URL: https://issues.apache.org/jira/browse/DISPATCH-2005
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.19.0
>
>
> [https://github.com/buoyantio/strest-grpc]
> Test was run for 10 seconds
> Without router
> {noformat}
>  [gmurthy@localhost linux]$ ./strest-grpc client --address localhost:1 
> --latencyUnit us
>   {
>   "good": 58143,
>   "bad": 0,
>   "bytes": 0,
>   "latency": {
> "p50": 118,
> "p75": 129,
> "p90": 144,
> "p95": 163,
> "p99": 356,
> "p999": 6675
>   },
>   "jitter": {
> "p50": 0,
> "p75": 0,
> "p90": 0,
> "p95": 0,
> "p99": 0,
> "p999": 0
>   }
> }{noformat}
>  
> With router
> {noformat}
>  [gmurthy@localhost linux]$ ./strest-grpc client --address localhost:9000 
> --latencyUnit us
>  {
>   "good": 2983,
>   "bad": 0,
>   "bytes": 0,
>   "latency": {
> "p50": 1842,
> "p75": 2383,
> "p90": 3567,
> "p95": 4379,
> "p99": 5827,
> "p999": 21215
>   },
>   "jitter": {
> "p50": 0,
> "p75": 0,
> "p90": 0,
> "p95": 0,
> "p99": 0,
> "p999": 0
>   }
> }
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1958) Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437446#comment-17437446
 ] 

ASF GitHub Bot commented on DISPATCH-1958:
--

ganeshmurthy commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-957887593


   > hmmm... I wonder if it would be simpler to make QD_MEMORY_STATS 
non-configurable? IOW, get rid of the flag and just always provide memory 
statistics. It's pretty obvious we haven't tested QD_MEMORY_STATS=OFF as part 
of our CI.
   > 
   > Just an opinion, thoughts?
   
   I am all for getting rid of the flag once and for all and always provide 
memory statistics but first I want to understand why this flag was introduced 
in the first place ? 
   If we decide to keep this flag, we need to augment CI (preferably GHA) to 
test with QD_MEMORY_STATS=OFF. That will add *yet another* build type to the 
already long list of tests we run, so I am inclined to say let's just get rid 
of this flag.
   
   @ted-ross  what do you think ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`
> 
>
> Key: DISPATCH-1958
> URL: https://issues.apache.org/jira/browse/DISPATCH-1958
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tools
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> From the README
> {noformat}
> -DQD_MEMORY_STATS=
> --
> Dispatch will track memory pool usage statistics if this is enabled.
> {noformat}
> So the statistics may not be always available, depending on the way 
> Dispatch is compiled.
> Allocator metrics get reported as 0. I see that {{qdmanage}} works just fine, 
> but {{qdstat}} is throwing an error in such case:
> {noformat}
> $ qdstat -m
> 2021-02-04 15:08:19.288818 UTC
> Standalone_v++jCPCjYiQcGo3
> TypeError: unsupported operand type(s) for *: 'int32' and 'NoneType'
> {noformat}
> Found during PR review by [~fgiorget].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #1416: DISPATCH-1958: Fixed error in qdstat when memory stats are turned off…

[GitBox]

ganeshmurthy commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-957887593


   > hmmm... I wonder if it would be simpler to make QD_MEMORY_STATS 
non-configurable? IOW, get rid of the flag and just always provide memory 
statistics. It's pretty obvious we haven't tested QD_MEMORY_STATS=OFF as part 
of our CI.
   > 
   > Just an opinion, thoughts?
   
   I am all for getting rid of the flag once and for all and always provide 
memory statistics but first I want to understand why this flag was introduced 
in the first place ? 
   If we decide to keep this flag, we need to augment CI (preferably GHA) to 
test with QD_MEMORY_STATS=OFF. That will add *yet another* build type to the 
already long list of tests we run, so I am inclined to say let's just get rid 
of this flag.
   
   @ted-ross  what do you think ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1821) Double-free in qd_entity_configure_policy on error

[Jira]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437445#comment-17437445
 ] 

Jiri Daněk commented on DISPATCH-1821:
--

[~kgiusti] The code in question is quite weird and could be probably somewhat 
improved. (If I remember the previous thinking, the idea is that more correct 
handling there is to fail startup and don't try to recover.) Other than that, 
there is probably little to be done about this.

> Double-free in qd_entity_configure_policy on error
> --
>
> Key: DISPATCH-1821
> URL: https://issues.apache.org/jira/browse/DISPATCH-1821
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Policy Engine
>Affects Versions: 1.14.0
>Reporter: Jiri Daněk
>Assignee: Charles E. Rolke
>Priority: Trivial
>  Labels: clang-analyzer
> Fix For: 1.18.0
>
>
> As far as I can tell, this double-free is near impossible in normal operation 
> of the router. Below, it is reproduced using a test, which passes in a value 
> for that cannot be converted to a Python bool. There is no way for a 
> legitimate user to make this happen.
> Regarding a fix, I am not sure what the router should do when it detect 
> invalid configuration. Freeing qd->policy is IMO not the right response, 
> because that is normally freed in qd_dispatch_free. Printing an error and 
> carying on (that now happens for {{maxConnections < 0}}) does not seem right 
> to me either (but it's probably needed in case the config is changed through 
> remote management interface),
> {noformat}
> 2020-11-02 09:48:51.887312 +0100 ROUTER_CORE (info) In-process subscription 
> L/$management
> 2020-11-02 09:48:51.939210 +0100 ERROR (error) Python: NotImplementedError: 
> 2020-11-02 09:48:51.941666 +0100 ERROR (error) Traceback (most recent call 
> last):
>   File "test_module", line 3, in __bool__
> NotImplementedError
> =
> ==27615==ERROR: AddressSanitizer: attempting double-free on 0x60201810 in 
> thread T0:
> #0 0x7f876d5191d7 in __interceptor_free 
> (/nix/store/zhbhxp4jgalycwffildy2bwcgmrsmayk-gcc-9.2.0-lib/lib/libasan.so.5+0x10a1d7)
> #1 0x7f876cd33b95 in qd_policy_free ../src/policy.c:136
> #2 0x7f876cd347cf in qd_entity_configure_policy ../src/policy.c:178
> #3 0x4ef6a6 in _DOCTEST_ANON_FUNC_6 
> ../tests/c_unittests/test_policy.cpp:75
> #4 0x493edd in doctest::Context::run() ../tests/c_unittests/doctest.h:5849
> #5 0x4974e9 in main ../tests/c_unittests/doctest.h:5933
> #6 0x7f876b610d8a in __libc_start_main 
> (/nix/store/xg6ilb9g9zhi2zg1dpi4zcp288rhnvns-glibc-2.30/lib/libc.so.6+0x23d8a)
> #7 0x43cd99 in _start 
> (/home/jdanek/repos/qpid/qpid-dispatch/cmake-build-debug/tests/c_unittests/c_unittests+0x43cd99)
> 0x60201810 is located 0 bytes inside of 5-byte region 
> [0x60201810,0x60201815)
> freed by thread T0 here:
> #0 0x7f876d5191d7 in __interceptor_free 
> (/nix/store/zhbhxp4jgalycwffildy2bwcgmrsmayk-gcc-9.2.0-lib/lib/libasan.so.5+0x10a1d7)
> #1 0x7f876cd347c3 in qd_entity_configure_policy ../src/policy.c:177
> #2 0x4ef6a6 in _DOCTEST_ANON_FUNC_6 
> ../tests/c_unittests/test_policy.cpp:75
> #3 0x493edd in doctest::Context::run() ../tests/c_unittests/doctest.h:5849
> #4 0x4974e9 in main ../tests/c_unittests/doctest.h:5933
> #5 0x7f876b610d8a in __libc_start_main 
> (/nix/store/xg6ilb9g9zhi2zg1dpi4zcp288rhnvns-glibc-2.30/lib/libc.so.6+0x23d8a)
> previously allocated by thread T0 here:
> #0 0x7f876d4a40b5 in strdup 
> (/nix/store/zhbhxp4jgalycwffildy2bwcgmrsmayk-gcc-9.2.0-lib/lib/libasan.so.5+0x950b5)
> #1 0x7f876cec8c99 in py_string_2_c ../src/python_utils.c:35
> #2 0x7f876cce21e2 in qd_entity_get_string ../src/entity.c:49
> #3 0x7f876cce2b5f in qd_entity_opt_string ../src/entity.c:84
> #4 0x7f876cd341b0 in qd_entity_configure_policy ../src/policy.c:161
> #5 0x4ef6a6 in _DOCTEST_ANON_FUNC_6 
> ../tests/c_unittests/test_policy.cpp:75
> #6 0x493edd in doctest::Context::run() ../tests/c_unittests/doctest.h:5849
> #7 0x4974e9 in main ../tests/c_unittests/doctest.h:5933
> #8 0x7f876b610d8a in __libc_start_main 
> (/nix/store/xg6ilb9g9zhi2zg1dpi4zcp288rhnvns-glibc-2.30/lib/libc.so.6+0x23d8a)
> SUMMARY: AddressSanitizer: double-free 
> (/nix/store/zhbhxp4jgalycwffildy2bwcgmrsmayk-gcc-9.2.0-lib/lib/libasan.so.5+0x10a1d7)
>  in __interceptor_free
> ==27615==ABORTING
> Process finished with exit code 1
> {noformat}
> The test which follows is currently missing PY decrefs. 
> {noformat}
> #include 
> #include 
> #include "helpers.hpp"
> #include "qdr_doctest.h"
> extern "C" {
> #include 
> #include 
> #include 
> #include 
> #include 
> #include 
> #include 
> }
> TEST_CASE("policy") {
>

[jira] [Assigned] (DISPATCH-2103) Log the actual HTTP websocket listener port when 0 was specified in config

[Jira]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Daněk reassigned DISPATCH-2103:


Assignee: Jiri Daněk

> Log the actual HTTP websocket listener port when 0 was specified in config
> --
>
> Key: DISPATCH-2103
> URL: https://issues.apache.org/jira/browse/DISPATCH-2103
> Project: Qpid Dispatch
>  Issue Type: New Feature
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
> {code}
> if (hl->vhost) {
> /* Store hl pointer in vhost */
> void *vp = lws_protocol_vh_priv_zalloc(hl->vhost, &protocols[0], 
> sizeof(hl));
> memcpy(vp, &hl, sizeof(hl));
> qd_log(hs->log, QD_LOG_NOTICE, "Listening for HTTP on %s", 
> config->host_port);
> return;
> } else {
> qd_log(hs->log, QD_LOG_NOTICE, "Error listening for HTTP on %s", 
> config->host_port);
> goto error;
> }
> return;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org