[jira] [Commented] (PROTON-2705) [protonj2] Sender Tracker future can be completed before state is fully updated
[ https://issues.apache.org/jira/browse/PROTON-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708611#comment-17708611 ] ASF subversion and git services commented on PROTON-2705: - Commit 09bc72ee41ddc2b9fceb27d36e40d070b7ef31ac in qpid-protonj2's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=09bc72ee ] PROTON-2705 Ensure tracker state is in sync with future completion Ensure that remote settlement state is correct when the settlement future is completed. > [protonj2] Sender Tracker future can be completed before state is fully > updated > --- > > Key: PROTON-2705 > URL: https://issues.apache.org/jira/browse/PROTON-2705 > Project: Qpid Proton > Issue Type: Bug > Components: protonj2 >Affects Versions: protonj2-1.0.0-M13 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Major > Fix For: protonj2-1.0.0-M14 > > > The Tracker returned from a send can have its internal settlement Future > completed before the remote state data is updated and made visible meaning > that calls to get remote state after checking the Future is completed might > not return the correct values. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2705) [protonj2] Sender Tracker future can be completed before state is fully updated
[ https://issues.apache.org/jira/browse/PROTON-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy A. Bish resolved PROTON-2705. - Resolution: Fixed > [protonj2] Sender Tracker future can be completed before state is fully > updated > --- > > Key: PROTON-2705 > URL: https://issues.apache.org/jira/browse/PROTON-2705 > Project: Qpid Proton > Issue Type: Bug > Components: protonj2 >Affects Versions: protonj2-1.0.0-M13 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Major > Fix For: protonj2-1.0.0-M14 > > > The Tracker returned from a send can have its internal settlement Future > completed before the remote state data is updated and made visible meaning > that calls to get remote state after checking the Future is completed might > not return the correct values. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2705) [protonj2] Sender Tracker future can be completed before state is fully updated
Timothy A. Bish created PROTON-2705: --- Summary: [protonj2] Sender Tracker future can be completed before state is fully updated Key: PROTON-2705 URL: https://issues.apache.org/jira/browse/PROTON-2705 Project: Qpid Proton Issue Type: Bug Components: protonj2 Affects Versions: protonj2-1.0.0-M13 Reporter: Timothy A. Bish Assignee: Timothy A. Bish Fix For: protonj2-1.0.0-M14 The Tracker returned from a send can have its internal settlement Future completed before the remote state data is updated and made visible meaning that calls to get remote state after checking the Future is completed might not return the correct values. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2704) [Python] The examples test hangs
[ https://issues.apache.org/jira/browse/PROTON-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708567#comment-17708567 ] ASF subversion and git services commented on PROTON-2704: - Commit 0f93611a52dbd4774abd0c686859281980dd5676 in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=0f93611a5 ] PROTON-2704: Make sure example tester terminates server Previously if the client didn't produce the expected result an exception was thrown which bypassed terminsting the server which would make the test hang. > [Python] The examples test hangs > > > Key: PROTON-2704 > URL: https://issues.apache.org/jira/browse/PROTON-2704 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.39.0 >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.39.0 > > > Running the python examples via the unittest in the examples directory hangs > at the various sync client tests. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2704) [Python] The examples test hangs
[ https://issues.apache.org/jira/browse/PROTON-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708568#comment-17708568 ] ASF subversion and git services commented on PROTON-2704: - Commit 6b29f6d848828f5d0cd5706333c6570e71cbc666 in qpid-proton's branch refs/heads/main from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=6b29f6d84 ] PROTON-2704: Reorganise python code to avoid runtime import of _events This runtime import was causing an exception at shutdown with the new cffi based code as it can happen in a delete operation in the middle of shutting down python. This was causing the test to hang. > [Python] The examples test hangs > > > Key: PROTON-2704 > URL: https://issues.apache.org/jira/browse/PROTON-2704 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.39.0 >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.39.0 > > > Running the python examples via the unittest in the examples directory hangs > at the various sync client tests. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2704) [Python] The examples test hangs
Andrew Stitcher created PROTON-2704: --- Summary: [Python] The examples test hangs Key: PROTON-2704 URL: https://issues.apache.org/jira/browse/PROTON-2704 Project: Qpid Proton Issue Type: Bug Components: python-binding Affects Versions: proton-c-0.39.0 Reporter: Andrew Stitcher Assignee: Andrew Stitcher Fix For: proton-c-0.39.0 Running the python examples via the unittest in the examples directory hangs at the various sync client tests. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2355) Implement the `format` attribute for `qd_log_impl` and other such functions to hopefully have compile-time check for format strings
[
https://issues.apache.org/jira/browse/DISPATCH-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708379#comment-17708379
]
ASF subversion and git services commented on DISPATCH-2355:
---
Commit e9add40d5a4218140f57581f759eb457022e2e60 in qpid-dispatch's branch
refs/heads/main from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=e9add40d ]
DISPATCH-2355: Implement the `format` attribute for `qd_log_impl` and other
such functions to hopefully have compile-time check for format strings (#1630)
This is backported code from skupper-router,
https://github.com/skupperproject/skupper-router/issues/1011
> Implement the `format` attribute for `qd_log_impl` and other such functions
> to hopefully have compile-time check for format strings
> ---
>
> Key: DISPATCH-2355
> URL: https://issues.apache.org/jira/browse/DISPATCH-2355
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.19.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.20.0
>
> Attachments: image-2023-04-02-21-25-09-798.png
>
>
> https://gcc.gnu.org/onlinedocs/gcc-8.2.0/gcc/Common-Function-Attributes.html#Common-Function-Attributes
> {code}
> void qd_log_impl(qd_log_source_t *source, qd_log_level_t level, const char
> *file, int line, const char *fmt, ...) __attribute__(( format(printf,5,6) ));
> {code}
> !image-2023-04-02-21-25-09-798.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2356) CFFI Proton now installs whl into dist/, previously it was in pkgs/
[ https://issues.apache.org/jira/browse/DISPATCH-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk resolved DISPATCH-2356. -- Resolution: Fixed > CFFI Proton now installs whl into dist/, previously it was in pkgs/ > --- > > Key: DISPATCH-2356 > URL: https://issues.apache.org/jira/browse/DISPATCH-2356 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.20.0 >Reporter: Jiri Daněk >Priority: Major > Fix For: 1.20.0 > > > Ci is failing with Proton main on being unable to install the whl > https://github.com/apache/qpid-dispatch/actions/runs/4295869746/jobs/7486862258#step:18:34 > See https://github.com/skupperproject/skupper-router/pull/928 for discussion > about the fix. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2355) Implement the `format` attribute for `qd_log_impl` and other such functions to hopefully have compile-time check for format strings
[
https://issues.apache.org/jira/browse/DISPATCH-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk resolved DISPATCH-2355.
--
Resolution: Fixed
> Implement the `format` attribute for `qd_log_impl` and other such functions
> to hopefully have compile-time check for format strings
> ---
>
> Key: DISPATCH-2355
> URL: https://issues.apache.org/jira/browse/DISPATCH-2355
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.19.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.20.0
>
> Attachments: image-2023-04-02-21-25-09-798.png
>
>
> https://gcc.gnu.org/onlinedocs/gcc-8.2.0/gcc/Common-Function-Attributes.html#Common-Function-Attributes
> {code}
> void qd_log_impl(qd_log_source_t *source, qd_log_level_t level, const char
> *file, int line, const char *fmt, ...) __attribute__(( format(printf,5,6) ));
> {code}
> !image-2023-04-02-21-25-09-798.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2355) Implement the `format` attribute for `qd_log_impl` and other such functions to hopefully have compile-time check for format strings
[
https://issues.apache.org/jira/browse/DISPATCH-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708378#comment-17708378
]
ASF GitHub Bot commented on DISPATCH-2355:
--
jiridanek merged PR #1630:
URL: https://github.com/apache/qpid-dispatch/pull/1630
> Implement the `format` attribute for `qd_log_impl` and other such functions
> to hopefully have compile-time check for format strings
> ---
>
> Key: DISPATCH-2355
> URL: https://issues.apache.org/jira/browse/DISPATCH-2355
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.19.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.20.0
>
> Attachments: image-2023-04-02-21-25-09-798.png
>
>
> https://gcc.gnu.org/onlinedocs/gcc-8.2.0/gcc/Common-Function-Attributes.html#Common-Function-Attributes
> {code}
> void qd_log_impl(qd_log_source_t *source, qd_log_level_t level, const char
> *file, int line, const char *fmt, ...) __attribute__(( format(printf,5,6) ));
> {code}
> !image-2023-04-02-21-25-09-798.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #1630: DISPATCH-2355: Implement the `format` attribute for `qd_log_impl` and…
jiridanek merged PR #1630: URL: https://github.com/apache/qpid-dispatch/pull/1630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2355) Implement the `format` attribute for `qd_log_impl` and other such functions to hopefully have compile-time check for format strings
[
https://issues.apache.org/jira/browse/DISPATCH-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708377#comment-17708377
]
ASF GitHub Bot commented on DISPATCH-2355:
--
ganeshmurthy commented on PR #1630:
URL: https://github.com/apache/qpid-dispatch/pull/1630#issuecomment-1495789609
> 100% tests pass again!
When it rains, it pours !!
> Implement the `format` attribute for `qd_log_impl` and other such functions
> to hopefully have compile-time check for format strings
> ---
>
> Key: DISPATCH-2355
> URL: https://issues.apache.org/jira/browse/DISPATCH-2355
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.19.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.20.0
>
> Attachments: image-2023-04-02-21-25-09-798.png
>
>
> https://gcc.gnu.org/onlinedocs/gcc-8.2.0/gcc/Common-Function-Attributes.html#Common-Function-Attributes
> {code}
> void qd_log_impl(qd_log_source_t *source, qd_log_level_t level, const char
> *file, int line, const char *fmt, ...) __attribute__(( format(printf,5,6) ));
> {code}
> !image-2023-04-02-21-25-09-798.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #1630: DISPATCH-2355: Implement the `format` attribute for `qd_log_impl` and…
ganeshmurthy commented on PR #1630: URL: https://github.com/apache/qpid-dispatch/pull/1630#issuecomment-1495789609 > 100% tests pass again! When it rains, it pours !! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2355) Implement the `format` attribute for `qd_log_impl` and other such functions to hopefully have compile-time check for format strings
[
https://issues.apache.org/jira/browse/DISPATCH-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708369#comment-17708369
]
ASF GitHub Bot commented on DISPATCH-2355:
--
jiridanek commented on PR #1630:
URL: https://github.com/apache/qpid-dispatch/pull/1630#issuecomment-1495764877
@ganeshmurthy 100% tests pass again!
> Implement the `format` attribute for `qd_log_impl` and other such functions
> to hopefully have compile-time check for format strings
> ---
>
> Key: DISPATCH-2355
> URL: https://issues.apache.org/jira/browse/DISPATCH-2355
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.19.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.20.0
>
> Attachments: image-2023-04-02-21-25-09-798.png
>
>
> https://gcc.gnu.org/onlinedocs/gcc-8.2.0/gcc/Common-Function-Attributes.html#Common-Function-Attributes
> {code}
> void qd_log_impl(qd_log_source_t *source, qd_log_level_t level, const char
> *file, int line, const char *fmt, ...) __attribute__(( format(printf,5,6) ));
> {code}
> !image-2023-04-02-21-25-09-798.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1630: DISPATCH-2355: Implement the `format` attribute for `qd_log_impl` and…
jiridanek commented on PR #1630: URL: https://github.com/apache/qpid-dispatch/pull/1630#issuecomment-1495764877 @ganeshmurthy 100% tests pass again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
