[jira] [Commented] (DISPATCH-1637) Adding new config address, autolinks and link routes become slower as more get added
[
https://issues.apache.org/jira/browse/DISPATCH-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117033#comment-17117033
]
Michael Cressman commented on DISPATCH-1637:
If the work is done here, you can resolve it. The parse tree fix is a separate
JIRA: DISPATCH-1642
> Adding new config address, autolinks and link routes become slower as more
> get added
> -
>
> Key: DISPATCH-1637
> URL: https://issues.apache.org/jira/browse/DISPATCH-1637
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.11.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.13.0
>
> Attachments: qdr_perf_core_369301_369302.svg
>
>
> Steps to reproduce -
> # Start the router with a default config file, nothing special
> # Run the following qdmanage command in a loop from 1 to 200,000
> ## qdmanage CREATE --type=address prefix=abc\{i} name=abc\{i}
> distribution=balanced waypoint=yes
> # watch qdstat -g
> # Over time, the rate at which the addresses get added comes to a crawl
> This happens for autoLinks and linkRoutes as well
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1637) Adding new config address, autolinks and link routes become slower as more get added
[
https://issues.apache.org/jira/browse/DISPATCH-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101167#comment-17101167
]
Ganesh Murthy commented on DISPATCH-1637:
-
Not marking this as Resolved yet. [~kgiusti] might have another fix (parse tree)
> Adding new config address, autolinks and link routes become slower as more
> get added
> -
>
> Key: DISPATCH-1637
> URL: https://issues.apache.org/jira/browse/DISPATCH-1637
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.11.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.13.0
>
> Attachments: qdr_perf_core_369301_369302.svg
>
>
> Steps to reproduce -
> # Start the router with a default config file, nothing special
> # Run the following qdmanage command in a loop from 1 to 200,000
> ## qdmanage CREATE --type=address prefix=abc\{i} name=abc\{i}
> distribution=balanced waypoint=yes
> # watch qdstat -g
> # Over time, the rate at which the addresses get added comes to a crawl
> This happens for autoLinks and linkRoutes as well
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1637) Adding new config address, autolinks and link routes become slower as more get added
[
https://issues.apache.org/jira/browse/DISPATCH-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101163#comment-17101163
]
ASF subversion and git services commented on DISPATCH-1637:
---
Commit 936d679f754639895df85b665651ed4d73f3 in qpid-dispatch's branch
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=936d679 ]
DISPATCH-1637: Added a hashtable to store names of link routes, auto links and
address configs. This closes #732.
> Adding new config address, autolinks and link routes become slower as more
> get added
> -
>
> Key: DISPATCH-1637
> URL: https://issues.apache.org/jira/browse/DISPATCH-1637
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.11.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.13.0
>
> Attachments: qdr_perf_core_369301_369302.svg
>
>
> Steps to reproduce -
> # Start the router with a default config file, nothing special
> # Run the following qdmanage command in a loop from 1 to 200,000
> ## qdmanage CREATE --type=address prefix=abc\{i} name=abc\{i}
> distribution=balanced waypoint=yes
> # watch qdstat -g
> # Over time, the rate at which the addresses get added comes to a crawl
> This happens for autoLinks and linkRoutes as well
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1637) Adding new config address, autolinks and link routes become slower as more get added
[
https://issues.apache.org/jira/browse/DISPATCH-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101108#comment-17101108
]
ASF GitHub Bot commented on DISPATCH-1637:
--
kgiusti commented on a change in pull request #732:
URL: https://github.com/apache/qpid-dispatch/pull/732#discussion_r421031191
##
File path: src/router_core/route_control.c
##
@@ -441,6 +454,9 @@ void qdr_route_del_link_route_CT(qdr_core_t *core,
qdr_link_route_t *lr)
}
}
+if (lr->hash_handle)
+qd_hash_remove_by_handle(core->addr_lr_al_hash, lr->hash_handle);
Review comment:
Do we need to keep the hash handle around after this?
If not consider freeing it now and zero the lr->hash_handle.
##
File path: src/router_core/router_core.c
##
@@ -678,6 +684,8 @@ void qdr_core_remove_address_config(qdr_core_t *core,
qdr_address_config_t *addr
qd_iterator_t *pattern = qd_iterator_string(addr->pattern, ITER_VIEW_ALL);
// Remove the address from the list and the parse tree
+if (addr->hash_handle)
+qd_hash_remove_by_handle(core->addr_lr_al_hash, addr->hash_handle);
Review comment:
ditto
##
File path: src/router_core/route_control.c
##
@@ -543,6 +570,9 @@ void qdr_route_del_auto_link_CT(qdr_core_t *core,
qdr_auto_link_t *al)
}
}
+if (al->hash_handle)
+qd_hash_remove_by_handle(core->addr_lr_al_hash, al->hash_handle);
Review comment:
ditto
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Adding new config address, autolinks and link routes become slower as more
> get added
> -
>
> Key: DISPATCH-1637
> URL: https://issues.apache.org/jira/browse/DISPATCH-1637
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.11.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.13.0
>
> Attachments: qdr_perf_core_369301_369302.svg
>
>
> Steps to reproduce -
> # Start the router with a default config file, nothing special
> # Run the following qdmanage command in a loop from 1 to 200,000
> ## qdmanage CREATE --type=address prefix=abc\{i} name=abc\{i}
> distribution=balanced waypoint=yes
> # watch qdstat -g
> # Over time, the rate at which the addresses get added comes to a crawl
> This happens for autoLinks and linkRoutes as well
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1637) Adding new config address, autolinks and link routes become slower as more get added
[
https://issues.apache.org/jira/browse/DISPATCH-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101065#comment-17101065
]
ASF GitHub Bot commented on DISPATCH-1637:
--
ganeshmurthy opened a new pull request #732:
URL: https://github.com/apache/qpid-dispatch/pull/732
… links and address configs
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Adding new config address, autolinks and link routes become slower as more
> get added
> -
>
> Key: DISPATCH-1637
> URL: https://issues.apache.org/jira/browse/DISPATCH-1637
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.11.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.13.0
>
> Attachments: qdr_perf_core_369301_369302.svg
>
>
> Steps to reproduce -
> # Start the router with a default config file, nothing special
> # Run the following qdmanage command in a loop from 1 to 200,000
> ## qdmanage CREATE --type=address prefix=abc\{i} name=abc\{i}
> distribution=balanced waypoint=yes
> # watch qdstat -g
> # Over time, the rate at which the addresses get added comes to a crawl
> This happens for autoLinks and linkRoutes as well
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1637) Adding new config address, autolinks and link routes become slower as more get added
[
https://issues.apache.org/jira/browse/DISPATCH-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097064#comment-17097064
]
Ken Giusti commented on DISPATCH-1637:
--
Attached is a flamegraph taken when the router is struggling to add new
addresses (as described above).
The flamegraph shows the activity of the core thread - this thread happens to
be under the most load during the test.
[^qdr_perf_core_369301_369302.svg]
qdr_manage_create_CT is where the time is spent. A great deal of time involves
parse tree lookup and addition. This is a good candidate for optimization.
> Adding new config address, autolinks and link routes become slower as more
> get added
> -
>
> Key: DISPATCH-1637
> URL: https://issues.apache.org/jira/browse/DISPATCH-1637
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.11.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.13.0
>
> Attachments: qdr_perf_core_369301_369302.svg
>
>
> Steps to reproduce -
> # Start the router with a default config file, nothing special
> # Run the following qdmanage command in a loop from 1 to 200,000
> ## qdmanage CREATE --type=address prefix=abc\{i} name=abc\{i}
> distribution=balanced waypoint=yes
> # watch qdstat -g
> # Over time, the rate at which the addresses get added comes to a crawl
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
