[jira] [Commented] (QPID-7095) [Java Broker] Add meta data for context variables describing their usage
[
https://issues.apache.org/jira/browse/QPID-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214126#comment-15214126
]
Rob Godfrey commented on QPID-7095:
---
{quote}
>From reviewing your changes I take the following:
* yes, my understanding of the intended use of {{@ManagedContextDependency}} is
correct.
* no, the problem was not that {{doWithAllParents}} considers the type
hierarchy instead of the model hierarchy
{quote}
Yep... The interesting thing I found when looking into the issue was that
context defaults defined in {{Broker}} didn't seem to be being processed at
all... I couldn't determine which change had caused this behaviour.
Separately, on your final point in your original comment:
bq. * While not being directly related to your patch I think I would like to
see the default values for ManagedAttributes and ManagedContextDefaults in the
ApiDocs and the MetaData.
I'm in two minds about this - at run time the default value may be overridden
by a system property (potentially automatically overridden through packaged
properties files) and obviously at different points in the configuration, the
context may be overridden. As such the "default" may be wildly misleading.
I think if we want to display the defaults somewhere, maybe there should be a
separate page which just shows system context name -> default value or
something.
> [Java Broker] Add meta data for context variables describing their usage
>
>
> Key: QPID-7095
> URL: https://issues.apache.org/jira/browse/QPID-7095
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Rob Godfrey
>
> Currently there is no way to discover which context variables are used by the
> broker, and the description of what they do. We should add meta data
> covering this and also provide this information through the dynamic API docs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7095) [Java Broker] Add meta data for context variables describing their usage
[
https://issues.apache.org/jira/browse/QPID-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214060#comment-15214060
]
Lorenz Quack commented on QPID-7095:
tl;dr: I think this is okay, now! The mechanism is in place but we still need
to add the actual information.
>From reviewing your changes I take the following:
* yes, my understanding of the intended use of {{@ManagedContextDependency}} is
correct.
* no, the problem was not that {{doWithAllParents}} considers the type
hierarchy instead of the model hierarchy
I found the last point a bit confusing because the declaration of a default
context variable is a global operation while overriding/setting it is a local
operation only affecting children in the model hierarchy. The code under review
is only concerned with the declaration part not with the setting therefore
considering the type hierarchy is fine as long as all are processed eventually.
> [Java Broker] Add meta data for context variables describing their usage
>
>
> Key: QPID-7095
> URL: https://issues.apache.org/jira/browse/QPID-7095
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Rob Godfrey
>
> Currently there is no way to discover which context variables are used by the
> broker, and the description of what they do. We should add meta data
> covering this and also provide this information through the dynamic API docs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7095) [Java Broker] Add meta data for context variables describing their usage
[ https://issues.apache.org/jira/browse/QPID-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213598#comment-15213598 ] ASF subversion and git services commented on QPID-7095: --- Commit 1736810 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1736810 ] QPID-7095 : Ensure Broker context defaults are processed, and that unresolved context dependencies are determined only at the completion of processing > [Java Broker] Add meta data for context variables describing their usage > > > Key: QPID-7095 > URL: https://issues.apache.org/jira/browse/QPID-7095 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey > > Currently there is no way to discover which context variables are used by the > broker, and the description of what they do. We should add meta data > covering this and also provide this information through the dynamic API docs. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7095) [Java Broker] Add meta data for context variables describing their usage
[
https://issues.apache.org/jira/browse/QPID-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211972#comment-15211972
]
Lorenz Quack commented on QPID-7095:
Hi Rob,
I just reviewed your patch.
* I am not sure I understand the intended use of the
{{@ManagedContextDependency}} annotation which is currently unused. Is it that
we can annotate a class and declare the usage of context variables that are
define else where? For example the context variable
{{qpid.security.tls.protocolWhiteList}} is defined as a
{{ManagedContextDefault}} on the {{Broker}}. The {{Port}} interface would then
be annotated with
{{@ManagedContextDependency(value=\{"qpid.security.tls.protocolWhiteList"})}}
and this would cause the context variable to show up in the ApiDocs for both
the {{Broker}} as well as the {{Port}}. If that is the intended purpose then I
don't think it is currently working. The problem is that
{{ConfiguredObjectTypeRegistry#doWithAllParents}} considers the Java type
hierarchy and not the Qpid model hierarchy when traversing the parents. So a
context variable defined on the {{Broker}} will not be detected by the {{Port}}.
* While not being directly related to your patch I think I would like to see
the default values for {{ManagedAttributes}} and {{ManagedContextDefaults}} in
the ApiDocs and the MetaData.
> [Java Broker] Add meta data for context variables describing their usage
>
>
> Key: QPID-7095
> URL: https://issues.apache.org/jira/browse/QPID-7095
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Rob Godfrey
>
> Currently there is no way to discover which context variables are used by the
> broker, and the description of what they do. We should add meta data
> covering this and also provide this information through the dynamic API docs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7095) [Java Broker] Add meta data for context variables describing their usage
[ https://issues.apache.org/jira/browse/QPID-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204037#comment-15204037 ] ASF subversion and git services commented on QPID-7095: --- Commit 1735943 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1735943 ] QPID-7095 : Add ability to describe context variables usage through meta data > [Java Broker] Add meta data for context variables describing their usage > > > Key: QPID-7095 > URL: https://issues.apache.org/jira/browse/QPID-7095 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey > > Currently there is no way to discover which context variables are used by the > broker, and the description of what they do. We should add meta data > covering this and also provide this information through the dynamic API docs. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
