Re: Build failure for C++ tests with VC2008 and Boost 1.38

2009-03-17 Thread Ján Sáreník
Hello!

On Sun, Mar 15, 2009 at 03:00:12PM +, James Mansion wrote:
 I'm using VS2008 with Boost 1.38, QPID_AUTO_TEST_CASE_EXPECTED_FAILURES
 expands to BOOST_AUTO_TEST_CASE_EXPECTED_FAILURES, but that doesn't seem
 to expand to something that ends with the start of a function definition.

On Mon, Mar 16, 2009 at 09:28:31AM +0100, Ján Sáreník wrote:
 Yes, IMHO it is a boost change. I am including a patch that helps me
 to make it compile and run.

The change is already upstream in trunk, see
https://issues.apache.org/jira/browse/QPID-1741
for more info.

   Best regards, Jasan
-- 
Red Hat Czech, MRG Quality Assurance Associate
 Looking to carve out IT costs?
www.europe.redhat.com/promo/carveoutcosts/ 

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Build failure for C++ tests with VC2008 and Boost 1.38

2009-03-16 Thread Ján Sáreník
Hi James!

On Sun, Mar 15, 2009 at 03:00:12PM +, James Mansion wrote:
 I don't have older boost versions installed - is this a boost change?

Yes, IMHO it is a boost change. I am including a patch that helps me
to make it compile and run.

  Best regards, Jasan

-- 
Red Hat Czech, MRG Quality Assurance Associate
 Looking to carve out IT costs?
www.europe.redhat.com/promo/carveoutcosts/ 
From 10f37eddc6158dd5f726e93f19e7fa946091b7f4 Mon Sep 17 00:00:00 2001
From: Jan Sarenik ja...@x31.com
Date: Thu, 12 Mar 2009 15:30:23 +0100
Subject: [PATCH] Boost test API exception

API has changed, this patch handles it for newer versions of Boost.
---
 cpp/src/tests/unit_test.h |9 -
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/cpp/src/tests/unit_test.h b/cpp/src/tests/unit_test.h
index df3ebfb..fc542e6 100644
--- a/cpp/src/tests/unit_test.h
+++ b/cpp/src/tests/unit_test.h
@@ -61,7 +61,14 @@
 namespace { struct test_name { void test_method(); };  }\
 void test_name::test_method()
 
-#endif  // Workaround for BOOST_AUTO_TEST_SUITE_EXPECTED_FAILURES
+#endif  // Workaround for BOOST_AUTO_TEST_CASE_EXPECTED_FAILURES
+
+// Correct syntax for boost  1.36
+#if (BOOST_VERSION  103500)
+# define QPID_AUTO_TEST_CASE_EXPECTED_FAILURES(name,n) \
+BOOST_AUTO_TEST_CASE_EXPECTED_FAILURES(name,n) \
+BOOST_AUTO_TEST_CASE(name)
+#endif  // Correct syntax for boost  1.36
 
 //
 // Default definitions for latest version of boost.
-- 
1.6.0.1.196.g01914


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Build failure for C++ tests with VC2008 and Boost 1.38

2009-03-15 Thread James Mansion

Where to Jira?

I see:

ClientSessionTest.cpp
.\ClientSessionTest.cpp(149) : error C2447: '{' : missing function 
header (old-style formal list?)
.\ClientSessionTest.cpp(170) : error C2447: '{' : missing function 
header (old-style formal list?)


I'm using VS2008 with Boost 1.38, QPID_AUTO_TEST_CASE_EXPECTED_FAILURES
expands to BOOST_AUTO_TEST_CASE_EXPECTED_FAILURES, but that doesn't seem
to expand to something that ends with the start of a function definition.

Rather it expands to:

struct testSuspend0Timeout_id; static struct 
testSuspend0Timeout_exp_fail_num_spec : boost::unit_test::ut_detail:: 
auto_tc_exp_failtestSuspend0Timeout_id  { 
testSuspend0Timeout_exp_fail_num_spec() : boost::unit_test::ut_detail:: 
auto_tc_exp_failtestSuspend0Timeout_id ( 1 ) {} } 
testSuspend0Timeout_exp_fail_num_spec_inst;

{
   ClientSessionFixture fix;
   fix.session.suspend(); 


I don't have older boost versions installed - is this a boost change?

James


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org