Re: Review Request 23130: Removing wrapped types from proton swigged bindings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/#review46894 --- Ship it! Ship It! - Rafael Schloming On June 27, 2014, 5:06 p.m., Andrew Stitcher wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/ --- (Updated June 27, 2014, 5:06 p.m.) Review request for qpid and Darryl Pierce. Bugs: PROTON-620 https://issues.apache.org/jira/browse/PROTON-620 Repository: qpid Description --- see PROTON-620 for rationale. Note that this also has a bug fix which stops python crashing when trying to typemap non strings to pn_uuid_t Diffs - proton/trunk/proton-c/bindings/python/cproton.i 1606140 proton/trunk/proton-c/bindings/ruby/ruby.i 1606140 proton/trunk/proton-c/include/proton/cproton.i 1606140 Diff: https://reviews.apache.org/r/23130/diff/ Testing --- ctest succeeds for all languages that have tests. Thanks, Andrew Stitcher
Re: Review Request 23130: Removing wrapped types from proton swigged bindings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/#review46895 --- proton/trunk/proton-c/bindings/python/cproton.i https://reviews.apache.org/r/23130/#comment82468 These methods are used by the Ruby and Perl bindings. - Darryl Pierce On June 27, 2014, 5:06 p.m., Andrew Stitcher wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/ --- (Updated June 27, 2014, 5:06 p.m.) Review request for qpid and Darryl Pierce. Bugs: PROTON-620 https://issues.apache.org/jira/browse/PROTON-620 Repository: qpid Description --- see PROTON-620 for rationale. Note that this also has a bug fix which stops python crashing when trying to typemap non strings to pn_uuid_t Diffs - proton/trunk/proton-c/bindings/python/cproton.i 1606140 proton/trunk/proton-c/bindings/ruby/ruby.i 1606140 proton/trunk/proton-c/include/proton/cproton.i 1606140 Diff: https://reviews.apache.org/r/23130/diff/ Testing --- ctest succeeds for all languages that have tests. Thanks, Andrew Stitcher
Re: Review Request 23130: Removing wrapped types from proton swigged bindings
On June 27, 2014, 7:10 p.m., Darryl Pierce wrote: proton/trunk/proton-c/bindings/python/cproton.i, line 40 https://reviews.apache.org/r/23130/diff/1/?file=619420#file619420line40 These methods are used by the Ruby and Perl bindings. I know - that's why I only removed them from the python binding! - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/#review46895 --- On June 27, 2014, 5:06 p.m., Andrew Stitcher wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/ --- (Updated June 27, 2014, 5:06 p.m.) Review request for qpid and Darryl Pierce. Bugs: PROTON-620 https://issues.apache.org/jira/browse/PROTON-620 Repository: qpid Description --- see PROTON-620 for rationale. Note that this also has a bug fix which stops python crashing when trying to typemap non strings to pn_uuid_t Diffs - proton/trunk/proton-c/bindings/python/cproton.i 1606140 proton/trunk/proton-c/bindings/ruby/ruby.i 1606140 proton/trunk/proton-c/include/proton/cproton.i 1606140 Diff: https://reviews.apache.org/r/23130/diff/ Testing --- ctest succeeds for all languages that have tests. Thanks, Andrew Stitcher
Re: Review Request 23130: Removing wrapped types from proton swigged bindings
On June 27, 2014, 7:10 p.m., Darryl Pierce wrote: proton/trunk/proton-c/bindings/python/cproton.i, line 40 https://reviews.apache.org/r/23130/diff/1/?file=619420#file619420line40 These methods are used by the Ruby and Perl bindings. Andrew Stitcher wrote: I know - that's why I only removed them from the python binding! Sorry, I should have phrased that better. Ruby and Perl use them, should they not? I'd like to keep some parity across the bindings, so if they're not needed in Python are they still needed in other languages? - Darryl --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/#review46895 --- On June 27, 2014, 5:06 p.m., Andrew Stitcher wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/ --- (Updated June 27, 2014, 5:06 p.m.) Review request for qpid and Darryl Pierce. Bugs: PROTON-620 https://issues.apache.org/jira/browse/PROTON-620 Repository: qpid Description --- see PROTON-620 for rationale. Note that this also has a bug fix which stops python crashing when trying to typemap non strings to pn_uuid_t Diffs - proton/trunk/proton-c/bindings/python/cproton.i 1606140 proton/trunk/proton-c/bindings/ruby/ruby.i 1606140 proton/trunk/proton-c/include/proton/cproton.i 1606140 Diff: https://reviews.apache.org/r/23130/diff/ Testing --- ctest succeeds for all languages that have tests. Thanks, Andrew Stitcher
Re: Review Request 23130: Removing wrapped types from proton swigged bindings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/#review46903 --- Ship it! Ship It! - Darryl Pierce On June 27, 2014, 5:06 p.m., Andrew Stitcher wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23130/ --- (Updated June 27, 2014, 5:06 p.m.) Review request for qpid and Darryl Pierce. Bugs: PROTON-620 https://issues.apache.org/jira/browse/PROTON-620 Repository: qpid Description --- see PROTON-620 for rationale. Note that this also has a bug fix which stops python crashing when trying to typemap non strings to pn_uuid_t Diffs - proton/trunk/proton-c/bindings/python/cproton.i 1606140 proton/trunk/proton-c/bindings/ruby/ruby.i 1606140 proton/trunk/proton-c/include/proton/cproton.i 1606140 Diff: https://reviews.apache.org/r/23130/diff/ Testing --- ctest succeeds for all languages that have tests. Thanks, Andrew Stitcher
