Re: Timer warnings in logs

2011-09-08 Thread Alan Conway

On 09/07/2011 07:31 AM, Gordon Sim wrote:

The broker at present will log warnings about overrunning timer tasks and late
wakeups. Not surprisingly, a common question from users is whether they should
be concerned with these statements and how they prevent them.

My belief is that in general they can be ignored. The information in the
warnings is only of interest if they are experiencing other problems that may be
connected to the precision of timer tasks. The most obvious issue - for which I
believe these warnings were introduced - is where clients are timing out due to
delays to broker heartbeats.

Tasks that require a degree of precision (e.g. heartbeats) to function correctly
imply constraints on other tasks driven by the same timer thread. If this is a
concern these constraints should be made explicit. We can then either have
different timer instances with different constraints, or separate the processing
of (longer running) tasks from their activation.

Going back to the logs however, I think these warnings should be demoted to
informational statements (at most). It is much easier to turn them on if needed
(--log-enable info+:Timer) than it is to turn them off if not.

I know this has been raised before... any objections to making this change?



Nope, I say do it.

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Timer warnings in logs

2011-09-07 Thread Andrew Stitcher
On Wed, 2011-09-07 at 12:31 +0100, Gordon Sim wrote:
 The broker at present will log warnings about overrunning timer tasks 
 and late wakeups. Not surprisingly, a common question from users is 
 whether they should be concerned with these statements and how they 
 prevent them.
 ...
 
 Going back to the logs however, I think these warnings should be demoted 
 to informational statements (at most). It is much easier to turn them on 
 if needed (--log-enable info+:Timer) than it is to turn them off if not.
 
 I know this has been raised before... any objections to making this change?
 

If this is a common issue that users are running into and is confusing
them then demote the messages.

We've been running with them for a long time now and as far as I can
tell have turned out to be less useful then I originally thought they
would be for debugging.

Typically they only tell you that some other process is taking up a lot
of CPU and that the broker isn't making good progress on its own (but
that they mean this is not at all obvious).

Andrew



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Timer warnings in logs

2011-09-07 Thread Gordon Sim

On 09/07/2011 04:46 PM, Andrew Stitcher wrote:

If this is a common issue that users are running into and is confusing
them then demote the messages.


Done.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org