Re: svn commit: r813825 [1/2] - in /qpid/trunk/qpid/cpp/src: ./ qpid/broker/ qpid/sys/ qpid/xml/ tests/
On Mon, 2009-09-21 at 16:39 +0100, Gordon Sim wrote: On 09/17/2009 06:21 PM, Gordon Sim wrote: I don't mind how many Jiras we use to track the issues. I have created two already, but don't mind if those get augmented or replaced, providing we make the problems being solved clear. Carl, Kim, I have attached a candidate fix to QPID-2102 that also address QPID-2101. Have a look and let me know what you think. If we are all happy with this, I can commit it. Else we can keep seeking something agreeable to all. --Gordon The code looks good. One question, however: I do not see isPersistent() in PersisbableMessage - this will be needed for setting the transient flag correctly when enqueuing on the store. Did you handle it another way (by casting, for example)? I'll make a separate checkin of the exchange route() refactorisation from the previous (subsequently rolled out) checkin 813825, which is a helpful change, but it is no longer needed for this issue. Kim - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: svn commit: r813825 [1/2] - in /qpid/trunk/qpid/cpp/src: ./ qpid/broker/ qpid/sys/ qpid/xml/ tests/
On 09/21/2009 08:24 PM, Kim van der Riet wrote: On Mon, 2009-09-21 at 16:39 +0100, Gordon Sim wrote: On 09/17/2009 06:21 PM, Gordon Sim wrote: I don't mind how many Jiras we use to track the issues. I have created two already, but don't mind if those get augmented or replaced, providing we make the problems being solved clear. Carl, Kim, I have attached a candidate fix to QPID-2102 that also address QPID-2101. Have a look and let me know what you think. If we are all happy with this, I can commit it. Else we can keep seeking something agreeable to all. --Gordon The code looks good. One question, however: I do not see isPersistent() in PersisbableMessage - this will be needed for setting the transient flag correctly when enqueuing on the store. Did you handle it another way (by casting, for example)? I did not make that change. It sounds like a separate issue? - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: svn commit: r813825 [1/2] - in /qpid/trunk/qpid/cpp/src: ./ qpid/broker/ qpid/sys/ qpid/xml/ tests/
On Mon, 2009-09-14 at 13:46 +0100, Gordon Sim wrote: On 09/11/2009 02:33 PM, kp...@apache.org wrote: Author: kpvdr Date: Fri Sep 11 13:33:42 2009 New Revision: 813825 URL: http://svn.apache.org/viewvc?rev=813825view=rev Log: Joint checkin with cctrieloff. Refactor of exchange routing so that multi-queue policy differences may be resolved and allow for correct multi-queue flow-to-disk behavior. Different queues may have differing policies and persistence properties - these were previously being neglected. New c++ test added. I'm not very keen on some of these changes. While the original code is already unpleasant, this allows the bad smells to leak further into the codebase. I have rolled this checkin back out in r814692. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
