[GitHub] incubator-quickstep pull request #319: Fixed the bug when partition w/ prune...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/319


---

[GitHub] incubator-quickstep issue #319: Fixed the bug when partition w/ pruned colum...

[jianqiao]

Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/319
  
LGTM! Merging.


---

[GitHub] incubator-quickstep pull request #328: QUICKSTEP-114 Upgrade cpplint

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/328


---

[GitHub] incubator-quickstep pull request #328: QUICKSTEP-114 Upgrade cpplint

[zuyu]

Github user zuyu commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/328#discussion_r158369912
  
--- Diff: parser/ParseString.hpp ---
@@ -115,4 +115,4 @@ class ParseString : public ParseTreeNode {
 
 }  // namespace quickstep
 
-#endif /* QUICKSTEP_PARSER_PARSE_STRING_HPP_ */
+#endif  /* QUICKSTEP_PARSER_PARSE_STRING_HPP_ */
--- End diff --

Suggest to `// QUICKSTEP_PARSER_PARSE_STRING_HPP_`.


---

[GitHub] incubator-quickstep pull request #328: QUICKSTEP-114 Upgrade cpplint

[zuyu]

Github user zuyu commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/328#discussion_r158370165
  
--- Diff: storage/BasicColumnStoreValueAccessor.hpp ---
@@ -108,25 +109,25 @@ class BasicColumnStoreValueAccessorHelper {
   }
 
   template 
-  inline const void* getAttributeValue(const tuple_id tuple,
+  inline const void* getAttributeValue(const tuple_id input_tuple,
--- End diff --

To be consistent with above, how about using `tid`?


---