Re: [racket-dev] [plt] Push #22828: master branch updated
15 minutes ago, stamo...@racket-lang.org wrote: > 7e9dbde Vincent St-Amour 2011-06-17 14:03 > : > | Add more scribble forms that evaluate code and display the results. > : > M collects/scribble/eval.rkt | 33 > +++ > M collects/scribblings/scribble/eval.scrbl | 15 I don't know why more of these are needed (they seem to be growing exponentially), but this: > +(define-syntax racketblock+interaction > + (syntax-rules () > +[(_ #:eval ev name e ...) > + (let ([eva ev]) > + (#%expression > +(begin (interaction #:eval eva e) ... > + (racketblock name e ...] > +[(_ name e ...) > + (racketblock+interaction #:eval (make-base-eval) name e ...)])) is breaking exactly what I committed yesterday -- if there's a bad sandbox, the error will start with "interaction:". Also, I'm not sure whether it's realted, but the `name' input seems very broken. (The same two points for the other two additions.) -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life! _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
Re: [racket-dev] [plt] Push #22828: master branch updated
At Fri, 17 Jun 2011 14:51:29 -0400, Eli Barzilay wrote: > I don't know why more of these are needed (they seem to be growing > exponentially), but this: I need racketmod+interaction for some docs I'm currently writing. So I added the others for consistency's sake. > > +(define-syntax racketblock+interaction > > + (syntax-rules () > > +[(_ #:eval ev name e ...) > > + (let ([eva ev]) > > + (#%expression > > +(begin (interaction #:eval eva e) ... > > + (racketblock name e ...] > > +[(_ name e ...) > > + (racketblock+interaction #:eval (make-base-eval) name e ...)])) > > is breaking exactly what I committed yesterday -- if there's a bad > sandbox, the error will start with "interaction:". > > Also, I'm not sure whether it's realted, but the `name' input seems > very broken. I've pushed this too fast. I'll revert it. Vincent _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
Re: [racket-dev] [plt] Push #22828: master branch updated
9 minutes ago, Vincent St-Amour wrote: > At Fri, 17 Jun 2011 14:51:29 -0400, > Eli Barzilay wrote: > > I don't know why more of these are needed (they seem to be growing > > exponentially), but this: > > I need racketmod+interaction for some docs I'm currently writing. So > I added the others for consistency's sake. I couldn't even figure out what it was supposed to do... BTW, your recent fix (before you reverted) was more broken wrt the `name' thing -- it appeared in the docs, but not in the code, except for a leftover in the code that didn't have a pattern variable for it... -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life! _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
Re: [racket-dev] [plt] Push #22828: master branch updated
FWIW, some of this stuff is okay to just put into the docs you're building directly. IMO, it is okay to wait until you've needed these little things more than once to put them into scribble proper. Also, you didn't commit any tests. Robby On Sat, Jun 18, 2011 at 3:12 AM, Vincent St-Amour wrote: > At Fri, 17 Jun 2011 14:51:29 -0400, > Eli Barzilay wrote: >> I don't know why more of these are needed (they seem to be growing >> exponentially), but this: > > I need racketmod+interaction for some docs I'm currently writing. So I > added the others for consistency's sake. > >> > +(define-syntax racketblock+interaction >> > + (syntax-rules () >> > + [(_ #:eval ev name e ...) >> > + (let ([eva ev]) >> > + (#%expression >> > + (begin (interaction #:eval eva e) ... >> > + (racketblock name e ...] >> > + [(_ name e ...) >> > + (racketblock+interaction #:eval (make-base-eval) name e ...)])) >> >> is breaking exactly what I committed yesterday -- if there's a bad >> sandbox, the error will start with "interaction:". >> >> Also, I'm not sure whether it's realted, but the `name' input seems >> very broken. > > I've pushed this too fast. I'll revert it. > > Vincent > _ > For list-related administrative tasks: > http://lists.racket-lang.org/listinfo/dev > _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
Re: [racket-dev] [plt] Push #22821: master branch updated
I'd hope for this to go the other way -- for the focus to remain where it is. (But I'd say the same on the behavior when both windows are visible too, and the focus is in the interactions -- I'd like it to show the highlighted error in that case, but keep the focus in the interactions.) Earlier today, ro...@racket-lang.org wrote: > 8357629 Robby Findler 2011-06-17 11:13:11 +0800 > : > | if we're highlighting something in the defs window, make sure the > | window is shown > | closes PR 11977 > : > M collects/drracket/private/rep.rkt |8 -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life! _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
