[jira] [Updated] (RANGER-1399) Do some code improvement in Java method SolrUtil.searchResources

2017-02-20 Thread Qiang Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-1399:

Attachment: (was: 
0001-RANGER-1399-Do-some-code-improvement-in-Java-method-.patch)

> Do some code improvement in Java method SolrUtil.searchResources
> 
>
> Key: RANGER-1399
> URL: https://issues.apache.org/jira/browse/RANGER-1399
> Project: Ranger
>  Issue Type: Improvement
>  Components: admin
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Minor
>  Labels: patch
> Attachments: 
> 0001-RANGER-1399-Do-some-code-improvement-in-Java-method-.patch
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> In method searchResources of class 
> /security-admin-web/src/main/java/org/apache/ranger/solr/SolrUtil.java,
> there is some code can be improved:
> 1.There is spelling error, "Search file" should be "Search field"
> {code}
> logger.error("Search file is not of java object instanceof Date");
> {code}
> 2.use "query" to replace "query.toString()" when print log
> {code}
> if (logger.isDebugEnabled()) {
>   logger.debug("SOLR QUERY=" + query.toString());
> }
> if (response == null || response.getStatus() != 0) {
>   logger.error("Error running query. query=" + query.toString()
>   + ", response=" + response);
>   throw restErrorUtil.createRESTException("Error running query",
>   MessageEnums.ERROR_SYSTEM);
> }
> {code}
> 3.In Java method SolrAccessAuditsService.searchXAccessAudits, there is 
> duplicate code to check response, in fact it would never be called, because 
> response has been checked before returning in SolrUtil.searchResources, so 
> remove it
> {code}
> if (response == null) {
>   logger.warn("Error running search query. searchCriteria="
>   + searchCriteria.toString());
>   throw restErrorUtil.createRESTException(
>   "Error running search query", 
> MessageEnums.ERROR_SYSTEM);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56866: RANGER-1399:Do some code improvement in Java method SolrUtil.searchResources

2017-02-20 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56866/
---

(Updated 二月 21, 2017, 7:57 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, 
Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and 
Velmurugan Periasamy.


Bugs: RANGER-1399
https://issues.apache.org/jira/browse/RANGER-1399


Repository: ranger


Description
---

#Solution:
Do some code improvement in Java method SolrUtil.searchResources and 
some related in SolrAccessAuditsService.searchXAccessAudits.


Diffs (updated)
-

  
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java
 917c760 
  security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e 

Diff: https://reviews.apache.org/r/56866/diff/


Testing
---

#Test Result:
1.Start Ranger-Admin success with using solr for audit
2.Search success in Audit Access WebPage


Thanks,

Qiang Zhang

[jira] [Updated] (RANGER-1399) Do some code improvement in Java method SolrUtil.searchResources

2017-02-20 Thread Qiang Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-1399:

Attachment: 0001-RANGER-1399-Do-some-code-improvement-in-Java-method-.patch

> Do some code improvement in Java method SolrUtil.searchResources
> 
>
> Key: RANGER-1399
> URL: https://issues.apache.org/jira/browse/RANGER-1399
> Project: Ranger
>  Issue Type: Improvement
>  Components: admin
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Minor
>  Labels: patch
> Attachments: 
> 0001-RANGER-1399-Do-some-code-improvement-in-Java-method-.patch
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> In method searchResources of class 
> /security-admin-web/src/main/java/org/apache/ranger/solr/SolrUtil.java,
> there is some code can be improved:
> 1.There is spelling error, "Search file" should be "Search field"
> {code}
> logger.error("Search file is not of java object instanceof Date");
> {code}
> 2.use "query" to replace "query.toString()" when print log
> {code}
> if (logger.isDebugEnabled()) {
>   logger.debug("SOLR QUERY=" + query.toString());
> }
> if (response == null || response.getStatus() != 0) {
>   logger.error("Error running query. query=" + query.toString()
>   + ", response=" + response);
>   throw restErrorUtil.createRESTException("Error running query",
>   MessageEnums.ERROR_SYSTEM);
> }
> {code}
> 3.In Java method SolrAccessAuditsService.searchXAccessAudits, there is 
> duplicate code to check response, in fact it would never be called, because 
> response has been checked before returning in SolrUtil.searchResources, so 
> remove it
> {code}
> if (response == null) {
>   logger.warn("Error running search query. searchCriteria="
>   + searchCriteria.toString());
>   throw restErrorUtil.createRESTException(
>   "Error running search query", 
> MessageEnums.ERROR_SYSTEM);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 56866: RANGER-1399:Do some code improvement in Java method SolrUtil.searchResources

2017-02-20 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56866/
---

Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, 
Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and 
Velmurugan Periasamy.


Bugs: RANGER-1399
https://issues.apache.org/jira/browse/RANGER-1399


Repository: ranger


Description
---

#Solution:
Do some code improvement in Java method SolrUtil.searchResources and 
some related in SolrAccessAuditsService.searchXAccessAudits.


Diffs
-

  
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java
 917c760 
  security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e 

Diff: https://reviews.apache.org/r/56866/diff/


Testing
---

#Test Result:
1.Start Ranger-Admin success with using solr for audit
2.Search success in Audit Access WebPage


Thanks,

Qiang Zhang

[jira] [Created] (RANGER-1399) Do some code improvement in Java method SolrUtil.searchResources

2017-02-20 Thread Qiang Zhang (JIRA) 
Qiang Zhang created RANGER-1399:
---

 Summary: Do some code improvement in Java method 
SolrUtil.searchResources
 Key: RANGER-1399
 URL: https://issues.apache.org/jira/browse/RANGER-1399
 Project: Ranger
  Issue Type: Improvement
  Components: admin
Reporter: Qiang Zhang
Assignee: Qiang Zhang
Priority: Minor


In method searchResources of class 
/security-admin-web/src/main/java/org/apache/ranger/solr/SolrUtil.java,
there is some code can be improved:
1.There is spelling error, "Search file" should be "Search field"
{code}
logger.error("Search file is not of java object instanceof Date");
{code}
2.use "query" to replace "query.toString()" when print log
{code}
if (logger.isDebugEnabled()) {
logger.debug("SOLR QUERY=" + query.toString());
}
if (response == null || response.getStatus() != 0) {
logger.error("Error running query. query=" + query.toString()
+ ", response=" + response);
throw restErrorUtil.createRESTException("Error running query",
MessageEnums.ERROR_SYSTEM);
}
{code}
3.In Java method SolrAccessAuditsService.searchXAccessAudits, there is 
duplicate code to check response, in fact it would never be called, because 
response has been checked before returning in SolrUtil.searchResources, so 
remove it
{code}
if (response == null) {
logger.warn("Error running search query. searchCriteria="
+ searchCriteria.toString());
throw restErrorUtil.createRESTException(
"Error running search query", 
MessageEnums.ERROR_SYSTEM);
}
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1398) Missing the settings for 'ranger.usersync.unix.minGroupId' in ranger usersync module

2017-02-20 Thread Qiang Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-1398:

Attachment: 0001-RANGER-1398-Missing-the-settings-for-ranger.usersync.patch

> Missing the settings for 'ranger.usersync.unix.minGroupId' in ranger usersync 
> module
> 
>
> Key: RANGER-1398
> URL: https://issues.apache.org/jira/browse/RANGER-1398
> Project: Ranger
>  Issue Type: Bug
>  Components: usersync
>Affects Versions: 0.7.0
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
> Fix For: 0.7.0
>
> Attachments: 
> 0001-RANGER-1398-Missing-the-settings-for-ranger.usersync.patch
>
>
> I checked the codes and found we will get 'minimumGroupId' from 
> ranger-ugsync-site.xml, but I can't find this parameter in this file after 
> execute the shell script.
> The reason why I set the value for 'ranger.usersync.unix.minGroupId' as 500:
> The value must be non-negative. The default is to use the  smallest ID value 
> greater than 500 and greater than every other group. Values between 0 and 499 
> are typically reserved for system accounts.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RANGER-1398) Missing the settings for 'ranger.usersync.unix.minGroupId' in ranger usersync module

2017-02-20 Thread Qiang Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875434#comment-15875434
 ] 

Qiang Zhang commented on RANGER-1398:
-

Review request: https://reviews.apache.org/r/56864/

> Missing the settings for 'ranger.usersync.unix.minGroupId' in ranger usersync 
> module
> 
>
> Key: RANGER-1398
> URL: https://issues.apache.org/jira/browse/RANGER-1398
> Project: Ranger
>  Issue Type: Bug
>  Components: usersync
>Affects Versions: 0.7.0
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
> Fix For: 0.7.0
>
> Attachments: 
> 0001-RANGER-1398-Missing-the-settings-for-ranger.usersync.patch
>
>
> I checked the codes and found we will get 'minimumGroupId' from 
> ranger-ugsync-site.xml, but I can't find this parameter in this file after 
> execute the shell script.
> The reason why I set the value for 'ranger.usersync.unix.minGroupId' as 500:
> The value must be non-negative. The default is to use the  smallest ID value 
> greater than 500 and greater than every other group. Values between 0 and 499 
> are typically reserved for system accounts.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 56864: RANGER-1398:Missing the settings for 'ranger.usersync.unix.minGroupId' in ranger usersync module

2017-02-20 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56864/
---

Review request for ranger, Don Bosco Durai and Colm O hEigeartaigh.


Bugs: RANGER-1398
https://issues.apache.org/jira/browse/RANGER-1398


Repository: ranger


Description
---

I checked the codes and found we will get 'minimumGroupId' from 
ranger-ugsync-site.xml, but I can't find this parameter in this file after 
execute the shell script.
The reason why I set the value for 'ranger.usersync.unix.minGroupId' as 500:
The value must be non-negative. The default is to use the smallest ID value 
greater than 500 and greater than every other group. Values between 0 and 499 
are typically reserved for system accounts.


Diffs
-

  unixauthservice/conf.dist/ranger-ugsync-default.xml 5ed5b89 
  unixauthservice/scripts/install.properties 13ae1e5 
  unixauthservice/scripts/templates/installprop2xml.properties 1a9bf36 
  unixauthservice/scripts/templates/ranger-ugsync-template.xml 0025dc8 

Diff: https://reviews.apache.org/r/56864/diff/


Testing
---

$ git apply --stat 
0001-RANGER-1398-Missing-the-settings-for-ranger.usersync.patch
 .../conf.dist/ranger-ugsync-default.xml|4 
 unixauthservice/scripts/install.properties |6 ++
 .../scripts/templates/installprop2xml.properties   |1 +
 .../scripts/templates/ranger-ugsync-template.xml   |4 
 4 files changed, 15 insertions(+)
$ git am --signoff < 
0001-RANGER-1398-Missing-the-settings-for-ranger.usersync.patch
Applying: RANGER-1398:Missing the settings for ranger.usersync.unix.minGroupId 
in ranger usersync module


Thanks,

Qiang Zhang

Re: [VOTE] Apache Ranger Release 0.7.0 - rc1

2017-02-20 Thread Gautam Borad 
+1

Downloaded apache-ranger-0.7.0.tar.gz, apache-ranger-0.7.0.tar.gz.asc and
apache-ranger-0.7.0.tar.gz.mds
Verified PGP Signature and MD5/SHA hash
Did mvn build successfully

On Mon, Feb 20, 2017 at 11:51 PM, Selvamohan Neethiraj 
wrote:

> Rangers:
>
>
>
> Thank you for your contribution to this Apache community to be able to
> release this major release – Ranger 0.7.0.
>
> This release includes numerous improvements/bug-fixes as well as some new
> features over the previous release of Ranger (see Release Notes for
> details).
>
>
>
> Apache ranger-0.7.0 release candidate # 1 is now available with the
> following artifacts up for vote.
>
> I kindly request all of the Rangers (dev & PMC members) to review and vote
> on this release.
>
>
>
> Git tag for the release:
>
> https://github.com/apache/ranger/tree/ranger-0.7.0-rc1 (last commit id:
> f39e4880082f5579db49b29be735977a341c041b)
>
>
>
> Sources for the release:
>
> https://dist.apache.org/repos/dist/dev/ranger/0.7.0-rc1/
> apache-ranger-0.7.0.tar.gz
>
>
>
> Source release verification:
>
> PGP Signature:
>
>   https://dist.apache.org/repos/dist/dev/ranger/0.7.0-rc1/
> apache-ranger-0.7.0.tar.gz.asc
>
> MD5/SHA Hash:
>
>   https://dist.apache.org/repos/dist/dev/ranger/0.7.0-rc1/
> apache-ranger-0.7.0.tar.gz.mds
>
>
>
> Keys to verify the signature of the release artifact are available at:
>
>   https://people.apache.org/keys/group/ranger.asc
>
>
>
> Release Notes:
>
>https://cwiki.apache.org/confluence/display/RANGER/
> Apache+Ranger+0.7.0+-+Release+Notes
>
>
>
> Build verification steps can be found at:
>
>http://ranger.apache.org/quick_start_guide.html
>
>
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> [ ] +1  approve
>
> [ ] +0  no opinion
>
> [ ] -1  disapprove (and reason why)
>
>
>
> Here is my +1 (binding).
>
>
>
> Thank you,
>
> Selva-
>
>


-- 
Regards,
Gautam.

Review Request 56862: RANGER-1397:Error method name in the printed logs

2017-02-20 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56862/
---

Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, and Selvamohan 
Neethiraj.


Bugs: RANGER-1397
https://issues.apache.org/jira/browse/RANGER-1397


Repository: ranger


Description
---

public List getTblList(String tableNameMatching, List dbList, 
List tblList) throws HadoopException {

if(LOG.isDebugEnabled()) {
LOG.debug("==> HiveClient getTableList() tableNameMatching : " 
+ tableNameMatching + " ExcludedbList :" + dbList + "ExcludeTableList :" + 
tblList);
}
...
if(LOG.isDebugEnabled()) {
LOG.debug("<== HiveClient getTableList() " +  ret);
}

return ret;
}


Diffs
-

  
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java 
ec61458 

Diff: https://reviews.apache.org/r/56862/diff/


Testing
---


Thanks,

Qiang Zhang

[jira] [Updated] (RANGER-1397) Error method name in the printed logs

2017-02-20 Thread Qiang Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-1397:

Attachment: 0001-RANGER-1397.patch

> Error method name in the printed logs
> -
>
> Key: RANGER-1397
> URL: https://issues.apache.org/jira/browse/RANGER-1397
> Project: Ranger
>  Issue Type: Bug
>  Components: plugins
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Trivial
> Attachments: 0001-RANGER-1397.patch
>
>
> {code}
> public List getTblList(String tableNameMatching, List dbList, 
> List tblList) throws HadoopException {
>   if(LOG.isDebugEnabled()) {
>   LOG.debug("==> HiveClient getTableList() tableNameMatching : " 
> + tableNameMatching + " ExcludedbList :" + dbList + "ExcludeTableList :" + 
> tblList);
>   }
>   ...
>   if(LOG.isDebugEnabled()) {
>   LOG.debug("<== HiveClient getTableList() " +  ret);
>   }
>   return ret;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RANGER-1397) Error method name in the printed logs

2017-02-20 Thread Qiang Zhang (JIRA) 
Qiang Zhang created RANGER-1397:
---

 Summary: Error method name in the printed logs
 Key: RANGER-1397
 URL: https://issues.apache.org/jira/browse/RANGER-1397
 Project: Ranger
  Issue Type: Bug
  Components: plugins
Reporter: Qiang Zhang
Assignee: Qiang Zhang
Priority: Trivial


{code}
public List getTblList(String tableNameMatching, List dbList, 
List tblList) throws HadoopException {
if(LOG.isDebugEnabled()) {
LOG.debug("==> HiveClient getTableList() tableNameMatching : " 
+ tableNameMatching + " ExcludedbList :" + dbList + "ExcludeTableList :" + 
tblList);
}
...
if(LOG.isDebugEnabled()) {
LOG.debug("<== HiveClient getTableList() " +  ret);
}

return ret;
}
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1383) Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-20 Thread Selvamohan Neethiraj (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Selvamohan Neethiraj updated RANGER-1383:
-
Fix Version/s: (was: 0.7.0)
   1.0.0

> Support for using resource-matcher for filtering policies within a service if 
> service-resource is provided in the filter
> 
>
> Key: RANGER-1383
> URL: https://issues.apache.org/jira/browse/RANGER-1383
> Project: Ranger
>  Issue Type: Bug
>  Components: admin
>Affects Versions: 0.7.0
>Reporter: Deepak Sharma
>Assignee: Abhay Kulkarni
> Fix For: 1.0.0
>
>
> Ranger admin's REST API support retrieving and filtering policies for 
> resource specified in the provided filter. Currently, a simple string-match 
> and wildcard-match is used to filter policies. It is desirable to provide an 
> option to use, for filtering purpose, the same resource-matching algorithm 
> that is used by the policy engine to search policies that need to be 
> evaluated for access determination in the component.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1354) Error on Atlas plugin install

2017-02-20 Thread Selvamohan Neethiraj (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Selvamohan Neethiraj updated RANGER-1354:
-
Fix Version/s: (was: 0.7.0)
   1.0.0

> Error on Atlas plugin install
> -
>
> Key: RANGER-1354
> URL: https://issues.apache.org/jira/browse/RANGER-1354
> Project: Ranger
>  Issue Type: Bug
>  Components: plugins
>Reporter: Colm O hEigeartaigh
>Assignee: Colm O hEigeartaigh
> Fix For: 1.0.0
>
> Attachments: 0001-RANGER-1354-Error-on-Atlas-plugin-install.patch
>
>
> When installing the Atlas plugin, it throws an error if the Apache Atlas 
> distribution does not have a "libext" directory. As it doesn't by default, 
> this can be a bit confusing to the user. The script should be updated to 
> create the "libext" directory in the Atlas distribution if it doesn't already 
> exist.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1348) Atlas Autocompletion not working properly

2017-02-20 Thread Selvamohan Neethiraj (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Selvamohan Neethiraj updated RANGER-1348:
-
Fix Version/s: (was: 0.7.0)
   1.0.0

> Atlas Autocompletion not working properly
> -
>
> Key: RANGER-1348
> URL: https://issues.apache.org/jira/browse/RANGER-1348
> Project: Ranger
>  Issue Type: Bug
>  Components: admin
>Reporter: Colm O hEigeartaigh
>Assignee: Qiang Zhang
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1348-Atlas-Autocompletion-not-working-properl-2.patch, 
> 0001-RANGER-1348-Atlas-Autocompletion-not-working-properl.patch, 
> ranger-atlas.png, test1.png
>
>
> The autocompletion feature available in the Admin Service when selecting an 
> Atlas type (for example) does not work properly. If you start typing you can 
> see that all of the results retrieved from Atlas are available to be selected 
> (see the screenshot below). It looks like the results from Atlas are not 
> parsed properly (tested with 0.8.0 SNAPSHOT version of Atlas for the record)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1364) MySQLPLRunner take wrong start index when traverse the resultSet metadata

2017-02-20 Thread Selvamohan Neethiraj (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Selvamohan Neethiraj updated RANGER-1364:
-
Fix Version/s: (was: 0.7.0)
   1.0.0

> MySQLPLRunner take wrong start index when traverse the resultSet metadata
> -
>
> Key: RANGER-1364
> URL: https://issues.apache.org/jira/browse/RANGER-1364
> Project: Ranger
>  Issue Type: Bug
>  Components: admin
>Affects Versions: 0.7.0
>Reporter: zhangxiong
> Fix For: 1.0.0
>
> Attachments: 
> 0001-change-mysql-ResultSetMetaData-traverse-index-from-0.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> when we install the admin,the dba_script.py would call MySQLRunner to run 
> some sqls from file or input string.But MySQLRunner take wrong start index 
> when traverse then resultSet colname.According to jdbc specification,we 
> should get the rs first column name with index 1 NOT 0. But take 0 as start 
> index is what ranger does.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1252) Policy lookup does not honor the case sensitivity flag of resources

2017-02-20 Thread Selvamohan Neethiraj (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Selvamohan Neethiraj updated RANGER-1252:
-
Fix Version/s: (was: 0.7.0)
   1.0.0

> Policy lookup does not honor the case sensitivity flag of resources
> ---
>
> Key: RANGER-1252
> URL: https://issues.apache.org/jira/browse/RANGER-1252
> Project: Ranger
>  Issue Type: Bug
>  Components: admin
>Affects Versions: 0.6.2
>Reporter: Yan
> Fix For: 1.0.0
>
> Attachments: Ranger-1252.patch
>
>
> For case insensitive Hive db/table names, the public API's policy lookup does 
> not hit the case insensitive names. For instance, the following curl command:
> curl -iv -u admin:admin -H "Content-type:application/json" -X GET 
> http://11.22.33.444:6080/service/public/api/policy?databases=db1=table1
> returns different results from running the following command using different 
> cases in names:
> curl -iv -u admin:admin -H "Content-type:application/json" -X GET 
> http://11.22.33.444:6080/service/public/api/policy?databases=DB1=TABLE1
> if there exists such a Hive table db1/table1 in the metastore.
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Rangers: Need help to move 9 open JIRA(s) to either RESOLVED state or move out to 1.0.0 version ....

2017-02-20 Thread Selvamohan Neethiraj 
Rangers:

 

I have moved the following 7 JIRA(s) out of 0.7.0 release to fixVersion =  1.0.0

 

RANGER-1252

RANGER-1326

RANGER-1348

RANGER-1354

RANGER-1364

RANGER-1383

RANGER-1392

 

Thanks,

Selva-

 

From: Selvamohan Neethiraj 
Date: Monday, February 20, 2017 at 1:18 AM
To: 
Subject: Rangers: Need help to move 9 open JIRA(s) to either RESOLVED state or 
move out to 1.0.0 version 

 

Rangers:

 

As I am preparing for ranger-0.7.0  release, I still see 9 more open issues 
targeted for ranger 0.7 fix version. 

(JIRA Filter:  project = RANGER AND fixVersion = 0.7.0 AND resolution = 
Unresolved and type not in (Task) ORDER BY due ASC, priority DESC, created ASC)

Can you please review this list and move your assigned jira(s) to next release 
version 1.0.0 if you cannot resolve it in next 4 hours?  If it is not moved out 
(or resolved), I will have to move them to 1.0.0 release before sending the 
release for VOTE.

 

Just another FYI:  I have disabled the build.apache.org Jenkin Job that was 
publishing our 0.7.0-SNAPSHOT libraries to Apache (since we have changed the 
version to 0.7.0 and the release is not yet approved).

 

Thanks,

Selva-

Review Request 56844: There are error logs in SecureClientLogin class

2017-02-20 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56844/
---

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-1396
https://issues.apache.org/jira/browse/RANGER-1396


Repository: ranger


Description
---

There are error logs in SecureClientLogin class


Diffs
-

  agents-common/src/main/java/org/apache/hadoop/security/SecureClientLogin.java 
3949350 

Diff: https://reviews.apache.org/r/56844/diff/


Testing
---


Thanks,

Qiang Zhang

Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly

2017-02-20 Thread Colm O hEigeartaigh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56654/#review166073
---



Thanks for making the changes. Could you update the patch to the latest master, 
it doesn't apply as there was a change to AtlasClient. The other change I'd 
like to see is that there is still a "atlasResourceParamter" (instead of 
atlasResourceParameter) in AtlasResourceMgr.

- Colm O hEigeartaigh


On Feb. 18, 2017, 6:44 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56654/
> ---
> 
> (Updated Feb. 18, 2017, 6:44 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, 
> Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1348
> https://issues.apache.org/jira/browse/RANGER-1348
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Autocompletion not working properly Resource Autocompletion fuction I have 
> submit the patch please review it.
> 
> 
> Diffs
> -
> 
>   
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java
>  ba4d263 
>   
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java
>  4f90469 
>   
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java
>  84e24c5 
>   
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java
>  93b2662 
>   
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java
>  PRE-CREATION 
>   
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java
>  PRE-CREATION 
>   
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java
>  PRE-CREATION 
>   
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java
>  PRE-CREATION 
>   
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56654/diff/
> 
> 
> Testing
> ---
> 
> Tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

[jira] [Updated] (RANGER-1396) There are error logs in SecureClientLogin class

2017-02-20 Thread Qiang Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-1396:

Request participants:   (was: )
Priority: Minor  (was: Trivial)

> There are error logs in SecureClientLogin class
> ---
>
> Key: RANGER-1396
> URL: https://issues.apache.org/jira/browse/RANGER-1396
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Minor
>  Labels: patch
>
> The log format is incorrect in SecureClientLogin class



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1396) There are error logs in SecureClientLogin class

2017-02-20 Thread Qiang Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-1396:

Summary: There are error logs in SecureClientLogin class  (was: The log 
format is incorrect in SecureClientLogin class)

> There are error logs in SecureClientLogin class
> ---
>
> Key: RANGER-1396
> URL: https://issues.apache.org/jira/browse/RANGER-1396
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Trivial
>  Labels: patch
>
> The log format is incorrect in SecureClientLogin class



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RANGER-1396) The log format is incorrect in SecureClientLogin class

2017-02-20 Thread Qiang Zhang (JIRA) 
Qiang Zhang created RANGER-1396:
---

 Summary: The log format is incorrect in SecureClientLogin class
 Key: RANGER-1396
 URL: https://issues.apache.org/jira/browse/RANGER-1396
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: Qiang Zhang
Assignee: Qiang Zhang
Priority: Trivial


The log format is incorrect in SecureClientLogin class



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56739: RANGER-1387:Remove unused SQL_CONNECTOR_JAR in install.properties of ranger plugin

2017-02-20 Thread Colm O hEigeartaigh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56739/#review166069
---


Ship it!




Ship It!

- Colm O hEigeartaigh


On Feb. 16, 2017, 7:01 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56739/
> ---
> 
> (Updated Feb. 16, 2017, 7:01 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1387
> https://issues.apache.org/jira/browse/RANGER-1387
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> #Solution:
> Remove unused SQL_CONNECTOR_JAR in install.properties of ranger plugin
> 
> 
> Diffs
> -
> 
>   hbase-agent/scripts/install.properties aca57bb 
>   hdfs-agent/scripts/install.properties 148d2ba 
>   hive-agent/scripts/install.properties 9f88524 
>   knox-agent/scripts/install.properties dbf1e11 
>   plugin-atlas/scripts/install.properties b339d26 
>   plugin-kafka/scripts/install.properties e5cf664 
>   plugin-solr/scripts/install.properties 9073e8e 
>   plugin-yarn/scripts/install.properties 3825125 
>   storm-agent/scripts/install.properties f3a0693 
> 
> Diff: https://reviews.apache.org/r/56739/diff/
> 
> 
> Testing
> ---
> 
> #Test Result:
> 1. install hdfs-plugin sucess
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Rangers: Need help to move 9 open JIRA(s) to either RESOLVED state or move out to 1.0.0 version ....

2017-02-20 Thread Colm O hEigeartaigh 
Hi Selva,

I have one issue on that list, a simple fix for installing the Atlas plugin:

https://issues.apache.org/jira/browse/RANGER-1354
https://reviews.apache.org/r/56489/

If you could take a quick look at the patch that'd be great, otherwise feel
free to bump it to 1.0.0.

The only concern I have is with the licensing JIRA, where do we stand on
this? We should really have licensing issues definitively resolved by now:

https://issues.apache.org/jira/browse/RANGER-1326

Colm.

On Mon, Feb 20, 2017 at 6:18 AM, Selvamohan Neethiraj 
wrote:

> Rangers:
>
>
>
> As I am preparing for ranger-0.7.0  release, I still see 9 more open
> issues targeted for ranger 0.7 fix version.
>
> (JIRA Filter:  project = RANGER AND fixVersion = 0.7.0 AND resolution =
> Unresolved and type not in (Task) ORDER BY due ASC, priority DESC, created
> ASC)
>
> Can you please review this list and move your assigned jira(s) to next
> release version 1.0.0 if you cannot resolve it in next 4 hours?  If it is
> not moved out (or resolved), I will have to move them to 1.0.0 release
> before sending the release for VOTE.
>
>
>
> Just another FYI:  I have disabled the build.apache.org Jenkin Job that
> was publishing our 0.7.0-SNAPSHOT libraries to Apache (since we have
> changed the version to 0.7.0 and the release is not yet approved).
>
>
>
> Thanks,
>
> Selva-
>
>


-- 
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com

Re: Review Request 56700: RANGER-1386:Ranger hdfs-plugin function not revoked after execute disable-hdfs-plugin.sh which cause hadoop-hdfs authorization failed.

2017-02-20 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56700/
---

(Updated 二月 20, 2017, 9:06 a.m.)


Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, 
Selvamohan Neethiraj, and Velmurugan Periasamy.


Summary (updated)
-

RANGER-1386:Ranger hdfs-plugin function not revoked after execute 
disable-hdfs-plugin.sh which cause hadoop-hdfs authorization failed.


Bugs: RANGER-1386
https://issues.apache.org/jira/browse/RANGER-1386


Repository: ranger


Description (updated)
---

steps:
1.User yuwen does't has the permission to put a.txt in hdfs Catalog /test
[yuwen@zdh41 bin]$ ./hdfs dfs -put /home/xiehh/a.txt /test
put: Permission denied: user=yuwen, access=WRITE, 
inode="/test/a.txt._COPYING_":xiehh:supergroup:drwxr-xr-x

2.Execute enable-hdfs-plugin.sh and Restart hadoop-hdfs, ranger authorization 
control enabled. 
We add policy to give permission for user yuwen to put a file in web UI.
[yuwen@zdh41 bin]$ ./hdfs dfs -put /home/xiehh/a.txt /test
[yuwen@zdh41 bin]$ ./hdfs dfs -ls /test
Found 1 items
-rw-r--r--   3 yuwen supergroup 15 2017-02-20 17:07 /test/a.txt

3. Execute disable-hdfs-plugin.sh and Restart hadoop-hdfs
user yuwen shouldn't have the permission to put a file in Catalog /test
but he also has the rights ,ranger hdfs-plugin function not revoked
This is a serious problem which cause hadoop-hdfs authorization failed.


Diffs
-

  hdfs-agent/disable-conf/hdfs-site-changes.cfg PRE-CREATION 
  src/main/assembly/hdfs-agent.xml 63e426a 

Diff: https://reviews.apache.org/r/56700/diff/


Testing
---


Thanks,

Qiang Zhang

[jira] [Updated] (RANGER-1386) ranger hdfs-plugin function not revoked after execute disable-hdfs-plugin.sh which cause hadoop-hdfs authorization failed.

2017-02-20 Thread Qiang Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-1386:

Description: 
steps:
1.User yuwen does't has the permission to put a.txt in hdfs Catalog /test
[yuwen@zdh41 bin]$ ./hdfs dfs -put /home/xiehh/a.txt /test
put: Permission denied: user=yuwen, access=WRITE, 
inode="/test/a.txt._COPYING_":xiehh:supergroup:drwxr-xr-x

2.Execute enable-hdfs-plugin.sh and Restart hadoop-hdfs, ranger authorization 
control enabled. 
We add policy to give permission for user yuwen to put a file in web UI.
[yuwen@zdh41 bin]$ ./hdfs dfs -put /home/xiehh/a.txt /test
[yuwen@zdh41 bin]$ ./hdfs dfs -ls /test
Found 1 items
-rw-r--r--   3 yuwen supergroup 15 2017-02-20 17:07 /test/a.txt

3. Execute disable-hdfs-plugin.sh and Restart hadoop-hdfs
user yuwen shouldn't have the permission to put a file in Catalog /test
but he also has the rights ,ranger hdfs-plugin function not revoked
This is a serious problem which cause hadoop-hdfs authorization failed.

  was:
steps:
1. Execute enable-hdfs-plugin.sh
2. Restart hadoop-hdfs, Authorization control enabled. We can set the rights 
for users in web UI.
3. Execute disable-hdfs-plugin.sh
4. Restart hadoop-hdfs, we can also set the rights for users in web UI. 
I think after we disable the hdfs plugin, we shouldn't have the right to set 
the rights for users through ranger.


> ranger hdfs-plugin function not revoked after execute disable-hdfs-plugin.sh 
> which cause hadoop-hdfs authorization failed.
> --
>
> Key: RANGER-1386
> URL: https://issues.apache.org/jira/browse/RANGER-1386
> Project: Ranger
>  Issue Type: Bug
>  Components: plugins
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
> Attachments: 0001-RANGER-1386.patch
>
>
> steps:
> 1.User yuwen does't has the permission to put a.txt in hdfs Catalog /test
> [yuwen@zdh41 bin]$ ./hdfs dfs -put /home/xiehh/a.txt /test
> put: Permission denied: user=yuwen, access=WRITE, 
> inode="/test/a.txt._COPYING_":xiehh:supergroup:drwxr-xr-x
> 2.Execute enable-hdfs-plugin.sh and Restart hadoop-hdfs, ranger authorization 
> control enabled. 
> We add policy to give permission for user yuwen to put a file in web UI.
> [yuwen@zdh41 bin]$ ./hdfs dfs -put /home/xiehh/a.txt /test
> [yuwen@zdh41 bin]$ ./hdfs dfs -ls /test
> Found 1 items
> -rw-r--r--   3 yuwen supergroup 15 2017-02-20 17:07 /test/a.txt
> 3. Execute disable-hdfs-plugin.sh and Restart hadoop-hdfs
> user yuwen shouldn't have the permission to put a file in Catalog /test
> but he also has the rights ,ranger hdfs-plugin function not revoked
> This is a serious problem which cause hadoop-hdfs authorization failed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1386) ranger hdfs-plugin function not revoked after execute disable-hdfs-plugin.sh which cause hadoop-hdfs authorization failed.

2017-02-20 Thread Qiang Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-1386:

Summary: ranger hdfs-plugin function not revoked after execute 
disable-hdfs-plugin.sh which cause hadoop-hdfs authorization failed.  (was: 
Can't disable hdfs plugin after execute disable-hdfs-plugin.sh)

> ranger hdfs-plugin function not revoked after execute disable-hdfs-plugin.sh 
> which cause hadoop-hdfs authorization failed.
> --
>
> Key: RANGER-1386
> URL: https://issues.apache.org/jira/browse/RANGER-1386
> Project: Ranger
>  Issue Type: Bug
>  Components: plugins
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
> Attachments: 0001-RANGER-1386.patch
>
>
> steps:
> 1. Execute enable-hdfs-plugin.sh
> 2. Restart hadoop-hdfs, Authorization control enabled. We can set the rights 
> for users in web UI.
> 3. Execute disable-hdfs-plugin.sh
> 4. Restart hadoop-hdfs, we can also set the rights for users in web UI. 
> I think after we disable the hdfs plugin, we shouldn't have the right to set 
> the rights for users through ranger.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)