Review Request 60061: Like security admin and usersync, the kms installer should chech whether the user group exists before creating the user group.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60061/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. Bugs: RANGER-1641 https://issues.apache.org/jira/browse/RANGER-1641 Repository: ranger Description --- Like security admin and usersync, the kms installer should chech whether the user group exists before creating the user group. Diffs - kms/scripts/setup.sh c8d7519 Diff: https://reviews.apache.org/r/60061/diff/1/ Testing --- Thanks, Qiang Zhang
[jira] [Updated] (RANGER-1641) Like security admin and usersync, the kms installer should chech whether the user group exists before creating the user group.
[ https://issues.apache.org/jira/browse/RANGER-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1641: Attachment: 0001-RANGER-1641-Like-security-admin-and-usersync-the-kms.patch > Like security admin and usersync, the kms installer should chech whether the > user group exists before creating the user group. > -- > > Key: RANGER-1641 > URL: https://issues.apache.org/jira/browse/RANGER-1641 > Project: Ranger > Issue Type: Bug > Components: kms >Reporter: Qiang Zhang >Assignee: Qiang Zhang > Labels: patch > Attachments: > 0001-RANGER-1641-Like-security-admin-and-usersync-the-kms.patch > > > Like security admin and usersync, the kms installer should chech whether the > user group exists before creating the user group. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1641) Like security admin and usersync, the kms installer should chech whether the user group exists before creating the user group.
[ https://issues.apache.org/jira/browse/RANGER-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1641: Summary: Like security admin and usersync, the kms installer should chech whether the user group exists before creating the user group. (was: Like security admin, the kms installer should chech whether the user group exists before creating the user group.) > Like security admin and usersync, the kms installer should chech whether the > user group exists before creating the user group. > -- > > Key: RANGER-1641 > URL: https://issues.apache.org/jira/browse/RANGER-1641 > Project: Ranger > Issue Type: Bug > Components: kms >Reporter: Qiang Zhang >Assignee: Qiang Zhang > Labels: patch > > Like security admin, the kms installer should chech whether the user group > exists before creating the user group. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1641) Like security admin and usersync, the kms installer should chech whether the user group exists before creating the user group.
[ https://issues.apache.org/jira/browse/RANGER-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1641: Description: Like security admin and usersync, the kms installer should chech whether the user group exists before creating the user group. (was: Like security admin, the kms installer should chech whether the user group exists before creating the user group.) > Like security admin and usersync, the kms installer should chech whether the > user group exists before creating the user group. > -- > > Key: RANGER-1641 > URL: https://issues.apache.org/jira/browse/RANGER-1641 > Project: Ranger > Issue Type: Bug > Components: kms >Reporter: Qiang Zhang >Assignee: Qiang Zhang > Labels: patch > > Like security admin and usersync, the kms installer should chech whether the > user group exists before creating the user group. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (RANGER-1641) Like security admin, the kms installer should chech whether the user group exists before creating the user group.
Qiang Zhang created RANGER-1641: --- Summary: Like security admin, the kms installer should chech whether the user group exists before creating the user group. Key: RANGER-1641 URL: https://issues.apache.org/jira/browse/RANGER-1641 Project: Ranger Issue Type: Bug Components: kms Reporter: Qiang Zhang Assignee: Qiang Zhang Like security admin, the kms installer should chech whether the user group exists before creating the user group. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (RANGER-1636) Remove the pmd check error
[ https://issues.apache.org/jira/browse/RANGER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang resolved RANGER-1636. - Resolution: Fixed Fix Version/s: 1.0.0 > Remove the pmd check error > -- > > Key: RANGER-1636 > URL: https://issues.apache.org/jira/browse/RANGER-1636 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Labels: patch > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1636-Remove-the-pmd-check-error.patch > > > The following information will occur when using PMD tool to check code. > > > name="/submitranger/RangerCompile01/Ranger/agents-common/src/test/java/org/apache/ranger/plugin/errors/TestValidationErrorCode.java"> > rule="UnusedImports" ruleset="Import Statements" > package="org.apache.ranger.plugin.errors" > externalInfoUrl="http://pmd.sourceforge.net/pmd-5.3.2/pmd-java/rules/java/imports.html#UnusedImports"; > priority="4"> > Avoid unused imports such as > 'org.apache.ranger.plugin.model.validation.ValidationFailureDetails' > > > name="/submitranger/RangerCompile01/Ranger/agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerValidator.java"> > rule="UnusedLocalVariable" ruleset="Unused Code" > package="org.apache.ranger.plugin.model.validation" > class="TestRangerValidator$RangerValidatorForTest" method="isValid" > variable="valid" > externalInfoUrl="http://pmd.sourceforge.net/pmd-5.3.2/pmd-java/rules/java/unusedcode.html#UnusedLocalVariable"; > priority="3"> > Avoid unused local variables such as 'valid'. > > > > > > name="/home/pengjianhua/gerrit/submitranger/RangerCompile/kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java"> > rule="UnusedFormalParameter" ruleset="Unused Code" > package="org.apache.hadoop.crypto.key" class="RangerKeyStore" > method="mapToEntityBean" variable="i" > externalInfoUrl="http://pmd.sourceforge.net/pmd-5.3.2/pmd-java/rules/java/unusedcode.html#UnusedFormalParameter"; > priority="3"> > Avoid unused method parameters such as 'i'. > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 60032: Remove the pmd check error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60032/#review177858 --- Ship it! Ship It! - Qiang Zhang On 六月 13, 2017, 4:36 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60032/ > --- > > (Updated 六月 13, 2017, 4:36 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1636 > https://issues.apache.org/jira/browse/RANGER-1636 > > > Repository: ranger > > > Description > --- > > The following information will occur when using PMD tool to check code. > > > name="/submitranger/RangerCompile01/Ranger/agents-common/src/test/java/org/apache/ranger/plugin/errors/TestValidationErrorCode.java"> > rule="UnusedImports" ruleset="Import Statements" > package="org.apache.ranger.plugin.errors" > externalInfoUrl="http://pmd.sourceforge.net/pmd-5.3.2/pmd-java/rules/java/imports.html#UnusedImports"; > priority="4"> > Avoid unused imports such as > 'org.apache.ranger.plugin.model.validation.ValidationFailureDetails' > > > name="/submitranger/RangerCompile01/Ranger/agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerValidator.java"> > rule="UnusedLocalVariable" ruleset="Unused Code" > package="org.apache.ranger.plugin.model.validation" > class="TestRangerValidator$RangerValidatorForTest" method="isValid" > variable="valid" > externalInfoUrl="http://pmd.sourceforge.net/pmd-5.3.2/pmd-java/rules/java/unusedcode.html#UnusedLocalVariable"; > priority="3"> > Avoid unused local variables such as 'valid'. > > > > > > name="/home/pengjianhua/gerrit/submitranger/RangerCompile/kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java"> > rule="UnusedFormalParameter" ruleset="Unused Code" > package="org.apache.hadoop.crypto.key" class="RangerKeyStore" > method="mapToEntityBean" variable="i" > externalInfoUrl="http://pmd.sourceforge.net/pmd-5.3.2/pmd-java/rules/java/unusedcode.html#UnusedFormalParameter"; > priority="3"> > Avoid unused method parameters such as 'i'. > > > > > > Diffs > - > > > agents-common/src/test/java/org/apache/ranger/plugin/errors/TestValidationErrorCode.java > 1b00c64 > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java c4f7267 > > > Diff: https://reviews.apache.org/r/60032/diff/1/ > > > Testing > --- > > > Thanks, > > pengjianhua > >
Re: Review Request 60046: RANGER-1640 - HBase Test Connection does not work when creating a service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60046/#review177857 --- Ship it! Ship It! - Qiang Zhang On 六月 13, 2017, 12:10 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60046/ > --- > > (Updated 六月 13, 2017, 12:10 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1640 > https://issues.apache.org/jira/browse/RANGER-1640 > > > Repository: ranger > > > Description > --- > > Testing a connection doesn't work with the HBase service on the first go in > the Admin UI, as the password is not yet encrypted > > > Diffs > - > > agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java > 485ac04e > > > Diff: https://reviews.apache.org/r/60046/diff/1/ > > > Testing > --- > > Tested that the connection works fine in the Admin UI when creating a service > and also when editing an already created service. > > > Thanks, > > Colm O hEigeartaigh > >
[jira] [Commented] (RANGER-1582) Support KNOX SSO Token based authentication on Ranger REST API calls
[ https://issues.apache.org/jira/browse/RANGER-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047800#comment-16047800 ] Ankita Sinha commented on RANGER-1582: -- Committed to ranger-0.7 : https://github.com/apache/ranger/commit/d4cf793efd2d5c1604e4404ad12f72252470c1cd > Support KNOX SSO Token based authentication on Ranger REST API calls > > > Key: RANGER-1582 > URL: https://issues.apache.org/jira/browse/RANGER-1582 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: 1.0.0 >Reporter: Ankita Sinha >Assignee: Ankita Sinha > Fix For: 1.0.0 > > Attachments: RANGER-1582.patch > > > *Actual* : > Currently Knox SSO is just supported from Ranger UI through web browser. > *Expected* : > Support KNOX SSO Token based authentication on Ranger REST API calls. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 60043: Ranger KMS should validate key name before importing into DB
> On June 13, 2017, 12:20 p.m., Colm O hEigeartaigh wrote: > > Ship It! Actually, is it feasible to add some unit tests for this? - Colm --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/#review177731 --- On June 13, 2017, 12:06 p.m., Ankita Sinha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60043/ > --- > > (Updated June 13, 2017, 12:06 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1639 > https://issues.apache.org/jira/browse/RANGER-1639 > > > Repository: ranger > > > Description > --- > > Actual : > Ranger KMS does not validate key name before importing into DB. So the > imported key can have special characters in Key name. > > Expected : > Ranger KMS should validate key name before importing into DB. > > > Diffs > - > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java c4f7267 > > > Diff: https://reviews.apache.org/r/60043/diff/2/ > > > Testing > --- > > Below steps were followed to test this scenario > > 1. Installed Hadoop KMS > 2. Created encryption keys with combination of special characters, alphabets > and numbers > 3. Installed Ranger KMS > 4. imported hadoop key jceks to Ranger KMS (Validation was successful) > > > Thanks, > > Ankita Sinha > >
Re: Review Request 60043: Ranger KMS should validate key name before importing into DB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/#review177731 --- Ship it! Ship It! - Colm O hEigeartaigh On June 13, 2017, 12:06 p.m., Ankita Sinha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60043/ > --- > > (Updated June 13, 2017, 12:06 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1639 > https://issues.apache.org/jira/browse/RANGER-1639 > > > Repository: ranger > > > Description > --- > > Actual : > Ranger KMS does not validate key name before importing into DB. So the > imported key can have special characters in Key name. > > Expected : > Ranger KMS should validate key name before importing into DB. > > > Diffs > - > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java c4f7267 > > > Diff: https://reviews.apache.org/r/60043/diff/2/ > > > Testing > --- > > Below steps were followed to test this scenario > > 1. Installed Hadoop KMS > 2. Created encryption keys with combination of special characters, alphabets > and numbers > 3. Installed Ranger KMS > 4. imported hadoop key jceks to Ranger KMS (Validation was successful) > > > Thanks, > > Ankita Sinha > >
[jira] [Commented] (RANGER-1582) Support KNOX SSO Token based authentication on Ranger REST API calls
[ https://issues.apache.org/jira/browse/RANGER-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047786#comment-16047786 ] Ankita Sinha commented on RANGER-1582: -- Committed to master : https://github.com/apache/ranger/commit/9a99e3f41cc2125295058a8fc32e5b9e53bb48a4 > Support KNOX SSO Token based authentication on Ranger REST API calls > > > Key: RANGER-1582 > URL: https://issues.apache.org/jira/browse/RANGER-1582 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: 1.0.0 >Reporter: Ankita Sinha >Assignee: Ankita Sinha > Fix For: 1.0.0 > > Attachments: RANGER-1582.patch > > > *Actual* : > Currently Knox SSO is just supported from Ranger UI through web browser. > *Expected* : > Support KNOX SSO Token based authentication on Ranger REST API calls. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Review Request 60046: RANGER-1640 - HBase Test Connection does not work when creating a service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60046/ --- Review request for ranger. Bugs: RANGER-1640 https://issues.apache.org/jira/browse/RANGER-1640 Repository: ranger Description --- Testing a connection doesn't work with the HBase service on the first go in the Admin UI, as the password is not yet encrypted Diffs - agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java 485ac04e Diff: https://reviews.apache.org/r/60046/diff/1/ Testing --- Tested that the connection works fine in the Admin UI when creating a service and also when editing an already created service. Thanks, Colm O hEigeartaigh
[jira] [Updated] (RANGER-1640) HBase Test Connection does not work when creating a service
[ https://issues.apache.org/jira/browse/RANGER-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated RANGER-1640: Attachment: 0001-RANGER-1640-HBase-Test-Connection-does-not-work-when.patch > HBase Test Connection does not work when creating a service > --- > > Key: RANGER-1640 > URL: https://issues.apache.org/jira/browse/RANGER-1640 > Project: Ranger > Issue Type: Bug > Components: admin >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1640-HBase-Test-Connection-does-not-work-when.patch > > > Testing a connection doesn't work with the HBase service on the first go in > the Admin UI, as the password is not yet encrypted. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 60043: Ranger KMS should validate key name before importing into DB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/ --- (Updated June 13, 2017, 12:06 p.m.) Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. Changes --- Updated Review request with review comments Bugs: RANGER-1639 https://issues.apache.org/jira/browse/RANGER-1639 Repository: ranger Description --- Actual : Ranger KMS does not validate key name before importing into DB. So the imported key can have special characters in Key name. Expected : Ranger KMS should validate key name before importing into DB. Diffs (updated) - kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java c4f7267 Diff: https://reviews.apache.org/r/60043/diff/2/ Changes: https://reviews.apache.org/r/60043/diff/1-2/ Testing --- Below steps were followed to test this scenario 1. Installed Hadoop KMS 2. Created encryption keys with combination of special characters, alphabets and numbers 3. Installed Ranger KMS 4. imported hadoop key jceks to Ranger KMS (Validation was successful) Thanks, Ankita Sinha
Re: Review Request 60043: Ranger KMS should validate key name before importing into DB
- Ankita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/#review177725 --- On June 13, 2017, 12:06 p.m., Ankita Sinha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60043/ > --- > > (Updated June 13, 2017, 12:06 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1639 > https://issues.apache.org/jira/browse/RANGER-1639 > > > Repository: ranger > > > Description > --- > > Actual : > Ranger KMS does not validate key name before importing into DB. So the > imported key can have special characters in Key name. > > Expected : > Ranger KMS should validate key name before importing into DB. > > > Diffs > - > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java c4f7267 > > > Diff: https://reviews.apache.org/r/60043/diff/2/ > > > Testing > --- > > Below steps were followed to test this scenario > > 1. Installed Hadoop KMS > 2. Created encryption keys with combination of special characters, alphabets > and numbers > 3. Installed Ranger KMS > 4. imported hadoop key jceks to Ranger KMS (Validation was successful) > > > Thanks, > > Ankita Sinha > >
Re: Review Request 60043: Ranger KMS should validate key name before importing into DB
> On June 13, 2017, 10:31 a.m., Colm O hEigeartaigh wrote: > > Instead of calling Pattern.compile for each check, it's better to make the > > Pattern static + call Pattern.compile once, as the regex itself is static > > and doesn't change. Thanks, Updated the review request. - Ankita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/#review177725 --- On June 13, 2017, 12:06 p.m., Ankita Sinha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60043/ > --- > > (Updated June 13, 2017, 12:06 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1639 > https://issues.apache.org/jira/browse/RANGER-1639 > > > Repository: ranger > > > Description > --- > > Actual : > Ranger KMS does not validate key name before importing into DB. So the > imported key can have special characters in Key name. > > Expected : > Ranger KMS should validate key name before importing into DB. > > > Diffs > - > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java c4f7267 > > > Diff: https://reviews.apache.org/r/60043/diff/2/ > > > Testing > --- > > Below steps were followed to test this scenario > > 1. Installed Hadoop KMS > 2. Created encryption keys with combination of special characters, alphabets > and numbers > 3. Installed Ranger KMS > 4. imported hadoop key jceks to Ranger KMS (Validation was successful) > > > Thanks, > > Ankita Sinha > >
[jira] [Created] (RANGER-1640) HBase Test Connection does not work when creating a service
Colm O hEigeartaigh created RANGER-1640: --- Summary: HBase Test Connection does not work when creating a service Key: RANGER-1640 URL: https://issues.apache.org/jira/browse/RANGER-1640 Project: Ranger Issue Type: Bug Components: admin Reporter: Colm O hEigeartaigh Assignee: Colm O hEigeartaigh Fix For: 1.0.0 Testing a connection doesn't work with the HBase service on the first go in the Admin UI, as the password is not yet encrypted. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1639) Ranger KMS should validate key name before importing into DB
[ https://issues.apache.org/jira/browse/RANGER-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1639: - Attachment: RANGER-1639.patch > Ranger KMS should validate key name before importing into DB > > > Key: RANGER-1639 > URL: https://issues.apache.org/jira/browse/RANGER-1639 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: 1.0.0 >Reporter: Ankita Sinha >Assignee: Ankita Sinha > Fix For: 1.0.0 > > Attachments: RANGER-1639.patch > > > *Actual* : > Ranger KMS does not validate key name before importing into DB. So the > imported key can have special characters in Key name. > *Expected* : > Ranger KMS should validate key name before importing into DB. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1639) Ranger KMS should validate key name before importing into DB
[ https://issues.apache.org/jira/browse/RANGER-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1639: - Attachment: (was: RANGER-1639.patch) > Ranger KMS should validate key name before importing into DB > > > Key: RANGER-1639 > URL: https://issues.apache.org/jira/browse/RANGER-1639 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: 1.0.0 >Reporter: Ankita Sinha >Assignee: Ankita Sinha > Fix For: 1.0.0 > > > *Actual* : > Ranger KMS does not validate key name before importing into DB. So the > imported key can have special characters in Key name. > *Expected* : > Ranger KMS should validate key name before importing into DB. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60034/#review177727 --- Ship it! Ship It! - Velmurugan Periasamy On June 13, 2017, 9:55 a.m., Ankita Sinha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60034/ > --- > > (Updated June 13, 2017, 9:55 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1582 > https://issues.apache.org/jira/browse/RANGER-1582 > > > Repository: ranger > > > Description > --- > > Actual : > Currently Knox SSO is just supported from Ranger UI through web browser. > > Expected : > Support KNOX SSO Token based authentication on Ranger REST API calls. > > > Diffs > - > > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java > ffb60b9 > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > f0ccae1 > > > Diff: https://reviews.apache.org/r/60034/diff/2/ > > > Testing > --- > > 1. Checked Knox SSO for REST API Calls > 2. Knox SSO working as expected from Ranger UI > 3. Tested in secure as well as simple environment. > > > Thanks, > > Ankita Sinha > >
Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60034/#review177726 --- Ship it! Ship It! - Colm O hEigeartaigh On June 13, 2017, 9:55 a.m., Ankita Sinha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60034/ > --- > > (Updated June 13, 2017, 9:55 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1582 > https://issues.apache.org/jira/browse/RANGER-1582 > > > Repository: ranger > > > Description > --- > > Actual : > Currently Knox SSO is just supported from Ranger UI through web browser. > > Expected : > Support KNOX SSO Token based authentication on Ranger REST API calls. > > > Diffs > - > > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java > ffb60b9 > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > f0ccae1 > > > Diff: https://reviews.apache.org/r/60034/diff/2/ > > > Testing > --- > > 1. Checked Knox SSO for REST API Calls > 2. Knox SSO working as expected from Ranger UI > 3. Tested in secure as well as simple environment. > > > Thanks, > > Ankita Sinha > >
Re: Review Request 60043: Ranger KMS should validate key name before importing into DB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/#review177725 --- Instead of calling Pattern.compile for each check, it's better to make the Pattern static + call Pattern.compile once, as the regex itself is static and doesn't change. - Colm O hEigeartaigh On June 13, 2017, 10:07 a.m., Ankita Sinha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60043/ > --- > > (Updated June 13, 2017, 10:07 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1639 > https://issues.apache.org/jira/browse/RANGER-1639 > > > Repository: ranger > > > Description > --- > > Actual : > Ranger KMS does not validate key name before importing into DB. So the > imported key can have special characters in Key name. > > Expected : > Ranger KMS should validate key name before importing into DB. > > > Diffs > - > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java c4f7267 > > > Diff: https://reviews.apache.org/r/60043/diff/1/ > > > Testing > --- > > Below steps were followed to test this scenario > > 1. Installed Hadoop KMS > 2. Created encryption keys with combination of special characters, alphabets > and numbers > 3. Installed Ranger KMS > 4. imported hadoop key jceks to Ranger KMS (Validation was successful) > > > Thanks, > > Ankita Sinha > >
Review Request 60043: Ranger KMS should validate key name before importing into DB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/ --- Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. Bugs: RANGER-1639 https://issues.apache.org/jira/browse/RANGER-1639 Repository: ranger Description --- Actual : Ranger KMS does not validate key name before importing into DB. So the imported key can have special characters in Key name. Expected : Ranger KMS should validate key name before importing into DB. Diffs - kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java c4f7267 Diff: https://reviews.apache.org/r/60043/diff/1/ Testing --- Below steps were followed to test this scenario 1. Installed Hadoop KMS 2. Created encryption keys with combination of special characters, alphabets and numbers 3. Installed Ranger KMS 4. imported hadoop key jceks to Ranger KMS (Validation was successful) Thanks, Ankita Sinha
[jira] [Updated] (RANGER-1639) Ranger KMS should validate key name before importing into DB
[ https://issues.apache.org/jira/browse/RANGER-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1639: - Attachment: RANGER-1639.patch > Ranger KMS should validate key name before importing into DB > > > Key: RANGER-1639 > URL: https://issues.apache.org/jira/browse/RANGER-1639 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: 1.0.0 >Reporter: Ankita Sinha >Assignee: Ankita Sinha > Fix For: 1.0.0 > > Attachments: RANGER-1639.patch > > > *Actual* : > Ranger KMS does not validate key name before importing into DB. So the > imported key can have special characters in Key name. > *Expected* : > Ranger KMS should validate key name before importing into DB. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls
> On June 13, 2017, 8:49 a.m., Colm O hEigeartaigh wrote: > > Please put curly brackets around the two one-line if statements: > > if(LOG.isDebugEnabled()) Thanks, updated with the suggested changes. - Ankita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60034/#review177715 --- On June 13, 2017, 9:55 a.m., Ankita Sinha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60034/ > --- > > (Updated June 13, 2017, 9:55 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1582 > https://issues.apache.org/jira/browse/RANGER-1582 > > > Repository: ranger > > > Description > --- > > Actual : > Currently Knox SSO is just supported from Ranger UI through web browser. > > Expected : > Support KNOX SSO Token based authentication on Ranger REST API calls. > > > Diffs > - > > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java > ffb60b9 > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > f0ccae1 > > > Diff: https://reviews.apache.org/r/60034/diff/2/ > > > Testing > --- > > 1. Checked Knox SSO for REST API Calls > 2. Knox SSO working as expected from Ranger UI > 3. Tested in secure as well as simple environment. > > > Thanks, > > Ankita Sinha > >
Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60034/ --- (Updated June 13, 2017, 9:55 a.m.) Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. Changes --- Included curly brackets around the two one-line if statements: if(LOG.isDebugEnabled()) Bugs: RANGER-1582 https://issues.apache.org/jira/browse/RANGER-1582 Repository: ranger Description --- Actual : Currently Knox SSO is just supported from Ranger UI through web browser. Expected : Support KNOX SSO Token based authentication on Ranger REST API calls. Diffs (updated) - security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java ffb60b9 security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml f0ccae1 Diff: https://reviews.apache.org/r/60034/diff/2/ Changes: https://reviews.apache.org/r/60034/diff/1-2/ Testing --- 1. Checked Knox SSO for REST API Calls 2. Knox SSO working as expected from Ranger UI 3. Tested in secure as well as simple environment. Thanks, Ankita Sinha
Re: Review Request 60032: Remove the pmd check error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60032/#review177717 --- Ship it! Ship It! - Colm O hEigeartaigh On June 13, 2017, 4:36 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60032/ > --- > > (Updated June 13, 2017, 4:36 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1636 > https://issues.apache.org/jira/browse/RANGER-1636 > > > Repository: ranger > > > Description > --- > > The following information will occur when using PMD tool to check code. > > > name="/submitranger/RangerCompile01/Ranger/agents-common/src/test/java/org/apache/ranger/plugin/errors/TestValidationErrorCode.java"> > rule="UnusedImports" ruleset="Import Statements" > package="org.apache.ranger.plugin.errors" > externalInfoUrl="http://pmd.sourceforge.net/pmd-5.3.2/pmd-java/rules/java/imports.html#UnusedImports"; > priority="4"> > Avoid unused imports such as > 'org.apache.ranger.plugin.model.validation.ValidationFailureDetails' > > > name="/submitranger/RangerCompile01/Ranger/agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerValidator.java"> > rule="UnusedLocalVariable" ruleset="Unused Code" > package="org.apache.ranger.plugin.model.validation" > class="TestRangerValidator$RangerValidatorForTest" method="isValid" > variable="valid" > externalInfoUrl="http://pmd.sourceforge.net/pmd-5.3.2/pmd-java/rules/java/unusedcode.html#UnusedLocalVariable"; > priority="3"> > Avoid unused local variables such as 'valid'. > > > > > > name="/home/pengjianhua/gerrit/submitranger/RangerCompile/kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java"> > rule="UnusedFormalParameter" ruleset="Unused Code" > package="org.apache.hadoop.crypto.key" class="RangerKeyStore" > method="mapToEntityBean" variable="i" > externalInfoUrl="http://pmd.sourceforge.net/pmd-5.3.2/pmd-java/rules/java/unusedcode.html#UnusedFormalParameter"; > priority="3"> > Avoid unused method parameters such as 'i'. > > > > > > Diffs > - > > > agents-common/src/test/java/org/apache/ranger/plugin/errors/TestValidationErrorCode.java > 1b00c64 > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java c4f7267 > > > Diff: https://reviews.apache.org/r/60032/diff/1/ > > > Testing > --- > > > Thanks, > > pengjianhua > >
[jira] [Updated] (RANGER-1582) Support KNOX SSO Token based authentication on Ranger REST API calls
[ https://issues.apache.org/jira/browse/RANGER-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1582: - Attachment: RANGER-1582.patch > Support KNOX SSO Token based authentication on Ranger REST API calls > > > Key: RANGER-1582 > URL: https://issues.apache.org/jira/browse/RANGER-1582 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: 1.0.0 >Reporter: Ankita Sinha >Assignee: Ankita Sinha > Fix For: 1.0.0 > > Attachments: RANGER-1582.patch > > > *Actual* : > Currently Knox SSO is just supported from Ranger UI through web browser. > *Expected* : > Support KNOX SSO Token based authentication on Ranger REST API calls. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1582) Support KNOX SSO Token based authentication on Ranger REST API calls
[ https://issues.apache.org/jira/browse/RANGER-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1582: - Attachment: (was: RANGER-1582.patch) > Support KNOX SSO Token based authentication on Ranger REST API calls > > > Key: RANGER-1582 > URL: https://issues.apache.org/jira/browse/RANGER-1582 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: 1.0.0 >Reporter: Ankita Sinha >Assignee: Ankita Sinha > Fix For: 1.0.0 > > > *Actual* : > Currently Knox SSO is just supported from Ranger UI through web browser. > *Expected* : > Support KNOX SSO Token based authentication on Ranger REST API calls. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (RANGER-1639) Ranger KMS should validate key name before importing into DB
Ankita Sinha created RANGER-1639: Summary: Ranger KMS should validate key name before importing into DB Key: RANGER-1639 URL: https://issues.apache.org/jira/browse/RANGER-1639 Project: Ranger Issue Type: Bug Components: Ranger Affects Versions: 1.0.0 Reporter: Ankita Sinha Assignee: Ankita Sinha Fix For: 1.0.0 *Actual* : Ranger KMS does not validate key name before importing into DB. So the imported key can have special characters in Key name. *Expected* : Ranger KMS should validate key name before importing into DB. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60034/#review177715 --- Please put curly brackets around the two one-line if statements: if(LOG.isDebugEnabled()) - Colm O hEigeartaigh On June 13, 2017, 8:23 a.m., Ankita Sinha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60034/ > --- > > (Updated June 13, 2017, 8:23 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1582 > https://issues.apache.org/jira/browse/RANGER-1582 > > > Repository: ranger > > > Description > --- > > Actual : > Currently Knox SSO is just supported from Ranger UI through web browser. > > Expected : > Support KNOX SSO Token based authentication on Ranger REST API calls. > > > Diffs > - > > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java > ffb60b9 > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 4f5f1d3 > > > Diff: https://reviews.apache.org/r/60034/diff/1/ > > > Testing > --- > > 1. Checked Knox SSO for REST API Calls > 2. Knox SSO working as expected from Ranger UI > 3. Tested in secure as well as simple environment. > > > Thanks, > > Ankita Sinha > >
Review Request 60034: Support KNOX SSO Token based authentication on Ranger REST API calls
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60034/ --- Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. Bugs: RANGER-1582 https://issues.apache.org/jira/browse/RANGER-1582 Repository: ranger Description --- Actual : Currently Knox SSO is just supported from Ranger UI through web browser. Expected : Support KNOX SSO Token based authentication on Ranger REST API calls. Diffs - security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java ffb60b9 security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3 Diff: https://reviews.apache.org/r/60034/diff/1/ Testing --- 1. Checked Knox SSO for REST API Calls 2. Knox SSO working as expected from Ranger UI 3. Tested in secure as well as simple environment. Thanks, Ankita Sinha
