Re: Review Request 64634: RANGER-1929:The ranger should support the View policy.

[pengjianhua]

> On 十二月 19, 2017, 11:14 a.m., Colm O hEigeartaigh wrote:
> > Looks good thanks, but please see Vel's comments on the JIRA.

Ok. I had fixed it according to Vel's comments. Please get it from 
https://reviews.apache.org/r/64634/diff/5/. Thanks.


- pengjianhua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/#review194135
---


On 十二月 20, 2017, 6:23 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64634/
> ---
> 
> (Updated 十二月 20, 2017, 6:23 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1929
> https://issues.apache.org/jira/browse/RANGER-1929
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently we can only edit the policy without viewing the policy. We must use 
> editing funtion of policy when only need to query the detail for policy. So 
> we should supply the function of the query detail for policy.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> b8de5c3ba 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js
>  PRE-CREATION 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js 
> PRE-CREATION 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  09e2e1669 
>   security-admin/src/main/webapp/styles/xa.css 22eedf644 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64634/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

[jira] [Updated] (RANGER-1929) The ranger should support the View policy.

[peng.jianhua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1929:
-
Attachment: (was: 
0001-RANGER-1929-The-ranger-should-support-preview-policy.patch)

> The ranger should support the View policy.
> --
>
> Key: RANGER-1929
> URL: https://issues.apache.org/jira/browse/RANGER-1929
> Project: Ranger
>  Issue Type: New Feature
>  Components: admin
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: newbie, patch
> Attachments: 
> 0001-RANGER-1929-The-ranger-should-support-the-View-polic.patch, 
> ragner_pic1.png, ragner_pic2.png, ragner_pic3.png, ragner_pic4.png, 
> view-policy.png
>
>
> Currently we can only edit the policy without viewing the policy. We must use 
> editing funtion of policy when only need to query the detail for policy. So 
> we should supply the function of the query detail for policy.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 64634: RANGER-1929:The ranger should support the View policy.

[pengjianhua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/
---

(Updated 十二月 20, 2017, 6:23 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1929
https://issues.apache.org/jira/browse/RANGER-1929


Repository: ranger


Description
---

Currently we can only edit the policy without viewing the policy. We must use 
editing funtion of policy when only need to query the detail for policy. So we 
should supply the function of the query detail for policy.


Diffs (updated)
-

  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
b8de5c3ba 
  
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js 
PRE-CREATION 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js 
PRE-CREATION 
  
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
 09e2e1669 
  security-admin/src/main/webapp/styles/xa.css 22eedf644 
  
security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html
 PRE-CREATION 
  
security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html 
PRE-CREATION 


Diff: https://reviews.apache.org/r/64634/diff/5/

Changes: https://reviews.apache.org/r/64634/diff/4-5/


Testing
---


Thanks,

pengjianhua

[jira] [Comment Edited] (RANGER-1929) The ranger should support the View policy.

[peng.jianhua (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297835#comment-16297835
 ] 

peng.jianhua edited comment on RANGER-1929 at 12/20/17 6:22 AM:


Hi [~vperiasamy], please refer to view-policy.png. I added the View icon near 
edit icon. Thanks.

I updated the patch.


was (Author: peng.jianhua):
Hi [~vperiasamy], please refer to view-policy.png. I added the View icon near 
edit icon. Thanks.

> The ranger should support the View policy.
> --
>
> Key: RANGER-1929
> URL: https://issues.apache.org/jira/browse/RANGER-1929
> Project: Ranger
>  Issue Type: New Feature
>  Components: admin
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: newbie, patch
> Attachments: 
> 0001-RANGER-1929-The-ranger-should-support-the-View-polic.patch, 
> ragner_pic1.png, ragner_pic2.png, ragner_pic3.png, ragner_pic4.png, 
> view-policy.png
>
>
> Currently we can only edit the policy without viewing the policy. We must use 
> editing funtion of policy when only need to query the detail for policy. So 
> we should supply the function of the query detail for policy.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RANGER-1929) The ranger should support the View policy.

[peng.jianhua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1929:
-
Attachment: 0001-RANGER-1929-The-ranger-should-support-the-View-polic.patch

> The ranger should support the View policy.
> --
>
> Key: RANGER-1929
> URL: https://issues.apache.org/jira/browse/RANGER-1929
> Project: Ranger
>  Issue Type: New Feature
>  Components: admin
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: newbie, patch
> Attachments: 
> 0001-RANGER-1929-The-ranger-should-support-the-View-polic.patch, 
> ragner_pic1.png, ragner_pic2.png, ragner_pic3.png, ragner_pic4.png, 
> view-policy.png
>
>
> Currently we can only edit the policy without viewing the policy. We must use 
> editing funtion of policy when only need to query the detail for policy. So 
> we should supply the function of the query detail for policy.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RANGER-1934) Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

[peng.jianhua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1934:
-
Attachment: 0001-RANGER-1934-Optimize-the-init-method-in-BaseAuditHan.patch

> Optimize the init method in BaseAuditHandler class to avoid 
> ArrayIndexOutOfBoundsException
> --
>
> Key: RANGER-1934
> URL: https://issues.apache.org/jira/browse/RANGER-1934
> Project: Ranger
>  Issue Type: Bug
>  Components: audit
>Affects Versions: master
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
> Fix For: master
>
> Attachments: 
> 0001-RANGER-1934-Optimize-the-init-method-in-BaseAuditHan.patch
>
>
> Optimize  the init method in BaseAuditHandler class to avoid 
> ArrayIndexOutOfBoundsException
> The follow in the init method "   List tokens = 
> MiscUtil.toArray(propPrefix, ".");
> String finalToken = tokens.get(tokens.size() - 1);".
> in the init method we should add " if (tokens.size() > 1)" to avoid 
> ArrayIndexOutOfBoundsException.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RANGER-1934) Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

[peng.jianhua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1934:
-
Attachment: (was: 
0001-RANGER-1934-Optimize-the-init-method-in-BaseAuditHan.patch)

> Optimize the init method in BaseAuditHandler class to avoid 
> ArrayIndexOutOfBoundsException
> --
>
> Key: RANGER-1934
> URL: https://issues.apache.org/jira/browse/RANGER-1934
> Project: Ranger
>  Issue Type: Bug
>  Components: audit
>Affects Versions: master
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
> Fix For: master
>
> Attachments: 
> 0001-RANGER-1934-Optimize-the-init-method-in-BaseAuditHan.patch
>
>
> Optimize  the init method in BaseAuditHandler class to avoid 
> ArrayIndexOutOfBoundsException
> The follow in the init method "   List tokens = 
> MiscUtil.toArray(propPrefix, ".");
> String finalToken = tokens.get(tokens.size() - 1);".
> in the init method we should add " if (tokens.size() > 1)" to avoid 
> ArrayIndexOutOfBoundsException.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

[pengjianhua]

> On 十二月 19, 2017, 11:53 a.m., Colm O hEigeartaigh wrote:
> > Better to have "!tokens.isEmpty()" than "tokens.size() > 0". Also, the 
> > indentation inside the if statement is wrong "if (providerName == null) {".

Hi, I has updated the patch .thanks.


- pengjianhua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64677/#review194136
---


On 十二月 20, 2017, 5:54 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64677/
> ---
> 
> (Updated 十二月 20, 2017, 5:54 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1934
> https://issues.apache.org/jira/browse/RANGER-1934
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Optimize the init method in BaseAuditHandler class to avoid 
> ArrayIndexOutOfBoundsException
> The follow in the init method "   List tokens = 
> MiscUtil.toArray(propPrefix, ".");
> String finalToken = tokens.get(tokens.size() - 1);".
> in the init method we should add " if (tokens.size() > 1)" to avoid 
> ArrayIndexOutOfBoundsException.
> 
> 
> Diffs
> -
> 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java
>  b095000 
> 
> 
> Diff: https://reviews.apache.org/r/64677/diff/3/
> 
> 
> Testing
> ---
> 
> Tested it.
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

[pengjianhua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64677/
---

(Updated 十二月 20, 2017, 5:54 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1934
https://issues.apache.org/jira/browse/RANGER-1934


Repository: ranger


Description
---

Optimize the init method in BaseAuditHandler class to avoid 
ArrayIndexOutOfBoundsException
The follow in the init method " List tokens = 
MiscUtil.toArray(propPrefix, ".");
String finalToken = tokens.get(tokens.size() - 1);".
in the init method we should add " if (tokens.size() > 1)" to avoid 
ArrayIndexOutOfBoundsException.


Diffs (updated)
-

  
agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java
 b095000 


Diff: https://reviews.apache.org/r/64677/diff/3/

Changes: https://reviews.apache.org/r/64677/diff/2-3/


Testing
---

Tested it.


Thanks,

pengjianhua

Re: Review Request 64705: RANGER-1781: RangerUI :Policy create/edit form should display only relevant accesses based on the user-selected resource.

[Gautam Borad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64705/#review194215
---


Ship it!




Ship It!

- Gautam Borad


On Dec. 19, 2017, 9:34 a.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64705/
> ---
> 
> (Updated Dec. 19, 2017, 9:34 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, 
> Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1781
> https://issues.apache.org/jira/browse/RANGER-1781
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Policy create/edit form should display only applicable set of access 
> permissions based on the policy resource (excludedAccesses property) and not 
> the entire set of permissions defined for the service definition.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js 
> c4911af 
>   security-admin/src/main/webapp/scripts/modules/XAOverrides.js f340bee 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 90b41d8 
>   security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 
> df6a2be 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 
> 1475dd9 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
> 443ecc8 
>   security-admin/src/main/webapp/styles/xa.css 22eedf6 
> 
> 
> Diff: https://reviews.apache.org/r/64705/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Policy CRUD working fine with existing service definition.
> 2. Verified policy CRUD after modifying resources and access types by 
> updating service definiton.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>

[jira] [Updated] (RANGER-1929) The ranger should support the View policy.

[peng.jianhua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1929:
-
Attachment: view-policy.png

> The ranger should support the View policy.
> --
>
> Key: RANGER-1929
> URL: https://issues.apache.org/jira/browse/RANGER-1929
> Project: Ranger
>  Issue Type: New Feature
>  Components: admin
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: newbie, patch
> Attachments: 
> 0001-RANGER-1929-The-ranger-should-support-preview-policy.patch, 
> ragner_pic1.png, ragner_pic2.png, ragner_pic3.png, ragner_pic4.png, 
> view-policy.png
>
>
> Currently we can only edit the policy without viewing the policy. We must use 
> editing funtion of policy when only need to query the detail for policy. So 
> we should supply the function of the query detail for policy.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 64634: RANGER-1929:The ranger should support the View policy.

[pengjianhua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/
---

(Updated 十二月 20, 2017, 3:19 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Summary (updated)
-

RANGER-1929:The ranger should support  the View policy.


Bugs: RANGER-1929
https://issues.apache.org/jira/browse/RANGER-1929


Repository: ranger


Description (updated)
---

Currently we can only edit the policy without viewing the policy. We must use 
editing funtion of policy when only need to query the detail for policy. So we 
should supply the function of the query detail for policy.


Diffs
-

  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
b8de5c3b 
  
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js 
PRE-CREATION 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js 
PRE-CREATION 
  
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
 09e2e166 
  security-admin/src/main/webapp/styles/xa.css 22eedf64 
  
security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html
 PRE-CREATION 
  
security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html 
PRE-CREATION 


Diff: https://reviews.apache.org/r/64634/diff/4/


Testing
---


Thanks,

pengjianhua

[jira] [Updated] (RANGER-1929) The ranger should support View policy.

[peng.jianhua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1929:
-
Description: Currently we can only edit the policy without viewing the 
policy. We must use editing funtion of policy when only need to query the 
detail for policy. So we should supply the function of the query detail for 
policy.  (was: Currently we can only edit the policy without previewing the 
policy. We must use editing funtion of policy when only need to query the 
detail for policy. So we should supply the function of the query detail for 
policy.)

> The ranger should support View policy.
> --
>
> Key: RANGER-1929
> URL: https://issues.apache.org/jira/browse/RANGER-1929
> Project: Ranger
>  Issue Type: New Feature
>  Components: admin
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: newbie, patch
> Attachments: 
> 0001-RANGER-1929-The-ranger-should-support-preview-policy.patch, 
> ragner_pic1.png, ragner_pic2.png, ragner_pic3.png, ragner_pic4.png
>
>
> Currently we can only edit the policy without viewing the policy. We must use 
> editing funtion of policy when only need to query the detail for policy. So 
> we should supply the function of the query detail for policy.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RANGER-1929) The ranger should support View policy.

[peng.jianhua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1929:
-
Summary: The ranger should support View policy.  (was: The ranger should 
support preview policy.)

> The ranger should support View policy.
> --
>
> Key: RANGER-1929
> URL: https://issues.apache.org/jira/browse/RANGER-1929
> Project: Ranger
>  Issue Type: New Feature
>  Components: admin
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: newbie, patch
> Attachments: 
> 0001-RANGER-1929-The-ranger-should-support-preview-policy.patch, 
> ragner_pic1.png, ragner_pic2.png, ragner_pic3.png, ragner_pic4.png
>
>
> Currently we can only edit the policy without previewing the policy. We must 
> use editing funtion of policy when only need to query the detail for policy. 
> So we should supply the function of the query detail for policy.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (RANGER-1929) The ranger should support preview policy.

[peng.jianhua (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297835#comment-16297835
 ] 

peng.jianhua commented on RANGER-1929:
--

Hi [~vperiasamy], please refer to view-policy.png. I added the View icon near 
edit icon. Thanks.

> The ranger should support preview policy.
> -
>
> Key: RANGER-1929
> URL: https://issues.apache.org/jira/browse/RANGER-1929
> Project: Ranger
>  Issue Type: New Feature
>  Components: admin
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: newbie, patch
> Attachments: 
> 0001-RANGER-1929-The-ranger-should-support-preview-policy.patch, 
> ragner_pic1.png, ragner_pic2.png, ragner_pic3.png, ragner_pic4.png
>
>
> Currently we can only edit the policy without previewing the policy. We must 
> use editing funtion of policy when only need to query the detail for policy. 
> So we should supply the function of the query detail for policy.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RANGER-1929) The ranger should support the View policy.

[peng.jianhua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1929:
-
Summary: The ranger should support the View policy.  (was: The ranger 
should support View policy.)

> The ranger should support the View policy.
> --
>
> Key: RANGER-1929
> URL: https://issues.apache.org/jira/browse/RANGER-1929
> Project: Ranger
>  Issue Type: New Feature
>  Components: admin
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: newbie, patch
> Attachments: 
> 0001-RANGER-1929-The-ranger-should-support-preview-policy.patch, 
> ragner_pic1.png, ragner_pic2.png, ragner_pic3.png, ragner_pic4.png
>
>
> Currently we can only edit the policy without viewing the policy. We must use 
> editing funtion of policy when only need to query the detail for policy. So 
> we should supply the function of the query detail for policy.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (RANGER-1939) Simplify Maven dependencies and assembly specification for hdfs plugin module

[Abhay Kulkarni (JIRA)]

Abhay Kulkarni created RANGER-1939:
--

 Summary: Simplify Maven dependencies and assembly specification 
for hdfs plugin module
 Key: RANGER-1939
 URL: https://issues.apache.org/jira/browse/RANGER-1939
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Affects Versions: master
Reporter: Abhay Kulkarni
Assignee: Abhay Kulkarni
 Fix For: master


There are two issues with the Maven POM files for Ranger's hdfs plugin module.

1. There are overlapping and sometimes conflicting versions of libraries on 
which hdfs plugin code depends. Conflicts arise partly because some of the 
libraries packaged with hdfs plugin module are already exist in hdfs component 
and have different versions.
2. assembly specification for hdfs plugin module uses DependencySets - a 
construct which is confusing and hard to get right. They also clutter up build 
output log with spurious messages. It is desirable to use FileSets which are 
easier to understand and straightforward to specify in an assembly spec.





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RANGER-1938) Solr for Audit setup doesn't use DocValues effectively

[Velmurugan Periasamy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Velmurugan Periasamy updated RANGER-1938:
-
Fix Version/s: 0.7.2
   1.0.0

> Solr for Audit setup doesn't use DocValues effectively
> --
>
> Key: RANGER-1938
> URL: https://issues.apache.org/jira/browse/RANGER-1938
> Project: Ranger
>  Issue Type: Bug
>  Components: audit
>Affects Versions: 0.6.0, 0.7.0, 0.6.1, 0.6.2, 0.6.3, 0.7.1
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>  Labels: performance
> Fix For: 1.0.0, 0.7.2
>
> Attachments: 
> 0001-RANGER-1938-Enable-DocValues-for-more-fields-in-Solr.patch
>
>
> Ranger uses Ambari Infra Solr (or another Apache Solr install) for storing 
> Ranger Audit events for displaying in Ranger Admin. In our case, we have 
> noticed quite a few Ambari Infra Solr OOM due to Ranger. I've talked with a 
> few other people who are having very similar problems with OOM errors.
> I've typed up some details about how the way Ranger is using Solr requires a 
> lot of heap. I've also outlined the fix for this which significantly reduced 
> the amount of heap memory required. I'm an Apache Lucene/Solr committer so 
> this optimization/usage might not be immediately obvious to those using Solr 
> especially version 5.x.
> https://risdenk.github.io/2017/12/18/ambari-infra-solr-ranger.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RANGER-1938) Solr for Audit setup doesn't use DocValues effectively

[Kevin Risden (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated RANGER-1938:
-
Labels: performance  (was: )

> Solr for Audit setup doesn't use DocValues effectively
> --
>
> Key: RANGER-1938
> URL: https://issues.apache.org/jira/browse/RANGER-1938
> Project: Ranger
>  Issue Type: Bug
>  Components: audit
>Affects Versions: 0.6.0, 0.7.0, 0.6.1, 0.6.2, 0.6.3, 0.7.1
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>  Labels: performance
> Attachments: 
> 0001-RANGER-1938-Enable-DocValues-for-more-fields-in-Solr.patch
>
>
> Ranger uses Ambari Infra Solr (or another Apache Solr install) for storing 
> Ranger Audit events for displaying in Ranger Admin. In our case, we have 
> noticed quite a few Ambari Infra Solr OOM due to Ranger. I've talked with a 
> few other people who are having very similar problems with OOM errors.
> I've typed up some details about how the way Ranger is using Solr requires a 
> lot of heap. I've also outlined the fix for this which significantly reduced 
> the amount of heap memory required. I'm an Apache Lucene/Solr committer so 
> this optimization/usage might not be immediately obvious to those using Solr 
> especially version 5.x.
> https://risdenk.github.io/2017/12/18/ambari-infra-solr-ranger.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (RANGER-1938) Solr for Audit setup doesn't use DocValues effectively

[Kevin Risden (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297750#comment-16297750
 ] 

Kevin Risden commented on RANGER-1938:
--

This will require Solr 5.5 or later. Migrating from non DocValues to DocValues 
requires a reindex if planning to keep existing documents. I have deleted the 
ranger_audit collection and recreated it after making this schema change. For 
new installations this isn't a concern.

> Solr for Audit setup doesn't use DocValues effectively
> --
>
> Key: RANGER-1938
> URL: https://issues.apache.org/jira/browse/RANGER-1938
> Project: Ranger
>  Issue Type: Bug
>  Components: audit
>Affects Versions: 0.6.0, 0.7.0, 0.6.1, 0.6.2, 0.6.3, 0.7.1
>Reporter: Kevin Risden
>Assignee: Kevin Risden
> Attachments: 
> 0001-RANGER-1938-Enable-DocValues-for-more-fields-in-Solr.patch
>
>
> Ranger uses Ambari Infra Solr (or another Apache Solr install) for storing 
> Ranger Audit events for displaying in Ranger Admin. In our case, we have 
> noticed quite a few Ambari Infra Solr OOM due to Ranger. I've talked with a 
> few other people who are having very similar problems with OOM errors.
> I've typed up some details about how the way Ranger is using Solr requires a 
> lot of heap. I've also outlined the fix for this which significantly reduced 
> the amount of heap memory required. I'm an Apache Lucene/Solr committer so 
> this optimization/usage might not be immediately obvious to those using Solr 
> especially version 5.x.
> https://risdenk.github.io/2017/12/18/ambari-infra-solr-ranger.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (RANGER-1938) Solr for Audit setup doesn't use DocValues effectively

[Kevin Risden (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297749#comment-16297749
 ] 

Kevin Risden commented on RANGER-1938:
--

https://reviews.apache.org/r/64740/

> Solr for Audit setup doesn't use DocValues effectively
> --
>
> Key: RANGER-1938
> URL: https://issues.apache.org/jira/browse/RANGER-1938
> Project: Ranger
>  Issue Type: Bug
>  Components: audit
>Affects Versions: 0.6.0, 0.7.0, 0.6.1, 0.6.2, 0.6.3, 0.7.1
>Reporter: Kevin Risden
>Assignee: Kevin Risden
> Attachments: 
> 0001-RANGER-1938-Enable-DocValues-for-more-fields-in-Solr.patch
>
>
> Ranger uses Ambari Infra Solr (or another Apache Solr install) for storing 
> Ranger Audit events for displaying in Ranger Admin. In our case, we have 
> noticed quite a few Ambari Infra Solr OOM due to Ranger. I've talked with a 
> few other people who are having very similar problems with OOM errors.
> I've typed up some details about how the way Ranger is using Solr requires a 
> lot of heap. I've also outlined the fix for this which significantly reduced 
> the amount of heap memory required. I'm an Apache Lucene/Solr committer so 
> this optimization/usage might not be immediately obvious to those using Solr 
> especially version 5.x.
> https://risdenk.github.io/2017/12/18/ambari-infra-solr-ranger.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RANGER-1938) Solr for Audit setup doesn't use DocValues effectively

[Kevin Risden (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated RANGER-1938:
-
Attachment: 0001-RANGER-1938-Enable-DocValues-for-more-fields-in-Solr.patch

> Solr for Audit setup doesn't use DocValues effectively
> --
>
> Key: RANGER-1938
> URL: https://issues.apache.org/jira/browse/RANGER-1938
> Project: Ranger
>  Issue Type: Bug
>  Components: audit
>Affects Versions: 0.6.0, 0.7.0, 0.6.1, 0.6.2, 0.6.3, 0.7.1
>Reporter: Kevin Risden
>Assignee: Kevin Risden
> Attachments: 
> 0001-RANGER-1938-Enable-DocValues-for-more-fields-in-Solr.patch
>
>
> Ranger uses Ambari Infra Solr (or another Apache Solr install) for storing 
> Ranger Audit events for displaying in Ranger Admin. In our case, we have 
> noticed quite a few Ambari Infra Solr OOM due to Ranger. I've talked with a 
> few other people who are having very similar problems with OOM errors.
> I've typed up some details about how the way Ranger is using Solr requires a 
> lot of heap. I've also outlined the fix for this which significantly reduced 
> the amount of heap memory required. I'm an Apache Lucene/Solr committer so 
> this optimization/usage might not be immediately obvious to those using Solr 
> especially version 5.x.
> https://risdenk.github.io/2017/12/18/ambari-infra-solr-ranger.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 64740: RANGER-1938: Solr for Audit setup doesn't use DocValues effectively

[Kevin Risden]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64740/
---

(Updated Dec. 19, 2017, 7:22 p.m.)


Review request for ranger.


Bugs: RANGER-1938
https://issues.apache.org/jira/browse/RANGER-1938


Repository: ranger


Description (updated)
---

RANGER-1938: Solr for Audit setup doesn't use DocValues effectively

This requires Solr 5.5.x or later for DocValues to be used in this way.


Diffs
-

  security-admin/contrib/solr_for_audit_setup/conf/managed-schema 4d032f55 


Diff: https://reviews.apache.org/r/64740/diff/1/


Testing
---

See details here: 
https://risdenk.github.io/2017/12/18/ambari-infra-solr-ranger.html

This has been running for about 2 months for us on Ambari Infra Solr 5.5. It 
dropped heap usage from 22GB+ to  less than 4GB for the _version_ field. This 
did not change the behavior of Ranger Admin when querying Solr.


Thanks,

Kevin Risden

Review Request 64740: RANGER-1938: Solr for Audit setup doesn't use DocValues effectively

[Kevin Risden]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64740/
---

Review request for ranger.


Bugs: RANGER-1938
https://issues.apache.org/jira/browse/RANGER-1938


Repository: ranger


Description
---

RANGER-1938: Solr for Audit setup doesn't use DocValues effectively


Diffs
-

  security-admin/contrib/solr_for_audit_setup/conf/managed-schema 4d032f55 


Diff: https://reviews.apache.org/r/64740/diff/1/


Testing
---

See details here: 
https://risdenk.github.io/2017/12/18/ambari-infra-solr-ranger.html

This has been running for about 2 months for us on Ambari Infra Solr 5.5. It 
dropped heap usage from 22GB+ to  less than 4GB for the _version_ field. This 
did not change the behavior of Ranger Admin when querying Solr.


Thanks,

Kevin Risden

[jira] [Assigned] (RANGER-1938) Solr for Audit setup doesn't use DocValues effectively

[Kevin Risden (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden reassigned RANGER-1938:


Assignee: Kevin Risden

> Solr for Audit setup doesn't use DocValues effectively
> --
>
> Key: RANGER-1938
> URL: https://issues.apache.org/jira/browse/RANGER-1938
> Project: Ranger
>  Issue Type: Bug
>  Components: audit
>Affects Versions: 0.6.0, 0.7.0, 0.6.1, 0.6.2, 0.6.3, 0.7.1
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>
> Ranger uses Ambari Infra Solr (or another Apache Solr install) for storing 
> Ranger Audit events for displaying in Ranger Admin. In our case, we have 
> noticed quite a few Ambari Infra Solr OOM due to Ranger. I've talked with a 
> few other people who are having very similar problems with OOM errors.
> I've typed up some details about how the way Ranger is using Solr requires a 
> lot of heap. I've also outlined the fix for this which significantly reduced 
> the amount of heap memory required. I'm an Apache Lucene/Solr committer so 
> this optimization/usage might not be immediately obvious to those using Solr 
> especially version 5.x.
> https://risdenk.github.io/2017/12/18/ambari-infra-solr-ranger.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 64705: RANGER-1781: RangerUI :Policy create/edit form should display only relevant accesses based on the user-selected resource.

[Abhay Kulkarni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64705/#review194193
---


Ship it!




Ship It!

- Abhay Kulkarni


On Dec. 19, 2017, 9:34 a.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64705/
> ---
> 
> (Updated Dec. 19, 2017, 9:34 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, 
> Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1781
> https://issues.apache.org/jira/browse/RANGER-1781
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Policy create/edit form should display only applicable set of access 
> permissions based on the policy resource (excludedAccesses property) and not 
> the entire set of permissions defined for the service definition.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js 
> c4911af 
>   security-admin/src/main/webapp/scripts/modules/XAOverrides.js f340bee 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 90b41d8 
>   security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 
> df6a2be 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 
> 1475dd9 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
> 443ecc8 
>   security-admin/src/main/webapp/styles/xa.css 22eedf6 
> 
> 
> Diff: https://reviews.apache.org/r/64705/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Policy CRUD working fine with existing service definition.
> 2. Verified policy CRUD after modifying resources and access types by 
> updating service definiton.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>

[jira] [Commented] (RANGER-1938) Solr for Audit setup doesn't use DocValues effectively

[Kevin Risden (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297553#comment-16297553
 ] 

Kevin Risden commented on RANGER-1938:
--

>From this mailing list thread:

https://mail-archives.apache.org/mod_mbox/ranger-user/201712.mbox/%3CCAJU9nmjAZSuHdujNtOUbsAgtf4qG7YiJ46CnCceFbcUAyZmJWw%40mail.gmail.com%3E

> Solr for Audit setup doesn't use DocValues effectively
> --
>
> Key: RANGER-1938
> URL: https://issues.apache.org/jira/browse/RANGER-1938
> Project: Ranger
>  Issue Type: Bug
>  Components: audit
>Affects Versions: 0.6.0, 0.7.0, 0.6.1, 0.6.2, 0.6.3, 0.7.1
>Reporter: Kevin Risden
>
> Ranger uses Ambari Infra Solr (or another Apache Solr install) for storing 
> Ranger Audit events for displaying in Ranger Admin. In our case, we have 
> noticed quite a few Ambari Infra Solr OOM due to Ranger. I've talked with a 
> few other people who are having very similar problems with OOM errors.
> I've typed up some details about how the way Ranger is using Solr requires a 
> lot of heap. I've also outlined the fix for this which significantly reduced 
> the amount of heap memory required. I'm an Apache Lucene/Solr committer so 
> this optimization/usage might not be immediately obvious to those using Solr 
> especially version 5.x.
> https://risdenk.github.io/2017/12/18/ambari-infra-solr-ranger.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RANGER-1897) TagSync should replace use of V1 Atlas APIs with V2 APIs for efficient tag-download from Atlas

[Velmurugan Periasamy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Velmurugan Periasamy updated RANGER-1897:
-
Fix Version/s: 1.0.0

> TagSync should replace use of V1 Atlas APIs with V2 APIs for efficient 
> tag-download from Atlas
> --
>
> Key: RANGER-1897
> URL: https://issues.apache.org/jira/browse/RANGER-1897
> Project: Ranger
>  Issue Type: Bug
>  Components: tagsync
>Affects Versions: 0.7.2
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
> Fix For: 1.0.0
>
> Attachments: RANGER-1897.patch
>
>
> Currently tag-synchronization via REST API method uses Atlas V1 APIs, which 
> requires large number of calls from Ranger tag-sync to Atlas server. In 
> environments having large number of entities, this approach can take a long 
> time to download tags from Atlas. Use of Atlas V2 APIs would significantly 
> improve the performance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RANGER-1938) Solr for Audit setup doesn't use DocValues effectively

[Kevin Risden (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Risden updated RANGER-1938:
-
Summary: Solr for Audit setup doesn't use DocValues effectively  (was: Solr 
for Audit setup doesn't require DocValues)

> Solr for Audit setup doesn't use DocValues effectively
> --
>
> Key: RANGER-1938
> URL: https://issues.apache.org/jira/browse/RANGER-1938
> Project: Ranger
>  Issue Type: Bug
>  Components: audit
>Affects Versions: 0.6.0, 0.7.0, 0.6.1, 0.6.2, 0.6.3, 0.7.1
>Reporter: Kevin Risden
>
> Ranger uses Ambari Infra Solr (or another Apache Solr install) for storing 
> Ranger Audit events for displaying in Ranger Admin. In our case, we have 
> noticed quite a few Ambari Infra Solr OOM due to Ranger. I've talked with a 
> few other people who are having very similar problems with OOM errors.
> I've typed up some details about how the way Ranger is using Solr requires a 
> lot of heap. I've also outlined the fix for this which significantly reduced 
> the amount of heap memory required. I'm an Apache Lucene/Solr committer so 
> this optimization/usage might not be immediately obvious to those using Solr 
> especially version 5.x.
> https://risdenk.github.io/2017/12/18/ambari-infra-solr-ranger.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Ranger and Ambari Infra Solr (or another Solr install) - OOM

[Kevin Risden]

Created https://issues.apache.org/jira/browse/RANGER-1938

I'll move more details from the blog post into the ticket and should be
able to come up with the simple patch.

Kevin Risden

On Tue, Dec 19, 2017 at 3:58 PM, Velmurugan Periasamy <
vperias...@hortonworks.com> wrote:

> This is a good idea. Thanks Kevin. Please go ahead with JIRA. Adding dev
> list.
>
> From: Kevin Risden mailto:kris...@apache.org>>
> Reply-To: "u...@ranger.apache.org" <
> u...@ranger.apache.org>
> Date: Tuesday, December 19, 2017 at 4:52 PM
> To: "u...@ranger.apache.org" <
> u...@ranger.apache.org>
> Subject: Ranger and Ambari Infra Solr (or another Solr install) - OOM
>
> Ranger uses Ambari Infra Solr (or another Apache Solr install) for storing
> Ranger Audit events for displaying in Ranger Admin. In our case, we have
> noticed quite a few Ambari Infra Solr OOM due to Ranger. I've talked with a
> few other people who are having very similar problems with OOM errors.
>
> I've typed up some details about how the way Ranger is using Solr requires
> a lot of heap. I've also outlined the fix for this which significantly
> reduced the amount of heap memory required. I'm an Apache Lucene/Solr
> committer so this optimization/usage might not be immediately obvious to
> those using Solr especially version 5.x.
>
> https://risdenk.github.io/2017/12/18/ambari-infra-solr-ranger.html
>
> I can open a JIRA issue if this would be helpful to fix the managed-schema
> shipped with Ranger. This would also be something that should be fixed
> upstream with Ambari if possible when deploying Ranger and Ambari Infra
> Solr.
>
> Kevin Risden
>

[jira] [Created] (RANGER-1938) Solr for Audit setup doesn't require DocValues

[Kevin Risden (JIRA)]

Kevin Risden created RANGER-1938:


 Summary: Solr for Audit setup doesn't require DocValues
 Key: RANGER-1938
 URL: https://issues.apache.org/jira/browse/RANGER-1938
 Project: Ranger
  Issue Type: Bug
  Components: audit
Affects Versions: 0.7.1, 0.6.3, 0.6.2, 0.6.1, 0.7.0, 0.6.0
Reporter: Kevin Risden


Ranger uses Ambari Infra Solr (or another Apache Solr install) for storing 
Ranger Audit events for displaying in Ranger Admin. In our case, we have 
noticed quite a few Ambari Infra Solr OOM due to Ranger. I've talked with a few 
other people who are having very similar problems with OOM errors.

I've typed up some details about how the way Ranger is using Solr requires a 
lot of heap. I've also outlined the fix for this which significantly reduced 
the amount of heap memory required. I'm an Apache Lucene/Solr committer so this 
optimization/usage might not be immediately obvious to those using Solr 
especially version 5.x.

https://risdenk.github.io/2017/12/18/ambari-infra-solr-ranger.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Ranger and Ambari Infra Solr (or another Solr install) - OOM

[Velmurugan Periasamy]

This is a good idea. Thanks Kevin. Please go ahead with JIRA. Adding dev list.

From: Kevin Risden mailto:kris...@apache.org>>
Reply-To: "u...@ranger.apache.org" 
mailto:u...@ranger.apache.org>>
Date: Tuesday, December 19, 2017 at 4:52 PM
To: "u...@ranger.apache.org" 
mailto:u...@ranger.apache.org>>
Subject: Ranger and Ambari Infra Solr (or another Solr install) - OOM

Ranger uses Ambari Infra Solr (or another Apache Solr install) for storing 
Ranger Audit events for displaying in Ranger Admin. In our case, we have 
noticed quite a few Ambari Infra Solr OOM due to Ranger. I've talked with a few 
other people who are having very similar problems with OOM errors.

I've typed up some details about how the way Ranger is using Solr requires a 
lot of heap. I've also outlined the fix for this which significantly reduced 
the amount of heap memory required. I'm an Apache Lucene/Solr committer so this 
optimization/usage might not be immediately obvious to those using Solr 
especially version 5.x.

https://risdenk.github.io/2017/12/18/ambari-infra-solr-ranger.html

I can open a JIRA issue if this would be helpful to fix the managed-schema 
shipped with Ranger. This would also be something that should be fixed upstream 
with Ambari if possible when deploying Ranger and Ambari Infra Solr.

Kevin Risden

Review Request 64723: Ranger tagsync should process ENTITY_CREATE notification, to support Atlas import feature

[Abhay Kulkarni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64723/
---

Review request for ranger and Madhan Neethiraj.


Bugs: RANGER-1937
https://issues.apache.org/jira/browse/RANGER-1937


Repository: ranger


Description
---

Currently Ranger tagsync ignores ENTITY_CREATE notifications from Atlas, as no 
tags would be associated with the newly created entity. However, when an entity 
is created in Atlas via import, tags could be associated with the entity. To 
not miss the tags associated with the entities, Ranger tagsync should be 
updated to process ENTITY_CREATE notifications as well.


Diffs
-

  
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java
 f42c908 


Diff: https://reviews.apache.org/r/64723/diff/1/


Testing
---

Unit test run successful


Thanks,

Abhay Kulkarni

[jira] [Created] (RANGER-1937) Ranger tagsync should process ENTITY_CREATE notification, to support Atlas import feature

[Abhay Kulkarni (JIRA)]

Abhay Kulkarni created RANGER-1937:
--

 Summary: Ranger tagsync should process ENTITY_CREATE notification, 
to support Atlas import feature
 Key: RANGER-1937
 URL: https://issues.apache.org/jira/browse/RANGER-1937
 Project: Ranger
  Issue Type: Bug
  Components: tagsync
Affects Versions: 0.7.1, 0.7.0
Reporter: Abhay Kulkarni
Assignee: Abhay Kulkarni
 Fix For: 0.7.2


Currently Ranger tagsync ignores ENTITY_CREATE notifications from Atlas, as no 
tags would be associated with the newly created entity. However, when an entity 
is created in Atlas via import, tags could be associated with the entity. To 
not miss the tags associated with the entities, Ranger tagsync should be 
updated to process ENTITY_CREATE notifications as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 59523: RANGER-689 - "For Solr plugin, use resources folders for adding Ranger properties".

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59523/#review194153
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 24, 2017, 11:08 a.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59523/
> ---
> 
> (Updated May 24, 2017, 11:08 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-689
> https://issues.apache.org/jira/browse/RANGER-689
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Put the Ranger properties into the SOLR resource folder instead of the webapp.
> 
> 
> Diffs
> -
> 
>   agents-common/scripts/enable-agent.sh 76ba8f0d 
> 
> 
> Diff: https://reviews.apache.org/r/59523/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with Solr 6.5.1.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

[jira] [Commented] (RANGER-689) For Solr plugin, use resources folders for adding Ranger properties

[Velmurugan Periasamy (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296715#comment-16296715
 ] 

Velmurugan Periasamy commented on RANGER-689:
-

[~rmani]/[~vishal.suvagia] - could you please review 
https://reviews.apache.org/r/59523/ ?

> For Solr plugin, use resources folders for adding Ranger properties
> ---
>
> Key: RANGER-689
> URL: https://issues.apache.org/jira/browse/RANGER-689
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Affects Versions: 0.5.0
>Reporter: Don Bosco Durai
>Assignee: Colm O hEigeartaigh
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-689-For-Solr-plugin-use-resources-folders-for.patch
>
>
> Currently, the jars required by Ranger are added to WEB-INF/lib and 
> WEB-INF/classes folders. However, Solr recommends to put all extension jars 
> in server/lib/ext and properties in server/resources
> We should update out plugin installer code to use the new location.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 64708: RANGER-1936 - Upgrade Ranger to use Java 1.8

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64708/#review194139
---


Ship it!




Ship It!

- Velmurugan Periasamy


On Dec. 19, 2017, 10:28 a.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64708/
> ---
> 
> (Updated Dec. 19, 2017, 10:28 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1936
> https://issues.apache.org/jira/browse/RANGER-1936
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> As discussed on the mailing list, this task is to upgrade Ranger to use Java 
> 1.8.
> 
> 
> Diffs
> -
> 
>   pom.xml a537a65a 
> 
> 
> Diff: https://reviews.apache.org/r/64708/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

[jira] [Commented] (RANGER-1929) The ranger should support preview policy.

[peng.jianhua (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296680#comment-16296680
 ] 

peng.jianhua commented on RANGER-1929:
--

Hi [~vperiasamy], ok. Thanks.

> The ranger should support preview policy.
> -
>
> Key: RANGER-1929
> URL: https://issues.apache.org/jira/browse/RANGER-1929
> Project: Ranger
>  Issue Type: New Feature
>  Components: admin
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: newbie, patch
> Attachments: 
> 0001-RANGER-1929-The-ranger-should-support-preview-policy.patch, 
> ragner_pic1.png, ragner_pic2.png, ragner_pic3.png, ragner_pic4.png
>
>
> Currently we can only edit the policy without previewing the policy. We must 
> use editing funtion of policy when only need to query the detail for policy. 
> So we should supply the function of the query detail for policy.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 59523: RANGER-689 - "For Solr plugin, use resources folders for adding Ranger properties".

[Colm O hEigeartaigh]

> On Aug. 11, 2017, 11:55 a.m., Colm O hEigeartaigh wrote:
> > *bump*
> 
> Colm O hEigeartaigh wrote:
> Requesting review, please.

Could someone take a look please?


- Colm


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59523/#review182682
---


On May 24, 2017, 11:08 a.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59523/
> ---
> 
> (Updated May 24, 2017, 11:08 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-689
> https://issues.apache.org/jira/browse/RANGER-689
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Put the Ranger properties into the SOLR resource folder instead of the webapp.
> 
> 
> Diffs
> -
> 
>   agents-common/scripts/enable-agent.sh 76ba8f0d 
> 
> 
> Diff: https://reviews.apache.org/r/59523/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with Solr 6.5.1.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64677/#review194136
---



Better to have "!tokens.isEmpty()" than "tokens.size() > 0". Also, the 
indentation inside the if statement is wrong "if (providerName == null) {".

- Colm O hEigeartaigh


On Dec. 19, 2017, 1:40 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64677/
> ---
> 
> (Updated Dec. 19, 2017, 1:40 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1934
> https://issues.apache.org/jira/browse/RANGER-1934
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Optimize the init method in BaseAuditHandler class to avoid 
> ArrayIndexOutOfBoundsException
> The follow in the init method "   List tokens = 
> MiscUtil.toArray(propPrefix, ".");
> String finalToken = tokens.get(tokens.size() - 1);".
> in the init method we should add " if (tokens.size() > 1)" to avoid 
> ArrayIndexOutOfBoundsException.
> 
> 
> Diffs
> -
> 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java
>  b095000 
> 
> 
> Diff: https://reviews.apache.org/r/64677/diff/2/
> 
> 
> Testing
> ---
> 
> Tested it.
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 64634: RANGER-1929:The ranger should support preview policy.

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/#review194135
---



Looks good thanks, but please see Vel's comments on the JIRA.

- Colm O hEigeartaigh


On Dec. 19, 2017, 9:16 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64634/
> ---
> 
> (Updated Dec. 19, 2017, 9:16 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1929
> https://issues.apache.org/jira/browse/RANGER-1929
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently we can only edit the policy without previewing the policy. We must 
> use editing funtion of policy when only need to query the detail for policy. 
> So we should supply the function of the query detail for policy.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> b8de5c3b 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js
>  PRE-CREATION 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js 
> PRE-CREATION 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  09e2e166 
>   security-admin/src/main/webapp/styles/xa.css 22eedf64 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64634/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Re: Moving master to Java 1.8?

[Colm O hEigeartaigh]

OK thanks all, as there is consensus I've updated the Jenkins job to use
Java 1.8 and submitted the following patch:

https://issues.apache.org/jira/browse/RANGER-1936

Colm.

On Tue, Dec 19, 2017 at 1:17 AM,  wrote:

> +1
>
>
>
>
>
>
> Jianhua Peng
> 原始邮件
> *发件人：* ;
> *收件人：* ;
> *抄送人：* ;
> *日 期 ：*2017年12月19日 05:00
> *主 题 ：**Re: Moving master to Java 1.8?*
> +1
>
> Thanks,
> Selva-
>
> > On Dec 18, 2017, at 2:52 PM, Velmurugan Periasamy  > wrote:
> >
> > Colm ­ this is a good idea. +1
> >
> > From:  Ramesh Mani 
> > Reply-To:  "dev@ranger.apache.org" 
> > Date:  Monday, December 18, 2017 at 1:08 PM
> > To:  "dev@ranger.apache.org" , "coh
> ei...@apache.org"
> > 
> > Subject:  Re: Moving master to Java 1.8?
> >
> > Colm,
> >
> > I having being thinking on this, when we move to Hbase 2.
> 0 version we need
> > Java 1.8 for the  Ranger hbase plugin to compile.
> >
> > +1 for this.
> >
> > Thanks,
> > Ramesh
> >
> > On 12/16/17, 10:18 AM, "Colm O hEigeartaigh"  > wrote:
> >
> >> Hi all,
> >>
> >> Before I fix the currently failing Hive tests with JDK 7,
>  I'm wondering if
> >> it's time to move Ranger master to require Java 1.8.
> Apache Hadoop 3.0.0
> >> requires Java 1.8 - so we will have to make the switch
> if we want to pick
> >> up Hadoop 3.0.0 for Ranger 1.0.0. Apache Knox 0.14.0 is
> also Java 8 only,
> >> so we can't upgrade to that as things stand.
> >>
> >> Thoughts?
> >>
> >> Colm.
> >>
> >>
> >> --
> >> Colm O hEigeartaigh
> >>
> >> Talend Community Coder
> >> http://coders.talend.com
> >
> >
> >
> >
>
>
>


-- 
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com

Review Request 64708: RANGER-1936 - Upgrade Ranger to use Java 1.8

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64708/
---

Review request for ranger.


Bugs: RANGER-1936
https://issues.apache.org/jira/browse/RANGER-1936


Repository: ranger


Description
---

As discussed on the mailing list, this task is to upgrade Ranger to use Java 
1.8.


Diffs
-

  pom.xml a537a65a 


Diff: https://reviews.apache.org/r/64708/diff/1/


Testing
---


Thanks,

Colm O hEigeartaigh

[jira] [Updated] (RANGER-1936) Upgrade Ranger to use Java 1.8

[Colm O hEigeartaigh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated RANGER-1936:

Attachment: 0001-RANGER-1936-Upgrade-Ranger-to-use-Java-1.8.patch

> Upgrade Ranger to use Java 1.8
> --
>
> Key: RANGER-1936
> URL: https://issues.apache.org/jira/browse/RANGER-1936
> Project: Ranger
>  Issue Type: Improvement
>  Components: admin, plugins
>Reporter: Colm O hEigeartaigh
>Assignee: Colm O hEigeartaigh
> Fix For: 1.0.0
>
> Attachments: 0001-RANGER-1936-Upgrade-Ranger-to-use-Java-1.8.patch
>
>
> As discussed on the mailing list, this task is to upgrade Ranger to use Java 
> 1.8.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (RANGER-1936) Upgrade Ranger to use Java 1.8

[Colm O hEigeartaigh (JIRA)]

Colm O hEigeartaigh created RANGER-1936:
---

 Summary: Upgrade Ranger to use Java 1.8
 Key: RANGER-1936
 URL: https://issues.apache.org/jira/browse/RANGER-1936
 Project: Ranger
  Issue Type: Improvement
  Components: admin, plugins
Reporter: Colm O hEigeartaigh
Assignee: Colm O hEigeartaigh
 Fix For: 1.0.0


As discussed on the mailing list, this task is to upgrade Ranger to use Java 
1.8.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Review Request 64705: RANGER-1781: RangerUI :Policy create/edit form should display only relevant accesses based on the user-selected resource.

[Nitin Galave]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64705/
---

Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Pradeep 
Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-1781
https://issues.apache.org/jira/browse/RANGER-1781


Repository: ranger


Description
---

Policy create/edit form should display only applicable set of access 
permissions based on the policy resource (excludedAccesses property) and not 
the entire set of permissions defined for the service definition.


Diffs
-

  security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js c4911af 
  security-admin/src/main/webapp/scripts/modules/XAOverrides.js f340bee 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js 90b41d8 
  security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 
df6a2be 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 
1475dd9 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
443ecc8 
  security-admin/src/main/webapp/styles/xa.css 22eedf6 


Diff: https://reviews.apache.org/r/64705/diff/1/


Testing
---

1. Policy CRUD working fine with existing service definition.
2. Verified policy CRUD after modifying resources and access types by updating 
service definiton.


Thanks,

Nitin Galave

Re: Review Request 64634: RANGER-1929:The ranger should support preview policy.

[pengjianhua]

> On 十二月 18, 2017, 4:20 p.m., Colm O hEigeartaigh wrote:
> > Looks pretty good to me. Could you remove the whitespace errors from the 
> > patch?

Ok. I had fixed it. Please get it from 
https://reviews.apache.org/r/64634/diff/4/. Thanks.


- pengjianhua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/#review194076
---


On 十二月 19, 2017, 9:16 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64634/
> ---
> 
> (Updated 十二月 19, 2017, 9:16 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1929
> https://issues.apache.org/jira/browse/RANGER-1929
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently we can only edit the policy without previewing the policy. We must 
> use editing funtion of policy when only need to query the detail for policy. 
> So we should supply the function of the query detail for policy.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> b8de5c3b 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js
>  PRE-CREATION 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js 
> PRE-CREATION 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  09e2e166 
>   security-admin/src/main/webapp/styles/xa.css 22eedf64 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64634/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 64634: RANGER-1929:The ranger should support preview policy.

[pengjianhua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/
---

(Updated 十二月 19, 2017, 9:16 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1929
https://issues.apache.org/jira/browse/RANGER-1929


Repository: ranger


Description
---

Currently we can only edit the policy without previewing the policy. We must 
use editing funtion of policy when only need to query the detail for policy. So 
we should supply the function of the query detail for policy.


Diffs (updated)
-

  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
b8de5c3b 
  
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js 
PRE-CREATION 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js 
PRE-CREATION 
  
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
 09e2e166 
  security-admin/src/main/webapp/styles/xa.css 22eedf64 
  
security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html
 PRE-CREATION 
  
security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html 
PRE-CREATION 


Diff: https://reviews.apache.org/r/64634/diff/4/

Changes: https://reviews.apache.org/r/64634/diff/3-4/


Testing
---


Thanks,

pengjianhua