Re: Review Request 68849: RANGER-2235 Modify the login session detail page as a modal.

2018-10-02 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68849/#review209163
---


Ship it!




Ship It!

- Velmurugan Periasamy


On Sept. 26, 2018, 9:01 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68849/
> ---
> 
> (Updated Sept. 26, 2018, 9:01 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, pengjianhua, 
> Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam  rome, Venkat 
> Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2235
> https://issues.apache.org/jira/browse/RANGER-2235
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> On the Audit Admin tab page, if the user clicks to view the session details, 
> it will jump to a new page, user cannot return to previous page. We need to 
> click again to enter the Audit Admin tab page, and reselect the filter 
> condition and the page number.
> Audit Login Sessions tab page has the same problem.
> 
> Modify the login session detail page as a modal?the user can continue to view 
> the current page after close the modal.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 
> 697d33d9c 
>   security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js 
> e92929a93 
>   
> security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html 
> b11fa83fb 
> 
> 
> Diff: https://reviews.apache.org/r/68849/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 67697: RANGER-2140: Upgrade spring and guava libraries

2018-10-02 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67697/#review209162
---




knox-agent/src/test/java/org/apache/ranger/services/knox/KnoxRangerTest.java
Lines 46 (patched)


Upgrading to 25.1-jre is a good idea. 

Instead of ignoring the test, my suggestion is to fix the issue.

Also if this JIRA is going to be used only for Guava upgrade, please update 
the description in RR and JIRA. For spring version upgrade, please create a new 
JIRA. Thanks.


- Velmurugan Periasamy


On June 25, 2018, 10:26 a.m., Pradeep Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67697/
> ---
> 
> (Updated June 25, 2018, 10:26 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul 
> Parikh, suja s, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2140
> https://issues.apache.org/jira/browse/RANGER-2140
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Here I am proposing to change Guava version to only 17.0, currently there are 
> three different version are being used. Also proposing to change Spring 
> Security to 4.2.7 and Spring Framework to 4.3.18.
> 
> 
> Diffs
> -
> 
>   kms/pom.xml 6fc190f35 
>   
> knox-agent/src/test/java/org/apache/ranger/services/knox/KnoxRangerTest.java 
> 764192172 
>   plugin-atlas/pom.xml fcc037f93 
>   pom.xml e6695b440 
>   src/main/assembly/kms.xml 7fbc1410c 
>   src/main/assembly/plugin-atlas.xml 8f4a64cb6 
>   src/main/assembly/plugin-kms.xml 6d15f2a10 
>   src/main/assembly/plugin-solr.xml de30bfb13 
>   ugsync/pom.xml f4c24e739 
>   unixauthclient/pom.xml cd3d15604 
>   unixauthservice/pom.xml 2c0ed2eef 
> 
> 
> Diff: https://reviews.apache.org/r/67697/diff/3/
> 
> 
> Testing
> ---
> 
> Tested Ranger admin installation, user login, usersync and other crud 
> operations on service, policy, user and group module.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>

Re: Review Request 65950: Add support to allow clients to access resource permissions stored in Ranger

2018-10-02 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65950/#review209155
---




hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java
Lines 36 (patched)


Could you please fix PMD violations?

```
[INFO] --- maven-pmd-plugin:3.7:check (default) @ ranger-hbase-plugin ---
[INFO] PMD Failure: 
org/apache/ranger/authorization/hbase/AuthorizationSession.java:36 
Rule:UnusedImports Priority:4 Avoid unused imports such as 
'org.apache.ranger.plugin.policyengine.RangerResourceACLs'.
[INFO] PMD Failure: 
org.apache.ranger.authorization.hbase.HBaseRangerAuthorizationTest:1007 
Rule:UnusedLocalVariable Priority:3 Avoid unused local variables such as 
'userPermission'..
```



hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java
Lines 1007 (patched)


Please fix PMD violation.

```
[INFO] --- maven-pmd-plugin:3.7:check (default) @ ranger-hbase-plugin ---
[INFO] PMD Failure: 
org/apache/ranger/authorization/hbase/AuthorizationSession.java:36 
Rule:UnusedImports Priority:4 Avoid unused imports such as 
'org.apache.ranger.plugin.policyengine.RangerResourceACLs'.
[INFO] PMD Failure: 
org.apache.ranger.authorization.hbase.HBaseRangerAuthorizationTest:1007 
Rule:UnusedLocalVariable Priority:3 Avoid unused local variables such as 
'userPermission'..
```


- Velmurugan Periasamy


On Sept. 26, 2018, 10:40 p.m., Ankit Singhal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65950/
> ---
> 
> (Updated Sept. 26, 2018, 10:40 p.m.)
> 
> 
> Review request for ranger and Ramesh Mani.
> 
> 
> Bugs: RANGER-1958
> https://issues.apache.org/jira/browse/RANGER-1958
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-1958 [HBase] Implement getUserPermissions API of 
> AccessControlService.Interface to allow clients to access HBase permissions 
> stored in Ranger
> 
> 
> Diffs
> -
> 
>   
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java
>  cdaad00a4 
>   
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
>  d85339a09 
>   
> hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java
>  38408855d 
>   hbase-agent/src/test/resources/hbase-policies.json b7b44c9ea 
> 
> 
> Diff: https://reviews.apache.org/r/65950/diff/3/
> 
> 
> Testing
> ---
> 
> Unit testing is done
> 
> 
> Thanks,
> 
> Ankit Singhal
> 
>

Re: [RESULT] [VOTE] Apache Ranger Release 1.2.0-rc1

2018-10-02 Thread Velmurugan Periasamy 
Updated vote count. Sorry for missing a vote from Dilli. 

Seven +1 votes from the following PPMC member(s):

+1 Abhay Kulkarni
+1 Colm O hEigeartaigh
+1 Dilli Arumugam
+1 Madhanmohan Neethiraj
+1 Ramesh Mani
+1 Selvamohan Neethiraj
+1 Velmurugan Periasamy

Six +1 votes from the following non-PPMC member(s):

+1 Koji Kawamura
+1 Mehul Parikh
+1 Nixon Rodrigues
+1 Peng Jianhua
+1 Pradeep Agrawal
+1 Sailaja Polavarapu

Zero -1 votes:


> On Oct 2, 2018, at 11:50 AM, Velmurugan Periasamy  wrote:
> 
> Hello Rangers:
> 
> Thank you so much for your efforts to validate Apache Ranger 1.2.0 release 
> candidate #1 and your feedback/vote.
> 
> More than 72 hours have passed and the current vote thread is considered 
> concluded and passes with the following resolution:
> 
> Six +1 votes from the following PPMC member(s):
> 
> +1 Abhay Kulkarni
> +1 Colm O hEigeartaigh
> +1 Madhanmohan Neethiraj
> +1 Ramesh Mani
> +1 Selvamohan Neethiraj
> +1 Velmurugan Periasamy
> 
> Six +1 votes from the following non-PPMC member(s):
> 
> +1 Koji Kawamura
> +1 Mehul Parikh
> +1 Nixon Rodrigues
> +1 Peng Jianhua
> +1 Pradeep Agrawal
> +1 Sailaja Polavarapu
> 
> Zero -1 votes:
> 
> I will start the process of moving the release artifacts to the mirrors and 
> other release activities. 
> 
> Voting thread for reference - 
> https://lists.apache.org/thread.html/09dd1e32e8af7ae2bac334cd87f4c659493f938c71cd1d91ab321200@%3Cdev.ranger.apache.org%3E
>  
> 
> Issues fixed in this release - 
> https://cwiki.apache.org/confluence/display/RANGER/Apache+Ranger+1.2.0+-+Release+Notes
> 
> Thank you,
> Vel
> 
> 
>> On Sep 27, 2018, at 7:24 PM, Velmurugan Periasamy  wrote:
>> 
>> Hello Rangers:
>> 
>> Thank you for your contribution to Apache Ranger community. Apache Ranger 
>> 1.2.0 release candidate #1 is now available for a vote within dev community. 
>> 
>> Links to RC1 release artifacts are given below. Kindly request all Rangers 
>> (Dev's & PMC members) to review and vote on this release.
>> 
>> 
>> Git tag for the release:
>> https://github.com/apache/ranger/tree/ranger-1.2.0-rc1 (last commit id:  
>> 39ec5a38913e1d852cffecbdb8688b2370b6318f)
>> 
>> 
>> Sources for the release:
>> https://dist.apache.org/repos/dist/dev/ranger/1.2.0-rc1/apache-ranger-1.2.0.tar.gz
>> 
>> 
>> Source release verification:
>> 
>> PGP Signature:
>> https://dist.apache.org/repos/dist/dev/ranger/1.2.0-rc1/apache-ranger-1.2.0.tar.gz.asc
>> 
>> MD5/SHA Hashes:
>> https://dist.apache.org/repos/dist/dev/ranger/1.2.0-rc1/apache-ranger-1.2.0.tar.gz.mds
>> https://dist.apache.org/repos/dist/dev/ranger/1.2.0-rc1/apache-ranger-1.2.0.tar.gz.sha1
>> https://dist.apache.org/repos/dist/dev/ranger/1.2.0-rc1/apache-ranger-1.2.0.tar.gz.sha256
>> https://dist.apache.org/repos/dist/dev/ranger/1.2.0-rc1/apache-ranger-1.2.0.tar.gz.sha512
>> 
>> 
>> Keys to verify the signature of the release artifact are available at: 
>> https://dist.apache.org/repos/dist/release/ranger/KEYS
>> 
>> 
>> Release Notes:
>> https://cwiki.apache.org/confluence/display/RANGER/Apache+Ranger+1.2.0+-+Release+Notes
>> 
>> 
>> Build verification steps can be found at:
>> http://ranger.apache.org/quick_start_guide.html
>> 
>> 
>> The vote will be open for at least 72 hours or until necessary number of 
>> votes are reached.
>> [ ] +1  approve
>> [ ] +0  no opinion
>> [ ] -1  disapprove (and reason why)
>> 
>> Here is my +1
>> 
>> Thank you,
>> Vel
>

Re: Review Request 68864: RANGER-2237 Upgrade Kylin version to 2.5.0

2018-10-02 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68864/#review209154
---




pom.xml
Line 191 (original), 191 (patched)


This patch does not apply. Could you please rebase?

```
$ git apply --check -v < 
~/Downloads/0001-RANGER-2237-Upgrade-Kylin-version-to-2.5.0.patch
Checking patch pom.xml...
error: while searching for:
2.0.0
1.0.0
1.0.0
2.3.0
1.10
${project.basedir}/../lib/local
1.2.17

error: patch failed: pom.xml:188
error: pom.xml: patch does not apply
```


- Velmurugan Periasamy


On Sept. 27, 2018, 7:19 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68864/
> ---
> 
> (Updated Sept. 27, 2018, 7:19 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Nitin Galave, 
> pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam  rome, 
> Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2237
> https://issues.apache.org/jira/browse/RANGER-2237
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Upgrade Kylin version to 2.5.0
> 
> 
> Diffs
> -
> 
>   pom.xml e6695b440 
> 
> 
> Diff: https://reviews.apache.org/r/68864/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Passed all unit tests.
> 2. Tested authorization works correctly with Kylin v2.5.0
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 68894: RANGER-2239 - Update to surefire 2.21.0

2018-10-02 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68894/#review209153
---


Ship it!




Ship It!

- Velmurugan Periasamy


On Oct. 2, 2018, 8:52 a.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68894/
> ---
> 
> (Updated Oct. 2, 2018, 8:52 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2239
> https://issues.apache.org/jira/browse/RANGER-2239
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> To support newer Java versions, we need to update surefire.
> 
> 
> Diffs
> -
> 
>   pom.xml e0df461e9 
> 
> 
> Diff: https://reviews.apache.org/r/68894/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

2018-10-02 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68871/#review209152
---




security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java
Line 859 (original), 859 (patched)


Better to use equalsIgnoreCase ?


- Velmurugan Periasamy


On Sept. 28, 2018, 3:20 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68871/
> ---
> 
> (Updated Sept. 28, 2018, 3:20 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Nitin Galave, 
> pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam  rome, 
> Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2238
> https://issues.apache.org/jira/browse/RANGER-2238
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Here is related code:
> 
> for(RangerPolicy.RangerPolicyItemCondition condition : 
> policyItem.getConditions()) {
> if(condition.getType() == "ipaddress") {
> 
> equals() should be used to compare Strings.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 
> 0292881b4 
> 
> 
> Diff: https://reviews.apache.org/r/68871/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

2018-10-02 Thread Colm O hEigeartaigh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68871/#review209145
---


Ship it!




Ship It!

- Colm O hEigeartaigh


On Sept. 28, 2018, 3:20 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68871/
> ---
> 
> (Updated Sept. 28, 2018, 3:20 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Nitin Galave, 
> pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam  rome, 
> Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2238
> https://issues.apache.org/jira/browse/RANGER-2238
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Here is related code:
> 
> for(RangerPolicy.RangerPolicyItemCondition condition : 
> policyItem.getConditions()) {
> if(condition.getType() == "ipaddress") {
> 
> equals() should be used to compare Strings.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 
> 0292881b4 
> 
> 
> Diff: https://reviews.apache.org/r/68871/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Review Request 68894: RANGER-2239 - Update to surefire 2.21.0

2018-10-02 Thread Colm O hEigeartaigh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68894/
---

Review request for ranger.


Bugs: RANGER-2239
https://issues.apache.org/jira/browse/RANGER-2239


Repository: ranger


Description
---

To support newer Java versions, we need to update surefire.


Diffs
-

  pom.xml e0df461e9 


Diff: https://reviews.apache.org/r/68894/diff/1/


Testing
---


Thanks,

Colm O hEigeartaigh

[jira] [Updated] (RANGER-2239) Update to surefire 2.21.0

2018-10-02 Thread Colm O hEigeartaigh (JIRA) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated RANGER-2239:

Attachment: 0001-RANGER-2239-Update-to-surefire-2.21.0.patch

> Update to surefire 2.21.0
> -
>
> Key: RANGER-2239
> URL: https://issues.apache.org/jira/browse/RANGER-2239
> Project: Ranger
>  Issue Type: Task
>  Components: build-infra
>Reporter: Colm O hEigeartaigh
>Assignee: Colm O hEigeartaigh
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 0001-RANGER-2239-Update-to-surefire-2.21.0.patch
>
>
> To support newer Java versions, we need to update surefire.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (RANGER-2239) Update to surefire 2.21.0

2018-10-02 Thread Colm O hEigeartaigh (JIRA) 
Colm O hEigeartaigh created RANGER-2239:
---

 Summary: Update to surefire 2.21.0
 Key: RANGER-2239
 URL: https://issues.apache.org/jira/browse/RANGER-2239
 Project: Ranger
  Issue Type: Task
  Components: build-infra
Reporter: Colm O hEigeartaigh
Assignee: Colm O hEigeartaigh
 Fix For: 2.0.0


To support newer Java versions, we need to update surefire.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)