Re: Review Request 65950: Add support to allow clients to access resource permissions stored in Ranger

2018-10-05 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65950/#review209281
---


Ship it!




Ship It!

- Velmurugan Periasamy


On Oct. 4, 2018, 11:38 p.m., Ankit Singhal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65950/
> ---
> 
> (Updated Oct. 4, 2018, 11:38 p.m.)
> 
> 
> Review request for ranger and Ramesh Mani.
> 
> 
> Bugs: RANGER-1958
> https://issues.apache.org/jira/browse/RANGER-1958
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-1958 [HBase] Implement getUserPermissions API of 
> AccessControlService.Interface to allow clients to access HBase permissions 
> stored in Ranger
> 
> 
> Diffs
> -
> 
>   
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java
>  cdaad00a4 
>   
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
>  d85339a09 
>   
> hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java
>  38408855d 
>   hbase-agent/src/test/resources/hbase-policies.json b7b44c9ea 
> 
> 
> Diff: https://reviews.apache.org/r/65950/diff/4/
> 
> 
> Testing
> ---
> 
> Unit testing is done
> 
> 
> Thanks,
> 
> Ankit Singhal
> 
>

Review Request 68942: RANGER-2207: Allow resources to appear in column mask policies without being visible in access policies

2018-10-05 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68942/
---

Review request for ranger, Madhan Neethiraj, Nitin Galave, Ramesh Mani, and 
Velmurugan Periasamy.


Bugs: RANGER-2207
https://issues.apache.org/jira/browse/RANGER-2207


Repository: ranger


Description
---

In the service definition file, a resource can not be added to the list of 
dataMaskDef resources without also declaring it as a resource for access 
policies. Plugins should have the flexibility to define a resource for column 
masking policies only.

For example, a plugin may only allow the creation of access policies at the 
table level. Currently, for this plugin to add column masking policies with a 
'column' resource, 'column' would also have to be added to access policies.

This Jira requests the removal of this requirement, or at least the ability to 
hide the resource in access policies.

For a resource, if value of "mandatory" attribute is set to false, and uiHint 
is set to "{"hideIfNull": true }", then GUI will not display the resource 
(provided its value is set to null).

Following is a sample service-definition to illustrate the usage. "column" 
resource is specified in resources section as :
{
"description": "Hive Column", "isValidLeaf": true, "itemId": 4, 
"level": 30, "lookupSupported": true,
"mandatory": false, "matcherOptions": { "ignoreCase": "true", 
"wildCard": "true" },
"name": "column", "parent": "table", "type": "string", "uiHint": "{ 
\"hideIfNull\": true }"
}

It is specified in dataMaskDefs::resources section as:
{ "description": "Hive Column", "isValidLeaf": true, "itemId": 4, 
"level": 30, "lookupSupported": true,
"mandatory": true, "matcherOptions": { "ignoreCase": "true", 
"wildCard": "false" },
"name": "column", "parent": "table", "type": "string", 
"uiHint": "{ \"singleValue\":true }"
}

As a result, GUI for access policy creation will not display "column" resource, 
but GUI for masking policy creation will display it, and user can provide value 
for it.

Also note that in resources section, "table" resource (parent of "column")  is 
specified as being a valid leaf resource.
{ "description": "Hive Table", "isValidLeaf": false, "itemId": 2, 
"level": 20, "lookupSupported": true,
"mandatory": true, "matcherOptions": { "ignoreCase": "true", 
"wildCard": "false" },
"name": "table", "parent": "database", "type": "string", 
"uiHint": "{ \"singleValue\":true }"
},

This is required so that correct set of default policies are created.

Service-definition for a test component follows. This is closely modeled after 
hive component's service-definition.

{
"name": "test",
"description": "Test ServiceDef for RANGER-2207",
"isEnabled": true,
"options": { "enableDenyAndExceptionsInPolicies": "true" },
"accessTypes": [
{ "itemId": 1, "name": "select","label": "select" },
{ "itemId": 2, "name": "update","label": "update" },
{ "itemId": 3, "name": "create","label": "create" },
{ "itemId": 4, "name": "drop","label": "drop" },
{ "itemId": 5, "name": "alter","label": "alter" },
{ "itemId": 6, "name": "index","label": "index" },
{ "itemId": 7, "name": "lock","label": "lock" },
{ "impliedGrants": [ "select", "update", "create", "drop", "alter", 
"index",
"lock", "read", "write", "repladmin", "serviceadmin" ],
"itemId": 8, "name": "all","label": "all" },
{ "itemId": 9, "name": "read","label": "read" },
{ "itemId": 10, "name": "write","label": "write" },
{ "itemId": 11, "name": "repladmin","label": "repladmin" },
{ "itemId": 12, "name": "serviceadmin","label": "serviceadmin" },
{ "itemId": 13, "name": "tempudfadmin","label": "tempudfadmin" }
],
"resources": [
{
"description": "URL", "isValidLeaf": true, "itemId": 5, "level": 
10, "lookupSupported": false,
"mandatory": true, "matcher": 
"org.apache.ranger.plugin.resourcematcher.RangerPathResourceMatcher",
"matcherOptions": { "ignoreCase": "false", "wildCard": "true" },
"name": "url", "recursiveSupported": true, "type": "string"
},
{
"description": "Hive Service", "isValidLeaf": true, "itemId": 6, 
"level": 10, "lookupSupported": false,
"mandatory": true, "matcherOptions": { "ignoreCase": "false", 
"wildCard": "true" },
"name": "hiveservice", "type": "string"
},
{
"description": "Global", "isValidLeaf": true, "itemId": 7, "level": 
10, "lookupSupported": false,
"mandatory": true, "matcherOptions": { "ignoreCase": "false", 
"wildCard": "true" },

Re: Review Request 68855: RANGER-2222: Apache RangerKafkaPlugin support to handle Kafka Cluster as a new resource

2018-10-05 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68855/
---

(Updated Oct. 5, 2018, 11:15 p.m.)


Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan 
Periasamy.


Changes
---

Fixed PMD issues


Bugs: RANGER-
https://issues.apache.org/jira/browse/RANGER-


Repository: ranger


Description
---

RANGER-: Apache RangerKafkaPlugin support to handle Kafka Cluster as a new 
resource


Diffs (updated)
-

  agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json 
ca3e0fe 
  
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuditHandler.java
 PRE-CREATION 
  
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java
 eab869a 
  
plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerGSSTest.java
 c1386fe 
  
plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerTopicCreationTest.java
 PRE-CREATION 
  plugin-kafka/src/test/resources/kafka-policies.json 0c07604 
  plugin-kafka/src/test/resources/kafka_kerberos.jaas 1de804b 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 3f23b00 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql bafdb96 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
2bc58ac 
  
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 
1b64eea 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
4a216fe 
  
security-admin/src/main/java/org/apache/ranger/patch/PatchForKafkaServiceDefUpdate_J10025.java
 PRE-CREATION 
  src/main/assembly/plugin-kafka.xml 97ff8ad 


Diff: https://reviews.apache.org/r/68855/diff/5/

Changes: https://reviews.apache.org/r/68855/diff/4-5/


Testing
---

- This patch addresses "Cluster" and "DelegationToken" as resource in Ranger 
plugin.
- Tested in local vm and added unit test for TopicCreation.
- Upgrade patch tested for default policy creation for cluster and delegation 
token as resource.


Thanks,

Ramesh Mani

[jira] [Assigned] (RANGER-2243) Provide option to ranger builds to specifically build a single plugin

2018-10-05 Thread Sailaja Polavarapu (JIRA) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sailaja Polavarapu reassigned RANGER-2243:
--

Assignee: Sailaja Polavarapu

> Provide option to ranger builds to specifically build a single plugin
> -
>
> Key: RANGER-2243
> URL: https://issues.apache.org/jira/browse/RANGER-2243
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Sailaja Polavarapu
>Assignee: Sailaja Polavarapu
>Priority: Major
> Fix For: 2.0.0
>
>
> Make changes to ranger pom file to provide option for building individual 
> plugins. This way if anyone wants to deploy only ranger's hbase plugin, for 
> example, they can use the corresponding build option and generate only 
> ranger's hbase plugin tar instead of generating all the tar files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (RANGER-2243) Provide option to ranger builds to specifically build a single plugin

2018-10-05 Thread Sailaja Polavarapu (JIRA) 
Sailaja Polavarapu created RANGER-2243:
--

 Summary: Provide option to ranger builds to specifically build a 
single plugin
 Key: RANGER-2243
 URL: https://issues.apache.org/jira/browse/RANGER-2243
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: Sailaja Polavarapu
 Fix For: 2.0.0


Make changes to ranger pom file to provide option for building individual 
plugins. This way if anyone wants to deploy only ranger's hbase plugin, for 
example, they can use the corresponding build option and generate only ranger's 
hbase plugin tar instead of generating all the tar files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68855: RANGER-2222: Apache RangerKafkaPlugin support to handle Kafka Cluster as a new resource

2018-10-05 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68855/#review209277
---




plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java
Line 43 (original), 43 (patched)


Could you please fix PMD violations? Thanks.

```
[INFO] --- maven-pmd-plugin:3.7:check (default) @ ranger-kafka-plugin ---
[INFO] PMD Failure: 
org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java:43 
Rule:UnusedImports Priority:4 Avoid unused imports such as 
'org.apache.ranger.plugin.audit.RangerDefaultAuditHandler'.
[INFO] PMD Failure: 
org.apache.ranger.authorization.kafka.authorizer.KafkaRangerTopicCreationTest:197
 Rule:UnusedPrivateMethod Priority:3 Avoid unused private methods such as 
'checkTopicExists(KafkaConsumer)'..
[INFO] PMD Failure: 
org.apache.ranger.authorization.kafka.authorizer.KafkaRangerTopicCreationTest:207
 Rule:UnusedPrivateMethod Priority:3 Avoid unused private methods such as 
'sendMessage(Producer)'..
```



plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerTopicCreationTest.java
Lines 197 (patched)


Same as above.



plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerTopicCreationTest.java
Lines 207 (patched)


Same as above.


- Velmurugan Periasamy


On Oct. 5, 2018, 3:43 p.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68855/
> ---
> 
> (Updated Oct. 5, 2018, 3:43 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-
> https://issues.apache.org/jira/browse/RANGER-
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-: Apache RangerKafkaPlugin support to handle Kafka Cluster as a 
> new resource
> 
> 
> Diffs
> -
> 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json 
> ca3e0fe 
>   
> plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuditHandler.java
>  PRE-CREATION 
>   
> plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java
>  eab869a 
>   
> plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerGSSTest.java
>  c1386fe 
>   
> plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerTopicCreationTest.java
>  PRE-CREATION 
>   plugin-kafka/src/test/resources/kafka-policies.json 0c07604 
>   plugin-kafka/src/test/resources/kafka_kerberos.jaas 1de804b 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 3f23b00 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> bafdb96 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> 2bc58ac 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  1b64eea 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> 4a216fe 
>   
> security-admin/src/main/java/org/apache/ranger/patch/PatchForKafkaServiceDefUpdate_J10025.java
>  PRE-CREATION 
>   src/main/assembly/plugin-kafka.xml 97ff8ad 
> 
> 
> Diff: https://reviews.apache.org/r/68855/diff/4/
> 
> 
> Testing
> ---
> 
> - This patch addresses "Cluster" and "DelegationToken" as resource in Ranger 
> plugin.
> - Tested in local vm and added unit test for TopicCreation.
> - Upgrade patch tested for default policy creation for cluster and delegation 
> token as resource.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

[jira] [Resolved] (RANGER-2241) Fix release build scripts to conform to latest Apache release guidelines - Part 2 - Remove sha1 and mds

2018-10-05 Thread Velmurugan Periasamy (JIRA) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Velmurugan Periasamy resolved RANGER-2241.
--
Resolution: Fixed

master - 
[https://git-wip-us.apache.org/repos/asf?p=ranger.git;a=commit;h=e2fa2e2f70ca9bcef33466dc82d4a40b6d13e4fe]

ranger-1 - 
[https://git-wip-us.apache.org/repos/asf?p=ranger.git;a=commit;h=028de96b8f011d5c967ecc709a7d7f4d023cea7b]

ranger-1.2 - 
[https://git-wip-us.apache.org/repos/asf?p=ranger.git;a=commit;h=19f33f2353a796193fba61239294ad3f7269a7da]

ranger-1.1 - 
[https://git-wip-us.apache.org/repos/asf?p=ranger.git;a=commit;h=8544b5792d13f22e9ff03e796bafc50fe877e2bd]

ranger-1.0 - 
[https://git-wip-us.apache.org/repos/asf?p=ranger.git;a=commit;h=012cf993604c6f3fa452934432117c72c1a33424]
 

 

> Fix release build scripts to conform to latest Apache release guidelines - 
> Part 2 - Remove sha1 and mds
> ---
>
> Key: RANGER-2241
> URL: https://issues.apache.org/jira/browse/RANGER-2241
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Colm O hEigeartaigh
>Assignee: Velmurugan Periasamy
>Priority: Major
> Fix For: 1.0.1, 2.0.0, 1.1.1, 1.2.1
>
>
> Fix the release build scripts to conform to the Apache release guidelines 
> surrounding hashes:
> [http://www.apache.org/dev/release-distribution#sigs-and-sums]
> <<<
> For every artifact distributed to the public through Apache channels, the PMC
>  * MUST supply a 
> [valid|http://www.apache.org/dev/release-signing#verifying-signature] 
> [OpenPGP-compatible ASCII-armored detached 
> signature|http://www.apache.org/dev/release-signing#openpgp-ascii-detach-sig] 
> file
>  * MUST supply at least one checksum file
>  * SHOULD supply a [SHA-256 and/or 
> SHA-512|http://www.apache.org/dev/release-signing#sha-checksum] checksum file
>  * SHOULD NOT supply a MD5 or SHA-1 checksum file (because these are 
> deprecated)
>  >>>



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (RANGER-2209) Service Definition for ABFS to support Ranger Authorization

2018-10-05 Thread Yuan Gao (JIRA) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yuan Gao updated RANGER-2209:
-
Fix Version/s: master

> Service Definition for ABFS to support Ranger Authorization
> ---
>
> Key: RANGER-2209
> URL: https://issues.apache.org/jira/browse/RANGER-2209
> Project: Ranger
>  Issue Type: New Feature
>  Components: Ranger
>Affects Versions: 0.7.0, master
>Reporter: Yuan Gao
>Priority: Major
> Fix For: 0.7.0, master
>
> Attachments: RANGER-2209-001.patch
>
>
> This is to add Service Definition for Azure Blob File System (ABFS) in Ranger 
> Authorization. This will give an option to add ABFS as a Service in the 
> Ranger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (RANGER-2209) Service Definition for ABFS to support Ranger Authorization

2018-10-05 Thread Yuan Gao (JIRA) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yuan Gao updated RANGER-2209:
-
Affects Version/s: master

> Service Definition for ABFS to support Ranger Authorization
> ---
>
> Key: RANGER-2209
> URL: https://issues.apache.org/jira/browse/RANGER-2209
> Project: Ranger
>  Issue Type: New Feature
>  Components: Ranger
>Affects Versions: 0.7.0, master
>Reporter: Yuan Gao
>Priority: Major
> Fix For: 0.7.0
>
> Attachments: RANGER-2209-001.patch
>
>
> This is to add Service Definition for Azure Blob File System (ABFS) in Ranger 
> Authorization. This will give an option to add ABFS as a Service in the 
> Ranger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68925: RANGER-2241: Fix release build scripts to conform to latest Apache release guidelines - Part 2 - Remove sha1 and mds

2018-10-05 Thread Sailaja Polavarapu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68925/#review209273
---


Ship it!




Ship It!

- Sailaja Polavarapu


On Oct. 4, 2018, 7:23 p.m., Velmurugan Periasamy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68925/
> ---
> 
> (Updated Oct. 4, 2018, 7:23 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2241
> https://issues.apache.org/jira/browse/RANGER-2241
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Sha1 is depracated, so should not be included in build artifacts
> 
> 
> Diffs
> -
> 
>   release-build.xml 752a57e 
> 
> 
> Diff: https://reviews.apache.org/r/68925/diff/1/
> 
> 
> Testing
> ---
> 
> Verified that release build does not include this file
> 
> 
> Thanks,
> 
> Velmurugan Periasamy
> 
>

Re: Review Request 68855: RANGER-2222: Apache RangerKafkaPlugin support to handle Kafka Cluster as a new resource

2018-10-05 Thread Ramesh Mani 


> On Sept. 28, 2018, 10:27 p.m., Abhay Kulkarni wrote:
> > agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json
> > Lines 41 (patched)
> > 
> >
> > Need to review the resource hierarchy for Kafka resources. Can cluster 
> > be modeled as parent of topic, with a subset of accesses allowed for it?

There is no hierarchy with it the resources of Kafka cluster.


- Ramesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68855/#review209109
---


On Oct. 5, 2018, 3:43 p.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68855/
> ---
> 
> (Updated Oct. 5, 2018, 3:43 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-
> https://issues.apache.org/jira/browse/RANGER-
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-: Apache RangerKafkaPlugin support to handle Kafka Cluster as a 
> new resource
> 
> 
> Diffs
> -
> 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json 
> ca3e0fe 
>   
> plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuditHandler.java
>  PRE-CREATION 
>   
> plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java
>  eab869a 
>   
> plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerGSSTest.java
>  c1386fe 
>   
> plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerTopicCreationTest.java
>  PRE-CREATION 
>   plugin-kafka/src/test/resources/kafka-policies.json 0c07604 
>   plugin-kafka/src/test/resources/kafka_kerberos.jaas 1de804b 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 3f23b00 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> bafdb96 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> 2bc58ac 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  1b64eea 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> 4a216fe 
>   
> security-admin/src/main/java/org/apache/ranger/patch/PatchForKafkaServiceDefUpdate_J10025.java
>  PRE-CREATION 
>   src/main/assembly/plugin-kafka.xml 97ff8ad 
> 
> 
> Diff: https://reviews.apache.org/r/68855/diff/4/
> 
> 
> Testing
> ---
> 
> - This patch addresses "Cluster" and "DelegationToken" as resource in Ranger 
> plugin.
> - Tested in local vm and added unit test for TopicCreation.
> - Upgrade patch tested for default policy creation for cluster and delegation 
> token as resource.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 68855: RANGER-2222: Apache RangerKafkaPlugin support to handle Kafka Cluster as a new resource

2018-10-05 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68855/
---

(Updated Oct. 5, 2018, 3:43 p.m.)


Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan 
Periasamy.


Changes
---

Fixed review comments


Bugs: RANGER-
https://issues.apache.org/jira/browse/RANGER-


Repository: ranger


Description
---

RANGER-: Apache RangerKafkaPlugin support to handle Kafka Cluster as a new 
resource


Diffs (updated)
-

  agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json 
ca3e0fe 
  
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuditHandler.java
 PRE-CREATION 
  
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java
 eab869a 
  
plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerGSSTest.java
 c1386fe 
  
plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerTopicCreationTest.java
 PRE-CREATION 
  plugin-kafka/src/test/resources/kafka-policies.json 0c07604 
  plugin-kafka/src/test/resources/kafka_kerberos.jaas 1de804b 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 3f23b00 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql bafdb96 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
2bc58ac 
  
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 
1b64eea 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
4a216fe 
  
security-admin/src/main/java/org/apache/ranger/patch/PatchForKafkaServiceDefUpdate_J10025.java
 PRE-CREATION 
  src/main/assembly/plugin-kafka.xml 97ff8ad 


Diff: https://reviews.apache.org/r/68855/diff/4/

Changes: https://reviews.apache.org/r/68855/diff/3-4/


Testing
---

- This patch addresses "Cluster" and "DelegationToken" as resource in Ranger 
plugin.
- Tested in local vm and added unit test for TopicCreation.
- Upgrade patch tested for default policy creation for cluster and delegation 
token as resource.


Thanks,

Ramesh Mani

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-10-05 Thread Nitin Galave 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review209260
---


Ship it!




Ship It!

- Nitin Galave


On Oct. 4, 2018, 7:50 p.m., Csaba Koncz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Oct. 4, 2018, 7:50 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modified so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   pom.xml d8e3a5da9 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/minify.build.js PRE-CREATION 
>   security-admin/src/main/webapp/package-lock.json PRE-CREATION 
>   security-admin/src/main/webapp/package.json PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/4/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>

[jira] [Updated] (RANGER-2242) JiSQL utility is failing Oracle UDF

2018-10-05 Thread Pradeep Agrawal (JIRA) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Agrawal updated RANGER-2242:

Attachment: 0001-RANGER-2242-JiSQL-utility-is-failing-Oracle-UDF.patch

> JiSQL utility is failing Oracle UDF
> ---
>
> Key: RANGER-2242
> URL: https://issues.apache.org/jira/browse/RANGER-2242
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 1.0.0, 1.1.0, 2.0.0, 1.2.0
>Reporter: Pradeep Agrawal
>Assignee: Pradeep Agrawal
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 
> 0001-RANGER-2242-JiSQL-utility-is-failing-Oracle-UDF.patch
>
>
> JiSQL utility is failing if SQL patch contains Oracle UDF or stored procedure.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (RANGER-2242) JiSQL utility is failing Oracle UDF

2018-10-05 Thread Pradeep Agrawal (JIRA) 
Pradeep Agrawal created RANGER-2242:
---

 Summary: JiSQL utility is failing Oracle UDF
 Key: RANGER-2242
 URL: https://issues.apache.org/jira/browse/RANGER-2242
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Affects Versions: 1.2.0, 1.1.0, 1.0.0, 2.0.0
Reporter: Pradeep Agrawal
Assignee: Pradeep Agrawal
 Fix For: 2.0.0


JiSQL utility is failing if SQL patch contains Oracle UDF or stored procedure.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68908: Perform graceful terminate with retries before doing forceful kill for usersync and tagsync

2018-10-05 Thread bhavik patel 


> On Oct. 5, 2018, 2:34 a.m., Velmurugan Periasamy wrote:
> > tagsync/scripts/ranger-tagsync-services.sh
> > Lines 124 (patched)
> > 
> >
> > Can you please make sure this is merged in ranger-1 line branches?

Yes Vel, patch is applying on ranger-1 line branches.


- bhavik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68908/#review209244
---


On Oct. 3, 2018, 6:43 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68908/
> ---
> 
> (Updated Oct. 3, 2018, 6:43 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2229
> https://issues.apache.org/jira/browse/RANGER-2229
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> In ranger usersync and tagsync scripts, stop of the process is done 
> forcefully using kill -9.
> Suggestion is to do a graceful shutdown with retries and do a force kill only 
> if graceful shutdown is not successful.
> 
> Stop section from ranger-tagsync-services.sh and ranger-tusersync-services.sh
> 
> 
> Diffs
> -
> 
>   tagsync/scripts/ranger-tagsync-services.sh 5686390 
>   unixauthservice/scripts/ranger-usersync-services.sh 028ad08 
> 
> 
> Diff: https://reviews.apache.org/r/68908/diff/1/
> 
> 
> Testing
> ---
> 
> Tested ranger usersync & ranger tagsync are getting shutdown gracefully, also 
> verified if graceful shutdown is not successful(after 15 retries) than it 
> used kill -9 to stopped the proccess forcefully.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Request for adding me as contributor

2018-10-05 Thread Madhan Neethiraj 
Akash,

Thanks for your interest in contributing to Apache Ranger. You have been added 
as a contributor. Welcome to Apache Ranger community. 

Regards,
Madhan



On 10/4/18, 11:06 PM, "Akash Pawale"  wrote:

Hi,
My username in https://issues.apache.org is
akashp16

Thanks,
Akash Pawale.


On Thu, Oct 4, 2018 at 10:48 PM Madhan Neethiraj  wrote:

> Akash,
>
> Thanks for your interest in contributing to Apache Ranger. Can you please
> let me know your username in https://issues.apache.org?
>
> Thanks,
> Madhan
>
>
>
>
> On 10/3/18, 10:45 PM, "Akash Pawale"  wrote:
>
> Hi All,
>
> I would like to contribute to Apache Ranger project, Can
> you please add me as a contributor to the project?
>
> Thanks,
> Akash Pawale.
>
>
>
>

Re: Request for adding me as contributor

2018-10-05 Thread Akash Pawale 
Hi,
My username in https://issues.apache.org is
akashp16

Thanks,
Akash Pawale.


On Thu, Oct 4, 2018 at 10:48 PM Madhan Neethiraj  wrote:

> Akash,
>
> Thanks for your interest in contributing to Apache Ranger. Can you please
> let me know your username in https://issues.apache.org?
>
> Thanks,
> Madhan
>
>
>
>
> On 10/3/18, 10:45 PM, "Akash Pawale"  wrote:
>
> Hi All,
>
> I would like to contribute to Apache Ranger project, Can
> you please add me as a contributor to the project?
>
> Thanks,
> Akash Pawale.
>
>
>
>