Re: Review Request 70981: RANGER-2494:Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent

[Ramesh Mani]

> On July 1, 2019, 2:19 a.m., Ramesh Mani wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsNotPresentConditionEvaluator.java
> > Lines 72 (patched)
> > 
> >
> > when resourceTags will be null here.
> > 
> > Set resourceTags= context.getAllTagTypes()  going to give 
> > either null or set of resource tags.
> > So in that case when null we don't allow.
> > I shall check for empty also here so it wont be confusing.
> 
> Don Bosco Durai wrote:
> Ideally, it should be consistent. I not sure when we would get null. If 
> it is error condition, then not allowing is fine. But if it could be null 
> because there are no tags, then we should allow, because the condition says 
> "Tags not present", so empty tag list means the tags are not present.

I have updated the patch now. If resource-tags  are not null or empty, then 
only check for the corresponding matches is done, else matcher will return 
"true". I have updated the conditions in both the scenarios. Thanks.


- Ramesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70981/#review216256
---


On July 1, 2019, 6:37 a.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70981/
> ---
> 
> (Updated July 1, 2019, 6:37 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2494
> https://issues.apache.org/jira/browse/RANGER-2494
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-2494:Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsAnyPresentConditionEvaluator.java
>  PRE-CREATION 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsNotPresentConditionEvaluator.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70981/diff/2/
> 
> 
> Testing
> ---
> 
> Testing done in LOCAL VM
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 70981: RANGER-2494:Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent

[Ramesh Mani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70981/
---

(Updated July 1, 2019, 6:37 a.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
and Velmurugan Periasamy.


Changes
---

Addressed review comments


Bugs: RANGER-2494
https://issues.apache.org/jira/browse/RANGER-2494


Repository: ranger


Description
---

RANGER-2494:Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsAnyPresentConditionEvaluator.java
 PRE-CREATION 
  
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsNotPresentConditionEvaluator.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/70981/diff/2/

Changes: https://reviews.apache.org/r/70981/diff/1-2/


Testing
---

Testing done in LOCAL VM


Thanks,

Ramesh Mani

Re: Review Request 70981: RANGER-2494:Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent

[Don Bosco Durai]

> On July 1, 2019, 2:19 a.m., Ramesh Mani wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsNotPresentConditionEvaluator.java
> > Lines 72 (patched)
> > 
> >
> > when resourceTags will be null here.
> > 
> > Set resourceTags= context.getAllTagTypes()  going to give 
> > either null or set of resource tags.
> > So in that case when null we don't allow.
> > I shall check for empty also here so it wont be confusing.

Ideally, it should be consistent. I not sure when we would get null. If it is 
error condition, then not allowing is fine. But if it could be null because 
there are no tags, then we should allow, because the condition says "Tags not 
present", so empty tag list means the tags are not present.


- Don Bosco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70981/#review216256
---


On July 1, 2019, 1:03 a.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70981/
> ---
> 
> (Updated July 1, 2019, 1:03 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2494
> https://issues.apache.org/jira/browse/RANGER-2494
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-2494:Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsAnyPresentConditionEvaluator.java
>  PRE-CREATION 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsNotPresentConditionEvaluator.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70981/diff/1/
> 
> 
> Testing
> ---
> 
> Testing done in LOCAL VM
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 70981: RANGER-2494:Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent

[Ramesh Mani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70981/#review216256
---




agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsNotPresentConditionEvaluator.java
Lines 72 (patched)


when resourceTags will be null here.

Set resourceTags= context.getAllTagTypes()  going to give 
either null or set of resource tags.
So in that case when null we don't allow.
I shall check for empty also here so it wont be confusing.


- Ramesh Mani


On July 1, 2019, 1:03 a.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70981/
> ---
> 
> (Updated July 1, 2019, 1:03 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2494
> https://issues.apache.org/jira/browse/RANGER-2494
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-2494:Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsAnyPresentConditionEvaluator.java
>  PRE-CREATION 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsNotPresentConditionEvaluator.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70981/diff/1/
> 
> 
> Testing
> ---
> 
> Testing done in LOCAL VM
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

[jira] [Commented] (RANGER-2494) Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent

[Don Bosco Durai (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875901#comment-16875901
 ] 

Don Bosco Durai commented on RANGER-2494:
-

[~rmani] thanks for the clarification. These are good enhancements. Thanks

> Ranger Custom PolicyCondition for TagsNotPresent and  AnyTagPresent
> ---
>
> Key: RANGER-2494
> URL: https://issues.apache.org/jira/browse/RANGER-2494
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: master, 2.0.0
>Reporter: Ramesh Mani
>Assignee: Ramesh Mani
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 
> 0001-RANGER-2494-Ranger-Custom-PolicyCondition-for-TagNot.patch
>
>
> Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent.
> - Two new Custom Policy Conditions are to be created.
> 1) RangerTagsAnyPresentConditionEvaluator - This condition evaluates to 
> "true" when  "Any of the Policy condition Tag" defined is present  in the 
> tags associated to the Resource.
> 2) RangerTagsNotPresentConditionEvaluator - This condition evaluates to 
> "true" when "None of the Policy condition Tag" defined is present in the tags 
> associated to the resource.
> These new custom policy conditions are in addition to the one created in 
> https://issues.apache.org/jira/browse/RANGER-2465



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 70981: RANGER-2494:Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent

[Don Bosco Durai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70981/#review216255
---




agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsNotPresentConditionEvaluator.java
Lines 72 (patched)


Seems confusing. What if resourceTags is null? Do we allow or not? 
According to this, if it is null we don't allow, but if empty we will allow. I 
might be wrong.


- Don Bosco Durai


On July 1, 2019, 1:03 a.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70981/
> ---
> 
> (Updated July 1, 2019, 1:03 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2494
> https://issues.apache.org/jira/browse/RANGER-2494
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-2494:Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsAnyPresentConditionEvaluator.java
>  PRE-CREATION 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsNotPresentConditionEvaluator.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70981/diff/1/
> 
> 
> Testing
> ---
> 
> Testing done in LOCAL VM
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Review Request 70981: RANGER-2494:Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent

[Ramesh Mani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70981/
---

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
and Velmurugan Periasamy.


Bugs: RANGER-2494
https://issues.apache.org/jira/browse/RANGER-2494


Repository: ranger


Description
---

RANGER-2494:Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsAnyPresentConditionEvaluator.java
 PRE-CREATION 
  
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsNotPresentConditionEvaluator.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/70981/diff/1/


Testing
---

Testing done in LOCAL VM


Thanks,

Ramesh Mani

[jira] [Commented] (RANGER-2494) Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent

[Ramesh Mani (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875898#comment-16875898
 ] 

Ramesh Mani commented on RANGER-2494:
-

[~bosco], I have added more descriptions to the JIRA. Thanks.

> Ranger Custom PolicyCondition for TagsNotPresent and  AnyTagPresent
> ---
>
> Key: RANGER-2494
> URL: https://issues.apache.org/jira/browse/RANGER-2494
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: master, 2.0.0
>Reporter: Ramesh Mani
>Assignee: Ramesh Mani
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 
> 0001-RANGER-2494-Ranger-Custom-PolicyCondition-for-TagNot.patch
>
>
> Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent.
> - Two new Custom Policy Conditions are to be created.
> 1) RangerTagsAnyPresentConditionEvaluator - This condition evaluates to 
> "true" when  "Any of the Policy condition Tag" defined is present  in the 
> tags associated to the Resource.
> 2) RangerTagsNotPresentConditionEvaluator - This condition evaluates to 
> "true" when "None of the Policy condition Tag" defined is present in the tags 
> associated to the resource.
> These new custom policy conditions are in addition to the one created in 
> https://issues.apache.org/jira/browse/RANGER-2465



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (RANGER-2494) Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent

[Ramesh Mani (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Mani updated RANGER-2494:

Description: 
Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent.
- Two new Custom Policy Conditions are to be created.
1) RangerTagsAnyPresentConditionEvaluator - This condition evaluates to "true" 
when  "Any of the Policy condition Tag" defined is present  in the tags 
associated to the Resource.
2) RangerTagsNotPresentConditionEvaluator - This condition evaluates to "true" 
when "None of the Policy condition Tag" defined is present in the tags 
associated to the resource.

These new custom policy conditions are in addition to the one created in 
https://issues.apache.org/jira/browse/RANGER-2465


  was:Ranger Custom PolicyCondition for TagNotPresent and  AnyTagPresent


> Ranger Custom PolicyCondition for TagsNotPresent and  AnyTagPresent
> ---
>
> Key: RANGER-2494
> URL: https://issues.apache.org/jira/browse/RANGER-2494
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: master, 2.0.0
>Reporter: Ramesh Mani
>Assignee: Ramesh Mani
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 
> 0001-RANGER-2494-Ranger-Custom-PolicyCondition-for-TagNot.patch
>
>
> Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent.
> - Two new Custom Policy Conditions are to be created.
> 1) RangerTagsAnyPresentConditionEvaluator - This condition evaluates to 
> "true" when  "Any of the Policy condition Tag" defined is present  in the 
> tags associated to the Resource.
> 2) RangerTagsNotPresentConditionEvaluator - This condition evaluates to 
> "true" when "None of the Policy condition Tag" defined is present in the tags 
> associated to the resource.
> These new custom policy conditions are in addition to the one created in 
> https://issues.apache.org/jira/browse/RANGER-2465



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (RANGER-2494) Ranger Custom PolicyCondition for TagsNotPresent and AnyTagPresent

[Ramesh Mani (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Mani updated RANGER-2494:

Summary: Ranger Custom PolicyCondition for TagsNotPresent and  
AnyTagPresent  (was: Ranger Custom PolicyCondition for TagNotPresent and  
AnyTagPresent)

> Ranger Custom PolicyCondition for TagsNotPresent and  AnyTagPresent
> ---
>
> Key: RANGER-2494
> URL: https://issues.apache.org/jira/browse/RANGER-2494
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: master, 2.0.0
>Reporter: Ramesh Mani
>Assignee: Ramesh Mani
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 
> 0001-RANGER-2494-Ranger-Custom-PolicyCondition-for-TagNot.patch
>
>
> Ranger Custom PolicyCondition for TagNotPresent and  AnyTagPresent



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RANGER-2494) Ranger Custom PolicyCondition for TagNotPresent and AnyTagPresent

[Don Bosco Durai (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875897#comment-16875897
 ] 

Don Bosco Durai commented on RANGER-2494:
-

[~rmani] can you give additional information on this JIRA?

Thanks

> Ranger Custom PolicyCondition for TagNotPresent and  AnyTagPresent
> --
>
> Key: RANGER-2494
> URL: https://issues.apache.org/jira/browse/RANGER-2494
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: master, 2.0.0
>Reporter: Ramesh Mani
>Assignee: Ramesh Mani
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 
> 0001-RANGER-2494-Ranger-Custom-PolicyCondition-for-TagNot.patch
>
>
> Ranger Custom PolicyCondition for TagNotPresent and  AnyTagPresent



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (RANGER-2494) Ranger Custom PolicyCondition for TagNotPresent and AnyTagPresent

[Ramesh Mani (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Mani reassigned RANGER-2494:
---

Assignee: Ramesh Mani

> Ranger Custom PolicyCondition for TagNotPresent and  AnyTagPresent
> --
>
> Key: RANGER-2494
> URL: https://issues.apache.org/jira/browse/RANGER-2494
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: master, 2.0.0
>Reporter: Ramesh Mani
>Assignee: Ramesh Mani
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 
> 0001-RANGER-2494-Ranger-Custom-PolicyCondition-for-TagNot.patch
>
>
> Ranger Custom PolicyCondition for TagNotPresent and  AnyTagPresent



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (RANGER-2494) Ranger Custom PolicyCondition for TagNotPresent and AnyTagPresent

[Ramesh Mani (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Mani updated RANGER-2494:

Attachment: 0001-RANGER-2494-Ranger-Custom-PolicyCondition-for-TagNot.patch

> Ranger Custom PolicyCondition for TagNotPresent and  AnyTagPresent
> --
>
> Key: RANGER-2494
> URL: https://issues.apache.org/jira/browse/RANGER-2494
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: master, 2.0.0
>Reporter: Ramesh Mani
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 
> 0001-RANGER-2494-Ranger-Custom-PolicyCondition-for-TagNot.patch
>
>
> Ranger Custom PolicyCondition for TagNotPresent and  AnyTagPresent



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (RANGER-2494) Ranger Custom PolicyCondition for TagNotPresent and AnyTagPresent

[Ramesh Mani (JIRA)]

Ramesh Mani created RANGER-2494:
---

 Summary: Ranger Custom PolicyCondition for TagNotPresent and  
AnyTagPresent
 Key: RANGER-2494
 URL: https://issues.apache.org/jira/browse/RANGER-2494
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Affects Versions: master, 2.0.0
Reporter: Ramesh Mani
 Fix For: 2.0.0


Ranger Custom PolicyCondition for TagNotPresent and  AnyTagPresent



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 70973: RANGER-2480:Hive URL Policy doesn't match if recursive flag is on for the url resource

[Ramesh Mani]

> On June 29, 2019, 12:05 a.m., Abhay Kulkarni wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcher.java
> > Lines 201 (patched)
> > 
> >
> > Please ensure that the pathToCheck starts with string in 'ret'. If it 
> > does then return substring following 'ret' string. In that case getPath() 
> > function is not needed.

we need to have this getPatch method, so the subsequently when we do split and 
build the elements for resurvice matching we will have "scheme://" added to 
that list. This I verified and work as expected.


- Ramesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70973/#review216237
---


On June 30, 2019, 10:09 p.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70973/
> ---
> 
> (Updated June 30, 2019, 10:09 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2480
> https://issues.apache.org/jira/browse/RANGER-2480
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-2480:Hive URL Policy doesn't match if recursive flag is on for the url 
> resource
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcher.java
>  PRE-CREATION 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-hive.json 
> 370ff56 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcherTest.java
>  PRE-CREATION 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 7aa9b3f 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> 100ee9e 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> eac6a75 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  b836ff1 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> cca959a 
>   
> security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10030.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70973/diff/2/
> 
> 
> Testing
> ---
> 
> - Verified in LOCAL VM for Patch file upgrade 
> - Verified URL policies for HIVE Request.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 70973: RANGER-2480:Hive URL Policy doesn't match if recursive flag is on for the url resource

[Ramesh Mani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70973/
---

(Updated June 30, 2019, 10:09 p.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
and Velmurugan Periasamy.


Changes
---

Fixed review comments


Bugs: RANGER-2480
https://issues.apache.org/jira/browse/RANGER-2480


Repository: ranger


Description
---

RANGER-2480:Hive URL Policy doesn't match if recursive flag is on for the url 
resource


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcher.java
 PRE-CREATION 
  agents-common/src/main/resources/service-defs/ranger-servicedef-hive.json 
370ff56 
  
agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcherTest.java
 PRE-CREATION 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 7aa9b3f 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 100ee9e 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
eac6a75 
  
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 
b836ff1 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
cca959a 
  
security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10030.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/70973/diff/2/

Changes: https://reviews.apache.org/r/70973/diff/1-2/


Testing
---

- Verified in LOCAL VM for Patch file upgrade 
- Verified URL policies for HIVE Request.


Thanks,

Ramesh Mani

[jira] [Comment Edited] (RANGER-2489) Missing dependencies in assembly for Presto plugin

[Bolke de Bruin (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875844#comment-16875844
 ] 

Bolke de Bruin edited comment on RANGER-2489 at 6/30/19 6:52 PM:
-

 [~mehul] please merge this minor patch, it will improve the user experience 
for the presto plugin.


was (Author: bolke):
 [~mehul] please merge this, it will improve the user experience for the presto 
plugin

> Missing dependencies in assembly for Presto plugin
> --
>
> Key: RANGER-2489
> URL: https://issues.apache.org/jira/browse/RANGER-2489
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Reporter: Bolke de Bruin
>Assignee: Bolke de Bruin
>Priority: Major
> Attachments: 0001-RANGER-2489-Minor-updates-to-presto-plugin.patch
>
>
> If invoking with hostnames rather than ips extra dependencies are required by 
> the plugin for Presto.
> commons-codec commons-codec
>  com.kstruct gethostname4j
>  com.sun jna



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RANGER-2489) Missing dependencies in assembly for Presto plugin

[Bolke de Bruin (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875844#comment-16875844
 ] 

Bolke de Bruin commented on RANGER-2489:


 [~mehul] please merge this, it will improve the user experience for the presto 
plugin

> Missing dependencies in assembly for Presto plugin
> --
>
> Key: RANGER-2489
> URL: https://issues.apache.org/jira/browse/RANGER-2489
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Reporter: Bolke de Bruin
>Assignee: Bolke de Bruin
>Priority: Major
> Attachments: 0001-RANGER-2489-Minor-updates-to-presto-plugin.patch
>
>
> If invoking with hostnames rather than ips extra dependencies are required by 
> the plugin for Presto.
> commons-codec commons-codec
>  com.kstruct gethostname4j
>  com.sun jna



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (RANGER-2489) Missing dependencies in assembly for Presto plugin

[Bolke de Bruin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bolke de Bruin updated RANGER-2489:
---
Attachment: 0001-RANGER-2489-Minor-updates-to-presto-plugin.patch

> Missing dependencies in assembly for Presto plugin
> --
>
> Key: RANGER-2489
> URL: https://issues.apache.org/jira/browse/RANGER-2489
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Reporter: Bolke de Bruin
>Assignee: Bolke de Bruin
>Priority: Major
> Attachments: 0001-RANGER-2489-Minor-updates-to-presto-plugin.patch
>
>
> If invoking with hostnames rather than ips extra dependencies are required by 
> the plugin for Presto.
> commons-codec commons-codec
>  com.kstruct gethostname4j
>  com.sun jna



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (RANGER-2489) Missing dependencies in assembly for Presto plugin

[Bolke de Bruin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bolke de Bruin updated RANGER-2489:
---
Description: 
If invoking with hostnames rather than ips extra dependencies are required by 
the plugin for Presto.

commons-codec commons-codec
 com.kstruct gethostname4j
 com.sun jna

  was:
If invoking with hostnames rather than ips extra dependencies are required by 
the plugin for Presto.

commons-codec commons-codec-1.12
com.kstruct gethostname4j-0.0.3
com.sun jna-3.0.9.jar


> Missing dependencies in assembly for Presto plugin
> --
>
> Key: RANGER-2489
> URL: https://issues.apache.org/jira/browse/RANGER-2489
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Reporter: Bolke de Bruin
>Assignee: Bolke de Bruin
>Priority: Major
>
> If invoking with hostnames rather than ips extra dependencies are required by 
> the plugin for Presto.
> commons-codec commons-codec
>  com.kstruct gethostname4j
>  com.sun jna



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)