Re: Review Request 74486: RANGER-4296: [Ranger UI] [React JS] Dropdown option in the access audits must display "User" instead of "Users"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74486/#review225561 --- Ship it! Ship It! - Brijesh Bhalala On June 22, 2023, 6:06 a.m., Abhishek Patil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74486/ > --- > > (Updated June 22, 2023, 6:06 a.m.) > > > Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Mehul Parikh, and > Mugdha Varadkar. > > > Bugs: RANGER-4296 > https://issues.apache.org/jira/browse/RANGER-4296 > > > Repository: ranger > > > Description > --- > > In the options to filter the access audits in the react JS UI, the option to > filter by username must be displayed as "User" instead of "Users". > Even in the old UI's, the option is displayed as "User" > > > Diffs > - > > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx > bd8011fd5 > > > Diff: https://reviews.apache.org/r/74486/diff/1/ > > > Testing > --- > > Tested locally > > > Thanks, > > Abhishek Patil > >
[jira] [Updated] (RANGER-4296) [Ranger UI] [React JS] Dropdown option in the access audits must display "User" instead of "Users"
[
https://issues.apache.org/jira/browse/RANGER-4296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhishek updated RANGER-4296:
-
Attachment: 0001-RANGER-4296-Ranger-UI-React-JS-Dropdown-option-in-th.patch
> [Ranger UI] [React JS] Dropdown option in the access audits must display
> "User" instead of "Users"
> --
>
> Key: RANGER-4296
> URL: https://issues.apache.org/jira/browse/RANGER-4296
> Project: Ranger
> Issue Type: Bug
> Components: Ranger
>Reporter: Abhishek
>Assignee: Abhishek
>Priority: Major
> Attachments:
> 0001-RANGER-4296-Ranger-UI-React-JS-Dropdown-option-in-th.patch
>
>
> {color:#172b4d}In the options to filter the access audits in the react JS UI,
> the option to filter by username must be displayed as "User" instead of
> "Users".{color}
> {color:#172b4d}Even in the old UI's, the option is displayed as "User"{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RANGER-4296) [Ranger UI] [React JS] Dropdown option in the access audits must display "User" instead of "Users"
[
https://issues.apache.org/jira/browse/RANGER-4296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735985#comment-17735985
]
Abhishek commented on RANGER-4296:
--
Review request for patch :- https://reviews.apache.org/r/74486/
> [Ranger UI] [React JS] Dropdown option in the access audits must display
> "User" instead of "Users"
> --
>
> Key: RANGER-4296
> URL: https://issues.apache.org/jira/browse/RANGER-4296
> Project: Ranger
> Issue Type: Bug
> Components: Ranger
>Reporter: Abhishek
>Assignee: Abhishek
>Priority: Major
>
> {color:#172b4d}In the options to filter the access audits in the react JS UI,
> the option to filter by username must be displayed as "User" instead of
> "Users".{color}
> {color:#172b4d}Even in the old UI's, the option is displayed as "User"{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Review Request 74486: RANGER-4296: [Ranger UI] [React JS] Dropdown option in the access audits must display "User" instead of "Users"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74486/ --- Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Mehul Parikh, and Mugdha Varadkar. Bugs: RANGER-4296 https://issues.apache.org/jira/browse/RANGER-4296 Repository: ranger Description --- In the options to filter the access audits in the react JS UI, the option to filter by username must be displayed as "User" instead of "Users". Even in the old UI's, the option is displayed as "User" Diffs - security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx bd8011fd5 Diff: https://reviews.apache.org/r/74486/diff/1/ Testing --- Tested locally Thanks, Abhishek Patil
[jira] [Updated] (RANGER-4295) [Ranger UI] [React JS] Option might require to clear all filter at once for resouce policy side bars
[ https://issues.apache.org/jira/browse/RANGER-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brijesh Bhalala updated RANGER-4295: Summary: [Ranger UI] [React JS] Option might require to clear all filter at once for resouce policy side bars (was: Option might require to clear all filter at once for resouce policy side bars) > [Ranger UI] [React JS] Option might require to clear all filter at once for > resouce policy side bars > > > Key: RANGER-4295 > URL: https://issues.apache.org/jira/browse/RANGER-4295 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Anupam Rai >Assignee: Brijesh Bhalala >Priority: Major > Labels: ranger-react > Attachments: Screenshot 2023-06-19 at 5.36.39 PM.png > > > Option might require to clear all filter at once for resouce policy side bars > Expected : Simillar option like in policy filter (Which woul refresh > services and clear filter as well ) > Attached screenshot -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (RANGER-4295) Option might require to clear all filter at once for resouce policy side bars
[ https://issues.apache.org/jira/browse/RANGER-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brijesh Bhalala reassigned RANGER-4295: --- Assignee: Brijesh Bhalala > Option might require to clear all filter at once for resouce policy side bars > - > > Key: RANGER-4295 > URL: https://issues.apache.org/jira/browse/RANGER-4295 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Anupam Rai >Assignee: Brijesh Bhalala >Priority: Major > Labels: ranger-react > Attachments: Screenshot 2023-06-19 at 5.36.39 PM.png > > > Option might require to clear all filter at once for resouce policy side bars > Expected : Simillar option like in policy filter (Which woul refresh > services and clear filter as well ) > Attached screenshot -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Review Request 74472: RANGER-2895: Replace c3p0 connection pool with HikariCP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74472/#review225560 --- Ship it! Ship It! - Velmurugan Periasamy On June 12, 2023, 6:23 a.m., Pradeep Agrawal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74472/ > --- > > (Updated June 12, 2023, 6:23 a.m.) > > > Review request for ranger, bhavik patel, Abhay Kulkarni, Madhan Neethiraj, > Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2895 > https://issues.apache.org/jira/browse/RANGER-2895 > > > Repository: ranger > > > Description > --- > > This change is taken from PR : https://reviews.apache.org/r/72645/ and have > additional changes due to below details: > > 1) We should replace c3p0 with > [HikariCP|https://github.com/brettwooldridge/HikariCP]. HikariCP is much > faster and less error prone. HikariCP is more popular with 13.2k+ stars on > its github. There were no more new commits since Nov 18, 2019 in > [c3p0|https://github.com/swaldman/c3p0/commits/master]. > > > 2) [MySQL connector|https://github.com/mysql/mysql-connector-j] should be > upgraded to the latest stable versions as well to include many essential > bugfixes. > > 3) Removed audit to DB connection configs and code which is not supported now > > > Diffs > - > > pom.xml 3d4a755a2 > security-admin/pom.xml 25aaa0e58 > security-admin/scripts/ranger-admin-site-template.xml 037260f50 > security-admin/scripts/upgrade_admin.py 85f57b8ce > security-admin/src/main/java/org/apache/ranger/db/RangerDaoManager.java > 44375e5ac > security-admin/src/main/java/org/apache/ranger/db/XXAccessAuditDao.java > d6de8423c > security-admin/src/main/resources/META-INF/persistence.xml 20f08d22a > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 68d8a0303 > security-admin/src/main/webapp/META-INF/applicationContext.xml 0923d6007 > > > Diff: https://reviews.apache.org/r/74472/diff/2/ > > > Testing > --- > > Tested install and upgrade case for mysql, postgres, and oracle DB flavor. > > > Thanks, > > Pradeep Agrawal > >
[jira] [Updated] (RANGER-4025) Ranger improvement - Roles Import/export API for ranger admin
[ https://issues.apache.org/jira/browse/RANGER-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh Gupta updated RANGER-4025: - Attachment: 0011-RANGER-4025.patch > Ranger improvement - Roles Import/export API for ranger admin > - > > Key: RANGER-4025 > URL: https://issues.apache.org/jira/browse/RANGER-4025 > Project: Ranger > Issue Type: New Feature > Components: Ranger >Reporter: Dineshkumar Yadav >Assignee: Rakesh Gupta >Priority: Major > Attachments: 0011-RANGER-4025.patch > > > Provide API for Roles import/export. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4025) Ranger improvement - Roles Import/export API for ranger admin
[ https://issues.apache.org/jira/browse/RANGER-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh Gupta updated RANGER-4025: - Attachment: (was: 0010-RANGER-4025.patch) > Ranger improvement - Roles Import/export API for ranger admin > - > > Key: RANGER-4025 > URL: https://issues.apache.org/jira/browse/RANGER-4025 > Project: Ranger > Issue Type: New Feature > Components: Ranger >Reporter: Dineshkumar Yadav >Assignee: Rakesh Gupta >Priority: Major > Attachments: 0011-RANGER-4025.patch > > > Provide API for Roles import/export. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Review Request 74292: RANGER-4025: Ranger improvement - Roles Import/export API for ranger admin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74292/
---
(Updated June 21, 2023, 10:08 a.m.)
Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay
Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket
shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-4025
https://issues.apache.org/jira/browse/RANGER-4025
Repository: ranger
Description
---
Provide API for Roles import/export.
Diffs (updated)
-
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerRole.java
682bbd640
pom.xml 9a6667ad2
security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 12983688b
security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java
421b2312d
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
1f9801ba2
security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 7fb7d9c79
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
e91d3bc71
security-admin/src/main/java/org/apache/ranger/security/context/RangerPreAuthSecurityHandler.java
c823fba45
security-admin/src/main/java/org/apache/ranger/view/RangerExportRoleList.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/view/RangerPolicyList.java
4799b3f03
security-admin/src/main/java/org/apache/ranger/view/RangerRoleList.java
adbe93db6
security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java
217c1bba3
security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java
9d17553a4
security-admin/src/test/java/org/apache/ranger/rest/importRole/import_role_test_file.json
PRE-CREATION
Diff: https://reviews.apache.org/r/74292/diff/11/
Changes: https://reviews.apache.org/r/74292/diff/10-11/
Testing
---
Tested the below Rest API's for Roles import/export to make sure everything
works fine.
RoleREST Rest API :GET /roles/roles/exportJson
RoleREST Rest API :GET
/roles/roles/exportJson?roleName={rolename},{rolename},
RoleREST Rest API :GET /roles/roles/importRolesFromFile
RoleREST Rest API :GET /roles/roles/importRolesFromFile?updateIfExists=true
RoleREST Rest API :GET
/roles/roles/importRolesFromFile?createNonExistUserGroupRole=true
Thanks,
Rakesh Gupta
