Re: [PR] Update trino-plugin to be compatible with the latest Trino SPI (version 433) [ranger]

[via GitHub]

nghiabuilvb commented on PR #290:
URL: https://github.com/apache/ranger/pull/290#issuecomment-1884448532

   > @okayhooni can you share your maven build command for ranger and trino 
plugin? I tried to build your fork with JDK 17 but getting errors
   > 
   > `[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-war-plugin:2.6:exploded (prepare) on project 
security-admin-web: Execution prepare of goal 
org.apache.maven.plugins:maven-war-plugin:2.6:exploded failed: Unable to load 
the mojo 'exploded' in the plugin 
'org.apache.maven.plugins:maven-war-plugin:2.6' due to an API incompatibility: 
org.codehaus.plexus.component.repository.exception.ComponentLookupException: 
null`
   > 
   > I build by the following command:
   > 
   > `mvn -DskipTests=true clean compile package install`
   
   You should build only trino plugin, you can try to run this command:
   mvn clean package -DskipTests -P ranger-trino-plugin,-linux -am -pl 
distro,plugin-trino,ranger-trino-plugin-shim,agents-installer,credentialbuilder


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Review Request 74828: RANGER-4636, RANGER-4637: Fix /public/api/policy/count and /public/api/repository/count to return the proper value

[Abhishek Patil]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74828/
---

(Updated Jan. 10, 2024, 10:12 a.m.)


Review request for ranger, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, 
Pradeep Agrawal, and Ramesh Mani.


Bugs: RANGER-4636 and RANGER-4637
https://issues.apache.org/jira/browse/RANGER-4636
https://issues.apache.org/jira/browse/RANGER-4637


Repository: ranger


Description
---

If the number of policies / repositories is greater than 200, the 
/public/api/policy/count and the /public/api/repository/count APIs do not 
return the correct value.
This patch addresses the issue.


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java a6b86e965 
  security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 
180742bcd 
  security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIs.java 
eb0cb6452 
  security-admin/src/test/java/org/apache/ranger/rest/TestXAuditREST.java 
2864cd36c 


Diff: https://reviews.apache.org/r/74828/diff/2/

Changes: https://reviews.apache.org/r/74828/diff/1-2/


Testing
---

1. Applied the patch on a cluster, created more than 300 policies and 300 
services, and ensured that the proper values are returned for 
/public/api/policy/count and /public/api/repository/count APIs.
2. The associated unit tests have also been modified according to the code 
change, and the unit tests were run by triggering a maven build.
The unit tests passed


Thanks,

Abhishek Patil

[jira] [Created] (RANGER-4643) Upgrade react-bootstrap library for GDS UI.

[Dhaval Rajpara (Jira)]

Dhaval Rajpara created RANGER-4643:
--

 Summary: Upgrade react-bootstrap library for GDS UI.
 Key: RANGER-4643
 URL: https://issues.apache.org/jira/browse/RANGER-4643
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: Dhaval Rajpara
Assignee: Dhaval Rajpara






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74828: RANGER-4636, RANGER-4637: Fix /public/api/policy/count and /public/api/repository/count to return the proper value

[Ramachandran Krishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74828/#review226120
---


Ship it!




Ship It!

- Ramachandran Krishnan


On Jan. 10, 2024, 10:12 a.m., Abhishek Patil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74828/
> ---
> 
> (Updated Jan. 10, 2024, 10:12 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, 
> Pradeep Agrawal, and Ramesh Mani.
> 
> 
> Bugs: RANGER-4636 and RANGER-4637
> https://issues.apache.org/jira/browse/RANGER-4636
> https://issues.apache.org/jira/browse/RANGER-4637
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> If the number of policies / repositories is greater than 200, the 
> /public/api/policy/count and the /public/api/repository/count APIs do not 
> return the correct value.
> This patch addresses the issue.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java 
> a6b86e965 
>   security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 
> 180742bcd 
>   security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIs.java 
> eb0cb6452 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXAuditREST.java 
> 2864cd36c 
> 
> 
> Diff: https://reviews.apache.org/r/74828/diff/2/
> 
> 
> Testing
> ---
> 
> 1. Applied the patch on a cluster, created more than 300 policies and 300 
> services, and ensured that the proper values are returned for 
> /public/api/policy/count and /public/api/repository/count APIs.
> 2. The associated unit tests have also been modified according to the code 
> change, and the unit tests were run by triggering a maven build.
> The unit tests passed
> 
> 
> Thanks,
> 
> Abhishek Patil
> 
>

Re: Review Request 74806: RANGER-4628: Need to add Validations for Security-Zone partial update API

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74806/#review226121
---


Ship it!




Ship It!

- Madhan Neethiraj


On Dec. 28, 2023, 6:16 a.m., Prashant Satam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74806/
> ---
> 
> (Updated Dec. 28, 2023, 6:16 a.m.)
> 
> 
> Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan 
> Neethiraj, Monika Kachhadiya, Siddhesh Phatak, Subhrat Chaudhary, and Vanita 
> Ubale.
> 
> 
> Bugs: RANGER-4628
> https://issues.apache.org/jira/browse/RANGER-4628
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> For Partial Update of Security-Zone API ===> 
> /service/public/v2/api/zones-v2/{id}/partial
> 
> 1)We can add existing admins/auditors to the zone and still get 200 as 
> response
> 
> 2)We can add existing tagServices to the zone and still get 200 as response
> 
> 3)While removing the existing resources in zone if we pass invalid 
> serviceName we still get 200 as response though the zone is not getting 
> updated
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSecurityZoneHelper.java
>  72ec4a4c7 
> 
> 
> Diff: https://reviews.apache.org/r/74806/diff/1/
> 
> 
> Testing
> ---
> 
> steps to check :
> 1)We get validation when adding existing admins/auditors to the zone 
> 2)We get validation when adding existing tagServices to the zone 
> 3)We get validation when pass invalid serviceName for removing existing 
> resources from zone
> 
> 
> Thanks,
> 
> Prashant Satam
> 
>

Re: Review Request 74826: RANGER-4642: on security-zone delete/update, delete associated GDS objects

[Monika Kachhadiya via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74826/#review226122
---


Ship it!




Ship It!

- Monika Kachhadiya


On Jan. 9, 2024, 10:58 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74826/
> ---
> 
> (Updated Jan. 9, 2024, 10:58 p.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Mehul 
> Parikh, Monika Kachhadiya, Mugdha Varadkar, Ramesh Mani, Sailaja Polavarapu, 
> Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4642
> https://issues.apache.org/jira/browse/RANGER-4642
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - updated RangerSecurityZoneServiceService.preDelete() and postUpdate() to 
> remove associated GDS objects
> 
> 
> Diffs
> -
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/GdsStore.java 
> afbce78a1 
>   security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 
> 701165f9d 
>   security-admin/src/main/java/org/apache/ranger/db/XXGdsDataShareDao.java 
> 2845a1d04 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> e7e0abbc8 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java
>  940bd0bc6 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  74a3caa13 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml ae6788bac 
> 
> 
> Diff: https://reviews.apache.org/r/74826/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that deletion of a security-zone deletes all data-shares 
> associated with the security-zone
> - verified that removal of services from a security-zone deletes all 
> data-shares of the services in the security-zone
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74827: RANGER-4440: remove stale code that attempts to decompress x_security_zone.jsonData

[Monika Kachhadiya via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74827/#review226123
---


Ship it!




Ship It!

- Monika Kachhadiya


On Jan. 10, 2024, 12:16 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74827/
> ---
> 
> (Updated Jan. 10, 2024, 12:16 a.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Mehul 
> Parikh, Monika Kachhadiya, Mugdha Varadkar, Ramesh Mani, Sailaja Polavarapu, 
> Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4440
> https://issues.apache.org/jira/browse/RANGER-4440
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Updated SecurityZoneDBStore to leverage compressed JSON handling in 
> RangerSecurityZoneServiceService
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java 
> 8d22fb42b 
> 
> 
> Diff: https://reviews.apache.org/r/74827/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that security-zone update completes successfully with 
> configuration ranger.admin.store.security.zone.compress.json_data set to true 
> and false
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[jira] [Commented] (RANGER-4440) option to store compressed json text in x_security_zone.jsonData

[Madhan Neethiraj (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805254#comment-17805254
 ] 

Madhan Neethiraj commented on RANGER-4440:
--

{noformat}
commit 67d8c80aab5a47815f5c330c70cdb062808aa92c (HEAD -> master, origin/master, 
origin/HEAD)
Author: Madhan Neethiraj 
Date:   Tue Jan 9 16:00:39 2024 -0800

RANGER-4440: remove stale code that attempts to decompress 
x_security_zone.jsonData - #4
{noformat}

> option to store compressed json text in x_security_zone.jsonData
> 
>
> Key: RANGER-4440
> URL: https://issues.apache.org/jira/browse/RANGER-4440
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: RANGER-4440.patch
>
>
> Ranger stores security-zone in as a Json serialized string in column 
> x_security_zone.jsonData. Length of the json text for zones having large 
> number of resources (like 100k) can exceed the limit allowed by the database. 
> Having an option to compress the json text will help deal with such large 
> security zones.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74825: RANGER-4638:Multiple Columns Revoke not generating policies with correct number of columns

[Abhay Kulkarni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74825/#review226124
---




agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
Lines 394 (patched)


If there are many resource-evaluators, this will return false. Is that 
expected? Please review.



agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java
Lines 403 (patched)


Is the null check for the resourceValue needed here? In both cases, it is 
executing the same logic (lines 404 and 406. Please review.

Please consider if line 406 needs to be 

ret = matcher == null && matcher.isSomeMatch( resourceValue, evalContext);



agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java
Line 22 (original), 22 (patched)


Please consider importing packages one-by-one.



agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java
Lines 276 (patched)


Please review if this condition is correct. The first part of the condition 
may not be needed.

Can this condition be replaced with

ret = policyValues.containsAny(resValues);

?



security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminImpl.java
Lines 435 (patched)


This loop iterates over all resource policies. This may be expensive. Is 
there any way to limit the set of policies to search?

Please review.



security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java
Line 29 (original), 30 (patched)


Please consider importing package individually.



security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java
Lines 144 (patched)


Should this be 

(!CollectionUtils.isEmpty(rangerPolicyItems[POLICYITEM_TYPE.ALLOW_EXCEPTIONS.ordinal()].getAccesses()))
 {

Please review this and similar code in this function.



security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java
Lines 249 (patched)


RangerFactory.getResourceSignature() uses policy-resources and conditions 
to compute signature. It does not consider users/groups/roles. So, this 
function may return true when the policy matches signature but does not match 
users/groups/roles.

Please review.



security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java
Lines 964 (patched)


revokeRequest->grantRequest



security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java
Lines 1009 (patched)


Even if policyResources are less then revokedResources, revokedResources 
should be removed from policyResources. Please review.



security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java
Lines 1045 (patched)


resourceMap is extracted from existingPolicy. In that case, is it necessary 
to set it back into existingPolicy? Please review.


- Abhay Kulkarni


On Jan. 9, 2024, 6:48 a.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74825/
> ---
> 
> (Updated Jan. 9, 2024, 6:48 a.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, 
> Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-4638
> https://issues.apache.org/jira/browse/RANGER-4638
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-4638:Multiple Columns Revoke not generating policies with correct 
> number of columns
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
>  7fe2a2eb3 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java
>  0a14b387a 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java
>  f16157ce6 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerPolicyResourceMatcher.java
>  e1cd89b70 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/R

[jira] [Created] (RANGER-4644) [Ranger UI] Clicking on the policy Id in the access audits (audits related to gds) leads to an error

[Abhishek (Jira)]

Abhishek created RANGER-4644:


 Summary: [Ranger UI] Clicking on the policy Id in the access 
audits (audits related to gds) leads to an error
 Key: RANGER-4644
 URL: https://issues.apache.org/jira/browse/RANGER-4644
 Project: Ranger
  Issue Type: Sub-task
  Components: admin, Ranger
Reporter: Abhishek
Assignee: Abhishek


In the GDS access audits, if the user clicks on the policy id of a particular 
audit, then it leads to an error.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4644) [Ranger UI] Clicking on the policy Id in the access audits (audits related to gds) leads to an error

[Abhishek (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek updated RANGER-4644:
-
Attachment: Screenshot 2024-01-11 at 1.43.43 AM.png

> [Ranger UI] Clicking on the policy Id in the access audits (audits related to 
> gds) leads to an error
> 
>
> Key: RANGER-4644
> URL: https://issues.apache.org/jira/browse/RANGER-4644
> Project: Ranger
>  Issue Type: Sub-task
>  Components: admin, Ranger
>Reporter: Abhishek
>Assignee: Abhishek
>Priority: Major
> Attachments: Screenshot 2024-01-11 at 1.43.43 AM.png
>
>
> In the GDS access audits, if the user clicks on the policy id of a particular 
> audit, then it leads to an error.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4645) Unit test failures in TestAssetREST.testCountXAssets and TestXAuditREST.Test8countXAccessAudits

[Madhan Neethiraj (Jira)]

Madhan Neethiraj created RANGER-4645:


 Summary: Unit test failures in TestAssetREST.testCountXAssets and 
TestXAuditREST.Test8countXAccessAudits
 Key: RANGER-4645
 URL: https://issues.apache.org/jira/browse/RANGER-4645
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Affects Versions: 3.0.0
Reporter: Madhan Neethiraj
Assignee: Madhan Neethiraj


Build in master branch ({{{}mvn clean verify install{}}}) fails due to 
following 2 unit test failures:
{noformat}
Failed tests:
  TestSecurityZoneDBStore.test2updateSecurityZoneById:135
Wanted but not invoked:
daoManager.getXXSecurityZoneDao();
-> at 
org.apache.ranger.biz.TestSecurityZoneDBStore.test2updateSecurityZoneById(TestSecurityZoneDBStore.java:135)

However, there was exactly 1 interaction with this mock:
daoManager.getXXGlobalState();
-> at 
org.apache.ranger.biz.SecurityZoneDBStore.updateSecurityZoneById(SecurityZoneDBStore.java:125)


  TestSecurityZoneDBStore.test9updateSecurityZoneByUnknownId
Expected: an instance of javax.ws.rs.WebApplicationException
 but:  is a java.lang.NullPointerException
Stacktrace was: java.lang.NullPointerException
at 
org.apache.ranger.biz.SecurityZoneDBStore.updateSecurityZoneById(SecurityZoneDBStore.java:125)
at 
org.apache.ranger.biz.TestSecurityZoneDBStore.test9updateSecurityZoneByUnknownId(TestSecurityZoneDBStore.java:312)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.mockito.internal.runners.DefaultInternalRunner$1$1.evaluate(DefaultInternalRunner.java:44)
at 
org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at 
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at 
org.mockito.internal.runners.DefaultInternalRunner$1.run(DefaultInternalRunner.java:74)
at 
org.mockito.internal.runners.DefaultInternalRunner.run(DefaultInternalRunner.java:80)
at org.mockito.internal.runners.StrictRunner.run(StrictRunner.java:39)
at org.mockito.junit.MockitoJUnitRunner.run(MockitoJUnitRunner.java:163)
at 
org.mockito.runners.MockitoJUnitRunner.run(MockitoJUnitRunner.java:53)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)

Tests in error:
  TestAssetREST.testCountXAssets:424 » NullPointer
  TestXAuditREST.Test8countXAccessAudits:208 » NullPointer

Tests run: 1049, Failures: 2, Errors: 2, Skipped: 6
{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Review Request 74829: RANGER-4645: fix for unit test failures in TestAssetREST.testCountXAssets and TestXAuditREST.Test8countXAccessAudits

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74829/
---

Review request for ranger, Ankita Sinha, Abhay Kulkarni, Mehul Parikh, Monika 
Kachhadiya, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan 
Periasamy.


Bugs: RANGER-4645
https://issues.apache.org/jira/browse/RANGER-4645


Repository: ranger


Description
---

updated the tests for recent implementation changes


Diffs
-

  security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java 
a877597c5 
  
security-admin/src/test/java/org/apache/ranger/biz/TestSecurityZoneDBStore.java 
0a9e3bbb2 
  security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 
180742bcd 
  security-admin/src/test/java/org/apache/ranger/rest/TestXAuditREST.java 
2864cd36c 


Diff: https://reviews.apache.org/r/74829/diff/1/


Testing
---

- verified that build using 'mvn clean verify install' completes successfully


Thanks,

Madhan Neethiraj

[jira] [Updated] (RANGER-4645) Unit test failures in TestAssetREST.testCountXAssets and TestXAuditREST.Test8countXAccessAudits

[Madhan Neethiraj (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated RANGER-4645:
-
Attachment: RANGER-4645.patch

> Unit test failures in TestAssetREST.testCountXAssets and 
> TestXAuditREST.Test8countXAccessAudits
> ---
>
> Key: RANGER-4645
> URL: https://issues.apache.org/jira/browse/RANGER-4645
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 3.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: RANGER-4645.patch
>
>
> Build in master branch ({{{}mvn clean verify install{}}}) fails due to 
> following 2 unit test failures:
> {noformat}
> Failed tests:
>   TestSecurityZoneDBStore.test2updateSecurityZoneById:135
> Wanted but not invoked:
> daoManager.getXXSecurityZoneDao();
> -> at 
> org.apache.ranger.biz.TestSecurityZoneDBStore.test2updateSecurityZoneById(TestSecurityZoneDBStore.java:135)
> However, there was exactly 1 interaction with this mock:
> daoManager.getXXGlobalState();
> -> at 
> org.apache.ranger.biz.SecurityZoneDBStore.updateSecurityZoneById(SecurityZoneDBStore.java:125)
>   TestSecurityZoneDBStore.test9updateSecurityZoneByUnknownId
> Expected: an instance of javax.ws.rs.WebApplicationException
>  but:  is a java.lang.NullPointerException
> Stacktrace was: java.lang.NullPointerException
>   at 
> org.apache.ranger.biz.SecurityZoneDBStore.updateSecurityZoneById(SecurityZoneDBStore.java:125)
>   at 
> org.apache.ranger.biz.TestSecurityZoneDBStore.test9updateSecurityZoneByUnknownId(TestSecurityZoneDBStore.java:312)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.mockito.internal.runners.DefaultInternalRunner$1$1.evaluate(DefaultInternalRunner.java:44)
>   at 
> org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
>   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
>   at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
>   at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
>   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
>   at 
> org.mockito.internal.runners.DefaultInternalRunner$1.run(DefaultInternalRunner.java:74)
>   at 
> org.mockito.internal.runners.DefaultInternalRunner.run(DefaultInternalRunner.java:80)
>   at org.mockito.internal.runners.StrictRunner.run(StrictRunner.java:39)
>   at org.mockito.junit.MockitoJUnitRunner.run(MockitoJUnitRunner.java:163)
>   at 
> org.mockito.runners.MockitoJUnitRunner.run(MockitoJUnitRunner.java:53)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
> Tests in error:
>   TestAssetREST.testCountXAssets:424 » NullPoint

[jira] [Created] (RANGER-4646) Add Unit tests for GDS related implementation files

[Abhishek (Jira)]

Abhishek created RANGER-4646:


 Summary: Add Unit tests for GDS related implementation files
 Key: RANGER-4646
 URL: https://issues.apache.org/jira/browse/RANGER-4646
 Project: Ranger
  Issue Type: Sub-task
  Components: Ranger
Reporter: Abhishek
Assignee: Abhishek


Unit tests are missing in the repo for GDS REST APIs and other GDS related 
implementation files. Unit tests have to be added for them



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4644) [Ranger UI] Clicking on the policy Id in the access audits (audits related to gds) leads to an error

[Abhishek (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek updated RANGER-4644:
-
Labels: ranger-react  (was: )

> [Ranger UI] Clicking on the policy Id in the access audits (audits related to 
> gds) leads to an error
> 
>
> Key: RANGER-4644
> URL: https://issues.apache.org/jira/browse/RANGER-4644
> Project: Ranger
>  Issue Type: Sub-task
>  Components: admin, Ranger
>Reporter: Abhishek
>Assignee: Abhishek
>Priority: Major
>  Labels: ranger-react
> Attachments: Screenshot 2024-01-11 at 1.43.43 AM.png
>
>
> In the GDS access audits, if the user clicks on the policy id of a particular 
> audit, then it leads to an error.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4647) Text overflowing in the datashares table listing in the dataset -> datashares page

[Abhishek (Jira)]

Abhishek created RANGER-4647:


 Summary: Text overflowing in the datashares table listing in the 
dataset -> datashares page
 Key: RANGER-4647
 URL: https://issues.apache.org/jira/browse/RANGER-4647
 Project: Ranger
  Issue Type: Sub-task
  Components: admin
Reporter: Abhishek
Assignee: Abhishek


In the dataset page, there is a tab to view the linked datashares.
In the table where the datashares are listed, if the datashare name is long,
the text is overflowing into the next column.
Ideally, the text should be wrapped in such cases



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4647) Text overflowing in the datashares table listing in the dataset -> datashares page

[Abhishek (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek updated RANGER-4647:
-
Attachment: Screenshot 2024-01-11 at 11.17.09 AM.png

> Text overflowing in the datashares table listing in the dataset -> datashares 
> page
> --
>
> Key: RANGER-4647
> URL: https://issues.apache.org/jira/browse/RANGER-4647
> Project: Ranger
>  Issue Type: Sub-task
>  Components: admin
>Reporter: Abhishek
>Assignee: Abhishek
>Priority: Major
> Attachments: Screenshot 2024-01-11 at 11.17.09 AM.png
>
>
> In the dataset page, there is a tab to view the linked datashares.
> In the table where the datashares are listed, if the datashare name is long,
> the text is overflowing into the next column.
> Ideally, the text should be wrapped in such cases



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4648) [Ranger UI] Add assertions in the form to restrict the datashare / dataset name length

[Abhishek (Jira)]

Abhishek created RANGER-4648:


 Summary: [Ranger UI] Add assertions in the form to restrict the 
datashare / dataset name length
 Key: RANGER-4648
 URL: https://issues.apache.org/jira/browse/RANGER-4648
 Project: Ranger
  Issue Type: Sub-task
  Components: admin
Reporter: Abhishek
Assignee: Abhishek


Add assertions in the form to restrict the datashare / dataset name length.
If adding assertions is not possible, then a proper error message has to be 
displayed stating that the datashare / dataset name has to be limited (This 
behvaiour is already present in the policy creation form)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4647) [Ranger UI] Text overflowing in the datashares table listing in the dataset -> datashares page

[Abhishek (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek updated RANGER-4647:
-
Summary: [Ranger UI] Text overflowing in the datashares table listing in 
the dataset -> datashares page  (was: Text overflowing in the datashares table 
listing in the dataset -> datashares page)

> [Ranger UI] Text overflowing in the datashares table listing in the dataset 
> -> datashares page
> --
>
> Key: RANGER-4647
> URL: https://issues.apache.org/jira/browse/RANGER-4647
> Project: Ranger
>  Issue Type: Sub-task
>  Components: admin
>Reporter: Abhishek
>Assignee: Abhishek
>Priority: Major
> Attachments: Screenshot 2024-01-11 at 11.17.09 AM.png
>
>
> In the dataset page, there is a tab to view the linked datashares.
> In the table where the datashares are listed, if the datashare name is long,
> the text is overflowing into the next column.
> Ideally, the text should be wrapped in such cases



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4648) [Ranger UI] Add assertions in the form to restrict the datashare / dataset name length

[Abhishek (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek updated RANGER-4648:
-
Labels: ranger-react  (was: )

> [Ranger UI] Add assertions in the form to restrict the datashare / dataset 
> name length
> --
>
> Key: RANGER-4648
> URL: https://issues.apache.org/jira/browse/RANGER-4648
> Project: Ranger
>  Issue Type: Sub-task
>  Components: admin
>Reporter: Abhishek
>Assignee: Abhishek
>Priority: Major
>  Labels: ranger-react
>
> Add assertions in the form to restrict the datashare / dataset name length.
> If adding assertions is not possible, then a proper error message has to be 
> displayed stating that the datashare / dataset name has to be limited (This 
> behvaiour is already present in the policy creation form)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4647) [Ranger UI] Text overflowing in the datashares table listing in the dataset -> datashares page

[Abhishek (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek updated RANGER-4647:
-
Labels: ranger-react  (was: )

> [Ranger UI] Text overflowing in the datashares table listing in the dataset 
> -> datashares page
> --
>
> Key: RANGER-4647
> URL: https://issues.apache.org/jira/browse/RANGER-4647
> Project: Ranger
>  Issue Type: Sub-task
>  Components: admin
>Reporter: Abhishek
>Assignee: Abhishek
>Priority: Major
>  Labels: ranger-react
> Attachments: Screenshot 2024-01-11 at 11.17.09 AM.png
>
>
> In the dataset page, there is a tab to view the linked datashares.
> In the table where the datashares are listed, if the datashare name is long,
> the text is overflowing into the next column.
> Ideally, the text should be wrapped in such cases



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (RANGER-4213) Getting 302 status code instead of 419 in case of session timeout

[Rakesh Gupta (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805389#comment-17805389
 ] 

Rakesh Gupta commented on RANGER-4213:
--

[~vishalsuvagia]  please review this RR as it's breaking Ranger UI 
session-timeout functionality.

> Getting 302 status code instead of 419 in case of session timeout
> -
>
> Key: RANGER-4213
> URL: https://issues.apache.org/jira/browse/RANGER-4213
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Mugdha Varadkar
>Assignee: Rakesh Gupta
>Priority: Major
> Attachments: 0001-RANGER-4213.patch
>
>
> Steps to reproduce :
> # Setup a cluster with Ranger Admin code bits
> # Set session timeout to lower value in {{ews/webapp/WEB-INF/web.xml}}
> # Start Ranger Admin
> # When session is timeout the "service/plugins/" api gives status code 302 
> instead of 419
> # Earlier we used to get 419 status code from api during session time-out
> cc [~Dhaval.Rajpara] / [~mehul]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4649) Junit failing in TestServiceREST , TestAssetREST, TestXAuditREST

[Prashant Satam (Jira)]

Prashant Satam created RANGER-4649:
--

 Summary: Junit failing in TestServiceREST , TestAssetREST, 
TestXAuditREST
 Key: RANGER-4649
 URL: https://issues.apache.org/jira/browse/RANGER-4649
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Reporter: Prashant Satam






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (RANGER-4649) Junit failing in TestServiceREST , TestAssetREST, TestXAuditREST

[Prashant Satam (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashant Satam reassigned RANGER-4649:
--

Assignee: Prashant Satam

> Junit failing in TestServiceREST , TestAssetREST, TestXAuditREST
> 
>
> Key: RANGER-4649
> URL: https://issues.apache.org/jira/browse/RANGER-4649
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Prashant Satam
>Assignee: Prashant Satam
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4649) Junit failing in TestServiceREST , TestAssetREST, TestXAuditREST

[Prashant Satam (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashant Satam updated RANGER-4649:
---
Description: 
There are junit test case failure in :

 

 

  was:
There are junit test case failure in :

 


> Junit failing in TestServiceREST , TestAssetREST, TestXAuditREST
> 
>
> Key: RANGER-4649
> URL: https://issues.apache.org/jira/browse/RANGER-4649
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Prashant Satam
>Assignee: Prashant Satam
>Priority: Major
>
> There are junit test case failure in :
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4649) Junit failing in TestServiceREST , TestAssetREST, TestXAuditREST

[Prashant Satam (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashant Satam updated RANGER-4649:
---
Description: 
There are junit test case failure in :

 

> Junit failing in TestServiceREST , TestAssetREST, TestXAuditREST
> 
>
> Key: RANGER-4649
> URL: https://issues.apache.org/jira/browse/RANGER-4649
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Prashant Satam
>Assignee: Prashant Satam
>Priority: Major
>
> There are junit test case failure in :
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4649) Junit failing in TestServiceREST , TestAssetREST, TestXAuditREST

[Prashant Satam (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashant Satam updated RANGER-4649:
---
Description: 
There are junit test case failure in :

TestServiceREST > test71DeleteClusterServices

 

 

  was:
There are junit test case failure in :

 

 


> Junit failing in TestServiceREST , TestAssetREST, TestXAuditREST
> 
>
> Key: RANGER-4649
> URL: https://issues.apache.org/jira/browse/RANGER-4649
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Prashant Satam
>Assignee: Prashant Satam
>Priority: Major
>
> There are junit test case failure in :
> TestServiceREST > test71DeleteClusterServices
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4649) Junit failing in TestServiceREST , TestAssetREST, TestXAuditREST

[Prashant Satam (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashant Satam updated RANGER-4649:
---
Description: 
There are junit test case failure in :

TestServiceREST > test71DeleteClusterServices,

TestAssetREST ---> testCountXAssets,

TestXAuditREST --> Test7searchXAccessAudits

 

 

 

  was:
There are junit test case failure in :

TestServiceREST > test71DeleteClusterServices,

TestAssetREST ---> testCountXAssets,

 

 

 


> Junit failing in TestServiceREST , TestAssetREST, TestXAuditREST
> 
>
> Key: RANGER-4649
> URL: https://issues.apache.org/jira/browse/RANGER-4649
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Prashant Satam
>Assignee: Prashant Satam
>Priority: Major
>
> There are junit test case failure in :
> TestServiceREST > test71DeleteClusterServices,
> TestAssetREST ---> testCountXAssets,
> TestXAuditREST --> Test7searchXAccessAudits
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4649) Junit failing in TestServiceREST , TestAssetREST, TestXAuditREST

[Prashant Satam (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashant Satam updated RANGER-4649:
---
Description: 
There are junit test case failure in :

TestServiceREST > test71DeleteClusterServices,

TestAssetREST ---> testCountXAssets,

 

 

 

  was:
There are junit test case failure in :

TestServiceREST > test71DeleteClusterServices

 

 


> Junit failing in TestServiceREST , TestAssetREST, TestXAuditREST
> 
>
> Key: RANGER-4649
> URL: https://issues.apache.org/jira/browse/RANGER-4649
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Prashant Satam
>Assignee: Prashant Satam
>Priority: Major
>
> There are junit test case failure in :
> TestServiceREST > test71DeleteClusterServices,
> TestAssetREST ---> testCountXAssets,
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Review Request 74830: RANGER-4649 : Junit failing in TestServiceREST , TestAssetREST, TestXAuditREST

[Prashant Satam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74830/
---

Review request for ranger, Anand Nadar, Madhan Neethiraj, Monika Kachhadiya, 
and Subhrat Chaudhary.


Bugs: RANGER-4649
https://issues.apache.org/jira/browse/RANGER-4649


Repository: ranger


Description
---

There are junit test case failure in :

TestServiceREST > test71DeleteClusterServices,

TestAssetREST ---> testCountXAssets,

TestXAuditREST --> Test7searchXAccessAudits


Diffs
-

  security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 
180742bcd 
  security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 
ff5fe218a 
  security-admin/src/test/java/org/apache/ranger/rest/TestXAuditREST.java 
2864cd36c 


Diff: https://reviews.apache.org/r/74830/diff/1/


Testing
---

The above mentioned junit test cases are passing and ranger is able to build


Thanks,

Prashant Satam