Re: Review Request 71530: RANGER-2585: Ranger audits for hive role commands show user as "hive" instead of the effective user

[Sailaja Polavarapu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71530/
---

(Updated Sept. 23, 2019, 5:34 p.m.)


Review request for ranger, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, and 
Velmurugan Periasamy.


Changes
---

Incorporated review comments


Bugs: RANGER-2585
https://issues.apache.org/jira/browse/RANGER-2585


Repository: ranger


Description
---

Setting AddedByUserId and UpdatedByUserId from ranger role request instead from 
the user session.


Diffs (updated)
-

  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
 0c5449d44 
  
security-admin/src/main/java/org/apache/ranger/common/db/JPABeanCallbacks.java 
226c0606a 
  security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 25fb0858a 
  security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 
ca4407b06 


Diff: https://reviews.apache.org/r/71530/diff/2/

Changes: https://reviews.apache.org/r/71530/diff/1-2/


Testing
---

1. Patched cluster and verified the audits for role commands are showing the 
effective user instead of "hive" user.
2. Also verified the DB tables for x_role and x_trxlog tables.
3. Verified all the existing unit tests run successfully.


Thanks,

Sailaja Polavarapu

Re: Review Request 71530: RANGER-2585: Ranger audits for hive role commands show user as "hive" instead of the effective user

[Abhay Kulkarni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71530/#review217900
---


Fix it, then Ship it!





security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java
Lines 158 (patched)


Please consider using StringUtils.isNotBlank() instead of StringUtil class.



security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java
Lines 162 (patched)


Please format with spaces around operators in this block.


- Abhay Kulkarni


On Sept. 21, 2019, 12:27 a.m., Sailaja Polavarapu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71530/
> ---
> 
> (Updated Sept. 21, 2019, 12:27 a.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2585
> https://issues.apache.org/jira/browse/RANGER-2585
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Setting AddedByUserId and UpdatedByUserId from ranger role request instead 
> from the user session.
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  0c5449d44 
>   
> security-admin/src/main/java/org/apache/ranger/common/db/JPABeanCallbacks.java
>  226c0606a 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 25fb0858a 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 
> ca4407b06 
> 
> 
> Diff: https://reviews.apache.org/r/71530/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Patched cluster and verified the audits for role commands are showing the 
> effective user instead of "hive" user.
> 2. Also verified the DB tables for x_role and x_trxlog tables.
> 3. Verified all the existing unit tests run successfully.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>

Review Request 71530: RANGER-2585: Ranger audits for hive role commands show user as "hive" instead of the effective user

[Sailaja Polavarapu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71530/
---

Review request for ranger, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, and 
Velmurugan Periasamy.


Bugs: RANGER-2585
https://issues.apache.org/jira/browse/RANGER-2585


Repository: ranger


Description
---

Setting AddedByUserId and UpdatedByUserId from ranger role request instead from 
the user session.


Diffs
-

  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
 0c5449d44 
  
security-admin/src/main/java/org/apache/ranger/common/db/JPABeanCallbacks.java 
226c0606a 
  security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 25fb0858a 
  security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 
ca4407b06 


Diff: https://reviews.apache.org/r/71530/diff/1/


Testing
---

1. Patched cluster and verified the audits for role commands are showing the 
effective user instead of "hive" user.
2. Also verified the DB tables for x_role and x_trxlog tables.
3. Verified all the existing unit tests run successfully.


Thanks,

Sailaja Polavarapu