Re: Apache Roller 5.2.1-rc-1 ready for review
Upgrade looks ok. Database upgrade went OK also. +1 (b) ## Noticed that the pager links look strange on the main weblog page. http://localhost:8080/roller/testuser/ If I have three entries Test1 Test2 Test3 If I click on Test1 : http://localhost:8080/roller/testuser/entry/test1 The pager link at the top of the page is : « Test1 | Main Should be: Main | Test2 » as we are paging down the entries? also these don't look correct: http://localhost:8080/roller/testuser/entry/test2 « Test2 | Main | Test1 » >> « Test1 | Main | Test3 » http://localhost:8080/roller/testuser/entry/test3 « Test3 | Main | Test2 » >> « Test2 | Main Cheers Greg On Sat, 1 Sep 2018 at 13:57, Dave wrote: > I have prepared a release candidate #1 for a new release Roller v.5.2.1. > > The purpose of this release is to upgrade to Struts 2.5.17 which includes > some security fixes. That is the only change in this release. > > You can find the release files here: > https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.1-rc-1/ > > I've done some smoke-testing and will upgrade my site over the next day or > two. > Please take a look, try it out if you have time and I will call a vote > probably tomorrow. > > Thanks, > Dave >
Re: Switch Roller master branch to Java 10?
Turns out Guice is not yet fully compatible with Java 9 and Java 10, so we will have to wait for Guice 4.2.1 to be released or remove Guice. I've often wondered how hard it would be to switch out Guice for standand Java CDI. We don't make extensive use or Guice or any of its more advanced features, so it shouldn't be that hard. Dave On Sun, Sep 2, 2018 at 12:37 AM Kohei Nozaki wrote: > +1 > > > On Sep 2, 2018, at 13:30, Nitin Lokhande > wrote: > > > > Its good. > > Though if Java 11 releasing this month then it can be an option too. > > > > Thanks, > > Nitin > > > > On Sat, Sep 1, 2018 at 4:11 PM, Dave wrote: > > > >> The Roller 5.2.1 release candidate and the 5.2 branch is still using > Java > >> 7, which is past its end of life. I think that is fine and good for > 5.2.x > >> releases but for post 5.2.x, I think we should switch to Java 10. > >> > >> Anybody opposed to switching Roller master over to Java 10? > >> > >> Thanks, > >> Dave > >> > >
jetty:run not working ( source github)
jetty:run is throwing exceptions for source downloaded from github master branch. However it works fine if I download source as zip from apache or 5.2.0final branch of github. Thanks, Nitin
Re: Apache Roller 5.2.1-rc-1 ready for review
Thanks Greg. I'll check that out. Dave On Sun, Sep 2, 2018 at 4:40 AM Greg Huber wrote: > Upgrade looks ok. Database upgrade went OK also. +1 (b) > > ## > > Noticed that the pager links look strange on the main weblog page. > > http://localhost:8080/roller/testuser/ > > If I have three entries > Test1 > Test2 > Test3 > > If I click on Test1 : http://localhost:8080/roller/testuser/entry/test1 > > The pager link at the top of the page is : « Test1 | Main > > Should be: Main | Test2 » as we are paging down the entries? > > also these don't look correct: > > http://localhost:8080/roller/testuser/entry/test2 > > « Test2 | Main | Test1 » >> « Test1 | Main | Test3 » > > http://localhost:8080/roller/testuser/entry/test3 > > « Test3 | Main | Test2 » >> « Test2 | Main > > Cheers Greg > > > On Sat, 1 Sep 2018 at 13:57, Dave wrote: > > > I have prepared a release candidate #1 for a new release Roller v.5.2.1. > > > > The purpose of this release is to upgrade to Struts 2.5.17 which includes > > some security fixes. That is the only change in this release. > > > > You can find the release files here: > > https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.1-rc-1/ > > > > I've done some smoke-testing and will upgrade my site over the next day > or > > two. > > Please take a look, try it out if you have time and I will call a vote > > probably tomorrow. > > > > Thanks, > > Dave > > >
Re: jetty:run not working ( source github)
Hi Nitin, I just upgraded master to use Java 8 and the latest version of Jetty. "mvn jetty:run" is working for me with these changes. Hope that helps... Dave On Sun, Sep 2, 2018 at 2:26 PM Nitin Lokhande wrote: > jetty:run is throwing exceptions for source downloaded from github master > branch. > However it works fine if I download source as zip from apache or 5.2.0final > branch of github. > > Thanks, > Nitin >
