Re: MediaFileView.jsp
> looks like a copy and paste bug on first glance. However deleting
folders actually works, right? I ran a quick test and the folder is gone.
Yes it works, but I get this error in the console (forgot to add this to
the first email) after delete:
Uncaught TypeError: document.bookmarks is undefined
onDeleteFolder
http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:956
onclick
http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:1
##
>Its called Blogroll...
OK name change.
Cheers Greg
On 09/08/2021 17:46, Michael Bien wrote:
On 09.08.21 09:51, Greg Huber wrote:
Spotted this one when deleting a folder:
MediaFileView.jsp
function onDeleteFolder() {
if (confirm("/>")) {
document.bookmarks.action = 'action="mediaFileView!deleteFolder" />';
document.bookmarks.submit();
}
}
guess it should be: document.mediaFileViewForm.action and
document.mediaFileViewForm.submit();
looks like a copy and paste bug on first glance. However deleting
folders actually works, right? I ran a quick test and the folder is gone.
Also where is the bookmarks page link now? editor-menu.xml, for
weblogPerms="admin"
subactions="bookmarkAdd,bookmarkEdit,folderAdd,folderEdit,bookmarksImport"
/>
Its called Blogroll in the menu
(/roller-ui/authoring/bookmarks.rol?weblog=blog)
the admin user might not have this menu unless the admin has a blog too.
best regards,
michael
Re: MediaFileView.jsp
...Sorry, sent too soon,
Below comes from the
http://127.0.0.1:8080/roller/roller-ui/authoring/bookmarks.rol?weblog=testuser
menu.
08:06:25.493 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (org.apache.roller.weblogger.ui.struts2.editor.Bookmarks)
could not locate the message resource with key 'default'
08:06:25.493 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (org.apache.roller.weblogger.ui.struts2.editor.Bookmarks)
could not locate the message resource with key 'default'
08:06:25.494 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The default value
expression 'default' was evaluated and did not match a property. The
literal value 'default' will be used.
08:06:25.494 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The default value
expression 'default' was evaluated and did not match a property. The
literal value 'default' will be used.
Cheers Greg
On 09/08/2021 17:46, Michael Bien wrote:
On 09.08.21 09:51, Greg Huber wrote:
Spotted this one when deleting a folder:
MediaFileView.jsp
function onDeleteFolder() {
if (confirm("/>")) {
document.bookmarks.action = 'action="mediaFileView!deleteFolder" />';
document.bookmarks.submit();
}
}
guess it should be: document.mediaFileViewForm.action and
document.mediaFileViewForm.submit();
looks like a copy and paste bug on first glance. However deleting
folders actually works, right? I ran a quick test and the folder is gone.
Also where is the bookmarks page link now? editor-menu.xml, for
weblogPerms="admin"
subactions="bookmarkAdd,bookmarkEdit,folderAdd,folderEdit,bookmarksImport"
/>
Its called Blogroll in the menu
(/roller-ui/authoring/bookmarks.rol?weblog=blog)
the admin user might not have this menu unless the admin has a blog too.
best regards,
michael
[GitHub] [roller] mbien opened a new pull request #101: MediaFileView.jsp delete folder JS error fix
mbien opened a new pull request #101: URL: https://github.com/apache/roller/pull/101 As noticed by Greg Huber on the mailing list, deleting a folder in the media file view results in a JS error. (although the folder is still deleted) this fixes it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: MediaFileView.jsp
On 10.08.21 09:05, Greg Huber wrote: > looks like a copy and paste bug on first glance. However deleting folders actually works, right? I ran a quick test and the folder is gone. Yes it works, but I get this error in the console (forgot to add this to the first email) after delete: Uncaught TypeError: document.bookmarks is undefined onDeleteFolder http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:956 onclick http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:1 oh, *that* console :) It looks like it is failing in a good way since it is actually unable to delete bookmarks with that context. fix -> https://github.com/apache/roller/pull/101 I don't feel its a show stopper for the update release. regards, michael
Re: VOTE: Release Apache Roller 6.0.2
+1 Thanks and Regards, Aditya Sharma On Mon, 9 Aug 2021 at 01:27, Dave wrote: > Please vote to release the release candidate (RC2) at the link below as > Apache Roller 6.0.2 > The release candidate is here > https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.2/ > > Please vote +1 to release or -1 with reasons not to release. > > > This release includes the minor changes listed below: > > Parse referrer URL instead of using string value directly > https://github.com/apache/roller/pull/90 > > Improved: the UI for the blog entries page > https://github.com/apache/roller/pull/87 > > Improved: tooltip content on the registration form > https://github.com/apache/roller/pull/89 > > Updated: the main menu to have proper space when displaying permission > message > https://github.com/apache/roller/pull/95 > > Updated: the header to show the tagline only when it's available > https://github.com/apache/roller/pull/99 > > > UI fixes are thanks to new contributor Yash Maheshwari. > > Best regards, > Dave >
Re: Board report coming up
Thanks Dave! Looks good to me. Thanks and Regards, Aditya Sharma On Mon, 9 Aug 2021 at 02:22, Dave wrote: > I typed up a draft of the report in the Reporter tool, which you can find > here: > >https://reporter.apache.org/wizard/?roller > > PMC members please review if you have a chance and feel free to make edits. > I will submit the report Tuesday. > > Thanks, > Dave >
