Re: Apache tiles
After some investigation, I've found that moving Struts 6 is more work than I'm ready for right now. I think you should merge that dependency update PR as is, Michael. It looks good to me. Dave On Tue, Mar 21, 2023 at 9:53 AM Dave wrote: > I retract my statement about the IT tests passing. The tests run a lot > farther than they did but I'm still getting a failure. I've got a little > time today, so I will investigate. > > Dave > > > On Tue, Mar 21, 2023 at 9:44 AM Dave wrote: > >> Michael, I checked out your PR https://github.com/apache/roller/pull/119 >> and bumped Struts up to 6.1.2 and then saw errors when running the >> integration tests. When I upgraded Struts-Bootstrap to 5.0.0 those errors >> went away, but parts of the Roller UI look a little funky, e.g. button >> placement is off on the editor page. I'm going to do some more testing and >> fixing and see if I get that PR ready for merge. >> >> Dave >> >> >> On Tue, Mar 21, 2023 at 3:24 AM Michael Bien wrote: >> >>> roller would need some updates before it can go beyond struts 2.5.29: >>> >>> https://github.com/apache/roller/pull/119#issuecomment-1344814362 >>> >>> >>> probably easy to do but I never got to it. (bump the version and you >>> should see failing integration tests) >>> >>> the bootstrap dependency is also locked to 3.4.x AFAIR due to breaking >>> changes which may or may not prevent other updates in future. >>> >>> other then that I tried to keep the dependencies somewhat up2date, i >>> think jakarta.persistence is already in use via eclipse link etc. >>> >>> best regards, >>> >>> michael >>> >>> >>> On 21.03.23 07:58, Greg Huber wrote: >>> > Dave, >>> > >>> > BTW, Struts devs are planning to merge the tiles code base into the >>> > Struts Tiles Plugin to eliminate the dependency on the now Attic >>> project. >>> > >>> > https://github.com/apache/struts/tree/WW-5233-tiles/plugins/tiles >>> > >>> > >>> > On 20/03/2023 21:38, Dave wrote: >>> >> Hi Laurent and PJ, >>> >> >>> >> The Apache Roller project still uses Struts, Tiles and Velocity and I >>> >> would >>> >> like to see the projects continue and move into Jakarta land. I have >>> >> some >>> >> limited time to help out. What do y'all need help with? >>> >> >>> >> Dave >>> >> >>> >> On Sun, Mar 19, 2023 at 8:01 AM PJ Fanning >>> wrote: >>> >> >>> >>> Hi Laurent, >>> >>> I don't want to write off the possibility of a Jakarta variant of >>> >>> Tiles joining the Apache Incubator - but the fact that Apache Tiles >>> >>> doesn't have an active community around it is going to be a major >>> >>> impediment. For Apache projects and podlings to succeed, they need a >>> >>> number of contributors to get involved. >>> >>> Could you start by putting your code up on Github or somewhere >>> similar >>> >>> and adding documentation that highlights that you are looking for >>> >>> collaborators? Maybe there are some forums where some remaining users >>> >>> of Tiles can be contacted? >>> >>> >>> >>> There is no impediment to you simply releasing your Jakarta variant >>> of >>> >>> Tiles yourself or via some organisation that you are involved with >>> >>> (e.g. a company that you work with). If you go this route, the ASF >>> >>> would look like to see that you remove all the ASF branding and >>> >>> ideally, change the package names. >>> >>> >>> >>> If you want to avoid having to do all the branding changes and see >>> the >>> >>> new project join/rejoin the ASF, then I think that you'll need to >>> come >>> >>> back to us with more collaborators and probably some indication that >>> >>> they are bought into keeping the project going over the foreseeable >>> >>> future. >>> >>> >>> >>> Regards, >>> >>> PJ >>> >>> >>> >>> >>> >>> On Sat, 18 Mar 2023 at 06:32, Laurent Schoelens >>> >>> wrote: >>> Hi everyone, >>> >>> I’m working on Apache Tiles porting to Jakarta EE (without support >>> of >>> >>> freemarker and velocity, since both of them are still going with >>> >>> javax API) >>> >>> and my work is going to reach it’s end – all builds are successful, >>> >>> jdk17 >>> >>> baseline and updated dependencies (as far as I know) – but still >>> >>> uncommited >>> >>> to my personal github account. >>> I know Tiles is in Attic land of Apache but I’d which to make this >>> first >>> >>> step (Jakarta migration) go to open-source world, without creating >>> new >>> >>> projects out of the box. >>> Tiles is a framework I use on a project, with Spring and since >>> Spring 6 >>> >>> has migrated to Jakarta API, I’m stuck to Spring 5.X if I stay on >>> this. >>> >>> Changing technology is an option for frontend application but not >>> >>> until a >>> >>> good rework that may take months (or years, depending on time we >>> >>> have to do >>> >>> that migration). >>> Having a Tiles Jakarta port would be great since the technology >>> itself >>> >>> is working well on my project. >>> Do you know what can I do to make this properly, according to Apache
Re: Apache tiles
I retract my statement about the IT tests passing. The tests run a lot farther than they did but I'm still getting a failure. I've got a little time today, so I will investigate. Dave On Tue, Mar 21, 2023 at 9:44 AM Dave wrote: > Michael, I checked out your PR https://github.com/apache/roller/pull/119 > and bumped Struts up to 6.1.2 and then saw errors when running the > integration tests. When I upgraded Struts-Bootstrap to 5.0.0 those errors > went away, but parts of the Roller UI look a little funky, e.g. button > placement is off on the editor page. I'm going to do some more testing and > fixing and see if I get that PR ready for merge. > > Dave > > > On Tue, Mar 21, 2023 at 3:24 AM Michael Bien wrote: > >> roller would need some updates before it can go beyond struts 2.5.29: >> >> https://github.com/apache/roller/pull/119#issuecomment-1344814362 >> >> >> probably easy to do but I never got to it. (bump the version and you >> should see failing integration tests) >> >> the bootstrap dependency is also locked to 3.4.x AFAIR due to breaking >> changes which may or may not prevent other updates in future. >> >> other then that I tried to keep the dependencies somewhat up2date, i >> think jakarta.persistence is already in use via eclipse link etc. >> >> best regards, >> >> michael >> >> >> On 21.03.23 07:58, Greg Huber wrote: >> > Dave, >> > >> > BTW, Struts devs are planning to merge the tiles code base into the >> > Struts Tiles Plugin to eliminate the dependency on the now Attic >> project. >> > >> > https://github.com/apache/struts/tree/WW-5233-tiles/plugins/tiles >> > >> > >> > On 20/03/2023 21:38, Dave wrote: >> >> Hi Laurent and PJ, >> >> >> >> The Apache Roller project still uses Struts, Tiles and Velocity and I >> >> would >> >> like to see the projects continue and move into Jakarta land. I have >> >> some >> >> limited time to help out. What do y'all need help with? >> >> >> >> Dave >> >> >> >> On Sun, Mar 19, 2023 at 8:01 AM PJ Fanning >> wrote: >> >> >> >>> Hi Laurent, >> >>> I don't want to write off the possibility of a Jakarta variant of >> >>> Tiles joining the Apache Incubator - but the fact that Apache Tiles >> >>> doesn't have an active community around it is going to be a major >> >>> impediment. For Apache projects and podlings to succeed, they need a >> >>> number of contributors to get involved. >> >>> Could you start by putting your code up on Github or somewhere similar >> >>> and adding documentation that highlights that you are looking for >> >>> collaborators? Maybe there are some forums where some remaining users >> >>> of Tiles can be contacted? >> >>> >> >>> There is no impediment to you simply releasing your Jakarta variant of >> >>> Tiles yourself or via some organisation that you are involved with >> >>> (e.g. a company that you work with). If you go this route, the ASF >> >>> would look like to see that you remove all the ASF branding and >> >>> ideally, change the package names. >> >>> >> >>> If you want to avoid having to do all the branding changes and see the >> >>> new project join/rejoin the ASF, then I think that you'll need to come >> >>> back to us with more collaborators and probably some indication that >> >>> they are bought into keeping the project going over the foreseeable >> >>> future. >> >>> >> >>> Regards, >> >>> PJ >> >>> >> >>> >> >>> On Sat, 18 Mar 2023 at 06:32, Laurent Schoelens >> >>> wrote: >> Hi everyone, >> >> I’m working on Apache Tiles porting to Jakarta EE (without support of >> >>> freemarker and velocity, since both of them are still going with >> >>> javax API) >> >>> and my work is going to reach it’s end – all builds are successful, >> >>> jdk17 >> >>> baseline and updated dependencies (as far as I know) – but still >> >>> uncommited >> >>> to my personal github account. >> I know Tiles is in Attic land of Apache but I’d which to make this >> first >> >>> step (Jakarta migration) go to open-source world, without creating new >> >>> projects out of the box. >> Tiles is a framework I use on a project, with Spring and since >> Spring 6 >> >>> has migrated to Jakarta API, I’m stuck to Spring 5.X if I stay on >> this. >> >>> Changing technology is an option for frontend application but not >> >>> until a >> >>> good rework that may take months (or years, depending on time we >> >>> have to do >> >>> that migration). >> Having a Tiles Jakarta port would be great since the technology >> itself >> >>> is working well on my project. >> Do you know what can I do to make this properly, according to Apache >> >>> work ? >> Thanks in advance for your help. >> >> Regards. >> L. SCHOELENS >> >>> - >> >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> >>> For additional commands, e-mail: general-h...@incubator.apache.org >> >>> >> >>> >> >> >>
Re: Apache tiles
Michael, I checked out your PR https://github.com/apache/roller/pull/119 and bumped Struts up to 6.1.2 and then saw errors when running the integration tests. When I upgraded Struts-Bootstrap to 5.0.0 those errors went away, but parts of the Roller UI look a little funky, e.g. button placement is off on the editor page. I'm going to do some more testing and fixing and see if I get that PR ready for merge. Dave On Tue, Mar 21, 2023 at 3:24 AM Michael Bien wrote: > roller would need some updates before it can go beyond struts 2.5.29: > > https://github.com/apache/roller/pull/119#issuecomment-1344814362 > > > probably easy to do but I never got to it. (bump the version and you > should see failing integration tests) > > the bootstrap dependency is also locked to 3.4.x AFAIR due to breaking > changes which may or may not prevent other updates in future. > > other then that I tried to keep the dependencies somewhat up2date, i > think jakarta.persistence is already in use via eclipse link etc. > > best regards, > > michael > > > On 21.03.23 07:58, Greg Huber wrote: > > Dave, > > > > BTW, Struts devs are planning to merge the tiles code base into the > > Struts Tiles Plugin to eliminate the dependency on the now Attic project. > > > > https://github.com/apache/struts/tree/WW-5233-tiles/plugins/tiles > > > > > > On 20/03/2023 21:38, Dave wrote: > >> Hi Laurent and PJ, > >> > >> The Apache Roller project still uses Struts, Tiles and Velocity and I > >> would > >> like to see the projects continue and move into Jakarta land. I have > >> some > >> limited time to help out. What do y'all need help with? > >> > >> Dave > >> > >> On Sun, Mar 19, 2023 at 8:01 AM PJ Fanning > wrote: > >> > >>> Hi Laurent, > >>> I don't want to write off the possibility of a Jakarta variant of > >>> Tiles joining the Apache Incubator - but the fact that Apache Tiles > >>> doesn't have an active community around it is going to be a major > >>> impediment. For Apache projects and podlings to succeed, they need a > >>> number of contributors to get involved. > >>> Could you start by putting your code up on Github or somewhere similar > >>> and adding documentation that highlights that you are looking for > >>> collaborators? Maybe there are some forums where some remaining users > >>> of Tiles can be contacted? > >>> > >>> There is no impediment to you simply releasing your Jakarta variant of > >>> Tiles yourself or via some organisation that you are involved with > >>> (e.g. a company that you work with). If you go this route, the ASF > >>> would look like to see that you remove all the ASF branding and > >>> ideally, change the package names. > >>> > >>> If you want to avoid having to do all the branding changes and see the > >>> new project join/rejoin the ASF, then I think that you'll need to come > >>> back to us with more collaborators and probably some indication that > >>> they are bought into keeping the project going over the foreseeable > >>> future. > >>> > >>> Regards, > >>> PJ > >>> > >>> > >>> On Sat, 18 Mar 2023 at 06:32, Laurent Schoelens > >>> wrote: > Hi everyone, > > I’m working on Apache Tiles porting to Jakarta EE (without support of > >>> freemarker and velocity, since both of them are still going with > >>> javax API) > >>> and my work is going to reach it’s end – all builds are successful, > >>> jdk17 > >>> baseline and updated dependencies (as far as I know) – but still > >>> uncommited > >>> to my personal github account. > I know Tiles is in Attic land of Apache but I’d which to make this > first > >>> step (Jakarta migration) go to open-source world, without creating new > >>> projects out of the box. > Tiles is a framework I use on a project, with Spring and since > Spring 6 > >>> has migrated to Jakarta API, I’m stuck to Spring 5.X if I stay on this. > >>> Changing technology is an option for frontend application but not > >>> until a > >>> good rework that may take months (or years, depending on time we > >>> have to do > >>> that migration). > Having a Tiles Jakarta port would be great since the technology itself > >>> is working well on my project. > Do you know what can I do to make this properly, according to Apache > >>> work ? > Thanks in advance for your help. > > Regards. > L. SCHOELENS > >>> - > >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >>> For additional commands, e-mail: general-h...@incubator.apache.org > >>> > >>> > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: Apache tiles
Michael It's worth upgrading as there are many improvements and also a setting that will speed up Roller UI: struts.i18n.search.defaultbundles.first=true As roller mainly uses ApplicationResources.properties for its i18n properties, the flag makes Struts check this file first, and then if it does not find the property do its extensive package search. It brings back Struts1 performance (if you can remember that far back!). The default is to do its extensive package search first (why it is slow). On 21/03/2023 07:19, Michael Bien wrote: roller would need some updates before it can go beyond struts 2.5.29: https://github.com/apache/roller/pull/119#issuecomment-1344814362 probably easy to do but I never got to it. (bump the version and you should see failing integration tests) the bootstrap dependency is also locked to 3.4.x AFAIR due to breaking changes which may or may not prevent other updates in future. other then that I tried to keep the dependencies somewhat up2date, i think jakarta.persistence is already in use via eclipse link etc. best regards, michael On 21.03.23 07:58, Greg Huber wrote: Dave, BTW, Struts devs are planning to merge the tiles code base into the Struts Tiles Plugin to eliminate the dependency on the now Attic project. https://github.com/apache/struts/tree/WW-5233-tiles/plugins/tiles On 20/03/2023 21:38, Dave wrote: Hi Laurent and PJ, The Apache Roller project still uses Struts, Tiles and Velocity and I would like to see the projects continue and move into Jakarta land. I have some limited time to help out. What do y'all need help with? Dave On Sun, Mar 19, 2023 at 8:01 AM PJ Fanning wrote: Hi Laurent, I don't want to write off the possibility of a Jakarta variant of Tiles joining the Apache Incubator - but the fact that Apache Tiles doesn't have an active community around it is going to be a major impediment. For Apache projects and podlings to succeed, they need a number of contributors to get involved. Could you start by putting your code up on Github or somewhere similar and adding documentation that highlights that you are looking for collaborators? Maybe there are some forums where some remaining users of Tiles can be contacted? There is no impediment to you simply releasing your Jakarta variant of Tiles yourself or via some organisation that you are involved with (e.g. a company that you work with). If you go this route, the ASF would look like to see that you remove all the ASF branding and ideally, change the package names. If you want to avoid having to do all the branding changes and see the new project join/rejoin the ASF, then I think that you'll need to come back to us with more collaborators and probably some indication that they are bought into keeping the project going over the foreseeable future. Regards, PJ On Sat, 18 Mar 2023 at 06:32, Laurent Schoelens wrote: Hi everyone, I’m working on Apache Tiles porting to Jakarta EE (without support of freemarker and velocity, since both of them are still going with javax API) and my work is going to reach it’s end – all builds are successful, jdk17 baseline and updated dependencies (as far as I know) – but still uncommited to my personal github account. I know Tiles is in Attic land of Apache but I’d which to make this first step (Jakarta migration) go to open-source world, without creating new projects out of the box. Tiles is a framework I use on a project, with Spring and since Spring 6 has migrated to Jakarta API, I’m stuck to Spring 5.X if I stay on this. Changing technology is an option for frontend application but not until a good rework that may take months (or years, depending on time we have to do that migration). Having a Tiles Jakarta port would be great since the technology itself is working well on my project. Do you know what can I do to make this properly, according to Apache work ? Thanks in advance for your help. Regards. L. SCHOELENS - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: Apache tiles
roller would need some updates before it can go beyond struts 2.5.29: https://github.com/apache/roller/pull/119#issuecomment-1344814362 probably easy to do but I never got to it. (bump the version and you should see failing integration tests) the bootstrap dependency is also locked to 3.4.x AFAIR due to breaking changes which may or may not prevent other updates in future. other then that I tried to keep the dependencies somewhat up2date, i think jakarta.persistence is already in use via eclipse link etc. best regards, michael On 21.03.23 07:58, Greg Huber wrote: Dave, BTW, Struts devs are planning to merge the tiles code base into the Struts Tiles Plugin to eliminate the dependency on the now Attic project. https://github.com/apache/struts/tree/WW-5233-tiles/plugins/tiles On 20/03/2023 21:38, Dave wrote: Hi Laurent and PJ, The Apache Roller project still uses Struts, Tiles and Velocity and I would like to see the projects continue and move into Jakarta land. I have some limited time to help out. What do y'all need help with? Dave On Sun, Mar 19, 2023 at 8:01 AM PJ Fanning wrote: Hi Laurent, I don't want to write off the possibility of a Jakarta variant of Tiles joining the Apache Incubator - but the fact that Apache Tiles doesn't have an active community around it is going to be a major impediment. For Apache projects and podlings to succeed, they need a number of contributors to get involved. Could you start by putting your code up on Github or somewhere similar and adding documentation that highlights that you are looking for collaborators? Maybe there are some forums where some remaining users of Tiles can be contacted? There is no impediment to you simply releasing your Jakarta variant of Tiles yourself or via some organisation that you are involved with (e.g. a company that you work with). If you go this route, the ASF would look like to see that you remove all the ASF branding and ideally, change the package names. If you want to avoid having to do all the branding changes and see the new project join/rejoin the ASF, then I think that you'll need to come back to us with more collaborators and probably some indication that they are bought into keeping the project going over the foreseeable future. Regards, PJ On Sat, 18 Mar 2023 at 06:32, Laurent Schoelens wrote: Hi everyone, I’m working on Apache Tiles porting to Jakarta EE (without support of freemarker and velocity, since both of them are still going with javax API) and my work is going to reach it’s end – all builds are successful, jdk17 baseline and updated dependencies (as far as I know) – but still uncommited to my personal github account. I know Tiles is in Attic land of Apache but I’d which to make this first step (Jakarta migration) go to open-source world, without creating new projects out of the box. Tiles is a framework I use on a project, with Spring and since Spring 6 has migrated to Jakarta API, I’m stuck to Spring 5.X if I stay on this. Changing technology is an option for frontend application but not until a good rework that may take months (or years, depending on time we have to do that migration). Having a Tiles Jakarta port would be great since the technology itself is working well on my project. Do you know what can I do to make this properly, according to Apache work ? Thanks in advance for your help. Regards. L. SCHOELENS - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: Apache tiles
Dave, BTW, Struts devs are planning to merge the tiles code base into the Struts Tiles Plugin to eliminate the dependency on the now Attic project. https://github.com/apache/struts/tree/WW-5233-tiles/plugins/tiles On 20/03/2023 21:38, Dave wrote: Hi Laurent and PJ, The Apache Roller project still uses Struts, Tiles and Velocity and I would like to see the projects continue and move into Jakarta land. I have some limited time to help out. What do y'all need help with? Dave On Sun, Mar 19, 2023 at 8:01 AM PJ Fanning wrote: Hi Laurent, I don't want to write off the possibility of a Jakarta variant of Tiles joining the Apache Incubator - but the fact that Apache Tiles doesn't have an active community around it is going to be a major impediment. For Apache projects and podlings to succeed, they need a number of contributors to get involved. Could you start by putting your code up on Github or somewhere similar and adding documentation that highlights that you are looking for collaborators? Maybe there are some forums where some remaining users of Tiles can be contacted? There is no impediment to you simply releasing your Jakarta variant of Tiles yourself or via some organisation that you are involved with (e.g. a company that you work with). If you go this route, the ASF would look like to see that you remove all the ASF branding and ideally, change the package names. If you want to avoid having to do all the branding changes and see the new project join/rejoin the ASF, then I think that you'll need to come back to us with more collaborators and probably some indication that they are bought into keeping the project going over the foreseeable future. Regards, PJ On Sat, 18 Mar 2023 at 06:32, Laurent Schoelens wrote: Hi everyone, I’m working on Apache Tiles porting to Jakarta EE (without support of freemarker and velocity, since both of them are still going with javax API) and my work is going to reach it’s end – all builds are successful, jdk17 baseline and updated dependencies (as far as I know) – but still uncommited to my personal github account. I know Tiles is in Attic land of Apache but I’d which to make this first step (Jakarta migration) go to open-source world, without creating new projects out of the box. Tiles is a framework I use on a project, with Spring and since Spring 6 has migrated to Jakarta API, I’m stuck to Spring 5.X if I stay on this. Changing technology is an option for frontend application but not until a good rework that may take months (or years, depending on time we have to do that migration). Having a Tiles Jakarta port would be great since the technology itself is working well on my project. Do you know what can I do to make this properly, according to Apache work ? Thanks in advance for your help. Regards. L. SCHOELENS - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
