Re: Release rc1 as Roller v6.1.2
Perfect! I will include that in future release emails. Gotta love Micro$oft Github. On Thu, Jul 20, 2023 at 5:52 PM Michael Bien wrote: > we could use the github release feature, which essentially creates a PR > list between two tags and can be generated with a few clicks. > > Roller 6.1.1 tag is missing at the moment, this draft creates a list > down to 6.1.0 as demonstration: > > https://github.com/apache/roller/releases/tag/untagged-180d51f564bac392e75d > > -mbien > > On 20.07.23 23:24, Dave wrote: > > Thanks for the review, Greg. I’ll look into those issues and put > together a > > change log. > > > > Dave > > > > > > On Thu, Jul 20, 2023 at 3:57 AM Greg Huber wrote: > > > >> Is there a change log so I can test specific changes? > >> > >> From a new install everything worked well. > >> > >> Observations: > >> > >> > >> > >> From the docs is there a reason for the incorrect quote ` rather than > ' > >> as I have to change it to grant all. > >> > >> mysql> create database rollerdb DEFAULT CHARACTER SET utf8 DEFAULT > >> COLLATE utf8_general_ci; > >> mysql> grant all on rollerdb.* to scott@`%' identified by `tiger'; > >> mysql> grant all on rollerdb.* to scott@localhost identified by > `tiger'; > >> > >> > >> > >> Create weblog, possibly unnecessary log message when handle is invalid? > >> > >> http://www/roller/roller-ui/createWeblog!save.rol > >> > >>* The handle you specified is not valid > >>* Unexpected error validating weblog -- check Roller logs > >> > >> URL: http://www.devbox/roller/test-another > >> > >> org.apache.roller.weblogger.WebloggerException: Invalid handle: > >> 'test-another' > >> > >> at > >> > org.apache.roller.weblogger.business.jpa.JPAWeblogManagerImpl.getWeblogByHandle(JPAWeblogManagerImpl.java:370) > >> > >> ~[classes/:?] > >> > >> at > >> > org.apache.roller.weblogger.business.jpa.JPAWeblogManagerImpl.getWeblogByHandle(JPAWeblogManagerImpl.java:358) > >> > >> ~[classes/:?] > >> > >> at > >> > org.apache.roller.weblogger.ui.struts2.core.CreateWeblog.myValidate(CreateWeblog.java:183) > >> > >> ~[classes/:?] > >> > >> On 20/07/2023 00:45, Dave wrote: > >>> This release of Roller includes dependency updates, minor fixes and > some > >>> input validation fixes. > >>> > >>> You can find the convenience binaries and the source code of the > release > >>> here:https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/ > >>> > >>> Please take it for a spin and vote: > >>> +1 to release > >>> -1 not to release (with reasons) > >>> > >>> Thanks, > >>> Dave > >>> > >
Re: Release rc1 as Roller v6.1.2
we could use the github release feature, which essentially creates a PR list between two tags and can be generated with a few clicks. Roller 6.1.1 tag is missing at the moment, this draft creates a list down to 6.1.0 as demonstration: https://github.com/apache/roller/releases/tag/untagged-180d51f564bac392e75d -mbien On 20.07.23 23:24, Dave wrote: Thanks for the review, Greg. I’ll look into those issues and put together a change log. Dave On Thu, Jul 20, 2023 at 3:57 AM Greg Huber wrote: Is there a change log so I can test specific changes? From a new install everything worked well. Observations: From the docs is there a reason for the incorrect quote ` rather than ' as I have to change it to grant all. mysql> create database rollerdb DEFAULT CHARACTER SET utf8 DEFAULT COLLATE utf8_general_ci; mysql> grant all on rollerdb.* to scott@`%' identified by `tiger'; mysql> grant all on rollerdb.* to scott@localhost identified by `tiger'; Create weblog, possibly unnecessary log message when handle is invalid? http://www/roller/roller-ui/createWeblog!save.rol * The handle you specified is not valid * Unexpected error validating weblog -- check Roller logs URL: http://www.devbox/roller/test-another org.apache.roller.weblogger.WebloggerException: Invalid handle: 'test-another' at org.apache.roller.weblogger.business.jpa.JPAWeblogManagerImpl.getWeblogByHandle(JPAWeblogManagerImpl.java:370) ~[classes/:?] at org.apache.roller.weblogger.business.jpa.JPAWeblogManagerImpl.getWeblogByHandle(JPAWeblogManagerImpl.java:358) ~[classes/:?] at org.apache.roller.weblogger.ui.struts2.core.CreateWeblog.myValidate(CreateWeblog.java:183) ~[classes/:?] On 20/07/2023 00:45, Dave wrote: This release of Roller includes dependency updates, minor fixes and some input validation fixes. You can find the convenience binaries and the source code of the release here:https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/ Please take it for a spin and vote: +1 to release -1 not to release (with reasons) Thanks, Dave
Re: [VOTE] Release rc1 as Roller v6.1.2
Thanks for the review, Greg. I’ll look into those issues and put together a change log. Dave On Thu, Jul 20, 2023 at 3:57 AM Greg Huber wrote: > Is there a change log so I can test specific changes? > > From a new install everything worked well. > > Observations: > > > > From the docs is there a reason for the incorrect quote ` rather than ' > as I have to change it to grant all. > > mysql> create database rollerdb DEFAULT CHARACTER SET utf8 DEFAULT > COLLATE utf8_general_ci; > mysql> grant all on rollerdb.* to scott@`%' identified by `tiger'; > mysql> grant all on rollerdb.* to scott@localhost identified by `tiger'; > > > > Create weblog, possibly unnecessary log message when handle is invalid? > > http://www/roller/roller-ui/createWeblog!save.rol > > * The handle you specified is not valid > * Unexpected error validating weblog -- check Roller logs > > URL: http://www.devbox/roller/test-another > > org.apache.roller.weblogger.WebloggerException: Invalid handle: > 'test-another' > > at > org.apache.roller.weblogger.business.jpa.JPAWeblogManagerImpl.getWeblogByHandle(JPAWeblogManagerImpl.java:370) > > ~[classes/:?] > > at > org.apache.roller.weblogger.business.jpa.JPAWeblogManagerImpl.getWeblogByHandle(JPAWeblogManagerImpl.java:358) > > ~[classes/:?] > > at > org.apache.roller.weblogger.ui.struts2.core.CreateWeblog.myValidate(CreateWeblog.java:183) > > ~[classes/:?] > > On 20/07/2023 00:45, Dave wrote: > > This release of Roller includes dependency updates, minor fixes and some > > input validation fixes. > > > > You can find the convenience binaries and the source code of the release > > here:https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/ > > > > Please take it for a spin and vote: > > +1 to release > > -1 not to release (with reasons) > > > > Thanks, > > Dave > >
Re: Roller v6.1.2 rc1
Good catch. I’ll fix that in a new RC. Thanks, Dave On Thu, Jul 20, 2023 at 2:01 PM Michael Bien wrote: > Hi Dave, > > /WEB-INF/lib/ contains now Jetty 9.4 which pulled due to the new > org.apache.solr:solr-solrj dependency. > > I don't think the apache solr client is used anywhere, I removed the > dependency and build/junit/integration works with 9 MB less libs deployed. > > Would it be better to remove it again until it is actually used? > > best regards, > > michael > >
Roller v6.1.2 rc1
Hi Dave, /WEB-INF/lib/ contains now Jetty 9.4 which pulled due to the new org.apache.solr:solr-solrj dependency. I don't think the apache solr client is used anywhere, I removed the dependency and build/junit/integration works with 9 MB less libs deployed. Would it be better to remove it again until it is actually used? best regards, michael
Re: [VOTE] Release rc1 as Roller v6.1.2
Is there a change log so I can test specific changes? From a new install everything worked well. Observations: From the docs is there a reason for the incorrect quote ` rather than ' as I have to change it to grant all. mysql> create database rollerdb DEFAULT CHARACTER SET utf8 DEFAULT COLLATE utf8_general_ci; mysql> grant all on rollerdb.* to scott@`%' identified by `tiger'; mysql> grant all on rollerdb.* to scott@localhost identified by `tiger'; Create weblog, possibly unnecessary log message when handle is invalid? http://www/roller/roller-ui/createWeblog!save.rol * The handle you specified is not valid * Unexpected error validating weblog -- check Roller logs URL: http://www.devbox/roller/test-another org.apache.roller.weblogger.WebloggerException: Invalid handle: 'test-another' at org.apache.roller.weblogger.business.jpa.JPAWeblogManagerImpl.getWeblogByHandle(JPAWeblogManagerImpl.java:370) ~[classes/:?] at org.apache.roller.weblogger.business.jpa.JPAWeblogManagerImpl.getWeblogByHandle(JPAWeblogManagerImpl.java:358) ~[classes/:?] at org.apache.roller.weblogger.ui.struts2.core.CreateWeblog.myValidate(CreateWeblog.java:183) ~[classes/:?] On 20/07/2023 00:45, Dave wrote: This release of Roller includes dependency updates, minor fixes and some input validation fixes. You can find the convenience binaries and the source code of the release here:https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/ Please take it for a spin and vote: +1 to release -1 not to release (with reasons) Thanks, Dave
