Re: MediaFileView.jsp
On 09.08.21 09:51, Greg Huber wrote:
Spotted this one when deleting a folder:
MediaFileView.jsp
function onDeleteFolder() {
if (confirm("/>")) {
document.bookmarks.action = 'action="mediaFileView!deleteFolder" />';
document.bookmarks.submit();
}
}
guess it should be: document.mediaFileViewForm.action and
document.mediaFileViewForm.submit();
looks like a copy and paste bug on first glance. However deleting
folders actually works, right? I ran a quick test and the folder is gone.
Also where is the bookmarks page link now? editor-menu.xml, for
weblogPerms="admin"
subactions="bookmarkAdd,bookmarkEdit,folderAdd,folderEdit,bookmarksImport"
/>
Its called Blogroll in the menu
(/roller-ui/authoring/bookmarks.rol?weblog=blog)
the admin user might not have this menu unless the admin has a blog too.
best regards,
michael
Re: MediaFileView.jsp
> looks like a copy and paste bug on first glance. However deleting
folders actually works, right? I ran a quick test and the folder is gone.
Yes it works, but I get this error in the console (forgot to add this to
the first email) after delete:
Uncaught TypeError: document.bookmarks is undefined
onDeleteFolder
http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:956
onclick
http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:1
##
>Its called Blogroll...
OK name change.
Cheers Greg
On 09/08/2021 17:46, Michael Bien wrote:
On 09.08.21 09:51, Greg Huber wrote:
Spotted this one when deleting a folder:
MediaFileView.jsp
function onDeleteFolder() {
if (confirm("/>")) {
document.bookmarks.action = 'action="mediaFileView!deleteFolder" />';
document.bookmarks.submit();
}
}
guess it should be: document.mediaFileViewForm.action and
document.mediaFileViewForm.submit();
looks like a copy and paste bug on first glance. However deleting
folders actually works, right? I ran a quick test and the folder is gone.
Also where is the bookmarks page link now? editor-menu.xml, for
weblogPerms="admin"
subactions="bookmarkAdd,bookmarkEdit,folderAdd,folderEdit,bookmarksImport"
/>
Its called Blogroll in the menu
(/roller-ui/authoring/bookmarks.rol?weblog=blog)
the admin user might not have this menu unless the admin has a blog too.
best regards,
michael
Re: MediaFileView.jsp
...Sorry, sent too soon,
Below comes from the
http://127.0.0.1:8080/roller/roller-ui/authoring/bookmarks.rol?weblog=testuser
menu.
08:06:25.493 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (org.apache.roller.weblogger.ui.struts2.editor.Bookmarks)
could not locate the message resource with key 'default'
08:06:25.493 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (org.apache.roller.weblogger.ui.struts2.editor.Bookmarks)
could not locate the message resource with key 'default'
08:06:25.494 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The default value
expression 'default' was evaluated and did not match a property. The
literal value 'default' will be used.
08:06:25.494 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The default value
expression 'default' was evaluated and did not match a property. The
literal value 'default' will be used.
Cheers Greg
On 09/08/2021 17:46, Michael Bien wrote:
On 09.08.21 09:51, Greg Huber wrote:
Spotted this one when deleting a folder:
MediaFileView.jsp
function onDeleteFolder() {
if (confirm("/>")) {
document.bookmarks.action = 'action="mediaFileView!deleteFolder" />';
document.bookmarks.submit();
}
}
guess it should be: document.mediaFileViewForm.action and
document.mediaFileViewForm.submit();
looks like a copy and paste bug on first glance. However deleting
folders actually works, right? I ran a quick test and the folder is gone.
Also where is the bookmarks page link now? editor-menu.xml, for
weblogPerms="admin"
subactions="bookmarkAdd,bookmarkEdit,folderAdd,folderEdit,bookmarksImport"
/>
Its called Blogroll in the menu
(/roller-ui/authoring/bookmarks.rol?weblog=blog)
the admin user might not have this menu unless the admin has a blog too.
best regards,
michael
Re: MediaFileView.jsp
On 10.08.21 09:05, Greg Huber wrote: > looks like a copy and paste bug on first glance. However deleting folders actually works, right? I ran a quick test and the folder is gone. Yes it works, but I get this error in the console (forgot to add this to the first email) after delete: Uncaught TypeError: document.bookmarks is undefined onDeleteFolder http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:956 onclick http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:1 oh, *that* console :) It looks like it is failing in a good way since it is actually unable to delete bookmarks with that context. fix -> https://github.com/apache/roller/pull/101 I don't feel its a show stopper for the update release. regards, michael
[GitHub] [roller] mbien merged pull request #101: MediaFileView.jsp delete folder JS error fix
mbien merged pull request #101: URL: https://github.com/apache/roller/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: svn commit: r1642435 - /roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/MediaFileView.jsp
I could never figure out how to get those settings right. :) BTW, haven't forgotten the 5.1.1 bug to get mvn jetty:run working again (I updated to the latest Jetty without testing it first), still on my list. Glen On 11/29/2014 10:16 AM, snoopd...@apache.org wrote: Author: snoopdave Date: Sat Nov 29 15:16:20 2014 New Revision: 1642435 URL: http://svn.apache.org/r1642435 Log: Restoring media title truncation at 47 characters to avoid having picture title overflow into adjacent cells of the media grid. Looks good on Firefox, Chome and Safari. Modified: roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/MediaFileView.jsp Modified: roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/MediaFileView.jsp URL: http://svn.apache.org/viewvc/roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/MediaFileView.jsp?rev=1642435&r1=1642434&r2=1642435&view=diff == --- roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/MediaFileView.jsp (original) +++ roller/trunk/app/src/main/webapp/WEB-INF/jsps/editor/MediaFileView.jsp Sat Nov 29 15:16:20 2014 @@ -305,7 +305,7 @@ - +
[GitHub] [roller] mbien opened a new pull request #101: MediaFileView.jsp delete folder JS error fix
mbien opened a new pull request #101: URL: https://github.com/apache/roller/pull/101 As noticed by Greg Huber on the mailing list, deleting a folder in the media file view results in a JS error. (although the folder is still deleted) this fixes it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
