Re: Release rc2 as Roller v6.1.2

2023-07-29 Thread Greg Huber
OK on the TODO.  (Seen this...possibly weblog timestamp not being updated?)

+1 (b)

On Sat, 29 Jul 2023 at 22:19, Dave  wrote:

> Yeah, it's a cache issue. I did some experimentation and I found this:
>
> - Create an entry
> - See it on blog page
> - Change entry to a draft
> - It still appears on blog page
> - Switch to a different web browser (but do not login to Roller) and see
> that entry does not appear on blog page
> - Login with different web browser and see that entry does appear on blog
> page
>
> Seems like a cache invalidation problem for logged in users, but I do not
> see the problem in the code. I'm glad the draft entry gets removed from the
> search index tho, and thanks for testing search functionality Greg
> because it did change recently.
>
> I'm +1 on this release despite this glitch.
>
> Dave
>
>
>
> On Sat, Jul 29, 2023 at 4:33 PM Michael Bien  wrote:
>
> > Hi Greg,
> >
> > I could reproduce it, this seems to be a cache invalidation issue.
> >
> > the entry will disappear if you clear the cache via the Maintenance UI.
> > Roller has also various cache settings which can be set in roller
> > properties, e.g age based eviction which would further mitigate this.
> >
> > This is probably a bug but not a show stopper IMHO - updating entries
> > works fine for example,
> >
> > best regards,
> > michael
> >
> >
> > On 24.07.23 10:55, Greg Huber wrote:
> > > If I have a published entry, and then change the status to draft it
> > > does not update the front page/weblog and the entry still shows.
> > >
> > > If I publish another entry, the draft entry now does not so.
> > >
> > > Also how do I get it to show other weblog entries on the front page
> now?
> > >
> > > On 23/07/2023 21:10, Dave wrote:
> > >> This release of Roller includes dependency updates, minor fixes and
> some
> > >> input validation fixes. This new RC removes an unnecessary Solr
> > >> dependency,
> > >> makes some small docs fixes and removes an unnecessary error message.
> > >> Thanks for the reviews!
> > >>
> > >> You can find the convenience binaries and the source code of the
> release
> > >> here:
> https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/
> > >>
> > >> Please take it for a spin and vote:
> > >> +1 to release
> > >> -1 not to release (with reasons)
> > >>
> > >> Thanks,
> > >> Dave
> > >>
> >
> >
>


Re: Release rc2 as Roller v6.1.2

2023-07-29 Thread Dave
Yeah, it's a cache issue. I did some experimentation and I found this:

- Create an entry
- See it on blog page
- Change entry to a draft
- It still appears on blog page
- Switch to a different web browser (but do not login to Roller) and see
that entry does not appear on blog page
- Login with different web browser and see that entry does appear on blog
page

Seems like a cache invalidation problem for logged in users, but I do not
see the problem in the code. I'm glad the draft entry gets removed from the
search index tho, and thanks for testing search functionality Greg
because it did change recently.

I'm +1 on this release despite this glitch.

Dave



On Sat, Jul 29, 2023 at 4:33 PM Michael Bien  wrote:

> Hi Greg,
>
> I could reproduce it, this seems to be a cache invalidation issue.
>
> the entry will disappear if you clear the cache via the Maintenance UI.
> Roller has also various cache settings which can be set in roller
> properties, e.g age based eviction which would further mitigate this.
>
> This is probably a bug but not a show stopper IMHO - updating entries
> works fine for example,
>
> best regards,
> michael
>
>
> On 24.07.23 10:55, Greg Huber wrote:
> > If I have a published entry, and then change the status to draft it
> > does not update the front page/weblog and the entry still shows.
> >
> > If I publish another entry, the draft entry now does not so.
> >
> > Also how do I get it to show other weblog entries on the front page now?
> >
> > On 23/07/2023 21:10, Dave wrote:
> >> This release of Roller includes dependency updates, minor fixes and some
> >> input validation fixes. This new RC removes an unnecessary Solr
> >> dependency,
> >> makes some small docs fixes and removes an unnecessary error message.
> >> Thanks for the reviews!
> >>
> >> You can find the convenience binaries and the source code of the release
> >> here: https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/
> >>
> >> Please take it for a spin and vote:
> >> +1 to release
> >> -1 not to release (with reasons)
> >>
> >> Thanks,
> >> Dave
> >>
>
>


Re: [VOTE] Release rc2 as Roller v6.1.2

2023-07-29 Thread Michael Bien

+1 (binding)

super sorry for the delay Dave.

 * tested a fresh blog setup using JDK 17, tomcat 9 + postgresql in 
containers and everything worked fine (except the cache issue Greg 
mentioned)

 * tested blog upgrade using JDK 20, jetty + hsqldb
 * sha256 sigs look good
 * lib folder looks good

thanks a lot for preparing a release!

best regards,
michael

On 23.07.23 22:10, Dave wrote:

This release of Roller includes dependency updates, minor fixes and some
input validation fixes. This new RC removes an unnecessary Solr dependency,
makes some small docs fixes and removes an unnecessary error message.
Thanks for the reviews!

You can find the convenience binaries and the source code of the release
here: https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/

Please take it for a spin and vote:
+1 to release
-1 not to release (with reasons)

Thanks,
Dave





Release rc2 as Roller v6.1.2

2023-07-29 Thread Michael Bien

Hi Greg,

I could reproduce it, this seems to be a cache invalidation issue.

the entry will disappear if you clear the cache via the Maintenance UI. 
Roller has also various cache settings which can be set in roller 
properties, e.g age based eviction which would further mitigate this.


This is probably a bug but not a show stopper IMHO - updating entries 
works fine for example,


best regards,
michael


On 24.07.23 10:55, Greg Huber wrote:
If I have a published entry, and then change the status to draft it 
does not update the front page/weblog and the entry still shows.


If I publish another entry, the draft entry now does not so.

Also how do I get it to show other weblog entries on the front page now?

On 23/07/2023 21:10, Dave wrote:

This release of Roller includes dependency updates, minor fixes and some
input validation fixes. This new RC removes an unnecessary Solr 
dependency,

makes some small docs fixes and removes an unnecessary error message.
Thanks for the reviews!

You can find the convenience binaries and the source code of the release
here: https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/

Please take it for a spin and vote:
+1 to release
-1 not to release (with reasons)

Thanks,
Dave





Re: [VOTE] Release rc2 as Roller v6.1.2

2023-07-27 Thread Dave
Thanks for testing the search changes. I’m not able to reproduce yet, but I
suspect there is a problem.

Dave


On Tue, Jul 25, 2023 at 3:13 AM Greg Huber  wrote:

> I was testing the search index changes.
>
> Add and entry, go to the Site page "All" category and do a test search.
> Then click the "edit" link on the entry, then click draft.  Go back to
> the Site page "All" category the entry shows, but the search does not
> find it any more.
>
> On 23/07/2023 21:10, Dave wrote:
> > This release of Roller includes dependency updates, minor fixes and some
> > input validation fixes. This new RC removes an unnecessary Solr
> dependency,
> > makes some small docs fixes and removes an unnecessary error message.
> > Thanks for the reviews!
> >
> > You can find the convenience binaries and the source code of the release
> > here: https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/
> >
> > Please take it for a spin and vote:
> > +1 to release
> > -1 not to release (with reasons)
> >
> > Thanks,
> > Dave
> >
>


Re: [VOTE] Release rc2 as Roller v6.1.2

2023-07-25 Thread Greg Huber

I was testing the search index changes.

Add and entry, go to the Site page "All" category and do a test search.  
Then click the "edit" link on the entry, then click draft.  Go back to 
the Site page "All" category the entry shows, but the search does not 
find it any more.


On 23/07/2023 21:10, Dave wrote:

This release of Roller includes dependency updates, minor fixes and some
input validation fixes. This new RC removes an unnecessary Solr dependency,
makes some small docs fixes and removes an unnecessary error message.
Thanks for the reviews!

You can find the convenience binaries and the source code of the release
here: https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/

Please take it for a spin and vote:
+1 to release
-1 not to release (with reasons)

Thanks,
Dave



Re: [VOTE] Release rc2 as Roller v6.1.2

2023-07-24 Thread Dave
Hi Greg,

I'm not able to reproduce the problem of publishing an entry and then
changing it to a draft. When I change my published entry to a draft and
then refresh the front-page, the entry is no longer shown. Maybe I'm going
something different from the way you are doing it. Do you have steps to
reproduce?

Dave

On Mon, Jul 24, 2023 at 4:55 AM Greg Huber  wrote:

> If I have a published entry, and then change the status to draft it does
> not update the front page/weblog and the entry still shows.
>
> If I publish another entry, the draft entry now does not so.
>
> Also how do I get it to show other weblog entries on the front page now?
>
> On 23/07/2023 21:10, Dave wrote:
> > This release of Roller includes dependency updates, minor fixes and some
> > input validation fixes. This new RC removes an unnecessary Solr
> dependency,
> > makes some small docs fixes and removes an unnecessary error message.
> > Thanks for the reviews!
> >
> > You can find the convenience binaries and the source code of the release
> > here: https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/
> >
> > Please take it for a spin and vote:
> > +1 to release
> > -1 not to release (with reasons)
> >
> > Thanks,
> > Dave
> >
>


Re: [VOTE] Release rc2 as Roller v6.1.2

2023-07-24 Thread Greg Huber
If I have a published entry, and then change the status to draft it does 
not update the front page/weblog and the entry still shows.


If I publish another entry, the draft entry now does not so.

Also how do I get it to show other weblog entries on the front page now?

On 23/07/2023 21:10, Dave wrote:

This release of Roller includes dependency updates, minor fixes and some
input validation fixes. This new RC removes an unnecessary Solr dependency,
makes some small docs fixes and removes an unnecessary error message.
Thanks for the reviews!

You can find the convenience binaries and the source code of the release
here: https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/

Please take it for a spin and vote:
+1 to release
-1 not to release (with reasons)

Thanks,
Dave



[VOTE] Release rc2 as Roller v6.1.2

2023-07-23 Thread Dave
This release of Roller includes dependency updates, minor fixes and some
input validation fixes. This new RC removes an unnecessary Solr dependency,
makes some small docs fixes and removes an unnecessary error message.
Thanks for the reviews!

You can find the convenience binaries and the source code of the release
here: https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.2/

Please take it for a spin and vote:
+1 to release
-1 not to release (with reasons)

Thanks,
Dave